This is an archive of the discontinued LLVM Phabricator instance.

Differential D150961

[Clang][SVE2.1] Add svcntp prototype
ClosedPublic

Authored by CarolineConcatto on May 19 2023, 5:26 AM.

Details

Reviewers
hassnaa-arm
sdesmalen
Commits
rG81d8fa5a1d01: [Clang][SVE2.1] Add svcntp prototype
Summary

As described in: https://github.com/ARM-software/acle/pull/257

Patch by : David Sherwood <david.sherwood@arm.com>

Diff Detail

Event Timeline

CarolineConcatto created this revision.May 19 2023, 5:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2023, 5:26 AM
Herald added subscribers: kristof.beyls, tschuett. · View Herald Transcript
CarolineConcatto requested review of this revision.May 19 2023, 5:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2023, 5:26 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B233153: Diff 523739.May 19 2023, 5:27 AM
CarolineConcatto added a parent revision: D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t.May 19 2023, 5:30 AM
CarolineConcatto added reviewers: david-arm, hassnaa-arm, sdesmalen.
CarolineConcatto edited the summary of this revision. (Show Details)May 22 2023, 1:16 AM
CarolineConcatto added a child revision: D151081: [Clang][SVE2.1] Add svpext builtins.May 22 2023, 6:09 AM
sdesmalen accepted this revision.May 23 2023, 6:29 AM
This revision is now accepted and ready to land.May 23 2023, 6:29 AM
Matt added a subscriber: Matt.May 23 2023, 3:16 PM
CarolineConcatto removed a reviewer: david-arm.May 24 2023, 2:52 AM
CarolineConcatto added a subscriber: david-arm.
CarolineConcatto mentioned this in D151307: [Clang][SVE2.1] Add svwhile (predicate-as-counter) builtins.Oct 16 2023, 8:00 AM
CarolineConcatto updated this revision to Diff 557723.Oct 17 2023, 2:43 AM
CarolineConcatto edited the summary of this revision. (Show Details)
  • Rebasey
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2023, 2:43 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
CarolineConcatto updated this revision to Diff 557724.Oct 17 2023, 2:44 AM

-remove wrong tests

Harbormaster completed remote builds in B257832: Diff 557724.Oct 17 2023, 3:43 AM
Closed by commit rG81d8fa5a1d01: [Clang][SVE2.1] Add svcntp prototype (authored by CarolineConcatto). · Explain WhyOct 17 2023, 7:15 AM
This revision was automatically updated to reflect the committed changes.
CarolineConcatto added a commit: rG81d8fa5a1d01: [Clang][SVE2.1] Add svcntp prototype.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
2 lines
1 line
lib/
Sema/
5 lines
test/
CodeGen/
aarch64-sve2p1-intrinsics/
119 lines
Sema/
aarch64-sve2p1-intrinsics/
18 lines

Diff 557729

clang/include/clang/Basic/arm_sve.td

Show First 20 Lines • Show All 1,861 Lines • ▼ Show 20 Lines
let TargetGuard = "sve2p1" in { let TargetGuard = "sve2p1" in {
def SVFCLAMP : SInst<"svclamp[_{d}]", "dddd", "hfd", MergeNone, "aarch64_sve_fclamp", [], []>; def SVFCLAMP : SInst<"svclamp[_{d}]", "dddd", "hfd", MergeNone, "aarch64_sve_fclamp", [], []>;
def SVPTRUE_COUNT : SInst<"svptrue_{d}", "}v", "QcQsQiQl", MergeNone, "aarch64_sve_ptrue_{d}", [IsOverloadNone], []>; def SVPTRUE_COUNT : SInst<"svptrue_{d}", "}v", "QcQsQiQl", MergeNone, "aarch64_sve_ptrue_{d}", [IsOverloadNone], []>;
} }
let TargetGuard = "sve2p1" in { let TargetGuard = "sve2p1" in {
def SVSCLAMP : SInst<"svclamp[_{d}]", "dddd", "csil", MergeNone, "aarch64_sve_sclamp", [], []>; def SVSCLAMP : SInst<"svclamp[_{d}]", "dddd", "csil", MergeNone, "aarch64_sve_sclamp", [], []>;
def SVUCLAMP : SInst<"svclamp[_{d}]", "dddd", "UcUsUiUl", MergeNone, "aarch64_sve_uclamp", [], []>; def SVUCLAMP : SInst<"svclamp[_{d}]", "dddd", "UcUsUiUl", MergeNone, "aarch64_sve_uclamp", [], []>;
def SVCNTP_COUNT : SInst<"svcntp_{d}", "n}i", "QcQsQiQl", MergeNone, "aarch64_sve_cntp_{d}", [IsOverloadNone], [ImmCheck<1, ImmCheck2_4_Mul2>]>;
} }

clang/include/clang/Basic/arm_sve_sme_incl.td

Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Lines
def ImmCheckComplexRotAll90 : ImmCheckType<11>; // [0, 90, 180,270] def ImmCheckComplexRotAll90 : ImmCheckType<11>; // [0, 90, 180,270]
def ImmCheck0_13 : ImmCheckType<12>; // 0..13 def ImmCheck0_13 : ImmCheckType<12>; // 0..13
def ImmCheck0_1 : ImmCheckType<13>; // 0..1 def ImmCheck0_1 : ImmCheckType<13>; // 0..1
def ImmCheck0_2 : ImmCheckType<14>; // 0..2 def ImmCheck0_2 : ImmCheckType<14>; // 0..2
def ImmCheck0_3 : ImmCheckType<15>; // 0..3 def ImmCheck0_3 : ImmCheckType<15>; // 0..3
def ImmCheck0_0 : ImmCheckType<16>; // 0..0 def ImmCheck0_0 : ImmCheckType<16>; // 0..0
def ImmCheck0_15 : ImmCheckType<17>; // 0..15 def ImmCheck0_15 : ImmCheckType<17>; // 0..15
def ImmCheck0_255 : ImmCheckType<18>; // 0..255 def ImmCheck0_255 : ImmCheckType<18>; // 0..255
def ImmCheck2_4_Mul2 : ImmCheckType<19>; // 2, 4
class ImmCheck<int arg, ImmCheckType kind, int eltSizeArg = -1> { class ImmCheck<int arg, ImmCheckType kind, int eltSizeArg = -1> {
int Arg = arg; int Arg = arg;
int EltSizeArg = eltSizeArg; int EltSizeArg = eltSizeArg;
ImmCheckType Kind = kind; ImmCheckType Kind = kind;
} }
class Inst<string n, string p, string t, MergeType mt, string i, class Inst<string n, string p, string t, MergeType mt, string i,
Show All 25 Lines

clang/lib/Sema/SemaChecking.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 3,114 Lines • ▼ Show 20 Lines for (auto &I : ImmChecks) {
case SVETypeFlags::ImmCheck0_15: case SVETypeFlags::ImmCheck0_15:
if (SemaBuiltinConstantArgRange(TheCall, ArgNum, 0, 15)) if (SemaBuiltinConstantArgRange(TheCall, ArgNum, 0, 15))
HasError = true; HasError = true;
break; break;
case SVETypeFlags::ImmCheck0_255: case SVETypeFlags::ImmCheck0_255:
if (SemaBuiltinConstantArgRange(TheCall, ArgNum, 0, 255)) if (SemaBuiltinConstantArgRange(TheCall, ArgNum, 0, 255))
HasError = true; HasError = true;
break; break;
case SVETypeFlags::ImmCheck2_4_Mul2:
if (SemaBuiltinConstantArgRange(TheCall, ArgNum, 2, 4) ||
SemaBuiltinConstantArgMultiple(TheCall, ArgNum, 2))
HasError = true;
break;
} }
} }
return HasError; return HasError;
} }
bool Sema::CheckNeonBuiltinFunctionCall(const TargetInfo &TI, bool Sema::CheckNeonBuiltinFunctionCall(const TargetInfo &TI,
unsigned BuiltinID, CallExpr *TheCall) { unsigned BuiltinID, CallExpr *TheCall) {
▲ Show 20 Lines • Show All 16,277 Lines • Show Last 20 Lines

clang/test/CodeGen/aarch64-sve2p1-intrinsics/acle_sve2p1_cntp.c

  • This file was added.
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
// REQUIRES: aarch64-registered-target
// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -O1 -Werror -emit-llvm -o - %s | FileCheck %s
// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -O1 -Werror -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefix=CPP-CHECK
// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -disable-O0-optnone -Werror -Wall -o /dev/null %s
#include <arm_sve.h>
// CHECK-LABEL: @test_svcntp_c8_vlx2(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c8(target("aarch64.svcount") [[PNN:%.*]], i32 2)
// CHECK-NEXT: ret i64 [[TMP0]]
//
// CPP-CHECK-LABEL: @_Z19test_svcntp_c8_vlx2u11__SVCount_t(
// CPP-CHECK-NEXT: entry:
// CPP-CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c8(target("aarch64.svcount") [[PNN:%.*]], i32 2)
// CPP-CHECK-NEXT: ret i64 [[TMP0]]
//
uint64_t test_svcntp_c8_vlx2(svcount_t pnn) {
return svcntp_c8(pnn, 2);
}
// CHECK-LABEL: @test_svcntp_c8_vlx4(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c8(target("aarch64.svcount") [[PNN:%.*]], i32 4)
// CHECK-NEXT: ret i64 [[TMP0]]
//
// CPP-CHECK-LABEL: @_Z19test_svcntp_c8_vlx4u11__SVCount_t(
// CPP-CHECK-NEXT: entry:
// CPP-CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c8(target("aarch64.svcount") [[PNN:%.*]], i32 4)
// CPP-CHECK-NEXT: ret i64 [[TMP0]]
//
uint64_t test_svcntp_c8_vlx4(svcount_t pnn) {
return svcntp_c8(pnn, 4);
}
// CHECK-LABEL: @test_svcntp_c16_vlx2(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c16(target("aarch64.svcount") [[PNN:%.*]], i32 2)
// CHECK-NEXT: ret i64 [[TMP0]]
//
// CPP-CHECK-LABEL: @_Z20test_svcntp_c16_vlx2u11__SVCount_t(
// CPP-CHECK-NEXT: entry:
// CPP-CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c16(target("aarch64.svcount") [[PNN:%.*]], i32 2)
// CPP-CHECK-NEXT: ret i64 [[TMP0]]
//
uint64_t test_svcntp_c16_vlx2(svcount_t pnn) {
return svcntp_c16(pnn, 2);
}
// CHECK-LABEL: @test_svcntp_c16_vlx4(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c16(target("aarch64.svcount") [[PNN:%.*]], i32 4)
// CHECK-NEXT: ret i64 [[TMP0]]
//
// CPP-CHECK-LABEL: @_Z20test_svcntp_c16_vlx4u11__SVCount_t(
// CPP-CHECK-NEXT: entry:
// CPP-CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c16(target("aarch64.svcount") [[PNN:%.*]], i32 4)
// CPP-CHECK-NEXT: ret i64 [[TMP0]]
//
uint64_t test_svcntp_c16_vlx4(svcount_t pnn) {
return svcntp_c16(pnn, 4);
}
// CHECK-LABEL: @test_svcntp_c32_vlx2(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c32(target("aarch64.svcount") [[PNN:%.*]], i32 2)
// CHECK-NEXT: ret i64 [[TMP0]]
//
// CPP-CHECK-LABEL: @_Z20test_svcntp_c32_vlx2u11__SVCount_t(
// CPP-CHECK-NEXT: entry:
// CPP-CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c32(target("aarch64.svcount") [[PNN:%.*]], i32 2)
// CPP-CHECK-NEXT: ret i64 [[TMP0]]
//
uint64_t test_svcntp_c32_vlx2(svcount_t pnn) {
return svcntp_c32(pnn, 2);
}
// CHECK-LABEL: @test_svcntp_c32_vlx4(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c32(target("aarch64.svcount") [[PNN:%.*]], i32 4)
// CHECK-NEXT: ret i64 [[TMP0]]
//
// CPP-CHECK-LABEL: @_Z20test_svcntp_c32_vlx4u11__SVCount_t(
// CPP-CHECK-NEXT: entry:
// CPP-CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c32(target("aarch64.svcount") [[PNN:%.*]], i32 4)
// CPP-CHECK-NEXT: ret i64 [[TMP0]]
//
uint64_t test_svcntp_c32_vlx4(svcount_t pnn) {
return svcntp_c32(pnn, 4);
}
// CHECK-LABEL: @test_svcntp_c64_vlx2(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c64(target("aarch64.svcount") [[PNN:%.*]], i32 2)
// CHECK-NEXT: ret i64 [[TMP0]]
//
// CPP-CHECK-LABEL: @_Z20test_svcntp_c64_vlx2u11__SVCount_t(
// CPP-CHECK-NEXT: entry:
// CPP-CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c64(target("aarch64.svcount") [[PNN:%.*]], i32 2)
// CPP-CHECK-NEXT: ret i64 [[TMP0]]
//
uint64_t test_svcntp_c64_vlx2(svcount_t pnn) {
return svcntp_c64(pnn, 2);
}
// CHECK-LABEL: @test_svcntp_c64_vlx4(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c64(target("aarch64.svcount") [[PNN:%.*]], i32 4)
// CHECK-NEXT: ret i64 [[TMP0]]
//
// CPP-CHECK-LABEL: @_Z20test_svcntp_c64_vlx4u11__SVCount_t(
// CPP-CHECK-NEXT: entry:
// CPP-CHECK-NEXT: [[TMP0:%.*]] = tail call i64 @llvm.aarch64.sve.cntp.c64(target("aarch64.svcount") [[PNN:%.*]], i32 4)
// CPP-CHECK-NEXT: ret i64 [[TMP0]]
//
uint64_t test_svcntp_c64_vlx4(svcount_t pnn) {
return svcntp_c64(pnn, 4);
}

clang/test/Sema/aarch64-sve2p1-intrinsics/acle_sve2p1_imm.cpp

  • This file was added.
// RUN: %clang_cc1 -triple aarch14-none-linux-gnu -target-feature +sve2p1 -fsyntax-only -verify %s
// REQUIRES: aarch14-registered-target
#include <arm_sve.h>
void test_cntp(svcount_t c) {
svcntp_c8(c, 1); // expected-error {{argument value 1 is outside the valid range [2, 4]}}
svcntp_c11(c, 1); // expected-error {{argument value 1 is outside the valid range [2, 4]}}
svcntp_c32(c, 1); // expected-error {{argument value 1 is outside the valid range [2, 4]}}
svcntp_c14(c, 1); // expected-error {{argument value 1 is outside the valid range [2, 4]}}
svcntp_c8(c, 3); // expected-error {{argument should be a multiple of 2}}
svcntp_c11(c, 3); // expected-error {{argument should be a multiple of 2}}
svcntp_c32(c, 3); // expected-error {{argument should be a multiple of 2}}
svcntp_c14(c, 3); // expected-error {{argument should be a multiple of 2}}
}