Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D151461

[Clang][SVE2.1] Add builtins and intrinsics for SVBFMLSLB/T
AcceptedPublic
Actions

Authored by CarolineConcatto on May 25 2023, 8:53 AM.

Details

Reviewers
david-arm
hassnaa-arm
Summary

As described in: https://github.com/ARM-software/acle/pull/257

Patch by: Kerry McLaughlin <kerry.mclaughlin@arm.com>

Diff Detail

Event Timeline

CarolineConcatto created this revision.May 25 2023, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 8:53 AM
Herald added subscribers: hiraditya, kristof.beyls, tschuett. · View Herald Transcript
CarolineConcatto requested review of this revision.May 25 2023, 8:53 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 25 2023, 8:53 AM
Herald added subscribers: llvm-commits, cfe-commits. · View Herald Transcript
CarolineConcatto added reviewers: david-arm, hassnaa-arm.May 25 2023, 8:53 AM
CarolineConcatto added a subscriber: kmclaughlin.
Harbormaster completed remote builds in B234541: Diff 525649.May 25 2023, 8:53 AM
CarolineConcatto added a parent revision: D151439: [Clang][SVE2.1] Add builtins for 2-way svdot (vectors, indexed).May 25 2023, 8:54 AM
CarolineConcatto added a child revision: D151709: [Clang][SVE2.1] Add builtins for svrevd.May 30 2023, 6:44 AM
david-arm accepted this revision.Jun 5 2023, 6:10 AM

LGTM! I left a nit, which you could just address before landing the patch?

clang/test/CodeGen/aarch64-sve2p1-intrinsics/acle_sve2p1_bfmlsl.c
48

nit: Just a minor issue, but perhaps worth calling this test_bfmlslb_lane to be consistent with the builtin?

This revision is now accepted and ready to land.Jun 5 2023, 6:10 AM

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
Basic/
7 lines
test/
CodeGen/
aarch64-sve2p1-intrinsics/
85 lines
utils/
TableGen/
7 lines
llvm/
include/
llvm/
IR/
16 lines
lib/
Target/
AArch64/
8 lines
test/
CodeGen/
AArch64/
43 lines

Diff 525649

View Options

clang/include/clang/Basic/arm_sve.td

Loading...
View Options

clang/test/CodeGen/aarch64-sve2p1-intrinsics/acle_sve2p1_bfmlsl.c

Loading...
View Options

clang/utils/TableGen/SveEmitter.cpp

Loading...
View Options

llvm/include/llvm/IR/IntrinsicsAArch64.td

Loading...
View Options

llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td

Loading...
View Options

llvm/test/CodeGen/AArch64/sve2p1-intrinsics-bfmls.ll

Loading...