Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

hassnaa-arm (hassnaaHamdi)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2022, 2:49 AM (68 w, 2 d)

Recent Activity

Aug 17 2023

hassnaa-arm added inline comments to D152550: [Constant Hoisting]: Hoist Constant GEP Expressions..
Aug 17 2023, 10:18 AM · Restricted Project, Restricted Project

Aug 16 2023

hassnaa-arm updated the diff for D152550: [Constant Hoisting]: Hoist Constant GEP Expressions..
  • Avoid hoisting in following cases:
    • The cost of the const expr is 'free' for the target.
    • The expr can be folded into a legal addressing mode for the target.
    • The expr has only single use, and it's not inside a loop.
  • Now there are no regressions.
Aug 16 2023, 10:28 AM · Restricted Project, Restricted Project

Aug 2 2023

hassnaa-arm added inline comments to D155299: [AArch64][SVE2] Combine add+lsr to rshrnb for stores.
Aug 2 2023, 2:31 AM · Restricted Project, Restricted Project

Aug 1 2023

hassnaa-arm added inline comments to D155299: [AArch64][SVE2] Combine add+lsr to rshrnb for stores.
Aug 1 2023, 5:03 AM · Restricted Project, Restricted Project

Jul 20 2023

hassnaa-arm accepted D155432: [AArch64][SME] Use `fmov` instead of NEON `movi` for FP value..

LGTM. Thanks for the clarification.

Jul 20 2023, 2:33 AM · Restricted Project, Restricted Project

Jul 18 2023

hassnaa-arm added inline comments to D155432: [AArch64][SME] Use `fmov` instead of NEON `movi` for FP value..
Jul 18 2023, 7:02 AM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D155432: [AArch64][SME] Use `fmov` instead of NEON `movi` for FP value..
Jul 18 2023, 5:50 AM · Restricted Project, Restricted Project

Jun 9 2023

hassnaa-arm added reviewers for D152550: [Constant Hoisting]: Hoist Constant GEP Expressions.: zzheng, sdesmalen, david-arm, efriedma, wmi.
Jun 9 2023, 9:24 AM · Restricted Project, Restricted Project
hassnaa-arm requested review of D152550: [Constant Hoisting]: Hoist Constant GEP Expressions..
Jun 9 2023, 9:20 AM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D151197: [Clang][SVE2p1] Add svpsel builtins.
Jun 9 2023, 5:30 AM · Restricted Project, Restricted Project

Jun 8 2023

hassnaa-arm added inline comments to D151197: [Clang][SVE2p1] Add svpsel builtins.
Jun 8 2023, 10:18 AM · Restricted Project, Restricted Project

May 31 2023

hassnaa-arm added inline comments to D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t.
May 31 2023, 5:31 AM · Restricted Project, Restricted Project
hassnaa-arm accepted D151081: [Clang][SVE2.1] Add svpext builtins.
May 31 2023, 2:38 AM · Restricted Project, Restricted Project

May 30 2023

hassnaa-arm added inline comments to D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t.
May 30 2023, 9:01 AM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t.
May 30 2023, 8:53 AM · Restricted Project, Restricted Project

May 10 2023

hassnaa-arm accepted D150265: [AArch64][SME2/SVE2p1] Add predicate-as-counter intrinsics for while*.
May 10 2023, 7:57 AM · Restricted Project, Restricted Project

Apr 24 2023

hassnaa-arm updated the diff for D148118: [AArch64][DAGCombiner]: combine <2xi64> mul add/sub..

Add extra test cases that have 'extract_subvector' in both operands.

Apr 24 2023, 4:34 AM · Restricted Project, Restricted Project

Apr 20 2023

hassnaa-arm updated the diff for D148118: [AArch64][DAGCombiner]: combine <2xi64> mul add/sub..

Fix warning.

Apr 20 2023, 10:26 PM · Restricted Project, Restricted Project

Apr 19 2023

hassnaa-arm updated the diff for D148118: [AArch64][DAGCombiner]: combine <2xi64> mul add/sub..

Enhance code readability.

Apr 19 2023, 11:57 PM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

Updating by main branch.

Apr 19 2023, 3:24 AM · Restricted Project, Restricted Project
hassnaa-arm reopened D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

This patch indirectly causes the vectoriser to choose a lower VF due to the high cost of extending nxv16i8 -> nxv16i16, and that caused a regression.
Dave was investigating that issue and he has created a patch for fixing it.
So, right now this patch should work well.
I will rebase it and run checks to make sure everything is okay.

Apr 19 2023, 2:05 AM · Restricted Project, Restricted Project

Apr 18 2023

hassnaa-arm added a comment to D148118: [AArch64][DAGCombiner]: combine <2xi64> mul add/sub..

Hi @paulwalker-arm Are you okay with landing this patch ?

Apr 18 2023, 5:57 AM · Restricted Project, Restricted Project

Apr 12 2023

hassnaa-arm requested review of D148118: [AArch64][DAGCombiner]: combine <2xi64> mul add/sub..
Apr 12 2023, 4:57 AM · Restricted Project, Restricted Project

Apr 4 2023

hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Fix format.

Apr 4 2023, 7:38 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Check that extract node and mul node has one use.
That change triggered new changes in testing file of sve-fixed-length-int-rem.ll

Apr 4 2023, 7:34 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Add check for fixed-length vectors.

Apr 4 2023, 4:19 AM · Restricted Project, Restricted Project

Apr 3 2023

hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Add a check to make sure that the mul has single use.

Apr 3 2023, 9:08 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Remove line added by mistake.

Apr 3 2023, 7:52 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Enhance code readability.

Apr 3 2023, 7:51 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Remove line added by mistake.

Apr 3 2023, 6:29 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Add additional checks to make sure of the expected pattern.

Apr 3 2023, 6:22 AM · Restricted Project, Restricted Project

Mar 31 2023

hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Fix Typo.

Mar 31 2023, 2:39 AM · Restricted Project, Restricted Project

Mar 30 2023

hassnaa-arm added a reviewer for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add.: CarolineConcatto.
Mar 30 2023, 9:06 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..

Improve code readability, Add comments.

Mar 30 2023, 8:54 AM · Restricted Project, Restricted Project
hassnaa-arm added a reviewer for D147236: [AArch64][Combine]: combine <2xi64> Mul-Add.: sdesmalen.
Mar 30 2023, 7:52 AM · Restricted Project, Restricted Project
hassnaa-arm requested review of D147236: [AArch64][Combine]: combine <2xi64> Mul-Add..
Mar 30 2023, 7:51 AM · Restricted Project, Restricted Project

Mar 9 2023

hassnaa-arm added a comment to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

@dmgreen Thanks for reviewing the patch. Do you have any further comments ?

Mar 9 2023, 4:54 AM · Restricted Project, Restricted Project

Mar 8 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Add test cases that use lshr.

Mar 8 2023, 1:39 PM · Restricted Project, Restricted Project

Mar 7 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Add comments explaining what LowerAvg() does.

Mar 7 2023, 4:42 AM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Mar 7 2023, 4:42 AM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Mar 7 2023, 2:17 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Add test cases for logical shr.

Mar 7 2023, 2:10 AM · Restricted Project, Restricted Project

Mar 3 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Enhance code readability.

Mar 3 2023, 3:33 AM · Restricted Project, Restricted Project

Mar 2 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

While checking isZeroExtending, only checking the signbit of known Zeros is enough.

Mar 2 2023, 7:01 AM · Restricted Project, Restricted Project

Mar 1 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Check if both operands of AVG are extended, not just single one.

Mar 1 2023, 12:21 PM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Mar 1 2023, 12:13 PM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Mar 1 2023, 7:42 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Use ComputeNumSignBits instead of ComputeKnownBits for SIGN_EXTEND_INREG ops.

Mar 1 2023, 7:35 AM · Restricted Project, Restricted Project

Feb 28 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Use computeKnownBits for checking zeroExtedn/signExtend.

Feb 28 2023, 9:18 AM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 28 2023, 4:53 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Remove sve-avgfloor testing file.
Add RUN line for sve to sve2-hadd
rename sve2-hadd to sve-hadd

Feb 28 2023, 4:50 AM · Restricted Project, Restricted Project

Feb 23 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Enhance code readability.

Feb 23 2023, 8:43 AM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 23 2023, 8:41 AM · Restricted Project, Restricted Project

Feb 22 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

In case of CEIL, Put ADD operation for constant 1.

Feb 22 2023, 10:05 AM · Restricted Project, Restricted Project

Feb 21 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Change lshr to ashr for signed cases in the precursory patch.

Feb 21 2023, 5:53 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Check if it's better to emit the original code or custom lower AVGFloor/Ceil

Feb 21 2023, 5:33 AM · Restricted Project, Restricted Project

Feb 20 2023

hassnaa-arm added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 20 2023, 5:11 AM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 20 2023, 4:37 AM · Restricted Project, Restricted Project
hassnaa-arm retitled D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil. from [AArch64][SVE]: custom lower AVGFloor/AVGCeil. [WIP] to [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 20 2023, 2:04 AM · Restricted Project, Restricted Project

Feb 16 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Optimize the generated code by checking if the extended nodes were previously truncated.

Feb 16 2023, 9:26 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Optimize the generated code by checking if the extended node was previously truncated.

Feb 16 2023, 9:02 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Add precursory patch.

Feb 16 2023, 1:56 AM · Restricted Project, Restricted Project

Feb 10 2023

hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Remove old code that is not used now.

Feb 10 2023, 5:58 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D141595: [AArch64][SME]: Add missing Ops that need custom-lowering in streaming mode..

Rerun testing files after updating the patch by main branch.

Feb 10 2023, 4:32 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D141595: [AArch64][SME]: Add missing Ops that need custom-lowering in streaming mode..

Update by main branch.

Feb 10 2023, 4:15 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Remove neon-lshr.ll

Feb 10 2023, 4:03 AM · Restricted Project, Restricted Project
hassnaa-arm retitled D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil. from [AArch64][combine]: combine lshr pattern. [WIP] to [AArch64][SVE]: custom lower AVGFloor/AVGCeil. [WIP].
Feb 10 2023, 4:02 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Add AArch64 implementation for custom-lowering AVGFloor/AVGCeil

Feb 10 2023, 4:01 AM · Restricted Project, Restricted Project

Feb 9 2023

hassnaa-arm retitled D143433: [AArch64][SME]: Custom-lower SIGN_EXTEND_INREG for streaming SVE from [AArch64][SME]: Custom-lower SIGN_EXTEND_INREG to [AArch64][SME]: Custom-lower SIGN_EXTEND_INREG for streaming SVE.
Feb 9 2023, 2:45 AM · Restricted Project, Restricted Project
hassnaa-arm retitled D143434: [AArch64][SME]: Custom lower select and fp_extend for streaming SVE from [AArch64][SME]: Custom lower select and fp_extend to [AArch64][SME]: Custom lower select and fp_extend for streaming SVE.
Feb 9 2023, 2:44 AM · Restricted Project, Restricted Project

Feb 8 2023

hassnaa-arm added a comment to D141595: [AArch64][SME]: Add missing Ops that need custom-lowering in streaming mode..

The affected testing files are related to custom-lowering ISD::VSELECT and ISD::BITREVERSE

Feb 8 2023, 2:59 AM · Restricted Project, Restricted Project

Feb 7 2023

hassnaa-arm added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 7 2023, 10:36 AM · Restricted Project, Restricted Project
hassnaa-arm retitled D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil. from [AArch64][combine]: transform lshr pattern. [WIP] to [AArch64][combine]: combine lshr pattern. [WIP].
Feb 7 2023, 10:28 AM · Restricted Project, Restricted Project
hassnaa-arm retitled D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil. from [Transform][InstCombine]: transform lshr pattern. [WIP] to [AArch64][combine]: transform lshr pattern. [WIP].
Feb 7 2023, 10:28 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Move combining trunc shift and extend shift to AArch64

Feb 7 2023, 10:27 AM · Restricted Project, Restricted Project

Feb 6 2023

hassnaa-arm requested review of D143434: [AArch64][SME]: Custom lower select and fp_extend for streaming SVE.
Feb 6 2023, 1:18 PM · Restricted Project, Restricted Project
hassnaa-arm added reviewers for D143433: [AArch64][SME]: Custom-lower SIGN_EXTEND_INREG for streaming SVE: david-arm, sdesmalen.
Feb 6 2023, 12:56 PM · Restricted Project, Restricted Project
hassnaa-arm requested review of D143433: [AArch64][SME]: Custom-lower SIGN_EXTEND_INREG for streaming SVE.
Feb 6 2023, 12:55 PM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D141595: [AArch64][SME]: Add missing Ops that need custom-lowering in streaming mode..

Split out custom-lower select/fp_extend and related testing files into a new patch

Feb 6 2023, 12:43 PM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D141595: [AArch64][SME]: Add missing Ops that need custom-lowering in streaming mode..

Split out custom-lowering sign-extend-inreg and related testing files to another patch

Feb 6 2023, 12:18 PM · Restricted Project, Restricted Project
hassnaa-arm abandoned D136858: [AArch64-SVE]: Force generating code compatible to streaming mode for sve-fixed-length tests..

This patch was split into smaller patches.

Feb 6 2023, 11:47 AM · Restricted Project, Restricted Project
hassnaa-arm retitled D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil. from [Transform][InstCombine]: transform lshr pattern. to [Transform][InstCombine]: transform lshr pattern. [WIP].
Feb 6 2023, 2:01 AM · Restricted Project, Restricted Project

Feb 3 2023

hassnaa-arm requested review of D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 3 2023, 9:57 AM · Restricted Project, Restricted Project

Feb 2 2023

hassnaa-arm added inline comments to D141595: [AArch64][SME]: Add missing Ops that need custom-lowering in streaming mode..
Feb 2 2023, 4:32 AM · Restricted Project, Restricted Project

Jan 31 2023

hassnaa-arm abandoned D141397: [AArch64][SVE]: Optimize using ptest with whilelo.
Jan 31 2023, 1:19 AM · Restricted Project, Restricted Project

Jan 26 2023

hassnaa-arm updated the summary of D142456: [AArch64][CostModel]: Add costs for zero/sign extend..
Jan 26 2023, 5:38 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

Recalculate the costs.

Jan 26 2023, 5:37 AM · Restricted Project, Restricted Project
hassnaa-arm added inline comments to D142456: [AArch64][CostModel]: Add costs for zero/sign extend..
Jan 26 2023, 5:09 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

Update the calculated costs.
Use a cost of 1 for each SVE instruction.

Jan 26 2023, 2:52 AM · Restricted Project, Restricted Project

Jan 25 2023

hassnaa-arm added a comment to D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

where each operation has a cost of 2

Why does each instruction have a cost of 2?

Because that is mentioned here: https://developer.arm.com/documentation/pjdoc466751330-9685/latest/
in section 3.25 (SVE integer instructions)

Hi @hassnaa-arm, the cost-model shouldn't be hardcoding the number of cycles for one specific micro-architecture, because the cost-model should be accurate for other micro-architectures as well.
The cost requested here is the througput cost, not the latency. The throughput is closer to the number of instructions that is required for the operation.

Jan 25 2023, 6:37 AM · Restricted Project, Restricted Project
hassnaa-arm added a comment to D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

where each operation has a cost of 2

Why does each instruction have a cost of 2?

Jan 25 2023, 3:53 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

Remove changes included by mistake.

Jan 25 2023, 2:15 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

Recalculate costs. In the code generation testing file, use real variable instead of undef to get accurate costs.

Jan 25 2023, 2:13 AM · Restricted Project, Restricted Project

Jan 24 2023

hassnaa-arm updated the diff for D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

Add more accurte costs.

Jan 24 2023, 9:50 AM · Restricted Project, Restricted Project
hassnaa-arm retitled D142456: [AArch64][CostModel]: Add costs for zero/sign extend. from [AArch64] cost mode. to [AArch64][CostModel]: Add costs for zero/sign extend..
Jan 24 2023, 8:22 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

fix comment typo

Jan 24 2023, 7:55 AM · Restricted Project, Restricted Project
hassnaa-arm added a reviewer for D142456: [AArch64][CostModel]: Add costs for zero/sign extend.: david-arm.
Jan 24 2023, 7:52 AM · Restricted Project, Restricted Project
hassnaa-arm updated the diff for D142456: [AArch64][CostModel]: Add costs for zero/sign extend..

Add testing file for the cost of zero/sign extend

Jan 24 2023, 7:13 AM · Restricted Project, Restricted Project
hassnaa-arm added a reviewer for D141595: [AArch64][SME]: Add missing Ops that need custom-lowering in streaming mode.: david-arm.
Jan 24 2023, 5:50 AM · Restricted Project, Restricted Project
hassnaa-arm requested review of D142456: [AArch64][CostModel]: Add costs for zero/sign extend..
Jan 24 2023, 5:06 AM · Restricted Project, Restricted Project