This is an archive of the discontinued LLVM Phabricator instance.

Adopt Properties to store operations inherent Attributes in the GPU dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:04 AM.

Details

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:04 AM
mehdi_amini requested review of this revision.Apr 21 2023, 12:04 AM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:11 PM
rriddle added inline comments.
mlir/include/mlir/Dialect/Func/IR/FuncOps.td
27 ↗(On Diff #516254)

This looks like it got included by accident

This revision is now accepted and ready to land.Apr 23 2023, 11:11 PM

Remove spurious diff

mehdi_amini marked an inline comment as done.Apr 25 2023, 12:23 AM
This revision was landed with ongoing or failed builds.May 9 2023, 7:00 AM
This revision was automatically updated to reflect the committed changes.