This is an archive of the discontinued LLVM Phabricator instance.

[clang][Sema][NFC] Sprinkle some const around in Sema
ClosedPublic

Authored by tbaeder on Apr 19 2023, 2:53 AM.

Details

Summary

NFC but uploading for review for the pre-commit CI and maybe some actual review.

Diff Detail

Event Timeline

tbaeder created this revision.Apr 19 2023, 2:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 2:53 AM
tbaeder requested review of this revision.Apr 19 2023, 2:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 2:53 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
tbaeder updated this revision to Diff 514878.Apr 19 2023, 3:00 AM
tbaeder updated this revision to Diff 514933.Apr 19 2023, 6:20 AM
aaron.ballman accepted this revision.Apr 19 2023, 12:26 PM

Changes generally LGTM though I spotted a few places where we might as well update to auto and one place where I think a const was missed.

clang/lib/Sema/SemaExpr.cpp
2122–2124
2222
3012
3037
clang/lib/Sema/SemaLookup.cpp
1337

Right?

This revision is now accepted and ready to land.Apr 19 2023, 12:26 PM
tbaeder marked 5 inline comments as done.Apr 20 2023, 12:31 AM
tbaeder added inline comments.
clang/lib/Sema/SemaLookup.cpp
1337

Unfortunately not, the naming class ends up in some ::Create call at some point, so can't be const.

This revision was landed with ongoing or failed builds.Apr 20 2023, 3:24 AM
This revision was automatically updated to reflect the committed changes.
tbaeder marked an inline comment as done.