Page MenuHomePhabricator

tbaeder (Timm Bäder)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2020, 4:41 AM (116 w, 4 d)

Recent Activity

Wed, May 25

tbaeder updated the diff for D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.

@MaskRay Ignored the new test on Windows hosts now like you suggested. Does this look good?

Wed, May 25, 3:20 AM · Restricted Project, Restricted Project

Tue, May 24

tbaeder added a comment to D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.

Harbormaster completed remote builds in B165047: Diff 430277.

You can get Windows bot results in the link.

Tue, May 24, 1:59 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.
Tue, May 24, 1:16 AM · Restricted Project, Restricted Project

Mon, May 23

tbaeder added a reverting change for rG8717b492dfcd: [clang][driver] Dynamically select gcc-toolset/devtoolset version: rG0eccc92fa0fd: Revert "[clang][driver] Dynamically select gcc-toolset/devtoolset version".
Mon, May 23, 6:23 AM · Restricted Project, Restricted Project
tbaeder committed rG0eccc92fa0fd: Revert "[clang][driver] Dynamically select gcc-toolset/devtoolset version" (authored by tbaeder).
Revert "[clang][driver] Dynamically select gcc-toolset/devtoolset version"
Mon, May 23, 6:23 AM · Restricted Project, Restricted Project
tbaeder added a reverting change for D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes: rG0eccc92fa0fd: Revert "[clang][driver] Dynamically select gcc-toolset/devtoolset version".
Mon, May 23, 6:23 AM · Restricted Project, Restricted Project
tbaeder committed rG8717b492dfcd: [clang][driver] Dynamically select gcc-toolset/devtoolset version (authored by tbaeder).
[clang][driver] Dynamically select gcc-toolset/devtoolset version
Mon, May 23, 2:35 AM · Restricted Project, Restricted Project
tbaeder closed D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.
Mon, May 23, 2:35 AM · Restricted Project, Restricted Project

Thu, May 19

tbaeder updated the diff for D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.
Thu, May 19, 12:49 AM · Restricted Project, Restricted Project

Wed, May 18

tbaeder updated the diff for D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.
Wed, May 18, 11:01 PM · Restricted Project, Restricted Project
tbaeder requested review of D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.
Wed, May 18, 1:50 AM · Restricted Project, Restricted Project
tbaeder requested review of D125860: [clang] Only use major version in resource dir.
Wed, May 18, 1:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, May 17

tbaeder added a reviewer for D125620: [Clang] Fix diagnostics formatting: aaron.ballman.
Tue, May 17, 11:24 PM · Restricted Project, Restricted Project

Thu, May 12

tbaeder committed rGb91073db6ac3: [clang][preprocessor] Fix unsigned-ness of utf8 char literals (authored by tbaeder).
[clang][preprocessor] Fix unsigned-ness of utf8 char literals
Thu, May 12, 11:05 PM · Restricted Project, Restricted Project
tbaeder committed rG791e0d1bc85d: [compiler-rt] Add NO_EXEC_STACK_DIRECTIVE on s390x (authored by tbaeder).
[compiler-rt] Add NO_EXEC_STACK_DIRECTIVE on s390x
Thu, May 12, 11:05 PM · Restricted Project, Restricted Project
tbaeder closed D125454: [compiler-rt] Add missing NO_EXEC_STACK_DIRECTIVE to tsan_rtl_s390x.S.
Thu, May 12, 11:05 PM · Restricted Project, Restricted Project
tbaeder closed D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Thu, May 12, 11:05 PM · Restricted Project, Restricted Project
tbaeder added a comment to D125454: [compiler-rt] Add missing NO_EXEC_STACK_DIRECTIVE to tsan_rtl_s390x.S.

Sorry, I'm not familiar enough with compiler-rt tests. Is the failing Linux/decorate_proc_maps test my fault?

Thu, May 12, 6:10 AM · Restricted Project, Restricted Project
tbaeder requested review of D125454: [compiler-rt] Add missing NO_EXEC_STACK_DIRECTIVE to tsan_rtl_s390x.S.
Thu, May 12, 1:53 AM · Restricted Project, Restricted Project

Wed, May 11

tbaeder updated the diff for D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Wed, May 11, 11:48 PM · Restricted Project, Restricted Project

Tue, May 10

tbaeder added inline comments to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Tue, May 10, 11:52 PM · Restricted Project, Restricted Project
tbaeder updated the diff for D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Tue, May 10, 12:49 AM · Restricted Project, Restricted Project

Mon, May 9

tbaeder added inline comments to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Mon, May 9, 12:46 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Mon, May 9, 12:44 AM · Restricted Project, Restricted Project

Fri, May 6

tbaeder added inline comments to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Fri, May 6, 6:12 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Fri, May 6, 6:10 AM · Restricted Project, Restricted Project

Thu, May 5

tbaeder updated the diff for D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Thu, May 5, 5:47 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Thu, May 5, 5:13 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Thu, May 5, 4:12 AM · Restricted Project, Restricted Project
tbaeder requested review of D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
Thu, May 5, 3:13 AM · Restricted Project, Restricted Project

Apr 19 2022

tbaeder committed rG33ec65305525: [clang][lexer] Allow u8 character literal prefixes in C2x (authored by tbaeder).
[clang][lexer] Allow u8 character literal prefixes in C2x
Apr 19 2022, 1:00 AM · Restricted Project, Restricted Project
tbaeder closed D119221: [clang][lexer] Allow u8 character literal prefixes in C2x.
Apr 19 2022, 1:00 AM · Restricted Project, Restricted Project

Apr 12 2022

tbaeder updated the diff for D119221: [clang][lexer] Allow u8 character literal prefixes in C2x.
Apr 12 2022, 11:18 PM · Restricted Project, Restricted Project
tbaeder added inline comments to D119221: [clang][lexer] Allow u8 character literal prefixes in C2x.
Apr 12 2022, 11:17 PM · Restricted Project, Restricted Project
tbaeder committed rG0eb5891adcb8: [clang][preprocessor] Allow calling DumpToken() on annotation tokens (authored by tbaeder).
[clang][preprocessor] Allow calling DumpToken() on annotation tokens
Apr 12 2022, 10:06 PM · Restricted Project, Restricted Project
tbaeder closed D122659: [clang][preprocessor] Allow calling DumpToken() on annotation tokens.
Apr 12 2022, 10:06 PM · Restricted Project, Restricted Project

Apr 5 2022

tbaeder added a comment to D122885: [clang] Draft: Implement P1703R1.

What patches are you talking about exactly?

Apr 5 2022, 9:39 PM · Restricted Project, Restricted Project
tbaeder accepted D123120: [clang] Document p1703 not needed.

Other than the indentation LGTM, thanks.

Apr 5 2022, 5:42 AM · Restricted Project, Restricted Project

Apr 4 2022

tbaeder added a comment to D122885: [clang] Draft: Implement P1703R1.

Ah, I'd had a thinko about what 1703 was. that's superseded by <strike>p1757</strike>wg21.link/p1857. That's what is needed. (your patch makes more sense in the 1703 context)

Apr 4 2022, 6:43 AM · Restricted Project, Restricted Project

Apr 1 2022

tbaeder requested review of D122885: [clang] Draft: Implement P1703R1.
Apr 1 2022, 2:14 AM · Restricted Project, Restricted Project

Mar 31 2022

Herald added a project to D119221: [clang][lexer] Allow u8 character literal prefixes in C2x: Restricted Project.

Is there anything missing here?

Mar 31 2022, 11:09 PM · Restricted Project, Restricted Project

Mar 30 2022

tbaeder updated the diff for D122659: [clang][preprocessor] Allow calling DumpToken() on annotation tokens.
Mar 30 2022, 1:52 AM · Restricted Project, Restricted Project

Mar 29 2022

tbaeder requested review of D122659: [clang][preprocessor] Allow calling DumpToken() on annotation tokens.
Mar 29 2022, 8:23 AM · Restricted Project, Restricted Project

Mar 24 2022

tbaeder closed D119056: add sysroot/include/c++/version/${TARGET} to wasm32-wasi.
Mar 24 2022, 12:15 AM · Restricted Project
tbaeder committed rG711e3a569167: [clang][parse] Move source range into ParsedAttibutesView (authored by tbaeder).
[clang][parse] Move source range into ParsedAttibutesView
Mar 24 2022, 12:12 AM · Restricted Project
tbaeder closed D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 24 2022, 12:12 AM · Restricted Project, Restricted Project

Mar 22 2022

tbaeder updated the diff for D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 22 2022, 11:28 PM · Restricted Project, Restricted Project
tbaeder added inline comments to D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 22 2022, 8:44 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 22 2022, 8:11 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 22 2022, 3:42 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 22 2022, 3:41 AM · Restricted Project, Restricted Project

Mar 16 2022

tbaeder updated the diff for D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 16 2022, 3:14 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D121201: [clang] Merge the SourceRange into ParsedAttributes.

Remove ParsedAttributesViewWithRange and address other review comments.

Mar 16 2022, 1:39 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 16 2022, 1:37 AM · Restricted Project, Restricted Project

Mar 15 2022

tbaeder added inline comments to D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 15 2022, 11:51 PM · Restricted Project, Restricted Project

Mar 9 2022

tbaeder committed rGe5ccd6680198: [clang][sema] Enable first-class bool support for C2x (authored by tbaeder).
[clang][sema] Enable first-class bool support for C2x
Mar 9 2022, 6:05 AM · Restricted Project
tbaeder closed D120244: [clang][sema] Enable first-class bool support for C2x.
Mar 9 2022, 6:05 AM · Restricted Project, Restricted Project

Mar 8 2022

tbaeder requested review of D121275: [compiler-rt] Add LLVM cmake package in standalone builds.
Mar 8 2022, 10:55 PM · Restricted Project, Restricted Project
tbaeder added a comment to D118511: Add a warning for not packing non-POD members in packed structs.

Hey @dblaikie, seems like this has never been pushed?

Mar 8 2022, 9:49 PM · Restricted Project, Restricted Project
tbaeder updated the diff for D120244: [clang][sema] Enable first-class bool support for C2x.
Mar 8 2022, 9:43 PM · Restricted Project, Restricted Project
tbaeder added a comment to D120244: [clang][sema] Enable first-class bool support for C2x.

Precommit CI is failing:

Failed Tests (1):

Clang :: Headers/stdbool.c
Mar 8 2022, 9:42 PM · Restricted Project, Restricted Project
tbaeder committed rG5b7941ad7c89: [clang][driver] Fix float128 diagnostics with glibc >= 2.32 (authored by tbaeder).
[clang][driver] Fix float128 diagnostics with glibc >= 2.32
Mar 8 2022, 7:15 AM · Restricted Project
tbaeder closed D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32.
Mar 8 2022, 7:15 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D120244: [clang][sema] Enable first-class bool support for C2x.
Mar 8 2022, 6:07 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D120244: [clang][sema] Enable first-class bool support for C2x.
Mar 8 2022, 6:06 AM · Restricted Project, Restricted Project
tbaeder requested review of D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32.
Mar 8 2022, 5:25 AM · Restricted Project, Restricted Project
Herald added a project to D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain: Restricted Project.

I'm running into a problem with the testsuite that's caused by this patch. I think the comment from @jsji about newer glibc was never addressed.

Mar 8 2022, 5:04 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 8 2022, 2:33 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 8 2022, 2:32 AM · Restricted Project, Restricted Project
tbaeder requested review of D121201: [clang] Merge the SourceRange into ParsedAttributes.
Mar 8 2022, 2:31 AM · Restricted Project, Restricted Project

Mar 6 2022

tbaeder committed rG7b969b0bb53e: [clang][parser] Stop dragging an EndLoc around when parsing attributes (authored by tbaeder).
[clang][parser] Stop dragging an EndLoc around when parsing attributes
Mar 6 2022, 11:17 PM · Restricted Project
tbaeder closed D120888: [clang] Stop dragging a EndLoc around when parsing attributes.
Mar 6 2022, 11:17 PM · Restricted Project, Restricted Project
tbaeder added inline comments to D120244: [clang][sema] Enable first-class bool support for C2x.
Mar 6 2022, 12:43 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D120244: [clang][sema] Enable first-class bool support for C2x.

Thanks for the links to the papers. What's the best way of updating https://clang.llvm.org/c_status.html#c2x with the new papers?

Mar 6 2022, 12:38 AM · Restricted Project, Restricted Project

Mar 5 2022

tbaeder updated the diff for D120888: [clang] Stop dragging a EndLoc around when parsing attributes.
Mar 5 2022, 11:36 PM · Restricted Project, Restricted Project

Mar 4 2022

tbaeder updated the diff for D120888: [clang] Stop dragging a EndLoc around when parsing attributes.
Mar 4 2022, 6:34 AM · Restricted Project, Restricted Project
tbaeder added a comment to D120888: [clang] Stop dragging a EndLoc around when parsing attributes.

Thank you for working on this! We've (very) slowly been working towards all of the attribute parsing functions taking a ParsedAttributesWithRange so that we don't lose this information in the AST, and this is a good step in the right direction towards that.

Mar 4 2022, 6:15 AM · Restricted Project, Restricted Project

Mar 3 2022

tbaeder updated the diff for D120888: [clang] Stop dragging a EndLoc around when parsing attributes.
Mar 3 2022, 7:27 AM · Restricted Project, Restricted Project
tbaeder requested review of D120888: [clang] Stop dragging a EndLoc around when parsing attributes.
Mar 3 2022, 3:21 AM · Restricted Project, Restricted Project

Feb 28 2022

tbaeder committed rG12d3679256c9: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB (authored by tbaeder).
[clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB
Feb 28 2022, 5:56 AM
tbaeder closed D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB.
Feb 28 2022, 5:56 AM · Restricted Project

Feb 27 2022

tbaeder added a comment to D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB.

The failing tests seem all omp related and not about this change.

Feb 27 2022, 11:39 PM · Restricted Project
tbaeder requested review of D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB.
Feb 27 2022, 10:49 PM · Restricted Project

Feb 23 2022

tbaeder added a comment to D119056: add sysroot/include/c++/version/${TARGET} to wasm32-wasi.

This was fixed via https://reviews.llvm.org/D120251

Feb 23 2022, 5:45 AM · Restricted Project
tbaeder committed rG2f300d34decb: [clang][driver][wasm] Fix libstdc++ target-dependent include dir (authored by tbaeder).
[clang][driver][wasm] Fix libstdc++ target-dependent include dir
Feb 23 2022, 5:44 AM
tbaeder closed D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir.
Feb 23 2022, 5:43 AM · Restricted Project

Feb 22 2022

tbaeder updated the diff for D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir.
Feb 22 2022, 8:27 AM · Restricted Project
tbaeder committed rG535a23053bbb: Fix docs build after f8cedc642d9b85720cb7175ef25ddde90a3fbca2 (authored by tbaeder).
Fix docs build after f8cedc642d9b85720cb7175ef25ddde90a3fbca2
Feb 22 2022, 7:36 AM
tbaeder committed rGf8cedc642d9b: [clang] Never wrap a nullptr in CXXNewExpr::getArraySize() (authored by tbaeder).
[clang] Never wrap a nullptr in CXXNewExpr::getArraySize()
Feb 22 2022, 7:28 AM
tbaeder closed D119525: [clang] Fix crash when array size is missing in initializer.
Feb 22 2022, 7:28 AM · Restricted Project
tbaeder committed rG02571f86bb01: [clang][www] Port make_cxx_dr_status script to Python3 (authored by tbaeder).
[clang][www] Port make_cxx_dr_status script to Python3
Feb 22 2022, 6:48 AM
tbaeder closed D120313: [clang][www] Port make_cxx_dr_status script to Python3.
Feb 22 2022, 6:48 AM · Restricted Project
tbaeder requested review of D120313: [clang][www] Port make_cxx_dr_status script to Python3.
Feb 22 2022, 2:12 AM · Restricted Project
tbaeder added a comment to D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir.

@sbc100 Do you think we should add /backward as well? Gnu.cpp does that it seems: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Gnu.cpp#L2959-L2960

Feb 22 2022, 12:06 AM · Restricted Project

Feb 21 2022

tbaeder abandoned D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks.
Feb 21 2022, 10:57 PM · Restricted Project
tbaeder abandoned D84846: [MC] Add support for generating missing GNU build notes.
Feb 21 2022, 10:57 PM · Restricted Project, Restricted Project
tbaeder requested review of D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir.
Feb 21 2022, 7:04 AM · Restricted Project
tbaeder added inline comments to D120244: [clang][sema] Enable first-class bool support for C2x.
Feb 21 2022, 4:51 AM · Restricted Project, Restricted Project
tbaeder requested review of D120244: [clang][sema] Enable first-class bool support for C2x.
Feb 21 2022, 4:36 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D119221: [clang][lexer] Allow u8 character literal prefixes in C2x.
Feb 21 2022, 12:54 AM · Restricted Project, Restricted Project