Page MenuHomePhabricator

tbaeder (Timm Bäder)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2020, 4:41 AM (58 w, 2 d)

Recent Activity

Tue, Apr 6

tbaeder abandoned D90457: [clang][driver] Set LTO mode based on input files.
Tue, Apr 6, 3:24 AM · Restricted Project
tbaeder abandoned D95536: [clang][sema] Note decl location on missing member.

Abandoning this since it's probably not worth it.

Tue, Apr 6, 3:24 AM · Restricted Project
tbaeder requested review of D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes.
Tue, Apr 6, 3:20 AM · Restricted Project

Sat, Apr 3

tbaeder committed rG1b4800c26259: [clang][parser] Set source ranges for GNU-style attributes (authored by tbaeder).
[clang][parser] Set source ranges for GNU-style attributes
Sat, Apr 3, 11:00 PM

Fri, Apr 2

tbaeder added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

I compiled libc++ with a clang that has this patch applied and didn't run into more problems.

Fri, Apr 2, 11:02 PM · Restricted Project
tbaeder updated the diff for D75844: [clang] Set begin loc on GNU attribute parsed attrs.
Fri, Apr 2, 12:50 PM · Restricted Project
tbaeder updated the diff for D75844: [clang] Set begin loc on GNU attribute parsed attrs.

A little earlier than expected. Happy Easter :P

Fri, Apr 2, 7:38 AM · Restricted Project

Thu, Apr 1

tbaeder added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Yep. I'll try to come up with a test and a fix next week.

Thu, Apr 1, 8:41 AM · Restricted Project
tbaeder added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Damn. Reverted again for the time being. The libc++ build seems to fail and I won't have time to look into that this week. :(

Thu, Apr 1, 8:34 AM · Restricted Project
tbaeder added a reverting change for rG1ea9fa8c507e: [clang][parser] Set source ranges for GNU-style attributes: rG908a267b5a3b: Revert "[clang][parser] Set source ranges for GNU-style attributes".
Thu, Apr 1, 8:33 AM
tbaeder committed rG908a267b5a3b: Revert "[clang][parser] Set source ranges for GNU-style attributes" (authored by tbaeder).
Revert "[clang][parser] Set source ranges for GNU-style attributes"
Thu, Apr 1, 8:33 AM
tbaeder added a reverting change for D75844: [clang] Set begin loc on GNU attribute parsed attrs: rG908a267b5a3b: Revert "[clang][parser] Set source ranges for GNU-style attributes".
Thu, Apr 1, 8:33 AM · Restricted Project
tbaeder committed rG1ea9fa8c507e: [clang][parser] Set source ranges for GNU-style attributes (authored by tbaeder).
[clang][parser] Set source ranges for GNU-style attributes
Thu, Apr 1, 8:27 AM
tbaeder closed D75844: [clang] Set begin loc on GNU attribute parsed attrs.
Thu, Apr 1, 8:27 AM · Restricted Project
tbaeder updated the diff for D75844: [clang] Set begin loc on GNU attribute parsed attrs.
Thu, Apr 1, 6:18 AM · Restricted Project
tbaeder updated the diff for D75844: [clang] Set begin loc on GNU attribute parsed attrs.
Thu, Apr 1, 12:19 AM · Restricted Project
tbaeder updated the diff for D75844: [clang] Set begin loc on GNU attribute parsed attrs.

I know it's been a while, but here's an update on that patch.

Thu, Apr 1, 12:15 AM · Restricted Project

Wed, Mar 31

tbaeder committed rG5018e15fdfda: [clang][parser] Allow GNU-style attributes in explicit template... (authored by tbaeder).
[clang][parser] Allow GNU-style attributes in explicit template...
Wed, Mar 31, 7:46 AM
tbaeder closed D97362: [clang][parser] Allow attributes in explicit template instantiations.
Wed, Mar 31, 7:46 AM · Restricted Project
tbaeder added inline comments to D97362: [clang][parser] Allow attributes in explicit template instantiations.
Wed, Mar 31, 2:06 AM · Restricted Project

Tue, Mar 30

tbaeder abandoned D99338: [clang][parser] Allow GNU-style attributes in enum specifiers.

Abandoning in favor of https://reviews.llvm.org/D97362

Tue, Mar 30, 9:03 AM · Restricted Project
tbaeder abandoned D99278: [clang][parser] Allow GNU-style attributes in struct declarations.

Abandoning in favor of https://reviews.llvm.org/D97362

Tue, Mar 30, 9:02 AM · Restricted Project
tbaeder updated the diff for D97362: [clang][parser] Allow attributes in explicit template instantiations.

Added the changes from https://reviews.llvm.org/D99338 and https://reviews.llvm.org/D99278

Tue, Mar 30, 9:01 AM · Restricted Project

Mon, Mar 29

tbaeder added a comment to D99278: [clang][parser] Allow GNU-style attributes in struct declarations.

All the attribute patches are just preparations so I can finally enable the source locations in GNU attributes in https://reviews.llvm.org/D75844.

Mon, Mar 29, 11:16 PM · Restricted Project
tbaeder added a comment to D99278: [clang][parser] Allow GNU-style attributes in struct declarations.

This (and https://reviews.llvm.org/D99338) are both NFC changes once https://reviews.llvm.org/D97362 lands (they need the three-parameter version of ProhibitCXX11Attributes()). I can merge the three into one patch if you prefer.

Mon, Mar 29, 10:57 PM · Restricted Project

Fri, Mar 26

tbaeder updated the diff for D99338: [clang][parser] Allow GNU-style attributes in enum specifiers.
Fri, Mar 26, 2:06 AM · Restricted Project
tbaeder updated the diff for D97362: [clang][parser] Allow attributes in explicit template instantiations.
Fri, Mar 26, 2:04 AM · Restricted Project

Thu, Mar 25

tbaeder requested review of D99338: [clang][parser] Allow GNU-style attributes in enum specifiers.
Thu, Mar 25, 7:06 AM · Restricted Project
tbaeder updated the diff for D99278: [clang][parser] Allow GNU-style attributes in struct declarations.
Thu, Mar 25, 12:50 AM · Restricted Project

Wed, Mar 24

tbaeder requested review of D99278: [clang][parser] Allow GNU-style attributes in struct declarations.
Wed, Mar 24, 9:41 AM · Restricted Project
tbaeder updated the diff for D97362: [clang][parser] Allow attributes in explicit template instantiations.
Wed, Mar 24, 6:40 AM · Restricted Project
tbaeder updated the diff for D97362: [clang][parser] Allow attributes in explicit template instantiations.

Alright, thanks for the review.

Wed, Mar 24, 6:34 AM · Restricted Project
tbaeder updated the diff for D97362: [clang][parser] Allow attributes in explicit template instantiations.
Wed, Mar 24, 1:09 AM · Restricted Project
tbaeder added a comment to D97362: [clang][parser] Allow attributes in explicit template instantiations.

I'm gonna continue the conversation here if that's ok, the inline comments are rather cramped and confusing.

Wed, Mar 24, 1:00 AM · Restricted Project

Tue, Mar 23

tbaeder added a comment to D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.

Thanks everyone!

Tue, Mar 23, 7:27 AM · Restricted Project
tbaeder committed rGbc6b139392f6: [clang][parser] Don't prohibit attributes on objc @try/@throw (authored by tbaeder).
[clang][parser] Don't prohibit attributes on objc @try/@throw
Tue, Mar 23, 7:27 AM
tbaeder closed D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.
Tue, Mar 23, 7:27 AM · Restricted Project
tbaeder added a comment to D97362: [clang][parser] Allow attributes in explicit template instantiations.

Hey Aaron, do you have any more comments on this?

Tue, Mar 23, 12:34 AM · Restricted Project

Mon, Mar 22

tbaeder updated the diff for D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.
Mon, Mar 22, 11:29 PM · Restricted Project
tbaeder updated the diff for D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.
Mon, Mar 22, 7:42 AM · Restricted Project
tbaeder added a comment to D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.

Hmm, the new test seems to cause an assertion failure in llvm code generation in Windows. Is anything known about that? Is the test case wrong in some way?

Mon, Mar 22, 3:41 AM · Restricted Project
tbaeder updated the diff for D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.
Mon, Mar 22, 1:22 AM · Restricted Project

Fri, Mar 19

tbaeder updated the diff for D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.
Fri, Mar 19, 3:32 AM · Restricted Project

Thu, Mar 18

tbaeder added a comment to D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.

Thank you.

Thu, Mar 18, 1:46 AM · Restricted Project

Wed, Mar 17

tbaeder added a comment to D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.

John, do you have any more comments on this?

Wed, Mar 17, 9:08 AM · Restricted Project
tbaeder committed rGd9ef6bc42643: [clang] Disable LTO and LLD on SystemZ for stage3 builds (authored by tbaeder).
[clang] Disable LTO and LLD on SystemZ for stage3 builds
Wed, Mar 17, 7:17 AM
tbaeder closed D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD.
Wed, Mar 17, 7:16 AM · Restricted Project
tbaeder updated the diff for D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD.

Here's a version that shells out to uname -m to get the arch. Setting both the _LLD and _LTO variable that often looks a bit odd but I didn't want to use other variables. Can change that of course.

Wed, Mar 17, 5:42 AM · Restricted Project
tbaeder added a comment to D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD.

Including CMakeDetermineSystem gives me:

Wed, Mar 17, 5:39 AM · Restricted Project

Tue, Mar 16

tbaeder added a comment to D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD.

If we know SystemZ + LLD + LTO is a bad configuration, "fixing" the configuration and logging a message seems like the wrong move when the only way to get into that state is to specifically request options.

Tue, Mar 16, 8:42 AM · Restricted Project
tbaeder updated the diff for D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD.

Dropped the FORCE stuff since we can just set the variable directly and that shouldn't make a difference as far was I know. And the warning now only appears if either LTO or LLD are enabled.

Tue, Mar 16, 5:36 AM · Restricted Project

Mar 9 2021

tbaeder committed rG272bcd0eeff5: [clang][sema][NFC] Remove a superfluous semicolon (authored by tbaeder).
[clang][sema][NFC] Remove a superfluous semicolon
Mar 9 2021, 7:15 AM
tbaeder updated the diff for D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD.

Just re-tested this on a SystemZ machine and found that the set() in clang/CMakeLists.txt were not actually being applied. I also made it disable LLD on SystemZ as well, as you suggested. And I added a warning when BOOTSTRAP_LLVM_ENABLE_LLD is TRUE but lld is not in LLVM_ENABLE_PROJECTS

Mar 9 2021, 5:52 AM · Restricted Project

Mar 4 2021

tbaeder added inline comments to D97362: [clang][parser] Allow attributes in explicit template instantiations.
Mar 4 2021, 12:23 AM · Restricted Project

Mar 3 2021

tbaeder updated the diff for D97362: [clang][parser] Allow attributes in explicit template instantiations.

Thanks for the suggestions, Aaron. The new version seems to work but I was not sure how to get the token at a source location. I could only find Lexer::findNextToken().

Mar 3 2021, 1:52 AM · Restricted Project

Mar 2 2021

tbaeder added inline comments to D97362: [clang][parser] Allow attributes in explicit template instantiations.
Mar 2 2021, 7:30 AM · Restricted Project
tbaeder added a comment to D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.

They are being applied to the @try at least (-ast-print prints them) and we do some error checking for missing call expressions in handleNoMergeAttr() in SemaStmtAttr.cpp. I don't know much about Objective C so I am not sure how to check that the attribute really has any effect in the end.

Mar 2 2021, 1:11 AM · Restricted Project

Mar 1 2021

tbaeder added a comment to D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.

Well we test them on @try in tests/Parser/stmt-attributes.m, but they are not being diagnosed as invalid. Should I instead keep the ProhibitAttributes() call and change the test to make sure they are being diagnosed?

Mar 1 2021, 10:16 PM · Restricted Project

Feb 27 2021

tbaeder updated the diff for D97362: [clang][parser] Allow attributes in explicit template instantiations.

You are right of course. I changed the diff to allow GNU-style attributes and reject everything else.

Feb 27 2021, 1:11 AM · Restricted Project

Feb 25 2021

tbaeder added a comment to D97445: [clang][sema] Ignore xor-used-as-pow if both sides are macros.

Thanks everyone!

Feb 25 2021, 7:32 AM · Restricted Project
tbaeder committed rG2cc58463caf4: [clang][sema] Ignore xor-used-as-pow if both sides are macros (authored by tbaeder).
[clang][sema] Ignore xor-used-as-pow if both sides are macros
Feb 25 2021, 7:32 AM
tbaeder closed D97445: [clang][sema] Ignore xor-used-as-pow if both sides are macros.
Feb 25 2021, 7:31 AM · Restricted Project

Feb 24 2021

tbaeder requested review of D97445: [clang][sema] Ignore xor-used-as-pow if both sides are macros.
Feb 24 2021, 11:25 PM · Restricted Project
tbaeder abandoned D94873: [clang] [driver] Remove obsolete unistd.h include.
Feb 24 2021, 11:17 PM · Restricted Project
tbaeder requested review of D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.
Feb 24 2021, 2:35 AM · Restricted Project

Feb 23 2021

tbaeder requested review of D97362: [clang][parser] Allow attributes in explicit template instantiations.
Feb 23 2021, 11:59 PM · Restricted Project
tbaeder committed rG64d06ed9c9e0: [clang][parse][NFC] Remove dead ProhibitAttributes() call (authored by tbaeder).
[clang][parse][NFC] Remove dead ProhibitAttributes() call
Feb 23 2021, 4:56 AM
tbaeder closed D97271: [clang][parse] Remove dead ProhibitAttributes() call.
Feb 23 2021, 4:56 AM · Restricted Project
tbaeder requested review of D97271: [clang][parse] Remove dead ProhibitAttributes() call.
Feb 23 2021, 4:29 AM · Restricted Project

Feb 18 2021

tbaeder abandoned D96070: [clang] [driver] Enable static linking to libc++.

Thanks for the input everyone.

Feb 18 2021, 4:36 AM · Restricted Project

Feb 17 2021

tbaeder added a comment to D95536: [clang][sema] Note decl location on missing member.

Hmm... I feel like the diagnostic should already be sufficient to locate the originating location of the class or namespace and the note is adding a bit more (almost, but not quite) noise,

Feb 17 2021, 5:13 AM · Restricted Project

Feb 10 2021

tbaeder committed rG6f9db455a504: [clang][NFC] Fix undefined-libs tests (authored by tbaeder).
[clang][NFC] Fix undefined-libs tests
Feb 10 2021, 6:04 AM

Feb 9 2021

tbaeder added a comment to D95536: [clang][sema] Note decl location on missing member.

Any update on this?

Thank you for the patch! Do you have some motivating examples of when this would really add clarity to the diagnostic? I'm not opposed to the patch per se, but I'm a bit wary about adding an additional note because that makes the diagnostic output seem that much longer, which makes the salient diagnostics a bit harder to find (colorization in the terminal helps with this, though).

Feb 9 2021, 11:00 PM · Restricted Project
tbaeder added a comment to D95915: [clang][driver] Only warn once about invalid -stdlib value.

Looks like this broke the tests because -stdlib is not a thing on Windows? Would passing a linux -target x86_64-linux-gnu be an appropriate fix for the tests?

Feb 9 2021, 10:09 PM · Restricted Project
tbaeder added a comment to D90457: [clang][driver] Set LTO mode based on input files.

I don't think .bc files are affected by this patch since they aren't types::TY_Object files, but I might misremember.

Feb 9 2021, 9:51 PM · Restricted Project
tbaeder committed rGa6439b52088b: [clang][driver] Only warn once about invalid library values (authored by tbaeder).
[clang][driver] Only warn once about invalid library values
Feb 9 2021, 9:21 PM
tbaeder closed D95915: [clang][driver] Only warn once about invalid -stdlib value.
Feb 9 2021, 9:20 PM · Restricted Project
tbaeder added a comment to D95915: [clang][driver] Only warn once about invalid -stdlib value.

Is this good to go now? Or still something left? @yaxunl?

Feb 9 2021, 9:29 AM · Restricted Project
tbaeder added a comment to D90457: [clang][driver] Set LTO mode based on input files.

Hey @MaskRay, have you thought about this some more? Or is it too much magic and you'd rather reject it altogether?

Feb 9 2021, 9:27 AM · Restricted Project
tbaeder added a comment to D96070: [clang] [driver] Enable static linking to libc++.

we cannot control (optional -lc++abi/-lcxxrt/others), which is depended by the installation configuration (e.g. LIBCXX_STATICALLY_LINK_ABI_IN_STATIC_LIBRARY, or libc++.a as a linker script (https://bugs.llvm.org/show_bug.cgi?id=46321), or .deplibs) and whether you are specifying --sysroot. Perhaps I had the opportunity to redesign the matter, I would let -stdlib=libc++ not affect linker options at all. Users just should specify -lc++ and related options by themselves.

Feb 9 2021, 9:24 AM · Restricted Project
tbaeder added a comment to D95536: [clang][sema] Note decl location on missing member.

Any update on this?

Feb 9 2021, 7:32 AM · Restricted Project

Feb 8 2021

tbaeder updated the diff for D95915: [clang][driver] Only warn once about invalid -stdlib value.

Switched to llvm::Optional and added some tests

Feb 8 2021, 4:40 AM · Restricted Project

Feb 5 2021

tbaeder added a comment to D96070: [clang] [driver] Enable static linking to libc++.

In particular, if libcxx is built with LIBCXX_ENABLE_STATIC_ABI_LIBRARY enabled, the libcxxabi static library is merged into libc++.a, making static linking work just fine.

Feb 5 2021, 12:22 AM · Restricted Project

Feb 4 2021

tbaeder requested review of D96070: [clang] [driver] Enable static linking to libc++.
Feb 4 2021, 11:45 AM · Restricted Project
tbaeder updated the diff for D95915: [clang][driver] Only warn once about invalid -stdlib value.

Here a version without the local static bools. If this is good to go, I can add some tests.

Feb 4 2021, 1:53 AM · Restricted Project

Feb 3 2021

tbaeder added a comment to D95915: [clang][driver] Only warn once about invalid -stdlib value.

My proposal would be to cache the return value of the three routines in ToolChain. This has the advantage that the values get parsed only once and there is at most one warning. I don't know how this plays with parallelization efforts, but I don't think we should worry about this right now, given the current code.

Feb 3 2021, 11:44 PM · Restricted Project
tbaeder added a comment to D95915: [clang][driver] Only warn once about invalid -stdlib value.

Also, now you don't warn for different missing runtimes, which seems odd.

Feb 3 2021, 11:04 PM · Restricted Project
tbaeder updated the diff for D95915: [clang][driver] Only warn once about invalid -stdlib value.

Noticed similar/worse behavior for -rtlib. Expanded the patch to that and -unwindlib as well.

Feb 3 2021, 12:30 AM · Restricted Project

Feb 2 2021

tbaeder requested review of D95915: [clang][driver] Only warn once about invalid -stdlib value.
Feb 2 2021, 7:21 PM · Restricted Project

Jan 28 2021

tbaeder updated the diff for D95536: [clang][sema] Note decl location on missing member.

Fixed the Lambda oddity as well.

Jan 28 2021, 3:38 AM · Restricted Project
tbaeder updated the diff for D95536: [clang][sema] Note decl location on missing member.

Answered one of my questions by adding a new function directly to Sema.

Jan 28 2021, 1:03 AM · Restricted Project

Jan 27 2021

tbaeder updated the diff for D95536: [clang][sema] Note decl location on missing member.

Forgot clang-format of course, sorry.

Jan 27 2021, 2:13 PM · Restricted Project
tbaeder requested review of D95536: [clang][sema] Note decl location on missing member.
Jan 27 2021, 8:37 AM · Restricted Project

Jan 19 2021

tbaeder added a comment to D94873: [clang] [driver] Remove obsolete unistd.h include.

Pushed as b86e7ae66cb988dda33445c29fa64f93e7ca9c3c

Jan 19 2021, 12:30 AM · Restricted Project
tbaeder committed rGb86e7ae66cb9: [clang][driver][NFC][obvious] Remove obsolete unistd.h include (authored by tbaeder).
[clang][driver][NFC][obvious] Remove obsolete unistd.h include
Jan 19 2021, 12:29 AM

Jan 16 2021

tbaeder requested review of D94873: [clang] [driver] Remove obsolete unistd.h include.
Jan 16 2021, 11:05 PM · Restricted Project

Jan 15 2021

tbaeder updated the diff for D84846: [MC] Add support for generating missing GNU build notes.

Sorry about the last change, that was the wrong patch.

Jan 15 2021, 7:19 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D84846: [MC] Add support for generating missing GNU build notes.
Jan 15 2021, 7:18 AM · Restricted Project, Restricted Project

Jan 12 2021

tbaeder added a comment to D93375: [clang][driver] Add -ansi option to CompileOnly group.

Thanks for the commits, Aaron. If you don't mind I have a short question: both commits don't seem to list the test cases, have they not been committed at all or are they filtered out in github and/or phabricator? Did I mess something up?

Jan 12 2021, 9:17 PM · Restricted Project
tbaeder added a comment to D93375: [clang][driver] Add -ansi option to CompileOnly group.

Yes, I was gonna ask somebody else but if you have time, committing this one and https://reviews.llvm.org/D94478 would be nice

Jan 12 2021, 10:04 AM · Restricted Project