Page MenuHomePhabricator
People tbaeder

tbaeder (Timm Bäder)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2020, 4:41 AM (159 w, 6 d)

Recent Activity
View All

Fri, Mar 24

tbaeder requested review of D146819: [llvm][github] Add good-first-issue comment to issues.
Fri, Mar 24, 9:08 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D146376: Update static_assert message for redundant cases .
Fri, Mar 24, 8:52 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D141497: [clang][Interp] Record initialization via conditional operator.
Fri, Mar 24, 1:21 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D146408: [clang][Interp] Start supporting complex types.
Fri, Mar 24, 1:08 AM · Restricted Project, Restricted Project
tbaeder requested review of D146788: [clang][Interp] Fix zero-initializing of floating types.
Fri, Mar 24, 12:35 AM · Restricted Project, Restricted Project

Thu, Mar 23

tbaeder updated the diff for D141472: [clang][Interp] Add function pointers.
Thu, Mar 23, 11:22 PM · Restricted Project, Restricted Project
tbaeder updated the diff for D141472: [clang][Interp] Add function pointers.

Okay, fixed this by using visitZeroInitializer() so now it's not dead code anymore.

Thu, Mar 23, 11:20 PM · Restricted Project, Restricted Project
tbaeder added a comment to D141472: [clang][Interp] Add function pointers.
In D141472#4217479, @aaron.ballman wrote:
In D141472#4112790, @tbaeder wrote:

I'm not sure what to do about this right now. I was wondering about restructuring pointers so all the metadata is before all the actual data, but that would be a large refactoring.

For right now, we can move forward with basic function pointer support and we can revisit this when you get around to doing member function pointers.

Thu, Mar 23, 11:01 PM · Restricted Project, Restricted Project
tbaeder added a comment to D146436: [clang][Interp][NFC] Add tests for __fp16.

Meh, is __fp16 something I need to check support for?

Thu, Mar 23, 2:35 AM · Restricted Project, Restricted Project
tbaeder added a reverting change for rG0691bcb18024: [clang][Interp][NFC] Add tests for __fp16: rG814177e434d8: Revert "[clang][Interp][NFC] Add tests for __fp16".
Thu, Mar 23, 2:34 AM · Restricted Project, Restricted Project
tbaeder committed rG814177e434d8: Revert "[clang][Interp][NFC] Add tests for __fp16" (authored by tbaeder).
Revert "[clang][Interp][NFC] Add tests for __fp16"
Thu, Mar 23, 2:34 AM · Restricted Project, Restricted Project
tbaeder added a reverting change for D146436: [clang][Interp][NFC] Add tests for __fp16: rG814177e434d8: Revert "[clang][Interp][NFC] Add tests for __fp16".
Thu, Mar 23, 2:34 AM · Restricted Project, Restricted Project
tbaeder committed rG0691bcb18024: [clang][Interp][NFC] Add tests for __fp16 (authored by tbaeder).
[clang][Interp][NFC] Add tests for __fp16
Thu, Mar 23, 2:09 AM · Restricted Project, Restricted Project
tbaeder closed D146436: [clang][Interp][NFC] Add tests for __fp16.
Thu, Mar 23, 2:09 AM · Restricted Project, Restricted Project
tbaeder set the repository for D142630: [clang][Interp] Implement virtual function calls to rG LLVM Github Monorepo.
Thu, Mar 23, 1:44 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D142630: [clang][Interp] Implement virtual function calls.

Add some more tests for virtual destructors.

Thu, Mar 23, 1:44 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D146408: [clang][Interp] Start supporting complex types.

Completely forgot to add the tests to the patch, oops.

Thu, Mar 23, 1:42 AM · Restricted Project, Restricted Project
tbaeder added a comment to D146030: [clang][Interp] Handle LambdaExprs.

Ping

Thu, Mar 23, 12:30 AM · Restricted Project, Restricted Project
tbaeder added a comment to D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies.

Ping

Thu, Mar 23, 12:29 AM · Restricted Project, Restricted Project
tbaeder added a comment to D144164: [clang][Interp] Handle PtrMemOps.

Ping

Thu, Mar 23, 12:27 AM · Restricted Project, Restricted Project
tbaeder committed rGc5d22f4e1866: [clang][Sema][NFC] Make local variable const (authored by tbaeder).
[clang][Sema][NFC] Make local variable const
Thu, Mar 23, 12:23 AM · Restricted Project, Restricted Project

Wed, Mar 22

tbaeder added a comment to D146376: Update static_assert message for redundant cases .

I think just checking that the toplevel binary operator is a logical or should be enough? Since that only fails if both operands evaluate to false, so we don't need to print the "false or false" diagnostic.

Wed, Mar 22, 10:49 AM · Restricted Project, Restricted Project
tbaeder added a comment to D146376: Update static_assert message for redundant cases .

Since we only handle BinaryOperators in the toplevel assertion expression, I think it should just be safe to never diagnose for them if it's an BO_LOr opcode, so you should be able to just check for that in DiagnoseStaticAssertDetails().

Wed, Mar 22, 2:20 AM · Restricted Project, Restricted Project
tbaeder updated subscribers of D146503: Fix highlighting issue with _complex and initialization list with more than 2 items.

LGTM but I'll wait for @aaron.ballman to maybe comment on the diagnostic differences in C.

Wed, Mar 22, 12:33 AM · Restricted Project, Restricted Project

Tue, Mar 21

tbaeder added a comment to D146503: Fix highlighting issue with _complex and initialization list with more than 2 items.

I think the problem is that in https://github.com/llvm/llvm-project/blob/25ca26e0da2e1f80d62f71807828762691a049ac/clang/lib/Sema/SemaInit.cpp#L1532-L1541, the code checks for Index != 2 and then handles it as a single scalar initializer.

Tue, Mar 21, 3:15 AM · Restricted Project, Restricted Project

Mon, Mar 20

tbaeder added inline comments to D146436: [clang][Interp][NFC] Add tests for __fp16.
Mon, Mar 20, 1:44 PM · Restricted Project, Restricted Project
tbaeder updated the diff for D146436: [clang][Interp][NFC] Add tests for __fp16.
Mon, Mar 20, 1:43 PM · Restricted Project, Restricted Project
tbaeder requested review of D146436: [clang][Interp][NFC] Add tests for __fp16.
Mon, Mar 20, 9:48 AM · Restricted Project, Restricted Project
tbaeder requested review of D146408: [clang][Interp] Start supporting complex types.
Mon, Mar 20, 1:37 AM · Restricted Project, Restricted Project

Sun, Mar 19

tbaeder added a comment to D145860: [clang][Interp] Fix initializing fields after base class members.

Ping

Sun, Mar 19, 12:27 AM · Restricted Project, Restricted Project
tbaeder added a comment to D145841: [clang][Interp] Fix diagnostics for calling non-constexpr constructors.

Ping

Sun, Mar 19, 12:27 AM · Restricted Project, Restricted Project
tbaeder added a comment to D144943: [clang][Interp] Implement bitcasts (WIP).

Ping

Sun, Mar 19, 12:26 AM · Restricted Project, Restricted Project
tbaeder added a comment to D144457: [clang][Interp] Handle global composite temporaries.

Ping

Sun, Mar 19, 12:25 AM · Restricted Project, Restricted Project
tbaeder added a comment to D141472: [clang][Interp] Add function pointers.

Ping

Sun, Mar 19, 12:24 AM · Restricted Project, Restricted Project
tbaeder added a comment to D141497: [clang][Interp] Record initialization via conditional operator.

Ping

Sun, Mar 19, 12:24 AM · Restricted Project, Restricted Project

Sat, Mar 18

tbaeder added a comment to D146376: Update static_assert message for redundant cases .

Looks like you're just removing the output altogether, so that won't work.

Sat, Mar 18, 11:55 PM · Restricted Project, Restricted Project
tbaeder added a comment to D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables.

"subobject named 'foo'" sounds a bit weird to me, I'd expect just "subobject 'foo'", but that's just a suggestion and I'll wait for a native spearker to chime in on this.

Sat, Mar 18, 11:01 PM · Restricted Project, Restricted Project

Wed, Mar 15

tbaeder added a comment to D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies.

Ping

Wed, Mar 15, 9:33 AM · Restricted Project, Restricted Project
tbaeder abandoned D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays.

Abandoning this since the approach is not feasible anymore with https://reviews.llvm.org/D145545

Wed, Mar 15, 9:32 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays.
Wed, Mar 15, 2:13 AM · Restricted Project, Restricted Project

Tue, Mar 14

tbaeder updated the diff for D145861: [clang][Interp] Ignore more non-VarDecl declarations.
Tue, Mar 14, 7:40 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies.
Tue, Mar 14, 7:18 AM · Restricted Project, Restricted Project
tbaeder committed rG6603c68302c1: [clang][sema][NFC] Make a few functions const (authored by tbaeder).
[clang][sema][NFC] Make a few functions const
Tue, Mar 14, 5:48 AM · Restricted Project, Restricted Project
tbaeder closed D145947: [clang][sema][NFC] Make a few functions const.
Tue, Mar 14, 5:48 AM · Restricted Project, Restricted Project
tbaeder requested review of D146030: [clang][Interp] Handle LambdaExprs.
Tue, Mar 14, 3:46 AM · Restricted Project, Restricted Project

Mon, Mar 13

tbaeder added inline comments to D145861: [clang][Interp] Ignore more non-VarDecl declarations.
Mon, Mar 13, 8:43 AM · Restricted Project, Restricted Project
tbaeder requested review of D145947: [clang][sema][NFC] Make a few functions const.
Mon, Mar 13, 8:42 AM · Restricted Project, Restricted Project

Sat, Mar 11

tbaeder requested review of D145861: [clang][Interp] Ignore more non-VarDecl declarations.
Sat, Mar 11, 11:33 PM · Restricted Project, Restricted Project
tbaeder requested review of D145860: [clang][Interp] Fix initializing fields after base class members.
Sat, Mar 11, 10:46 PM · Restricted Project, Restricted Project
tbaeder updated the diff for D145841: [clang][Interp] Fix diagnostics for calling non-constexpr constructors.
Sat, Mar 11, 10:28 PM · Restricted Project, Restricted Project
tbaeder added a comment to D144943: [clang][Interp] Implement bitcasts (WIP).

Ping

Sat, Mar 11, 10:27 PM · Restricted Project, Restricted Project
tbaeder requested review of D145841: [clang][Interp] Fix diagnostics for calling non-constexpr constructors.
Sat, Mar 11, 12:58 AM · Restricted Project, Restricted Project

Fri, Mar 10

tbaeder added inline comments to D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call.
Fri, Mar 10, 7:47 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D143466: [clang][Interp] Fix initializing base class members.
Fri, Mar 10, 7:32 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D143466: [clang][Interp] Fix initializing base class members.
Fri, Mar 10, 7:31 AM · Restricted Project, Restricted Project
tbaeder added a comment to D144457: [clang][Interp] Handle global composite temporaries.

Ping

Fri, Mar 10, 7:31 AM · Restricted Project, Restricted Project
tbaeder added a comment to D144164: [clang][Interp] Handle PtrMemOps.

Ping

Fri, Mar 10, 6:37 AM · Restricted Project, Restricted Project
tbaeder added a comment to D141472: [clang][Interp] Add function pointers.

Ping

Fri, Mar 10, 6:37 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D145769: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC).
Fri, Mar 10, 6:17 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D141497: [clang][Interp] Record initialization via conditional operator.
Fri, Mar 10, 3:15 AM · Restricted Project, Restricted Project
tbaeder abandoned D141194: [clang][Interp] Implement bitcasts.

Abandoning this since it's superseded by https://reviews.llvm.org/D144943

Fri, Mar 10, 1:16 AM · Restricted Project, Restricted Project

Thu, Mar 9

tbaeder added inline comments to D143480: [clang][Interp] Fix derived-to-base casts for >1 levels.
Thu, Mar 9, 9:37 PM · Restricted Project, Restricted Project
tbaeder updated the diff for D143480: [clang][Interp] Fix derived-to-base casts for >1 levels.
Thu, Mar 9, 9:37 PM · Restricted Project, Restricted Project
tbaeder committed rG0041f081962c: [clang][Interp][NFC] Take a const Descriptor* in dtor,move,ctorFns (authored by tbaeder).
[clang][Interp][NFC] Take a const Descriptor* in dtor,move,ctorFns
Thu, Mar 9, 7:10 AM · Restricted Project, Restricted Project
tbaeder added a comment to D143466: [clang][Interp] Fix initializing base class members.

The tests you proposed need https://reviews.llvm.org/D143480 first so we can cast up more than one level.

Thu, Mar 9, 4:28 AM · Restricted Project, Restricted Project

Wed, Mar 8

tbaeder updated the summary of D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies.
Wed, Mar 8, 1:02 AM · Restricted Project, Restricted Project

Tue, Mar 7

tbaeder requested review of D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies.
Tue, Mar 7, 10:22 PM · Restricted Project, Restricted Project

Sun, Mar 5

tbaeder added a reverting change for rG78e4237460bf: [clang][Interp] Support destructors: rG5e12002c6cea: Revert "[clang][Interp] Support destructors".
Sun, Mar 5, 4:19 AM · Restricted Project, Restricted Project
tbaeder committed rG5e12002c6cea: Revert "[clang][Interp] Support destructors" (authored by tbaeder).
Revert "[clang][Interp] Support destructors"
Sun, Mar 5, 4:18 AM · Restricted Project, Restricted Project
tbaeder added a reverting change for D137070: [clang][Interp] Support destructors: rG5e12002c6cea: Revert "[clang][Interp] Support destructors".
Sun, Mar 5, 4:18 AM · Restricted Project, Restricted Project
tbaeder committed rG78e4237460bf: [clang][Interp] Support destructors (authored by tbaeder).
[clang][Interp] Support destructors
Sun, Mar 5, 1:09 AM · Restricted Project, Restricted Project
tbaeder closed D137070: [clang][Interp] Support destructors.
Sun, Mar 5, 1:08 AM · Restricted Project, Restricted Project
tbaeder committed rG33ba940de040: [clang][Interp][NFCI] Support more expression in initializers (authored by tbaeder).
[clang][Interp][NFCI] Support more expression in initializers
Sun, Mar 5, 1:00 AM · Restricted Project, Restricted Project

Sat, Mar 4

tbaeder committed rG2708869801ae: Re-land "[clang][Interp] Implement C++ Range-for loops" (authored by tbaeder).
Re-land "[clang][Interp] Implement C++ Range-for loops"
Sat, Mar 4, 6:18 AM · Restricted Project, Restricted Project

Fri, Mar 3

tbaeder added a comment to D142328: [clang][Interp] Fix compound assign operator types.

All the interpreter work is experimental so it doesn't really need to be in the release branch. This should all be fine, thanks for asking.

Fri, Mar 3, 10:35 AM · Restricted Project, Restricted Project

Thu, Mar 2

tbaeder added a reverting change for rGbce8b3c18304: [clang][Interp] Implement C++ Range-for loops: rG43e67707f9ab: Revert "[clang][Interp] Implement C++ Range-for loops".
Thu, Mar 2, 2:04 AM · Restricted Project, Restricted Project
tbaeder committed rG43e67707f9ab: Revert "[clang][Interp] Implement C++ Range-for loops" (authored by tbaeder).
Revert "[clang][Interp] Implement C++ Range-for loops"
Thu, Mar 2, 2:04 AM · Restricted Project, Restricted Project
tbaeder added a reverting change for D140803: [clang][Interp] Implement C++ Range-for loops: rG43e67707f9ab: Revert "[clang][Interp] Implement C++ Range-for loops".
Thu, Mar 2, 2:04 AM · Restricted Project, Restricted Project
tbaeder committed rG90d921fa1f71: [clang][Interp] Handle record initialization via CastExpr (authored by tbaeder).
[clang][Interp] Handle record initialization via CastExpr
Thu, Mar 2, 1:09 AM · Restricted Project, Restricted Project
tbaeder closed D140808: [clang][Interp] Handle record initialization via CastExpr.
Thu, Mar 2, 1:09 AM · Restricted Project, Restricted Project
tbaeder committed rG6b5afda61c4a: [clang][Interp] Add ArrayElemPtr{,Pop} opcode (authored by tbaeder).
[clang][Interp] Add ArrayElemPtr{,Pop} opcode
Thu, Mar 2, 12:46 AM · Restricted Project, Restricted Project
tbaeder closed D140805: [clang][Interp] Add ArrayElemPtr{,Pop} opcode.
Thu, Mar 2, 12:45 AM · Restricted Project, Restricted Project
tbaeder committed rG569222e172e5: [clang][Interp] Only check constructors for global variables (authored by tbaeder).
[clang][Interp] Only check constructors for global variables
Thu, Mar 2, 12:24 AM · Restricted Project, Restricted Project
tbaeder closed D140723: [clang][Interp] Only check constructors for global variables.
Thu, Mar 2, 12:23 AM · Restricted Project, Restricted Project
tbaeder committed rGbce8b3c18304: [clang][Interp] Implement C++ Range-for loops (authored by tbaeder).
[clang][Interp] Implement C++ Range-for loops
Thu, Mar 2, 12:01 AM · Restricted Project, Restricted Project
tbaeder closed D140803: [clang][Interp] Implement C++ Range-for loops.
Thu, Mar 2, 12:01 AM · Restricted Project, Restricted Project

Wed, Mar 1

tbaeder committed rGbf6c1344ec18: [clang][Interp] Handle defined functions without a body (authored by tbaeder).
[clang][Interp] Handle defined functions without a body
Wed, Mar 1, 11:19 PM · Restricted Project, Restricted Project
tbaeder closed D140776: [clang][Interp] Handle defined functions without a body.
Wed, Mar 1, 11:18 PM · Restricted Project, Restricted Project
tbaeder committed rGf18b71d14f7e: [clang][Interp] Implement remaining MaterializeTemporaryExpr bits (authored by tbaeder).
[clang][Interp] Implement remaining MaterializeTemporaryExpr bits
Wed, Mar 1, 10:53 PM · Restricted Project, Restricted Project
tbaeder closed D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs.
Wed, Mar 1, 10:53 PM · Restricted Project, Restricted Project
tbaeder committed rG730eca6a3de8: [clang][Interp] Handle DecompositionDecls (authored by tbaeder).
[clang][Interp] Handle DecompositionDecls
Wed, Mar 1, 8:12 AM · Restricted Project, Restricted Project
tbaeder closed D138802: [clang][Interp] Implement DecompositionDecls.
Wed, Mar 1, 8:12 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D142630: [clang][Interp] Implement virtual function calls.
Wed, Mar 1, 7:26 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D142617: [clang][Interp] Check This pointer without creating InterpFrame.

Added an aligned() assertion and renamed the old peek(unsigned Offset) returning a void* to peekData(), so both peek overloads are now public member functions.

Wed, Mar 1, 7:06 AM · Restricted Project, Restricted Project
tbaeder committed rG8d09bd616be8: [clang][Interp] This pointers are writable in de-/constructors (authored by tbaeder).
[clang][Interp] This pointers are writable in de-/constructors
Wed, Mar 1, 6:42 AM · Restricted Project, Restricted Project
tbaeder closed D136751: [clang][Interp] This pointers are writable in constructors.
Wed, Mar 1, 6:41 AM · Restricted Project, Restricted Project
tbaeder added a comment to D141472: [clang][Interp] Add function pointers.

Ping

Wed, Mar 1, 12:25 AM · Restricted Project, Restricted Project
tbaeder added inline comments to D141591: [clang][Interp] Properly identify not-yet-defined functions.
Wed, Mar 1, 12:25 AM · Restricted Project, Restricted Project
tbaeder added a comment to D142617: [clang][Interp] Check This pointer without creating InterpFrame.

Ping

Wed, Mar 1, 12:23 AM · Restricted Project, Restricted Project
tbaeder added a comment to D142630: [clang][Interp] Implement virtual function calls.

Ping

Wed, Mar 1, 12:23 AM · Restricted Project, Restricted Project