Page MenuHomePhabricator

tbaeder (Timm Bäder)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2020, 4:41 AM (33 w, 5 d)

Recent Activity

Thu, Oct 22

tbaeder requested review of D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD.
Thu, Oct 22, 3:03 AM · Restricted Project

Sep 2 2020

tbaeder added a comment to D84846: [MC] Add support for generating missing GNU build notes.

Ping

Sep 2 2020, 6:34 AM · Restricted Project, Restricted Project

Aug 21 2020

tbaeder added a reviewer for D84846: [MC] Add support for generating missing GNU build notes: pcc.
Aug 21 2020, 12:47 AM · Restricted Project, Restricted Project

Aug 10 2020

tbaeder updated the diff for D84846: [MC] Add support for generating missing GNU build notes.

Add a test that checks that clang accepts -Wa,--generate-missing-build-notes=yes and -Wa,--generate-missing-build-notes=no

Aug 10 2020, 3:48 AM · Restricted Project, Restricted Project

Jul 29 2020

tbaeder requested review of D84846: [MC] Add support for generating missing GNU build notes.
Jul 29 2020, 7:09 AM · Restricted Project, Restricted Project

Jun 5 2020

tbaeder added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

I'm looking at this again and I am not sure how it is meant to work. For example in Parser::parseClassSpecifier in ParseDeclCXX.cpp.
Here attrs is a local variable of type ParsedAttributesWithRange, already before my patch. attrs is then passed to

Jun 5 2020, 6:33 AM · Restricted Project

Mar 31 2020

tbaeder added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Sorry for taking so long but it seems like I've went down a rabbit hole a bit. My previous patch sets the range in parseGNUAttributes() unconditionally, but that seems to trigger cases such as

Mar 31 2020, 1:37 AM · Restricted Project

Mar 23 2020

tbaeder added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Thanks, I'll take a look at the tests.

Mar 23 2020, 6:30 AM · Restricted Project

Mar 11 2020

tbaeder updated the diff for D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Updated according to Aaron's comments. I'm not sure about changing the DeclSpec member and moving ParsedAttributesWithRange to ParsedAttr.h.

Mar 11 2020, 3:47 AM · Restricted Project

Mar 9 2020

tbaeder created D75844: [clang] Set begin loc on GNU attribute parsed attrs.
Mar 9 2020, 5:52 AM · Restricted Project

Mar 4 2020

tbaeder added a comment to D73852: [clang] detect switch fallthrough marked by a comment (PR43465).

I know this has been reverted, but for the record, the implementation has a few shortcomings that makes it hard to use it for projects that rely on fallthrough comments:

Mar 4 2020, 12:06 AM · Restricted Project

Mar 3 2020

tbaeder abandoned D75461: Ignore macro expansions when scanning for fallthrough comments.

fallthrough comment detection has been reverted, so abandon this in the meantime.

Mar 3 2020, 11:33 PM · Restricted Project

Mar 2 2020

tbaeder created D75461: Ignore macro expansions when scanning for fallthrough comments.
Mar 2 2020, 8:12 AM · Restricted Project