This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Affine][NFC] Wrap dialect in "affine" namespace
ClosedPublic

Authored by springerm on Apr 18 2023, 11:41 PM.

Diff Detail

Event Timeline

springerm created this revision.Apr 18 2023, 11:41 PM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
springerm requested review of this revision.Apr 18 2023, 11:41 PM
nicolasvasilache accepted this revision.Apr 19 2023, 1:58 AM
This revision is now accepted and ready to land.Apr 19 2023, 1:58 AM
mehdi_amini accepted this revision.Apr 19 2023, 10:27 AM

Thanks!

Can you add a description with the motivation, even if only: "This cleanup aligns the affine dialect with all the other dialects." or something like that.

dcaballe accepted this revision.Apr 19 2023, 11:18 AM
This revision was landed with ongoing or failed builds.Apr 19 2023, 7:20 PM
This revision was automatically updated to reflect the committed changes.

Thanks for doing this. This had been long pending. This also cleans up the naming/addressing of free-standing methods that were otherwise in the mlir namespace. Having mlir::affine::... for these is a big naming and readability improvement.

ubfx added a subscriber: ubfx.Apr 22 2023, 12:46 AM

Will the Operations from the Affine dialect also be renamed? I feel like affine::AffineForOp could be renamed to affine::ForOp now.