Page MenuHomePhabricator

ubfx (Felix Schneider)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 31 2023, 8:20 AM (9 w, 4 d)

Recent Activity

Apr 22 2023

ubfx added a comment to D148687: [mlir][Affine][NFC] Wrap dialect in "affine" namespace.

Will the Operations from the Affine dialect also be renamed? I feel like affine::AffineForOp could be renamed to affine::ForOp now.

Apr 22 2023, 12:46 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2023

ubfx added a comment to D148009: [mlir][MemRef] fix error message in ReinterpretCastOp::verify.

Thank you, @ftynse
Could you push the patch when you get a chance since I don't have permissions?

Apr 11 2023, 8:34 AM · Restricted Project, Restricted Project
ubfx updated the diff for D148009: [mlir][MemRef] fix error message in ReinterpretCastOp::verify.

Also fix the tests

Apr 11 2023, 6:19 AM · Restricted Project, Restricted Project
ubfx requested review of D148009: [mlir][MemRef] fix error message in ReinterpretCastOp::verify.
Apr 11 2023, 5:26 AM · Restricted Project, Restricted Project

Apr 4 2023

ubfx updated the diff for D147345: [mlir] Allow merging symbols without attached Values.

merge my commits into one

Apr 4 2023, 3:21 AM · Restricted Project, Restricted Project
ubfx updated the diff for D147345: [mlir] Allow merging symbols without attached Values.

Add braces for readability

Apr 4 2023, 3:08 AM · Restricted Project, Restricted Project
ubfx added a comment to D147345: [mlir] Allow merging symbols without attached Values.

This change makes sense to me. It's been a while since I looked at this particular part of the file though. Could you go back in the Github history and also add the original author of this function? (The file was moved around a few times.)

Apr 4 2023, 2:48 AM · Restricted Project, Restricted Project
ubfx added a comment to D147345: [mlir] Allow merging symbols without attached Values.

@springerm Since you have been working on a restructuring of the FlatAffineValueConstraints / Affine Analysis classes and are working on the ValueBoundsOpInterface, which all seem related, could you comment on this?

Apr 4 2023, 2:05 AM · Restricted Project, Restricted Project

Apr 2 2023

ubfx added a comment to D147384: [mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface.

Could someone with repository access push this patch? Thanks in advance :)

Apr 2 2023, 12:00 PM · Restricted Project, Restricted Project

Apr 1 2023

ubfx added a comment to D147384: [mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface.

Is the cast still needed now? I would think that getOperation() returns directly the interface now

Apr 1 2023, 1:14 PM · Restricted Project, Restricted Project
ubfx updated the diff for D147384: [mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface.

Remove the cast because getOperation() already returns the Interface.

Apr 1 2023, 1:14 PM · Restricted Project, Restricted Project
ubfx requested review of D147384: [mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface.
Apr 1 2023, 12:39 PM · Restricted Project, Restricted Project

Mar 31 2023

ubfx updated subscribers of D147345: [mlir] Allow merging symbols without attached Values.
Mar 31 2023, 9:54 PM · Restricted Project, Restricted Project
ubfx added a comment to D147345: [mlir] Allow merging symbols without attached Values.

To clarify a little more, because I saw that there have been a few changes to these files recently and I'm not entirely sure whether the current behavior of the function might be intentional:

Mar 31 2023, 11:16 AM · Restricted Project, Restricted Project
ubfx requested review of D147345: [mlir] Allow merging symbols without attached Values.
Mar 31 2023, 11:01 AM · Restricted Project, Restricted Project
ubfx updated ubfx.
Mar 31 2023, 8:23 AM