Page MenuHomePhabricator

hanchung (Han-Chung Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 8:20 PM (26 w, 3 d)

Recent Activity

Fri, Jun 26

hanchung added inline comments to D82619: [mlir][spirv] Add lowering of std alloca to SPIR-V.
Fri, Jun 26, 12:31 AM · Restricted Project

Mon, Jun 22

hanchung committed rG809bcf4c87d0: [mlir] Fix a doc link in LinalgBase.td (authored by hanchung).
[mlir] Fix a doc link in LinalgBase.td
Mon, Jun 22, 11:50 AM
hanchung closed D82303: [mlir] Fix a doc link in LinalgBase.td.
Mon, Jun 22, 11:50 AM · Restricted Project
hanchung created D82303: [mlir] Fix a doc link in LinalgBase.td.
Mon, Jun 22, 8:02 AM · Restricted Project

Thu, Jun 18

hanchung committed rG9cb10296ecaa: [mlir] Add support for lowering tanh to LLVMIR. (authored by hanchung).
[mlir] Add support for lowering tanh to LLVMIR.
Thu, Jun 18, 10:54 AM
hanchung closed D82040: [mlir] Add support for expanding tanh op into exp form..
Thu, Jun 18, 10:54 AM · Restricted Project
hanchung updated the diff for D82040: [mlir] Add support for expanding tanh op into exp form..

Remove unneeded include from mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp

Thu, Jun 18, 9:45 AM · Restricted Project

Wed, Jun 17

hanchung retitled D82040: [mlir] Add support for expanding tanh op into exp form. from [mlir] Add support for lowering tanh to LLVMIR. to [mlir] Add support for expanding tanh op into exp form..
Wed, Jun 17, 12:56 PM · Restricted Project
hanchung updated the diff for D82040: [mlir] Add support for expanding tanh op into exp form..

Remove the pattern from ConvertLinalgToLLVMPass.

Wed, Jun 17, 12:56 PM · Restricted Project
hanchung added a reviewer for D82040: [mlir] Add support for expanding tanh op into exp form.: asaadaldien.
Wed, Jun 17, 12:24 PM · Restricted Project
hanchung added a comment to D82040: [mlir] Add support for expanding tanh op into exp form..

Oh wait me a sec, I think I should populate the pattern at populateStdToLLVMConversionPatterns, not in LinalgToLLVM.cpp file. Let me fix it.

Wed, Jun 17, 12:24 PM · Restricted Project
hanchung added a comment to D82040: [mlir] Add support for expanding tanh op into exp form..

It's fixed by adding a missing dep in mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt

Wed, Jun 17, 12:24 PM · Restricted Project
hanchung created D82040: [mlir] Add support for expanding tanh op into exp form..
Wed, Jun 17, 12:24 PM · Restricted Project

Mon, Jun 15

hanchung added a comment to D81618: [mlir] Add support for lowering tanh to LLVMIR..

Reverted in a9a21bb4b682474248dc85f9e7db4b260d249ab9 ; the standalone test was broken

Mon, Jun 15, 4:02 PM · Restricted Project
hanchung committed rG487ca07fcc75: [mlir][NFC] Fix file comments. (authored by hanchung).
[mlir][NFC] Fix file comments.
Mon, Jun 15, 2:57 PM
hanchung closed D81858: [mlir][NFC] Fix file comments..
Mon, Jun 15, 2:57 PM · Restricted Project
hanchung created D81858: [mlir][NFC] Fix file comments..
Mon, Jun 15, 11:31 AM · Restricted Project
hanchung committed rG32c757e4f808: [mlir] Add support for lowering tanh to LLVMIR. (authored by hanchung).
[mlir] Add support for lowering tanh to LLVMIR.
Mon, Jun 15, 10:58 AM
hanchung closed D81618: [mlir] Add support for lowering tanh to LLVMIR..
Mon, Jun 15, 10:56 AM · Restricted Project

Fri, Jun 12

hanchung retitled D81618: [mlir] Add support for lowering tanh to LLVMIR. from [mlir][StandardToLLVM] Add support for lowering tanh to LLVMIR. to [mlir] Add support for lowering tanh to LLVMIR..
Fri, Jun 12, 12:35 PM · Restricted Project
hanchung added inline comments to D81618: [mlir] Add support for lowering tanh to LLVMIR..
Fri, Jun 12, 12:07 PM · Restricted Project
hanchung updated the diff for D81618: [mlir] Add support for lowering tanh to LLVMIR..

Address comments.

Fri, Jun 12, 12:06 PM · Restricted Project

Thu, Jun 11

hanchung updated the diff for D81618: [mlir] Add support for lowering tanh to LLVMIR..

Add missing files...

Thu, Jun 11, 7:15 PM · Restricted Project
hanchung added a comment to D81618: [mlir] Add support for lowering tanh to LLVMIR..

Thanks for the advice, I think it's better now. :)

Thu, Jun 11, 7:15 PM · Restricted Project
hanchung updated the diff for D81618: [mlir] Add support for lowering tanh to LLVMIR..

Add a test

Thu, Jun 11, 7:15 PM · Restricted Project
hanchung updated the diff for D81618: [mlir] Add support for lowering tanh to LLVMIR..

Add expanding tanh pattern to StandardOps/Transforms/

Thu, Jun 11, 6:43 PM · Restricted Project

Jun 10 2020

hanchung created D81618: [mlir] Add support for lowering tanh to LLVMIR..
Jun 10 2020, 4:08 PM · Restricted Project

Jun 9 2020

hanchung abandoned D81317: [mlir][StandardToSPIRV] Handle i1 case for lowering std.load op and std.store op.

Should we drop this for now given this is not the preferred way to go?

Jun 9 2020, 9:29 PM · Restricted Project

Jun 5 2020

hanchung created D81317: [mlir][StandardToSPIRV] Handle i1 case for lowering std.load op and std.store op.
Jun 5 2020, 4:16 PM · Restricted Project

Jun 3 2020

hanchung committed rG0b025d2733d0: [mlir][StandardToSPIRV] Handle i1 case for lowering std.zexti to SPIR-V. (authored by hanchung).
[mlir][StandardToSPIRV] Handle i1 case for lowering std.zexti to SPIR-V.
Jun 3 2020, 3:30 PM
hanchung committed rGcc11ceda165b: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic… (authored by hanchung).
[mlir][Linalg] Add support for fusion between indexed_generic ops and generic…
Jun 3 2020, 3:30 PM
hanchung committed rG27fca57546c2: [mlir][Linalg] Add support for fusion between indexed_generic ops and… (authored by hanchung).
[mlir][Linalg] Add support for fusion between indexed_generic ops and…
Jun 3 2020, 3:30 PM
hanchung closed D80965: [mlir][StandardToSPIRV] Handle i1 case for lowering std.zexti to SPIR-V..
Jun 3 2020, 3:29 PM · Restricted Project
hanchung closed D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..
Jun 3 2020, 3:29 PM · Restricted Project, Restricted Project
hanchung closed D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops.
Jun 3 2020, 3:29 PM · Restricted Project, Restricted Project

Jun 2 2020

hanchung updated the summary of D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..
Jun 2 2020, 10:57 AM · Restricted Project, Restricted Project

Jun 1 2020

hanchung created D80965: [mlir][StandardToSPIRV] Handle i1 case for lowering std.zexti to SPIR-V..
Jun 1 2020, 5:21 PM · Restricted Project
hanchung updated the diff for D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops.

rebase

Jun 1 2020, 2:39 PM · Restricted Project, Restricted Project
hanchung updated the diff for D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..

rebase

Jun 1 2020, 2:39 PM · Restricted Project, Restricted Project

May 27 2020

hanchung updated the diff for D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..

Address comments.

May 27 2020, 3:16 PM · Restricted Project, Restricted Project
hanchung added inline comments to D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..
May 27 2020, 3:16 PM · Restricted Project, Restricted Project

May 26 2020

hanchung added a comment to D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops.

Good to know that this minimal change works as expected (I hoped it would). Thanks for adding tests.
Based on the previous patch in this stack, if we can combine the methods for fusion of generic/indexed-generic producer/consumer then I think this change will not be needed. The tests are still useful though. Will wait to review this again after that.

May 26 2020, 5:28 PM · Restricted Project, Restricted Project
hanchung updated the diff for D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops.

Update parents

May 26 2020, 4:55 PM · Restricted Project, Restricted Project
hanchung updated the diff for D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..

Update parents.

May 26 2020, 4:55 PM · Restricted Project, Restricted Project
hanchung updated the diff for D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..

Merge methods together for generic ops and indexed_generic ops.

May 26 2020, 4:55 PM · Restricted Project, Restricted Project

May 21 2020

hanchung added a reviewer for D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops: ThomasRaoux.
May 21 2020, 3:43 PM · Restricted Project, Restricted Project
hanchung added a reviewer for D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors.: ThomasRaoux.
May 21 2020, 3:43 PM · Restricted Project, Restricted Project

May 20 2020

hanchung added a child revision for D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors.: D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops.
May 20 2020, 6:15 PM · Restricted Project, Restricted Project
hanchung created D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops.
May 20 2020, 6:15 PM · Restricted Project, Restricted Project
hanchung created D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..
May 20 2020, 6:15 PM · Restricted Project, Restricted Project

May 19 2020

hanchung committed rG520a5702680e: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation. (authored by hanchung).
[mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation.
May 19 2020, 11:29 AM
hanchung closed D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..
May 19 2020, 11:29 AM · Restricted Project

May 18 2020

hanchung updated the diff for D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..

address comments

May 18 2020, 3:45 PM · Restricted Project
hanchung added inline comments to D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..
May 18 2020, 3:45 PM · Restricted Project

May 15 2020

hanchung added inline comments to D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..
May 15 2020, 5:24 PM · Restricted Project
hanchung updated the diff for D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..

Add check on more unsigned ops.

May 15 2020, 5:24 PM · Restricted Project
hanchung added inline comments to D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..
May 15 2020, 2:42 PM · Restricted Project
hanchung updated the diff for D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..

Add a TODO.

May 15 2020, 2:42 PM · Restricted Project

May 14 2020

hanchung added inline comments to D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..
May 14 2020, 2:08 PM · Restricted Project
hanchung added a comment to D79931: [mlir][spirv] Handle debuginfo for control flow ops..

Still working on it, will reply once it's ready to review.

May 14 2020, 2:08 PM · Restricted Project
hanchung retitled D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation. from [mlir][StandardToSPIRV] Fix a bug in loading a non-i32 value. to [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..
May 14 2020, 2:08 PM · Restricted Project
hanchung updated the diff for D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..

Handle bitwidth emulation on unsigned operator.

May 14 2020, 2:08 PM · Restricted Project
hanchung added a comment to D79931: [mlir][spirv] Handle debuginfo for control flow ops..

Still working on it, will reply once it's ready to review.

May 14 2020, 1:36 PM · Restricted Project

May 11 2020

hanchung added inline comments to D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..
May 11 2020, 5:18 PM · Restricted Project
hanchung created D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation..
May 11 2020, 5:18 PM · Restricted Project
hanchung committed rG756d6959d7ac: [mlir][StandardToSPIRV] Add support for lowering index_cast to SPIR-V. (authored by hanchung).
[mlir][StandardToSPIRV] Add support for lowering index_cast to SPIR-V.
May 11 2020, 3:42 PM
hanchung closed D79644: [mlir][StandardToSPIRV] Add support for lowering index_cast to SPIR-V..
May 11 2020, 3:41 PM · Restricted Project
hanchung updated the diff for D79644: [mlir][StandardToSPIRV] Add support for lowering index_cast to SPIR-V..

Add test cases for casting between i32 and index.

May 11 2020, 2:35 PM · Restricted Project
hanchung added inline comments to D79644: [mlir][StandardToSPIRV] Add support for lowering index_cast to SPIR-V..
May 11 2020, 2:35 PM · Restricted Project
hanchung committed rG3f07cab3124d: [mlir][StandardToLLVM] Add support for lowering FPToSIOp to LLVM. (authored by hanchung).
[mlir][StandardToLLVM] Add support for lowering FPToSIOp to LLVM.
May 11 2020, 1:34 AM
hanchung committed rGb80da04b4457: [mlir] Add FPToSIOp to Standard dialect. (authored by hanchung).
[mlir] Add FPToSIOp to Standard dialect.
May 11 2020, 1:34 AM
hanchung committed rGac691c4fe7f6: [mlir][StandardToSPIRV] Add support for lowering FPToSIOp to SPIR-V. (authored by hanchung).
[mlir][StandardToSPIRV] Add support for lowering FPToSIOp to SPIR-V.
May 11 2020, 1:34 AM
hanchung closed D79373: [mlir] Add FPToSIOp to Standard dialect..
May 11 2020, 1:34 AM · Restricted Project
hanchung closed D79455: [mlir][StandardToLLVM] Add support for lowering FPToSIOp to LLVM..
May 11 2020, 1:34 AM · Restricted Project
hanchung closed D79374: [mlir][StandardToSPIRV] Add support for lowering FPToSIOp to SPIR-V..
May 11 2020, 1:34 AM · Restricted Project

May 8 2020

hanchung updated the diff for D79644: [mlir][StandardToSPIRV] Add support for lowering index_cast to SPIR-V..

I think indices could be negative? so switch to using SConvert.

May 8 2020, 3:03 PM · Restricted Project
hanchung updated the diff for D79644: [mlir][StandardToSPIRV] Add support for lowering index_cast to SPIR-V..

Rebases to master.

May 8 2020, 1:26 PM · Restricted Project
hanchung added a comment to D79373: [mlir] Add FPToSIOp to Standard dialect..

Looks good to me. Please wait for River to accept.

I think River's concerns were addressed. He is OOO for the next week; let's land this and we can always fix afterwards if he has more concerns.

May 8 2020, 1:26 PM · Restricted Project
hanchung created D79644: [mlir][StandardToSPIRV] Add support for lowering index_cast to SPIR-V..
May 8 2020, 12:20 PM · Restricted Project

May 5 2020

hanchung created D79455: [mlir][StandardToLLVM] Add support for lowering FPToSIOp to LLVM..
May 5 2020, 4:45 PM · Restricted Project
hanchung added a child revision for D79374: [mlir][StandardToSPIRV] Add support for lowering FPToSIOp to SPIR-V.: D79455: [mlir][StandardToLLVM] Add support for lowering FPToSIOp to LLVM..
May 5 2020, 4:45 PM · Restricted Project

May 4 2020

hanchung updated the diff for D79373: [mlir] Add FPToSIOp to Standard dialect..

Address comments.

May 4 2020, 5:46 PM · Restricted Project
hanchung added inline comments to D79373: [mlir] Add FPToSIOp to Standard dialect..
May 4 2020, 5:46 PM · Restricted Project
hanchung created D79373: [mlir] Add FPToSIOp to Standard dialect..
May 4 2020, 4:41 PM · Restricted Project
hanchung created D79374: [mlir][StandardToSPIRV] Add support for lowering FPToSIOp to SPIR-V..
May 4 2020, 4:41 PM · Restricted Project
hanchung added a child revision for D79373: [mlir] Add FPToSIOp to Standard dialect.: D79374: [mlir][StandardToSPIRV] Add support for lowering FPToSIOp to SPIR-V..
May 4 2020, 4:41 PM · Restricted Project
hanchung committed rG5d10613b6edc: [mlir][StandardToSPIRV] Emulate bitwidths not supported for store op. (authored by hanchung).
[mlir][StandardToSPIRV] Emulate bitwidths not supported for store op.
May 4 2020, 3:38 PM
hanchung closed D79272: [mlir][StandardToSPIRV] Emulate bitwidths not supported for store op..
May 4 2020, 3:38 PM · Restricted Project
hanchung updated the summary of D79272: [mlir][StandardToSPIRV] Emulate bitwidths not supported for store op..
May 4 2020, 3:37 PM · Restricted Project
hanchung updated the diff for D79272: [mlir][StandardToSPIRV] Emulate bitwidths not supported for store op..

Address comments

May 4 2020, 3:37 PM · Restricted Project

May 1 2020

hanchung created D79272: [mlir][StandardToSPIRV] Emulate bitwidths not supported for store op..
May 1 2020, 5:13 PM · Restricted Project

Apr 30 2020

hanchung committed rGbe0ad5b034b2: [mlir][StandardToSPIRV] Add support for lowering integer casting. (authored by hanchung).
[mlir][StandardToSPIRV] Add support for lowering integer casting.
Apr 30 2020, 7:33 PM
hanchung closed D79143: [mlir][StandardToSPIRV] Add support for lowering integer casting..
Apr 30 2020, 7:33 PM · Restricted Project
hanchung committed rG6601b65aedd0: [mlir][StandardToSPIRV] Emulate bitwidths not supported for load op. (authored by hanchung).
[mlir][StandardToSPIRV] Emulate bitwidths not supported for load op.
Apr 30 2020, 7:33 PM
hanchung closed D78974: [mlir][StandardToSPIRV] Emulate bitwidths not supported for load op..
Apr 30 2020, 7:33 PM · Restricted Project
hanchung updated the summary of D79143: [mlir][StandardToSPIRV] Add support for lowering integer casting..
Apr 30 2020, 3:38 PM · Restricted Project
hanchung updated the diff for D79143: [mlir][StandardToSPIRV] Add support for lowering integer casting..

Address comments.

Apr 30 2020, 3:38 PM · Restricted Project
hanchung added inline comments to D79143: [mlir][StandardToSPIRV] Add support for lowering integer casting..
Apr 30 2020, 3:38 PM · Restricted Project
hanchung added inline comments to D78974: [mlir][StandardToSPIRV] Emulate bitwidths not supported for load op..
Apr 30 2020, 3:38 PM · Restricted Project
hanchung updated the diff for D78974: [mlir][StandardToSPIRV] Emulate bitwidths not supported for load op..

Address comments. Also found that scalar is not the case, so we can remove some checks and make the logic simpler.

Apr 30 2020, 3:08 PM · Restricted Project