User Details
User Details
- User Since
- Jan 7 2020, 8:20 PM (124 w, 2 d)
Yesterday
Yesterday
hanchung committed rG5aefdafccf33: [mlir][Linalg] Relax vectorization condition to allow transposed output. (authored by hanchung).
[mlir][Linalg] Relax vectorization condition to allow transposed output.
hanchung updated the diff for D126454: [mlir][Linalg] Relax vectorization condition to allow transposed output..
fix test
hanchung added a reviewer for D126454: [mlir][Linalg] Relax vectorization condition to allow transposed output.: dcaballe.
Tue, May 24
Tue, May 24
Mon, May 9
Mon, May 9
hanchung committed rGad7c49bef774: [mlir][linalg] Fix padding size calculation for Conv2d ops. (authored by pzread).
[mlir][linalg] Fix padding size calculation for Conv2d ops.
Wed, May 4
Wed, May 4
Nice fix!
Tue, May 3
Tue, May 3
hanchung accepted D124849: [mlir][bufferize] Allow in-place bufferization for writes to init_tensors in loops.
`linalg.init_tensor` is an operation that materializes a tensor of a given shape. The shape could be dynamic or static.
hanchung committed rG919e459f1ba3: [Linalg] Remove Optional from getStaticLoopRanges interface method. (authored by hanchung).
[Linalg] Remove Optional from getStaticLoopRanges interface method.
hanchung added inline comments to D124596: [Linalg] Remove Optional from getStaticLoopRanges interface method..
hanchung updated the diff for D124596: [Linalg] Remove Optional from getStaticLoopRanges interface method..
add asserts
Thu, Apr 28
Thu, Apr 28
hanchung updated the diff for D124596: [Linalg] Remove Optional from getStaticLoopRanges interface method..
update comments
Wed, Apr 27
Wed, Apr 27
hanchung added reviewers for D124596: [Linalg] Remove Optional from getStaticLoopRanges interface method.: springerm, antiagainst.
hanchung requested review of D124596: [Linalg] Remove Optional from getStaticLoopRanges interface method..
Apr 26 2022
Apr 26 2022
Apr 25 2022
Apr 25 2022
Thanks!
Apr 15 2022
Apr 15 2022
Apr 8 2022
Apr 8 2022
Apr 5 2022
Apr 5 2022
hanchung committed rG96e9b6c9dc60: Revert "[mlir] Rewrite canonicalization of collapse(expand) and expand… (authored by hanchung).
Revert "[mlir] Rewrite canonicalization of collapse(expand) and expand…
hanchung added a comment to D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..
I think there are bugs in the commit. The verifier failed with the commit. To repro:
Apr 4 2022
Apr 4 2022
Mar 31 2022
Mar 31 2022
Overall looks good to me, just few nits. :)
Mar 29 2022
Mar 29 2022
Mar 24 2022
Mar 24 2022
Mar 23 2022
Mar 23 2022
Mar 14 2022
Mar 14 2022
Mar 8 2022
Mar 8 2022
Mar 7 2022
Mar 7 2022
hanchung committed rG1538bd518cd2: [mlir][Vector] Add patterns to reorder elementwise ops and broadcast/transpose… (authored by hanchung).
[mlir][Vector] Add patterns to reorder elementwise ops and broadcast/transpose…
Mar 7 2022, 12:52 PM · Restricted Project
hanchung added inline comments to D120760: [mlir][Vector] Add patterns to reorder elementwise ops and broadcast/transpose ops..
hanchung updated the diff for D120760: [mlir][Vector] Add patterns to reorder elementwise ops and broadcast/transpose ops..
Update comments
hanchung updated the diff for D120760: [mlir][Vector] Add patterns to reorder elementwise ops and broadcast/transpose ops..
Add more comments and remove template types
Mar 3 2022
Mar 3 2022
hanchung added inline comments to D120760: [mlir][Vector] Add patterns to reorder elementwise ops and broadcast/transpose ops..
hanchung updated the diff for D120760: [mlir][Vector] Add patterns to reorder elementwise ops and broadcast/transpose ops..
Address comments
Mar 1 2022
Mar 1 2022
Feb 25 2022
Feb 25 2022
hanchung committed rG748bf4bb289b: [mlir][Linalg] Add support for tileFuseAndDistribute on tensors. (authored by hanchung).
[mlir][Linalg] Add support for tileFuseAndDistribute on tensors.
Feb 25 2022, 11:51 AM · Restricted Project
hanchung updated the diff for D120441: [mlir][Linalg] Add support for tileFuseAndDistribute on tensors..
rebase
Feb 25 2022, 10:52 AM · Restricted Project
Feb 24 2022
Feb 24 2022
hanchung updated the diff for D120441: [mlir][Linalg] Add support for tileFuseAndDistribute on tensors..
Address comments
Feb 24 2022, 4:14 PM · Restricted Project
Feb 23 2022
Feb 23 2022
hanchung added inline comments to D120441: [mlir][Linalg] Add support for tileFuseAndDistribute on tensors..
Feb 23 2022, 4:08 PM · Restricted Project
hanchung requested review of D120441: [mlir][Linalg] Add support for tileFuseAndDistribute on tensors..
Feb 23 2022, 4:06 PM · Restricted Project
Feb 14 2022
Feb 14 2022
hanchung updated the diff for D119390: [mlir][linalg] Propagate static padding informations through Linalg ops..
address comments
Feb 9 2022
Feb 9 2022
hanchung planned changes to D119211: Enhance pad transform to handle scf.for producers..
We might want https://reviews.llvm.org/D119390 instead because scf.for iter types might change during runtime.
hanchung added a reviewer for D119390: [mlir][linalg] Propagate static padding informations through Linalg ops.: gysit.
hanchung published D119390: [mlir][linalg] Propagate static padding informations through Linalg ops. for review.
Feb 8 2022
Feb 8 2022
hanchung updated the diff for D119211: Enhance pad transform to handle scf.for producers..
Address comments
Feb 7 2022
Feb 7 2022
hanchung published D119211: Enhance pad transform to handle scf.for producers. for review.
Jan 24 2022
Jan 24 2022
Jan 24 2022, 5:25 PM · Restricted Project
Dec 16 2021
Dec 16 2021
hanchung accepted D115196: [mlir][tosa] Support dynamic batch dimension for ops where the batch dim is explicit.
Dec 16 2021, 5:44 PM · Restricted Project
Dec 15 2021
Dec 15 2021
hanchung committed rG501674dc3b14: [mlir][Vector] Further fix to avoid infinite loop in… (authored by hanchung).
[mlir][Vector] Further fix to avoid infinite loop in…
hanchung closed D115820: [mlir][Vector] Further fix to avoid infinite loop in InnerOuterDimReductionConversion.
Dec 15 2021, 1:55 PM · Restricted Project
hanchung retitled D115820: [mlir][Vector] Further fix to avoid infinite loop in InnerOuterDimReductionConversion from [mlir][Vector] Further fix to Avoid infinite loop in InnerOuterDimReductionConversion to [mlir][Vector] Further fix to avoid infinite loop in InnerOuterDimReductionConversion.
Dec 15 2021, 1:02 PM · Restricted Project
hanchung requested review of D115820: [mlir][Vector] Further fix to avoid infinite loop in InnerOuterDimReductionConversion.
Dec 15 2021, 12:03 PM · Restricted Project
Dec 8 2021
Dec 8 2021
Dec 8 2021, 10:27 AM · Restricted Project
Dec 7 2021
Dec 7 2021
hanchung requested changes to D115196: [mlir][tosa] Support dynamic batch dimension for ops where the batch dim is explicit.
Dec 7 2021, 10:49 AM · Restricted Project
Nov 3 2021
Nov 3 2021
Nov 3 2021, 10:08 AM · Restricted Project
Nov 1 2021
Nov 1 2021
hanchung added inline comments to D110262: [mlir][linalg] Add support for transitive fusion..
Nov 1 2021, 5:16 PM · Restricted Project
Nov 1 2021, 3:25 PM · Restricted Project
hanchung added a comment to D110262: [mlir][linalg] Add support for transitive fusion..
This is the PR I'm looking for, thanks!
Nov 1 2021, 3:24 PM · Restricted Project
Oct 26 2021
Oct 26 2021
hanchung accepted D112560: [mlir][python] Segment MLIR Python test dialect to avoid testonly dependency..
Thanks for the fix!
Oct 26 2021, 10:20 AM · Restricted Project
Jul 30 2021
Jul 30 2021
Jul 30 2021, 1:46 PM · Restricted Project
Jul 30 2021, 1:45 PM · Restricted Project
Jul 30 2021, 1:42 PM · Restricted Project
Jul 29 2021
Jul 29 2021
Jul 29 2021, 12:05 PM · Restricted Project
Nice cleanup!
Jul 29 2021, 12:02 PM · Restricted Project
Jul 29 2021, 12:01 PM · Restricted Project
Jul 22 2021
Jul 22 2021
hanchung added inline comments to D105940: [mlir][tosa] Tosa shape propagation for tosa.cond_if.
Jul 22 2021, 3:13 PM · Restricted Project
LGTM if adding a roundtrip test to mlir/test/Dialect/Linalg/named-ops.mlir.
Jul 22 2021, 3:02 PM · Restricted Project
Jul 21 2021
Jul 21 2021
hanchung requested changes to D106407: [mlir][tosa] Quantized Conv2DOp lowering to linalg added..
We should add a roundtrip test when adding a new op. You can add it to mlir/test/Dialect/Linalg/named-ops.mlir
Jul 21 2021, 12:37 PM · Restricted Project
Jul 20 2021
Jul 20 2021
hanchung committed rG3de06260f746: [mlir][Linalg] Update signatures of the callback functions. (authored by hanchung).
[mlir][Linalg] Update signatures of the callback functions.
Jul 20 2021, 5:03 PM · Restricted Project
hanchung added inline comments to D106322: [mlir][Linalg] Update signatures of the callback functions..
Jul 20 2021, 4:31 PM · Restricted Project
hanchung updated the diff for D106322: [mlir][Linalg] Update signatures of the callback functions..
adjust comments a bit
Jul 20 2021, 4:29 PM · Restricted Project
Jul 19 2021
Jul 19 2021
hanchung requested review of D106322: [mlir][Linalg] Update signatures of the callback functions..
Jul 19 2021, 4:15 PM · Restricted Project
hanchung committed rG9c49195330d7: [mlir][Linalg] Migrate 2D pooling ops from tc definition to yaml definition. (authored by hanchung).
[mlir][Linalg] Migrate 2D pooling ops from tc definition to yaml definition.
hanchung closed D106181: [mlir][Linalg] Migrate 2D pooling ops from tc definition to yaml definition..
Jul 19 2021, 9:24 AM · Restricted Project
Jul 16 2021
Jul 16 2021
hanchung updated the diff for D106181: [mlir][Linalg] Migrate 2D pooling ops from tc definition to yaml definition..
update test
Jul 16 2021, 5:10 PM · Restricted Project
hanchung accepted D106132: [mlir][Linalg] NFC: Rename FusionOfTensors pass to FusionOfElementwiseOps pass..
Jul 16 2021, 12:55 PM · Restricted Project