Page MenuHomePhabricator

hanchung (Han-Chung Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 8:20 PM (168 w, 2 d)

Recent Activity

Mon, Mar 20

hanchung accepted D146439: [mlir][Tensor] Make `TilingInterface` implementation only return handle to the created `pad` operation..
Mon, Mar 20, 11:54 AM · Restricted Project, Restricted Project
hanchung accepted D146440: [mlir][Tensor] Avoid dropping attributes for `tensor.pad` operations during canonicalization..
Mon, Mar 20, 11:50 AM · Restricted Project, Restricted Project
hanchung accepted D146254: Changes to `SCFFuseProducerOfSliceResult` to also return the operations created during fusion..
Mon, Mar 20, 11:44 AM · Restricted Project, Restricted Project

Tue, Mar 14

hanchung added a comment to D145744: [linalg] Fixed tosa-to-linalg-named for tosa.conv2d i8 with i8 bias.

I think Rob has more context about it.

Tue, Mar 14, 1:24 PM · Restricted Project, Restricted Project
hanchung edited reviewers for D145744: [linalg] Fixed tosa-to-linalg-named for tosa.conv2d i8 with i8 bias, added: rsuderman; removed: hanchung.
Tue, Mar 14, 1:24 PM · Restricted Project, Restricted Project

Thu, Mar 9

hanchung committed rGbe76f6bef835: [mlir][tensor] Expose padding requirement of pack ops to a static method (authored by hanchung).
[mlir][tensor] Expose padding requirement of pack ops to a static method
Thu, Mar 9, 10:04 AM · Restricted Project, Restricted Project
hanchung closed D145522: [mlir][tensor] Expose padding requirement of pack ops to a static method.
Thu, Mar 9, 10:04 AM · Restricted Project, Restricted Project

Wed, Mar 8

hanchung added a comment to D145625: [mlir] Relaxing verification of DPS ops.

I'm not convinced that this is the fix... The result type and operand type should match based on my understanding about DSP interface. (I could be wrong though)

Wed, Mar 8, 4:15 PM · Restricted Project, Restricted Project
hanchung committed rG991945f4410a: [mlir][linalg] Downscale 2D convolution with unit dimensions to 1D convolution (authored by devajith-huawei).
[mlir][linalg] Downscale 2D convolution with unit dimensions to 1D convolution
Wed, Mar 8, 2:32 PM · Restricted Project, Restricted Project
hanchung closed D145162: [mlir][linalg] Downscale 2D convolution with unit dimensions to 1D convolution.
Wed, Mar 8, 2:32 PM · Restricted Project, Restricted Project
hanchung committed rG5299953ababd: [mlir][linalg] Add vectorization support for conv_1d (authored by devajith-huawei).
[mlir][linalg] Add vectorization support for conv_1d
Wed, Mar 8, 2:24 PM · Restricted Project, Restricted Project
hanchung closed D145160: [mlir][linalg] Add vectorization support for conv_1d.
Wed, Mar 8, 2:23 PM · Restricted Project, Restricted Project
hanchung added a comment to D145160: [mlir][linalg] Add vectorization support for conv_1d.

It will be great if someone can commit this for me (if it is good to go).

Wed, Mar 8, 12:39 PM · Restricted Project, Restricted Project

Tue, Mar 7

hanchung updated the summary of D145522: [mlir][tensor] Expose padding requirement of pack ops to a static method.
Tue, Mar 7, 11:40 AM · Restricted Project, Restricted Project
hanchung requested review of D145522: [mlir][tensor] Expose padding requirement of pack ops to a static method.
Tue, Mar 7, 11:39 AM · Restricted Project, Restricted Project

Mon, Mar 6

hanchung accepted D145160: [mlir][linalg] Add vectorization support for conv_1d.
Mon, Mar 6, 10:14 AM · Restricted Project, Restricted Project
hanchung accepted D145162: [mlir][linalg] Downscale 2D convolution with unit dimensions to 1D convolution.
Mon, Mar 6, 10:09 AM · Restricted Project, Restricted Project
hanchung accepted D145133: [mlir][TilingInterface] Modify `TilingInterface` methods to better return the state of the transformed IR..
Mon, Mar 6, 10:04 AM · Restricted Project, Restricted Project

Wed, Mar 1

hanchung added a comment to rG201b7858f695: [AArch64] Disable aarch64-enable-gep-opt.

Hello. The original commit and the revert of this seem to have caused quite a lot of performance changes. Do you know by any chance what the difference between the code was? And by chance do you know if it was the SplittingGeps pass, LICM or CSE that gave the increase?

Wed, Mar 1, 6:20 PM · Restricted Project, Restricted Project

Tue, Feb 28

hanchung added a comment to rG201b7858f695: [AArch64] Disable aarch64-enable-gep-opt.

Hey @dmgreen, this is Hanhan working on IREE team (which is a MLIR based compiler project). We've noticed that this commit causes regressions in our tracking models. If there was a way to do control this flag through the C++ API, that would help us configure the options during setup of target machine easier. Could you help expose the option or give us some advices on how we can control the flag through some C++ API? Thank you!

Tue, Feb 28, 9:04 PM · Restricted Project, Restricted Project

Feb 28 2023

hanchung accepted D144989: [MLIR][Linalg] Fix propagation for rank-zero tensor.
Feb 28 2023, 1:30 PM · Restricted Project, Restricted Project

Feb 23 2023

hanchung committed rG4d0365101f98: [mlir][tensor] Improve size inference in tiling tensor.pack ops. (authored by hanchung).
[mlir][tensor] Improve size inference in tiling tensor.pack ops.
Feb 23 2023, 10:35 AM · Restricted Project, Restricted Project
hanchung closed D144604: [mlir][tensor] Improve size inference in tiling tensor.pack ops..
Feb 23 2023, 10:35 AM · Restricted Project, Restricted Project
hanchung abandoned D144067: [mlir][linalg] Add more shape information for tensor.pack generalization.
Feb 23 2023, 10:24 AM · Restricted Project, Restricted Project

Feb 22 2023

hanchung added a comment to D144067: [mlir][linalg] Add more shape information for tensor.pack generalization.

https://reviews.llvm.org/D144604 is a better fix.

Feb 22 2023, 5:02 PM · Restricted Project, Restricted Project
hanchung requested review of D144604: [mlir][tensor] Improve size inference in tiling tensor.pack ops..
Feb 22 2023, 5:02 PM · Restricted Project, Restricted Project
hanchung accepted D144425: [mlir][tensor] Fix transpose permutation in tensor.pack generalization pattern.
Feb 22 2023, 11:29 AM · Restricted Project, Restricted Project

Feb 21 2023

hanchung requested changes to D144425: [mlir][tensor] Fix transpose permutation in tensor.pack generalization pattern.
Feb 21 2023, 2:41 PM · Restricted Project, Restricted Project
hanchung accepted D144443: [mlir][linalg] Allow constant exprs in pack/unpack propagation through elementwise.

LGTM

Feb 21 2023, 2:30 PM · Restricted Project, Restricted Project
hanchung added a reviewer for D144425: [mlir][tensor] Fix transpose permutation in tensor.pack generalization pattern: chelini.
Feb 21 2023, 1:08 PM · Restricted Project, Restricted Project
hanchung added a reviewer for D144443: [mlir][linalg] Allow constant exprs in pack/unpack propagation through elementwise: chelini.
Feb 21 2023, 1:08 PM · Restricted Project, Restricted Project
hanchung accepted D144246: [MLIR][Linalg] Change insertion point for `bubbleUpPackOpThroughElemGenericOp`.
Feb 21 2023, 1:07 PM · Restricted Project, Restricted Project

Feb 17 2023

hanchung added inline comments to D144246: [MLIR][Linalg] Change insertion point for `bubbleUpPackOpThroughElemGenericOp`.
Feb 17 2023, 2:11 PM · Restricted Project, Restricted Project
hanchung added a comment to D144067: [mlir][linalg] Add more shape information for tensor.pack generalization.

This seems strange to me. There is nothing that prevents a subsequent transformation to collapse the cast into the slice. Indeed it is probably better to do so.

Feb 17 2023, 2:02 PM · Restricted Project, Restricted Project
hanchung committed rG5fa9933c13e7: [mlir][tensor] Do not use affine ops on non-perfect-tiling unpack cases. (authored by hanchung).
[mlir][tensor] Do not use affine ops on non-perfect-tiling unpack cases.
Feb 17 2023, 11:08 AM · Restricted Project, Restricted Project
hanchung closed D144151: [mlir][tensor] Do not use affine ops on non-perfect-tiling unpack cases..
Feb 17 2023, 11:08 AM · Restricted Project, Restricted Project

Feb 16 2023

hanchung added a comment to D144151: [mlir][tensor] Do not use affine ops on non-perfect-tiling unpack cases..

This is a similar fix to the issue we found in iree_linalg_ext.unpack version: https://github.com/iree-org/iree/issues/11607

Feb 16 2023, 2:30 PM · Restricted Project, Restricted Project
hanchung updated the diff for D144067: [mlir][linalg] Add more shape information for tensor.pack generalization.

rebase

Feb 16 2023, 11:21 AM · Restricted Project, Restricted Project
hanchung updated the diff for D144151: [mlir][tensor] Do not use affine ops on non-perfect-tiling unpack cases..

rebase

Feb 16 2023, 11:20 AM · Restricted Project, Restricted Project
hanchung committed rGc6c41c31f1e5: [mlir][linalg][tensor] Delete duplicate tests and fix typo in filename (authored by hanchung).
[mlir][linalg][tensor] Delete duplicate tests and fix typo in filename
Feb 16 2023, 11:06 AM · Restricted Project, Restricted Project
hanchung closed D144152: [mlir][linalg][tensor] Delete duplicate tests and fix typo in filename.
Feb 16 2023, 11:06 AM · Restricted Project, Restricted Project

Feb 15 2023

hanchung requested review of D144152: [mlir][linalg][tensor] Delete duplicate tests and fix typo in filename.
Feb 15 2023, 5:40 PM · Restricted Project, Restricted Project
hanchung requested review of D144151: [mlir][tensor] Do not use affine ops on non-perfect-tiling unpack cases..
Feb 15 2023, 5:37 PM · Restricted Project, Restricted Project
hanchung committed rGbe75cf931f3f: [mlir][tensor] Fix a bug in tiling unpack op. (authored by hanchung).
[mlir][tensor] Fix a bug in tiling unpack op.
Feb 15 2023, 10:26 AM · Restricted Project, Restricted Project
hanchung closed D143978: [mlir][tensor] Fix a bug in tiling unpack op..
Feb 15 2023, 10:26 AM · Restricted Project, Restricted Project

Feb 14 2023

hanchung requested review of D144067: [mlir][linalg] Add more shape information for tensor.pack generalization.
Feb 14 2023, 6:30 PM · Restricted Project, Restricted Project
hanchung accepted D143907: [MLIR][Tensor] Introduce a pattern to propagate through `tensor.pad`.
Feb 14 2023, 12:09 PM · Restricted Project, Restricted Project
hanchung updated the diff for D143978: [mlir][tensor] Fix a bug in tiling unpack op..

add a test

Feb 14 2023, 10:22 AM · Restricted Project, Restricted Project
hanchung added a comment to D143978: [mlir][tensor] Fix a bug in tiling unpack op..

Do we have a test case to exercise this code path?

Feb 14 2023, 9:54 AM · Restricted Project, Restricted Project

Feb 13 2023

hanchung updated the diff for D143978: [mlir][tensor] Fix a bug in tiling unpack op..

fix clone method

Feb 13 2023, 9:10 PM · Restricted Project, Restricted Project
hanchung requested review of D143978: [mlir][tensor] Fix a bug in tiling unpack op..
Feb 13 2023, 9:06 PM · Restricted Project, Restricted Project
hanchung requested changes to D143907: [MLIR][Tensor] Introduce a pattern to propagate through `tensor.pad`.
Feb 13 2023, 11:13 AM · Restricted Project, Restricted Project
hanchung added a reviewer for D143907: [MLIR][Tensor] Introduce a pattern to propagate through `tensor.pad`: mravishankar.
Feb 13 2023, 11:00 AM · Restricted Project, Restricted Project

Feb 9 2023

hanchung committed rGf71de259c373: [mlir][tensor] Add shape inference methods to tensor::PackOp. (authored by hanchung).
[mlir][tensor] Add shape inference methods to tensor::PackOp.
Feb 9 2023, 5:25 PM · Restricted Project, Restricted Project
hanchung closed D143686: [mlir][tensor] Add shape inference methods to tensor::PackOp..
Feb 9 2023, 5:24 PM · Restricted Project, Restricted Project
hanchung updated the diff for D143686: [mlir][tensor] Add shape inference methods to tensor::PackOp..

update comments

Feb 9 2023, 3:26 PM · Restricted Project, Restricted Project
hanchung requested review of D143686: [mlir][tensor] Add shape inference methods to tensor::PackOp..
Feb 9 2023, 3:25 PM · Restricted Project, Restricted Project
hanchung accepted D143655: [mlir][linalg] Support non-function ops in Detensorize.
Feb 9 2023, 3:25 PM · Restricted Project, Restricted Project

Feb 8 2023

hanchung committed rG061201ec3d6d: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases. (authored by hanchung).
[mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases.
Feb 8 2023, 6:40 PM · Restricted Project, Restricted Project
hanchung closed D143043: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases..
Feb 8 2023, 6:39 PM · Restricted Project, Restricted Project
hanchung updated the diff for D143043: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases..

rebase

Feb 8 2023, 5:49 PM · Restricted Project, Restricted Project
hanchung updated the diff for D143043: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases..

address comments

Feb 8 2023, 5:48 PM · Restricted Project, Restricted Project
hanchung added a comment to D143043: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases..

Thanks for extending!
Could you point me to your usage of this abstraction (offline is fine)?

Feb 8 2023, 5:46 PM · Restricted Project, Restricted Project

Feb 2 2023

hanchung accepted D143244: Fix bazel dependency.
Feb 2 2023, 11:57 PM · Restricted Project, Restricted Project
hanchung accepted D143243: [mlir][linalg] Fix crash in vectorizer when expanding affine apply.
Feb 2 2023, 11:56 PM · Restricted Project, Restricted Project

Jan 31 2023

hanchung updated the diff for D143043: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases..

fix tests

Jan 31 2023, 11:41 PM · Restricted Project, Restricted Project
hanchung updated the diff for D143043: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases..

rebase and fix tests

Jan 31 2023, 9:39 PM · Restricted Project, Restricted Project
hanchung accepted D142889: [mlir][Linalg] Add a transform.structured.lower_unpack op.
Jan 31 2023, 8:41 PM · Restricted Project, Restricted Project
hanchung added inline comments to D142889: [mlir][Linalg] Add a transform.structured.lower_unpack op.
Jan 31 2023, 8:40 PM · Restricted Project, Restricted Project
hanchung updated the diff for D143043: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases..

rebase

Jan 31 2023, 8:36 PM · Restricted Project, Restricted Project
hanchung accepted D142523: [MLIR] Propagate unpack through element-wise ops.

nice work, thanks!

Jan 31 2023, 8:05 PM · Restricted Project, Restricted Project
hanchung added a reviewer for D143043: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases.: mravishankar.
Jan 31 2023, 7:25 PM · Restricted Project, Restricted Project
hanchung requested review of D143043: [mlir][linalg] Enhance padding LinalgOps to handle tensor.empty cases..
Jan 31 2023, 7:25 PM · Restricted Project, Restricted Project

Jan 30 2023

hanchung added inline comments to D142881: [mlir][Linalg] Add a transform.structured.lower_pack op.
Jan 30 2023, 8:34 PM · Restricted Project, Restricted Project
hanchung added inline comments to D142523: [MLIR] Propagate unpack through element-wise ops.
Jan 30 2023, 8:10 PM · Restricted Project, Restricted Project
hanchung accepted D142869: [MLIR] Split `generalize-tensor-pack.mlir` (NFC).
Jan 30 2023, 4:23 PM · Restricted Project, Restricted Project
hanchung accepted D142848: [mlir][Linalg] Make Elementwise op fusion return a map from existing values to values in the fused op..
Jan 30 2023, 4:22 PM · Restricted Project, Restricted Project

Jan 29 2023

hanchung added inline comments to D142848: [mlir][Linalg] Make Elementwise op fusion return a map from existing values to values in the fused op..
Jan 29 2023, 6:32 PM · Restricted Project, Restricted Project

Jan 26 2023

hanchung committed rGadcb98880972: [mlir][tensor] Add a tiling interface registration for pack/unpack only. (authored by hanchung).
[mlir][tensor] Add a tiling interface registration for pack/unpack only.
Jan 26 2023, 5:53 PM · Restricted Project, Restricted Project
hanchung closed D141977: [mlir][tensor] Add a tiling interface registration for pack/unpack only..
Jan 26 2023, 5:53 PM · Restricted Project, Restricted Project

Jan 17 2023

hanchung added reviewers for D141977: [mlir][tensor] Add a tiling interface registration for pack/unpack only.: mravishankar, chelini.
Jan 17 2023, 4:45 PM · Restricted Project, Restricted Project
hanchung requested review of D141977: [mlir][tensor] Add a tiling interface registration for pack/unpack only..
Jan 17 2023, 4:45 PM · Restricted Project, Restricted Project
hanchung accepted D141837: Reduce input arguments for `getPackingInfoFromConsumer` (NFC).
Jan 17 2023, 1:20 PM · Restricted Project, Restricted Project

Jan 13 2023

hanchung accepted D141688: [MLIR] Fix tiling for `tensor.unpack` with outer permutations.

Thanks for fixing this!

Jan 13 2023, 12:56 PM · Restricted Project, Restricted Project

Jan 12 2023

hanchung accepted D141483: [MLIR] Fold outer dims permutation to pack when propagating.
Jan 12 2023, 10:45 AM · Restricted Project, Restricted Project

Jan 11 2023

hanchung added a comment to D141483: [MLIR] Fold outer dims permutation to pack when propagating.

LG, thanks!

Jan 11 2023, 5:14 PM · Restricted Project, Restricted Project
hanchung committed rG65388086e682: [mlir][tensor] Add patterns that fold ops into pack and unpack ops. (authored by hanchung).
[mlir][tensor] Add patterns that fold ops into pack and unpack ops.
Jan 11 2023, 1:52 PM · Restricted Project, Restricted Project
hanchung closed D141099: [mlir][tensor] Add patterns that fold ops into pack and unpack ops..
Jan 11 2023, 1:52 PM · Restricted Project, Restricted Project

Jan 10 2023

hanchung accepted D141123: [MLIR][Tensor] Add canonicalization patterns for `tensor.pack`.
Jan 10 2023, 10:36 PM · Restricted Project, Restricted Project
hanchung accepted D141452: [mlir][vector] Fix crash in extractelement vec distribution.
Jan 10 2023, 6:11 PM · Restricted Project, Restricted Project
hanchung added inline comments to D141099: [mlir][tensor] Add patterns that fold ops into pack and unpack ops..
Jan 10 2023, 4:28 PM · Restricted Project, Restricted Project
hanchung updated the diff for D141099: [mlir][tensor] Add patterns that fold ops into pack and unpack ops..

address comments

Jan 10 2023, 4:28 PM · Restricted Project, Restricted Project
hanchung accepted D141430: [mlir][linalg] Add named op for matmul_transpose_b.
Jan 10 2023, 2:21 PM · Restricted Project, Restricted Project

Jan 9 2023

hanchung added inline comments to D141123: [MLIR][Tensor] Add canonicalization patterns for `tensor.pack`.
Jan 9 2023, 10:47 AM · Restricted Project, Restricted Project

Jan 6 2023

hanchung committed rGead535b2f9ef: [mlir][tensor] Add producer fusion for tensor.unpack op. (authored by hanchung).
[mlir][tensor] Add producer fusion for tensor.unpack op.
Jan 6 2023, 2:13 PM · Restricted Project, Restricted Project
hanchung closed D141151: [mlir][tensor] Add producer fusion for tensor.unpack op..
Jan 6 2023, 2:13 PM · Restricted Project, Restricted Project
hanchung requested review of D141151: [mlir][tensor] Add producer fusion for tensor.unpack op..
Jan 6 2023, 10:52 AM · Restricted Project, Restricted Project

Jan 5 2023

hanchung requested review of D141099: [mlir][tensor] Add patterns that fold ops into pack and unpack ops..
Jan 5 2023, 4:57 PM · Restricted Project, Restricted Project
hanchung accepted D141097: [NFC][MLIR] Adding better names to lit test for pooling vectorization.
Jan 5 2023, 4:08 PM · Restricted Project, Restricted Project
hanchung added inline comments to D140188: [mlir][linalg] Vectorize 1D pooling ops.
Jan 5 2023, 11:21 AM · Restricted Project, Restricted Project