Page MenuHomePhabricator

hanchung (Han-Chung Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 8:20 PM (46 w, 5 d)

Recent Activity

Thu, Nov 19

hanchung accepted D91749: [mlir][Linalg] Add utility function that return static loop bounds of Linalg ops.

few nits, LGTM!

Thu, Nov 19, 12:07 AM · Restricted Project

Wed, Nov 18

hanchung accepted D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

LGTM

Wed, Nov 18, 11:58 PM · Restricted Project

Mon, Nov 16

hanchung accepted D91502: [mlir][Linalg] Add dependence type to LinalgDependenceGraphElem..
Mon, Nov 16, 8:49 AM · Restricted Project
hanchung requested changes to D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Mon, Nov 16, 8:48 AM · Restricted Project
hanchung added inline comments to D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Mon, Nov 16, 8:44 AM · Restricted Project
hanchung committed rG47fd19f22eb5: [mlir][StandardToSPIRV] Extend support for lowering cmpi to SPIRV. (authored by hanchung).
[mlir][StandardToSPIRV] Extend support for lowering cmpi to SPIRV.
Mon, Nov 16, 6:51 AM
hanchung closed D91403: [mlir][StandardToSPIRV] Extend support for lowering cmpi to SPIRV..
Mon, Nov 16, 6:51 AM · Restricted Project

Thu, Nov 12

hanchung requested review of D91403: [mlir][StandardToSPIRV] Extend support for lowering cmpi to SPIRV..
Thu, Nov 12, 10:57 PM · Restricted Project
hanchung requested changes to D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Thu, Nov 12, 12:52 AM · Restricted Project

Wed, Nov 11

hanchung accepted D91101: [mlir][Linalg] Change LinalgDependenceGraph to use LinalgOp..
Wed, Nov 11, 11:47 PM · Restricted Project
hanchung accepted D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..
Wed, Nov 11, 11:46 PM · Restricted Project

Tue, Nov 10

hanchung added inline comments to D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..
Tue, Nov 10, 8:27 AM · Restricted Project

Mon, Nov 9

hanchung accepted D91080: [mlir][spirv] Expose more query APIs directly on TargetEnv.
Mon, Nov 9, 8:29 AM · Restricted Project

Wed, Nov 4

hanchung added inline comments to D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..
Wed, Nov 4, 6:29 AM · Restricted Project

Oct 27 2020

hanchung added a comment to D90082: [mlir][Linalg] Add fusion of IndexedGenericOp with TensorReshapeOp by expansion..

LGTM, thanks!

Oct 27 2020, 11:54 AM · Restricted Project
hanchung accepted D90082: [mlir][Linalg] Add fusion of IndexedGenericOp with TensorReshapeOp by expansion..
Oct 27 2020, 11:54 AM · Restricted Project

Oct 26 2020

hanchung accepted D90118: [mlir][Linalg] Miscalleneous enhancements to cover more fusion cases..

This is great, just two nits. :)

Oct 26 2020, 11:35 AM · Restricted Project

Oct 25 2020

hanchung added inline comments to D90082: [mlir][Linalg] Add fusion of IndexedGenericOp with TensorReshapeOp by expansion..
Oct 25 2020, 9:29 PM · Restricted Project

Oct 12 2020

hanchung accepted D88911: [mlir][Linalg] Lower padding attribute for pooling ops.

Just few nits, thanks for adding this!

Oct 12 2020, 9:13 AM · Restricted Project

Oct 8 2020

hanchung added inline comments to D88911: [mlir][Linalg] Lower padding attribute for pooling ops.
Oct 8 2020, 2:49 AM · Restricted Project

Oct 7 2020

hanchung added a comment to D88911: [mlir][Linalg] Lower padding attribute for pooling ops.

Thanks for adding this! I left two concerns below. I stoped adding this because we could drop padding attributes in the future as @mravishankar mentioned. And there are cases that I don't have answers yet, we can iterate on one of the approach for padding value and revisit padding dimensions later.

Oct 7 2020, 6:40 AM · Restricted Project

Oct 6 2020

hanchung added inline comments to D88869: Relax FuseTensorReshapeOpAsproducer identity mapping constraint.
Oct 6 2020, 2:05 AM · Restricted Project

Sep 22 2020

hanchung accepted D88057: [mlir][Linalg] Add pattern to fold linalg.tensor_reshape that add unit extent dims..

Thanks, just few nits!

Sep 22 2020, 3:33 AM · Restricted Project

Sep 18 2020

hanchung committed rG1909b6ac0dbc: [mlir][StandardToSPIRV] Handle vector of i1 case for lowering zexti to SPIR-V. (authored by hanchung).
[mlir][StandardToSPIRV] Handle vector of i1 case for lowering zexti to SPIR-V.
Sep 18 2020, 7:07 AM
hanchung closed D87887: [mlir][StandardToSPIRV] Handle vector of i1 case for lowering zexti to SPIR-V..
Sep 18 2020, 7:07 AM · Restricted Project
hanchung requested review of D87887: [mlir][StandardToSPIRV] Handle vector of i1 case for lowering zexti to SPIR-V..
Sep 18 2020, 12:37 AM · Restricted Project

Sep 17 2020

hanchung committed rGf16abe5f84ee: [mlir][Vector] Add a folder for vector.broadcast (authored by hanchung).
[mlir][Vector] Add a folder for vector.broadcast
Sep 17 2020, 8:55 AM
hanchung closed D87703: [mlir][Vector] Add a folder for vector.broadcast.
Sep 17 2020, 8:55 AM · Restricted Project

Sep 16 2020

hanchung added inline comments to D87703: [mlir][Vector] Add a folder for vector.broadcast.
Sep 16 2020, 7:27 AM · Restricted Project
hanchung updated the diff for D87703: [mlir][Vector] Add a folder for vector.broadcast.

Use getVectorType() instead

Sep 16 2020, 7:27 AM · Restricted Project
hanchung added inline comments to D87703: [mlir][Vector] Add a folder for vector.broadcast.
Sep 16 2020, 4:16 AM · Restricted Project
hanchung updated the diff for D87703: [mlir][Vector] Add a folder for vector.broadcast.

Add more checks on tests and handle constants properly.

Sep 16 2020, 4:15 AM · Restricted Project
hanchung updated the summary of D87703: [mlir][Vector] Add a folder for vector.broadcast.
Sep 16 2020, 1:48 AM · Restricted Project
hanchung added inline comments to D87703: [mlir][Vector] Add a folder for vector.broadcast.
Sep 16 2020, 1:47 AM · Restricted Project
hanchung updated the diff for D87703: [mlir][Vector] Add a folder for vector.broadcast.

Handle splat constants.

Sep 16 2020, 1:46 AM · Restricted Project
hanchung updated the diff for D87703: [mlir][Vector] Add a folder for vector.broadcast.

Remove the propagatin of vector.broadcast

Sep 16 2020, 1:30 AM · Restricted Project

Sep 15 2020

hanchung updated the summary of D87703: [mlir][Vector] Add a folder for vector.broadcast.
Sep 15 2020, 9:25 AM · Restricted Project
hanchung updated the diff for D87703: [mlir][Vector] Add a folder for vector.broadcast.

Fix test

Sep 15 2020, 9:23 AM · Restricted Project
hanchung requested review of D87703: [mlir][Vector] Add a folder for vector.broadcast.
Sep 15 2020, 8:31 AM · Restricted Project

Sep 3 2020

hanchung accepted D87090: [spirv][nfc] Simplify resource limit with default values.
Sep 3 2020, 8:48 AM · Restricted Project

Aug 28 2020

hanchung committed rGeb4efa883212: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op. (authored by hanchung).
[mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op.
Aug 28 2020, 1:56 AM
hanchung closed D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..
Aug 28 2020, 1:56 AM · Restricted Project

Aug 27 2020

hanchung added inline comments to D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..
Aug 27 2020, 11:13 PM · Restricted Project
hanchung updated the diff for D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..

Address comments

Aug 27 2020, 11:13 PM · Restricted Project
hanchung updated the diff for D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..

rebase

Aug 27 2020, 7:50 AM · Restricted Project
hanchung added inline comments to D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..
Aug 27 2020, 7:05 AM · Restricted Project
hanchung added inline comments to D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..
Aug 27 2020, 3:09 AM · Restricted Project
hanchung updated the diff for D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..

Address comments

Aug 27 2020, 3:09 AM · Restricted Project

Aug 24 2020

hanchung added inline comments to D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..
Aug 24 2020, 2:10 AM · Restricted Project
hanchung updated the diff for D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..

Address comments

Aug 24 2020, 2:10 AM · Restricted Project

Aug 20 2020

hanchung updated the diff for D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..

Fix test

Aug 20 2020, 1:06 PM · Restricted Project
hanchung requested review of D86314: [mlir][Linalg] Enhance Linalg fusion on generic op and tensor_reshape op..
Aug 20 2020, 12:45 PM · Restricted Project

Aug 18 2020

hanchung added inline comments to D86095: [mlir][Linalg] Modify callback for getting id/nprocs in LinalgDistribution options to allow more general distributions..
Aug 18 2020, 8:00 AM · Restricted Project

Jul 27 2020

hanchung accepted D84566: [mlir][Linalg] Enable fusion of std.constant (producer) with linalg.indexed_generic (consumer) with tensor arguments..

Thanks Mahesh! Just few nits.

Jul 27 2020, 12:33 AM · Restricted Project

Jul 14 2020

hanchung accepted D83714: [mlir][StandardToSPIRV] Use spv.UMod for index re-calculation.
Jul 14 2020, 8:21 AM · Restricted Project

Jul 13 2020

hanchung added inline comments to D83679: [mlir][StandardToSPIRV] Fix conversion for signed remainder.
Jul 13 2020, 9:43 AM · Restricted Project
hanchung abandoned D74365: [mlir][Linalg] Update semantics for Linalg generic ops with tensors..
Jul 13 2020, 9:37 AM · Restricted Project, Restricted Project
hanchung abandoned D77286: [mlir] Enable fusion on conv op if it is a consumer..
Jul 13 2020, 9:37 AM · Restricted Project, Restricted Project

Jun 26 2020

hanchung added inline comments to D82619: [mlir][spirv] Add lowering of std alloca to SPIR-V.
Jun 26 2020, 12:31 AM · Restricted Project

Jun 22 2020

hanchung committed rG809bcf4c87d0: [mlir] Fix a doc link in LinalgBase.td (authored by hanchung).
[mlir] Fix a doc link in LinalgBase.td
Jun 22 2020, 11:50 AM
hanchung closed D82303: [mlir] Fix a doc link in LinalgBase.td.
Jun 22 2020, 11:50 AM · Restricted Project
hanchung created D82303: [mlir] Fix a doc link in LinalgBase.td.
Jun 22 2020, 8:02 AM · Restricted Project

Jun 18 2020

hanchung committed rG9cb10296ecaa: [mlir] Add support for lowering tanh to LLVMIR. (authored by hanchung).
[mlir] Add support for lowering tanh to LLVMIR.
Jun 18 2020, 10:54 AM
hanchung closed D82040: [mlir] Add support for expanding tanh op into exp form..
Jun 18 2020, 10:54 AM · Restricted Project
hanchung updated the diff for D82040: [mlir] Add support for expanding tanh op into exp form..

Remove unneeded include from mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp

Jun 18 2020, 9:45 AM · Restricted Project

Jun 17 2020

hanchung retitled D82040: [mlir] Add support for expanding tanh op into exp form. from [mlir] Add support for lowering tanh to LLVMIR. to [mlir] Add support for expanding tanh op into exp form..
Jun 17 2020, 12:56 PM · Restricted Project
hanchung updated the diff for D82040: [mlir] Add support for expanding tanh op into exp form..

Remove the pattern from ConvertLinalgToLLVMPass.

Jun 17 2020, 12:56 PM · Restricted Project
hanchung added a reviewer for D82040: [mlir] Add support for expanding tanh op into exp form.: asaadaldien.
Jun 17 2020, 12:24 PM · Restricted Project
hanchung added a comment to D82040: [mlir] Add support for expanding tanh op into exp form..

Oh wait me a sec, I think I should populate the pattern at populateStdToLLVMConversionPatterns, not in LinalgToLLVM.cpp file. Let me fix it.

Jun 17 2020, 12:24 PM · Restricted Project
hanchung added a comment to D82040: [mlir] Add support for expanding tanh op into exp form..

It's fixed by adding a missing dep in mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt

Jun 17 2020, 12:24 PM · Restricted Project
hanchung created D82040: [mlir] Add support for expanding tanh op into exp form..
Jun 17 2020, 12:24 PM · Restricted Project

Jun 15 2020

hanchung added a comment to D81618: [mlir] Add support for lowering tanh to LLVMIR..

Reverted in a9a21bb4b682474248dc85f9e7db4b260d249ab9 ; the standalone test was broken

Jun 15 2020, 4:02 PM · Restricted Project
hanchung committed rG487ca07fcc75: [mlir][NFC] Fix file comments. (authored by hanchung).
[mlir][NFC] Fix file comments.
Jun 15 2020, 2:57 PM
hanchung closed D81858: [mlir][NFC] Fix file comments..
Jun 15 2020, 2:57 PM · Restricted Project
hanchung created D81858: [mlir][NFC] Fix file comments..
Jun 15 2020, 11:31 AM · Restricted Project
hanchung committed rG32c757e4f808: [mlir] Add support for lowering tanh to LLVMIR. (authored by hanchung).
[mlir] Add support for lowering tanh to LLVMIR.
Jun 15 2020, 10:58 AM
hanchung closed D81618: [mlir] Add support for lowering tanh to LLVMIR..
Jun 15 2020, 10:56 AM · Restricted Project

Jun 12 2020

hanchung retitled D81618: [mlir] Add support for lowering tanh to LLVMIR. from [mlir][StandardToLLVM] Add support for lowering tanh to LLVMIR. to [mlir] Add support for lowering tanh to LLVMIR..
Jun 12 2020, 12:35 PM · Restricted Project
hanchung added inline comments to D81618: [mlir] Add support for lowering tanh to LLVMIR..
Jun 12 2020, 12:07 PM · Restricted Project
hanchung updated the diff for D81618: [mlir] Add support for lowering tanh to LLVMIR..

Address comments.

Jun 12 2020, 12:06 PM · Restricted Project

Jun 11 2020

hanchung updated the diff for D81618: [mlir] Add support for lowering tanh to LLVMIR..

Add missing files...

Jun 11 2020, 7:15 PM · Restricted Project
hanchung added a comment to D81618: [mlir] Add support for lowering tanh to LLVMIR..

Thanks for the advice, I think it's better now. :)

Jun 11 2020, 7:15 PM · Restricted Project
hanchung updated the diff for D81618: [mlir] Add support for lowering tanh to LLVMIR..

Add a test

Jun 11 2020, 7:15 PM · Restricted Project
hanchung updated the diff for D81618: [mlir] Add support for lowering tanh to LLVMIR..

Add expanding tanh pattern to StandardOps/Transforms/

Jun 11 2020, 6:43 PM · Restricted Project

Jun 10 2020

hanchung created D81618: [mlir] Add support for lowering tanh to LLVMIR..
Jun 10 2020, 4:08 PM · Restricted Project

Jun 9 2020

hanchung abandoned D81317: [mlir][StandardToSPIRV] Handle i1 case for lowering std.load op and std.store op.

Should we drop this for now given this is not the preferred way to go?

Jun 9 2020, 9:29 PM · Restricted Project

Jun 5 2020

hanchung created D81317: [mlir][StandardToSPIRV] Handle i1 case for lowering std.load op and std.store op.
Jun 5 2020, 4:16 PM · Restricted Project

Jun 3 2020

hanchung committed rG0b025d2733d0: [mlir][StandardToSPIRV] Handle i1 case for lowering std.zexti to SPIR-V. (authored by hanchung).
[mlir][StandardToSPIRV] Handle i1 case for lowering std.zexti to SPIR-V.
Jun 3 2020, 3:30 PM
hanchung committed rGcc11ceda165b: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic… (authored by hanchung).
[mlir][Linalg] Add support for fusion between indexed_generic ops and generic…
Jun 3 2020, 3:30 PM
hanchung committed rG27fca57546c2: [mlir][Linalg] Add support for fusion between indexed_generic ops and… (authored by hanchung).
[mlir][Linalg] Add support for fusion between indexed_generic ops and…
Jun 3 2020, 3:30 PM
hanchung closed D80965: [mlir][StandardToSPIRV] Handle i1 case for lowering std.zexti to SPIR-V..
Jun 3 2020, 3:29 PM · Restricted Project
hanchung closed D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..
Jun 3 2020, 3:29 PM · Restricted Project, Restricted Project
hanchung closed D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops.
Jun 3 2020, 3:29 PM · Restricted Project, Restricted Project

Jun 2 2020

hanchung updated the summary of D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..
Jun 2 2020, 10:57 AM · Restricted Project, Restricted Project

Jun 1 2020

hanchung created D80965: [mlir][StandardToSPIRV] Handle i1 case for lowering std.zexti to SPIR-V..
Jun 1 2020, 5:21 PM · Restricted Project
hanchung updated the diff for D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops.

rebase

Jun 1 2020, 2:39 PM · Restricted Project, Restricted Project
hanchung updated the diff for D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..

rebase

Jun 1 2020, 2:39 PM · Restricted Project, Restricted Project

May 27 2020

hanchung updated the diff for D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..

Address comments.

May 27 2020, 3:16 PM · Restricted Project, Restricted Project
hanchung added inline comments to D80347: [mlir][Linalg] Add support for fusion between indexed_generic ops and generic ops on tensors..
May 27 2020, 3:16 PM · Restricted Project, Restricted Project

May 26 2020

hanchung added a comment to D80348: [mlir][Linalg] Add support for fusion between indexed_generic ops and tensor_reshape ops.

Good to know that this minimal change works as expected (I hoped it would). Thanks for adding tests.
Based on the previous patch in this stack, if we can combine the methods for fusion of generic/indexed-generic producer/consumer then I think this change will not be needed. The tests are still useful though. Will wait to review this again after that.

May 26 2020, 5:28 PM · Restricted Project, Restricted Project