This is an archive of the discontinued LLVM Phabricator instance.

[4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32
ClosedPublic

Authored by eopXD on Apr 7 2023, 2:24 AM.

Details

Summary

For the cover letter of this patch-set, please checkout D146872.

Depends on D147731.

This is the 4th patch of the patch-set.

This patch is a proof-of-concept and will be extended to full coverage
in the future. Currently, the old non-tuple unit-stride segment store is
not removed, and only signed integer unit-strided segment store of NF=2,
EEW=32 is defined here.

Diff Detail

Event Timeline

eopXD created this revision.Apr 7 2023, 2:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2023, 2:24 AM
eopXD requested review of this revision.Apr 7 2023, 2:24 AM
eopXD updated this revision to Diff 511891.Apr 8 2023, 7:27 AM

Minor code change: Separate defm of segment load and store under riscv_vector.td.

eopXD retitled this revision from [4/N][POC][Clang] Define tuple type variant of vsseg2e32 to [4/11][POC][Clang] Define tuple type variant of vsseg2e32.Apr 10 2023, 12:49 AM
eopXD retitled this revision from [4/11][POC][Clang] Define tuple type variant of vsseg2e32 to [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32.
eopXD updated this revision to Diff 516296.Apr 24 2023, 12:53 AM

Rebase upon update of parent patch.

craig.topper added inline comments.Apr 26 2023, 10:30 AM
clang/include/clang/Basic/riscv_vector.td
1571

Offset variable

eopXD updated this revision to Diff 522928.May 17 2023, 12:28 AM

ddress comment from Craig.

eopXD marked an inline comment as done.May 17 2023, 12:29 AM
evandro removed a subscriber: evandro.May 17 2023, 3:55 PM
craig.topper added inline comments.May 18 2023, 10:40 AM
clang/include/clang/Basic/riscv_vector.td
1571

Similar comment to patch 3. We can index the Ops array directly in the push_back calls instead of having temporary variables.

eopXD updated this revision to Diff 523465.May 18 2023, 11:22 AM

Address comments from Craig.

eopXD marked an inline comment as done.May 18 2023, 11:23 AM
eopXD updated this revision to Diff 523620.May 18 2023, 5:42 PM

Removed another variable that is too verbose.

This revision is now accepted and ready to land.May 18 2023, 6:24 PM
This revision was landed with ongoing or failed builds.May 22 2023, 2:52 AM
This revision was automatically updated to reflect the committed changes.