Emit a 4-byte alignment after the .arm directive and a 2-byte alignment
after the .thumb directive. The new behavior matches GNU assembler.
Fixes #53386
Differential D147763
[ARM] Emit code alignment after .arm and .thumb directives antangelo on Apr 6 2023, 10:30 PM. Authored by
Details Emit a 4-byte alignment after the .arm directive and a 2-byte alignment Fixes #53386
Diff Detail
Event Timeline
Comment Actions Fixed arm-fix-cortex-a8-nopatch test cases, added back a check in -recognized that was accidentally removed I changed the offsets around the .arm directive such that the instruction offsets are the same as before this patch. Comment Actions Tests updates look OK to me. A couple of comments overall.
Comment Actions Rebased, updated release notes, updated .thumb to align to a 2-byte boundary, and added a test case To my knowledge (testing with arm-none-eabi), the GNU assembler aligns code after the .arm directive to the next Comment Actions Rebased and updated the commit message to reflect the .thumb directive changes Also noting that I don't have commit access to commit this myself after the review is completed Comment Actions Sorry for the delay.
Comment Actions Rebase and addressing feedback Updated the release notes syntax, fixed the directive-arm-thumb-alignment test file name, After studying the tests again more closely, to my understanding, the nopatch tests I have verified the offsets in both the nopatch and recognize suites and they match what is currently
Comment Actions Replace offset and strtab size columns with wildcard, remove trailing newline in directive test Comment Actions I don't have commit access to commit the changes myself, if someone can commit on my behalf. My name and email are: Name: Antonio Abbatangelo |
This address adjustment will break what the test wants to check. The tests need a proper update.
@peter.smith