Page MenuHomePhabricator

alanphipps (Alan Phipps)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2019, 11:03 AM (36 w, 1 d)

Recent Activity

May 31 2020

alanphipps added a comment to D79961: [PGO] Fix computation of fuction Hash.

It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read as v6 rather than v5. Can you double check?

May 31 2020, 4:30 PM · Restricted Project, Restricted Project

May 28 2020

alanphipps added a comment to D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list.

clang/test/CodeGen/sanitize-coverage.c is also failing our downstream embedded ARMv7 validations.

May 28 2020, 8:42 AM · Restricted Project, Restricted Project

Jan 21 2020

alanphipps added a comment to D72897: List implicit operator== after implicit destructors in a vtable..

This test is still failing on the arm bots and also with my downstream ARM compiler validation.

Jan 21 2020, 7:44 AM · Restricted Project

Jan 17 2020

alanphipps added a comment to rG03a592f18ba5: TableGen/GlobalISel: Fix srcvalue inputs.

Hello! Your test specifically looks for "248", which is failing with my downstream embedded ARM compiler (we produce "249"); other similar tests that I've looked at simply ignore this value. Is there a reason why you need to check it specifically?

Jan 17 2020, 4:46 PM

Jan 10 2020

alanphipps added a comment to rGcee4a1c95742: Improve support of GNU mempcpy.

Sorry, we just saw your commit to fix. We are OK. Thanks!

Jan 10 2020, 11:29 AM
alanphipps added a comment to rGcee4a1c95742: Improve support of GNU mempcpy.

We maintain a downstream embedded ARM compiler, and this test is failing for us now because it assumes a 64bit size_t in the first CHECK line of the mempcpy-libcall.c. Because this is testing a GNU specific builtin, should it be specific to only targets that support that? Or should it be extended to support 32bit size_t?

Jan 10 2020, 11:27 AM