Page MenuHomePhabricator

alanphipps (Alan Phipps)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2019, 11:03 AM (56 w, 4 d)

Recent Activity

Mon, Nov 23

alanphipps added a comment to D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

Looks like _LIBCPP_HAS_NO_THREADS is being set for libcxxabi, and the build now fails with this change:

Mon, Nov 23, 1:16 PM · Restricted Project
alanphipps updated the diff for D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.

Bump format version and add preliminary documentation for CoverageMappingFormat, SourceBasedCodeCoverage, and llvm-cov tool

Mon, Nov 23, 11:53 AM · Restricted Project, Restricted Project

Thu, Nov 19

alanphipps added a comment to D48811: Fix disassembling ARM instructions as big-endian.

Just checking in again -- is there interest in completing this review? I'd be happy to assist, or I could post an updated version of it.

Thu, Nov 19, 3:43 PM · Restricted Project

Oct 19 2020

alanphipps added a comment to D88307: [DON'T MERGE] Jump-threading for finite state automata.

@eastig I tried this experimental patch in our system, and it definitely brings highly significant improvement to coremark. When do you expect to post a version for reviewing -- what will the differences be?

Oct 19 2020, 3:06 PM · Restricted Project

Oct 8 2020

alanphipps added inline comments to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Oct 8 2020, 8:09 AM · Restricted Project, Restricted Project

Oct 3 2020

alanphipps updated the diff for D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.

Updated diff:
1.) Fix a defect in the CGExprScalar.cpp code to instrument RHS condition for branch coverage that resulted in a RHS condition as being evaluated twice. This is incorrect behavior since a condition may have side-effects. I also added a test.
2.) Back out unintended whitespace/punctuation (please let me know if I overlooked anything).
3.) Rebase against updated upstream.

Oct 3 2020, 6:14 PM · Restricted Project, Restricted Project

Sep 29 2020

alanphipps added a comment to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
In D84467#2264205, @vsk wrote:

@alanphipps thanks for bearing with me. I think this is about ready to land. I do ask that you back out any punctuation/whitespace changes in code/tests that aren't directly modified in your diff (the clang-format-diff script can help with this). It looks like some libCoverage and test changes are no longer in the current version of this patch, as compared to the previous version (https://reviews.llvm.org/D84467?id=287269). Was that intentional?

Sep 29 2020, 3:11 PM · Restricted Project, Restricted Project

Sep 17 2020

alanphipps added a comment to D82995: [UpdateTestChecks] Allow $ in function names.

There exist downstream ARM compilers that doesn't support ARM64 and fail with Inputs/arm_function_name.ll. You should consider guarding arm64 specific tests.

Sep 17 2020, 11:01 AM · Restricted Project

Sep 7 2020

alanphipps updated the diff for D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
  • Rename isLeafCondition() to isInstrumentedCondition() and rephrase associated comments
  • Add branch regions on C++ range-based loops
Sep 7 2020, 9:06 AM · Restricted Project, Restricted Project
alanphipps added inline comments to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Sep 7 2020, 9:03 AM · Restricted Project, Restricted Project

Aug 24 2020

Herald added a project to D48811: Fix disassembling ARM instructions as big-endian: Restricted Project.

I just ran into what I think may be the same issue here in that llvm-objdump seems to ignore machine data (endian, possible mode) when disassembling ARM instructions on ARMv7. Is there any interest in completing this review and committing this particular fix (and making sure it works for ARMv7 as well)?

Aug 24 2020, 4:00 PM · Restricted Project

Aug 23 2020

alanphipps updated the diff for D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.

Updating for formatting and comments (and some test adjustments after rebase). Bypassing logical-NOT operators in CodeGenFunction::isLeafCondition(), which checks the condition for the presence of logical-AND and logical-OR. (this can be further expanded, if necessary)

Aug 23 2020, 12:21 PM · Restricted Project, Restricted Project
alanphipps added a comment to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
In D84467#2180421, @vsk wrote:

I haven't taken a close look at the tests yet, but plan on getting to it soon.

I'm not sure whether this is something you've already tried, but for this kind of change, it can be helpful to verify that a stage2 clang self-host with assertions enabled completes successfully. For coverage specifically, it's possible to do that by setting '-DLLVM_BUILD_INSTRUMENTED_COVERAGE=On' during the stage2 cmake step.

Aug 23 2020, 12:15 PM · Restricted Project, Restricted Project

Aug 7 2020

alanphipps added a comment to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
In D84467#2180421, @vsk wrote:

I haven't taken a close look at the tests yet, but plan on getting to it soon.

I'm not sure whether this is something you've already tried, but for this kind of change, it can be helpful to verify that a stage2 clang self-host with assertions enabled completes successfully. For coverage specifically, it's possible to do that by setting '-DLLVM_BUILD_INSTRUMENTED_COVERAGE=On' during the stage2 cmake step.

Aug 7 2020, 3:27 PM · Restricted Project, Restricted Project

Jul 31 2020

alanphipps added a comment to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.

Thank you for your comments on the review! I will respond soon; also have been swamped this week.

Jul 31 2020, 3:46 PM · Restricted Project, Restricted Project

Jul 27 2020

alanphipps added inline comments to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Jul 27 2020, 9:38 AM · Restricted Project, Restricted Project

Jul 23 2020

Herald added a project to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage: Restricted Project.
Jul 23 2020, 2:31 PM · Restricted Project, Restricted Project

Jul 15 2020

alanphipps added a comment to D82151: [builtins] Cleanup generic-file filtering.
Jul 15 2020, 1:31 PM · Restricted Project

May 31 2020

alanphipps added a comment to D79961: [PGO] Fix computation of fuction Hash.

It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read as v6 rather than v5. Can you double check?

May 31 2020, 4:30 PM · Restricted Project, Restricted Project

May 28 2020

alanphipps added a comment to D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list.

clang/test/CodeGen/sanitize-coverage.c is also failing our downstream embedded ARMv7 validations.

May 28 2020, 8:42 AM · Restricted Project, Restricted Project

Jan 21 2020

alanphipps added a comment to D72897: List implicit operator== after implicit destructors in a vtable..

This test is still failing on the arm bots and also with my downstream ARM compiler validation.

Jan 21 2020, 7:44 AM · Restricted Project

Jan 17 2020

alanphipps added a comment to rG03a592f18ba5: TableGen/GlobalISel: Fix srcvalue inputs.

Hello! Your test specifically looks for "248", which is failing with my downstream embedded ARM compiler (we produce "249"); other similar tests that I've looked at simply ignore this value. Is there a reason why you need to check it specifically?

Jan 17 2020, 4:46 PM

Jan 10 2020

alanphipps added a comment to rGcee4a1c95742: Improve support of GNU mempcpy.

Sorry, we just saw your commit to fix. We are OK. Thanks!

Jan 10 2020, 11:29 AM
alanphipps added a comment to rGcee4a1c95742: Improve support of GNU mempcpy.

We maintain a downstream embedded ARM compiler, and this test is failing for us now because it assumes a 64bit size_t in the first CHECK line of the mempcpy-libcall.c. Because this is testing a GNU specific builtin, should it be specific to only targets that support that? Or should it be extended to support 32bit size_t?

Jan 10 2020, 11:27 AM