Page MenuHomePhabricator

alanphipps (Alan Phipps)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2019, 11:03 AM (177 w, 4 d)

Recent Activity

Mon, Mar 13

alanphipps added a comment to D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization.

Overall, it looks good to me. I added a few minor things.
Please add --show-mcdc to the llvm-cov command guide.
https://github.com/llvm/llvm-project/blob/main/llvm/docs/CommandGuide/llvm-cov.rst

Mon, Mar 13, 7:04 AM · Restricted Project, Restricted Project
alanphipps added inline comments to D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization.
Mon, Mar 13, 7:02 AM · Restricted Project, Restricted Project

Dec 23 2022

alanphipps updated the diff for D138849: MC/DC in LLVM Source-Based Code Coverage: clang.

Update diff to fix a small bug and add a test case to test intrinsic generation (based off a comment in the backend review)

Dec 23 2022, 11:09 AM · Restricted Project
alanphipps added inline comments to D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt.
Dec 23 2022, 11:04 AM · Restricted Project, Restricted Project
alanphipps updated the diff for D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt.

Updated diff based on review comments

Dec 23 2022, 10:57 AM · Restricted Project, Restricted Project

Nov 29 2022

alanphipps added inline comments to D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt.
Nov 29 2022, 2:24 PM · Restricted Project, Restricted Project
alanphipps added a comment to D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt.

Hi @ellis, thank you for looking at this deeper! I'll update based on your comments below, but I want to respond to your primary question first:

Nov 29 2022, 2:19 PM · Restricted Project, Restricted Project

Nov 28 2022

alanphipps updated the summary of D138849: MC/DC in LLVM Source-Based Code Coverage: clang.
Nov 28 2022, 12:28 PM · Restricted Project
alanphipps added a comment to D138849: MC/DC in LLVM Source-Based Code Coverage: clang.

@peter.smith I know you may not feel comfortable reviewing everything or signing-off on the review, but for changes pertinent to clang, I think you made some substantive suggestions, so I am including you in the reviewer list. Thanks for your input.

Nov 28 2022, 12:27 PM · Restricted Project
alanphipps added a comment to D136385: Add support for MC/DC in LLVM Source-Based Code Coverage.

Thank you for the comments thus-far. I have split this patch into three stacked patches and updated them according to comments found on this review:

Nov 28 2022, 12:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
alanphipps added reviewers for D138849: MC/DC in LLVM Source-Based Code Coverage: clang: vsk, phosek, peter.smith.
Nov 28 2022, 12:21 PM · Restricted Project
alanphipps added reviewers for D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization: vsk, phosek.
Nov 28 2022, 12:21 PM · Restricted Project, Restricted Project
alanphipps added reviewers for D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt: vsk, phosek, ellis.
Nov 28 2022, 12:21 PM · Restricted Project, Restricted Project
alanphipps updated the summary of D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization.
Nov 28 2022, 12:17 PM · Restricted Project, Restricted Project
alanphipps updated the summary of D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt.
Nov 28 2022, 12:16 PM · Restricted Project, Restricted Project
alanphipps updated the summary of D138849: MC/DC in LLVM Source-Based Code Coverage: clang.
Nov 28 2022, 12:15 PM · Restricted Project
alanphipps updated the summary of D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization.
Nov 28 2022, 12:13 PM · Restricted Project, Restricted Project
alanphipps updated the summary of D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt.
Nov 28 2022, 12:11 PM · Restricted Project, Restricted Project
alanphipps updated the summary of D138849: MC/DC in LLVM Source-Based Code Coverage: clang.
Nov 28 2022, 12:04 PM · Restricted Project
alanphipps updated the summary of D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization.
Nov 28 2022, 12:04 PM · Restricted Project, Restricted Project
alanphipps updated the summary of D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt.
Nov 28 2022, 12:04 PM · Restricted Project, Restricted Project
alanphipps requested review of D138849: MC/DC in LLVM Source-Based Code Coverage: clang.
Nov 28 2022, 12:01 PM · Restricted Project
alanphipps requested review of D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization.
Nov 28 2022, 11:58 AM · Restricted Project, Restricted Project
alanphipps requested review of D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt.
Nov 28 2022, 11:54 AM · Restricted Project, Restricted Project

Oct 28 2022

alanphipps updated the summary of D136385: Add support for MC/DC in LLVM Source-Based Code Coverage.
Oct 28 2022, 9:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
alanphipps added a comment to D136385: Add support for MC/DC in LLVM Source-Based Code Coverage.

Thank you (both) for looking at it! I appreciate your time.

Oct 28 2022, 9:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 27 2022

alanphipps added a comment to D135929: [profile] Add binary ids into indexed profiles.

We would like to simplify our coverage pipeline by using debuginfod in llvm-cov. When we include binary ids into indexed profiles and start using debuginfod in llvm-cov

Oct 27 2022, 8:57 AM · Restricted Project, Restricted Project, Restricted Project

Oct 21 2022

alanphipps added reviewers for D136385: Add support for MC/DC in LLVM Source-Based Code Coverage: vsk, phosek.
Oct 21 2022, 1:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
alanphipps updated the summary of D136385: Add support for MC/DC in LLVM Source-Based Code Coverage.
Oct 21 2022, 1:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 20 2022

alanphipps updated the summary of D136385: Add support for MC/DC in LLVM Source-Based Code Coverage.
Oct 20 2022, 3:27 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
alanphipps updated the summary of D136385: Add support for MC/DC in LLVM Source-Based Code Coverage.
Oct 20 2022, 3:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
alanphipps requested review of D136385: Add support for MC/DC in LLVM Source-Based Code Coverage.
Oct 20 2022, 3:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 14 2022

alanphipps committed rGa921d6eb3b51: [llvm-cov] Allow branch coverage to be skipped when exporting for LCOV (authored by alanphipps).
[llvm-cov] Allow branch coverage to be skipped when exporting for LCOV
Oct 14 2022, 2:25 PM · Restricted Project, Restricted Project
alanphipps closed D135986: Allow branch coverage to be skipped by llvm-cov when exporting for LCOV.
Oct 14 2022, 2:25 PM · Restricted Project, Restricted Project
alanphipps requested review of D135986: Allow branch coverage to be skipped by llvm-cov when exporting for LCOV.
Oct 14 2022, 1:39 PM · Restricted Project, Restricted Project

Jul 29 2022

alanphipps added a comment to D130786: [clang-repl] Disable execution unittests on unsupported platforms..

@alanphipps I just confirmed that the buildbot failures were fixed by the new fix https://reviews.llvm.org/rG65c9265f4158. Could you check out if this fixes the failure on your end too?

Jul 29 2022, 10:21 PM · Restricted Project, Restricted Project
alanphipps added a comment to D130786: [clang-repl] Disable execution unittests on unsupported platforms..

I'm still seeing a failure on my downstream Arm compiler on Linux in the unit tests -- I thought I saw the same failure on the buildbots:

Jul 29 2022, 3:02 PM · Restricted Project, Restricted Project

Jul 25 2022

alanphipps added a comment to D121997: [clang][driver] Fix compilation database dump with multiple architectures.

Should there be an aarch64 guard on the test? There exist downstream Arm compilers that don't support Arm64 and fail. I know other tests explicitly state "REQUIRES: aarch64-registered-target"

Jul 25 2022, 11:16 AM · Restricted Project, Restricted Project

Jun 11 2022

alanphipps added a comment to D127226: [libc++] Simplify type_traits and use more builtins.

Nope, it was working fine until a few hours ago. The only files I see actually installed in include/c++/v1/__type_traits/ are "integral_constant.h" and "is_callable.h".

Jun 11 2022, 9:59 PM · Restricted Project, Restricted Project

Jun 10 2022

alanphipps added a comment to D127226: [libc++] Simplify type_traits and use more builtins.

add_lvalue_reference has been added in D126244, but I don't think there is anything different from the other granularization patches. Did anything fail like this before?

Jun 10 2022, 5:58 PM · Restricted Project, Restricted Project
alanphipps added a comment to D127226: [libc++] Simplify type_traits and use more builtins.

Hello! I'm noticing test failures with our downstream Arm compiler that may be related to the changes you're making, but I'm not sure where to begin looking.

Jun 10 2022, 4:12 PM · Restricted Project, Restricted Project

Apr 19 2022

alanphipps added a comment to D119136: [clang] Implement Change scope of lambda trailing-return-type.

We've also been seeing failures in our downstream Arm compiler when running the Perennial C++14 compliance tests related to this change. Specifically, the tests expect a diagnostic to be issued when the lambda capture variable is outside of the lambda's {} scope. Another tests uses the lambda capture variable in a decltype-style return type which is also outside of the scope.

Apr 19 2022, 11:24 AM · Restricted Project, Restricted Project

Apr 4 2022

alanphipps added a comment to D120026: [ARM] Fix ARM backend to correctly use atomic expansion routines..

There is no way to implement an "atomic" operation on an M0 besides turning off interrupts, and we don't want the builtins library to mess with the interrupt mask. I'd expect the OS/user to provide the functionality, if they need it. compiler-rt doesn't provide __sync_* for cortex-m0, for the same reason.

I'm not sure how your setup was working before. I guess maybe if you only need atomics for C++ static local vars, and you built libc++abi with LIBCXXABI_HAS_NO_THREADS? If you don't actually need threading/atomics, you can use -fno-threadsafe-statics and/or -mthread-model single.

Apr 4 2022, 2:08 PM · Restricted Project, Restricted Project
alanphipps added a comment to D120026: [ARM] Fix ARM backend to correctly use atomic expansion routines..

By "the builtins", do you mean you're using compiler-rt with -DCOMPILER_RT_EXCLUDE_ATOMIC_BUILTIN=Off? That implementation probably don't work on a Cortex-M0, unless you've hacked it somehow; it assumes width-1 lock-free atomics are available.

Apr 4 2022, 1:33 PM · Restricted Project, Restricted Project

Apr 1 2022

alanphipps added a comment to D120026: [ARM] Fix ARM backend to correctly use atomic expansion routines..

The impact on Cortex-M0 is that instead of using __sync_*, and inlined atomic load/store ops, it uses __atomic_* calls. I can't imagine that causing timeouts unless you're somehow using a bad implementation of __atomic_*.

Apr 1 2022, 5:38 PM · Restricted Project, Restricted Project
alanphipps added a comment to D120026: [ARM] Fix ARM backend to correctly use atomic expansion routines..

Interesting, this commit results in several testing timeouts in our downstream compiler for several C++ compliance tests (ACE, plumhall, perennial) for Cortex-M0/M0plus only. I confess I don't understand the nature of this commit or how it would impact runtime here, other than you indicate that this could impact Cortex-M0. Do you have any pointers as to what I could verify here?

Apr 1 2022, 11:28 AM · Restricted Project, Restricted Project

Nov 23 2021

alanphipps accepted D112816: [LLVM][llvm-cov] Inclusive language: rename option -name-whitelist to -name-allowlist.

Thanks for putting this up! The changes appear to be straightforward, and it makes sense to deprecate the older option and still accept it until next release. LGTM.

Nov 23 2021, 11:40 AM · Restricted Project

Oct 11 2021

alanphipps added a comment to D109958: [LoopFlatten] Enable it by default.

I assume you have a downstream change to enable it by default, just like us. So if we are going to enable this by default under the NPM, I am not sure if anything will change for you

Oct 11 2021, 2:23 PM · Restricted Project, Restricted Project
alanphipps added a comment to D109958: [LoopFlatten] Enable it by default.

There are already a good number of divergences between the two pass managers, I don't see the harm in keeping the LPM pipeline the same. Do you specifically care about this pass?

Oct 11 2021, 11:33 AM · Restricted Project, Restricted Project
alanphipps added a comment to D109958: [LoopFlatten] Enable it by default.

Thanks for the suggestion, I am happy to enable LoopFlatten by default only for the new PM, so will look into that.

Oct 11 2021, 11:14 AM · Restricted Project, Restricted Project

Oct 7 2021

alanphipps added a comment to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

This review appears to have stalled. Is anything missing as a result of the more recent comments to complete it? Thanks!

Oct 7 2021, 6:49 AM · Restricted Project

Sep 22 2021

alanphipps updated subscribers of D110261: [libc++][release] Do not force building the runtimes with -fPIC.
Sep 22 2021, 10:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 20 2021

alanphipps committed rG9116211d180c: [Coverage][llvm-cov] Correctly export branch coverage in LCOV format (authored by fetzerch).
[Coverage][llvm-cov] Correctly export branch coverage in LCOV format
Aug 20 2021, 11:49 AM
alanphipps closed D108358: [llvm-cov] Correctly export branch coverage in LCOV format.
Aug 20 2021, 11:49 AM · Restricted Project

Aug 19 2021

alanphipps added a comment to D108358: [llvm-cov] Correctly export branch coverage in LCOV format.

Thanks! This is my first contribution to LLVM and I don't have commit permissions. Could you or some of the maintainers please commit it on my behalf (Christian Fetzer <christian.fetzer@bmw.de>)? What would I need to do to 'block 12.x and 13.x release branches'?

Aug 19 2021, 9:25 AM · Restricted Project
alanphipps accepted D108358: [llvm-cov] Correctly export branch coverage in LCOV format.
Aug 19 2021, 7:36 AM · Restricted Project
alanphipps added a comment to D108358: [llvm-cov] Correctly export branch coverage in LCOV format.

Thank you for catching this! LGTM. Can you please ensure this defect fix blocks 12.x and 13.x release branches as well?

Aug 19 2021, 7:35 AM · Restricted Project

Aug 18 2021

alanphipps added a comment to D107381: [runtimeunroll] Support multiple exits to latch exit w/epilogue loop.

Hello! I'm seeing a failure from this commit in this test with our downstream Arm32 compiler. Does it ring any bells? Thanks.

Aug 18 2021, 4:05 PM · Restricted Project

Jun 8 2021

alanphipps added a comment to D99205: Add jump-threading optimization for deterministic finite automata.

Thanks for all of the effort! On our downstream Cortex-R5 compiler, I'm seeing a 20.4% speedup on Coremark with this patch, which is good, however, the older patch (https://reviews.llvm.org/D88307) gave me a 21.6% speedup. Any idea what could account for the difference there?

It would be very hard for us to explain the difference without having access to both the downstream compiler and the hardware but something that comes to mind is:

(1) were the two experiments performed on the same baseline compiler?
(2) 1% could be within noise and might be due to trivial changes in the generated code (change of alignment, change of branch addresses and branch target addresses, etc.)
(3) were both passes in the same place in the pipeline in both experiments?

From the information provided, it is not possible to understand the root cause of the difference.

Jun 8 2021, 7:54 AM · Restricted Project

Jun 1 2021

alanphipps added a comment to D99205: Add jump-threading optimization for deterministic finite automata.

Thanks for all of the effort! On our downstream Cortex-R5 compiler, I'm seeing a 20.4% speedup on Coremark with this patch, which is good, however, the older patch (https://reviews.llvm.org/D88307) gave me a 21.6% speedup. Any idea what could account for the difference there?

Jun 1 2021, 2:48 PM · Restricted Project

May 18 2021

alanphipps added a comment to D102193: Fix branch coverage merging across function instantiations .

OK, I will revert that commit on the 12.x branch then. Can you please file a bug for this patch and mark it as blocker of the release-12.0.1 metabug? I typically review and try to get an ack from at least on other person before backporting patches.

May 18 2021, 1:22 PM · Restricted Project

May 11 2021

alanphipps added a comment to D102193: Fix branch coverage merging across function instantiations .

I saw this fix was backported to the release/12.x branch, was there a bug for this?

May 11 2021, 5:38 PM · Restricted Project
alanphipps committed rGeccb925147d5: Reland "[Coverage] Fix branch coverage merging in FunctionCoverageSummary::get… (authored by alanphipps).
Reland "[Coverage] Fix branch coverage merging in FunctionCoverageSummary::get…
May 11 2021, 9:49 AM
alanphipps added a comment to D102193: Fix branch coverage merging across function instantiations .

Looks like this breaks tests on windows: http://45.33.8.238/win/38516/step_11.txt

PTAL, and revert for now if it takes a while to fix.

May 11 2021, 9:44 AM · Restricted Project
alanphipps added a reverting change for rG6400905a6152: Fix branch coverage merging in FunctionCoverageSummary::get() for instantiation: rG668dccc396da: Revert "Fix branch coverage merging in FunctionCoverageSummary::get() for….
May 11 2021, 9:27 AM
alanphipps added a reverting change for D102193: Fix branch coverage merging across function instantiations : rG668dccc396da: Revert "Fix branch coverage merging in FunctionCoverageSummary::get() for….
May 11 2021, 9:27 AM · Restricted Project
alanphipps committed rG668dccc396da: Revert "Fix branch coverage merging in FunctionCoverageSummary::get() for… (authored by alanphipps).
Revert "Fix branch coverage merging in FunctionCoverageSummary::get() for…
May 11 2021, 9:27 AM
alanphipps committed rG6400905a6152: Fix branch coverage merging in FunctionCoverageSummary::get() for instantiation (authored by alanphipps).
Fix branch coverage merging in FunctionCoverageSummary::get() for instantiation
May 11 2021, 8:44 AM
alanphipps closed D102193: Fix branch coverage merging across function instantiations .
May 11 2021, 8:44 AM · Restricted Project

May 10 2021

alanphipps requested review of D102193: Fix branch coverage merging across function instantiations .
May 10 2021, 1:28 PM · Restricted Project

Mar 10 2021

alanphipps added a comment to D96280: [clang][cli] Round-trip the whole CompilerInvocation.

We also encounter a build failure on the Mac related to above but in a different file:
clang/lib/CodeGen/CGStmtOpenMP.cpp:1916:3: error: too few template arguments for class template 'SmallVector'
SmallVector<llvm::Value *> EffectiveArgs;
^
clang/include/clang/Basic/LLVM.h:35:42: note: template is declared here
template<typename T, unsigned N> class SmallVector;

Mar 10 2021, 10:55 AM · Restricted Project
alanphipps added a comment to D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops..

Is is that same problem that D98265 addresses?

Mar 10 2021, 10:54 AM · Restricted Project, Restricted Project, Restricted Project
alanphipps added a comment to D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops..

Hello! I am seeing a downstream build failure on Mac as a result of your changes:

Mar 10 2021, 9:37 AM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2021

alanphipps added a comment to D96280: [clang][cli] Round-trip the whole CompilerInvocation.

We also encounter a build failure on the Mac related to above but in a different file:
clang/lib/CodeGen/CGStmtOpenMP.cpp:1916:3: error: too few template arguments for class template 'SmallVector'
SmallVector<llvm::Value *> EffectiveArgs;
^
clang/include/clang/Basic/LLVM.h:35:42: note: template is declared here
template<typename T, unsigned N> class SmallVector;

Mar 8 2021, 9:47 AM · Restricted Project

Jan 12 2021

alanphipps updated subscribers of D88307: [DON'T MERGE] Jump-threading for finite state automata.
Jan 12 2021, 9:45 AM · Restricted Project

Jan 7 2021

alanphipps added inline comments to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Jan 7 2021, 2:51 PM · Restricted Project, Restricted Project, Restricted Project
alanphipps committed rGebcc8dcb68aa: [Coverage] Refactor three tests from commit rG9f2967bcfe2f (authored by alanphipps).
[Coverage] Refactor three tests from commit rG9f2967bcfe2f
Jan 7 2021, 9:30 AM

Jan 5 2021

alanphipps added inline comments to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Jan 5 2021, 4:08 PM · Restricted Project, Restricted Project, Restricted Project
alanphipps committed rG216894211713: [Coverage] Fix Profile test failures from commit rG9f2967bcfe2f (authored by alanphipps).
[Coverage] Fix Profile test failures from commit rG9f2967bcfe2f
Jan 5 2021, 12:53 PM
alanphipps committed rG16f3401eae43: [Coverage] Fix test failures from commit rG9f2967bcfe2f (authored by alanphipps).
[Coverage] Fix test failures from commit rG9f2967bcfe2f
Jan 5 2021, 11:36 AM
alanphipps committed rG9f2967bcfe2f: [Coverage] Add support for Branch Coverage in LLVM Source-Based Code Coverage (authored by alanphipps).
[Coverage] Add support for Branch Coverage in LLVM Source-Based Code Coverage
Jan 5 2021, 7:53 AM
alanphipps closed D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Jan 5 2021, 7:52 AM · Restricted Project, Restricted Project, Restricted Project

Dec 23 2020

alanphipps added a reverting change for rGb920adf3b4f1: This is a test commit: rGbbd758a7913b: Revert "This is a test commit".
Dec 23 2020, 11:06 AM
alanphipps committed rGbbd758a7913b: Revert "This is a test commit" (authored by alanphipps).
Revert "This is a test commit"
Dec 23 2020, 11:06 AM
alanphipps committed rGb920adf3b4f1: This is a test commit (authored by alanphipps).
This is a test commit
Dec 23 2020, 10:58 AM

Dec 11 2020

alanphipps added a comment to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
In D84467#2449045, @vsk wrote:

Unfortunately I don't think I'll be able to commit this on your behalf. Would you be open to obtaining commit access from Chris and landing this directly? I ask because, for a patch of this size, there's typically a fair amount of post-commit feedback (primarily in the form of bot failure notifications, but occasionally design feedback as well). It's common for tests to pass locally, but not on some specific CI node, and it can take quite a bit of time to resolve those issues.

Dec 11 2020, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
alanphipps added a comment to D88307: [DON'T MERGE] Jump-threading for finite state automata.

Hi Alan,
Good news. I've got an approval. I cannot say when I post the updated version. I've just started a new job and are completely busy. I don't work anymore at Arm.

Dec 11 2020, 8:35 AM · Restricted Project
alanphipps added a comment to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
In D84467#2423636, @vsk wrote:

Thank you, lgtm!

Dec 11 2020, 7:57 AM · Restricted Project, Restricted Project, Restricted Project
alanphipps updated the diff for D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.

Diff after rebase.

Dec 11 2020, 7:56 AM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2020

alanphipps added a comment to rGa78aaa1ad512: [libc++] Factor out common logic for calling aligned allocation.

Done in d67e58f23a823, thanks for reporting. However, I'm still curious to understand how you're building libc++. Are you passing -D_LIBCPP_HAS_NO_LIBRARY_ALIGNED_ALLOCATION manually?

Dec 2 2020, 11:39 AM

Nov 29 2020

alanphipps added a comment to rGa78aaa1ad512: [libc++] Factor out common logic for calling aligned allocation.

I can fix this locally to get our builds running, but is it possible that you could commit a fix upstream? I appreciate it, thanks!

Nov 29 2020, 11:07 AM

Nov 27 2020

alanphipps added a comment to rGa78aaa1ad512: [libc++] Factor out common logic for calling aligned allocation.

I am seeing downstream build errors for fallback_malloc.cpp with this commit, e.g.:

llvm-project/libcxxabi/src/fallback_malloc.cpp:237:10: error: no type named 'libcpp_aligned_free' in namespace 'std'
std::
libcpp_aligned_free(ptr);
~~~~~^

How are you building the library? What's your configuration, system, compiler, etc? As you can see, our CI is green, so whatever you're experiencing is on a setup that we don't actively test.

Nov 27 2020, 10:59 AM
alanphipps added a comment to rGa78aaa1ad512: [libc++] Factor out common logic for calling aligned allocation.

In the description, you refer to fallback_malloc.cpp "The code in libcxxabi/src/fallback_malloc.cpp looks like it could be simplified after this change -- I purposefully did not simplify it further to keep this change as straightforward as possible, since it is touching very important parts of the library."

Nov 27 2020, 9:41 AM

Nov 23 2020

alanphipps added a comment to D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

Looks like _LIBCPP_HAS_NO_THREADS is being set for libcxxabi, and the build now fails with this change:

Nov 23 2020, 1:16 PM · Restricted Project
alanphipps updated the diff for D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.

Bump format version and add preliminary documentation for CoverageMappingFormat, SourceBasedCodeCoverage, and llvm-cov tool

Nov 23 2020, 11:53 AM · Restricted Project, Restricted Project, Restricted Project

Nov 19 2020

alanphipps added a comment to D48811: Fix disassembling ARM instructions as big-endian.

Just checking in again -- is there interest in completing this review? I'd be happy to assist, or I could post an updated version of it.

Nov 19 2020, 3:43 PM · Restricted Project, Restricted Project

Oct 19 2020

alanphipps added a comment to D88307: [DON'T MERGE] Jump-threading for finite state automata.

@eastig I tried this experimental patch in our system, and it definitely brings highly significant improvement to coremark. When do you expect to post a version for reviewing -- what will the differences be?

Oct 19 2020, 3:06 PM · Restricted Project

Oct 8 2020

alanphipps added inline comments to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Oct 8 2020, 8:09 AM · Restricted Project, Restricted Project, Restricted Project

Oct 3 2020

alanphipps updated the diff for D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.

Updated diff:
1.) Fix a defect in the CGExprScalar.cpp code to instrument RHS condition for branch coverage that resulted in a RHS condition as being evaluated twice. This is incorrect behavior since a condition may have side-effects. I also added a test.
2.) Back out unintended whitespace/punctuation (please let me know if I overlooked anything).
3.) Rebase against updated upstream.

Oct 3 2020, 6:14 PM · Restricted Project, Restricted Project, Restricted Project

Sep 29 2020

alanphipps added a comment to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
In D84467#2264205, @vsk wrote:

@alanphipps thanks for bearing with me. I think this is about ready to land. I do ask that you back out any punctuation/whitespace changes in code/tests that aren't directly modified in your diff (the clang-format-diff script can help with this). It looks like some libCoverage and test changes are no longer in the current version of this patch, as compared to the previous version (https://reviews.llvm.org/D84467?id=287269). Was that intentional?

Sep 29 2020, 3:11 PM · Restricted Project, Restricted Project, Restricted Project