Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D147743

[Clang][NFC] Rename methods/vars to reflect their real usage
ClosedPublic
Actions

Authored by void on Apr 6 2023, 2:36 PM.

Details

Reviewers
rsmith
rjmccall
aaron.ballman
dblaikie
Commits
rGb51a03e1bbe7: [Clang][NFC] Rename methods/vars to reflect their real usage
Summary

The "getField" method is a bit confusing considering we also have a
"getFieldName" method. Instead, use "getFieldDecl" rather than
"getField".

Diff Detail

Event Timeline

void created this revision.Apr 6 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 2:36 PM
Herald added a subscriber: arphaman. · View Herald Transcript
void requested review of this revision.Apr 6 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 2:36 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B224110: Diff 511531.Apr 6 2023, 3:56 PM
void updated this revision to Diff 511772.Apr 7 2023, 12:33 PM

Fix compilation issue.

Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2023, 12:33 PM
Herald added a subscriber: kadircet. · View Herald Transcript
Harbormaster completed remote builds in B224273: Diff 511772.Apr 7 2023, 1:39 PM
void added a comment.Apr 17 2023, 2:01 PM

Friendly ping.

void updated this revision to Diff 514395.Apr 17 2023, 2:02 PM

Reformat.

Harbormaster completed remote builds in B226213: Diff 514395.Apr 17 2023, 4:15 PM
aaron.ballman accepted this revision.Apr 18 2023, 6:34 AM

LGTM!

This revision is now accepted and ready to land.Apr 18 2023, 6:34 AM
shafik added a subscriber: shafik.Apr 18 2023, 8:54 AM
shafik added inline comments.
clang/lib/Index/IndexBody.cpp
426

nit

void updated this revision to Diff 514730.Apr 18 2023, 1:47 PM
void marked an inline comment as done.

Add comment.

This revision was landed with ongoing or failed builds.Apr 18 2023, 1:48 PM
Closed by commit rGb51a03e1bbe7: [Clang][NFC] Rename methods/vars to reflect their real usage (authored by void). · Explain Why
This revision was automatically updated to reflect the committed changes.
void added a commit: rGb51a03e1bbe7: [Clang][NFC] Rename methods/vars to reflect their real usage.
Harbormaster completed remote builds in B226445: Diff 514730.Apr 18 2023, 3:23 PM

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clangd/
4 lines
2 lines
clang/
include/
clang/
AST/
19 lines
Sema/
26 lines
Tooling/
Refactoring/
9 lines
lib/
AST/
2 lines
Index/
20 lines
Sema/
2 lines
8 lines
6 lines
Serialization/
2 lines
2 lines
Tooling/
Refactoring/
Rename/
21 lines
tools/
libclang/
2 lines

Diff 514731

View Options

clang-tools-extra/clangd/FindTarget.cpp

Loading...
View Options

clang-tools-extra/clangd/XRefs.cpp

Loading...
View Options

clang/include/clang/AST/Expr.h

Loading...
View Options

clang/include/clang/Sema/Designator.h

Loading...
View Options

clang/include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h

Loading...
View Options

clang/lib/AST/Expr.cpp

Loading...
View Options

clang/lib/Index/IndexBody.cpp

Loading...
View Options

clang/lib/Sema/SemaCodeComplete.cpp

Loading...
View Options

clang/lib/Sema/SemaInit.cpp

Loading...
View Options

clang/lib/Sema/TreeTransform.h

Loading...
View Options

clang/lib/Serialization/ASTReaderStmt.cpp

Loading...
View Options

clang/lib/Serialization/ASTWriterStmt.cpp

Loading...
View Options

clang/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp

Loading...
View Options

clang/tools/libclang/CIndex.cpp

Loading...