This is an archive of the discontinued LLVM Phabricator instance.

[Clang][NFC] Rename methods/vars to reflect their real usage
ClosedPublic

Authored by void on Apr 6 2023, 2:36 PM.

Details

Summary

The "getField" method is a bit confusing considering we also have a
"getFieldName" method. Instead, use "getFieldDecl" rather than
"getField".

Diff Detail

Event Timeline

void created this revision.Apr 6 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 2:36 PM
Herald added a subscriber: arphaman. · View Herald Transcript
void requested review of this revision.Apr 6 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 2:36 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
void updated this revision to Diff 511772.Apr 7 2023, 12:33 PM

Fix compilation issue.

Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2023, 12:33 PM
Herald added a subscriber: kadircet. · View Herald Transcript
void added a comment.Apr 17 2023, 2:01 PM

Friendly ping.

void updated this revision to Diff 514395.Apr 17 2023, 2:02 PM

Reformat.

This revision is now accepted and ready to land.Apr 18 2023, 6:34 AM
shafik added a subscriber: shafik.Apr 18 2023, 8:54 AM
shafik added inline comments.
clang/lib/Index/IndexBody.cpp
426

nit

void updated this revision to Diff 514730.Apr 18 2023, 1:47 PM
void marked an inline comment as done.

Add comment.

This revision was landed with ongoing or failed builds.Apr 18 2023, 1:48 PM
This revision was automatically updated to reflect the committed changes.