[RISCV] Fix gaps in IgnoreUnknown=true for RISCVISAInfo::parseArchString
ClosedPublic
Actions

Authored by asb on Sun, Mar 12, 11:21 AM.

Details

Reviewers

kito-cheng
MaskRay
jrtc27
reames
craig.topper

Commits

rGa159e58c0084: Reland [RISCV] Fix gaps in IgnoreUnknown=true for RISCVISAInfo::parseArchString
rGa7313f83b9ca: [RISCV] Fix gaps in IgnoreUnknown=true for RISCVISAInfo::parseArchString

Summary

Prior to this patch, unrecognised z/s/sx/x prefixed extensions were not ignored when IgnoreUnknown=true.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

asb created this revision.Sun, Mar 12, 11:21 AM

Herald added a project: Restricted Project. · View Herald TranscriptSun, Mar 12, 11:21 AM

Herald added subscribers: luke, wingo, pmatos and 27 others. · View Herald Transcript

asb requested review of this revision.Sun, Mar 12, 11:21 AM

Herald added a project: Restricted Project. · View Herald TranscriptSun, Mar 12, 11:21 AM

Herald added subscribers: pcwang-thead, eopXD. · View Herald Transcript

asb added a parent revision: D145879: [RISCV][test] Expand test coverage of RISCVISAInfo.Sun, Mar 12, 11:21 AM

Harbormaster completed remote builds in B218895: Diff 504459.Sun, Mar 12, 12:08 PM

LGTM :)

This revision is now accepted and ready to land.Sun, Mar 12, 8:24 PM

MaskRay accepted this revision.Sun, Mar 12, 10:11 PM

This revision was landed with ongoing or failed builds.Mon, Mar 13, 3:55 AM

Closed by commit rGa7313f83b9ca: [RISCV] Fix gaps in IgnoreUnknown=true for RISCVISAInfo::parseArchString (authored by asb). · Explain Why

This revision was automatically updated to reflect the committed changes.

asb added a commit: rGa7313f83b9ca: [RISCV] Fix gaps in IgnoreUnknown=true for RISCVISAInfo::parseArchString.

Herald added a subscriber: jobnoorman. · View Herald TranscriptMon, Mar 13, 3:55 AM

asb added a reverting change: rG7054aa6d6d68: Revert "[RISCV] Fix gaps in IgnoreUnknown=true for RISCVISAInfo….Mon, Mar 13, 4:21 AM

asb added a commit: rGa159e58c0084: Reland [RISCV] Fix gaps in IgnoreUnknown=true for RISCVISAInfo::parseArchString.Mon, Mar 13, 8:20 AM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Support/

RISCVISAInfo.cpp

3 lines

unittests/

Support/

RISCVISAInfoTest.cpp

10 lines

Diff 504581

View Options

llvm/lib/Support/RISCVISAInfo.cpp