Page MenuHomePhabricator

[RISCV][test] Expand test coverage of RISCVISAInfo
ClosedPublic

Authored by asb on Sun, Mar 12, 9:03 AM.

Details

Summary

D144343 added C++ unit tests for the newly added RISCVISAInfo::parseArchStringNormalized. This patch adds test coverage for parseArchString and the toFeatureVector member method.

Posting for review as it would be useful if someone can take a quick look to check they don't feel I've missed testing an important aspect of the current behaviour.

Diff Detail

Event Timeline

asb created this revision.Sun, Mar 12, 9:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Mar 12, 9:03 AM
asb requested review of this revision.Sun, Mar 12, 9:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Mar 12, 9:03 AM
This revision is now accepted and ready to land.Sun, Mar 12, 8:20 PM
This revision was automatically updated to reflect the committed changes.