This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Switch default Fold API to using FoldAdaptors
ClosedPublic

Authored by zero9178 on Feb 7 2023, 6:41 AM.

Details

Summary

As mentioned in https://discourse.llvm.org/t/psa-new-improved-fold-method-signature-has-landed-please-update-your-downstream-projects/67618, it has now been about one month since the new fold API has been introduced.

Any downstream users that have not yet switched, nor explicitly set useFoldAPI to kEmitRawAttributesFolder will experience a build break after this patch, requiring them to either switch to the new API or explicitly use the old one and live with the warning set by TableGen.

Diff Detail

Event Timeline

zero9178 created this revision.Feb 7 2023, 6:41 AM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added 1 blocking reviewer(s): jpienaar. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
zero9178 requested review of this revision.Feb 7 2023, 6:41 AM
jpienaar accepted this revision.Feb 7 2023, 7:09 AM

Nice, thanks. So this doesn't remove and just flips the default, so folks who haven't yet updated can just set raw explicit for now (and then fixup quickly before option is deprecated).

This revision is now accepted and ready to land.Feb 7 2023, 7:09 AM
This revision was automatically updated to reflect the committed changes.