Page MenuHomePhabricator

[llvm-readobj] Rename JSON Flag fields to be more consistent
Needs ReviewPublic

Authored by paulkirth on Oct 31 2022, 10:42 AM.

Details

Reviewers
jhenderson
Summary

Today the JSON uses Value and RawValue when printing Flags, when really
the Value field is always the name of an Enum variant, and RawValue is its
underlying numeric value. Similarly, we rename the RawFlags key to Value,
to match the new scheme. This also allows JSON parsing to use consistent logic
for Flag types.

Diff Detail

Event Timeline

paulkirth created this revision.Oct 31 2022, 10:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 10:42 AM
paulkirth requested review of this revision.Oct 31 2022, 10:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 10:42 AM
paulkirth updated this revision to Diff 484125.Dec 19 2022, 3:53 PM

Fix lit test, not updated during a rebase

paulkirth updated this revision to Diff 484392.Dec 20 2022, 3:02 PM

Fix test and rebase

paulkirth updated this revision to Diff 492287.Wed, Jan 25, 4:12 PM
paulkirth retitled this revision from [readobj] Rename JSON Flag fields to be more consistent to [llvm-readobj] Rename JSON Flag fields to be more consistent.
paulkirth edited the summary of this revision. (Show Details)

Rebase.