Page MenuHomePhabricator

paulkirth (Paul Kirth)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 11 2018, 11:58 AM (198 w, 6 h)

Recent Activity

Fri, Jun 24

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Address outstanding review comments.

Fri, Jun 24, 2:18 PM · Restricted Project, Restricted Project
paulkirth added inline comments to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.
Fri, Jun 24, 10:35 AM · Restricted Project, Restricted Project

Thu, Jun 23

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Address comments

Thu, Jun 23, 4:06 PM · Restricted Project, Restricted Project

Tue, Jun 21

paulkirth added a comment to D125263: [CMake][MSVC] Compile with `/permissive-`.

Well, that fixed our bots, so I'm going to guess that we just made an error when bisecting. Thanks @aeubanks for the quick and simple patch.

Tue, Jun 21, 5:30 PM · Restricted Project, Restricted Project
paulkirth added a comment to D125263: [CMake][MSVC] Compile with `/permissive-`.

@aeubanks That was my first thought too, but I think there may be something more subtle going on here with the /permissive- flag that is causing the underlying issue. AFAICT from the documentation linked in the summary, it shouldn't change how things are included, and this is compiling fine on other platforms. My guess is that clang-cl isn't handling this flag the same way as MSVC, and thus things like /Zc:rvalueCast aren't set correctly.

Tue, Jun 21, 2:03 PM · Restricted Project, Restricted Project
paulkirth added a comment to D125263: [CMake][MSVC] Compile with `/permissive-`.

Hi, we're seeing a build failure on windows that we've traced back to this revision.

Tue, Jun 21, 1:22 PM · Restricted Project, Restricted Project
paulkirth added a comment to D127931: [TableGen] Emit instruction name in INSTRINFO_OPERAND_TYPE.

Sorry, you can ignore my spam here. There's a newer failure that is still ongoing and I've mis-attributed it to this change. I think you're fine as is.

Tue, Jun 21, 10:04 AM · Restricted Project, Restricted Project
paulkirth added a comment to D127931: [TableGen] Emit instruction name in INSTRINFO_OPERAND_TYPE.

Sorry, our CI batches builds so sometimes it's non-obvious. You can find them all under the blame heading. I think they're also somewhere else on that page, but that is always where I go.

Tue, Jun 21, 10:01 AM · Restricted Project, Restricted Project
paulkirth added a comment to D127931: [TableGen] Emit instruction name in INSTRINFO_OPERAND_TYPE.

Hi, we're seeing a failure in Fuchsia's Clang CI for windows.

Tue, Jun 21, 9:39 AM · Restricted Project, Restricted Project

Thu, Jun 16

paulkirth added a comment to D126224: Add DWARF string debug to clang release notes..

so do we want to land this? or are there some outstanding issues I'm unaware of?

Thu, Jun 16, 11:16 AM · Restricted Project, Restricted Project

Wed, Jun 8

paulkirth committed rG56eb8dcf1e00: [compiler-rt][test] Restore original symbolize_stack test (authored by paulkirth).
[compiler-rt][test] Restore original symbolize_stack test
Wed, Jun 8, 12:16 PM · Restricted Project, Restricted Project
paulkirth closed D127334: [compiler-rt][test] Restore original symbolize_stack test.
Wed, Jun 8, 12:16 PM · Restricted Project, Restricted Project
paulkirth requested review of D127334: [compiler-rt][test] Restore original symbolize_stack test.
Wed, Jun 8, 12:03 PM · Restricted Project, Restricted Project

Tue, Jun 7

paulkirth added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

friendly ping.

Tue, Jun 7, 2:57 PM · Restricted Project, Restricted Project
paulkirth committed rGacfeb1a6c244: [compiler-rt] Avoid truncating Symbolizer output (authored by paulkirth).
[compiler-rt] Avoid truncating Symbolizer output
Tue, Jun 7, 2:51 PM · Restricted Project, Restricted Project
paulkirth closed D126580: [compiler-rt] Avoid truncating Symbolizer output.
Tue, Jun 7, 2:50 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D126580: [compiler-rt] Avoid truncating Symbolizer output.

Update test condition per discussion with @leonardchan

Tue, Jun 7, 2:01 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D126580: [compiler-rt] Avoid truncating Symbolizer output.

Address comments

Tue, Jun 7, 9:55 AM · Restricted Project, Restricted Project

Mon, Jun 6

paulkirth added inline comments to D126580: [compiler-rt] Avoid truncating Symbolizer output.
Mon, Jun 6, 4:02 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D126580: [compiler-rt] Avoid truncating Symbolizer output.

Address comments.

Mon, Jun 6, 3:59 PM · Restricted Project, Restricted Project
paulkirth added a comment to D126580: [compiler-rt] Avoid truncating Symbolizer output.

@vitalybuka is this change congruent w/ what you were suggesting in D126102?

Mon, Jun 6, 10:24 AM · Restricted Project, Restricted Project
paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Rebase

Mon, Jun 6, 10:13 AM · Restricted Project, Restricted Project

Tue, May 31

paulkirth added a comment to D126586: [InstrProf][WIP] Implement boolean counters in coverage.

I think somewhere in this patch there should be a description of the new algorithm. I also don't see any description of the old algorithm, so maybe we should describe both of them so that it's easy to understand the differences in between the different profiling approaches. For example llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp describes the MST approach in detail. I don't think it needs to be quite that detailed, but a diagram contrasting where counters are inserted in both approaches would help explain the differences.

Tue, May 31, 10:38 AM · Restricted Project, Restricted Project, Restricted Project

May 27 2022

paulkirth requested review of D126580: [compiler-rt] Avoid truncating Symbolizer output.
May 27 2022, 5:03 PM · Restricted Project, Restricted Project
paulkirth added a comment to D124481: [llvm][misexpect] Add tests for sample profiling.

So after looking at this for a while, I think the core issue is that MisExpect needs some kind of provenance information about whether or not the branch weight originates from an llvm.expect intrinsic. If we could know that, then MisExpect diagnostics should be correct even if you run several profiling passes or combine different types of profiling, since we would only report issues on branch weights that had the correct provenance.

May 27 2022, 10:03 AM · Restricted Project, Restricted Project
paulkirth added a comment to D126450: [cmake] make FindLibEdit.cmake more robust.

I think this is probably fine. Locally it seems to work as expected. so LGTM from me.

May 27 2022, 9:27 AM · Restricted Project, Restricted Project

May 26 2022

paulkirth added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

ping

May 26 2022, 11:50 AM · Restricted Project, Restricted Project

May 25 2022

paulkirth committed rG7f5439945b1f: [compiler-rt][test] Fix flake in symbolize_stack test (authored by paulkirth).
[compiler-rt][test] Fix flake in symbolize_stack test
May 25 2022, 12:03 PM · Restricted Project, Restricted Project
paulkirth closed D126102: [compiler-rt][test] Fix flake in symbolize_stack test.
May 25 2022, 12:02 PM · Restricted Project, Restricted Project
paulkirth added a comment to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.

@vitalybuka what if we just changed the implementation to return whatever it had read so far?

May 25 2022, 9:14 AM · Restricted Project, Restricted Project
paulkirth updated the diff for D126102: [compiler-rt][test] Fix flake in symbolize_stack test.

Restore exisiting checks, and mark the test unsupported on Linux

May 25 2022, 8:59 AM · Restricted Project, Restricted Project

May 24 2022

paulkirth added a comment to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.

I would prefer you just disable the test for your platform.

May 24 2022, 7:46 PM · Restricted Project, Restricted Project
paulkirth added a comment to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.

@vitalybuka I'm hoping to just address the flaky test for now. There's some value in ensuring that long output doesn't crash symbolization w/in sanitizer runtimes, so I've opted to keep the test, and try to make it less prone to flake. For now, I'm happy just to remove the flake so we can update our Toolchain.

May 24 2022, 6:43 PM · Restricted Project, Restricted Project
paulkirth added inline comments to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.
May 24 2022, 6:21 PM · Restricted Project, Restricted Project
paulkirth added a comment to D124481: [llvm][misexpect] Add tests for sample profiling.

Won't this patch if committed trigger the failure again?

May 24 2022, 6:16 PM · Restricted Project, Restricted Project
paulkirth accepted D126224: Add DWARF string debug to clang release notes..

LGTM.

May 24 2022, 9:57 AM · Restricted Project, Restricted Project

May 23 2022

paulkirth updated the diff for D126102: [compiler-rt][test] Fix flake in symbolize_stack test.

Just match on any frame in the symbolizer output.

May 23 2022, 5:50 PM · Restricted Project, Restricted Project
paulkirth updated the summary of D124481: [llvm][misexpect] Add tests for sample profiling.
May 23 2022, 5:41 PM · Restricted Project, Restricted Project
paulkirth published D124481: [llvm][misexpect] Add tests for sample profiling for review.

@tejohnson I have a test case that encapsulates when SampleProfiling crashes we saw w/ misexpect a while ago.

May 23 2022, 5:37 PM · Restricted Project, Restricted Project
paulkirth added a comment to D126224: Add DWARF string debug to clang release notes..

I'm going to try to summarize an offline discussion w/ @mcgrathr about this here:

May 23 2022, 1:12 PM · Restricted Project, Restricted Project
paulkirth updated subscribers of D126224: Add DWARF string debug to clang release notes..

@rnk the standard even has an example of this exact behavior, so I think it's hard to say its wrong for LLVM to do this, but that may be more gentle. I'm going to defer to more expert opinions here, however, and loop in @mcgrathr.

May 23 2022, 10:45 AM · Restricted Project, Restricted Project

May 20 2022

paulkirth removed a reviewer for D110552: tsan: add lock free stack pattern test: paulkirth.
May 20 2022, 5:25 PM · Restricted Project, Restricted Project
paulkirth requested changes to D110552: tsan: add lock free stack pattern test.
May 20 2022, 5:24 PM · Restricted Project, Restricted Project
paulkirth reopened D110552: tsan: add lock free stack pattern test.

I've reverted this for now, since I assume everyone is gone for the weekend, and our bots on AArch64 Linux are still showing problems with this test.

May 20 2022, 5:23 PM · Restricted Project, Restricted Project
paulkirth added a reverting change for rG5deca650fdba: tsan: add lock free stack pattern test: rGd6a3c8ca1831: Revert "tsan: add lock free stack pattern test".
May 20 2022, 5:19 PM · Restricted Project, Restricted Project
paulkirth committed rGd6a3c8ca1831: Revert "tsan: add lock free stack pattern test" (authored by paulkirth).
Revert "tsan: add lock free stack pattern test"
May 20 2022, 5:19 PM · Restricted Project, Restricted Project
paulkirth added a reverting change for rGb517d679dd69: Mark new TSan test as unsupported on PPC.: rGf1d197f1a804: Revert "Mark new TSan test as unsupported on PPC.".
May 20 2022, 5:19 PM · Restricted Project, Restricted Project
paulkirth added a reverting change for D110552: tsan: add lock free stack pattern test: rGd6a3c8ca1831: Revert "tsan: add lock free stack pattern test".
May 20 2022, 5:19 PM · Restricted Project, Restricted Project
paulkirth committed rGf1d197f1a804: Revert "Mark new TSan test as unsupported on PPC." (authored by paulkirth).
Revert "Mark new TSan test as unsupported on PPC."
May 20 2022, 5:19 PM · Restricted Project, Restricted Project
paulkirth added a comment to D110552: tsan: add lock free stack pattern test.

we're seeing this crop up on Fuchsia's Clang CI for AArch64 too.

May 20 2022, 4:36 PM · Restricted Project, Restricted Project
paulkirth added a comment to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.

For context: https://discourse.llvm.org/t/post-mortem-on-test-flake-in-sanitizer-common/62657 describes how I got here.

May 20 2022, 4:25 PM · Restricted Project, Restricted Project
paulkirth added reviewers for D126102: [compiler-rt][test] Fix flake in symbolize_stack test: vitalybuka, phosek, thakis, leonardchan.
May 20 2022, 4:20 PM · Restricted Project, Restricted Project
paulkirth requested review of D126102: [compiler-rt][test] Fix flake in symbolize_stack test.
May 20 2022, 4:13 PM · Restricted Project, Restricted Project
paulkirth added a comment to D126072: [lld-macho] Stop crash when emitting personalities with -dead_strip.

This is intended to address https://github.com/llvm/llvm-project/issues/55565

May 20 2022, 1:11 PM · Restricted Project, Restricted Project, Restricted Project

May 19 2022

paulkirth added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

We noticed when building Fuchsia using ToT LLVM that CGo has trouble with the new changes to DWARF introduced in this patch. It appears as if CGo is confused because it found a DW_TAG_variable that doesn't have a name, which is allowed by the DWARF standard.

May 19 2022, 10:15 AM · Restricted Project, Restricted Project, Restricted Project

May 18 2022

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Address review comments

May 18 2022, 4:03 PM · Restricted Project, Restricted Project
paulkirth added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Thanks for the feedback, and glad most of it seems to be in order.

May 18 2022, 9:11 AM · Restricted Project, Restricted Project

May 17 2022

paulkirth added a comment to D125478: [llvm-objcopy][test] Add cmp after copy.

We're also seeing this on Fuchsia's Clang CI. https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b8813965072418331409/overview

May 17 2022, 9:15 AM · Restricted Project, Restricted Project

May 16 2022

paulkirth added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Thanks for the quick response.

May 16 2022, 7:10 PM · Restricted Project, Restricted Project, Restricted Project
paulkirth added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Hi, we're seeing a breakage in Fuchsia's clang CI for x64 windows that I think is related to this patch.

May 16 2022, 6:47 PM · Restricted Project, Restricted Project, Restricted Project

May 13 2022

paulkirth accepted D125597: [libcxxabi] Copy headers into build location.

LGTM, given that the patch basically restores the code removed in D120727.

May 13 2022, 8:46 PM · Restricted Project, Restricted Project
paulkirth added a comment to D124673: [llvm][lldb] use FindLibEdit.cmake everywhere.

It's probably fine to reland this after D125570 lands, since that should unblock us.

May 13 2022, 10:57 AM · Restricted Project, Restricted Project, Restricted Project
paulkirth accepted D125570: [CMake] Disable libedit in Fuchsia toolchain.

LGTM.

May 13 2022, 10:50 AM · Restricted Project, Restricted Project
paulkirth added a comment to D120727: [libc++] Overhaul how we select the ABI library.

Hi, we're seeing some failures in Fuchsia's Clang CI. Our runtimes build seems to be unable to find cxxabi.h.

May 13 2022, 10:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
paulkirth added a comment to D124673: [llvm][lldb] use FindLibEdit.cmake everywhere.

Hi, Sorry for the late notification, but I think this change may not apply correctly to all configs.

May 13 2022, 10:08 AM · Restricted Project, Restricted Project, Restricted Project

May 10 2022

paulkirth added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

@ldionne I think this brings everything up correctly on the windows front. thoughts?

May 10 2022, 12:07 PM · Restricted Project, Restricted Project

May 5 2022

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Don't reintroduce LIBCXX-WINDOWS-FIXME

May 5 2022, 2:30 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Go back to previous macros, but ensure that diagnostics checks are on the same line as the catch block

May 5 2022, 2:26 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Try to set XFAIL to stop bot failure when _HAS_EXCEPTIONS=0. Worked locally ...

May 5 2022, 10:04 AM · Restricted Project, Restricted Project

May 4 2022

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Detect when exceptions are disabled in the compiler, and disambiguate from the case when _HAS_EXCEPTIONS ==0

May 4 2022, 5:06 PM · Restricted Project, Restricted Project
paulkirth added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

ok, that broke this test in other configs. _HAS_EXCEPTIONS will also be set when we use -fno-exceptions so I should have thought of that issue.

May 4 2022, 4:30 PM · Restricted Project, Restricted Project
paulkirth added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

@mstorsjo Thanks for that idea, and you're right, it is very ugly, more so after formatting. Hopefully this will allow the final test to pass.

May 4 2022, 2:32 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Use preprocessor to avoid incorrect diagnostic checking when __HAS_EXCEPTIONS == 0

May 4 2022, 2:27 PM · Restricted Project, Restricted Project
paulkirth added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

I think you should extend test_macros.h to define TEST_HAS_EXCEPTIONS like this:

#if (!TEST_HAS_FEATURE(cxx_exceptions) && !defined(__cpp_exceptions) \
     && !defined(__EXCEPTIONS)) || \
    (defined(_HAS_EXCEPTIONS) && _HAS_EXCEPTIONS == 0) 
#define TEST_HAS_NO_EXCEPTIONS
#endif

As the _HAS_EXCEPTIONS=0 flag practically means that we should skip exception tests, so the no-exceptions testsuite feature flag should be set. But on the compiler level, exceptions aren't really disabled, so this test macro doesn't pick it up, but we maybe can make the test macro look at _HAS_EXCEPTIONS too. Or does that break other tests, if TEST_HAS_NO_EXCEPTIONS suddenly is defined in all tests?

May 4 2022, 1:24 PM · Restricted Project, Restricted Project

May 3 2022

paulkirth committed rG625e0e611b40: [BOLT] [NFC] Remove unused variable (authored by paulkirth).
[BOLT] [NFC] Remove unused variable
May 3 2022, 8:16 AM · Restricted Project
paulkirth closed D124588: [BOLT] [NFC] Remove unused variable.
May 3 2022, 8:16 AM · Restricted Project, Restricted Project
paulkirth updated the summary of D124588: [BOLT] [NFC] Remove unused variable.
May 3 2022, 8:13 AM · Restricted Project, Restricted Project
paulkirth retitled D124588: [BOLT] [NFC] Remove unused variable from [BOLT] Warn about the number of mismatched branches to [BOLT] [NFC] Remove unused variable.
May 3 2022, 8:13 AM · Restricted Project, Restricted Project

May 2 2022

paulkirth added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

so this is down to one failure: support/test.support/test_macros_header.no_exceptions.verify.cpp (https://buildkite.com/llvm-project/libcxx-ci/builds/10551#b46abad1-6a39-4118-8a86-b50e1aaab001).

May 2 2022, 6:07 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D124588: [BOLT] [NFC] Remove unused variable.

Since reporting mismatched branches here is redundant, we can just remove the unused variable

May 2 2022, 5:30 PM · Restricted Project, Restricted Project
paulkirth added a comment to D124588: [BOLT] [NFC] Remove unused variable.

Thanks for the feedback. Removing the variable was another approach I considered, but it seemed important. Since its redundant, I'll just update the patch as you've suggested.

May 2 2022, 5:27 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Re-run clang-format on code, since git clang-format fails to format it correctly

May 2 2022, 2:34 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Rebase and fix accidental removal of LIBCPP_EXCEPTION_ABI macro outside of _HAS_EXCEPTIONS == 0 case

May 2 2022, 2:18 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Remove LIBCXX_EXCEPTION_ABI specifiers.

May 2 2022, 10:50 AM · Restricted Project, Restricted Project

Apr 29 2022

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

run clang-format

Apr 29 2022, 6:57 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Update class defs to match vcruntime_*.h definitions

Apr 29 2022, 5:30 PM · Restricted Project, Restricted Project
paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

change include to vcruntime.h to address bad definitions

Apr 29 2022, 11:34 AM · Restricted Project, Restricted Project

Apr 28 2022

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Move include outside of namespace & clean up changes to preprocessor checks

Apr 28 2022, 10:32 AM · Restricted Project, Restricted Project

Apr 27 2022

paulkirth added a comment to D124588: [BOLT] [NFC] Remove unused variable.

I'm unsure if this is the right thing to do here, but I wanted to fix the waring, or pull in someone who has better understanding of the right approach

Apr 27 2022, 5:39 PM · Restricted Project, Restricted Project
paulkirth requested review of D124588: [BOLT] [NFC] Remove unused variable.
Apr 27 2022, 5:38 PM · Restricted Project, Restricted Project

Apr 26 2022

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Use different approach to handling missing defintions.

Apr 26 2022, 5:26 PM · Restricted Project, Restricted Project
paulkirth committed rGa0b8ab1ba316: [BOLT][NFC] Fix warning for unqualified call to std::move (authored by paulkirth).
[BOLT][NFC] Fix warning for unqualified call to std::move
Apr 26 2022, 4:18 PM · Restricted Project
paulkirth closed D124482: [BOLT][NFC] Fix warning for unqualified call to std::move.
Apr 26 2022, 4:18 PM · Restricted Project, Restricted Project
paulkirth retitled D124482: [BOLT][NFC] Fix warning for unqualified call to std::move from [BOLT] Fix warning for unqualified call to std::move to [BOLT][NFC] Fix warning for unqualified call to std::move.
Apr 26 2022, 4:17 PM · Restricted Project, Restricted Project
paulkirth retitled D124482: [BOLT][NFC] Fix warning for unqualified call to std::move from [bolt] fix warning for unqualified call to std::move to [BOLT] Fix warning for unqualified call to std::move.
Apr 26 2022, 4:15 PM · Restricted Project, Restricted Project
paulkirth requested review of D124482: [BOLT][NFC] Fix warning for unqualified call to std::move.
Apr 26 2022, 3:00 PM · Restricted Project, Restricted Project

Apr 23 2022

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Try to make preprocessor conditions consistant

Apr 23 2022, 2:31 PM · Restricted Project, Restricted Project

Apr 22 2022

paulkirth updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Use unused parameter and remove noreturn specifier.

Apr 22 2022, 7:07 PM · Restricted Project, Restricted Project
paulkirth committed rG4683a2effa72: [llvm][misexpect] Avoid division by 0 when using sample profiling (authored by paulkirth).
[llvm][misexpect] Avoid division by 0 when using sample profiling
Apr 22 2022, 3:48 PM · Restricted Project, Restricted Project
paulkirth closed D124302: [llvm][misexpect] Avoid division by 0 when using sample profiling.
Apr 22 2022, 3:48 PM · Restricted Project, Restricted Project