Page MenuHomePhabricator

[llvm-readobj] Output valid JSON for GroupSections
Needs ReviewPublic

Authored by paulkirth on Oct 31 2022, 10:57 AM.

Details

Reviewers
jhenderson
Summary

The current implementation output the LLVM formatted heading for group
sections, which was not valid JSON. This patch provides two small
customization points that allow the heading to vary between the two
implementations, and another that allows the section members to be
output as valid JSON objects.

Diff Detail

Event Timeline

paulkirth created this revision.Oct 31 2022, 10:57 AM
Herald added a project: Restricted Project. · View Herald Transcript
paulkirth requested review of this revision.Oct 31 2022, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 10:57 AM

Please provide before and after examples, and test cases for the fix. Also, please fix the title to use "llvm-readobj" in the commit message/patch description, not simply "readobj".

jhenderson requested changes to this revision.Nov 1 2022, 1:31 AM
This revision now requires changes to proceed.Nov 1 2022, 1:31 AM
paulkirth updated this revision to Diff 483704.Dec 16 2022, 6:41 PM
paulkirth retitled this revision from [readobj] Output valid JSON for GroupSections to [llvm-readobj] Output valid JSON for GroupSections.
paulkirth edited the summary of this revision. (Show Details)

Rebase

  • avoid duplication in original patch
  • add tests to check the JSON and LLVM differences
paulkirth updated this revision to Diff 484088.Dec 19 2022, 2:49 PM

Rebase to fix patch application