This is an archive of the discontinued LLVM Phabricator instance.

[clang][llvm][doc] Add more information for the ABI change in FP16
ClosedPublic

Authored by pengfei on Aug 4 2022, 7:31 AM.

Diff Detail

Event Timeline

pengfei created this revision.Aug 4 2022, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2022, 7:31 AM
pengfei requested review of this revision.Aug 4 2022, 7:31 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 4 2022, 7:31 AM

This is for LLVM 15.0 release per to #56854.

Forgive me my bad English. Suggestions are welcome.

kparzysz accepted this revision.Aug 4 2022, 7:39 AM

Thanks!

This revision is now accepted and ready to land.Aug 4 2022, 7:39 AM

@pengfei You can commit this directly to the release/15.x branch whenever you are ready.

pengfei closed this revision.Aug 4 2022, 7:21 PM

@pengfei You can commit this directly to the release/15.x branch whenever you are ready.

I see. Done. Thanks all!

mehdi_amini added inline comments.
clang/docs/ReleaseNotes.rst
633

Can you add a link to a documentation that describe the new ABI?

llvm/docs/ReleaseNotes.rst
206

(same here: users reading "switch it to the new ABI" will be confused as to what to do exactly)

pengfei added inline comments.Sep 26 2022, 8:38 PM
clang/docs/ReleaseNotes.rst
633

Here is the link for latest X86_64 psABI: https://gitlab.com/x86-psABIs/x86-64-ABI/-/wikis/uploads/01de35b2c8adc7545de52604cc45d942/x86-64-psABI-2021-05-20.pdf
I didn't put it there because the doc is esoteric for end user, and senior user should be able to find the doc theirself.
Besides, these release notes are intended for LLVM 15 release. Given we have dropped 2 versions already, I don't see much value to change it. But I'm fine if you insist it.