- User Since
- Mar 4 2014, 11:25 AM (311 w, 5 d)
Dec 12 2019
Oct 29 2019
Oct 25 2019
Dec 13 2018
@rnk, I agree that it is a performance optimization, and it actually is in the hot path. I can understand the motivation for the jump. I think that the trampoline might also be a problem for lldb as it (or used to?) statically analyzes to see if it is jumping to objc_msgSend (yes, it is ugly).
Nov 28 2018
I don't mind the separation, but, I don't see what makes this target specific still. I really think that we should have this be out-side of the target specific content, but having this in LLVM instead of the readobj tool makes sense. At the very least, I think that we need to fix the big endian case.
Sep 24 2018
Sep 6 2018
Jun 5 2015
May 29 2015
Mar 9 2015
Feb 25 2015
Feb 24 2015
Feb 4 2015
The header doesn't have anything that is version specific, so I believe that this is safe for all the versions that we support.
Jan 5 2015
Dec 30 2014
Dec 16 2014
Address rnk's comments.
Catch the constant folding in Sema (thanks for pointing out that was possible rnk!)
Emit inserts exactly a single instruction. It provides no guarantees of the state, so I don't think that we need to worry about LLVM doing something like inserting spills.
Dec 8 2014
Dec 5 2014
Address review comments from majnemer
Dec 4 2014
Nov 12 2014
Seems that I can't close the revision :-(.
Nov 7 2014
Committed in SVN r221548 with the recommended change.
Nov 5 2014
Oct 31 2014
Address Jim's comments about reducing duplication and some error handling.
Oct 21 2014
Seems that an alternative implementation has been committed.
Oct 17 2014
Address a number of Jim's comments.
Given that the move will simplify the diff, I've addressed the inline comments and move into Utils from its own directory. I'll see about restructuring the descriptors to private from public. If clang ever needs to generate the descriptors, we can make them public then. Better to make as many of the types opaque as possible.
Jul 21 2014
Jul 18 2014
Jun 25 2014
Jun 20 2014
Jun 19 2014
Jun 18 2014
Fix Intrin.h with minor oversights caught by Warren.
Address comments from rnk.
Jun 17 2014
@rnk, Im a bit confused here. Why do I need the I constraint for __emit? Isnt I an immediate integer valid for a data operation? The __emit takes an unsigned long and emits that long constant as an instruction.
Jun 16 2014
SVN r211032 with a small fixup at SVN r211035.
Jun 15 2014
Use __ARM_ARCH_ISA_THUMB introduced in SVN r210991.
Jun 13 2014
It would be nice to have similar tests for the Itanium ABI, but I suspect that you are less interested in that.
Jun 12 2014
Make getLinkerFileListName more similar to getDependencyFileName. Add an assertion. Tweak some variable names as per review comments.
Jun 11 2014
Jun 9 2014
Jun 7 2014
As Jim mentioned at the beginning, that there is some overhead to this, and enabling this unconditionally seems a bit heavy handed. By improving the driver to be a bit more similar to gcc (adding support for -mlong-calls/-mno-long-calls), we can enable this as and when it is needed as the linker should indicate that the jump target is out of range.
Jun 6 2014
May 31 2014
This has been committed already, just closing off the revision.
May 15 2014
Apr 29 2014
I believe that should be correctly handled by the bundling approach (SVN r207608). It can always be resurrected if necessary.
I think everyone agrees that this is not a particularly pretty solution. Given that any case of the bundle being split up should be considered a bug, I think that there is no reason to hold up other changes on this. This addresses all but one case: the constant island pass. I've committed a change with the bundling approach with a bit more aggressive reorder prevention. The constant island handling will have to be addressed separately and we can discuss how to best handle that separately.
Apr 25 2014
Committed as SVN r207246.
Committed as SVN r207243.
Committed with the suggested changes as SVN r207242.
Apr 24 2014
Update to use new @llvm.arm.hint intrinsic as per the suggestion of Tim.
Hmm, seems that phabricator truncated your message Tim.