Page MenuHomePhabricator

abdulras (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2014, 11:25 AM (258 w, 5 d)

Recent Activity

Dec 13 2018

abdulras added a comment to D55229: [COFF] Statically link certain runtime library functions.

@rnk, I agree that it is a performance optimization, and it actually is in the hot path. I can understand the motivation for the jump. I think that the trampoline might also be a problem for lldb as it (or used to?) statically analyzes to see if it is jumping to objc_msgSend (yes, it is ugly).

Dec 13 2018, 6:11 PM

Nov 28 2018

abdulras requested changes to D52822: [llvm-readobj][AMDGPU] Moved AMDGPU-specific note record dumping into target.

I don't mind the separation, but, I don't see what makes this target specific still. I really think that we should have this be out-side of the target specific content, but having this in LLVM instead of the readobj tool makes sense. At the very least, I think that we need to fix the big endian case.

Nov 28 2018, 1:47 PM

Sep 24 2018

abdulras added inline comments to D52210: [LLVM-C] Add C APIs to access DebugLoc info.
Sep 24 2018, 8:05 AM

Sep 6 2018

abdulras accepted D51759: [llvm] Improve the performance of getSymbols used by ArchiveWriter .
Sep 6 2018, 5:02 PM

Jun 5 2015

abdulras added inline comments to D9976: Refactor: Simplify boolean conditional return statements in llvm/lib/MC.
Jun 5 2015, 11:37 AM

May 29 2015

abdulras updated subscribers of D10111: [Object, MachO] Make MachO parser significantly more robust to invalid inputs..
May 29 2015, 11:42 AM

Mar 9 2015

abdulras closed D7418: cmath: account for MSVCRT 12.0 changes.

SVN r230867.

Mar 9 2015, 10:16 AM

Feb 25 2015

abdulras updated the diff for D7872: DebugInfo: hoist definition into global context when needed.
Feb 25 2015, 8:33 AM

Feb 24 2015

abdulras added inline comments to D7872: DebugInfo: hoist definition into global context when needed.
Feb 24 2015, 4:59 PM
abdulras retitled D7872: DebugInfo: hoist definition into global context when needed from to DebugInfo: hoist definition into global context when needed.
Feb 24 2015, 3:12 PM

Feb 4 2015

abdulras retitled D7420: Handle function name conflicts in _LIBCPP_MSVCRT mode from to Handle function name conflicts in _LIBCPP_MSVCRT mode.
Feb 4 2015, 3:35 PM
abdulras retitled D7418: cmath: account for MSVCRT 12.0 changes from to cmath: account for MSVCRT 12.0 changes.
Feb 4 2015, 2:33 PM
abdulras added a comment to D7417: cctype: tweak inclusions for _LIBCPP_MSVCRT case.

The header doesn't have anything that is version specific, so I believe that this is safe for all the versions that we support.

Feb 4 2015, 2:21 PM
abdulras updated subscribers of D7417: cctype: tweak inclusions for _LIBCPP_MSVCRT case.
Feb 4 2015, 2:11 PM
abdulras retitled D7417: cctype: tweak inclusions for _LIBCPP_MSVCRT case from to cctype: tweak inclusions for _LIBCPP_MSVCRT case.
Feb 4 2015, 2:08 PM

Jan 5 2015

abdulras added a reviewer for D6813: Driver: begin threading frontend support for SymbolRewriter: echristo.
Jan 5 2015, 9:56 AM

Dec 30 2014

abdulras retitled D6813: Driver: begin threading frontend support for SymbolRewriter from to Driver: begin threading frontend support for SymbolRewriter.
Dec 30 2014, 4:05 PM

Dec 16 2014

abdulras updated the diff for D3489: CodeGen: implement __emit intrinsic.

Address rnk's comments.

Dec 16 2014, 2:50 PM
abdulras added inline comments to D3489: CodeGen: implement __emit intrinsic.
Dec 16 2014, 2:09 PM
abdulras updated the diff for D3489: CodeGen: implement __emit intrinsic.

Catch the constant folding in Sema (thanks for pointing out that was possible rnk!)

Dec 16 2014, 9:51 AM
abdulras added a comment to D3489: CodeGen: implement __emit intrinsic.

Emit inserts exactly a single instruction. It provides no guarantees of the state, so I don't think that we need to worry about LLVM doing something like inserting spills.

Dec 16 2014, 9:33 AM

Dec 8 2014

abdulras edited reviewers for D6547: [compiler-rt] Upstreaming small changes from the Rust project., added: compnerd; removed: abdulras.
Dec 8 2014, 12:47 PM

Dec 5 2014

abdulras updated the diff for D3489: CodeGen: implement __emit intrinsic.

Address review comments from majnemer

Dec 5 2014, 5:11 PM

Dec 4 2014

abdulras added inline comments to D3489: CodeGen: implement __emit intrinsic.
Dec 4 2014, 3:10 PM
abdulras updated the diff for D3489: CodeGen: implement __emit intrinsic.
Dec 4 2014, 9:43 AM

Nov 12 2014

abdulras abandoned D3161: SymbolRewriter: introduce the SymbolRewriter pass.

Seems that I can't close the revision :-(.

Nov 12 2014, 11:35 AM

Nov 7 2014

abdulras added a comment to D3161: SymbolRewriter: introduce the SymbolRewriter pass.

Committed in SVN r221548 with the recommended change.

Nov 7 2014, 4:14 PM
abdulras accepted D3161: SymbolRewriter: introduce the SymbolRewriter pass.
Nov 7 2014, 4:13 PM
abdulras added inline comments to D3161: SymbolRewriter: introduce the SymbolRewriter pass.
Nov 7 2014, 12:57 PM

Nov 5 2014

abdulras added a reviewer for D6145: Fix for nasty LTO issue that's most obvious in ObjectiveC.: rafael.
Nov 5 2014, 4:03 PM

Oct 31 2014

abdulras updated the diff for D3161: SymbolRewriter: introduce the SymbolRewriter pass.

Address Jim's comments about reducing duplication and some error handling.

Oct 31 2014, 1:30 PM

Oct 21 2014

abdulras abandoned D4104: Driver: generate file lists to pass through to linkers.

Seems that an alternative implementation has been committed.

Oct 21 2014, 9:26 AM

Oct 17 2014

abdulras updated the diff for D3161: SymbolRewriter: introduce the SymbolRewriter pass.

Address a number of Jim's comments.

Oct 17 2014, 4:21 PM
abdulras added a comment to D3161: SymbolRewriter: introduce the SymbolRewriter pass.

Given that the move will simplify the diff, I've addressed the inline comments and move into Utils from its own directory. I'll see about restructuring the descriptors to private from public. If clang ever needs to generate the descriptors, we can make them public then. Better to make as many of the types opaque as possible.

Oct 17 2014, 4:20 PM

Jul 21 2014

abdulras added inline comments to D4594: [libcxx] Add support for Android targets to lit.cfg..
Jul 21 2014, 11:59 AM

Jul 18 2014

abdulras added a reviewer for D3161: SymbolRewriter: introduce the SymbolRewriter pass: grosbach.
Jul 18 2014, 3:15 PM
abdulras updated the diff for D3161: SymbolRewriter: introduce the SymbolRewriter pass.
Jul 18 2014, 2:25 PM

Jun 25 2014

abdulras closed D3558: Headers: be a bit more careful about inline asm.

SVN r211716.

Jun 25 2014, 11:15 AM

Jun 20 2014

abdulras added a comment to D4161: compiler-rt: add support for building for Windows.

ping

Jun 20 2014, 6:05 PM

Jun 19 2014

abdulras closed D4182: CodeGen: improve ms instrincics support.
Jun 19 2014, 8:23 AM

Jun 18 2014

abdulras added inline comments to D4182: CodeGen: improve ms instrincics support.
Jun 18 2014, 1:49 PM
abdulras added inline comments to D4182: CodeGen: improve ms instrincics support.
Jun 18 2014, 12:53 PM
abdulras updated the diff for D4182: CodeGen: improve ms instrincics support.

Fix Intrin.h with minor oversights caught by Warren.

Jun 18 2014, 10:56 AM
abdulras added inline comments to D4182: CodeGen: improve ms instrincics support.
Jun 18 2014, 10:47 AM
abdulras updated the diff for D4182: CodeGen: improve ms instrincics support.

Address comments from rnk.

Jun 18 2014, 8:31 AM

Jun 17 2014

abdulras retitled D4182: CodeGen: improve ms instrincics support from to CodeGen: improve ms instrincics support.
Jun 17 2014, 1:47 PM
abdulras updated subscribers of D4180: [x32] Add X32 support to driver.
Jun 17 2014, 11:44 AM
abdulras added a comment to D3489: CodeGen: implement __emit intrinsic.

@rnk, Im a bit confused here. Why do I need the I constraint for __emit? Isnt I an immediate integer valid for a data operation? The __emit takes an unsigned long and emits that long constant as an instruction.

Jun 17 2014, 11:31 AM
abdulras added a comment to D4104: Driver: generate file lists to pass through to linkers.

ping

Jun 17 2014, 11:27 AM

Jun 16 2014

abdulras closed D3980: compiler-rt: prefer thumb over ARM.

SVN r211032 with a small fixup at SVN r211035.

Jun 16 2014, 10:46 AM
abdulras accepted D3980: compiler-rt: prefer thumb over ARM.
Jun 16 2014, 10:46 AM

Jun 15 2014

abdulras updated the diff for D3980: compiler-rt: prefer thumb over ARM.

Use __ARM_ARCH_ISA_THUMB introduced in SVN r210991.

Jun 15 2014, 12:07 PM

Jun 13 2014

abdulras added a comment to D4136: Inherit dll attributes to static locals.

It would be nice to have similar tests for the Itanium ABI, but I suspect that you are less interested in that.

Jun 13 2014, 11:15 AM
abdulras added a reviewer for D4104: Driver: generate file lists to pass through to linkers: echristo.
Jun 13 2014, 10:04 AM

Jun 12 2014

abdulras updated the diff for D4104: Driver: generate file lists to pass through to linkers.

Make getLinkerFileListName more similar to getDependencyFileName. Add an assertion. Tweak some variable names as per review comments.

Jun 12 2014, 9:40 AM

Jun 11 2014

abdulras retitled D4104: Driver: generate file lists to pass through to linkers from to Driver: add support for linker file lists.
Jun 11 2014, 2:40 PM
abdulras closed D4050: ARM: add VLA extension for WoA Itanium ABI.
Jun 11 2014, 12:59 PM

Jun 9 2014

abdulras updated the diff for D4050: ARM: add VLA extension for WoA Itanium ABI.
Jun 9 2014, 10:19 AM
abdulras added inline comments to D4050: ARM: add VLA extension for WoA Itanium ABI.
Jun 9 2014, 10:18 AM
abdulras updated subscribers of D4050: ARM: add VLA extension for WoA Itanium ABI.
Jun 9 2014, 9:23 AM
abdulras added a reviewer for D3980: compiler-rt: prefer thumb over ARM: deleted.
Jun 9 2014, 9:21 AM

Jun 7 2014

abdulras abandoned D3247: ARM: enable long calls for WoA.

As Jim mentioned at the beginning, that there is some overhead to this, and enabling this unconditionally seems a bit heavy handed. By improving the driver to be a bit more similar to gcc (adding support for -mlong-calls/-mno-long-calls), we can enable this as and when it is needed as the linker should indicate that the jump target is out of range.

Jun 7 2014, 1:10 PM

Jun 6 2014

abdulras retitled D4050: ARM: add VLA extension for WoA Itanium ABI from to ARM: add VLA extension for WoA Itanium ABI.
Jun 6 2014, 4:06 PM

May 31 2014

abdulras retitled D3980: compiler-rt: prefer thumb over ARM from to compiler-rt: prefer thumb over ARM.
May 31 2014, 3:23 PM
abdulras closed D3255: ARM: support stack probe emission for Windows on ARM.
May 31 2014, 3:20 PM
abdulras accepted D3255: ARM: support stack probe emission for Windows on ARM.

This has been committed already, just closing off the revision.

May 31 2014, 3:20 PM

May 15 2014

abdulras updated subscribers of D3772: Allow dllimport/dllexport on inline functions and get the linkage right.
May 15 2014, 1:32 PM

Apr 29 2014

abdulras abandoned D3264: T2 ITBlock: add support for Windows specific relocation handling.

I believe that should be correctly handled by the bundling approach (SVN r207608). It can always be resurrected if necessary.

Apr 29 2014, 10:06 PM
abdulras abandoned D3254: ARM: Windows on ARM Hazard recognition support.

I think everyone agrees that this is not a particularly pretty solution. Given that any case of the bundle being split up should be considered a bug, I think that there is no reason to hold up other changes on this. This addresses all but one case: the constant island pass. I've committed a change with the bundling approach with a bit more aggressive reorder prevention. The constant island handling will have to be addressed separately and we can discuss how to best handle that separately.

Apr 29 2014, 10:04 PM

Apr 25 2014

abdulras closed D3496: ARM: remove @llvm.arm.sevl intrinsic.
Apr 25 2014, 10:58 AM
abdulras accepted D3496: ARM: remove @llvm.arm.sevl intrinsic.

Committed as SVN r207246.

Apr 25 2014, 10:58 AM
abdulras closed D3495: CodeGen: remove use of @llvm.arm.sevl.
Apr 25 2014, 10:34 AM
abdulras accepted D3495: CodeGen: remove use of @llvm.arm.sevl.

Committed as SVN r207243.

Apr 25 2014, 10:34 AM
abdulras closed D3492: ARM: provide a generic hint intrinsic.
Apr 25 2014, 10:33 AM
abdulras accepted D3492: ARM: provide a generic hint intrinsic.

Committed with the suggested changes as SVN r207242.

Apr 25 2014, 10:33 AM

Apr 24 2014

abdulras retitled D3496: ARM: remove @llvm.arm.sevl intrinsic from to ARM: remove @llvm.arm.sevl intrinsic.
Apr 24 2014, 4:09 PM
abdulras retitled D3495: CodeGen: remove use of @llvm.arm.sevl from to CodeGen: remove use of @llvm.arm.sevl.
Apr 24 2014, 4:06 PM
abdulras updated the diff for D3489: CodeGen: implement __emit intrinsic.

Update to use new @llvm.arm.hint intrinsic as per the suggestion of Tim.

Apr 24 2014, 3:21 PM
abdulras updated subscribers of D3492: ARM: provide a generic hint intrinsic.
Apr 24 2014, 3:20 PM
abdulras retitled D3492: ARM: provide a generic hint intrinsic from to ARM: provide a generic hint intrinsic.
Apr 24 2014, 3:17 PM
abdulras added a comment to D3489: CodeGen: implement __emit intrinsic.

Hmm, seems that phabricator truncated your message Tim.

Apr 24 2014, 1:05 PM
abdulras updated D3489: CodeGen: implement __emit intrinsic.
Apr 24 2014, 11:41 AM
abdulras retitled D3489: CodeGen: implement __emit intrinsic from to CodeGen: implement __emit and __yield intrinsics.
Apr 24 2014, 11:41 AM