kparzysz (Krzysztof Parzyszek)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2014, 4:27 PM (195 w, 5 d)

Recent Activity

Wed, Jan 17

kparzysz added a comment to D42191: [RFC] [TargetTransformInfo] Introduce isRegisterRich, it returns true if the target architecture is register-rich..

There is already a function getNumberOfRegisters. Would it be enough to return some large number from it?

Wed, Jan 17, 12:23 PM

Mon, Jan 15

kparzysz committed rL322499: [Hexagon] Implement signed and unsigned multiply-high for vectors.
[Hexagon] Implement signed and unsigned multiply-high for vectors
Mon, Jan 15, 10:45 AM
kparzysz committed rL322498: [Hexagon] Rewrite LowerVECTOR_SHUFFLE for 32-/64-bit vectors.
[Hexagon] Rewrite LowerVECTOR_SHUFFLE for 32-/64-bit vectors
Mon, Jan 15, 10:35 AM

Thu, Jan 11

kparzysz committed rL322303: [Hexagon] Fix building 64-bit vector from constant values.
[Hexagon] Fix building 64-bit vector from constant values
Thu, Jan 11, 10:32 AM
kparzysz committed rL322301: [Hexagon] Cast elements to correct type when creating constant vector.
[Hexagon] Cast elements to correct type when creating constant vector
Thu, Jan 11, 10:04 AM
kparzysz committed rL322299: [Hexagon] Impose limits on container sizes in HexagonGenInsert.
[Hexagon] Impose limits on container sizes in HexagonGenInsert
Thu, Jan 11, 10:03 AM
kparzysz committed rL322298: [Hexagon] Use SetVector when queuing nodes to scan in selectVectorConstants.
[Hexagon] Use SetVector when queuing nodes to scan in selectVectorConstants
Thu, Jan 11, 10:01 AM

Wed, Jan 10

kparzysz added inline comments to D40805: [RISCV] Support for varargs.
Wed, Jan 10, 11:31 AM
kparzysz added inline comments to D40805: [RISCV] Support for varargs.
Wed, Jan 10, 11:19 AM

Tue, Jan 9

kparzysz added a comment to D41870: [CodeGen] Don't print "pred:" and "opt:" in -debug output.

I agree that having the extra "pred:" and "opt:" would make understanding easier in debugging situations but I would consider that secondary

Tue, Jan 9, 10:19 AM

Fri, Jan 5

kparzysz committed rL321908: [Hexagon] Even simpler patterns for sign- and zero-extending HVX vectors.
[Hexagon] Even simpler patterns for sign- and zero-extending HVX vectors
Fri, Jan 5, 2:32 PM
kparzysz committed rL321904: Revert r321894: it requires a part of another commit that is not ready yet.
Revert r321894: it requires a part of another commit that is not ready yet
Fri, Jan 5, 1:58 PM
kparzysz committed rL321902: Revert r321897: affected testcases were not updated.
Revert r321897: affected testcases were not updated
Fri, Jan 5, 1:51 PM
kparzysz committed rL321897: [Hexagon] Even simpler patterns for sign- and zero-extending HVX vectors.
[Hexagon] Even simpler patterns for sign- and zero-extending HVX vectors
Fri, Jan 5, 12:50 PM
kparzysz committed rL321895: [Hexagon] Add patterns for truncating HVX vector types.
[Hexagon] Add patterns for truncating HVX vector types
Fri, Jan 5, 12:49 PM
kparzysz committed rL321894: [Hexagon] Add patterns for sext_inreg of HVX vector types.
[Hexagon] Add patterns for sext_inreg of HVX vector types
Fri, Jan 5, 12:48 PM
kparzysz committed rL321893: [Hexagon] Add a bitcast to required type in LowerHvxMul.
[Hexagon] Add a bitcast to required type in LowerHvxMul
Fri, Jan 5, 12:46 PM
kparzysz committed rL321892: [Hexagon] Add pattern for vsplat to v8i8.
[Hexagon] Add pattern for vsplat to v8i8
Fri, Jan 5, 12:45 PM
kparzysz committed rL321891: [Hexagon] Set boolean contents in HexagonISelLowering.
[Hexagon] Set boolean contents in HexagonISelLowering
Fri, Jan 5, 12:42 PM

Thu, Jan 4

kparzysz committed rL321798: [Hexagon] Replace INSERTRP/EXTRACTRP with INSERT/EXTRACT in HexagonISD.
[Hexagon] Replace INSERTRP/EXTRACTRP with INSERT/EXTRACT in HexagonISD
Thu, Jan 4, 5:57 AM

Wed, Jan 3

kparzysz added inline comments to D41634: Branch relaxation - non invertible condition.
Wed, Jan 3, 12:56 PM

Tue, Jan 2

kparzysz committed rL321650: [Hexagon] Fix generation of vector sign extensions.
[Hexagon] Fix generation of vector sign extensions
Tue, Jan 2, 7:30 AM

Dec 21 2017

kparzysz committed rL321282: [TableGen] Print more helpful information in case of type contradiction.
[TableGen] Print more helpful information in case of type contradiction
Dec 21 2017, 9:13 AM

Dec 20 2017

kparzysz committed rL321221: [Hexagon] Use ArrayRef member functions instead of custom ones.
[Hexagon] Use ArrayRef member functions instead of custom ones
Dec 20 2017, 12:55 PM
kparzysz committed rL321220: [Hexagon] Allow construction of HVX vector predicates.
[Hexagon] Allow construction of HVX vector predicates
Dec 20 2017, 12:50 PM
kparzysz committed rL321218: [Hexagon] Legalize vector elements to i32 in buildVector32/64.
[Hexagon] Legalize vector elements to i32 in buildVector32/64
Dec 20 2017, 12:34 PM
kparzysz committed rL321180: Add optional SelectionDAG* parameter to SValue::dump and SDValue::dumpr.
Add optional SelectionDAG* parameter to SValue::dump and SDValue::dumpr
Dec 20 2017, 7:15 AM
kparzysz committed rL321177: [Hexagon] Adjust the value type for BCvt in LowerFormalArguments.
[Hexagon] Adjust the value type for BCvt in LowerFormalArguments
Dec 20 2017, 6:45 AM
kparzysz added a comment to D41029: [JumpTables][PowerPC] Let targets decide which switch instructions are suitable for jump tables.

Given that the plan to make the functions in TargetLowering virtual is generally accepted, could you commit that part? This would solve a problem we're facing in some downstream code.

Dec 20 2017, 6:14 AM

Dec 18 2017

kparzysz committed rL321034: [Hexagon] Cache loads to select to avoid traversing mutating DAG.
[Hexagon] Cache loads to select to avoid traversing mutating DAG
Dec 18 2017, 3:14 PM
kparzysz committed rL321008: [Hexagon] Higher versions of HVX imply presence of lower versions.
[Hexagon] Higher versions of HVX imply presence of lower versions
Dec 18 2017, 10:52 AM
kparzysz committed rL321005: i[Hexagon] ANY_EXTEND_VECTOR_INREG should be Custom, not Legal in r321004.
i[Hexagon] ANY_EXTEND_VECTOR_INREG should be Custom, not Legal in r321004
Dec 18 2017, 10:42 AM
kparzysz committed rL321004: [Hexagon] Generate HVX code for vector sign-, zero- and any-extends.
[Hexagon] Generate HVX code for vector sign-, zero- and any-extends
Dec 18 2017, 10:33 AM
kparzysz committed rL321002: [Hexagon] Prefer to widen HVX vectors instead of promoting.
[Hexagon] Prefer to widen HVX vectors instead of promoting
Dec 18 2017, 10:21 AM

Dec 16 2017

kparzysz accepted D41325: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.

It works.

Dec 16 2017, 2:48 PM

Dec 15 2017

kparzysz committed rL320866: [Hexagon] Remove recursion in visitUsesOf, replace with use queue.
[Hexagon] Remove recursion in visitUsesOf, replace with use queue
Dec 15 2017, 1:34 PM
kparzysz committed rL320865: [Hexagon] Handle concat_vectors of all allowed HVX types.
[Hexagon] Handle concat_vectors of all allowed HVX types
Dec 15 2017, 1:24 PM
kparzysz committed rL320855: [Hexagon] Fix operand-swapping PatFrag for atomic stores.
[Hexagon] Fix operand-swapping PatFrag for atomic stores
Dec 15 2017, 12:14 PM

Dec 14 2017

kparzysz committed rL320744: [Hexagon] Generate HVX code for comparisons and selects.
[Hexagon] Generate HVX code for comparisons and selects
Dec 14 2017, 1:29 PM
kparzysz committed rL320732: Add MVT::v128i1, NFC.
Add MVT::v128i1, NFC
Dec 14 2017, 11:06 AM
kparzysz committed rL320722: [Hexagon] Remove vectors of i64 from valid HVX types.
[Hexagon] Remove vectors of i64 from valid HVX types
Dec 14 2017, 10:36 AM

Dec 13 2017

kparzysz committed rC320609: [Hexagon] Intrinsic support for V62 and V65.
[Hexagon] Intrinsic support for V62 and V65
Dec 13 2017, 11:57 AM
kparzysz committed rL320609: [Hexagon] Intrinsic support for V62 and V65.
[Hexagon] Intrinsic support for V62 and V65
Dec 13 2017, 11:56 AM
kparzysz committed rC320579: [Hexagon] Add front-end support for Hexagon V65.
[Hexagon] Add front-end support for Hexagon V65
Dec 13 2017, 5:49 AM
kparzysz committed rL320579: [Hexagon] Add front-end support for Hexagon V65.
[Hexagon] Add front-end support for Hexagon V65
Dec 13 2017, 5:48 AM

Dec 12 2017

kparzysz committed rL320529: [Hexagon] Relax some checks in testcases, NFC.
[Hexagon] Relax some checks in testcases, NFC
Dec 12 2017, 1:44 PM
kparzysz committed rL320523: [Hexagon] Better detection of identity and undef masks in shuffles.
[Hexagon] Better detection of identity and undef masks in shuffles
Dec 12 2017, 12:24 PM
kparzysz committed rL320516: [Hexagon] Fix wrong order of operands for vmux.
[Hexagon] Fix wrong order of operands for vmux
Dec 12 2017, 11:33 AM

Dec 11 2017

kparzysz committed rC320410: [Hexagon] Remove unsupported vlut intrinsics.
[Hexagon] Remove unsupported vlut intrinsics
Dec 11 2017, 11:30 AM
kparzysz committed rL320410: [Hexagon] Remove unsupported vlut intrinsics.
[Hexagon] Remove unsupported vlut intrinsics
Dec 11 2017, 11:30 AM
kparzysz committed rL320404: [Hexagon] Add support for Hexagon V65.
[Hexagon] Add support for Hexagon V65
Dec 11 2017, 10:59 AM
kparzysz committed rL320369: [Hexagon] Crash in instruction selection for insert_vector_elt for HVX.
[Hexagon] Crash in instruction selection for insert_vector_elt for HVX
Dec 11 2017, 6:46 AM

Dec 10 2017

kparzysz accepted D39848: [RISCV] Support lowering FrameIndex.

Yes, LGTM.

Dec 10 2017, 2:22 PM

Dec 7 2017

kparzysz added inline comments to D39848: [RISCV] Support lowering FrameIndex.
Dec 7 2017, 1:33 PM
kparzysz committed rL320063: [Hexagon] Generate HVX code for basic arithmetic operations.
[Hexagon] Generate HVX code for basic arithmetic operations
Dec 7 2017, 9:38 AM

Dec 6 2017

kparzysz committed rL319978: [Hexagon] Recognize vdealb, vdealh, vshuffb and vshuffh specifically.
[Hexagon] Recognize vdealb, vdealh, vshuffb and vshuffh specifically
Dec 6 2017, 2:42 PM
kparzysz committed rL319965: [Hexagon] Handle perfect shuffles on single vectors.
[Hexagon] Handle perfect shuffles on single vectors
Dec 6 2017, 1:25 PM
kparzysz committed rL319901: [Hexagon] Generate HVX code for vector construction and access.
[Hexagon] Generate HVX code for vector construction and access
Dec 6 2017, 8:41 AM
kparzysz added a comment to D39845: [TableGen] Give the option of tolerating duplicate register names.

Sorry, I wasn't clear in my last comment. This comment doesn't add any new information, it's just a clarification.

Dec 6 2017, 8:21 AM

Dec 5 2017

kparzysz added a comment to D39845: [TableGen] Give the option of tolerating duplicate register names.

I think that leaving the returned value unspecified is better, at least for now. Otherwise, we'd need to invent a way to identify the "preferred" register, and then it would need to be preserved by any future modifications to the MatchRegisterName et.al. functions.

Dec 5 2017, 2:01 PM
kparzysz added inline comments to D38778: Implement rudimentary support for the PowerPC SPE APU.
Dec 5 2017, 8:25 AM
kparzysz accepted D39845: [TableGen] Give the option of tolerating duplicate register names.

Makes sense. LGTM.

Dec 5 2017, 7:56 AM

Nov 30 2017

kparzysz committed rL319477: [Hexagon] Implement HexagonSubtarget::useAA().
[Hexagon] Implement HexagonSubtarget::useAA()
Nov 30 2017, 1:26 PM
kparzysz committed rL319476: [Hexagon] Fix wrong check in test/CodeGen/Hexagon/newvaluejump-solo.mir.
[Hexagon] Fix wrong check in test/CodeGen/Hexagon/newvaluejump-solo.mir
Nov 30 2017, 1:23 PM
kparzysz committed rL319471: [Hexagon] Fix wrong pass in testcase.
[Hexagon] Fix wrong pass in testcase
Nov 30 2017, 12:39 PM
kparzysz committed rL319470: [Hexagon] Solo instructions cannot be used with new value jumps.
[Hexagon] Solo instructions cannot be used with new value jumps
Nov 30 2017, 12:33 PM

Nov 29 2017

kparzysz committed rL319352: [Hexagon] Remove HexagonISD::PACKHL.
[Hexagon] Remove HexagonISD::PACKHL
Nov 29 2017, 12:00 PM
kparzysz committed rL319351: [Hexagon] Create helpers extractVector and insertVector in lowering.
[Hexagon] Create helpers extractVector and insertVector in lowering
Nov 29 2017, 11:58 AM

Nov 28 2017

kparzysz committed rL319204: [Hexagon] Make sure to zero-extend bytes before building a vector.
[Hexagon] Make sure to zero-extend bytes before building a vector
Nov 28 2017, 11:13 AM

Nov 27 2017

kparzysz created D40509: Add phony registers for high words in 32-bit X86 registers.
Nov 27 2017, 11:16 AM
kparzysz accepted D40227: [Hexagon] Use stable sort for HexagonShuffler to remove non-deterministic ordering.
Nov 27 2017, 10:53 AM
kparzysz committed rL319064: [Hexagon] Implement HexagonSubtarget::isHVXVectorType.
[Hexagon] Implement HexagonSubtarget::isHVXVectorType
Nov 27 2017, 10:12 AM

Nov 26 2017

kparzysz added a comment to D39845: [TableGen] Give the option of tolerating duplicate register names.

Just to add to my last comment---this patch is fine as is, but it would be nice to make the selection of the correct register easier.

Nov 26 2017, 10:15 AM

Nov 23 2017

kparzysz added a comment to D39845: [TableGen] Give the option of tolerating duplicate register names.

This looks reasonable to me. The only comment I have is that the patch does not make it clear what numeric register id exactly will be returned if there are several of them matching a given string. Currently, the numeric match is unique, but once we make it non-unique, the code in a target with "reused" names will need to handle getting a "wrong" register id. Let's take the testcase as an example---the user would need to write something like this:

if (Want32Bit) {
  // If we got a 64-bit register, map it to the 32-bit counterpart.
  switch (Reg) {
    case R0_64:
      Reg = R0_32;
      break;
    case R1_64:
      ...
  }
} else if (Want64Bit) {
  // If we got a 32-bit register, map it to the 64-bit counterpart.
  switch (Reg) {
    case R0_32:
      Reg = R0_64;
      break;
    case R1_32:
      ...
}
Nov 23 2017, 11:26 AM

Nov 22 2017

kparzysz committed rL318877: [Hexagon] Implement buildVector32 and buildVector64 as utility functions.
[Hexagon] Implement buildVector32 and buildVector64 as utility functions
Nov 22 2017, 12:56 PM
kparzysz committed rL318876: [Hexagon] Add patterns to select A2_combine_ll and its variants.
[Hexagon] Add patterns to select A2_combine_ll and its variants
Nov 22 2017, 12:56 PM
kparzysz committed rL318875: [Hexagon] Remove trailing spaces, NFC.
[Hexagon] Remove trailing spaces, NFC
Nov 22 2017, 12:43 PM

Nov 21 2017

kparzysz committed rL318807: [Hexagon] Add HexagonSubtarget::getVectorLength().
[Hexagon] Add HexagonSubtarget::getVectorLength()
Nov 21 2017, 2:13 PM
kparzysz committed rL318801: [Hexagon] Make sure that RDF does not remove EH_LABELs.
[Hexagon] Make sure that RDF does not remove EH_LABELs
Nov 21 2017, 1:08 PM
kparzysz added a comment to D39848: [RISCV] Support lowering FrameIndex.

FrameIndex cannot be matched directly in patterns, but it can be matched by a ComplexPattern, which then can be used in selection patterns.

Nov 21 2017, 1:04 PM

Nov 16 2017

kparzysz added a comment to D39848: [RISCV] Support lowering FrameIndex.

Why do you want the special load/store instructions?

Nov 16 2017, 12:51 PM

Nov 10 2017

kparzysz committed rL317921: Recommit r317904: [Hexagon] Create HexagonISelDAGToDAG.h, NFC.
Recommit r317904: [Hexagon] Create HexagonISelDAGToDAG.h, NFC
Nov 10 2017, 12:10 PM
kparzysz committed rL317916: Revert "[Hexagon] Create HexagonISelDAGToDAG.h, NFC".
Revert "[Hexagon] Create HexagonISelDAGToDAG.h, NFC"
Nov 10 2017, 11:27 AM
kparzysz committed rL317904: [Hexagon] Create HexagonISelDAGToDAG.h, NFC.
[Hexagon] Create HexagonISelDAGToDAG.h, NFC
Nov 10 2017, 10:40 AM
kparzysz committed rL317903: Allow separation of declarations and definitions in <Target>ISelDAGToDAG.inc.
Allow separation of declarations and definitions in <Target>ISelDAGToDAG.inc
Nov 10 2017, 10:36 AM
kparzysz closed D39596: Allow separation of declarations and definitions in <Target>ISelDAGToDAG.inc by committing rL317903: Allow separation of declarations and definitions in <Target>ISelDAGToDAG.inc.
Nov 10 2017, 10:36 AM

Nov 7 2017

kparzysz committed rL317592: [Hexagon] Make a test more flexible in HexagonLoopIdiomRecognition.
[Hexagon] Make a test more flexible in HexagonLoopIdiomRecognition
Nov 7 2017, 9:06 AM

Nov 3 2017

kparzysz added a comment to D39596: Allow separation of declarations and definitions in <Target>ISelDAGToDAG.inc.

Here's an example of what an .inc file will look like:

Nov 3 2017, 7:08 AM
kparzysz created D39596: Allow separation of declarations and definitions in <Target>ISelDAGToDAG.inc.
Nov 3 2017, 7:05 AM

Nov 2 2017

kparzysz committed rL317275: [Hexagon] Prefer L2_loadrub_io over L4_loadrub_rr.
[Hexagon] Prefer L2_loadrub_io over L4_loadrub_rr
Nov 2 2017, 2:57 PM
kparzysz added a comment to D36504: [CodeGenPrepare][WIP] Convert uncond. branch to return into a return to help with shrink-wrapping.

Thanks for the feedback. Can you elaborate a bit more on why we wouldn't want to do this in CodeGenPrepare?

Nov 2 2017, 10:53 AM
kparzysz added a comment to D36504: [CodeGenPrepare][WIP] Convert uncond. branch to return into a return to help with shrink-wrapping.

So I attempted this in the PreRA tail-duplication pass. Unfortunately by the time we get there the opportunity is gone. If we do not duplicate the return then CodegenPrepare will end up deleting the for.cond.cleanup.loopexit block and we loose the shrink wrapping opportunity.

Nov 2 2017, 7:53 AM

Oct 30 2017

kparzysz committed rL316904: [Hexagon] Allow the RDF optimizations to be run in .mir testcases.
[Hexagon] Allow the RDF optimizations to be run in .mir testcases
Oct 30 2017, 7:12 AM

Oct 27 2017

kparzysz committed rL316804: [Hexagon] Adjust patterns to reflect instruction selection preferences.
[Hexagon] Adjust patterns to reflect instruction selection preferences
Oct 27 2017, 3:25 PM
kparzysz committed rL316785: [Hexagon] Fix an incorrect assertion in HexagonConstExtenders.cpp.
[Hexagon] Fix an incorrect assertion in HexagonConstExtenders.cpp
Oct 27 2017, 11:53 AM
kparzysz added a comment to D36504: [CodeGenPrepare][WIP] Convert uncond. branch to return into a return to help with shrink-wrapping.

Isn't tail duplication a better place to do this?

Oct 27 2017, 3:48 AM

Oct 25 2017

kparzysz committed rL316601: [Hexagon] Account for negative offset when limiting max deviation.
[Hexagon] Account for negative offset when limiting max deviation
Oct 25 2017, 11:47 AM

Oct 23 2017

kparzysz committed rL316367: [Hexagon] Return the correct chain edge for i1 function calls.
[Hexagon] Return the correct chain edge for i1 function calls
Oct 23 2017, 12:36 PM
kparzysz committed rL316363: [Hexagon] Add extra pattern for S4_addaddi.
[Hexagon] Add extra pattern for S4_addaddi
Oct 23 2017, 12:10 PM

Oct 20 2017

kparzysz committed rL316243: [Packetizer] Add function to check for aliasing between instructions.
[Packetizer] Add function to check for aliasing between instructions
Oct 20 2017, 3:10 PM