Page MenuHomePhabricator

kparzysz (Krzysztof Parzyszek)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2014, 4:27 PM (428 w, 1 d)

Recent Activity

Jun 1 2022

kparzysz accepted D123096: [Hexagon] Enable IAS in the Hexagon backend.
Jun 1 2022, 7:36 AM · Restricted Project, Restricted Project

May 30 2022

kparzysz committed rGd65fa2c43cfa: [Hexagon] Widen vector types with non-power-of-2 element counts (authored by kparzysz).
[Hexagon] Widen vector types with non-power-of-2 element counts
May 30 2022, 12:58 PM · Restricted Project, Restricted Project
kparzysz added inline comments to D126401: [ADT] Explicitly delete copy/move constructors and operator= in IntervalMap.
May 30 2022, 7:15 AM · Restricted Project, Restricted Project

May 28 2022

kparzysz abandoned D125899: [ADT] Add copy constructor to IntervalMap.

Closing in favor of https://reviews.llvm.org/D125611.

May 28 2022, 7:27 AM · Restricted Project, Restricted Project

May 26 2022

kparzysz committed rGaee6b8efd09c: [ADT] Explicitly delete copy/move constructors and operator= in IntervalMap (authored by kparzysz).
[ADT] Explicitly delete copy/move constructors and operator= in IntervalMap
May 26 2022, 7:58 AM · Restricted Project, Restricted Project
kparzysz closed D126401: [ADT] Explicitly delete copy/move constructors and operator= in IntervalMap.
May 26 2022, 7:58 AM · Restricted Project, Restricted Project

May 25 2022

kparzysz added a comment to D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs.

If you want to submit a follow-up patch to disable copy/move (construction and assignment) for IntervalMap, that'd be great, otherwise I can do that once this lands.

May 25 2022, 11:26 AM · Restricted Project, Restricted Project
kparzysz requested review of D126401: [ADT] Explicitly delete copy/move constructors and operator= in IntervalMap.
May 25 2022, 11:24 AM · Restricted Project, Restricted Project
kparzysz committed rG23bb550eeba4: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs (authored by kparzysz).
DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs
May 25 2022, 11:01 AM · Restricted Project, Restricted Project
kparzysz closed D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs.
May 25 2022, 11:01 AM · Restricted Project, Restricted Project
kparzysz updated the diff for D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs.

Changed type of M.

May 25 2022, 6:51 AM · Restricted Project, Restricted Project
kparzysz reclaimed D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs.
May 25 2022, 6:37 AM · Restricted Project, Restricted Project

May 22 2022

kparzysz added a comment to D125899: [ADT] Add copy constructor to IntervalMap.

If we decide that this is the way to go, I'll add the other functions.

May 22 2022, 11:33 AM · Restricted Project, Restricted Project

May 18 2022

kparzysz updated the diff for D125899: [ADT] Add copy constructor to IntervalMap.

Changed the copy to a deep one.

May 18 2022, 10:00 AM · Restricted Project, Restricted Project
kparzysz planned changes to D125899: [ADT] Add copy constructor to IntervalMap.

This is a shallow copy. Let me change it to a deep one.

May 18 2022, 9:23 AM · Restricted Project, Restricted Project
kparzysz abandoned D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs.

That seems likely to be a better solution - if that's closer to the root cause, less chance someone else will introduce a similarly problematic use of IntervalMap that way (since the use will be no longer problematic).

May 18 2022, 9:09 AM · Restricted Project, Restricted Project
kparzysz requested review of D125899: [ADT] Add copy constructor to IntervalMap.
May 18 2022, 9:07 AM · Restricted Project, Restricted Project

May 17 2022

kparzysz accepted D125391: [Target] use getSubtarget<> instead of static_cast<>(getSubtarget()).
May 17 2022, 10:44 AM · Restricted Project, Restricted Project

May 14 2022

kparzysz added a comment to rG0d8cb8b399ad: DWARFVerifier: Verify CU/TU index overlap issues.

Proposed workaround: https://reviews.llvm.org/D125611.

May 14 2022, 11:17 AM · Restricted Project, Restricted Project
kparzysz requested review of D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs.
May 14 2022, 11:17 AM · Restricted Project, Restricted Project

May 13 2022

kparzysz accepted D124697: Distinguish between different forms of "address-taken" MachineBasicBlocks.
May 13 2022, 2:44 PM · Restricted Project, Restricted Project

May 10 2022

kparzysz added a comment to rG0d8cb8b399ad: DWARFVerifier: Verify CU/TU index overlap issues.

Here's more info:

$ c++ --version
FreeBSD clang version 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a303)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin
May 10 2022, 7:16 PM · Restricted Project, Restricted Project

May 9 2022

kparzysz added a comment to rG0d8cb8b399ad: DWARFVerifier: Verify CU/TU index overlap issues.

This is on FreeBSD 13-STABLE, which I think uses clang 13. It's on my home computer, I'll check the details when I get home.

May 9 2022, 9:51 AM · Restricted Project, Restricted Project
kparzysz committed rGd9e6b5df74f5: [clang] Recognize scope of thread local variables in CFGBuilder (authored by kparzysz).
[clang] Recognize scope of thread local variables in CFGBuilder
May 9 2022, 7:12 AM · Restricted Project, Restricted Project
kparzysz closed D125177: Recognize scope of thread local variables in CFGBuilder.
May 9 2022, 7:12 AM · Restricted Project, Restricted Project

May 8 2022

kparzysz added a reviewer for D125177: Recognize scope of thread local variables in CFGBuilder: efriedma.
May 8 2022, 8:20 AM · Restricted Project, Restricted Project
kparzysz updated the diff for D125177: Recognize scope of thread local variables in CFGBuilder.

Use the proper diff file this time.

May 8 2022, 8:20 AM · Restricted Project, Restricted Project
kparzysz updated the diff for D125177: Recognize scope of thread local variables in CFGBuilder.

Replace the direct storage class examination with hasLocalStorage.

May 8 2022, 8:18 AM · Restricted Project, Restricted Project

May 7 2022

kparzysz requested review of D125177: Recognize scope of thread local variables in CFGBuilder.
May 7 2022, 1:58 PM · Restricted Project, Restricted Project
kparzysz raised a concern with rG0d8cb8b399ad: DWARFVerifier: Verify CU/TU index overlap issues.

This fails to compile:

May 7 2022, 9:32 AM · Restricted Project, Restricted Project

May 6 2022

kparzysz added a comment to D124697: Distinguish between different forms of "address-taken" MachineBasicBlocks.

I'm not questioning the splitting, I'm just wondering if the terminology could be more self-explanatory. In AsmPrinter there is a check that an address-taken block must actually be present, but that's a hard requirement really only when there is a branch to it. So I was thinking that maybe "isIndirectBranchTarget" could be a better name, but I wasn't sure if it captured the intent.

May 6 2022, 10:37 AM · Restricted Project, Restricted Project
kparzysz accepted D123143: SelectionDAG: Swap operands of atomic_store.

This is great. I think there is an unaddressed comment, but otherwise LGTM.

May 6 2022, 7:04 AM · Restricted Project, Restricted Project
kparzysz added a comment to D124697: Distinguish between different forms of "address-taken" MachineBasicBlocks.

The IR spec states that the value of blockaddress can only be used in an indirect branch/call, or in a comparison against null. The latter seems to fall under the "address materialized somewhere" that you mention in the referenced review. Is the motivation behind BlockAddressTarget to identify blocks that are targets of indirect branches? Otherwise, it's not clear to me why blockaddress(bb) == null is any different from storing the address of bb in an exception table, for example.

May 6 2022, 6:58 AM · Restricted Project, Restricted Project

Apr 22 2022

kparzysz committed rG0278dee1e577: [Hexagon] Generate TargetConstant in SelectAnyInt (authored by kparzysz).
[Hexagon] Generate TargetConstant in SelectAnyInt
Apr 22 2022, 10:42 AM · Restricted Project, Restricted Project

Apr 20 2022

kparzysz committed rG16c93aaa4a95: [Hexagon] Establish size limit for RegisterSet in hexbit (authored by kparzysz).
[Hexagon] Establish size limit for RegisterSet in hexbit
Apr 20 2022, 2:16 PM · Restricted Project, Restricted Project

Mar 14 2022

Herald added a project to D120094: [CallingConv] Generate isCCArgumentReg() predicate via tablegen: Restricted Project.

The Hexagon part looks ok.

Mar 14 2022, 3:10 PM · Restricted Project, Restricted Project

Mar 7 2022

kparzysz committed rG108910c66734: [Hexagon] Handle v2f16 in build_vector in isel (authored by kparzysz).
[Hexagon] Handle v2f16 in build_vector in isel
Mar 7 2022, 11:55 AM · Restricted Project

Mar 2 2022

kparzysz committed rG2cd13e8b0000: [Hexagon] Recognize "access size" for dcfetch (authored by kparzysz).
[Hexagon] Recognize "access size" for dcfetch
Mar 2 2022, 12:58 PM · Restricted Project

Feb 11 2022

kparzysz committed rG02e7479e6bd3: [Hexagon] Add patterns for select(i1, Q, Q) (authored by kparzysz).
[Hexagon] Add patterns for select(i1, Q, Q)
Feb 11 2022, 9:46 AM

Feb 8 2022

kparzysz committed rG0792161c006a: [Hexagon] Fix operation actions for v128f16 (authored by kparzysz).
[Hexagon] Fix operation actions for v128f16
Feb 8 2022, 3:40 PM
kparzysz committed rG7403c02f06d4: [Hexagon] Fix crash with shuffle_vector of v128f16 (authored by kparzysz).
[Hexagon] Fix crash with shuffle_vector of v128f16
Feb 8 2022, 1:06 PM
kparzysz committed rG2ecda9ec9cc8: [Hexagon] Alter meaning of versionless -mhvx (authored by kparzysz).
[Hexagon] Alter meaning of versionless -mhvx
Feb 8 2022, 9:09 AM

Feb 1 2022

kparzysz committed rGc935f6e0486c: [Hexagon] Punt on registers without reaching defs in addr mode opt (authored by kparzysz).
[Hexagon] Punt on registers without reaching defs in addr mode opt
Feb 1 2022, 9:53 AM

Jan 21 2022

kparzysz accepted D117851: [Hexagon] Use llvm::Register instead of unsigned in HexagonConstExtenders.cpp. NFC..
Jan 21 2022, 5:13 AM · Restricted Project

Jan 14 2022

kparzysz committed rGbde1032588f7: [Hexagon] Fix optimize address mode pass only handle BaseImmOffset mode (authored by pranavb).
[Hexagon] Fix optimize address mode pass only handle BaseImmOffset mode
Jan 14 2022, 3:46 PM
kparzysz closed D117133: Fix Hexagon optimize addressing mode pass so that it handles only BaseImmOffset addressing mode..
Jan 14 2022, 3:45 PM · Restricted Project

Jan 7 2022

kparzysz committed rGec2945d031b6: [Hexagon] Reconize M2_mnaci in HexagonBitTracker (authored by sgundapa).
[Hexagon] Reconize M2_mnaci in HexagonBitTracker
Jan 7 2022, 2:49 PM
kparzysz committed rG07ecb987987b: [Hexagon] Use map from HexagonDepArch instead of local one, NFC (authored by kparzysz).
[Hexagon] Use map from HexagonDepArch instead of local one, NFC
Jan 7 2022, 1:03 PM
kparzysz committed rGd9ee9a1419ed: [Hexagon] Extract condition into function, NFC (authored by kparzysz).
[Hexagon] Extract condition into function, NFC
Jan 7 2022, 12:35 PM
kparzysz committed rGdfbe74be63c2: [Hexagon] Fix release build break after 547658567353d (authored by kparzysz).
[Hexagon] Fix release build break after 547658567353d
Jan 7 2022, 12:22 PM
kparzysz committed rG028444c2b329: [Hexagon] Duplex error: wrong branch hint (authored by Michael Lambert <mlambert@quicinc.com>).
[Hexagon] Duplex error: wrong branch hint
Jan 7 2022, 12:04 PM
kparzysz committed rG4096ef3ed70d: [Hexagon] Consider direction hint forming dealloc_return duplex (authored by colinl).
[Hexagon] Consider direction hint forming dealloc_return duplex
Jan 7 2022, 12:04 PM
kparzysz committed rG547658567353: [Hexagon] Improve check for subinstruction registers (authored by colinl).
[Hexagon] Improve check for subinstruction registers
Jan 7 2022, 11:39 AM
kparzysz committed rG137642f433c6: [Hexagon] Reject accumulating on vd.tmp (authored by hexhexd).
[Hexagon] Reject accumulating on vd.tmp
Jan 7 2022, 11:18 AM
kparzysz committed rG1f71e46f2a4f: [Hexagon] Apply tiny core packet size slots limit (authored by androm3da).
[Hexagon] Apply tiny core packet size slots limit
Jan 7 2022, 10:33 AM
kparzysz committed rGa2473601736d: [Hexagon] Simplify AX instruction detection (authored by colinl).
[Hexagon] Simplify AX instruction detection
Jan 7 2022, 10:33 AM
kparzysz committed rG9af53d2f0cff: [Hexagon] s/Fatal/ReportErrors/ (authored by bcain).
[Hexagon] s/Fatal/ReportErrors/
Jan 7 2022, 8:28 AM
kparzysz committed rG5001c7cc9dad: [Hexagon] MC testcases for verifying packetization rules (authored by colinl).
[Hexagon] MC testcases for verifying packetization rules
Jan 7 2022, 8:28 AM
kparzysz committed rGa58a062fbae0: [Hexagon] Show slot resources for errors (authored by androm3da).
[Hexagon] Show slot resources for errors
Jan 7 2022, 8:28 AM
kparzysz committed rG88397739a300: [Hexagon] Misc shuffling fixes (authored by kparzysz).
[Hexagon] Misc shuffling fixes
Jan 7 2022, 8:28 AM

Jan 6 2022

kparzysz committed rGe37b6a67f8a7: [Hexagon] Some compound opportunities missed in presence of branches (authored by colinl).
[Hexagon] Some compound opportunities missed in presence of branches
Jan 6 2022, 2:21 PM
kparzysz committed rGddf1fb1f133a: [Hexagon] Save results from partial compound (authored by androm3da).
[Hexagon] Save results from partial compound
Jan 6 2022, 2:09 PM
kparzysz committed rGafdc6a0b8eee: [Hexagon] Some compound opportunities missed in presence of branches (authored by colinl).
[Hexagon] Some compound opportunities missed in presence of branches
Jan 6 2022, 9:30 AM
kparzysz committed rGb17f036a99eb: [Hexagon] Consider HVX reg aliases for .cur warning (authored by androm3da).
[Hexagon] Consider HVX reg aliases for .cur warning
Jan 6 2022, 9:06 AM

Jan 5 2022

kparzysz committed rG2819e5de42e0: [Hexagon] Handle instruction selection for select(I1,Q,Q) (authored by iajbar).
[Hexagon] Handle instruction selection for select(I1,Q,Q)
Jan 5 2022, 2:57 PM
kparzysz committed rG3892baaa711a: [Hexagon] Replace isImmValidForOpcode() with isExtendable flag (authored by iajbar).
[Hexagon] Replace isImmValidForOpcode() with isExtendable flag
Jan 5 2022, 1:25 PM
kparzysz committed rGf6309db719a4: [Hexagon] Handle L2_loadb[sz]w[24]_io in HII::isValidOffset (authored by kparzysz).
[Hexagon] Handle L2_loadb[sz]w[24]_io in HII::isValidOffset
Jan 5 2022, 1:25 PM
kparzysz committed rG9d0f5c1f8ef1: [Hexagon] Add missing memop instructions to HexagonInstrInfo (authored by sgundapa).
[Hexagon] Add missing memop instructions to HexagonInstrInfo
Jan 5 2022, 1:25 PM
kparzysz committed rG69deb3c8297b: [Hexagon] Update instruction info for missing .cur post-increment cases (authored by sgundapa).
[Hexagon] Update instruction info for missing .cur post-increment cases
Jan 5 2022, 1:25 PM
kparzysz committed rG41085357df2b: [Hexagon] Extend OptAddrMode pass to vgather (authored by Shubham Pawar <shubhamp@quicinc.com>).
[Hexagon] Extend OptAddrMode pass to vgather
Jan 5 2022, 8:44 AM
kparzysz committed rG9aa017342c8f: [Hexagon] Add setting hvx-qfloat in HexagonMCSubtargetInfo (authored by Joshua Herrera <joshherr@quicinc.com>).
[Hexagon] Add setting hvx-qfloat in HexagonMCSubtargetInfo
Jan 5 2022, 7:55 AM

Jan 4 2022

kparzysz committed rG822448635edc: [Hexagon] Fix MachineSink not to hoist FP instructions that update USR. (authored by sgundapa).
[Hexagon] Fix MachineSink not to hoist FP instructions that update USR.
Jan 4 2022, 3:56 PM
kparzysz committed rG52f347010a8c: [Hexagon] Make A2_tfrsi not cheap for operands exceeding 16 bits (authored by SANTANU DAS <santanudas@codeaurora.org>).
[Hexagon] Make A2_tfrsi not cheap for operands exceeding 16 bits
Jan 4 2022, 3:48 PM
kparzysz committed rG60944d132fe3: [Hexagon] Convert codegen testcase from .ll to .mir (authored by kparzysz).
[Hexagon] Convert codegen testcase from .ll to .mir
Jan 4 2022, 3:42 PM
kparzysz committed rG090f8ec8a8dc: [Hexagon] Fix some issues with packetizing slot0-only instructions (authored by bcahoon).
[Hexagon] Fix some issues with packetizing slot0-only instructions
Jan 4 2022, 2:40 PM
kparzysz committed rG2b1c6df5a60a: [Hexagon] Performance regression with b2b (authored by hjagasia).
[Hexagon] Performance regression with b2b
Jan 4 2022, 2:14 PM
kparzysz committed rGcff1a2ed5159: [Hexagon] HVX .new store uses different resources (authored by SANTANU DAS <santanudas@codeaurora.org>).
[Hexagon] HVX .new store uses different resources
Jan 4 2022, 1:43 PM
kparzysz committed rGd6a68d08f384: [Hexagon] Refactor updateLatency() function (authored by iajbar).
[Hexagon] Refactor updateLatency() function
Jan 4 2022, 1:17 PM
kparzysz committed rG9b63fff3db88: [Hexagon] Update latencies on REG_SEQUENCE/COPY based on successors. (authored by sgundapa).
[Hexagon] Update latencies on REG_SEQUENCE/COPY based on successors.
Jan 4 2022, 12:31 PM
kparzysz committed rGdb5b7915959a: [Hexagon] Fix an instruction move in HexagonVectorCombine (authored by bcahoon).
[Hexagon] Fix an instruction move in HexagonVectorCombine
Jan 4 2022, 11:47 AM
kparzysz committed rGe88eb6443fe0: [Hexagon] Fix buildVector32 for v4i8 constants (authored by Tasmia Rahman <trahman@quicinc.com>).
[Hexagon] Fix buildVector32 for v4i8 constants
Jan 4 2022, 11:24 AM
kparzysz committed rG78f5014fea9d: [Hexagon] Conversions to/from FP types, HVX and scalar (authored by kparzysz).
[Hexagon] Conversions to/from FP types, HVX and scalar
Jan 4 2022, 11:04 AM

Dec 30 2021

kparzysz committed rGdb83e3e5071a: [Hexagon] Generate HVX/FP arithmetic instructions (authored by kparzysz).
[Hexagon] Generate HVX/FP arithmetic instructions
Dec 30 2021, 12:48 PM
kparzysz committed rG9e6afbedb016: [Hexagon] Generate HVX/FP compare instructions (authored by kparzysz).
[Hexagon] Generate HVX/FP compare instructions
Dec 30 2021, 12:17 PM
kparzysz committed rGe107374e40a2: [Hexagon] Explicitly use integer types when rescaling a mask (authored by kparzysz).
[Hexagon] Explicitly use integer types when rescaling a mask
Dec 30 2021, 10:18 AM
kparzysz committed rGeb574259b696: [Hexagon] Handle HVX/FP {masked,wide} loads/stores (authored by kparzysz).
[Hexagon] Handle HVX/FP {masked,wide} loads/stores
Dec 30 2021, 10:18 AM
kparzysz committed rGcd997689f26d: [Hexagon] Fix isTypeForHVX to recognize floating point types (authored by kparzysz).
[Hexagon] Fix isTypeForHVX to recognize floating point types
Dec 30 2021, 10:01 AM
kparzysz committed rG23423638cc69: [Hexagon] Handle HVX/FP shuffles, insertion and extraction (authored by kparzysz).
[Hexagon] Handle HVX/FP shuffles, insertion and extraction
Dec 30 2021, 8:50 AM
kparzysz added a reverting change for rGba07f300c6d6: [Hexagon] Don't build two halves of HVX vector in parallel: rG95c7dd8810b0: Revert "[Hexagon] Don't build two halves of HVX vector in parallel".
Dec 30 2021, 8:14 AM
kparzysz committed rG95c7dd8810b0: Revert "[Hexagon] Don't build two halves of HVX vector in parallel" (authored by kparzysz).
Revert "[Hexagon] Don't build two halves of HVX vector in parallel"
Dec 30 2021, 8:13 AM

Dec 29 2021

kparzysz committed rGba07f300c6d6: [Hexagon] Don't build two halves of HVX vector in parallel (authored by kparzysz).
[Hexagon] Don't build two halves of HVX vector in parallel
Dec 29 2021, 11:06 AM
kparzysz committed rG505d57486e57: [Hexagon] Improve BUILD_VECTOR codegen (authored by Joshua Herrera <joshherr@quicinc.com>).
[Hexagon] Improve BUILD_VECTOR codegen
Dec 29 2021, 10:23 AM
kparzysz committed rG4df2aba294db: [Hexagon] Calling conventions for floating point vectors (authored by kparzysz).
[Hexagon] Calling conventions for floating point vectors
Dec 29 2021, 9:02 AM
kparzysz committed rG2ce586bc497f: [Hexagon] Handle floating point splats (authored by kparzysz).
[Hexagon] Handle floating point splats
Dec 29 2021, 6:53 AM
kparzysz committed rG33fc675e1670: [Hexagon] Handle floating point vector loads/stores (authored by kparzysz).
[Hexagon] Handle floating point vector loads/stores
Dec 29 2021, 5:53 AM

Dec 28 2021

kparzysz committed rG6a6ac3b36fcd: [Hexagon] Support BUILD_VECTOR of floating point HVX vectors (authored by kparzysz).
[Hexagon] Support BUILD_VECTOR of floating point HVX vectors
Dec 28 2021, 3:01 PM
kparzysz committed rG7df136bcf258: [Hexagon] Delete unused declaration of LowerHvxMul, NFC (authored by kparzysz).
[Hexagon] Delete unused declaration of LowerHvxMul, NFC
Dec 28 2021, 11:37 AM
kparzysz committed rGb05ed0d2cb8d: [Hexagon] Add testcase for arch flags (authored by androm3da).
[Hexagon] Add testcase for arch flags
Dec 28 2021, 11:32 AM
kparzysz committed rG20135c8a5347: [Hexagon] Move testcase accidentally committed to wrong directory (authored by kparzysz).
[Hexagon] Move testcase accidentally committed to wrong directory
Dec 28 2021, 11:22 AM
kparzysz committed rG1e7bd93ff2cc: [Hexagon] Add HexagonMCInstrInfo::IsABranchingInst, NFC (authored by androm3da).
[Hexagon] Add HexagonMCInstrInfo::IsABranchingInst, NFC
Dec 28 2021, 9:54 AM