Page MenuHomePhabricator

kparzysz (Krzysztof Parzyszek)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2014, 4:27 PM (335 w, 4 d)

Recent Activity

Yesterday

kparzysz added a comment to D88138: [NPM] Add target specific hook to add passes for New Pass Manager.

I think I'm still missing how exactly this will fit into the pipeline. As in where is registerPassBuilderCallbacks() going to be called?

Fri, Sep 25, 12:13 PM · Restricted Project
kparzysz added a comment to D88138: [NPM] Add target specific hook to add passes for New Pass Manager.

My understanding is that this API gives other applications chance to modify the pass pipeline.

Fri, Sep 25, 12:06 PM · Restricted Project

Thu, Sep 24

kparzysz requested review of D88273: [SDAG] Do not convert undef to 0 when folding CONCAT/BUILD_VECTOR.
Thu, Sep 24, 6:23 PM · Restricted Project
kparzysz committed rG3185839bcf66: [Hexagon] Avoid crash on CONCAT_VECTORS with illegal element types (authored by kparzysz).
[Hexagon] Avoid crash on CONCAT_VECTORS with illegal element types
Thu, Sep 24, 6:06 PM
kparzysz accepted D88020: [SplitKit] In addDeadDef tolerate parent range that defines more lanes.

You're right, it goes in the other direction. Looks ok to me.

Thu, Sep 24, 7:15 AM · Restricted Project

Wed, Sep 23

kparzysz added a comment to D88020: [SplitKit] In addDeadDef tolerate parent range that defines more lanes.

I don't think it's safe to add dead defs to the extra lanes. You could split the superset into the matching part and the remaining part, then only operate on the matching one.

Wed, Sep 23, 5:23 PM · Restricted Project
kparzysz added inline comments to rGe976fb1e54f3: [EarlyCSE] Fix crash with expensive checks after D87691.
Wed, Sep 23, 1:38 PM
kparzysz committed rG57f097420d43: Clean up test file, NFC (authored by kparzysz).
Clean up test file, NFC
Wed, Sep 23, 1:36 PM
kparzysz added a comment to rGe976fb1e54f3: [EarlyCSE] Fix crash with expensive checks after D87691.

We should probably change bugpoint to stop using undef everywhere.

Wed, Sep 23, 11:31 AM
kparzysz added a comment to D87691: [EarlyCSE] Small refactoring changes, NFC.

Fixed in https://reviews.llvm.org/rGe976fb1e54f3.

Wed, Sep 23, 10:26 AM · Restricted Project
kparzysz committed rG76e8c1899e7c: Break long line accidentally left in the previous commit (authored by kparzysz).
Break long line accidentally left in the previous commit
Wed, Sep 23, 10:25 AM
kparzysz committed rGe976fb1e54f3: [EarlyCSE] Fix crash with expensive checks after D87691 (authored by kparzysz).
[EarlyCSE] Fix crash with expensive checks after D87691
Wed, Sep 23, 10:22 AM
kparzysz added a comment to D87691: [EarlyCSE] Small refactoring changes, NFC.

It would be great if you could take a look or revert if it takes longer to fix.

Sure, let me check.

Wed, Sep 23, 9:01 AM · Restricted Project
kparzysz added a comment to D87691: [EarlyCSE] Small refactoring changes, NFC.

It would be great if you could take a look or revert if it takes longer to fix.

Wed, Sep 23, 6:09 AM · Restricted Project

Mon, Sep 21

kparzysz committed rGae3f54c1e909: [EarlyCSE] Handle masked loads and stores (authored by kparzysz).
[EarlyCSE] Handle masked loads and stores
Mon, Sep 21, 4:47 PM
kparzysz closed D87340: [EarlyCSE] Handle masked loads and stores.
Mon, Sep 21, 4:47 PM · Restricted Project
kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Removed unnecessary checks in isSubmask.

Mon, Sep 21, 4:40 PM · Restricted Project
kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Fixed submask detection.

Mon, Sep 21, 2:31 PM · Restricted Project
kparzysz committed rG2c768c7d6c61: [EarlyCSE] Small refactoring changes, NFC (authored by kparzysz).
[EarlyCSE] Small refactoring changes, NFC
Mon, Sep 21, 2:11 PM
kparzysz closed D87691: [EarlyCSE] Small refactoring changes, NFC.
Mon, Sep 21, 2:11 PM · Restricted Project

Fri, Sep 18

kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Pre-committed new test file.

Fri, Sep 18, 12:54 PM · Restricted Project
kparzysz committed rGae0ecb3c505e: Pre-commit test for CSEing masked loads/stores (authored by kparzysz).
Pre-commit test for CSEing masked loads/stores
Fri, Sep 18, 12:31 PM
kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Add testcases with unequal masks.

Fri, Sep 18, 12:12 PM · Restricted Project
kparzysz added inline comments to D87340: [EarlyCSE] Handle masked loads and stores.
Fri, Sep 18, 12:11 PM · Restricted Project
kparzysz updated the diff for D87691: [EarlyCSE] Small refactoring changes, NFC.

Removed the bool argument to getMatchingValue. Added comments explaining how the return value is used.

Fri, Sep 18, 8:09 AM · Restricted Project
kparzysz added inline comments to D87691: [EarlyCSE] Small refactoring changes, NFC.
Fri, Sep 18, 8:03 AM · Restricted Project

Wed, Sep 16

kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Thank you both @srj and @pranavb for your help!

Wed, Sep 16, 12:37 PM

Tue, Sep 15

kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Should be fixed in https://reviews.llvm.org/rG5f4abb7fab1c.

Tue, Sep 15, 6:37 PM
kparzysz committed rG5f4abb7fab1c: [Hexagon] Replace incorrect pattern for vpackl HWI32 -> HVi8 (authored by kparzysz).
[Hexagon] Replace incorrect pattern for vpackl HWI32 -> HVi8
Tue, Sep 15, 6:35 PM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

The machine instructions in both dumps are identical... There are differences in addresses that are printed in the dump, and in the names of some values in the LLVM IR, but the machine instructions are the same.

Tue, Sep 15, 11:52 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

The LLVM ERROR: Do not know how to split the result of this operator! happens when a function with an HVX intrinsic is compiled without +hvx,+hvx-length... attributes.

Tue, Sep 15, 11:24 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

I added it to attributes #0, #1, #3 and #4.

Tue, Sep 15, 11:23 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

If you have the ability to pass LLVM options, could you get the good and bad outputs with -debug-only=isel,legalize-types,legalizedag -print-after-all?

Tue, Sep 15, 10:34 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Just llc -march=hexagon < bad_hvx64_code.ll, but I added "target-cpu"="hexagonv65" "target-features"="+hvx,+hvx-length64b" to attributes inside the file.

Tue, Sep 15, 10:25 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

It may well still be too hard to debug with what I've given you -- let me know if it needs to be simplified further.

Tue, Sep 15, 10:09 AM
kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Rebased on top of D87691.

Tue, Sep 15, 8:08 AM · Restricted Project
kparzysz added a comment to D87340: [EarlyCSE] Handle masked loads and stores.

Created D87691 with the refactoring. Will rebase this patch soon.

Tue, Sep 15, 6:59 AM · Restricted Project
kparzysz requested review of D87691: [EarlyCSE] Small refactoring changes, NFC.
Tue, Sep 15, 6:58 AM · Restricted Project

Mon, Sep 14

kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Great, thanks! Will take a look tomorrow.

Mon, Sep 14, 4:50 PM
kparzysz committed rGf35617ad809b: [Hexagon] Add more detailed testcase for widening truncates (authored by kparzysz).
[Hexagon] Add more detailed testcase for widening truncates
Mon, Sep 14, 4:13 PM
kparzysz committed rGbb877d1af2ec: [Hexagon] Widen loads and handle any-/sign-/zero-extensions (authored by kparzysz).
[Hexagon] Widen loads and handle any-/sign-/zero-extensions
Mon, Sep 14, 4:11 PM
kparzysz committed rG6352381039c4: [Hexagon] Some HVX DAG combines (authored by kparzysz).
[Hexagon] Some HVX DAG combines
Mon, Sep 14, 4:11 PM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Do you know what vector types are involved (e.g. <32 x i8>)? Anything with i1 or i64?

Mon, Sep 14, 2:54 PM
kparzysz added a comment to D87340: [EarlyCSE] Handle masked loads and stores.

This should be NFC for everything that doesn't involve masked loads/stores.

Mon, Sep 14, 6:14 AM · Restricted Project

Sat, Sep 12

kparzysz committed rG9d300bc8d2f3: [Hexagon] Avoid widening vectors with non-HVX element types (authored by kparzysz).
[Hexagon] Avoid widening vectors with non-HVX element types
Sat, Sep 12, 6:30 PM

Fri, Sep 11

kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Sure. Keep me posted.

Fri, Sep 11, 5:34 PM
kparzysz committed rGf92908cc749e: [DSE] Make sure that DSE+MSSA can handle masked stores (authored by kparzysz).
[DSE] Make sure that DSE+MSSA can handle masked stores
Fri, Sep 11, 8:01 AM
kparzysz closed D87414: [DSE] Make sure that DSE+MSSA can handle masked stores.
Fri, Sep 11, 8:00 AM · Restricted Project
kparzysz added inline comments to D87414: [DSE] Make sure that DSE+MSSA can handle masked stores.
Fri, Sep 11, 7:20 AM · Restricted Project

Thu, Sep 10

kparzysz committed rG783e28a50839: [Hexagon] Split pair-based masked memops (authored by kparzysz).
[Hexagon] Split pair-based masked memops
Thu, Sep 10, 12:25 PM
kparzysz committed rG8a08740db6e1: [GVN] Account for masked loads/stores depending on load/store instructions (authored by kparzysz).
[GVN] Account for masked loads/stores depending on load/store instructions
Thu, Sep 10, 8:58 AM
kparzysz closed D87423: [GVN] Account for masked loads/stores depending on load/store instructions.
Thu, Sep 10, 8:58 AM · Restricted Project

Wed, Sep 9

kparzysz added a comment to D87061: Handle masked loads and stores in MemoryLocation/Dependence.

Fix for the crash: D87423.

Wed, Sep 9, 4:17 PM · Restricted Project
kparzysz requested review of D87423: [GVN] Account for masked loads/stores depending on load/store instructions.
Wed, Sep 9, 4:16 PM · Restricted Project
kparzysz updated the diff for D87414: [DSE] Make sure that DSE+MSSA can handle masked stores.

Addressed comments.

Wed, Sep 9, 3:49 PM · Restricted Project
kparzysz added a comment to D87414: [DSE] Make sure that DSE+MSSA can handle masked stores.

Marked masked-storing intrinsics as write-only in 8b7c8f2c549d301fcea75d8e6e98a8ee160d5ff4.

Wed, Sep 9, 3:29 PM · Restricted Project
kparzysz committed rG8b7c8f2c549d: Mark masked.{store,scatter,compressstore} intrinsics as write-only (authored by kparzysz).
Mark masked.{store,scatter,compressstore} intrinsics as write-only
Wed, Sep 9, 3:29 PM
kparzysz updated the diff for D87414: [DSE] Make sure that DSE+MSSA can handle masked stores.

Calling isMaskedStoreOverwrite from isOverwrite to avoid multiple checks.

Wed, Sep 9, 1:45 PM · Restricted Project
kparzysz added a comment to D87414: [DSE] Make sure that DSE+MSSA can handle masked stores.

I think that the isMaskedStoreOverwrite could be merged into isOverwrite, but it'd need to take instructions in addition to the locations. I think it would be a bit cleaner than what this patch does.

Wed, Sep 9, 1:30 PM · Restricted Project
kparzysz added a comment to D87387: [DSE] Handle masked stores.

Proposed fix: https://reviews.llvm.org/D87414.

Wed, Sep 9, 1:26 PM · Restricted Project
kparzysz requested review of D87414: [DSE] Make sure that DSE+MSSA can handle masked stores.
Wed, Sep 9, 1:26 PM · Restricted Project
kparzysz added a comment to D87387: [DSE] Handle masked stores.

Still investigating. Changing getLocForWriteEx doesn't fix it.

Wed, Sep 9, 1:06 PM · Restricted Project
kparzysz added a comment to rG1387f96ab331: [Hexagon] Handle widening of vector truncate.

Hopefully https://reviews.llvm.org/rG0ee54cf88329 fixes this.

Wed, Sep 9, 12:33 PM
kparzysz committed rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates (authored by kparzysz).
[Hexagon] Account for truncating pairs to non-pairs when widening truncates
Wed, Sep 9, 12:32 PM
kparzysz added a comment to D87387: [DSE] Handle masked stores.

Yes, it fails to remove the store.

Wed, Sep 9, 12:27 PM · Restricted Project
kparzysz added a comment to rG1387f96ab331: [Hexagon] Handle widening of vector truncate.

@srj Checking...

Wed, Sep 9, 11:51 AM
kparzysz added a comment to D87387: [DSE] Handle masked stores.

I disabled MSSA in this testcase so it won't fail when you switch (db7defd9bab7527ec1d0ed3fc62b379a9adf0971). I'll fix it in the meantime.

Wed, Sep 9, 11:47 AM · Restricted Project
kparzysz committed rGdb7defd9bab7: [DSE] Explicitly not use MSSA in testcase for now (authored by kparzysz).
[DSE] Explicitly not use MSSA in testcase for now
Wed, Sep 9, 11:46 AM
kparzysz added a comment to D87387: [DSE] Handle masked stores.

Hm, it fails with MemorySSA. Let me figure this out...

Wed, Sep 9, 11:41 AM · Restricted Project
kparzysz added a comment to D87387: [DSE] Handle masked stores.

@fhahn Sure, let me do it now.

Wed, Sep 9, 11:36 AM · Restricted Project
kparzysz closed D87387: [DSE] Handle masked stores.

Committed in https://reviews.llvm.org/rG81ff2d30a900. Forgot to update the commit message. :(

Wed, Sep 9, 11:35 AM · Restricted Project
kparzysz committed rG81ff2d30a900: [DSE] Handle masked stores (authored by kparzysz).
[DSE] Handle masked stores
Wed, Sep 9, 11:31 AM
kparzysz requested review of D87387: [DSE] Handle masked stores.
Wed, Sep 9, 8:41 AM · Restricted Project
kparzysz committed rG27cd187587eb: [DSE] Add testcase that uses masked loads and stores (authored by kparzysz).
[DSE] Add testcase that uses masked loads and stores
Wed, Sep 9, 8:32 AM
kparzysz added a reviewer for D87340: [EarlyCSE] Handle masked loads and stores: asbirlea.
Wed, Sep 9, 6:52 AM · Restricted Project

Tue, Sep 8

kparzysz committed rGc2b7b9b642b3: [Hexagon] Fix order of operands in V6_vdealb4w (authored by kparzysz).
[Hexagon] Fix order of operands in V6_vdealb4w
Tue, Sep 8, 8:11 PM
kparzysz requested review of D87340: [EarlyCSE] Handle masked loads and stores.
Tue, Sep 8, 5:57 PM · Restricted Project
kparzysz committed rG889cf9bedff1: [EarlyCSE] Add testcase for masked loads and stores, NFC (authored by kparzysz).
[EarlyCSE] Add testcase for masked loads and stores, NFC
Tue, Sep 8, 5:53 PM
kparzysz committed rG055d2095898d: Handle masked loads and stores in MemoryLocation/Dependence (authored by kparzysz).
Handle masked loads and stores in MemoryLocation/Dependence
Tue, Sep 8, 5:09 PM
kparzysz closed D87061: Handle masked loads and stores in MemoryLocation/Dependence.
Tue, Sep 8, 5:09 PM · Restricted Project
kparzysz committed rGd183f472617d: [Hexagon] Handle widening of truncation's operand with legal result (authored by kparzysz).
[Hexagon] Handle widening of truncation's operand with legal result
Tue, Sep 8, 2:17 PM
kparzysz updated the diff for D87061: Handle masked loads and stores in MemoryLocation/Dependence.

Pre-committed a testcase.

Tue, Sep 8, 10:11 AM · Restricted Project
kparzysz committed rGd0ccfcb040c6: [GVN] Add testcase that uses masked loads and stores, NFC (authored by kparzysz).
[GVN] Add testcase that uses masked loads and stores, NFC
Tue, Sep 8, 9:59 AM
kparzysz added reviewers for D87061: Handle masked loads and stores in MemoryLocation/Dependence: asbirlea, jdoerfert.
Tue, Sep 8, 8:14 AM · Restricted Project

Sat, Sep 5

kparzysz committed rG62f89a89f312: [Hexagon] Add assertions about V6_pred_scalar2 (authored by kparzysz).
[Hexagon] Add assertions about V6_pred_scalar2
Sat, Sep 5, 4:20 PM
kparzysz committed rG9518f032e492: [Hexagon] When widening truncate result, also widen operand if necessary (authored by kparzysz).
[Hexagon] When widening truncate result, also widen operand if necessary
Sat, Sep 5, 4:20 PM
kparzysz committed rG8789f2bbde8f: [Hexagon] Resize the mem operand when widening loads and stores (authored by kparzysz).
[Hexagon] Resize the mem operand when widening loads and stores
Sat, Sep 5, 4:19 PM
kparzysz committed rG1387f96ab331: [Hexagon] Handle widening of vector truncate (authored by kparzysz).
[Hexagon] Handle widening of vector truncate
Sat, Sep 5, 1:08 PM

Fri, Sep 4

kparzysz committed rG89a4fe79d4dd: [Hexagon] Unindent everything in HexagonISelLowering.h, NFC (authored by kparzysz).
[Hexagon] Unindent everything in HexagonISelLowering.h, NFC
Fri, Sep 4, 3:26 PM

Thu, Sep 3

kparzysz updated the diff for D87061: Handle masked loads and stores in MemoryLocation/Dependence.

Added a testcase for GVN.

Thu, Sep 3, 4:38 AM · Restricted Project
kparzysz added inline comments to D87061: Handle masked loads and stores in MemoryLocation/Dependence.
Thu, Sep 3, 4:35 AM · Restricted Project

Wed, Sep 2

kparzysz requested review of D87061: Handle masked loads and stores in MemoryLocation/Dependence.
Wed, Sep 2, 3:29 PM · Restricted Project

Sun, Aug 30

kparzysz committed rG69fac677bc20: [Hexagon] Fix perfect shuffle generation for single vectors (authored by kparzysz).
[Hexagon] Fix perfect shuffle generation for single vectors
Sun, Aug 30, 4:45 AM

Thu, Aug 27

kparzysz committed rG4ef9275b9b48: [Hexagon] Emit better 32-bit multiplication sequence for HVXv62+ (authored by kparzysz).
[Hexagon] Emit better 32-bit multiplication sequence for HVXv62+
Thu, Aug 27, 1:30 PM
kparzysz committed rG154daf1f94fd: [Hexagon] Widen short vector stores to HVX vectors using masked stores (authored by kparzysz).
[Hexagon] Widen short vector stores to HVX vectors using masked stores
Thu, Aug 27, 7:25 AM

Aug 26 2020

kparzysz accepted D86661: Use properlyDominates in RDFLiveness when sorting on dominance..
Aug 26 2020, 2:18 PM · Restricted Project
kparzysz committed rGe15143d31bca: [Hexagon] Implement llvm.masked.load and llvm.masked.store for HVX (authored by kparzysz).
[Hexagon] Implement llvm.masked.load and llvm.masked.store for HVX
Aug 26 2020, 11:11 AM

Aug 25 2020

kparzysz committed rG514d6e9a8d91: [SDAG] Improve MemSDNode::getBasePtr (authored by kparzysz).
[SDAG] Improve MemSDNode::getBasePtr
Aug 25 2020, 1:20 PM
kparzysz committed rG2da1eefb58a1: [Hexagon] Check if EVT is simple type in HVX lowering (authored by aciidb0mb3r).
[Hexagon] Check if EVT is simple type in HVX lowering
Aug 25 2020, 1:03 PM
kparzysz accepted D86482: Fix ty function in HexagonISelLowering.
Aug 25 2020, 12:21 PM · Restricted Project