Page MenuHomePhabricator

kparzysz (Krzysztof Parzyszek)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2014, 4:27 PM (373 w, 3 d)

Recent Activity

Today

kparzysz committed rZORGe7f9b7230c9a: Update compiler on hexagon-build-0x machines (authored by kparzysz).
Update compiler on hexagon-build-0x machines
Thu, Jun 17, 10:12 AM

Mon, Jun 14

kparzysz committed rG0577f4b1789e: [Hexagon] Add HVX and control register names to Hexagon target (authored by kparzysz).
[Hexagon] Add HVX and control register names to Hexagon target
Mon, Jun 14, 3:15 PM

Mon, Jun 7

kparzysz committed rG9d35c1701f26: [docs] Set Phabricator as the tool for pre-commit reviews (authored by kparzysz).
[docs] Set Phabricator as the tool for pre-commit reviews
Mon, Jun 7, 9:52 AM
kparzysz closed D103811: [docs] Set Phabricator as the tool for pre-commit code reviews.
Mon, Jun 7, 9:52 AM · Restricted Project
kparzysz requested review of D103811: [docs] Set Phabricator as the tool for pre-commit code reviews.
Mon, Jun 7, 7:02 AM · Restricted Project

Wed, May 26

kparzysz committed rG002f5e158d08: [Hexagon] Restore handling of expanding shuffles (authored by kparzysz).
[Hexagon] Restore handling of expanding shuffles
Wed, May 26, 4:04 PM

Tue, May 25

kparzysz committed rG6a2869cf1e5b: [Hexagon] Remove unused function from HexagonISelDAGToDAGHVX.cpp (authored by kparzysz).
[Hexagon] Remove unused function from HexagonISelDAGToDAGHVX.cpp
Tue, May 25, 12:47 PM
kparzysz committed rGe7c839b1925f: [Hexagon] Improve argument packing in vector shuffle selection (authored by kparzysz).
[Hexagon] Improve argument packing in vector shuffle selection
Tue, May 25, 10:48 AM

May 13 2021

kparzysz committed rG2b20dee59bc8: Fix section title underlining in the release notes (authored by kparzysz).
Fix section title underlining in the release notes
May 13 2021, 6:37 AM
kparzysz committed rG4dea3487315e: Add entry about Hexagon V68 support to the release notes (authored by kparzysz).
Add entry about Hexagon V68 support to the release notes
May 13 2021, 6:29 AM

May 10 2021

kparzysz committed rG8b9c15c2819b: [Hexagon] Handle loads and stores of scalar predicate vectors (authored by kparzysz).
[Hexagon] Handle loads and stores of scalar predicate vectors
May 10 2021, 2:43 PM

May 8 2021

kparzysz committed rG561026936bd2: [Hexagon] Propagate metadata in Hexagon Vector Combine (authored by kparzysz).
[Hexagon] Propagate metadata in Hexagon Vector Combine
May 8 2021, 1:17 PM

May 7 2021

kparzysz committed rG50cf0a1d1ae4: Allow empty value list in propagateMetadata(Inst, ArrayOf...) (authored by kparzysz).
Allow empty value list in propagateMetadata(Inst, ArrayOf...)
May 7 2021, 11:28 AM

May 5 2021

kparzysz committed rG6251b2f7f697: Attach metadata to simplified masked loads and stores (authored by Coplin, Jared <jcoplin@quicinc.com>).
Attach metadata to simplified masked loads and stores
May 5 2021, 4:02 PM
kparzysz committed rG1817dae19241: Preserve metadata on masked intrinsics in auto-upgrade (authored by kparzysz).
Preserve metadata on masked intrinsics in auto-upgrade
May 5 2021, 1:52 PM
kparzysz closed D101201: Preserve metadata on masked intrinsics in auto-upgrade.
May 5 2021, 1:52 PM · Restricted Project
kparzysz added a comment to D101201: Preserve metadata on masked intrinsics in auto-upgrade.

Ping. Hopefully this is ready to go.

May 5 2021, 9:40 AM · Restricted Project

Apr 30 2021

kparzysz updated the diff for D101201: Preserve metadata on masked intrinsics in auto-upgrade.

Added debug metadata to the testcase. Updated summary to refer to metadata in general, not specifically TBAA (although TBAA was mentioned in one specific context).

Apr 30 2021, 11:01 AM · Restricted Project
kparzysz added a comment to D101201: Preserve metadata on masked intrinsics in auto-upgrade.

Ping. Could someone weigh in on this?

Apr 30 2021, 8:03 AM · Restricted Project

Apr 29 2021

kparzysz added a comment to D101533: [TTI] NFC: Change getTypeLegalizationCost to return InstructionCost..

The type is actually added in the patch so if we'll leave std::pair, it is not needed.

Apr 29 2021, 1:33 PM · Restricted Project
kparzysz added a comment to D101533: [TTI] NFC: Change getTypeLegalizationCost to return InstructionCost..

For this patch it's probably best to just follow precedent as to what was used before, i.e. cases that used std::pair<unsigned, MVT> should be changed to std::pair<InstructionCost, MVT>

Apr 29 2021, 12:29 PM · Restricted Project
kparzysz added inline comments to D101533: [TTI] NFC: Change getTypeLegalizationCost to return InstructionCost..
Apr 29 2021, 9:25 AM · Restricted Project
kparzysz abandoned D100889: Better fix for incomplete DefaultPred.
Apr 29 2021, 8:52 AM · Restricted Project
kparzysz accepted D101533: [TTI] NFC: Change getTypeLegalizationCost to return InstructionCost..

LGTM

Apr 29 2021, 8:51 AM · Restricted Project

Apr 28 2021

kparzysz accepted D100695: [TableGen] Remove predicate filtering from GenerateVariants..
Apr 28 2021, 12:49 PM · Restricted Project
kparzysz accepted D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.
Apr 28 2021, 11:52 AM · Restricted Project
kparzysz added a reviewer for D101201: Preserve metadata on masked intrinsics in auto-upgrade: jeroen.dobbelaere.
Apr 28 2021, 10:47 AM · Restricted Project
kparzysz committed rG899352c7b484: [Hexagon] Skip function in Hexagon vector combine if requested (authored by kparzysz).
[Hexagon] Skip function in Hexagon vector combine if requested
Apr 28 2021, 7:24 AM

Apr 27 2021

kparzysz accepted D101240: [TableGen] Add predicate checks to isel patterns for default HwMode..
Apr 27 2021, 5:55 AM · Restricted Project

Apr 23 2021

kparzysz requested review of D101201: Preserve metadata on masked intrinsics in auto-upgrade.
Apr 23 2021, 1:56 PM · Restricted Project
kparzysz committed rG8ebdb58aac01: [Hexagon] Remove redundant HVX intrinsic selection patterns, NFC (authored by kparzysz).
[Hexagon] Remove redundant HVX intrinsic selection patterns, NFC
Apr 23 2021, 7:28 AM

Apr 22 2021

kparzysz committed rG06234f758e19: [Hexagon] Improve lowering of returns of i1 (authored by kparzysz).
[Hexagon] Improve lowering of returns of i1
Apr 22 2021, 2:49 PM
kparzysz committed rGab9521aaebc5: [Hexagon] Use 'vnot' instead of 'not' in patterns with vectors (authored by kparzysz).
[Hexagon] Use 'vnot' instead of 'not' in patterns with vectors
Apr 22 2021, 1:37 PM
kparzysz closed D100687: [Hexagon] Use 'not' instead of 'vnot' in patterns with vectors..
Apr 22 2021, 1:37 PM · Restricted Project
kparzysz committed rGdeda60fcaf0b: [Hexagon] Add HVX intrinsics for conditional vector loads/stores (authored by kparzysz).
[Hexagon] Add HVX intrinsics for conditional vector loads/stores
Apr 22 2021, 9:50 AM
kparzysz added a reverting change for rG96dc8d7e7dee: [Hexagon] Masked and unmasked load to same base -> load and two selects: rGe8d0475472ea: Revert "[Hexagon] Masked and unmasked load to same base -> load and two selects".
Apr 22 2021, 7:08 AM
kparzysz committed rGe8d0475472ea: Revert "[Hexagon] Masked and unmasked load to same base -> load and two selects" (authored by kparzysz).
Revert "[Hexagon] Masked and unmasked load to same base -> load and two selects"
Apr 22 2021, 7:08 AM

Apr 21 2021

kparzysz committed rGa7f33d720b74: [Polly] Explicitly include all std headers (authored by kparzysz).
[Polly] Explicitly include all std headers
Apr 21 2021, 10:54 AM

Apr 20 2021

kparzysz added inline comments to D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.
Apr 20 2021, 2:01 PM · Restricted Project
kparzysz requested review of D100889: Better fix for incomplete DefaultPred.
Apr 20 2021, 1:59 PM · Restricted Project
kparzysz added a comment to D100687: [Hexagon] Use 'not' instead of 'vnot' in patterns with vectors..

I'd have to take a closer look at this. You're right that these patterns won't match in this form, but the fixes may need to be different. The standard treatment of boolean vectors as somewhat equivalent to n-bit integers or having immediate value doesn't work well with Hexagon, so we have nodes like HexagonPTRUE or HexagonQTRUE (and the corresponding falses).

Apr 20 2021, 12:44 PM · Restricted Project
kparzysz added a comment to D100695: [TableGen] Remove predicate filtering from GenerateVariants..

Looks ok to me, but waiting for the prerequisite patch to be finalized.

Apr 20 2021, 12:21 PM · Restricted Project
kparzysz added inline comments to D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.
Apr 20 2021, 9:41 AM · Restricted Project

Apr 19 2021

kparzysz added inline comments to D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.
Apr 19 2021, 12:12 PM · Restricted Project

Apr 15 2021

kparzysz committed rG280678122d31: [Hexagon] Avoid infinite loops in type legalization when lowering SETCC (authored by kparzysz).
[Hexagon] Avoid infinite loops in type legalization when lowering SETCC
Apr 15 2021, 11:35 AM

Apr 1 2021

kparzysz added a comment to D99666: [flang] Implement reductions in the runtime.

Yup, just got it. Thanks!

Apr 1 2021, 1:12 PM · Restricted Project, Restricted Project
kparzysz added a comment to D99666: [flang] Implement reductions in the runtime.

__builtin_complex was added in clang 12. This code won't compile with any released version of clang.

Apr 1 2021, 12:57 PM · Restricted Project, Restricted Project

Mar 25 2021

kparzysz committed rGa5b7d38c579c: [Hexagon] Limit virtual register reuse range in FI elimination (authored by kparzysz).
[Hexagon] Limit virtual register reuse range in FI elimination
Mar 25 2021, 12:00 PM

Mar 19 2021

kparzysz accepted D98962: [Hexagon] Return an i64 for result 0 from LowerREADCYCLECOUNTER instead of an i32..

Thanks!

Mar 19 2021, 10:05 AM · Restricted Project

Mar 17 2021

kparzysz committed rGb292dce2309e: [ObjectYAML] Handle Hexagon V68 (authored by kparzysz).
[ObjectYAML] Handle Hexagon V68
Mar 17 2021, 7:44 PM
kparzysz committed rG0ddf38c99ebb: [Hexagon] Improve stack address base reuse for HVX spills (authored by kparzysz).
[Hexagon] Improve stack address base reuse for HVX spills
Mar 17 2021, 7:33 PM
kparzysz committed rG849412270b80: [Hexagon] Add more patterns for HVX loads and stores (authored by kparzysz).
[Hexagon] Add more patterns for HVX loads and stores
Mar 17 2021, 7:02 PM
kparzysz accepted D97891: Add register size info back to MCRegisterClass.

I'm inclined to accept this as is. There is definitely a limitation here that cannot be easily worked around.

Mar 17 2021, 11:21 AM · Restricted Project
kparzysz accepted D98436: [Hexagon] Support inlined use of cs0 and cs1.
Mar 17 2021, 7:01 AM · Restricted Project, Restricted Project

Mar 4 2021

kparzysz added a comment to D97891: Add register size info back to MCRegisterClass.

For targets that make use of HW modes, register sizes are specific to a subtarget.

Mar 4 2021, 5:28 AM · Restricted Project

Mar 2 2021

kparzysz committed rGd96b5e606add: [TableGen] Add IntrNoMerge as intrinsic property (authored by kparzysz).
[TableGen] Add IntrNoMerge as intrinsic property
Mar 2 2021, 9:05 AM
kparzysz closed D96364: [TableGen] Add IntrNoMerge as intrinsic property.
Mar 2 2021, 9:05 AM · Restricted Project

Mar 1 2021

kparzysz added a comment to D96364: [TableGen] Add IntrNoMerge as intrinsic property.

Gentle ping.

Mar 1 2021, 9:49 AM · Restricted Project

Feb 10 2021

kparzysz accepted D96020: [TTI] Change TargetTransformInfo::getMinimumVF to return ElementCount.

LGTM, but please respond to outstanding comments before committing.

Feb 10 2021, 5:57 AM · Restricted Project

Feb 9 2021

kparzysz requested review of D96364: [TableGen] Add IntrNoMerge as intrinsic property.
Feb 9 2021, 11:55 AM · Restricted Project

Feb 4 2021

kparzysz committed rGa83475d34b45: [Hexagon] Add -mv68 option to driver (authored by kparzysz).
[Hexagon] Add -mv68 option to driver
Feb 4 2021, 8:30 AM
kparzysz committed rGbc097f645e0d: [Hexagon] Add clang builtin definitions for Hexagon V68 (authored by kparzysz).
[Hexagon] Add clang builtin definitions for Hexagon V68
Feb 4 2021, 7:56 AM

Feb 3 2021

kparzysz committed rG0bb198510210: [Hexagon] Add LLVM instruction definitions for Hexagon V68 (authored by kparzysz).
[Hexagon] Add LLVM instruction definitions for Hexagon V68
Feb 3 2021, 12:13 PM
kparzysz committed rG3562d253dacf: [Hexagon] Add ELF flags for Hexagon V68 (authored by kparzysz).
[Hexagon] Add ELF flags for Hexagon V68
Feb 3 2021, 9:04 AM

Jan 28 2021

kparzysz abandoned D95371: [OpenMP] Use C++ to link libomp.so when LLVM libraries are included.

This is fixed in https://reviews.llvm.org/D95585.

Jan 28 2021, 5:48 AM · Restricted Project

Jan 27 2021

kparzysz accepted D95556: [OpenMP][NVPTX] Disable building NVPTX deviceRTL by default on a non-CUDA system.

This compiles ok on my machine.

Jan 27 2021, 1:02 PM · Restricted Project
kparzysz added a comment to D95466: [OpenMP][NVPTX] Drop dependence on CUDA to build NVPTX `deviceRTLs`.

Aside from potentially disabling this build, I actually have multilib installed:

ii  gcc-7-multilib                   7.5.0-3ubuntu1~18.04                amd64        GNU C compiler (multilib support)
ii  gcc-multilib                     4:7.4.0-1ubuntu2.3                  amd64        GNU C compiler (multilib files)
Jan 27 2021, 11:46 AM · Restricted Project
kparzysz added a comment to D95466: [OpenMP][NVPTX] Drop dependence on CUDA to build NVPTX `deviceRTLs`.

I don't have CUDA, why is this being compiled on my system to begin with?

Jan 27 2021, 10:45 AM · Restricted Project
kparzysz added a comment to D95466: [OpenMP][NVPTX] Drop dependence on CUDA to build NVPTX `deviceRTLs`.

I don't have CUDA on my system, and now the build is broken:

[ 38%] Building LLVM bitcode target_impl.cu-cuda_80-sm_80.bc
In file included from /w/src/llvm.org/openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu:14:
In file included from /w/src/llvm.org/openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:15:
In file included from /usr/include/assert.h:35:
/usr/include/features.h:424:12: fatal error: 'sys/cdefs.h' file not found
#  include <sys/cdefs.h>
           ^~~~~~~~~~~~~
1 error generated.
Jan 27 2021, 10:18 AM · Restricted Project

Jan 25 2021

kparzysz added a comment to D95371: [OpenMP] Use C++ to link libomp.so when LLVM libraries are included.

It's already guarded---it's only set to CXX when linking with the Support library.

Jan 25 2021, 1:24 PM · Restricted Project
kparzysz added a comment to D95371: [OpenMP] Use C++ to link libomp.so when LLVM libraries are included.

The problem is with linking the Support library from LLVM, which has a lot of C++ code. If I'm reading the CMakeLists.txt correctly, there is still an option to build libomp.so as a "standalone" library (line 138), where the C linking should be sufficient.

Jan 25 2021, 10:28 AM · Restricted Project
kparzysz requested review of D95371: [OpenMP] Use C++ to link libomp.so when LLVM libraries are included.
Jan 25 2021, 8:43 AM · Restricted Project

Jan 19 2021

kparzysz committed rG57443bfb4ab0: [Hexagon] Fix segment start to adjust for gaps between segments (authored by bcahoon).
[Hexagon] Fix segment start to adjust for gaps between segments
Jan 19 2021, 10:55 AM

Jan 14 2021

kparzysz accepted rG95019de8a122: [mlir][IR] Define the singleton builtin types in ODS instead of C++.

Mehdi has fixed this.

Jan 14 2021, 8:16 AM

Jan 13 2021

kparzysz closed D94607: [Hexagon] Improve legalizing of ISD::SETCC result.
Jan 13 2021, 10:32 AM · Restricted Project
kparzysz accepted D94607: [Hexagon] Improve legalizing of ISD::SETCC result.

Committed in https://reviews.llvm.org/rGa2e6506c47b1.

Jan 13 2021, 10:32 AM · Restricted Project
kparzysz added a comment to rGa90214760d04: [Hexagon] Custom-widen SETCC's operands.

Committed in https://reviews.llvm.org/rGa2e6506c47b1.

Jan 13 2021, 10:31 AM
kparzysz committed rGa2e6506c47b1: [Hexagon] Improve legalizing of ISD::SETCC result (authored by kparzysz).
[Hexagon] Improve legalizing of ISD::SETCC result
Jan 13 2021, 10:30 AM
kparzysz added a comment to rGa90214760d04: [Hexagon] Custom-widen SETCC's operands.

Could you try this patch? https://reviews.llvm.org/D94607

Jan 13 2021, 8:33 AM
kparzysz requested review of D94607: [Hexagon] Improve legalizing of ISD::SETCC result.
Jan 13 2021, 8:32 AM · Restricted Project
kparzysz added a comment to rGa90214760d04: [Hexagon] Custom-widen SETCC's operands.

Thanks for the report, looking into it.

Jan 13 2021, 7:30 AM

Jan 11 2021

kparzysz committed rGa90214760d04: [Hexagon] Custom-widen SETCC's operands (authored by kparzysz).
[Hexagon] Custom-widen SETCC's operands
Jan 11 2021, 10:29 AM

Jan 6 2021

kparzysz committed rG46975b5b29e2: [Hexagon] Wrap functions only used in asserts in ifndef NDEBUG (authored by kparzysz).
[Hexagon] Wrap functions only used in asserts in ifndef NDEBUG
Jan 6 2021, 7:41 AM

Jan 5 2021

kparzysz committed rGee11bf316f6b: [Hexagon] Silence unused function warning with gcc10, NFC (authored by kparzysz).
[Hexagon] Silence unused function warning with gcc10, NFC
Jan 5 2021, 12:12 PM

Jan 4 2021

kparzysz committed rGc55b609b777d: [Hexagon] Fix bad SDNodeXForm (authored by kparzysz).
[Hexagon] Fix bad SDNodeXForm
Jan 4 2021, 8:43 AM

Dec 16 2020

kparzysz raised a concern with rG95019de8a122: [mlir][IR] Define the singleton builtin types in ODS instead of C++.

This commit broke compilation of debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp. The compile command for this file doesn't get the path to the tblgen-generated includes, and it fails with

In file included from /w/src/llvm.org/debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp:2:
/w/src/llvm.org/llvm/../mlir/include/mlir/IR/BuiltinTypes.h:638:10: fatal error: 'mlir/IR/BuiltinTypes.h.inc' file not found
#include "mlir/IR/BuiltinTypes.h.inc"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Dec 16 2020, 8:26 AM

Dec 15 2020

kparzysz committed rG0f903015c774: [Hexagon] Rename test case, NFC (authored by kparzysz).
[Hexagon] Rename test case, NFC
Dec 15 2020, 5:07 PM
kparzysz committed rGfe0527e1c7e4: [Hexagon] Temporarily disable vector realignment for non-HVX vectors (authored by kparzysz).
[Hexagon] Temporarily disable vector realignment for non-HVX vectors
Dec 15 2020, 5:04 PM
kparzysz committed rG16385643bbf2: [Hexagon] Emit enough stores when aligning vector addresses (authored by kparzysz).
[Hexagon] Emit enough stores when aligning vector addresses
Dec 15 2020, 5:01 PM
kparzysz committed rG71601d2ac995: [Hexagon] Fix bitcasting v1i8 -> i8 (authored by kparzysz).
[Hexagon] Fix bitcasting v1i8 -> i8
Dec 15 2020, 2:02 PM

Dec 12 2020

kparzysz committed rGbaf931a8427d: [Hexagon] Reconsider getMask fix, return original mask, convert later (authored by kparzysz).
[Hexagon] Reconsider getMask fix, return original mask, convert later
Dec 12 2020, 11:30 AM
kparzysz committed rG2cf53104711e: [Hexagon] Create vector masks for scalar loads/stores (authored by kparzysz).
[Hexagon] Create vector masks for scalar loads/stores
Dec 12 2020, 9:12 AM

Dec 11 2020

kparzysz committed rG2d8cc5479b9e: [Hexagon] Workaround for compilation error with VS2017 (authored by kparzysz).
[Hexagon] Workaround for compilation error with VS2017
Dec 11 2020, 1:12 PM

Dec 10 2020

kparzysz added inline comments to rGf5d07a05bbd4: [Hexagon] Realign HVX vectors wherever possible.
Dec 10 2020, 6:23 AM
kparzysz committed rG7c9afe9183ee: [Hexagon] Fix gcc6 compilation issue (authored by kparzysz).
[Hexagon] Fix gcc6 compilation issue
Dec 10 2020, 6:19 AM

Dec 9 2020

kparzysz committed rGe3b2828b9d6d: [Hexagon] Silence warnings about unused objects (authored by kparzysz).
[Hexagon] Silence warnings about unused objects
Dec 9 2020, 3:56 PM
kparzysz committed rG43d1c7a56453: [Hexagon] Fix build: move template specialization into namespace scope (authored by kparzysz).
[Hexagon] Fix build: move template specialization into namespace scope
Dec 9 2020, 3:40 PM
kparzysz committed rGf5d07a05bbd4: [Hexagon] Realign HVX vectors wherever possible (authored by kparzysz).
[Hexagon] Realign HVX vectors wherever possible
Dec 9 2020, 3:12 PM

Dec 4 2020

kparzysz committed rG1b404ad51e93: Include BuiltinAttributes.h in llvm-prettyprinters/gdb/mlir-support.cpp (authored by kparzysz).
Include BuiltinAttributes.h in llvm-prettyprinters/gdb/mlir-support.cpp
Dec 4 2020, 1:59 PM

Nov 27 2020

kparzysz committed rGb7bde0e4f3d2: [Hexagon] Improve check for HVX types (authored by kparzysz).
[Hexagon] Improve check for HVX types
Nov 27 2020, 11:36 AM