Page MenuHomePhabricator

kparzysz (Krzysztof Parzyszek)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2014, 4:27 PM (282 w, 3 d)

Recent Activity

Wed, Sep 18

kparzysz added a comment to D67544: [TableGen] Support encoding and decoding per-HwMode.

Looks good to me.

Wed, Sep 18, 6:41 AM · Restricted Project

Tue, Sep 17

kparzysz added inline comments to D67544: [TableGen] Support encoding and decoding per-HwMode.
Tue, Sep 17, 6:10 AM · Restricted Project

Thu, Sep 5

kparzysz committed rG0ce93194fe3d: [Hexagon] Fix type in HexagonTargetLowering::ReplaceNodeResults (authored by kparzysz).
[Hexagon] Fix type in HexagonTargetLowering::ReplaceNodeResults
Thu, Sep 5, 9:20 AM
kparzysz committed rL371083: [Hexagon] Fix type in HexagonTargetLowering::ReplaceNodeResults.
[Hexagon] Fix type in HexagonTargetLowering::ReplaceNodeResults
Thu, Sep 5, 9:20 AM

Wed, Sep 4

kparzysz committed rG08a09822a5cb: [Hexagon] Improve generated code for test-if-bit-clear, one more time (authored by kparzysz).
[Hexagon] Improve generated code for test-if-bit-clear, one more time
Wed, Sep 4, 8:23 AM
kparzysz committed rL370913: [Hexagon] Improve generated code for test-if-bit-clear, one more time.
[Hexagon] Improve generated code for test-if-bit-clear, one more time
Wed, Sep 4, 8:22 AM

Mon, Aug 26

kparzysz committed rG9e0feaf56287: [Hexagon] Improve generated code for test-if-bit-clear (authored by kparzysz).
[Hexagon] Improve generated code for test-if-bit-clear
Mon, Aug 26, 12:16 PM
kparzysz committed rL369947: [Hexagon] Improve generated code for test-if-bit-clear.
[Hexagon] Improve generated code for test-if-bit-clear
Mon, Aug 26, 12:07 PM

Aug 16 2019

kparzysz committed rGac83aab035f2: [Hexagon] Generate min/max instructions for 64-bit vectors (authored by kparzysz).
[Hexagon] Generate min/max instructions for 64-bit vectors
Aug 16 2019, 9:17 AM
kparzysz committed rL369124: [Hexagon] Generate min/max instructions for 64-bit vectors.
[Hexagon] Generate min/max instructions for 64-bit vectors
Aug 16 2019, 9:17 AM

Aug 15 2019

kparzysz committed rG8e987702b1e6: [Hexagon] Fix instruction selection for vselect v4i8 (authored by kparzysz).
[Hexagon] Fix instruction selection for vselect v4i8
Aug 15 2019, 12:20 PM
kparzysz committed rL369040: [Hexagon] Fix instruction selection for vselect v4i8.
[Hexagon] Fix instruction selection for vselect v4i8
Aug 15 2019, 12:19 PM
kparzysz committed rG8460301d58ee: [Hexagon] Generate vector min/max for HVX (authored by kparzysz).
[Hexagon] Generate vector min/max for HVX
Aug 15 2019, 9:13 AM
kparzysz committed rL369014: [Hexagon] Generate vector min/max for HVX.
[Hexagon] Generate vector min/max for HVX
Aug 15 2019, 9:13 AM

Aug 8 2019

kparzysz added a comment to D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.

The Hexagon part looks ok.

Aug 8 2019, 7:23 AM · Restricted Project

Aug 5 2019

kparzysz committed rL367915: Upgrade compilers on hexagon-build-0[23] to clang 8.0.0.
Upgrade compilers on hexagon-build-0[23] to clang 8.0.0
Aug 5 2019, 12:47 PM

Aug 1 2019

kparzysz added a comment to D65424: [Packetizer] Increase the size of DFAInput bitfield to allow up to 32 units.

To clarify: clang-8 hangs on HexagonInstrInfo.cpp when compiling current master branch with this patch applied.

Aug 1 2019, 10:56 AM · Restricted Project
kparzysz added a comment to D65424: [Packetizer] Increase the size of DFAInput bitfield to allow up to 32 units.

This seems to hang when compiling HexagonInstrInfo.cpp.

Aug 1 2019, 9:18 AM · Restricted Project

Jul 1 2019

kparzysz committed rG657f8c16c19e: Update email address in CODE_OWNERS (authored by kparzysz).
Update email address in CODE_OWNERS
Jul 1 2019, 9:02 AM
kparzysz committed rL364793: Update email address in CODE_OWNERS.
Update email address in CODE_OWNERS
Jul 1 2019, 9:02 AM
kparzysz committed rG5abf80cdfa34: [Hexagon] Custom-lower UADDO(x, 1) and USUBO(x, 1) (authored by kparzysz).
[Hexagon] Custom-lower UADDO(x, 1) and USUBO(x, 1)
Jul 1 2019, 8:54 AM
kparzysz committed rL364790: [Hexagon] Custom-lower UADDO(x, 1) and USUBO(x, 1).
[Hexagon] Custom-lower UADDO(x, 1) and USUBO(x, 1)
Jul 1 2019, 8:50 AM
kparzysz committed rG511ad50db410: [Hexagon] Rework VLCR algorithm (authored by kparzysz).
[Hexagon] Rework VLCR algorithm
Jul 1 2019, 6:52 AM
kparzysz committed rL364770: [Hexagon] Rework VLCR algorithm.
[Hexagon] Rework VLCR algorithm
Jul 1 2019, 6:52 AM

Jun 28 2019

kparzysz committed rG40b88e07e2dd: [Hexagon] driver uses out-of-date option name and binary name (authored by kparzysz).
[Hexagon] driver uses out-of-date option name and binary name
Jun 28 2019, 8:10 AM
kparzysz committed rL364648: [Hexagon] driver uses out-of-date option name and binary name.
[Hexagon] driver uses out-of-date option name and binary name
Jun 28 2019, 8:08 AM
kparzysz closed D62127: [Hexagon] driver uses out-of-date option name and binary name.
Jun 28 2019, 8:08 AM · Restricted Project, Restricted Project

Jun 15 2019

kparzysz accepted D62127: [Hexagon] driver uses out-of-date option name and binary name.
Jun 15 2019, 11:19 AM · Restricted Project, Restricted Project

Jun 12 2019

kparzysz accepted D63075: [TargetLowering] Add MachineMemOperand::Flags to allowsMemoryAccess tests (PR42123).
Jun 12 2019, 8:16 AM · Restricted Project

Jun 11 2019

kparzysz added a comment to D63075: [TargetLowering] Add MachineMemOperand::Flags to allowsMemoryAccess tests (PR42123).

LGTM.

Jun 11 2019, 8:49 AM · Restricted Project

Jun 4 2019

kparzysz accepted D62867: UpdateTestChecks: hexagon support.
Jun 4 2019, 12:37 PM · Restricted Project
kparzysz added a comment to D62867: UpdateTestChecks: hexagon support.

What is this in preparation of? Why are only these 3 tests affected?

Jun 4 2019, 10:47 AM · Restricted Project

May 29 2019

kparzysz added a comment to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++.

This commit stopped clang++ from finding libc++:

May 29 2019, 12:58 PM · Restricted Project, Restricted Project, Restricted Project

May 16 2019

kparzysz accepted D61705: Tablegen type comparison LE should be LT or equal..
May 16 2019, 8:23 AM · Restricted Project

May 9 2019

kparzysz added inline comments to D61705: Tablegen type comparison LE should be LT or equal..
May 9 2019, 5:47 AM · Restricted Project

May 3 2019

kparzysz accepted D61133: [hexagon] change AsmParser assertion to error.
May 3 2019, 9:32 AM · Restricted Project

May 2 2019

kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

Ping.

May 2 2019, 9:15 AM · Restricted Project

Apr 16 2019

kparzysz committed rGef6823ec8dac: [Hexagon] Remove indeterministic traversal order (authored by kparzysz).
[Hexagon] Remove indeterministic traversal order
Apr 16 2019, 9:06 AM
kparzysz committed rL358505: [Hexagon] Remove indeterministic traversal order.
[Hexagon] Remove indeterministic traversal order
Apr 16 2019, 9:05 AM

Apr 10 2019

kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

Ping.

Apr 10 2019, 6:45 AM · Restricted Project

Apr 3 2019

kparzysz added a comment to D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.

The problem is that in some contexts the explicit sign- or zero-extension may be deliberate, regardless of how boolean values are represented in wider types. Other than delegating that to the target experts, I don't know how to address that.

Apr 3 2019, 2:13 PM · Restricted Project
kparzysz committed rG4841643a1da2: [X86] Extend boolean arguments to inline-asm according to getBooleanType (authored by kparzysz).
[X86] Extend boolean arguments to inline-asm according to getBooleanType
Apr 3 2019, 10:42 AM
kparzysz committed rL357615: [X86] Extend boolean arguments to inline-asm according to getBooleanType.
[X86] Extend boolean arguments to inline-asm according to getBooleanType
Apr 3 2019, 10:42 AM
kparzysz closed D60208: [X86] Extend boolean arguments to inline-asm according to getBooleanType.
Apr 3 2019, 10:42 AM · Restricted Project
kparzysz created D60208: [X86] Extend boolean arguments to inline-asm according to getBooleanType.
Apr 3 2019, 9:09 AM · Restricted Project

Mar 29 2019

kparzysz added a comment to D60006: [SelectionDAG] Add fcmp UNDEF handling to SelectionDAG::FoldSetCC.

The Hexagon part is ok.

Mar 29 2019, 12:05 PM · Restricted Project

Mar 28 2019

kparzysz raised a concern with rCXX355318: [libc++] decoupling Freestanding atomic<T> from libatomic.a.

This commit seems to be implicated in a cmake-time warning. See http://lists.llvm.org/pipermail/cfe-dev/2019-March/061837.html for more information.

Mar 28 2019, 9:51 AM

Mar 27 2019

kparzysz added a comment to D59758: [DAGCombiner] Combine OR as ADD when no common bits are set.

The Hexagon testcase can be fixed---it's probably just a matter of changing the selection pattern for the instruction we're checking.

Mar 27 2019, 7:34 AM · Restricted Project

Mar 21 2019

kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

There can be many changes to the compiled code between the IR combiner and the DAG combiner, so these patterns can certainly appear before DAG combining takes place. Also, we already combine for rotates in the DAG, this patch only makes it more comprehensive.

Mar 21 2019, 10:45 AM · Restricted Project
kparzysz updated the diff for D47735: [DAGCombiner] Create rotates more aggressively.

Rebased on top of the pre-committed testcases.

Mar 21 2019, 10:26 AM · Restricted Project
kparzysz committed rG471950294149: Add more rotate tests, including ORs of rotates (authored by kparzysz).
Add more rotate tests, including ORs of rotates
Mar 21 2019, 10:14 AM
kparzysz committed rL356683: Add more rotate tests, including ORs of rotates.
Add more rotate tests, including ORs of rotates
Mar 21 2019, 10:14 AM
kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

Oof, I somehow missed the comments... :o

Mar 21 2019, 10:14 AM · Restricted Project

Mar 15 2019

kparzysz added a comment to D59363: [SelectionDAG] Add icmp UNDEF handling to SelectionDAG::FoldSetCC.

The Hexagon changes look good.

Mar 15 2019, 7:23 AM · Restricted Project

Mar 6 2019

kparzysz committed rG9c005bbdd4db: [Hexagon] Avoid creating 5-instruction packets with vgather pseudos (authored by kparzysz).
[Hexagon] Avoid creating 5-instruction packets with vgather pseudos
Mar 6 2019, 9:44 AM
kparzysz committed rL355524: [Hexagon] Avoid creating 5-instruction packets with vgather pseudos.
[Hexagon] Avoid creating 5-instruction packets with vgather pseudos
Mar 6 2019, 9:44 AM

Mar 1 2019

kparzysz added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

I was actually thinking about handling of target-specific relocations, and applying them to instructions. We used to have a large chunk of auto-generated code that did that. The implementation in lld is much shorter, so it's probably not a big deal if it needs to be repeated.

Mar 1 2019, 3:42 PM · Restricted Project
kparzysz added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

Since you're rewrite this, is there any potential for sharing code with lld? Relocating instructions should essentially be the same between these two.

Mar 1 2019, 11:46 AM · Restricted Project
kparzysz accepted D58595: [TableGen][SelectionDAG][X86] Add specific isel matchers for immAllZerosV/immAllOnesV. Remove bitcasts from X86 patterns that are no longer necessary..

Looks ok to me.

Mar 1 2019, 8:38 AM · Restricted Project
kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

Ping.

Mar 1 2019, 8:33 AM · Restricted Project

Feb 21 2019

kparzysz updated the diff for D47735: [DAGCombiner] Create rotates more aggressively.

This patch uses MatchRotate to do the actual matching, so it's only going to look for opportunities to create a rotate. Maybe that function should be replaced with MatchRotateOrFunnelShift in a future patch.

Feb 21 2019, 2:23 PM · Restricted Project
kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

Are you opposed to having this done in the DAG combiner?

Feb 21 2019, 11:54 AM · Restricted Project
kparzysz committed rGf6e875bacfca: [Hexagon] Use misaligned load instead of trap0(#0) for __builtin_trap (authored by kparzysz).
[Hexagon] Use misaligned load instead of trap0(#0) for __builtin_trap
Feb 21 2019, 11:44 AM
kparzysz committed rL354611: [Hexagon] Use misaligned load instead of trap0(#0) for __builtin_trap.
[Hexagon] Use misaligned load instead of trap0(#0) for __builtin_trap
Feb 21 2019, 11:44 AM
kparzysz committed rG948c9f93c401: Revert r354606, it breaks asan tests (authored by kparzysz).
Revert r354606, it breaks asan tests
Feb 21 2019, 11:34 AM
kparzysz committed rL354609: Revert r354606, it breaks asan tests.
Revert r354606, it breaks asan tests
Feb 21 2019, 11:34 AM
kparzysz committed rG5f47fac3a2b0: [Hexagon] Use misaligned load instead of trap0(#0) for __builtin_trap (authored by kparzysz).
[Hexagon] Use misaligned load instead of trap0(#0) for __builtin_trap
Feb 21 2019, 10:39 AM
kparzysz committed rL354606: [Hexagon] Use misaligned load instead of trap0(#0) for __builtin_trap.
[Hexagon] Use misaligned load instead of trap0(#0) for __builtin_trap
Feb 21 2019, 10:38 AM
kparzysz added a comment to D58490: [ARM] Be super conservative about atomics.

The Hexagon changes are OK.

Feb 21 2019, 6:18 AM · Restricted Project

Feb 20 2019

kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

One goal was to be able to generate rol-and-accumulate instruction (on Hexagon), specifically for the accumulate operation being | (see f11 in rotate.ll). For the C code we still don't generate it:

unsigned blah(unsigned x, unsigned s) {
  return s | (x << 27) | (x >> 5);
}
Feb 20 2019, 2:02 PM · Restricted Project
kparzysz committed rG6128ac5a8fbb: [Hexagon] Split vector pairs for ISD::SIGN_EXTEND and ISD::ZERO_EXTEND (authored by kparzysz).
[Hexagon] Split vector pairs for ISD::SIGN_EXTEND and ISD::ZERO_EXTEND
Feb 20 2019, 7:06 AM
kparzysz committed rL354473: [Hexagon] Split vector pairs for ISD::SIGN_EXTEND and ISD::ZERO_EXTEND.
[Hexagon] Split vector pairs for ISD::SIGN_EXTEND and ISD::ZERO_EXTEND
Feb 20 2019, 7:04 AM

Feb 18 2019

kparzysz accepted D58356: Hexagon: Add ImmArg to intrinsics.

I see. Thanks for looking into it.

Feb 18 2019, 12:31 PM
kparzysz added a comment to D58356: Hexagon: Add ImmArg to intrinsics.

I'm not expecting this patch to be complete. Most of the intrinsic definitions are actually auto-generated, so we'll need to update the generating scripts to include these new annotations. What concerns me is that you claim that some things are missing, which could indicate that there are some issues with the generators. I'm trying to understand exactly what the missing pieces are, the contents of this patch are actually of secondary importance.

Feb 18 2019, 9:44 AM
kparzysz added a comment to D58356: Hexagon: Add ImmArg to intrinsics.

There has to be a corresponding builtin definition explicitly defined in clang, which also needs to correctly mark the required constant operands. The test coverage for which operands need to be constants is spotty or nonexistent for these, so those are possibly missing in the builtin definition.

Feb 18 2019, 9:22 AM
kparzysz added a comment to D58356: Hexagon: Add ImmArg to intrinsics.

I don't really understand the summary, could you elaborate on how the asserting implies the conclusion (the part that follows "This means that..."). Also, what does that part mean on its own? "Intrinsics are missing that don't use GCCBuiltin...", meaning that you'd expect some intrinsics that don't use GCCBuiltin, but they're not defined?

Feb 18 2019, 8:22 AM

Feb 13 2019

kparzysz accepted D55295: LiveIntervals: Add removePhysReg.
Feb 13 2019, 1:08 PM
kparzysz added a comment to D55295: LiveIntervals: Add removePhysReg.

I'm not trying to block this from being committed, but I'm really not a fan of it. I think that register units are fundamental enough not to be treated as an "implementation detail". Besides, they are quite explicit in the public interface of LiveIntervals.

Feb 13 2019, 11:55 AM
kparzysz added inline comments to D55295: LiveIntervals: Add removePhysReg.
Feb 13 2019, 11:22 AM
kparzysz added inline comments to D55295: LiveIntervals: Add removePhysReg.
Feb 13 2019, 10:38 AM

Feb 7 2019

kparzysz accepted D57917: [zorg] Update host compiler for reverse-iteration builder.
Feb 7 2019, 12:06 PM
kparzysz added inline comments to D57917: [zorg] Update host compiler for reverse-iteration builder.
Feb 7 2019, 11:25 AM
kparzysz accepted D57865: [zorg] Update host compiler for polly-arm-linux builder.
Feb 7 2019, 6:19 AM

Feb 2 2019

kparzysz added a comment to D57608: [NFC][GlobalISel]: Add a convenience method to MachineInstrBuilder to simplify getOperand(i).getReg().

If we're going to add a helper to shave some characters off, we might as well go for something really short like getOpReg().

Feb 2 2019, 7:22 AM · Restricted Project

Feb 1 2019

kparzysz committed rL352915: [Hexagon] Update release notes with the changes to the Hexagon backend.
[Hexagon] Update release notes with the changes to the Hexagon backend
Feb 1 2019, 12:55 PM
kparzysz committed rL352912: [Hexagon] Update release notes with the changes to the Hexagon backend.
[Hexagon] Update release notes with the changes to the Hexagon backend
Feb 1 2019, 12:44 PM

Jan 24 2019

kparzysz committed rL352101: [zorg] Pass environment to getPollyBuildFactory and getAOSPBuildFactory.
[zorg] Pass environment to getPollyBuildFactory and getAOSPBuildFactory
Jan 24 2019, 12:53 PM
kparzysz closed D51058: [zorg] Pass environment to getPollyBuildFactory and getAOSPBuildFactory.
Jan 24 2019, 12:53 PM
Herald added a reviewer for D51058: [zorg] Pass environment to getPollyBuildFactory and getAOSPBuildFactory: serge-sans-paille.
Jan 24 2019, 12:44 PM

Jan 23 2019

kparzysz committed rL351956: [Hexagon] Remove incorrect bit negation.
[Hexagon] Remove incorrect bit negation
Jan 23 2019, 7:37 AM

Jan 16 2019

kparzysz committed rL351369: [Hexagon] Do not promote terminator instructions in Hexagon loop idioms.
[Hexagon] Do not promote terminator instructions in Hexagon loop idioms
Jan 16 2019, 11:44 AM

Dec 20 2018

kparzysz committed rL349770: [Hexagon] Add patterns for funnel shifts.
[Hexagon] Add patterns for funnel shifts
Dec 20 2018, 8:44 AM

Dec 17 2018

kparzysz committed rL349391: [SDAG] Clarify the origin of chain in REG_SEQUENCE in comment, NFC.
[SDAG] Clarify the origin of chain in REG_SEQUENCE in comment, NFC
Dec 17 2018, 12:33 PM

Dec 14 2018

kparzysz committed rL349202: [Hexagon] Add patterns for shifts of v2i16.
[Hexagon] Add patterns for shifts of v2i16
Dec 14 2018, 2:37 PM
kparzysz committed rL349199: [Hexagon] Use IMPLICIT_DEF to any-extend 32-bit values to 64 bits.
[Hexagon] Use IMPLICIT_DEF to any-extend 32-bit values to 64 bits
Dec 14 2018, 2:09 PM
kparzysz committed rL349186: [SDAG] Ignore chain operand in REG_SEQUENCE when emitting instructions.
[SDAG] Ignore chain operand in REG_SEQUENCE when emitting instructions
Dec 14 2018, 12:17 PM
kparzysz added a comment to D55448: [DAGCombiner] allow hoisting vector bitwise logic ahead of truncates.

The Hexagon tests were meant to check operations on vector predicate registers, so for them to work the inputs need to be vectors of i1 with the lengths that correspond to the lengths of vectors of 8+ bit integers. The only way to generate such values is do either a compare or a truncate. Since compare instructions can be fused with logical operations, this leaves truncate as the only option. With the changes from this patch, truncate is also eliminated, so it appears that these instructions cannot be emitted anymore (from a non-intrinsic code). With this in mind, I am ok with these changes.

Dec 14 2018, 11:13 AM

Dec 11 2018

kparzysz added a comment to D55373: [LSR] Generate formulae to enable more indexed accesses.

I've run some tests and the results are not great for us. On some tests we got up to 5.5% improvements, but there are a lot of severe degradations (15+% worse). If this patch goes in, we'd like to be able to opt out.

Dec 11 2018, 9:05 AM · Restricted Project

Dec 10 2018

kparzysz committed rL348802: [Hexagon] Couple of fixes in optimize addressing mode.
[Hexagon] Couple of fixes in optimize addressing mode
Dec 10 2018, 1:59 PM
kparzysz committed rL348792: Revert "[Hexagon] Check if operand is an immediate before getImm".
Revert "[Hexagon] Check if operand is an immediate before getImm"
Dec 10 2018, 11:36 AM