Page MenuHomePhabricator

kparzysz (Krzysztof Parzyszek)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2014, 4:27 PM (299 w, 4 d)

Recent Activity

Yesterday

kparzysz committed rGfe085be1253f: [Hexagon] Use itinerary for assembler HVX resource checking (authored by Mike Lambert <mlambert@quicinc.com>).
[Hexagon] Use itinerary for assembler HVX resource checking
Fri, Jan 17, 11:21 AM
kparzysz accepted D72701: [Hexagon] Add support for Linux/Musl ABI..

LGTM

Fri, Jan 17, 10:51 AM · Restricted Project
kparzysz committed rG9ab2cab220cf: [Hexagon] Move testcase from c1873631d0a8f2acc to proper location (authored by kparzysz).
[Hexagon] Move testcase from c1873631d0a8f2acc to proper location
Fri, Jan 17, 10:42 AM
kparzysz committed rGc1873631d0a8: [Hexagon] Refactor HexagonShuffle (authored by bcain).
[Hexagon] Refactor HexagonShuffle
Fri, Jan 17, 10:23 AM
kparzysz committed rG2d5bfc6eb15f: [Hexagon] Improve HVX version checks (authored by kparzysz).
[Hexagon] Improve HVX version checks
Fri, Jan 17, 7:46 AM
kparzysz committed rG60aed6a4e5d9: [Hexagon] Add prev65 subtarget feature (authored by kparzysz).
[Hexagon] Add prev65 subtarget feature
Fri, Jan 17, 7:28 AM

Thu, Jan 16

kparzysz committed rG202446c639fd: Add BuiltinsHexagonDep.def to clang module map (authored by kparzysz).
Add BuiltinsHexagonDep.def to clang module map
Thu, Jan 16, 1:56 PM
kparzysz committed rGecf0766cf141: [Hexagon] Add ELF flags for Hexagon v66 to ELFYAML.cpp (authored by kparzysz).
[Hexagon] Add ELF flags for Hexagon v66 to ELFYAML.cpp
Thu, Jan 16, 1:07 PM
kparzysz committed rG6f3effbbf054: [Hexagon] Update autogenerated intrinsic info in clang (authored by kparzysz).
[Hexagon] Update autogenerated intrinsic info in clang
Thu, Jan 16, 12:28 PM
kparzysz committed rG5f65065437cd: [Hexagon] Update autogeneated intrinsic information in LLVM (authored by kparzysz).
[Hexagon] Update autogeneated intrinsic information in LLVM
Thu, Jan 16, 11:20 AM
kparzysz committed rG8ee2d1689664: [Hexagon] Add a target feature to disable compound instructions (authored by kparzysz).
[Hexagon] Add a target feature to disable compound instructions
Thu, Jan 16, 10:42 AM
kparzysz committed rGbc413da0865d: [Hexagon] Fix alignment info for __builtin_circ_lduh (authored by kparzysz).
[Hexagon] Fix alignment info for __builtin_circ_lduh
Thu, Jan 16, 8:57 AM
kparzysz committed rG7f5f6ff5476b: [Hexagon] Add preprocessor test for hexagonv66 (authored by kparzysz).
[Hexagon] Add preprocessor test for hexagonv66
Thu, Jan 16, 8:19 AM
kparzysz committed rG237fd9431252: [Hexagon] Remove unnecessary case in StringSwitch, NFC (authored by kparzysz).
[Hexagon] Remove unnecessary case in StringSwitch, NFC
Thu, Jan 16, 8:10 AM

Dec 16 2019

kparzysz added inline comments to D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used.
Dec 16 2019, 10:34 AM · Restricted Project, Restricted Project

Dec 2 2019

kparzysz added inline comments to D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used.
Dec 2 2019, 12:25 PM · Restricted Project, Restricted Project

Nov 21 2019

kparzysz added inline comments to D70000: [DAGCombine] Initialize the default operation action for SIGN_EXTEND_INREG for vector type as 'expand' instead of 'legal'.
Nov 21 2019, 11:00 AM · Restricted Project
kparzysz added a comment to D63973: [MachineVerifier] Improve checks of target instructions operands..

And the vasrh one (that I missed) in e8d1578131247d089209952476ba9191ad0295be. Hexagon tests should now pass.

Nov 21 2019, 7:42 AM · Restricted Project
kparzysz committed rGe8d157813124: [Hexagon] Remove incorrect intrinsic definition and invalid testcase (authored by kparzysz).
[Hexagon] Remove incorrect intrinsic definition and invalid testcase
Nov 21 2019, 7:21 AM

Nov 20 2019

kparzysz added a comment to D63973: [MachineVerifier] Improve checks of target instructions operands..

Fixed the Hexagon failures in 824b25fc02dc4544adae55e6451d355f4c6d7055.

Nov 20 2019, 1:14 PM · Restricted Project
kparzysz committed rG824b25fc02dc: [Hexagon] Fix two testcase errors (authored by kparzysz).
[Hexagon] Fix two testcase errors
Nov 20 2019, 1:09 PM

Nov 12 2019

kparzysz committed rGef150e2ea519: [Hexagon] Update PS_aligna with max stack alignment once isel completes (authored by kparzysz).
[Hexagon] Update PS_aligna with max stack alignment once isel completes
Nov 12 2019, 9:51 AM
kparzysz committed rG592dd4592429: [Hexagon] Fix vector spill expansion to use proper alignment (authored by kparzysz).
[Hexagon] Fix vector spill expansion to use proper alignment
Nov 12 2019, 7:50 AM
kparzysz committed rGe3eb10c5419d: [Hexagon] Convert stack object offsets to int64, NFC (authored by kparzysz).
[Hexagon] Convert stack object offsets to int64, NFC
Nov 12 2019, 7:50 AM
kparzysz committed rG67294c97fbfd: [Hexagon] Handle stack realignment in hexagon-vextract (authored by kparzysz).
[Hexagon] Handle stack realignment in hexagon-vextract
Nov 12 2019, 7:50 AM
kparzysz committed rG0a58ef5eb5e1: [Hexagon] Require PS_aligna whenever variable-sized objects are present (authored by kparzysz).
[Hexagon] Require PS_aligna whenever variable-sized objects are present
Nov 12 2019, 7:50 AM

Nov 7 2019

kparzysz added inline comments to D69741: [Codegen] Both sides of '&&' are same; fixed.
Nov 7 2019, 8:46 AM · Restricted Project

Oct 30 2019

kparzysz committed rG43144ffa91a2: LiveIntervals: Split live intervals on multiple dead defs (authored by kparzysz).
LiveIntervals: Split live intervals on multiple dead defs
Oct 30 2019, 6:51 AM
kparzysz closed D68666: LiveIntervals: Split live intervals on multiple dead defs.
Oct 30 2019, 6:51 AM · Restricted Project
kparzysz accepted D69614: Fix pattern error for S2_tstbit_i instruction.
Oct 30 2019, 6:23 AM · Restricted Project

Oct 29 2019

kparzysz committed rG99f51960fdb5: [Hexagon] Handle remaining registers in getRegisterByName() (authored by kparzysz).
[Hexagon] Handle remaining registers in getRegisterByName()
Oct 29 2019, 7:02 AM

Oct 23 2019

kparzysz added a comment to D69336: [BitVector] Define BitWord as uintptr_t.

There are custom implementations of these functions for 64-bit unsigned values, so you should make it uint64_t. There is no connection with the pointer size.

Oct 23 2019, 1:17 PM · Restricted Project
kparzysz added a comment to D69336: [BitVector] Define BitWord as uintptr_t.

There is no guarantee that size_t will match the size of a pointer either. Why do you want that anyway?

Oct 23 2019, 10:32 AM · Restricted Project

Oct 10 2019

kparzysz added a comment to D68651: [InstCombine] Signed saturation patterns.

I'm in favor of treating signed saturation as canonical. The issue in delaying detection of such cases to instruction selection is the volatility of the IR: there is no guarantee that the IR will remain in the same form (expected by isel) from one day to the next. For example, some optimization may decide to just promote the operations to the wider type and only do the extension/truncate once, depending on how many saturating operations may be near one another. Handling this variability in isel is just not feasible.

Oct 10 2019, 10:53 AM · Restricted Project

Oct 8 2019

kparzysz created D68666: LiveIntervals: Split live intervals on multiple dead defs.
Oct 8 2019, 2:24 PM · Restricted Project

Sep 23 2019

kparzysz committed rGf97fdf5792c3: [Hexagon] Bitcast v4i16 to v8i8, unify no-op casts between scalar and HVX (authored by kparzysz).
[Hexagon] Bitcast v4i16 to v8i8, unify no-op casts between scalar and HVX
Sep 23 2019, 7:37 AM
kparzysz committed rL372616: [Hexagon] Bitcast v4i16 to v8i8, unify no-op casts between scalar and HVX.
[Hexagon] Bitcast v4i16 to v8i8, unify no-op casts between scalar and HVX
Sep 23 2019, 7:37 AM

Sep 20 2019

kparzysz committed rG2b5d7e93dd18: [MVT] Add v256i1 to MachineValueType (authored by kparzysz).
[MVT] Add v256i1 to MachineValueType
Sep 20 2019, 8:24 AM
kparzysz committed rL372403: [MVT] Add v256i1 to MachineValueType.
[MVT] Add v256i1 to MachineValueType
Sep 20 2019, 8:18 AM

Sep 18 2019

kparzysz added a comment to D67544: [TableGen] Support encoding and decoding per-HwMode.

Looks good to me.

Sep 18 2019, 6:41 AM · Restricted Project

Sep 17 2019

kparzysz added inline comments to D67544: [TableGen] Support encoding and decoding per-HwMode.
Sep 17 2019, 6:10 AM · Restricted Project

Sep 5 2019

kparzysz committed rG0ce93194fe3d: [Hexagon] Fix type in HexagonTargetLowering::ReplaceNodeResults (authored by kparzysz).
[Hexagon] Fix type in HexagonTargetLowering::ReplaceNodeResults
Sep 5 2019, 9:20 AM
kparzysz committed rL371083: [Hexagon] Fix type in HexagonTargetLowering::ReplaceNodeResults.
[Hexagon] Fix type in HexagonTargetLowering::ReplaceNodeResults
Sep 5 2019, 9:20 AM

Sep 4 2019

kparzysz committed rG08a09822a5cb: [Hexagon] Improve generated code for test-if-bit-clear, one more time (authored by kparzysz).
[Hexagon] Improve generated code for test-if-bit-clear, one more time
Sep 4 2019, 8:23 AM
kparzysz committed rL370913: [Hexagon] Improve generated code for test-if-bit-clear, one more time.
[Hexagon] Improve generated code for test-if-bit-clear, one more time
Sep 4 2019, 8:22 AM

Aug 26 2019

kparzysz committed rG9e0feaf56287: [Hexagon] Improve generated code for test-if-bit-clear (authored by kparzysz).
[Hexagon] Improve generated code for test-if-bit-clear
Aug 26 2019, 12:16 PM
kparzysz committed rL369947: [Hexagon] Improve generated code for test-if-bit-clear.
[Hexagon] Improve generated code for test-if-bit-clear
Aug 26 2019, 12:07 PM

Aug 16 2019

kparzysz committed rGac83aab035f2: [Hexagon] Generate min/max instructions for 64-bit vectors (authored by kparzysz).
[Hexagon] Generate min/max instructions for 64-bit vectors
Aug 16 2019, 9:17 AM
kparzysz committed rL369124: [Hexagon] Generate min/max instructions for 64-bit vectors.
[Hexagon] Generate min/max instructions for 64-bit vectors
Aug 16 2019, 9:17 AM

Aug 15 2019

kparzysz committed rG8e987702b1e6: [Hexagon] Fix instruction selection for vselect v4i8 (authored by kparzysz).
[Hexagon] Fix instruction selection for vselect v4i8
Aug 15 2019, 12:20 PM
kparzysz committed rL369040: [Hexagon] Fix instruction selection for vselect v4i8.
[Hexagon] Fix instruction selection for vselect v4i8
Aug 15 2019, 12:19 PM
kparzysz committed rG8460301d58ee: [Hexagon] Generate vector min/max for HVX (authored by kparzysz).
[Hexagon] Generate vector min/max for HVX
Aug 15 2019, 9:13 AM
kparzysz committed rL369014: [Hexagon] Generate vector min/max for HVX.
[Hexagon] Generate vector min/max for HVX
Aug 15 2019, 9:13 AM

Aug 8 2019

kparzysz added a comment to D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.

The Hexagon part looks ok.

Aug 8 2019, 7:23 AM · Restricted Project

Aug 5 2019

kparzysz committed rL367915: Upgrade compilers on hexagon-build-0[23] to clang 8.0.0.
Upgrade compilers on hexagon-build-0[23] to clang 8.0.0
Aug 5 2019, 12:47 PM

Aug 1 2019

kparzysz added a comment to D65424: [Packetizer] Increase the size of DFAInput bitfield to allow up to 32 units.

To clarify: clang-8 hangs on HexagonInstrInfo.cpp when compiling current master branch with this patch applied.

Aug 1 2019, 10:56 AM · Restricted Project
kparzysz added a comment to D65424: [Packetizer] Increase the size of DFAInput bitfield to allow up to 32 units.

This seems to hang when compiling HexagonInstrInfo.cpp.

Aug 1 2019, 9:18 AM · Restricted Project

Jul 1 2019

kparzysz committed rG657f8c16c19e: Update email address in CODE_OWNERS (authored by kparzysz).
Update email address in CODE_OWNERS
Jul 1 2019, 9:02 AM
kparzysz committed rL364793: Update email address in CODE_OWNERS.
Update email address in CODE_OWNERS
Jul 1 2019, 9:02 AM
kparzysz committed rG5abf80cdfa34: [Hexagon] Custom-lower UADDO(x, 1) and USUBO(x, 1) (authored by kparzysz).
[Hexagon] Custom-lower UADDO(x, 1) and USUBO(x, 1)
Jul 1 2019, 8:54 AM
kparzysz committed rL364790: [Hexagon] Custom-lower UADDO(x, 1) and USUBO(x, 1).
[Hexagon] Custom-lower UADDO(x, 1) and USUBO(x, 1)
Jul 1 2019, 8:50 AM
kparzysz committed rG511ad50db410: [Hexagon] Rework VLCR algorithm (authored by kparzysz).
[Hexagon] Rework VLCR algorithm
Jul 1 2019, 6:52 AM
kparzysz committed rL364770: [Hexagon] Rework VLCR algorithm.
[Hexagon] Rework VLCR algorithm
Jul 1 2019, 6:52 AM

Jun 28 2019

kparzysz committed rG40b88e07e2dd: [Hexagon] driver uses out-of-date option name and binary name (authored by kparzysz).
[Hexagon] driver uses out-of-date option name and binary name
Jun 28 2019, 8:10 AM
kparzysz committed rL364648: [Hexagon] driver uses out-of-date option name and binary name.
[Hexagon] driver uses out-of-date option name and binary name
Jun 28 2019, 8:08 AM
kparzysz closed D62127: [Hexagon] driver uses out-of-date option name and binary name.
Jun 28 2019, 8:08 AM · Restricted Project, Restricted Project

Jun 15 2019

kparzysz accepted D62127: [Hexagon] driver uses out-of-date option name and binary name.
Jun 15 2019, 11:19 AM · Restricted Project, Restricted Project

Jun 12 2019

kparzysz accepted D63075: [TargetLowering] Add MachineMemOperand::Flags to allowsMemoryAccess tests (PR42123).
Jun 12 2019, 8:16 AM · Restricted Project

Jun 11 2019

kparzysz added a comment to D63075: [TargetLowering] Add MachineMemOperand::Flags to allowsMemoryAccess tests (PR42123).

LGTM.

Jun 11 2019, 8:49 AM · Restricted Project

Jun 4 2019

kparzysz accepted D62867: UpdateTestChecks: hexagon support.
Jun 4 2019, 12:37 PM · Restricted Project
kparzysz added a comment to D62867: UpdateTestChecks: hexagon support.

What is this in preparation of? Why are only these 3 tests affected?

Jun 4 2019, 10:47 AM · Restricted Project

May 29 2019

kparzysz added a comment to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++.

This commit stopped clang++ from finding libc++:

May 29 2019, 12:58 PM · Restricted Project, Restricted Project, Restricted Project

May 16 2019

kparzysz accepted D61705: Tablegen type comparison LE should be LT or equal..
May 16 2019, 8:23 AM · Restricted Project

May 9 2019

kparzysz added inline comments to D61705: Tablegen type comparison LE should be LT or equal..
May 9 2019, 5:47 AM · Restricted Project

May 3 2019

kparzysz accepted D61133: [hexagon] change AsmParser assertion to error.
May 3 2019, 9:32 AM · Restricted Project

May 2 2019

kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

Ping.

May 2 2019, 9:15 AM · Restricted Project

Apr 16 2019

kparzysz committed rGef6823ec8dac: [Hexagon] Remove indeterministic traversal order (authored by kparzysz).
[Hexagon] Remove indeterministic traversal order
Apr 16 2019, 9:06 AM
kparzysz committed rL358505: [Hexagon] Remove indeterministic traversal order.
[Hexagon] Remove indeterministic traversal order
Apr 16 2019, 9:05 AM

Apr 10 2019

kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

Ping.

Apr 10 2019, 6:45 AM · Restricted Project

Apr 3 2019

kparzysz added a comment to D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.

The problem is that in some contexts the explicit sign- or zero-extension may be deliberate, regardless of how boolean values are represented in wider types. Other than delegating that to the target experts, I don't know how to address that.

Apr 3 2019, 2:13 PM · Restricted Project
kparzysz committed rG4841643a1da2: [X86] Extend boolean arguments to inline-asm according to getBooleanType (authored by kparzysz).
[X86] Extend boolean arguments to inline-asm according to getBooleanType
Apr 3 2019, 10:42 AM
kparzysz committed rL357615: [X86] Extend boolean arguments to inline-asm according to getBooleanType.
[X86] Extend boolean arguments to inline-asm according to getBooleanType
Apr 3 2019, 10:42 AM
kparzysz closed D60208: [X86] Extend boolean arguments to inline-asm according to getBooleanType.
Apr 3 2019, 10:42 AM · Restricted Project
kparzysz created D60208: [X86] Extend boolean arguments to inline-asm according to getBooleanType.
Apr 3 2019, 9:09 AM · Restricted Project

Mar 29 2019

kparzysz added a comment to D60006: [SelectionDAG] Add fcmp UNDEF handling to SelectionDAG::FoldSetCC.

The Hexagon part is ok.

Mar 29 2019, 12:05 PM · Restricted Project

Mar 28 2019

kparzysz raised a concern with rCXX355318: [libc++] decoupling Freestanding atomic<T> from libatomic.a.

This commit seems to be implicated in a cmake-time warning. See http://lists.llvm.org/pipermail/cfe-dev/2019-March/061837.html for more information.

Mar 28 2019, 9:51 AM

Mar 27 2019

kparzysz added a comment to D59758: [DAGCombiner] Combine OR as ADD when no common bits are set.

The Hexagon testcase can be fixed---it's probably just a matter of changing the selection pattern for the instruction we're checking.

Mar 27 2019, 7:34 AM · Restricted Project

Mar 21 2019

kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

There can be many changes to the compiled code between the IR combiner and the DAG combiner, so these patterns can certainly appear before DAG combining takes place. Also, we already combine for rotates in the DAG, this patch only makes it more comprehensive.

Mar 21 2019, 10:45 AM · Restricted Project
kparzysz updated the diff for D47735: [DAGCombiner] Create rotates more aggressively.

Rebased on top of the pre-committed testcases.

Mar 21 2019, 10:26 AM · Restricted Project
kparzysz committed rG471950294149: Add more rotate tests, including ORs of rotates (authored by kparzysz).
Add more rotate tests, including ORs of rotates
Mar 21 2019, 10:14 AM
kparzysz committed rL356683: Add more rotate tests, including ORs of rotates.
Add more rotate tests, including ORs of rotates
Mar 21 2019, 10:14 AM
kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

Oof, I somehow missed the comments... :o

Mar 21 2019, 10:14 AM · Restricted Project

Mar 15 2019

kparzysz added a comment to D59363: [SelectionDAG] Add icmp UNDEF handling to SelectionDAG::FoldSetCC.

The Hexagon changes look good.

Mar 15 2019, 7:23 AM · Restricted Project

Mar 6 2019

kparzysz committed rG9c005bbdd4db: [Hexagon] Avoid creating 5-instruction packets with vgather pseudos (authored by kparzysz).
[Hexagon] Avoid creating 5-instruction packets with vgather pseudos
Mar 6 2019, 9:44 AM
kparzysz committed rL355524: [Hexagon] Avoid creating 5-instruction packets with vgather pseudos.
[Hexagon] Avoid creating 5-instruction packets with vgather pseudos
Mar 6 2019, 9:44 AM

Mar 1 2019

kparzysz added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

I was actually thinking about handling of target-specific relocations, and applying them to instructions. We used to have a large chunk of auto-generated code that did that. The implementation in lld is much shorter, so it's probably not a big deal if it needs to be repeated.

Mar 1 2019, 3:42 PM · Restricted Project
kparzysz added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

Since you're rewrite this, is there any potential for sharing code with lld? Relocating instructions should essentially be the same between these two.

Mar 1 2019, 11:46 AM · Restricted Project
kparzysz accepted D58595: [TableGen][SelectionDAG][X86] Add specific isel matchers for immAllZerosV/immAllOnesV. Remove bitcasts from X86 patterns that are no longer necessary..

Looks ok to me.

Mar 1 2019, 8:38 AM · Restricted Project
kparzysz added a comment to D47735: [DAGCombiner] Create rotates more aggressively.

Ping.

Mar 1 2019, 8:33 AM · Restricted Project

Feb 21 2019

kparzysz updated the diff for D47735: [DAGCombiner] Create rotates more aggressively.

This patch uses MatchRotate to do the actual matching, so it's only going to look for opportunities to create a rotate. Maybe that function should be replaced with MatchRotateOrFunnelShift in a future patch.

Feb 21 2019, 2:23 PM · Restricted Project