This is an archive of the discontinued LLVM Phabricator instance.

[clang][CodeGen] Only include ABIInfo.h where required (NFC)
ClosedPublic

Authored by barannikov88 on Jul 21 2022, 6:11 PM.

Diff Detail

Event Timeline

barannikov88 created this revision.Jul 21 2022, 6:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 6:11 PM
barannikov88 requested review of this revision.Jul 21 2022, 6:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 6:11 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
barannikov88 retitled this revision from [clang][CodeGen] Only include ABIInfo.h where required to [clang][CodeGen] Only include ABIInfo.h where required (NFC).Jul 21 2022, 6:16 PM
barannikov88 added a reviewer: kazu.
barannikov88 added inline comments.Jul 21 2022, 6:20 PM
clang/lib/CodeGen/CGCall.h
26

This is the main change. The included file was not used here at all.

barannikov88 added inline comments.Jul 21 2022, 6:26 PM
clang/lib/CodeGen/TargetInfo.h
49

Had to do this due to "incomplete class" error. Should not change a thing because this constructor is ever used in TargetInfo.cpp, where it now resides.

To reviewers: if you are OK with the patch, could you please merge it? I don't have permission yet.

barannikov88 updated this revision to Diff 446685.EditedJul 21 2022, 7:01 PM

Removed forward declaration of another unused class.

barannikov88 added inline comments.Jul 21 2022, 7:08 PM
clang/lib/CodeGen/ABIInfo.h
39 ↗(On Diff #446685)

Not used in this file. (This class does not seem to be used anywhere.)

MaskRay accepted this revision.Jul 21 2022, 7:26 PM

LGTM.

This revision is now accepted and ready to land.Jul 21 2022, 7:26 PM

@MaskRay
Would you please merge it?

Testing and will push in one minute

clang/lib/CodeGen/CGObjCRuntime.h
37

The style is to remove indentation. I'll fix it.

This revision was landed with ongoing or failed builds.Jul 22 2022, 10:45 AM
This revision was automatically updated to reflect the committed changes.

Testing and will push in one minute

Thanks!