Page MenuHomePhabricator
People kazu

kazu (Kazu Hirata)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2019, 10:35 AM (177 w, 3 d)

Recent Activity
View All

Today

kazu committed rG7370e45fb480: Fix warnings (authored by kazu).
Fix warnings
Fri, Mar 24, 9:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu added a comment to D146787: [X86] Teach computeKnownBitsForTargetNode about MUL_IMM.

Please take a look. Thanks!

Fri, Mar 24, 9:27 AM · Restricted Project, Restricted Project
kazu updated the diff for D146787: [X86] Teach computeKnownBitsForTargetNode about MUL_IMM.

Switched to KnownBits::mul.

Fri, Mar 24, 9:27 AM · Restricted Project, Restricted Project
kazu updated the diff for D146787: [X86] Teach computeKnownBitsForTargetNode about MUL_IMM.

Guard against a potential integer overflow.

Fri, Mar 24, 12:23 AM · Restricted Project, Restricted Project
kazu added reviewers for D146787: [X86] Teach computeKnownBitsForTargetNode about MUL_IMM: RKSimon, spatel, goldstein.w.n, nikic, pengfei.
Fri, Mar 24, 12:13 AM · Restricted Project, Restricted Project
kazu requested review of D146787: [X86] Teach computeKnownBitsForTargetNode about MUL_IMM.
Fri, Mar 24, 12:11 AM · Restricted Project, Restricted Project

Yesterday

kazu committed rG1e4325f30c24: [X86] Precommit a test (authored by kazu).
[X86] Precommit a test
Thu, Mar 23, 11:49 PM · Restricted Project, Restricted Project
kazu committed rGd8efbcf9dcbb: [AArch64] Add tests for umax(x, 1u) (authored by kazu).
[AArch64] Add tests for umax(x, 1u)
Thu, Mar 23, 8:21 PM · Restricted Project, Restricted Project
kazu updated the diff for D145890: [InstCombine] Generate better code for std::bit_floor from libstdc++.

Rebased.

Thu, Mar 23, 7:37 PM · Restricted Project, Restricted Project
kazu committed rG231fa2743510: [InstCombine] Generate better code for std::bit_ceil (authored by kazu).
[InstCombine] Generate better code for std::bit_ceil
Thu, Mar 23, 7:27 PM · Restricted Project, Restricted Project
kazu committed rG5f48b861f8ce: [SelectionDAG] Use isOneConstant (NFC) (authored by kazu).
[SelectionDAG] Use isOneConstant (NFC)
Thu, Mar 23, 7:27 PM · Restricted Project, Restricted Project
kazu closed D145299: [InstCombine] Generate better code for std::bit_ceil.
Thu, Mar 23, 7:27 PM · Restricted Project, Restricted Project
kazu added inline comments to D145299: [InstCombine] Generate better code for std::bit_ceil.
Thu, Mar 23, 7:08 PM · Restricted Project, Restricted Project
kazu updated the diff for D145299: [InstCombine] Generate better code for std::bit_ceil.

Adjusted MatchForward.
Adjusted the condition for select.

Thu, Mar 23, 7:06 PM · Restricted Project, Restricted Project

Wed, Mar 22

kazu added a comment to D145890: [InstCombine] Generate better code for std::bit_floor from libstdc++.

Please take look. Thanks!

Wed, Mar 22, 11:44 PM · Restricted Project, Restricted Project
kazu added a comment to D145890: [InstCombine] Generate better code for std::bit_floor from libstdc++.
In D145890#4209037, @RKSimon wrote:

please can you add vector test coverage?

Wed, Mar 22, 11:43 PM · Restricted Project, Restricted Project
kazu updated the diff for D145890: [InstCombine] Generate better code for std::bit_floor from libstdc++.

Added a vector test and some negative tests.

Wed, Mar 22, 11:42 PM · Restricted Project, Restricted Project
kazu committed rGf9f4767af9f3: [InstCombine] Precommit tests (authored by kazu).
[InstCombine] Precommit tests
Wed, Mar 22, 11:28 PM · Restricted Project, Restricted Project
kazu added a comment to D145299: [InstCombine] Generate better code for std::bit_ceil.

I've updated the patch. Please take a look. Thanks!

Wed, Mar 22, 11:06 PM · Restricted Project, Restricted Project
kazu updated the diff for D145299: [InstCombine] Generate better code for std::bit_ceil.

Updated tests, including a vector one.

Wed, Mar 22, 10:56 PM · Restricted Project, Restricted Project
kazu committed rG7bb6d1b32ea9: [llvm] Skip getAPIntValue (NFC) (authored by kazu).
[llvm] Skip getAPIntValue (NFC)
Wed, Mar 22, 10:11 PM · Restricted Project, Restricted Project
kazu committed rG4524db7316b2: [ARM] Use isNullConstant (NFC) (authored by kazu).
[ARM] Use isNullConstant (NFC)
Wed, Mar 22, 10:11 PM · Restricted Project, Restricted Project
kazu committed rG8d93cbed6e38: [InstCombine] Precommit tests (authored by kazu).
[InstCombine] Precommit tests
Wed, Mar 22, 10:11 PM · Restricted Project, Restricted Project
kazu committed rG0d19e583f106: [InstCombine] Precommit a test (authored by kazu).
[InstCombine] Precommit a test
Wed, Mar 22, 10:11 PM · Restricted Project, Restricted Project
kazu committed rG9bb96fd87498: [llvm] Use llvm::isNullConstant (NFC) (authored by kazu).
[llvm] Use llvm::isNullConstant (NFC)
Wed, Mar 22, 12:32 AM · Restricted Project, Restricted Project
kazu committed rG1fe6a8a584fe: [X86] Use llvm::isOneConstant (NFC) (authored by kazu).
[X86] Use llvm::isOneConstant (NFC)
Wed, Mar 22, 12:25 AM · Restricted Project, Restricted Project

Tue, Mar 21

kazu committed rGb9c4b95b11b5: [llvm] Use ConstantInt::{isZero,isOne} (NFC) (authored by kazu).
[llvm] Use ConstantInt::{isZero,isOne} (NFC)
Tue, Mar 21, 5:41 PM · Restricted Project, Restricted Project
kazu added a comment to D145299: [InstCombine] Generate better code for std::bit_ceil.

Please take a look. Thanks!

Tue, Mar 21, 2:12 PM · Restricted Project, Restricted Project
kazu updated the diff for D145299: [InstCombine] Generate better code for std::bit_ceil.
  • Removed the empty clause.
  • Removed RangeOp.
  • Switched to CreateNeg.
  • Made the matching a little more straightforward.
Tue, Mar 21, 2:10 PM · Restricted Project, Restricted Project

Mon, Mar 20

kazu updated the diff for D145299: [InstCombine] Generate better code for std::bit_ceil.

Use m_APInt instead of m_ConstantInt.

Mon, Mar 20, 12:59 PM · Restricted Project, Restricted Project
kazu added inline comments to D145299: [InstCombine] Generate better code for std::bit_ceil.
Mon, Mar 20, 8:58 AM · Restricted Project, Restricted Project

Sun, Mar 19

kazu added a comment to D145299: [InstCombine] Generate better code for std::bit_ceil.
In D145299#4205118, @nikic wrote:

I haven't looked in detail what you're doing here, but you're clearly looking for the ConstantRange class. makeExactICmpRegion(), add(), sub(), binaryNot(), etc.

Sun, Mar 19, 5:21 PM · Restricted Project, Restricted Project
kazu updated the diff for D145299: [InstCombine] Generate better code for std::bit_ceil.

Started using ConstantRange.

Sun, Mar 19, 5:20 PM · Restricted Project, Restricted Project
kazu added a reviewer for D145299: [InstCombine] Generate better code for std::bit_ceil: pengfei.
Sun, Mar 19, 2:11 PM · Restricted Project, Restricted Project
kazu added a comment to D145890: [InstCombine] Generate better code for std::bit_floor from libstdc++.

Please take a look. Thanks!

Sun, Mar 19, 2:09 PM · Restricted Project, Restricted Project
kazu updated the diff for D145890: [InstCombine] Generate better code for std::bit_floor from libstdc++.

Combine some "if" statements.

Sun, Mar 19, 2:09 PM · Restricted Project, Restricted Project
kazu added a comment to D145299: [InstCombine] Generate better code for std::bit_ceil.

Please take a look. Thanks!

Sun, Mar 19, 1:59 PM · Restricted Project, Restricted Project
kazu updated the summary of D145299: [InstCombine] Generate better code for std::bit_ceil.
Sun, Mar 19, 1:58 PM · Restricted Project, Restricted Project
kazu updated the diff for D145299: [InstCombine] Generate better code for std::bit_ceil.

Handle more cases.

Sun, Mar 19, 1:56 PM · Restricted Project, Restricted Project
kazu added inline comments to D145299: [InstCombine] Generate better code for std::bit_ceil.
Sun, Mar 19, 1:47 PM · Restricted Project, Restricted Project
kazu committed rGef860cf150f0: [InstCombine] Precommit tests (authored by kazu).
[InstCombine] Precommit tests
Sun, Mar 19, 1:45 PM · Restricted Project, Restricted Project

Thu, Mar 16

kazu committed rG96118f1b0ab7: [Inliner] clang-format InlineCost.cpp and Inliner.cpp (NFC) (authored by kazu).
[Inliner] clang-format InlineCost.cpp and Inliner.cpp (NFC)
Thu, Mar 16, 2:56 PM · Restricted Project, Restricted Project
kazu committed rG91362e5d5e4d: [mlir] Fix a warning (authored by kazu).
[mlir] Fix a warning
Thu, Mar 16, 1:03 PM · Restricted Project, Restricted Project

Wed, Mar 15

kazu committed rG4e585e51c167: Use *{Map,Set}::contains (NFC) (authored by kazu).
Use *{Map,Set}::contains (NFC)
Wed, Mar 15, 10:56 PM · Restricted Project, Restricted Project, Restricted Project
kazu committed rG7eaa7b055389: [clang] Use *{Map,Set}::contains (NFC) (authored by kazu).
[clang] Use *{Map,Set}::contains (NFC)
Wed, Mar 15, 6:07 PM · Restricted Project, Restricted Project
kazu committed rG398af9b43bbf: [llvm] Use *{Map,Set}::contains (NFC) (authored by kazu).
[llvm] Use *{Map,Set}::contains (NFC)
Wed, Mar 15, 6:07 PM · Restricted Project, Restricted Project
kazu committed rGc7c1d531b9a7: [Lex] Use false instead of 0 (NFC) (authored by kazu).
[Lex] Use false instead of 0 (NFC)
Wed, Mar 15, 6:07 PM · Restricted Project, Restricted Project
kazu added inline comments to D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits (WIP).
Wed, Mar 15, 12:41 PM · Restricted Project, Restricted Project
kazu accepted D146061: [ADT] Make llvm::is_contained call member `contains` or `find` when available.

LGTM. I like the fallback mechanism. We prefer to use X.contains(), but if that's not possible (or people just randomly call llvm::is_contained), llvm::is_contained is there to do the right thing for you.

Wed, Mar 15, 8:54 AM · Restricted Project, Restricted Project
kazu committed rG8bdf38785888: Use *{Map,Set}::contains (NFC) (authored by kazu).
Use *{Map,Set}::contains (NFC)
Wed, Mar 15, 8:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu closed D146104: Use *{Map,Set}::contains (NFC).
Wed, Mar 15, 8:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Mar 14

kazu committed rG0aee67ad4e6e: [polly] Use DenseMap::contains (NFC) (authored by kazu).
[polly] Use DenseMap::contains (NFC)
Tue, Mar 14, 11:09 PM · Restricted Project
kazu committed rGd61f560919f4: [flang] Use Use *{Set,Map}::contains (NFC) (authored by kazu).
[flang] Use Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 10:21 PM · Restricted Project, Restricted Project
kazu committed rGce14f7b18fe1: [mlir] Use Use *{Set,Map}::contains (NFC) (authored by kazu).
[mlir] Use Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 9:49 PM · Restricted Project, Restricted Project
kazu committed rG65a2d6d6904f: [lldb] Use *{Set,Map}::contains (NFC) (authored by kazu).
[lldb] Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 9:42 PM · Restricted Project
kazu committed rG15aa965363df: [clang-tools-extra] Use *{Set,Map}::contains (NFC) (authored by kazu).
[clang-tools-extra] Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 9:31 PM · Restricted Project, Restricted Project
kazu committed rGea9d404032be: [clang] Use *{Set,Map}::contains (NFC) (authored by kazu).
[clang] Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 7:17 PM · Restricted Project, Restricted Project
kazu committed rGb595eb83e5c1: [llvm] Use *{Set,Map}::contains (NFC) (authored by kazu).
[llvm] Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 6:56 PM · Restricted Project, Restricted Project
kazu committed rG7ada7bbee17f: [Target] Use *{Set,Map}::contains (NFC) (authored by kazu).
[Target] Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 6:07 PM · Restricted Project, Restricted Project
kazu added reviewers for D146104: Use *{Map,Set}::contains (NFC): kuhar, dblaikie, nikic.
Tue, Mar 14, 5:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu requested review of D146104: Use *{Map,Set}::contains (NFC).
Tue, Mar 14, 5:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu added a comment to D146061: [ADT] Make llvm::is_contained call member `contains` or `find` when available.
In D146061#4194466, @kuhar wrote:

Then I propose we frame it like this: llvm::is_contained is the (llvm-only) canonical/generic way to check if an element is in the range.

Tue, Mar 14, 2:05 PM · Restricted Project, Restricted Project
kazu committed rGe46d8a731535: [InlineOrder] Plugin Inline Order (authored by kazu).
[InlineOrder] Plugin Inline Order
Tue, Mar 14, 1:14 PM · Restricted Project, Restricted Project
kazu closed D140637: [InlineOrder] Plugin Inline Order.
Tue, Mar 14, 1:14 PM · Restricted Project, Restricted Project
kazu committed rGa585fa263777: [CodeGen] Use *{Set,Map}::contains (NFC) (authored by kazu).
[CodeGen] Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 8:08 AM · Restricted Project, Restricted Project
kazu committed rG11efd1cb04d0: [Analysis] Use *{Set,Map}::contains (NFC) (authored by kazu).
[Analysis] Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 12:33 AM · Restricted Project, Restricted Project
kazu committed rGc8f9555c4d2d: [Transforms] Use *{Set,Map}::contains (NFC) (authored by kazu).
[Transforms] Use *{Set,Map}::contains (NFC)
Tue, Mar 14, 12:25 AM · Restricted Project, Restricted Project

Mon, Mar 13

kazu accepted D140637: [InlineOrder] Plugin Inline Order.

Thank you for updating the patch. LGTM.

Mon, Mar 13, 8:38 PM · Restricted Project, Restricted Project
kazu added a comment to D145895: [ADT] Implement {DenseMap,MapVector,StringMap}::contains.
In D145895#4189370, @kuhar wrote:

LGTM.

Separately, it would be cool if we could make llvm::is_contained use the contains member when available, instead of doing a linear scan. It seems like a bit of a foot gun to me to have 2 functions with almost identical names but vastly different performance characteristics.

Mon, Mar 13, 9:41 AM · Restricted Project, Restricted Project
kazu committed rG21700677cb44: [ADT] Implement {DenseMap,MapVector,StringMap}::contains (authored by kazu).
[ADT] Implement {DenseMap,MapVector,StringMap}::contains
Mon, Mar 13, 9:13 AM · Restricted Project, Restricted Project
kazu closed D145895: [ADT] Implement {DenseMap,MapVector,StringMap}::contains.
Mon, Mar 13, 9:13 AM · Restricted Project, Restricted Project
kazu committed rGd298b02dbaa7: [mlir] Use llvm::is_contained (NFC) (authored by kazu).
[mlir] Use llvm::is_contained (NFC)
Mon, Mar 13, 12:44 AM · Restricted Project, Restricted Project

Sun, Mar 12

kazu committed rG23bd0e037b74: [mlir] Use std::optional instead of llvm::Optional (NFC) (authored by kazu).
[mlir] Use std::optional instead of llvm::Optional (NFC)
Sun, Mar 12, 11:02 PM · Restricted Project, Restricted Project
kazu added reviewers for D145895: [ADT] Implement {DenseMap,MapVector,StringMap}::contains: kuhar, MaskRay, dblaikie.
Sun, Mar 12, 10:25 PM · Restricted Project, Restricted Project
kazu requested review of D145895: [ADT] Implement {DenseMap,MapVector,StringMap}::contains.
Sun, Mar 12, 10:23 PM · Restricted Project, Restricted Project
kazu committed rGf271e5d9d44e: [SelectionDAG] Deprecate isNullValue and isAllOnesValue (authored by kazu).
[SelectionDAG] Deprecate isNullValue and isAllOnesValue
Sun, Mar 12, 6:25 PM · Restricted Project, Restricted Project
kazu closed D145357: [SelectionDAG] Deprecate isNullValue and isAllOnesValue.
Sun, Mar 12, 6:25 PM · Restricted Project, Restricted Project
kazu added reviewers for D145890: [InstCombine] Generate better code for std::bit_floor from libstdc++: RKSimon, spatel, goldstein.w.n, pengfei.
Sun, Mar 12, 6:05 PM · Restricted Project, Restricted Project
kazu requested review of D145890: [InstCombine] Generate better code for std::bit_floor from libstdc++.
Sun, Mar 12, 6:03 PM · Restricted Project, Restricted Project
kazu added a comment to D145299: [InstCombine] Generate better code for std::bit_ceil.
In D145299#4177666, @RKSimon wrote:

This should be handled in InstCombine

Sun, Mar 12, 1:06 PM · Restricted Project, Restricted Project
kazu retitled D145299: [InstCombine] Generate better code for std::bit_ceil from [X86] Generate better code for std::bit_ceil to [InstCombine] Generate better code for std::bit_ceil.
Sun, Mar 12, 1:04 PM · Restricted Project, Restricted Project
kazu updated the diff for D145299: [InstCombine] Generate better code for std::bit_ceil.

Ported to InstCombine.

Sun, Mar 12, 1:03 PM · Restricted Project, Restricted Project
kazu committed rG7946e67cf3e3: [InstCombine] Precommit tests (authored by kazu).
[InstCombine] Precommit tests
Sun, Mar 12, 12:00 PM · Restricted Project, Restricted Project

Fri, Mar 10

kazu added a comment to D140637: [InlineOrder] Plugin Inline Order.

Thank you for explaining how things work.

Fri, Mar 10, 2:34 PM · Restricted Project, Restricted Project

Wed, Mar 8

kazu added a comment to D140637: [InlineOrder] Plugin Inline Order.

I think I have a high-level understanding, but I haven't understood the implementation yet.

Wed, Mar 8, 9:56 AM · Restricted Project, Restricted Project

Tue, Mar 7

kazu committed rG912404db7882: [ControlHeightReduction] Freeze potentially poisonous conditions (authored by kazu).
[ControlHeightReduction] Freeze potentially poisonous conditions
Tue, Mar 7, 1:20 PM · Restricted Project, Restricted Project
kazu closed D145008: [ControlHeightReduction] Don't combine a "poison" branch.
Tue, Mar 7, 1:20 PM · Restricted Project, Restricted Project

Mon, Mar 6

kazu added reviewers for D145468: [X86] Optimize (and (srl X 30) 2): RKSimon, spatel, goldstein.w.n.
Mon, Mar 6, 9:50 PM · Restricted Project, Restricted Project
kazu requested review of D145468: [X86] Optimize (and (srl X 30) 2).
Mon, Mar 6, 9:49 PM · Restricted Project, Restricted Project
kazu committed rG3a0d5d846a67: [X86] Precommit a test (authored by kazu).
[X86] Precommit a test
Mon, Mar 6, 7:46 PM · Restricted Project, Restricted Project
kazu committed rG0fa1ee8f1c31: [DebugInfo] Fix a warning (authored by kazu).
[DebugInfo] Fix a warning
Mon, Mar 6, 7:29 PM · Restricted Project, Restricted Project
kazu committed rGd83492c97d9c: [mlir] Fix a warning (authored by kazu).
[mlir] Fix a warning
Mon, Mar 6, 1:57 PM · Restricted Project, Restricted Project
kazu added a comment to D145008: [ControlHeightReduction] Don't combine a "poison" branch.

Please take a look. Thanks!

Mon, Mar 6, 11:24 AM · Restricted Project, Restricted Project
kazu committed rGa21a7ddf5ad1: [X86] Optimize umax(X,1) (NFC) (authored by kazu).
[X86] Optimize umax(X,1) (NFC)
Mon, Mar 6, 10:19 AM · Restricted Project, Restricted Project
kazu closed D144451: [X86] Optimize umax(X,1).
Mon, Mar 6, 10:19 AM · Restricted Project, Restricted Project

Sun, Mar 5

kazu added reviewers for D145357: [SelectionDAG] Deprecate isNullValue and isAllOnesValue: MaskRay, dblaikie.
Sun, Mar 5, 11:55 PM · Restricted Project, Restricted Project
kazu requested review of D145357: [SelectionDAG] Deprecate isNullValue and isAllOnesValue.
Sun, Mar 5, 11:55 PM · Restricted Project, Restricted Project
kazu committed rG462b29019b20: [APInt] Deprecate several functions (authored by kazu).
[APInt] Deprecate several functions
Sun, Mar 5, 10:49 PM · Restricted Project, Restricted Project
kazu closed D144423: [APInt] Deprecate several functions.
Sun, Mar 5, 10:48 PM · Restricted Project, Restricted Project
kazu updated the diff for D144423: [APInt] Deprecate several functions.

Deprecate countPopulation as before.

Sun, Mar 5, 10:48 PM · Restricted Project, Restricted Project