Page MenuHomePhabricator

kazu (Kazu Hirata)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2019, 10:35 AM (86 w, 9 h)

Recent Activity

Today

kazu added inline comments to D104654: [llvm][Inliner] Make PriorityInlineOrder lazily updated.
Mon, Jun 21, 5:08 PM · Restricted Project

Thu, Jun 17

kazu added inline comments to D104028: [llvm][Inliner] Add an optional PriorityInlineOrder.
Thu, Jun 17, 10:07 AM · Restricted Project

Wed, Jun 16

kazu added a comment to D104028: [llvm][Inliner] Add an optional PriorityInlineOrder.

I am tuning the performance by reordering inlining in downstream. My first try was to use std::priority_queue. But I tried to use the inline cost heuristic to order them. In this patch it looks like sort callsites by HistoryID? What's the intention?

Wed, Jun 16, 10:43 AM · Restricted Project

Mon, Jun 14

kazu added inline comments to D104028: [llvm][Inliner] Add an optional PriorityInlineOrder.
Mon, Jun 14, 10:21 AM · Restricted Project

Thu, Jun 3

kazu accepted D103315: Add interface to order inlining.

Thanks for updating the patch!

Thu, Jun 3, 9:33 AM · Restricted Project

Tue, Jun 1

kazu added a comment to D103315: Add interface to order inlining.

Thanks for the update. I'd generalize the code around Call.erase a little bit more to accommodate other underlying data structures. See the comments below for details.

Tue, Jun 1, 10:26 AM · Restricted Project

Fri, May 28

kazu added a comment to D103315: Add interface to order inlining.

I also agree this is in the right direction. I've left some minor comments.

Fri, May 28, 10:33 AM · Restricted Project

Mar 29 2021

kazu accepted D98577: [InlineCost] Compute the savings of switch statements and SROA in the cost benefit analysis.

Thank you for running benchmarks!

Mar 29 2021, 3:22 PM · Restricted Project

Mar 25 2021

kazu committed rG9d375a40c3df: Reapply [InlineCost] Enable the cost benefit analysis on FDO (authored by kazu).
Reapply [InlineCost] Enable the cost benefit analysis on FDO
Mar 25 2021, 9:52 PM
kazu committed rG3c775d93a1dd: [InlineCost] Reject a zero entry count (authored by kazu).
[InlineCost] Reject a zero entry count
Mar 25 2021, 9:52 PM
kazu added a comment to rGef69aa961d12: [InlineCost] Enable the cost benefit analysis on FDO.

Thank you for taking the time to revert the patch. Let me look into this.

Mar 25 2021, 2:50 PM

Mar 24 2021

kazu added a comment to D98577: [InlineCost] Compute the savings of switch statements and SROA in the cost benefit analysis.

Do you think you could try some benchmarks?

Mar 24 2021, 4:24 PM · Restricted Project
kazu committed rGef69aa961d12: [InlineCost] Enable the cost benefit analysis on FDO (authored by kazu).
[InlineCost] Enable the cost benefit analysis on FDO
Mar 24 2021, 3:37 PM
kazu closed D98213: [InlineCost] Enable the cost benefit analysis on FDO.
Mar 24 2021, 3:37 PM · Restricted Project

Mar 11 2021

kazu added inline comments to D98213: [InlineCost] Enable the cost benefit analysis on FDO.
Mar 11 2021, 11:15 AM · Restricted Project
kazu added a comment to D98213: [InlineCost] Enable the cost benefit analysis on FDO.

What's the .text size change for your internal benchmark when you turn it on?

Mar 11 2021, 11:02 AM · Restricted Project

Mar 10 2021

kazu added a comment to D98297: [NFC] Fix a compiler warning.

May I ask which cpp file you see the warning in? I just built clang and llvm, but I wasn't able to reproduce the warning. Thanks!

Mar 10 2021, 12:44 AM · Restricted Project

Mar 8 2021

kazu requested review of D98213: [InlineCost] Enable the cost benefit analysis on FDO.
Mar 8 2021, 12:17 PM · Restricted Project

Mar 6 2021

kazu committed rGdd9a6411846b: [TableGen] Use range-based for loops (NFC) (authored by kazu).
[TableGen] Use range-based for loops (NFC)
Mar 6 2021, 3:53 PM
kazu committed rG3e8be5ab8716: [objdump] Use ListSeparator (NFC) (authored by kazu).
[objdump] Use ListSeparator (NFC)
Mar 6 2021, 3:53 PM
kazu committed rG31443f8e86ec: [clang] Fix typos in documentation (NFC) (authored by kazu).
[clang] Fix typos in documentation (NFC)
Mar 6 2021, 3:53 PM

Mar 1 2021

kazu committed rG4444b343d7e2: [IR] Use range-based for loops (NFC) (authored by kazu).
[IR] Use range-based for loops (NFC)
Mar 1 2021, 11:41 PM
kazu committed rG3a80088357d1: [readobj] Use ListSeparator (NFC) (authored by kazu).
[readobj] Use ListSeparator (NFC)
Mar 1 2021, 11:41 PM
kazu committed rG4fd3347d6e4b: [lldb] Fix typos in documentation (NFC) (authored by kazu).
[lldb] Fix typos in documentation (NFC)
Mar 1 2021, 11:41 PM

Feb 28 2021

kazu committed rGb4bed1cb245b: [IR] Use range-based for loops (NFC) (authored by kazu).
[IR] Use range-based for loops (NFC)
Feb 28 2021, 11:00 AM
kazu committed rG87360d6ff71a: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 28 2021, 11:00 AM
kazu committed rGd639120983c6: [llvm] Use set_is_subset (NFC) (authored by kazu).
[llvm] Use set_is_subset (NFC)
Feb 28 2021, 11:00 AM

Feb 27 2021

kazu committed rG6a337f85c8fa: [IR] Use range-based for loops (NFC) (authored by kazu).
[IR] Use range-based for loops (NFC)
Feb 27 2021, 10:10 AM
kazu committed rGe8fa9014cce4: [llvm] Fix typos in documentation (NFC) (authored by kazu).
[llvm] Fix typos in documentation (NFC)
Feb 27 2021, 10:10 AM
kazu committed rGc81dde929281: [llvm-readobj] Use ListSeparator (NFC) (authored by kazu).
[llvm-readobj] Use ListSeparator (NFC)
Feb 27 2021, 10:10 AM

Feb 26 2021

kazu committed rG1d4a2f37785b: [Transforms/Utils] Use range-based for loops (NFC) (authored by kazu).
[Transforms/Utils] Use range-based for loops (NFC)
Feb 26 2021, 10:37 PM
kazu committed rGf0e6d8dad526: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 26 2021, 10:37 PM
kazu committed rG233ba2709bde: [Driver] Fix a warning about the the initialization order (authored by kazu).
[Driver] Fix a warning about the the initialization order
Feb 26 2021, 4:33 PM

Feb 25 2021

kazu committed rG5fc9e3098569: [Scalar] Use range-based for loops (NFC) (authored by kazu).
[Scalar] Use range-based for loops (NFC)
Feb 25 2021, 7:55 PM
kazu committed rGedd92e018a7b: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 25 2021, 7:55 PM

Feb 23 2021

kazu added a comment to D97336: [InstrProfiling] Use nobits for __llvm_prf_cnts with binutils >=2.28.

This patch fixes the problem I was having while building an instrumented binary.

Feb 23 2021, 4:19 PM · Restricted Project

Feb 22 2021

kazu committed rG896d0e1a2a79: [Analysis] Use range-based for loops (NFC) (authored by kazu).
[Analysis] Use range-based for loops (NFC)
Feb 22 2021, 8:18 PM
kazu committed rG4ed47858ab76: [llvm] Use llvm::drop_begin (NFC) (authored by kazu).
[llvm] Use llvm::drop_begin (NFC)
Feb 22 2021, 8:18 PM
kazu committed rG871affc5e779: [Analysis] Use ListSeparator (NFC) (authored by kazu).
[Analysis] Use ListSeparator (NFC)
Feb 22 2021, 8:17 PM
kazu committed rG7c83799fd838: [MacroExpansionContext] Fix a warning. (authored by kazu).
[MacroExpansionContext] Fix a warning.
Feb 22 2021, 4:55 PM

Feb 21 2021

kazu committed rGffba9e596d09: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 21 2021, 7:59 PM
kazu committed rG5032b5890bb4: [llvm] Fix header guards (NFC) (authored by kazu).
[llvm] Fix header guards (NFC)
Feb 21 2021, 7:58 PM
kazu committed rG047fc3bf20b3: [Analysis] Use ListSeparator (NFC) (authored by kazu).
[Analysis] Use ListSeparator (NFC)
Feb 21 2021, 7:58 PM

Feb 20 2021

kazu committed rG0b417ba20f21: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 20 2021, 9:47 PM
kazu committed rG9e4033b06bec: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 20 2021, 9:47 PM

Feb 19 2021

kazu committed rGa205fa5cd9e4: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 19 2021, 10:44 PM
kazu committed rGf169c027d6e0: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 19 2021, 10:44 PM

Feb 18 2021

kazu committed rGfd04f3a30cbb: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 18 2021, 10:47 PM
kazu committed rG2d5eb67235c7: [Support] Use static_assert instead of assert (NFC) (authored by kazu).
[Support] Use static_assert instead of assert (NFC)
Feb 18 2021, 10:47 PM
kazu committed rG744a96afed9e: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 18 2021, 10:47 PM

Feb 17 2021

kazu committed rG61efa3d93f73: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 17 2021, 11:59 PM
kazu committed rGe54579307b15: [llvm] Ensure newlines at the end of files (NFC) (authored by kazu).
[llvm] Ensure newlines at the end of files (NFC)
Feb 17 2021, 11:59 PM
kazu committed rG8e13bbca0883: [CodeGen] Use ListSeparator (NFC) (authored by kazu).
[CodeGen] Use ListSeparator (NFC)
Feb 17 2021, 11:59 PM

Feb 16 2021

kazu committed rGab8a62057384: [OpenMP] Fix a warning on an unused variable (authored by kazu).
[OpenMP] Fix a warning on an unused variable
Feb 16 2021, 11:47 PM
kazu committed rG3279943adf41: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 16 2021, 11:23 PM
kazu committed rG2620459baabe: [llvm] Fix header guards (NFC) (authored by kazu).
[llvm] Fix header guards (NFC)
Feb 16 2021, 11:23 PM
kazu committed rGdf35a183d7d4: [SCEV] Use ListSeparator (NFC) (authored by kazu).
[SCEV] Use ListSeparator (NFC)
Feb 16 2021, 11:23 PM
kazu added a comment to rG310b35304cdf: [SampleFDO][NFC] Refactor SampleProfile.cpp.

This patch seems to break the shared build while building lib/libLLVMProfileData.so.13git.

Feb 16 2021, 2:05 PM
kazu committed rGba2aa5f49ebb: [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl (authored by kazu).
[SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl
Feb 16 2021, 1:18 PM
kazu closed D96810: [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl.
Feb 16 2021, 1:18 PM · Restricted Project
kazu requested review of D96810: [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl.
Feb 16 2021, 12:47 PM · Restricted Project
kazu committed rG1a323c8a96af: [analyzer] Fix a warning (authored by kazu).
[analyzer] Fix a warning
Feb 16 2021, 9:12 AM

Feb 15 2021

kazu committed rG22f00f61dd54: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 15 2021, 2:47 PM
kazu committed rGf0d5898f939f: [Support] Use ListSeparator (NFC) (authored by kazu).
[Support] Use ListSeparator (NFC)
Feb 15 2021, 2:47 PM
kazu committed rGc82cd5e54e10: [LazyCallGraph] Remove forward declarations of nonexistent classes (NFC) (authored by kazu).
[LazyCallGraph] Remove forward declarations of nonexistent classes (NFC)
Feb 15 2021, 2:47 PM

Feb 14 2021

kazu committed rGb4c0d610a660: [AMDGPU] Fix build breakage (authored by kazu).
[AMDGPU] Fix build breakage
Feb 14 2021, 9:03 AM
kazu committed rG910e2d1e57b7: [llvm] Use llvm::is_contained (NFC) (authored by kazu).
[llvm] Use llvm::is_contained (NFC)
Feb 14 2021, 8:37 AM
kazu committed rG1cc558bd4fa1: [llvm] Fix header guards (NFC) (authored by kazu).
[llvm] Fix header guards (NFC)
Feb 14 2021, 8:37 AM
kazu committed rG6ac12e4b348c: [Analysis] Use ListSeparator (NFC) (authored by kazu).
[Analysis] Use ListSeparator (NFC)
Feb 14 2021, 8:37 AM

Feb 13 2021

kazu committed rGd5adba10f049: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 13 2021, 8:42 PM
kazu committed rGdfa3ead01ebf: [Analysis] Drop unnecessary const from return types (NFC) (authored by kazu).
[Analysis] Drop unnecessary const from return types (NFC)
Feb 13 2021, 8:42 PM
kazu committed rGd3c304534447: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 13 2021, 8:42 PM

Feb 12 2021

kazu committed rG905cf88d1877: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 12 2021, 11:45 PM
kazu committed rG96c90a6d14af: [AMDGPU] Drop unnecessary const from a return type (NFC) (authored by kazu).
[AMDGPU] Drop unnecessary const from a return type (NFC)
Feb 12 2021, 11:45 PM
kazu committed rG64557e096d4a: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 12 2021, 11:45 PM

Feb 11 2021

kazu committed rGd61b4cb9d8de: [CodeGen] Use range-based for loops (NFC) (authored by kazu).
[CodeGen] Use range-based for loops (NFC)
Feb 11 2021, 11:32 PM
kazu committed rG9dc62d1dc147: [PGO] Drop unnecessary const from return types (NFC) (authored by kazu).
[PGO] Drop unnecessary const from return types (NFC)
Feb 11 2021, 11:32 PM
kazu committed rG3e2e63060f6f: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 11 2021, 11:32 PM

Feb 10 2021

kazu committed rGc5e90a885754: [AsmPrinter] Use range-based for loops (NFC) (authored by kazu).
[AsmPrinter] Use range-based for loops (NFC)
Feb 10 2021, 8:02 PM
kazu committed rGb16c6b2a83d9: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 10 2021, 8:02 PM
kazu committed rGd12a0f4fc0b5: [GCOV] Drop unnecessary const from return types (NFC) (authored by kazu).
[GCOV] Drop unnecessary const from return types (NFC)
Feb 10 2021, 8:02 PM

Feb 9 2021

kazu committed rG7e75f6fc1d55: [SelectionDAG] Use range-based for loops (NFC) (authored by kazu).
[SelectionDAG] Use range-based for loops (NFC)
Feb 9 2021, 10:15 PM
kazu committed rG781d0fea72a5: [TableGen] Drop unnecessary const from return types (NFC) (authored by kazu).
[TableGen] Drop unnecessary const from return types (NFC)
Feb 9 2021, 10:15 PM
kazu committed rG0f360fffe764: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 9 2021, 10:15 PM

Feb 8 2021

kazu committed rG302313a264c4: [Transforms] Use range-based for loops (NFC) (authored by kazu).
[Transforms] Use range-based for loops (NFC)
Feb 8 2021, 10:34 PM
kazu committed rG94c350847ac5: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 8 2021, 10:34 PM
kazu committed rGde6c49ae3182: [Transforms/Utils] Drop unnecessary const from a return type (NFC) (authored by kazu).
[Transforms/Utils] Drop unnecessary const from a return type (NFC)
Feb 8 2021, 10:34 PM

Feb 7 2021

kazu committed rGbe23012d5a84: [Transforms/Utils] Use range-based for loops (NFC) (authored by kazu).
[Transforms/Utils] Use range-based for loops (NFC)
Feb 7 2021, 9:50 AM
kazu committed rG92a6055835e2: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 7 2021, 9:50 AM
kazu committed rG7b9f6c2d4283: [SelectionDAG] Drop unnecessary const from a return type (NFC) (authored by kazu).
[SelectionDAG] Drop unnecessary const from a return type (NFC)
Feb 7 2021, 9:50 AM

Feb 6 2021

kazu committed rG28d31320894c: [Analysis] Use range-based for loops (NFC) (authored by kazu).
[Analysis] Use range-based for loops (NFC)
Feb 6 2021, 11:17 AM
kazu committed rG3289759b29a5: [TableGen] Use ListSeparator (NFC) (authored by kazu).
[TableGen] Use ListSeparator (NFC)
Feb 6 2021, 11:17 AM
kazu committed rGb3ec6a602db5: [IR] Drop unnecessary const from return types (NFC) (authored by kazu).
[IR] Drop unnecessary const from return types (NFC)
Feb 6 2021, 11:17 AM

Feb 5 2021

kazu committed rGea3175c15b60: [Transforms/Instrumentation] Use range-based for loops (NFC) (authored by kazu).
[Transforms/Instrumentation] Use range-based for loops (NFC)
Feb 5 2021, 9:03 PM
kazu committed rGaa5c09bead26: [llvm] Fix header guards (NFC) (authored by kazu).
[llvm] Fix header guards (NFC)
Feb 5 2021, 9:03 PM
kazu committed rG7725b81822f4: [AMDGPU] Drop unnecessary const from a return type (NFC) (authored by kazu).
[AMDGPU] Drop unnecessary const from a return type (NFC)
Feb 5 2021, 9:03 PM

Feb 4 2021

kazu committed rGfb74e1e78a27: [Transforms/Scalar] Use range-based for loops (NFC) (authored by kazu).
[Transforms/Scalar] Use range-based for loops (NFC)
Feb 4 2021, 9:18 PM
kazu committed rG5438e079b118: [GlobalISel] Use ListSeparator (NFC) (authored by kazu).
[GlobalISel] Use ListSeparator (NFC)
Feb 4 2021, 9:18 PM
kazu committed rGd29562b29c60: [IR] Drop unnecessary const from return types (NFC) (authored by kazu).
[IR] Drop unnecessary const from return types (NFC)
Feb 4 2021, 9:18 PM

Feb 3 2021

kazu committed rGbe37475897c1: [Transforms/IPO] Use range-based for loops (NFC) (authored by kazu).
[Transforms/IPO] Use range-based for loops (NFC)
Feb 3 2021, 8:42 PM