Page MenuHomePhabricator

kazu (Kazu Hirata)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2019, 10:35 AM (46 w, 6 d)

Recent Activity

Thu, Sep 17

kazu added a comment to D86160: [VectorCombine] allow vector loads with mismatched insert type.

I've filed an issue for a performance regression caused by this patch:

Thu, Sep 17, 9:50 AM · Restricted Project

Aug 11 2020

kazu committed rGcfdc96714bdf: [Instcombine] Fix uses of undef (PR46940) (authored by kazu).
[Instcombine] Fix uses of undef (PR46940)
Aug 11 2020, 2:25 PM
kazu closed D85687: [Instcombine] Fix uses of undef (PR46940).
Aug 11 2020, 2:25 PM · Restricted Project
kazu updated the diff for D85687: [Instcombine] Fix uses of undef (PR46940).

I've llvm/util/update_test_checks.py to update CHECK lines.

Aug 11 2020, 2:23 PM · Restricted Project
kazu added a comment to D85687: [Instcombine] Fix uses of undef (PR46940).

Please thank a look. Thanks!

Aug 11 2020, 1:56 PM · Restricted Project
kazu added reviewers for D85687: [Instcombine] Fix uses of undef (PR46940): jdoerfert, fhahn.
Aug 11 2020, 1:56 PM · Restricted Project
kazu updated the diff for D85687: [Instcombine] Fix uses of undef (PR46940).

I've rebased this patch on top of https://reviews.llvm.org/D85684.

Aug 11 2020, 1:54 PM · Restricted Project

Aug 10 2020

kazu added a comment to D85687: [Instcombine] Fix uses of undef (PR46940).

Oops, looks like we were working on this in parallel. I just submitted D85684 for the InstSimplify part of the problem.

Aug 10 2020, 2:01 PM · Restricted Project
kazu requested review of D85687: [Instcombine] Fix uses of undef (PR46940).
Aug 10 2020, 1:46 PM · Restricted Project
kazu added a comment to D81375: [InstCombine] Simplify boolean Phis with const inputs using CFG.

Would you mind if I revert this patch temporarily? This patch makes it easier to trigger bugs like https://bugs.llvm.org/show_bug.cgi?id=46940. Although I don't think this patch itself is the root cause, reverting this patch would allow me to fix the bug above while the compiler is in a more usable state. Thanks!

Aug 10 2020, 11:10 AM · Restricted Project

Aug 9 2020

kazu committed rGa31b3893c72d: [docs] Fix typos (authored by kazu).
[docs] Fix typos
Aug 9 2020, 7:45 PM

Aug 6 2020

kazu added a comment to D84250: [InstSimplify] ExpandBinOp should fold an expression only when it's safe.

Friendly ping.

Aug 6 2020, 3:35 PM · Restricted Project

Aug 1 2020

kazu committed rG60434989e5cd: Use llvm::is_contained where appropriate (NFC) (authored by kazu).
Use llvm::is_contained where appropriate (NFC)
Aug 1 2020, 9:51 PM
kazu closed D85083: Use llvm::is_contained where appropriate (NFC).
Aug 1 2020, 9:51 PM · Restricted Project
kazu accepted D85083: Use llvm::is_contained where appropriate (NFC).

Self LGTM as this one is an obvious NFC.

Aug 1 2020, 9:50 PM · Restricted Project
kazu requested review of D85083: Use llvm::is_contained where appropriate (NFC).
Aug 1 2020, 4:09 PM · Restricted Project

Jul 28 2020

kazu updated the diff for D84473: Dump Accumulator.

Spun off the llvm-readobj bit.

Jul 28 2020, 1:22 PM · Restricted Project, Restricted Project
kazu added a comment to D84473: Dump Accumulator.

Could the llvm-readobj bit be spun off into a separate review, please. As things stand it doesn't have any of its own testing, which should be added at the same time as adding support in the tool itself. The new option is also lacking any documentation in the llvm-readobj and llvm-readelf docs.

Jul 28 2020, 1:21 PM · Restricted Project, Restricted Project

Jul 27 2020

kazu added inline comments to D84473: Dump Accumulator.
Jul 27 2020, 1:30 PM · Restricted Project, Restricted Project
kazu committed rG902cbcd59e22: Use llvm::is_contained where appropriate (NFC) (authored by kazu).
Use llvm::is_contained where appropriate (NFC)
Jul 27 2020, 10:21 AM
kazu closed D84489: Use llvm::is_contained where appropriate (NFC).
Jul 27 2020, 10:21 AM · Restricted Project

Jul 23 2020

Herald added a project to D84489: Use llvm::is_contained where appropriate (NFC): Restricted Project.
Jul 23 2020, 11:38 PM · Restricted Project
Herald added a project to D84473: Dump Accumulator: Restricted Project.
Jul 23 2020, 4:12 PM · Restricted Project, Restricted Project

Jul 1 2020

kazu accepted D83021: [Inliner] Don't skip inlining alwaysinline in optnone functions.

LGTM. Thanks!

Jul 1 2020, 10:11 PM · Restricted Project

Jun 11 2020

kazu added a comment to D81216: [Inlining] Set -enable-npm-pgo-inline-deferral to false..

PTAL Thanks!

Jun 11 2020, 11:32 AM · Restricted Project

Jun 4 2020

kazu added a comment to D80776: [Inlining] Introduce -enable-npm-pgo-inline-deferral.

Experiments show that inline deferral past pre-inlining slightly pessimizes the performance.

What are the performance numbers in terms of % you saw when deferral is disabled, if it's ok to share? Was it from Instr. PGO or Sample FDO? Asking because the new switch seems to cover both.

Jun 4 2020, 11:25 PM · Restricted Project
kazu created D81216: [Inlining] Set -enable-npm-pgo-inline-deferral to false..
Jun 4 2020, 8:23 PM · Restricted Project
kazu committed rG347a599e5f03: [Inlining] Introduce -enable-npm-pgo-inline-deferral (authored by kazu).
[Inlining] Introduce -enable-npm-pgo-inline-deferral
Jun 4 2020, 1:02 AM
kazu closed D80776: [Inlining] Introduce -enable-npm-pgo-inline-deferral.
Jun 4 2020, 1:02 AM · Restricted Project

Jun 2 2020

kazu committed rGf355c7fc2f8f: [JumpThreading] Simplify FindMostPopularDest (NFC) (authored by kazu).
[JumpThreading] Simplify FindMostPopularDest (NFC)
Jun 2 2020, 7:12 PM
kazu closed D81030: [JumpThreading] Simplify FindMostPopularDest (NFC).
Jun 2 2020, 7:12 PM · Restricted Project
kazu added a comment to D81030: [JumpThreading] Simplify FindMostPopularDest (NFC).

Thank you two for reviews!

Jun 2 2020, 5:35 PM · Restricted Project
kazu created D81030: [JumpThreading] Simplify FindMostPopularDest (NFC).
Jun 2 2020, 1:42 PM · Restricted Project

Jun 1 2020

kazu added a comment to D80776: [Inlining] Introduce -enable-npm-pgo-inline-deferral.

PTAL Thanks!

Jun 1 2020, 10:45 AM · Restricted Project
kazu updated the diff for D80776: [Inlining] Introduce -enable-npm-pgo-inline-deferral.

Made the last parameter of shouldInline optional.

Jun 1 2020, 10:45 AM · Restricted Project

May 28 2020

kazu created D80776: [Inlining] Introduce -enable-npm-pgo-inline-deferral.
May 28 2020, 8:51 PM · Restricted Project

May 27 2020

kazu committed rGc4990a03c6c3: [JumpThreading] Use emplace_back instead of push_back (NFC) (authored by kazu).
[JumpThreading] Use emplace_back instead of push_back (NFC)
May 27 2020, 10:53 PM
kazu closed D80688: [JumpThreading] Use emplace_back instead of push_back (NFC).
May 27 2020, 10:53 PM · Restricted Project
kazu created D80688: [JumpThreading] Use emplace_back instead of push_back (NFC).
May 27 2020, 10:52 PM · Restricted Project

May 25 2020

kazu committed rGcec20db58825: [Inlining] Set inline-deferral-scale to 2. (authored by kazu).
[Inlining] Set inline-deferral-scale to 2.
May 25 2020, 4:05 PM
kazu closed D80229: [Inlining] Set inline-deferral-scale to 2..
May 25 2020, 4:05 PM · Restricted Project

May 21 2020

kazu added a comment to D80229: [Inlining] Set inline-deferral-scale to 2..

How does it affect text size overall?

May 21 2020, 11:21 AM · Restricted Project

May 20 2020

kazu added a comment to D80229: [Inlining] Set inline-deferral-scale to 2..

PTAL Thanks!

May 20 2020, 10:01 PM · Restricted Project

May 19 2020

kazu created D80229: [Inlining] Set inline-deferral-scale to 2..
May 19 2020, 12:36 PM · Restricted Project

May 11 2020

kazu committed rG0205fabe5dfb: [Inlining] Make shouldBeDeferred static (NFC) (authored by kazu).
[Inlining] Make shouldBeDeferred static (NFC)
May 11 2020, 5:51 PM
kazu closed D79750: [Inlining] Make shouldBeDeferred static (NFC).
May 11 2020, 5:51 PM · Restricted Project
kazu created D79750: [Inlining] Make shouldBeDeferred static (NFC).
May 11 2020, 3:40 PM · Restricted Project

May 5 2020

kazu committed rGe8984fe65b94: [Inlining] Teach shouldBeDeferred to take the total cost into account (authored by kazu).
[Inlining] Teach shouldBeDeferred to take the total cost into account
May 5 2020, 11:21 AM
kazu closed D79138: [Inlining] Teach shouldBeDeferred to take the total cost into account.
May 5 2020, 11:20 AM · Restricted Project

May 4 2020

kazu updated the diff for D79138: [Inlining] Teach shouldBeDeferred to take the total cost into account.

I've updated the patch to turn off the new cost calculation by default.

May 4 2020, 2:32 PM · Restricted Project

Apr 30 2020

kazu updated the diff for D79138: [Inlining] Teach shouldBeDeferred to take the total cost into account.

I've renamed SecondaryUsers to NumCallerUsers.

Apr 30 2020, 4:39 PM · Restricted Project

Apr 29 2020

kazu created D79138: [Inlining] Teach shouldBeDeferred to take the total cost into account.
Apr 29 2020, 4:12 PM · Restricted Project

Apr 7 2020

kazu committed rG91eb442fdef0: [JumpThreading] NFC: Simplify ComputeValueKnownInPredecessorsImpl (authored by kazu).
[JumpThreading] NFC: Simplify ComputeValueKnownInPredecessorsImpl
Apr 7 2020, 7:05 PM
kazu closed D77699: [JumpThreading] NFC: Simplify ComputeValueKnownInPredecessorsImpl.
Apr 7 2020, 7:05 PM · Restricted Project
kazu created D77699: [JumpThreading] NFC: Simplify ComputeValueKnownInPredecessorsImpl.
Apr 7 2020, 6:00 PM · Restricted Project

Mar 30 2020

kazu accepted D75799: [Intrinsic] Give "is.constant" the "convergent" attribute.

LGTM. Thank you for revising the patch!

Mar 30 2020, 10:16 AM · Restricted Project

Mar 29 2020

kazu added a comment to D75799: [Intrinsic] Give "is.constant" the "convergent" attribute.

It looks like the testcase can be reduced to the following. You can check for no jump threading occurring:

Mar 29 2020, 1:34 AM · Restricted Project

Mar 19 2020

kazu committed rGe23d78652691: [JumpThreading] Fix infinite loop (PR44611) (authored by kazu).
[JumpThreading] Fix infinite loop (PR44611)
Mar 19 2020, 1:12 PM
kazu closed D76390: [JumpThreading] Fix infinite loop (PR44611).
Mar 19 2020, 1:12 PM · Restricted Project
kazu updated the diff for D76390: [JumpThreading] Fix infinite loop (PR44611).

Incorporated feedback from efriedma to use llvm::is_contained instead
of llvm::find.

Mar 19 2020, 1:09 PM · Restricted Project

Mar 18 2020

kazu created D76390: [JumpThreading] Fix infinite loop (PR44611).
Mar 18 2020, 3:13 PM · Restricted Project

Mar 16 2020

kazu added a comment to D75977: [JumpThreading] Fix PR44611 .

Sorry, the infinite recursion seems to come from EvaluateOnPredecessorEdge, a function that I recently added to support jump threading across two basic blocks. EvaluateOnPredecessorEdge does not have a guard against infinite recursion while its close cousin ComputeValueKnownInPredecessors does.

Mar 16 2020, 12:34 PM · Restricted Project

Mar 13 2020

kazu added a comment to D75977: [JumpThreading] Fix PR44611 .

Hi junparser, your main change in JumpThreading.cpp looks good. Now, could you explain your change in removed-use.ll? To be honest, I haven't understood the original intent of the testcase. Thanks!

Mar 13 2020, 3:07 PM · Restricted Project

Mar 6 2020

kazu added a comment to D70247: [JumpThreading] Thread jumps through two basic blocks.

Hi @maxim-kuvyrkov, would you mind filing two separate issues -- the size and performance -- preferably with preprocessed source code? Thanks!

Mar 6 2020, 4:34 PM · Restricted Project

Feb 18 2020

kazu accepted D74747: [JumpThreading] Skip unconditional PredBB when threading jumps through two basic blocks.

LGTM.

Feb 18 2020, 11:02 AM · Restricted Project
kazu accepted D74747: [JumpThreading] Skip unconditional PredBB when threading jumps through two basic blocks.

Thank you for catching this! I meant to handle PredBB ending with a conditional branch only, but I wasn't aware that PredBB could end with an unconditional branch if its address is taken.

Feb 18 2020, 9:02 AM · Restricted Project

Feb 5 2020

kazu committed rG4698bf145d58: Resubmit^2: [JumpThreading] Thread jumps through two basic blocks (authored by kazu).
Resubmit^2: [JumpThreading] Thread jumps through two basic blocks
Feb 5 2020, 9:28 AM
kazu added a reverting change for rG41784bed0154: Revert "Resubmit: [JumpThreading] Thread jumps through two basic blocks": rG4698bf145d58: Resubmit^2: [JumpThreading] Thread jumps through two basic blocks.
Feb 5 2020, 9:28 AM
kazu closed D70247: [JumpThreading] Thread jumps through two basic blocks.
Feb 5 2020, 9:27 AM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

I've fixed the confusing debug message that Wei has pointed out.

Feb 5 2020, 9:27 AM · Restricted Project

Feb 3 2020

kazu added inline comments to D70247: [JumpThreading] Thread jumps through two basic blocks.
Feb 3 2020, 12:36 PM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

I've fixed several bugs. PTAL Thanks!

Feb 3 2020, 11:19 AM · Restricted Project

Jan 28 2020

kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

This patch is work-in-progress, but I am uploading it now so I can
share it with wider audience. I am still working on fixing loose
ends.

Jan 28 2020, 2:15 PM · Restricted Project
kazu reopened D70247: [JumpThreading] Thread jumps through two basic blocks.

I am re-opening this so that I can check in a revised version.

Jan 28 2020, 2:15 PM · Restricted Project

Jan 23 2020

kazu added a reverting change for rG53b68e676faf: Resubmit: [JumpThreading] Thread jumps through two basic blocks: rG41784bed0154: Revert "Resubmit: [JumpThreading] Thread jumps through two basic blocks".
Jan 23 2020, 6:48 AM
kazu committed rG41784bed0154: Revert "Resubmit: [JumpThreading] Thread jumps through two basic blocks" (authored by kazu).
Revert "Resubmit: [JumpThreading] Thread jumps through two basic blocks"
Jan 23 2020, 6:48 AM

Jan 17 2020

kazu added a comment to D72916: [JumpThreading] Reduce duplicate threshold at Oz.

I echo what other have said.

Jan 17 2020, 8:46 AM · Restricted Project

Jan 16 2020

kazu committed rG53b68e676faf: Resubmit: [JumpThreading] Thread jumps through two basic blocks (authored by kazu).
Resubmit: [JumpThreading] Thread jumps through two basic blocks
Jan 16 2020, 12:37 PM
kazu added a reverting change for rG2d258ed931cd: Revert "[JumpThreading] Thread jumps through two basic blocks": rG53b68e676faf: Resubmit: [JumpThreading] Thread jumps through two basic blocks.
Jan 16 2020, 12:37 PM
kazu closed D70247: [JumpThreading] Thread jumps through two basic blocks.
Jan 16 2020, 12:37 PM · Restricted Project
kazu requested review of D70247: [JumpThreading] Thread jumps through two basic blocks.

PTAL Thanks!

Jan 16 2020, 11:29 AM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

I've further simplied thread-two-bbs3.ll, the testcase for Windows,
and made it a little more robust with:

Jan 16 2020, 11:21 AM · Restricted Project

Jan 15 2020

kazu abandoned D72615: [JumpThreading] Thread jumps through two basic blocks.

I'm abandoning this change. We'll discuss the revision in https://reviews.llvm.org/D70247 instead.

Jan 15 2020, 7:28 AM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

PTAL Thanks!

Jan 15 2020, 7:26 AM · Restricted Project
kazu reopened D70247: [JumpThreading] Thread jumps through two basic blocks.

I'm reopening this so that I can upload a revision containing a fix for Windows build.

Jan 15 2020, 7:26 AM · Restricted Project

Jan 13 2020

kazu committed rG6b686703e63f: [Inlining] Add PreInlineThreshold for the new pass manager (authored by kazu).
[Inlining] Add PreInlineThreshold for the new pass manager
Jan 13 2020, 8:03 AM
kazu closed D72618: [Inlining] Add PreInlineThreshold for the new pass manager.
Jan 13 2020, 8:03 AM · Restricted Project
kazu created D72618: [Inlining] Add PreInlineThreshold for the new pass manager.
Jan 13 2020, 6:35 AM · Restricted Project
kazu created D72615: [JumpThreading] Thread jumps through two basic blocks.
Jan 13 2020, 6:26 AM · Restricted Project

Jan 8 2020

kazu added a comment to D70247: [JumpThreading] Thread jumps through two basic blocks.

I've reverted the change for now. I'll take a look at the failure on Windows.

Jan 8 2020, 2:32 PM · Restricted Project
kazu committed rG2d258ed931cd: Revert "[JumpThreading] Thread jumps through two basic blocks" (authored by kazu).
Revert "[JumpThreading] Thread jumps through two basic blocks"
Jan 8 2020, 2:05 PM
kazu added a reverting change for rGead815924e6e: [JumpThreading] Thread jumps through two basic blocks: rG2d258ed931cd: Revert "[JumpThreading] Thread jumps through two basic blocks".
Jan 8 2020, 2:05 PM
kazu committed rGead815924e6e: [JumpThreading] Thread jumps through two basic blocks (authored by kazu).
[JumpThreading] Thread jumps through two basic blocks
Jan 8 2020, 7:03 AM
kazu closed D70247: [JumpThreading] Thread jumps through two basic blocks.
Jan 8 2020, 7:03 AM · Restricted Project

Jan 7 2020

kazu added a comment to D70247: [JumpThreading] Thread jumps through two basic blocks.

Please take a look. Thanks!

Jan 7 2020, 5:07 PM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

Updated the patch, incorporating feedback from Wei.

Jan 7 2020, 3:04 PM · Restricted Project

Dec 30 2019

kazu abandoned D71776: [NFC][InlineCost] Refactor CallAnalyzer::analyze.

https://reviews.llvm.org/D71733 supersedes this patch.

Dec 30 2019, 6:57 AM · Restricted Project

Dec 20 2019

kazu created D71776: [NFC][InlineCost] Refactor CallAnalyzer::analyze.
Dec 20 2019, 9:40 AM · Restricted Project

Dec 17 2019

kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

I've updated the patch so that we commit to jump threading across two
basic blocks once we are done with analysis. That is, we don't
transform the IR partially only to see jump threading proper failing.

Dec 17 2019, 12:37 PM · Restricted Project

Nov 22 2019

kazu committed rGa1955566282b: [JumpThreading] NFC: Don't cache F.hasProfileData() (authored by kazu).
[JumpThreading] NFC: Don't cache F.hasProfileData()
Nov 22 2019, 8:54 AM