User Details
User Details
- User Since
- Oct 28 2019, 10:35 AM (139 w, 2 d)
Tue, Jun 28
Tue, Jun 28
kazu added a comment to rGd08f34b592ff: [llvm] Don't use Optional::hasValue (NFC).
kazu added a comment to D128622: [flang] Don't use Optional::hasValue (NFC).
kazu updated the diff for D128622: [flang] Don't use Optional::hasValue (NFC).
Updated FIROps.cpp and Dialect/FIROps.cpp.
Mon, Jun 27
Mon, Jun 27
kazu added a comment to D128622: [flang] Don't use Optional::hasValue (NFC).
Friendly ping. Thanks!
kazu added a comment to rGaa8feeefd3ac: Don't use Optional::hasValue (NFC).
Mon, Jun 27, 10:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Sun, Jun 26
Sun, Jun 26
kazu requested review of D128622: [flang] Don't use Optional::hasValue (NFC).
Don't use Optional::hasValue (NFC)
Sun, Jun 26, 7:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
[lld] Don't use Optional::hasValue (NFC)
Sun, Jun 26, 7:37 PM · Restricted Project
[lld] Don't use Optional::hasValue (NFC)
Sun, Jun 26, 7:30 PM · Restricted Project
[clang] Don't use Optional::hasValue (NFC)
[llvm] Don't use Optional::hasValue (NFC)
kazu committed rGa81b64a1fbff: [llvm] Use Optional::has_value instead of Optional::hasValue (NFC) (authored by kazu).
[llvm] Use Optional::has_value instead of Optional::hasValue (NFC)
Sat, Jun 25
Sat, Jun 25
[clang] Don't use Optional::hasValue (NFC)
[llvm] Don't use Optional::hasValue (NFC)
[flang] Restore Optional::value() (NFC)
kazu added a comment to D128590: [flang] Restore Optional::value() (NFC).
kazu requested review of D128590: [flang] Restore Optional::value() (NFC).
kazu added a reverting change for rGaa8feeefd3ac: Don't use Optional::hasValue (NFC): rG3b7c3a654c91: Revert "Don't use Optional::hasValue (NFC)".
Sat, Jun 25, 11:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Revert "Don't use Optional::hasValue (NFC)"
Sat, Jun 25, 11:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Don't use Optional::hasValue (NFC)
Sat, Jun 25, 11:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rGb8df4093e4d8: [clang, clang-tools-extra] Don't use Optional::{hasValue,getValue} (NFC) (authored by kazu).
[clang, clang-tools-extra] Don't use Optional::{hasValue,getValue} (NFC)
kazu committed rGd152e50c1541: [llvm] Don't use Optional::{hasValue,getValue} (NFC) (authored by kazu).
[llvm] Don't use Optional::{hasValue,getValue} (NFC)
kazu added a comment to rGd57163957926: [mlir][Linalg] SplitReduction implementation without tensor::ExpandShapeOp.
I've fixed the warning:
[mlir] Fix a warning
Fri, Jun 24
Fri, Jun 24
kazu added a comment to rGd57163957926: [mlir][Linalg] SplitReduction implementation without tensor::ExpandShapeOp.
kazu accepted D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..
LGTM with a minor comment fix. Thanks!
Thu, Jun 23
Thu, Jun 23
kazu added a comment to rGed8fceaa09cd: Don't use Optional::getValue (NFC).
Wed, Jun 22
Wed, Jun 22
kazu accepted D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..
LGTM with a minor change to the constructor of InlineAdvisor. Thank you for your patience.
kazu added a comment to rGd57163957926: [mlir][Linalg] SplitReduction implementation without tensor::ExpandShapeOp.
causes a warning:
Mon, Jun 20
Mon, Jun 20
Don't use Optional::getValue (NFC)
[mlir] Don't use Optional::getValue (NFC)
[clang] Don't use Optional::getValue (NFC)
[llvm] Don't use Optional::getValue (NFC)
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 8:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 8:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 8:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu added a comment to rG8c6e138aa893: Support logpoints in lldb-vscode.
This patch seems to break builds on my x86-64 linux machine. I'm using clang as the host compiler. Would you please take a look? Thanks!
Mon, Jun 20, 5:02 PM · Restricted Project
kazu added a comment to rG4cd416193cc1: [TableGen] Emit instruction name in INSTRINFO_OPERAND_TYPE.
This patch seems to make TableGen/get-operand-type.td fail on my x86-64 Linux machine. Would you please look into this? Thanks!
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 11:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 11:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
[mlir] Don't use Optional::hasValue (NFC)
[clang] Don't use Optional::hasValue (NFC)
[llvm] Don't use Optional::hasValue (NFC)
Sun, Jun 19
Sun, Jun 19
[Basic] Use has_value (NFC)
[ADT] Use value instead of getValue() (NFC)
[ADT] Use has_value (NFC)
[ADT] Rename value to alt (NFC)
Use value_or instead of getValueOr (NFC)
Sun, Jun 19, 10:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
[lldb] Use value_or instead of getValueOr (NFC)
Sun, Jun 19, 9:12 AM · Restricted Project
[lld] Use value_or instead of getValueOr (NFC)
Sun, Jun 19, 12:30 AM · Restricted Project
[AST] Fix an unused variable warning
kazu committed rG5dd171dcb55b: [clang-tools-extra] Use value_or instead of getValueOr (NFC) (authored by kazu).
[clang-tools-extra] Use value_or instead of getValueOr (NFC)
Sat, Jun 18
Sat, Jun 18
[clang] Use value_or instead of getValueOr (NFC)
[llvm] Use value_or instead of getValueOr (NFC)
kazu committed rG3c49576417ba: [ADT] Add has_value, value, value_or to llvm::Optional (authored by kazu).
[ADT] Add has_value, value, value_or to llvm::Optional
kazu committed rGa5258e5b2728: Revert "[MCParser] Use default member initialization (NFC)" (authored by kazu).
Revert "[MCParser] Use default member initialization (NFC)"
kazu committed rG68090a014cf5: [MCParser] Use default member initialization (NFC) (authored by kazu).
[MCParser] Use default member initialization (NFC)
kazu added a reviewer for D128131: [ADT] Add has_value, value, value_or to llvm::Optional: dblaikie.
kazu requested review of D128131: [ADT] Add has_value, value, value_or to llvm::Optional.
[ADT] Rename value to val (NFC)
[Toolchains] Use llvm::is_contained (NFC)
[Vectorize] Use llvm::is_contained (NFC)
kazu committed rG06dc4028d943: [Support] Use default member initialization (NFC) (authored by kazu).
[Support] Use default member initialization (NFC)
[IPO] Use default member initialization (NFC)
kazu requested review of D128125: [ADT] Rename value to val (NFC).
[IPO] Use default member initialization (NFC)
[X86] Use default member initialization (NFC)
[X86] Use default member initialization (NFC)
[X86] Use default member initialization (NFC)
kazu committed rG3cbe0bc4a1fa: [CodeGen] Use default member initialization (NFC) (authored by kazu).
[CodeGen] Use default member initialization (NFC)
kazu committed rG80c12bdb3bbd: [clang] Call *set::insert without checking membership first (NFC) (authored by kazu).
[clang] Call *set::insert without checking membership first (NFC)
kazu committed rGf8b5be64ab46: [IPO] Call *set::insert without checking membership first (NFC) (authored by kazu).
[IPO] Call *set::insert without checking membership first (NFC)
kazu committed rG437f960062e3: [llvm] Call *set::insert without checking membership first (NFC) (authored by kazu).
[llvm] Call *set::insert without checking membership first (NFC)
kazu committed rG4271a1ff3380: [llvm] Call *set::insert without checking membership first (NFC) (authored by kazu).
[llvm] Call *set::insert without checking membership first (NFC)
kazu committed rGb254d671604c: [llvm] Call *set::insert without checking membership first (NFC) (authored by kazu).
[llvm] Call *set::insert without checking membership first (NFC)
kazu committed rG4533e6aab8bf: [AsmParser] Use default member initialization (NFC) (authored by kazu).
[AsmParser] Use default member initialization (NFC)
kazu committed rG621f58e71619: [Target, CodeGen] Use isImm(), isReg(), etc (NFC) (authored by kazu).
[Target, CodeGen] Use isImm(), isReg(), etc (NFC)
Fri, Jun 17
Fri, Jun 17
kazu added a comment to D127921: [FunctionPropertiesAnalysis] Generalize support for unreachable.
LGTM modulo cosmetic changes. Your new algorithm looks pretty robust to me. Thanks!
Thu, Jun 16
Thu, Jun 16
LGTM modulo minor cosmetic changes. Thanks!
Tue, Jun 14
Tue, Jun 14
kazu requested review of D127799: [StaticAnalyzer] Remove dead code (DO NOT COMMIT).
LGTM with some cosmetic suggestions. Thanks!
Mon, Jun 13
Mon, Jun 13
kazu committed rGa2232da2a5d2: [CodeGen] Remove addSEHCatchHandler and addSEHCleanupHandler (NFC) (authored by kazu).
[CodeGen] Remove addSEHCatchHandler and addSEHCleanupHandler (NFC)
[CodeGen] Remove restrictRef (NFC)
[CodeGen] Remove futureWeight (NFC)
[Analysis] Remove getUniqueInstruction (NFC)
[CodeGen] Remove EvictionTrack (NFC)
[GlobalISel] Remove buildSequence (NFC)
Sun, Jun 12
Sun, Jun 12
kazu committed rG1ad01f4f7cde: [AArch64] Use default member initialization (NFC) (authored by kazu).
[AArch64] Use default member initialization (NFC)
kazu committed rG6c39687567fa: [Support] Use default member initialization (NFC) (authored by kazu).
[Support] Use default member initialization (NFC)
kazu committed rGdf792bcb0226: [Transforms] Use default member initialization (NFC) (authored by kazu).
[Transforms] Use default member initialization (NFC)
[X86] Use default member initialization (NFC)
[IR] Call DenseMap::erase directly (NFC)