Page MenuHomePhabricator

kazu (Kazu Hirata)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2019, 10:35 AM (139 w, 2 d)

Recent Activity

Tue, Jun 28

kazu added a comment to rGd08f34b592ff: [llvm] Don't use Optional::hasValue (NFC).

Where is the discussion and rational for this?

Tue, Jun 28, 4:00 PM · Restricted Project, Restricted Project
kazu added a comment to D128622: [flang] Don't use Optional::hasValue (NFC).

Hi @kazu, thanks for making a review and making the code style consistent. It seems part of the change is breaking builds (see bots).

Tue, Jun 28, 8:30 AM · Restricted Project, Restricted Project
kazu updated the diff for D128622: [flang] Don't use Optional::hasValue (NFC).

Updated FIROps.cpp and Dialect/FIROps.cpp.

Tue, Jun 28, 8:29 AM · Restricted Project, Restricted Project

Mon, Jun 27

kazu added a comment to D128622: [flang] Don't use Optional::hasValue (NFC).

Friendly ping. Thanks!

Mon, Jun 27, 10:45 PM · Restricted Project, Restricted Project
kazu added a comment to rGaa8feeefd3ac: Don't use Optional::hasValue (NFC).

@kazu Please make a review for these changes. They do not follow any guidelines and I think each subproject can use optional as they want (I'm speaking about flang here).

Mon, Jun 27, 10:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sun, Jun 26

kazu added a reviewer for D128622: [flang] Don't use Optional::hasValue (NFC): clementval.
Sun, Jun 26, 8:36 PM · Restricted Project, Restricted Project
kazu requested review of D128622: [flang] Don't use Optional::hasValue (NFC).
Sun, Jun 26, 8:33 PM · Restricted Project, Restricted Project
kazu committed rG94460f513654: Don't use Optional::hasValue (NFC) (authored by kazu).
Don't use Optional::hasValue (NFC)
Sun, Jun 26, 7:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rG586fb81eee1f: [lld] Don't use Optional::hasValue (NFC) (authored by kazu).
[lld] Don't use Optional::hasValue (NFC)
Sun, Jun 26, 7:37 PM · Restricted Project
kazu committed rG96d1b4ddb2cc: [lld] Don't use Optional::hasValue (NFC) (authored by kazu).
[lld] Don't use Optional::hasValue (NFC)
Sun, Jun 26, 7:30 PM · Restricted Project
kazu committed rGca05cc206478: [clang] Don't use Optional::hasValue (NFC) (authored by kazu).
[clang] Don't use Optional::hasValue (NFC)
Sun, Jun 26, 6:52 PM · Restricted Project, Restricted Project
kazu committed rGd08f34b592ff: [llvm] Don't use Optional::hasValue (NFC) (authored by kazu).
[llvm] Don't use Optional::hasValue (NFC)
Sun, Jun 26, 6:32 PM · Restricted Project, Restricted Project
kazu committed rGa81b64a1fbff: [llvm] Use Optional::has_value instead of Optional::hasValue (NFC) (authored by kazu).
[llvm] Use Optional::has_value instead of Optional::hasValue (NFC)
Sun, Jun 26, 4:11 PM · Restricted Project, Restricted Project

Sat, Jun 25

kazu committed rG97afce08cbbb: [clang] Don't use Optional::hasValue (NFC) (authored by kazu).
[clang] Don't use Optional::hasValue (NFC)
Sat, Jun 25, 10:26 PM · Restricted Project, Restricted Project
kazu committed rGa7938c74f163: [llvm] Don't use Optional::hasValue (NFC) (authored by kazu).
[llvm] Don't use Optional::hasValue (NFC)
Sat, Jun 25, 9:43 PM · Restricted Project, Restricted Project
kazu committed rGdc97886fa36d: [flang] Restore Optional::value() (NFC) (authored by kazu).
[flang] Restore Optional::value() (NFC)
Sat, Jun 25, 1:22 PM · Restricted Project, Restricted Project
kazu closed D128590: [flang] Restore Optional::value() (NFC).
Sat, Jun 25, 1:21 PM · Restricted Project, Restricted Project
kazu added a comment to D128590: [flang] Restore Optional::value() (NFC).

I'm a bit lost with your changes here. Earlier you removed the use of the value() or equivalent function and now you are introducing it back? Can we have a clear plan of action on this? Or is it just to stick with our guidelines? Is so there are more to change.

Sat, Jun 25, 1:12 PM · Restricted Project, Restricted Project
kazu added a reviewer for D128590: [flang] Restore Optional::value() (NFC): clementval.
Sat, Jun 25, 12:19 PM · Restricted Project, Restricted Project
kazu requested review of D128590: [flang] Restore Optional::value() (NFC).
Sat, Jun 25, 12:18 PM · Restricted Project, Restricted Project
kazu added a reverting change for rGaa8feeefd3ac: Don't use Optional::hasValue (NFC): rG3b7c3a654c91: Revert "Don't use Optional::hasValue (NFC)".
Sat, Jun 25, 11:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rG3b7c3a654c91: Revert "Don't use Optional::hasValue (NFC)" (authored by kazu).
Revert "Don't use Optional::hasValue (NFC)"
Sat, Jun 25, 11:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rGaa8feeefd3ac: Don't use Optional::hasValue (NFC) (authored by kazu).
Don't use Optional::hasValue (NFC)
Sat, Jun 25, 11:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rGb8df4093e4d8: [clang, clang-tools-extra] Don't use Optional::{hasValue,getValue} (NFC) (authored by kazu).
[clang, clang-tools-extra] Don't use Optional::{hasValue,getValue} (NFC)
Sat, Jun 25, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
kazu committed rGd152e50c1541: [llvm] Don't use Optional::{hasValue,getValue} (NFC) (authored by kazu).
[llvm] Don't use Optional::{hasValue,getValue} (NFC)
Sat, Jun 25, 11:24 AM · Restricted Project, Restricted Project
kazu added a comment to rGd57163957926: [mlir][Linalg] SplitReduction implementation without tensor::ExpandShapeOp.

I've fixed the warning:

Sat, Jun 25, 9:20 AM · Restricted Project, Restricted Project
kazu committed rGf8c1c9afd3e2: [mlir] Fix a warning (authored by kazu).
[mlir] Fix a warning
Sat, Jun 25, 9:18 AM · Restricted Project, Restricted Project

Fri, Jun 24

kazu added a comment to rGd57163957926: [mlir][Linalg] SplitReduction implementation without tensor::ExpandShapeOp.
if (op.getNumOutputs() != neutralElements.size())

causes a warning:

mlir/lib/Dialect/Linalg/Transforms/SplitReduction.cpp:300:26: error: comparison of integers of different signs: 'int64_t' (aka 'long') and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]

It's easy to to put a cast to silence the warning, but I am wondering if getNumOutputs should return an unsigned number instead.

Fri, Jun 24, 11:42 AM · Restricted Project, Restricted Project
kazu accepted D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

LGTM with a minor comment fix. Thanks!

Fri, Jun 24, 12:59 AM · Restricted Project, Restricted Project

Thu, Jun 23

kazu added a comment to rGed8fceaa09cd: Don't use Optional::getValue (NFC).

What is the rationale for all those changes without any review?

@kazu Ping!

Thu, Jun 23, 7:00 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

kazu accepted D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..

LGTM with a minor change to the constructor of InlineAdvisor. Thank you for your patience.

Wed, Jun 22, 2:38 PM · Restricted Project, Restricted Project
kazu added a comment to rGd57163957926: [mlir][Linalg] SplitReduction implementation without tensor::ExpandShapeOp.

causes a warning:

Wed, Jun 22, 2:19 PM · Restricted Project, Restricted Project

Mon, Jun 20

kazu committed rGed8fceaa09cd: Don't use Optional::getValue (NFC) (authored by kazu).
Don't use Optional::getValue (NFC)
Mon, Jun 20, 11:36 PM · Restricted Project, Restricted Project, Restricted Project
kazu committed rG6d5fc1e3d5ac: [mlir] Don't use Optional::getValue (NFC) (authored by kazu).
[mlir] Don't use Optional::getValue (NFC)
Mon, Jun 20, 11:20 PM · Restricted Project, Restricted Project
kazu committed rGca4af13e480e: [clang] Don't use Optional::getValue (NFC) (authored by kazu).
[clang] Don't use Optional::getValue (NFC)
Mon, Jun 20, 10:59 PM · Restricted Project, Restricted Project
kazu committed rG7a47ee51a145: [llvm] Don't use Optional::getValue (NFC) (authored by kazu).
[llvm] Don't use Optional::getValue (NFC)
Mon, Jun 20, 10:46 PM · Restricted Project, Restricted Project
kazu committed rGd66cbc565adb: Don't use Optional::hasValue (NFC) (authored by kazu).
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 8:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rG0916d96d12fd: Don't use Optional::hasValue (NFC) (authored by kazu).
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 8:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rG064a08cd9550: Don't use Optional::hasValue (NFC) (authored by kazu).
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 8:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu added a comment to rG8c6e138aa893: Support logpoints in lldb-vscode.

This patch seems to break builds on my x86-64 linux machine. I'm using clang as the host compiler. Would you please take a look? Thanks!

Mon, Jun 20, 5:02 PM · Restricted Project
kazu added a comment to rG4cd416193cc1: [TableGen] Emit instruction name in INSTRINFO_OPERAND_TYPE.

This patch seems to make TableGen/get-operand-type.td fail on my x86-64 Linux machine. Would you please look into this? Thanks!

Mon, Jun 20, 12:39 PM · Restricted Project, Restricted Project
kazu committed rGad7ce1e76961: Don't use Optional::hasValue (NFC) (authored by kazu).
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 11:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rG5413bf1bac2a: Don't use Optional::hasValue (NFC) (authored by kazu).
Don't use Optional::hasValue (NFC)
Mon, Jun 20, 11:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rG037f09959ac9: [mlir] Don't use Optional::hasValue (NFC) (authored by kazu).
[mlir] Don't use Optional::hasValue (NFC)
Mon, Jun 20, 11:23 AM · Restricted Project, Restricted Project
kazu committed rG452db157c963: [clang] Don't use Optional::hasValue (NFC) (authored by kazu).
[clang] Don't use Optional::hasValue (NFC)
Mon, Jun 20, 10:51 AM · Restricted Project, Restricted Project
kazu committed rGe0e687a615c1: [llvm] Don't use Optional::hasValue (NFC) (authored by kazu).
[llvm] Don't use Optional::hasValue (NFC)
Mon, Jun 20, 10:38 AM · Restricted Project, Restricted Project

Sun, Jun 19

kazu committed rG05ff3790b316: [Basic] Use has_value (NFC) (authored by kazu).
[Basic] Use has_value (NFC)
Sun, Jun 19, 7:00 PM · Restricted Project, Restricted Project
kazu committed rGc7987d494836: [ADT] Use value instead of getValue() (NFC) (authored by kazu).
[ADT] Use value instead of getValue() (NFC)
Sun, Jun 19, 6:35 PM · Restricted Project, Restricted Project, Restricted Project
kazu committed rG813f48722883: [ADT] Use has_value (NFC) (authored by kazu).
[ADT] Use has_value (NFC)
Sun, Jun 19, 6:10 PM · Restricted Project, Restricted Project, Restricted Project
kazu committed rG5d7e63fb4f26: [ADT] Rename value to alt (NFC) (authored by kazu).
[ADT] Rename value to alt (NFC)
Sun, Jun 19, 12:00 PM · Restricted Project, Restricted Project
kazu committed rG30c675878c21: Use value_or instead of getValueOr (NFC) (authored by kazu).
Use value_or instead of getValueOr (NFC)
Sun, Jun 19, 10:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rGaa88161b378e: [lldb] Use value_or instead of getValueOr (NFC) (authored by kazu).
[lldb] Use value_or instead of getValueOr (NFC)
Sun, Jun 19, 9:12 AM · Restricted Project
kazu committed rG757d9d22cd91: [lld] Use value_or instead of getValueOr (NFC) (authored by kazu).
[lld] Use value_or instead of getValueOr (NFC)
Sun, Jun 19, 12:30 AM · Restricted Project
kazu committed rG97c87c6f7cff: [AST] Fix an unused variable warning (authored by kazu).
[AST] Fix an unused variable warning
Sun, Jun 19, 12:21 AM · Restricted Project, Restricted Project
kazu committed rG5dd171dcb55b: [clang-tools-extra] Use value_or instead of getValueOr (NFC) (authored by kazu).
[clang-tools-extra] Use value_or instead of getValueOr (NFC)
Sun, Jun 19, 12:14 AM · Restricted Project, Restricted Project

Sat, Jun 18

kazu committed rG06decd0b4115: [clang] Use value_or instead of getValueOr (NFC) (authored by kazu).
[clang] Use value_or instead of getValueOr (NFC)
Sat, Jun 18, 11:22 PM · Restricted Project, Restricted Project
kazu committed rG129b531c9c67: [llvm] Use value_or instead of getValueOr (NFC) (authored by kazu).
[llvm] Use value_or instead of getValueOr (NFC)
Sat, Jun 18, 11:07 PM · Restricted Project, Restricted Project
kazu committed rG3c49576417ba: [ADT] Add has_value, value, value_or to llvm::Optional (authored by kazu).
[ADT] Add has_value, value, value_or to llvm::Optional
Sat, Jun 18, 9:22 PM · Restricted Project, Restricted Project
kazu closed D128131: [ADT] Add has_value, value, value_or to llvm::Optional.
Sat, Jun 18, 9:21 PM · Restricted Project, Restricted Project
kazu added a reverting change for rG68090a014cf5: [MCParser] Use default member initialization (NFC): rGa5258e5b2728: Revert "[MCParser] Use default member initialization (NFC)".
Sat, Jun 18, 9:02 PM · Restricted Project, Restricted Project
kazu committed rGa5258e5b2728: Revert "[MCParser] Use default member initialization (NFC)" (authored by kazu).
Revert "[MCParser] Use default member initialization (NFC)"
Sat, Jun 18, 9:02 PM · Restricted Project, Restricted Project
kazu committed rG68090a014cf5: [MCParser] Use default member initialization (NFC) (authored by kazu).
[MCParser] Use default member initialization (NFC)
Sat, Jun 18, 8:55 PM · Restricted Project, Restricted Project
kazu added a reviewer for D128131: [ADT] Add has_value, value, value_or to llvm::Optional: dblaikie.
Sat, Jun 18, 8:36 PM · Restricted Project, Restricted Project
kazu requested review of D128131: [ADT] Add has_value, value, value_or to llvm::Optional.
Sat, Jun 18, 8:35 PM · Restricted Project, Restricted Project
kazu committed rG556bcc782101: [ADT] Rename value to val (NFC) (authored by kazu).
[ADT] Rename value to val (NFC)
Sat, Jun 18, 8:19 PM · Restricted Project, Restricted Project
kazu closed D128125: [ADT] Rename value to val (NFC).
Sat, Jun 18, 8:19 PM · Restricted Project, Restricted Project
kazu committed rGc5935af0583b: [Toolchains] Use llvm::is_contained (NFC) (authored by kazu).
[Toolchains] Use llvm::is_contained (NFC)
Sat, Jun 18, 3:58 PM · Restricted Project, Restricted Project
kazu committed rGc399b3a6080c: [Vectorize] Use llvm::is_contained (NFC) (authored by kazu).
[Vectorize] Use llvm::is_contained (NFC)
Sat, Jun 18, 3:49 PM · Restricted Project, Restricted Project
kazu committed rG06dc4028d943: [Support] Use default member initialization (NFC) (authored by kazu).
[Support] Use default member initialization (NFC)
Sat, Jun 18, 3:46 PM · Restricted Project, Restricted Project
kazu committed rG726b2dd04001: [IPO] Use default member initialization (NFC) (authored by kazu).
[IPO] Use default member initialization (NFC)
Sat, Jun 18, 3:41 PM · Restricted Project, Restricted Project
kazu added a reviewer for D128125: [ADT] Rename value to val (NFC): dblaikie.
Sat, Jun 18, 2:26 PM · Restricted Project, Restricted Project
kazu requested review of D128125: [ADT] Rename value to val (NFC).
Sat, Jun 18, 2:25 PM · Restricted Project, Restricted Project
kazu committed rGeb15c80c89a5: [IPO] Use default member initialization (NFC) (authored by kazu).
[IPO] Use default member initialization (NFC)
Sat, Jun 18, 12:17 PM · Restricted Project, Restricted Project
kazu committed rG47b39c51572f: [X86] Use default member initialization (NFC) (authored by kazu).
[X86] Use default member initialization (NFC)
Sat, Jun 18, 12:12 PM · Restricted Project, Restricted Project
kazu committed rG1590d39f2e09: [X86] Use default member initialization (NFC) (authored by kazu).
[X86] Use default member initialization (NFC)
Sat, Jun 18, 12:08 PM · Restricted Project, Restricted Project
kazu committed rG7c987bb4d9f0: [X86] Use default member initialization (NFC) (authored by kazu).
[X86] Use default member initialization (NFC)
Sat, Jun 18, 12:06 PM · Restricted Project, Restricted Project
kazu committed rG3cbe0bc4a1fa: [CodeGen] Use default member initialization (NFC) (authored by kazu).
[CodeGen] Use default member initialization (NFC)
Sat, Jun 18, 12:01 PM · Restricted Project, Restricted Project
kazu committed rG80c12bdb3bbd: [clang] Call *set::insert without checking membership first (NFC) (authored by kazu).
[clang] Call *set::insert without checking membership first (NFC)
Sat, Jun 18, 10:41 AM · Restricted Project, Restricted Project
kazu committed rGf8b5be64ab46: [IPO] Call *set::insert without checking membership first (NFC) (authored by kazu).
[IPO] Call *set::insert without checking membership first (NFC)
Sat, Jun 18, 10:37 AM · Restricted Project, Restricted Project
kazu committed rG437f960062e3: [llvm] Call *set::insert without checking membership first (NFC) (authored by kazu).
[llvm] Call *set::insert without checking membership first (NFC)
Sat, Jun 18, 10:22 AM · Restricted Project, Restricted Project
kazu committed rG4271a1ff3380: [llvm] Call *set::insert without checking membership first (NFC) (authored by kazu).
[llvm] Call *set::insert without checking membership first (NFC)
Sat, Jun 18, 10:17 AM · Restricted Project, Restricted Project
kazu committed rGb254d671604c: [llvm] Call *set::insert without checking membership first (NFC) (authored by kazu).
[llvm] Call *set::insert without checking membership first (NFC)
Sat, Jun 18, 8:33 AM · Restricted Project, Restricted Project
kazu committed rG4533e6aab8bf: [AsmParser] Use default member initialization (NFC) (authored by kazu).
[AsmParser] Use default member initialization (NFC)
Sat, Jun 18, 7:46 AM · Restricted Project, Restricted Project
kazu committed rG621f58e71619: [Target, CodeGen] Use isImm(), isReg(), etc (NFC) (authored by kazu).
[Target, CodeGen] Use isImm(), isReg(), etc (NFC)
Sat, Jun 18, 7:41 AM · Restricted Project, Restricted Project

Fri, Jun 17

kazu accepted D127921: [FunctionPropertiesAnalysis] Generalize support for unreachable.
Fri, Jun 17, 1:09 PM · Restricted Project, Restricted Project
kazu added a comment to D127921: [FunctionPropertiesAnalysis] Generalize support for unreachable.

LGTM modulo cosmetic changes. Your new algorithm looks pretty robust to me. Thanks!

Fri, Jun 17, 1:09 PM · Restricted Project, Restricted Project

Thu, Jun 16

kazu accepted D127899: [MLInliner] Don't inline call sites in unreachable basic blocks.

LGTM modulo minor cosmetic changes. Thanks!

Thu, Jun 16, 8:59 AM · Restricted Project, Restricted Project

Tue, Jun 14

kazu requested review of D127799: [StaticAnalyzer] Remove dead code (DO NOT COMMIT).
Tue, Jun 14, 2:27 PM · Restricted Project, Restricted Project
kazu accepted D127353: FunctionPropertiesAnalysis: handle callsite BBs that loose edges.

LGTM with some cosmetic suggestions. Thanks!

Tue, Jun 14, 2:07 PM · Restricted Project, Restricted Project

Mon, Jun 13

kazu committed rGa2232da2a5d2: [CodeGen] Remove addSEHCatchHandler and addSEHCleanupHandler (NFC) (authored by kazu).
[CodeGen] Remove addSEHCatchHandler and addSEHCleanupHandler (NFC)
Mon, Jun 13, 11:09 PM · Restricted Project, Restricted Project
kazu committed rG34ff78c5cfc7: [CodeGen] Remove restrictRef (NFC) (authored by kazu).
[CodeGen] Remove restrictRef (NFC)
Mon, Jun 13, 11:09 PM · Restricted Project, Restricted Project
kazu committed rG145cc9db2b44: [CodeGen] Remove futureWeight (NFC) (authored by kazu).
[CodeGen] Remove futureWeight (NFC)
Mon, Jun 13, 5:10 PM · Restricted Project, Restricted Project
kazu committed rG5c41b0f42965: [Analysis] Remove getUniqueInstruction (NFC) (authored by kazu).
[Analysis] Remove getUniqueInstruction (NFC)
Mon, Jun 13, 2:26 PM · Restricted Project, Restricted Project
kazu committed rG23d9ca10ae8a: [CodeGen] Remove EvictionTrack (NFC) (authored by kazu).
[CodeGen] Remove EvictionTrack (NFC)
Mon, Jun 13, 7:21 AM · Restricted Project, Restricted Project
kazu committed rG246e83e9737b: [GlobalISel] Remove buildSequence (NFC) (authored by kazu).
[GlobalISel] Remove buildSequence (NFC)
Mon, Jun 13, 6:59 AM · Restricted Project, Restricted Project

Sun, Jun 12

kazu committed rG1ad01f4f7cde: [AArch64] Use default member initialization (NFC) (authored by kazu).
[AArch64] Use default member initialization (NFC)
Sun, Jun 12, 6:52 PM · Restricted Project, Restricted Project
kazu committed rG6c39687567fa: [Support] Use default member initialization (NFC) (authored by kazu).
[Support] Use default member initialization (NFC)
Sun, Jun 12, 6:46 PM · Restricted Project, Restricted Project
kazu committed rGdf792bcb0226: [Transforms] Use default member initialization (NFC) (authored by kazu).
[Transforms] Use default member initialization (NFC)
Sun, Jun 12, 6:39 PM · Restricted Project, Restricted Project
kazu committed rG92ab024f81e5: [X86] Use default member initialization (NFC) (authored by kazu).
[X86] Use default member initialization (NFC)
Sun, Jun 12, 6:31 PM · Restricted Project, Restricted Project
kazu committed rG974dbb20bd67: [IR] Call DenseMap::erase directly (NFC) (authored by kazu).
[IR] Call DenseMap::erase directly (NFC)
Sun, Jun 12, 10:47 AM · Restricted Project, Restricted Project