Page MenuHomePhabricator

kazu (Kazu Hirata)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2019, 10:35 AM (23 w, 2 d)

Recent Activity

Tue, Apr 7

kazu committed rG91eb442fdef0: [JumpThreading] NFC: Simplify ComputeValueKnownInPredecessorsImpl (authored by kazu).
[JumpThreading] NFC: Simplify ComputeValueKnownInPredecessorsImpl
Tue, Apr 7, 7:05 PM
kazu closed D77699: [JumpThreading] NFC: Simplify ComputeValueKnownInPredecessorsImpl.
Tue, Apr 7, 7:05 PM · Restricted Project
kazu created D77699: [JumpThreading] NFC: Simplify ComputeValueKnownInPredecessorsImpl.
Tue, Apr 7, 6:00 PM · Restricted Project

Mon, Mar 30

kazu accepted D75799: [Intrinsic] Give "is.constant" the "convergent" attribute.

LGTM. Thank you for revising the patch!

Mon, Mar 30, 10:16 AM · Restricted Project

Sun, Mar 29

kazu added a comment to D75799: [Intrinsic] Give "is.constant" the "convergent" attribute.

It looks like the testcase can be reduced to the following. You can check for no jump threading occurring:

Sun, Mar 29, 1:34 AM · Restricted Project

Thu, Mar 19

kazu committed rGe23d78652691: [JumpThreading] Fix infinite loop (PR44611) (authored by kazu).
[JumpThreading] Fix infinite loop (PR44611)
Thu, Mar 19, 1:12 PM
kazu closed D76390: [JumpThreading] Fix infinite loop (PR44611).
Thu, Mar 19, 1:12 PM · Restricted Project
kazu updated the diff for D76390: [JumpThreading] Fix infinite loop (PR44611).

Incorporated feedback from efriedma to use llvm::is_contained instead
of llvm::find.

Thu, Mar 19, 1:09 PM · Restricted Project

Wed, Mar 18

kazu created D76390: [JumpThreading] Fix infinite loop (PR44611).
Wed, Mar 18, 3:13 PM · Restricted Project

Mon, Mar 16

kazu added a comment to D75977: [JumpThreading] Fix PR44611 .

Sorry, the infinite recursion seems to come from EvaluateOnPredecessorEdge, a function that I recently added to support jump threading across two basic blocks. EvaluateOnPredecessorEdge does not have a guard against infinite recursion while its close cousin ComputeValueKnownInPredecessors does.

Mon, Mar 16, 12:34 PM · Restricted Project

Fri, Mar 13

kazu added a comment to D75977: [JumpThreading] Fix PR44611 .

Hi junparser, your main change in JumpThreading.cpp looks good. Now, could you explain your change in removed-use.ll? To be honest, I haven't understood the original intent of the testcase. Thanks!

Fri, Mar 13, 3:07 PM · Restricted Project

Mar 6 2020

kazu added a comment to D70247: [JumpThreading] Thread jumps through two basic blocks.

Hi @maxim-kuvyrkov, would you mind filing two separate issues -- the size and performance -- preferably with preprocessed source code? Thanks!

Mar 6 2020, 4:34 PM · Restricted Project

Feb 18 2020

kazu accepted D74747: [JumpThreading] Skip unconditional PredBB when threading jumps through two basic blocks.

LGTM.

Feb 18 2020, 11:02 AM · Restricted Project
kazu accepted D74747: [JumpThreading] Skip unconditional PredBB when threading jumps through two basic blocks.

Thank you for catching this! I meant to handle PredBB ending with a conditional branch only, but I wasn't aware that PredBB could end with an unconditional branch if its address is taken.

Feb 18 2020, 9:02 AM · Restricted Project

Feb 5 2020

kazu committed rG4698bf145d58: Resubmit^2: [JumpThreading] Thread jumps through two basic blocks (authored by kazu).
Resubmit^2: [JumpThreading] Thread jumps through two basic blocks
Feb 5 2020, 9:28 AM
kazu added a reverting change for rG41784bed0154: Revert "Resubmit: [JumpThreading] Thread jumps through two basic blocks": rG4698bf145d58: Resubmit^2: [JumpThreading] Thread jumps through two basic blocks.
Feb 5 2020, 9:28 AM
kazu closed D70247: [JumpThreading] Thread jumps through two basic blocks.
Feb 5 2020, 9:27 AM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

I've fixed the confusing debug message that Wei has pointed out.

Feb 5 2020, 9:27 AM · Restricted Project

Feb 3 2020

kazu added inline comments to D70247: [JumpThreading] Thread jumps through two basic blocks.
Feb 3 2020, 12:36 PM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

I've fixed several bugs. PTAL Thanks!

Feb 3 2020, 11:19 AM · Restricted Project

Jan 28 2020

kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

This patch is work-in-progress, but I am uploading it now so I can
share it with wider audience. I am still working on fixing loose
ends.

Jan 28 2020, 2:15 PM · Restricted Project
kazu reopened D70247: [JumpThreading] Thread jumps through two basic blocks.

I am re-opening this so that I can check in a revised version.

Jan 28 2020, 2:15 PM · Restricted Project

Jan 23 2020

kazu added a reverting change for rG53b68e676faf: Resubmit: [JumpThreading] Thread jumps through two basic blocks: rG41784bed0154: Revert "Resubmit: [JumpThreading] Thread jumps through two basic blocks".
Jan 23 2020, 6:48 AM
kazu committed rG41784bed0154: Revert "Resubmit: [JumpThreading] Thread jumps through two basic blocks" (authored by kazu).
Revert "Resubmit: [JumpThreading] Thread jumps through two basic blocks"
Jan 23 2020, 6:48 AM

Jan 17 2020

kazu added a comment to D72916: [JumpThreading] Reduce duplicate threshold at Oz.

I echo what other have said.

Jan 17 2020, 8:46 AM · Restricted Project

Jan 16 2020

kazu committed rG53b68e676faf: Resubmit: [JumpThreading] Thread jumps through two basic blocks (authored by kazu).
Resubmit: [JumpThreading] Thread jumps through two basic blocks
Jan 16 2020, 12:37 PM
kazu added a reverting change for rG2d258ed931cd: Revert "[JumpThreading] Thread jumps through two basic blocks": rG53b68e676faf: Resubmit: [JumpThreading] Thread jumps through two basic blocks.
Jan 16 2020, 12:37 PM
kazu closed D70247: [JumpThreading] Thread jumps through two basic blocks.
Jan 16 2020, 12:37 PM · Restricted Project
kazu requested review of D70247: [JumpThreading] Thread jumps through two basic blocks.

PTAL Thanks!

Jan 16 2020, 11:29 AM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

I've further simplied thread-two-bbs3.ll, the testcase for Windows,
and made it a little more robust with:

Jan 16 2020, 11:21 AM · Restricted Project

Jan 15 2020

kazu abandoned D72615: [JumpThreading] Thread jumps through two basic blocks.

I'm abandoning this change. We'll discuss the revision in https://reviews.llvm.org/D70247 instead.

Jan 15 2020, 7:28 AM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

PTAL Thanks!

Jan 15 2020, 7:26 AM · Restricted Project
kazu reopened D70247: [JumpThreading] Thread jumps through two basic blocks.

I'm reopening this so that I can upload a revision containing a fix for Windows build.

Jan 15 2020, 7:26 AM · Restricted Project

Jan 13 2020

kazu committed rG6b686703e63f: [Inlining] Add PreInlineThreshold for the new pass manager (authored by kazu).
[Inlining] Add PreInlineThreshold for the new pass manager
Jan 13 2020, 8:03 AM
kazu closed D72618: [Inlining] Add PreInlineThreshold for the new pass manager.
Jan 13 2020, 8:03 AM · Restricted Project
kazu created D72618: [Inlining] Add PreInlineThreshold for the new pass manager.
Jan 13 2020, 6:35 AM · Restricted Project
kazu created D72615: [JumpThreading] Thread jumps through two basic blocks.
Jan 13 2020, 6:26 AM · Restricted Project

Jan 8 2020

kazu added a comment to D70247: [JumpThreading] Thread jumps through two basic blocks.

I've reverted the change for now. I'll take a look at the failure on Windows.

Jan 8 2020, 2:32 PM · Restricted Project
kazu committed rG2d258ed931cd: Revert "[JumpThreading] Thread jumps through two basic blocks" (authored by kazu).
Revert "[JumpThreading] Thread jumps through two basic blocks"
Jan 8 2020, 2:05 PM
kazu added a reverting change for rGead815924e6e: [JumpThreading] Thread jumps through two basic blocks: rG2d258ed931cd: Revert "[JumpThreading] Thread jumps through two basic blocks".
Jan 8 2020, 2:05 PM
kazu committed rGead815924e6e: [JumpThreading] Thread jumps through two basic blocks (authored by kazu).
[JumpThreading] Thread jumps through two basic blocks
Jan 8 2020, 7:03 AM
kazu closed D70247: [JumpThreading] Thread jumps through two basic blocks.
Jan 8 2020, 7:03 AM · Restricted Project

Jan 7 2020

kazu added a comment to D70247: [JumpThreading] Thread jumps through two basic blocks.

Please take a look. Thanks!

Jan 7 2020, 5:07 PM · Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

Updated the patch, incorporating feedback from Wei.

Jan 7 2020, 3:04 PM · Restricted Project

Dec 30 2019

kazu abandoned D71776: [NFC][InlineCost] Refactor CallAnalyzer::analyze.

https://reviews.llvm.org/D71733 supersedes this patch.

Dec 30 2019, 6:57 AM · Restricted Project

Dec 20 2019

kazu created D71776: [NFC][InlineCost] Refactor CallAnalyzer::analyze.
Dec 20 2019, 9:40 AM · Restricted Project

Dec 17 2019

kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

I've updated the patch so that we commit to jump threading across two
basic blocks once we are done with analysis. That is, we don't
transform the IR partially only to see jump threading proper failing.

Dec 17 2019, 12:37 PM · Restricted Project

Nov 22 2019

kazu committed rGa1955566282b: [JumpThreading] NFC: Don't cache F.hasProfileData() (authored by kazu).
[JumpThreading] NFC: Don't cache F.hasProfileData()
Nov 22 2019, 8:54 AM
kazu closed D70602: [JumpThreading] NFC: Don't cache F.hasProfileData().
Nov 22 2019, 8:54 AM · Restricted Project
kazu accepted D70602: [JumpThreading] NFC: Don't cache F.hasProfileData().

Self-LGTM as this is a very simple NFC.

Nov 22 2019, 8:53 AM · Restricted Project
kazu created D70602: [JumpThreading] NFC: Don't cache F.hasProfileData().
Nov 22 2019, 8:53 AM · Restricted Project
kazu committed rG1a58be2ac58c: [JumpThreading] Use profile data even with the new pass manager (authored by kazu).
[JumpThreading] Use profile data even with the new pass manager
Nov 22 2019, 8:23 AM
kazu closed D70509: [JumpThreading] Use profile data even with the new pass manager.
Nov 22 2019, 8:23 AM · Restricted Project

Nov 21 2019

kazu committed rG4f5d931c5813: [JumpThreading] Refactor ThreadEdge (authored by kazu).
[JumpThreading] Refactor ThreadEdge
Nov 21 2019, 12:58 PM
kazu closed D70338: [JumpThreading] Refactor ThreadEdge.
Nov 21 2019, 12:58 PM · Restricted Project
kazu updated the diff for D70338: [JumpThreading] Refactor ThreadEdge.

Updated to incorporate the feedback.

Nov 21 2019, 8:47 AM · Restricted Project

Nov 20 2019

kazu created D70509: [JumpThreading] Use profile data even with the new pass manager.
Nov 20 2019, 1:37 PM · Restricted Project

Nov 15 2019

kazu created D70338: [JumpThreading] Refactor ThreadEdge.
Nov 15 2019, 1:21 PM · Restricted Project
kazu added inline comments to D70247: [JumpThreading] Thread jumps through two basic blocks.
Nov 15 2019, 9:29 AM · Restricted Project

Nov 14 2019

kazu added a reviewer for D70247: [JumpThreading] Thread jumps through two basic blocks: eli.friedman.
Nov 14 2019, 9:20 AM · Restricted Project
kazu created D70247: [JumpThreading] Thread jumps through two basic blocks.
Nov 14 2019, 8:34 AM · Restricted Project

Nov 8 2019

kazu committed rG9aff5e1c1884: [JumpThreading] Fix a comment typo (NFC) (authored by kazu).
[JumpThreading] Fix a comment typo (NFC)
Nov 8 2019, 9:31 AM
kazu closed D70013: [JumpThreading] Fix a comment typo (NFC).
Nov 8 2019, 9:31 AM · Restricted Project
kazu accepted D70013: [JumpThreading] Fix a comment typo (NFC).
Nov 8 2019, 9:30 AM · Restricted Project
kazu created D70013: [JumpThreading] Fix a comment typo (NFC).
Nov 8 2019, 9:30 AM · Restricted Project

Nov 6 2019

kazu committed rGf0f73ed8b004: [JumpThreading] Factor out code to clone instructions (NFC) (authored by kazu).
[JumpThreading] Factor out code to clone instructions (NFC)
Nov 6 2019, 2:21 PM
kazu closed D69861: [JumpThreading] Factor out code to clone a basic block (NFC).
Nov 6 2019, 2:21 PM · Restricted Project

Nov 5 2019

kazu added inline comments to D69861: [JumpThreading] Factor out code to clone a basic block (NFC).
Nov 5 2019, 7:23 PM · Restricted Project
kazu updated the diff for D69861: [JumpThreading] Factor out code to clone a basic block (NFC).

I've decided to scale back. I'm now simply factoring out code to
clone instructions. I thought about capturing more functionality into
CloneBasicBlock as you suggeted, but then the function would lose
generality I need for my upcoming patch.

Nov 5 2019, 7:23 PM · Restricted Project
kazu created D69861: [JumpThreading] Factor out code to clone a basic block (NFC).
Nov 5 2019, 11:15 AM · Restricted Project
kazu committed rG893afb9ca148: [JumpThreading] Factor out code to merge basic blocks (NFC) (authored by kazu).
[JumpThreading] Factor out code to merge basic blocks (NFC)
Nov 5 2019, 9:52 AM
kazu closed D69852: [JumpThreading] Factor out code to merge basic blocks (NFC).
Nov 5 2019, 9:51 AM · Restricted Project
kazu updated the diff for D69852: [JumpThreading] Factor out code to merge basic blocks (NFC).

I've incorporated the feedback from wmi.

Nov 5 2019, 9:42 AM · Restricted Project
kazu created D69852: [JumpThreading] Factor out code to merge basic blocks (NFC).
Nov 5 2019, 8:28 AM · Restricted Project
kazu committed rG0016c1f40043: [JumpThreading] Factor out common code to update the SSA form (NFC) (authored by kazu).
[JumpThreading] Factor out common code to update the SSA form (NFC)
Nov 5 2019, 6:19 AM
kazu closed D69811: [JumpThreading] Factor out common code to update the SSA form (NFC).
Nov 5 2019, 6:19 AM · Restricted Project

Nov 4 2019

kazu created D69811: [JumpThreading] Factor out common code to update the SSA form (NFC).
Nov 4 2019, 10:18 AM · Restricted Project