In D104028#2818736, @ChuanqiXu wrote:

I am tuning the performance by reordering inlining in downstream. My first try was to use std::priority_queue. But I tried to use the inline cost heuristic to order them. In this patch it looks like sort callsites by HistoryID? What's the intention?

Thanks for updating the patch!

Thanks for the update. I'd generalize the code around Call.erase a little bit more to accommodate other underlying data structures. See the comments below for details.

I also agree this is in the right direction. I've left some minor comments.

Thank you for running benchmarks!

Thank you for taking the time to revert the patch. Let me look into this.

Do you think you could try some benchmarks?

In D98213#2612503, @wenlei wrote:

What's the .text size change for your internal benchmark when you turn it on?

May I ask which cpp file you see the warning in? I just built clang and llvm, but I wasn't able to reproduce the warning. Thanks!

This patch fixes the problem I was having while building an instrumented binary.

This patch seems to break the shared build while building lib/libLLVMProfileData.so.13git.