Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D125497

[RISCV] Call relaxation
AbandonedPublic
Actions

Authored by gkm on May 12 2022, 12:54 PM.

Details

Reviewers
ruiu
MaskRay
jrtc27
luismarques
reames
Summary

Add relaxation handling for calls

Depends on D125036

Diff Detail

Event Timeline

gkm created this revision.May 12 2022, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2022, 12:54 PM
Herald added subscribers: sunshaoce, VincentWu, luke957 and 28 others. · View Herald Transcript
gkm requested review of this revision.May 12 2022, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2022, 12:54 PM
Herald added subscribers: llvm-commits, • pcwang-thead, eopXD. · View Herald Transcript
Harbormaster completed remote builds in B164183: Diff 429052.May 12 2022, 2:26 PM
gkm updated this revision to Diff 431770.May 24 2022, 1:07 PM
  • Add capacity to undo earlier relaxations that go out of range after later passes
Harbormaster completed remote builds in B166125: Diff 431770.May 24 2022, 2:33 PM
luismarques added a comment.May 25 2022, 4:03 AM

This still fails with the test case I provided as feedback for D100835: https://reviews.llvm.org/D100835#3456472

gkm updated this revision to Diff 432402.May 26 2022, 4:12 PM
  • Fix bug reported by @luismarques regarding relaxation of calls through PLT
Harbormaster completed remote builds in B166552: Diff 432402.May 26 2022, 4:23 PM
gkm updated this revision to Diff 432476.May 26 2022, 11:54 PM
  • add fillAlignGap(), extracted from fillAdjustGaps()
  • add empty cases for HI20/LO12 relaxations, to be fleshed-out in a later diff.
Harbormaster completed remote builds in B166600: Diff 432476.May 27 2022, 12:24 AM
luismarques added a comment.May 27 2022, 6:26 AM

Can you please rebase the patch? It fails to apply.

luismarques added a comment.May 27 2022, 6:42 AM
In D125497#3542269, @luismarques wrote:

Can you please rebase the patch? It fails to apply.

Nevermind. Updating the parent fixes it enough.

gkm updated this revision to Diff 432620.May 27 2022, 12:54 PM
  • Remove glob patterns from ld.lld command lines in lld/test/ELF/riscv-relax-call-undo.s because Windows doesn't support them.
gkm added a child revision: D126562: [RISCV][WIP] Load/store relaxation.May 27 2022, 1:02 PM
Harbormaster completed remote builds in B166693: Diff 432620.May 27 2022, 1:11 PM
gkm updated this revision to Diff 432625.May 27 2022, 1:32 PM
  • fix indentation, as caught by clang-format
Harbormaster completed remote builds in B166698: Diff 432625.May 27 2022, 1:44 PM
gkm updated this revision to Diff 434630.Jun 6 2022, 3:38 PM
  • Rebase, minor cleanups, minor comment revisions
Harbormaster completed remote builds in B168168: Diff 434630.Jun 6 2022, 3:49 PM
gkm abandoned this revision.Jun 26 2022, 10:04 PM

Revision Contents
Changeset List

PathSize
lld/
ELF/
Arch/
228 lines
test/
ELF/
44 lines
105 lines
99 lines

Diff 434630

View Options

lld/ELF/Arch/RISCV.cpp

Loading...
View Options

lld/test/ELF/riscv-relax-call-plt.s

Loading...
View Options

lld/test/ELF/riscv-relax-call-undo.s

Loading...
View Options

lld/test/ELF/riscv-relax-call.s

Loading...