[MachineOutliner] Make getOutliningType partially target-independent

[duck-37]

Summary

The motivation behind this patch is to unify some of the outliner logic across architectures. This looks nicer in general and makes fixing issues like this easier.
There are some notable changes here:

1. isMetaInstruction() is used directly instead of checking for specific meta-instructions like IMPLICIT_DEF or KILL. This was already done in the RISC-V implementation, but other architectures still did hardcoded checks.
   • As an exception to this, CFI instructions are explicitly delegated to the target because RISC-V has different handling for those.
2. isTargetIndex() checks are replaced with an assert; none of the architectures supported actually use MO_TargetIndex at this point in time.
3. isCFIIndex() and isFI() checks are also replaced with asserts, since these operands should not exist in any context at this stage in the pipeline.

[duck-37]

Comment clarification and typo fix.

[duck-37]

Rebase and add assertions for other operands that shouldn't exist at this point.

[pcwang-thead]

I'm not qualified for reviewing this patch, but it makes sense to me. Thanks for doing these changes. :-)

[pcwang-thead]

llvm/include/llvm/CodeGen/TargetInstrInfo.h

1987

We may need to change \p MI to \p MIT or modify param name.

llvm/lib/CodeGen/TargetInstrInfo.cpp

1594

"frame indices" could be excluded since we assert them now. :-)

[duck-37]

Rebase, update a few comments.

[duck-37]

Rebase.

[duck-37]

Rebase.

[duck-37]

Rebase to fix w/ new LLVM version. @paquette ping, this PR has been open for some time now and it's blocking the more important change (preventing XRay pseudo-opcodes from being outlined without needless code duplication)

[duck-37]

Rebase.

[paquette]

This is nice, thank you.

[zjaffal]

It looks like this commit introduced a new crash in llc when building for macos
Here is the link to the reproducer
https://godbolt.org/z/heqaE1jYa

Please take a look and revert if it needs a non-trivial fix

[duck-37]

In D125072#4227820, @zjaffal wrote:

It looks like this commit introduced a new crash in llc when building for macos
Here is the link to the reproducer
https://godbolt.org/z/heqaE1jYa

Please take a look and revert if it needs a non-trivial fix

Looking into it now, thanks.

[duck-37]

In D125072#4228326, @duck-37 wrote:

In D125072#4227820, @zjaffal wrote:

It looks like this commit introduced a new crash in llc when building for macos
Here is the link to the reproducer
https://godbolt.org/z/heqaE1jYa

Please take a look and revert if it needs a non-trivial fix

Looking into it now, thanks.

I've found the issue. Making a reduced test-case now.

[duck-37]

@zjaffal

most likely won't be able to get this done fully by tonight, so WIP patch is attached

llvm-trunk-18-48-43.patch1 KBDownload

[zjaffal]

In D125072#4228904, @duck-37 wrote:

@zjaffal

most likely won't be able to get this done fully by tonight, so WIP patch is attached

llvm-trunk-18-48-43.patch1 KBDownload

I tested the patch attached on the full project and it fixes the build failure.
Thanks