Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People zjaffal

zjaffal (Zain Jaffal)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 11 2022, 3:52 AM (58 w, 2 d)

Recent Activity
View All

Aug 11 2023

zjaffal retitled D156869: Remark Util introduce remark count from Remark Util intoduce remark count to Remark Util introduce remark count.
Aug 11 2023, 8:26 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D156869: Remark Util introduce remark count.

Address nit comments

Aug 11 2023, 8:25 AM · Restricted Project, Restricted Project
zjaffal added inline comments to D156869: Remark Util introduce remark count.
Aug 11 2023, 8:25 AM · Restricted Project, Restricted Project

Aug 2 2023

zjaffal abandoned D155187: [RemarkUtil] Add an option to collect remark count information given a list of keys..

D156869 should cover all the changes that this patch is doing.

Aug 2 2023, 2:43 AM · Restricted Project, Restricted Project
zjaffal requested review of D156869: Remark Util introduce remark count.
Aug 2 2023, 2:41 AM · Restricted Project, Restricted Project
zjaffal committed rG24f320e48c83: [RemarkUtil] Refactor llvm-remarkutil to include size-diff (authored by zjaffal).
[RemarkUtil] Refactor llvm-remarkutil to include size-diff
Aug 2 2023, 2:34 AM · Restricted Project, Restricted Project, Restricted Project
zjaffal closed D156515: [RemarkUtil] Refactor llvm-remarkutil to include size-diff.
Aug 2 2023, 2:33 AM · Restricted Project, Restricted Project, Restricted Project

Jul 28 2023

zjaffal requested review of D156515: [RemarkUtil] Refactor llvm-remarkutil to include size-diff.
Jul 28 2023, 1:24 AM · Restricted Project, Restricted Project, Restricted Project
zjaffal committed rG30d8e0837d68: [RemarkUtil] Refactor remarkutil tool to use a command registry. (authored by zjaffal).
[RemarkUtil] Refactor remarkutil tool to use a command registry.
Jul 28 2023, 1:22 AM · Restricted Project, Restricted Project
zjaffal closed D156416: [RemarkUtil] Refactor remarkutil tool to use a command registry..
Jul 28 2023, 1:22 AM · Restricted Project, Restricted Project

Jul 27 2023

zjaffal requested review of D156416: [RemarkUtil] Refactor remarkutil tool to use a command registry..
Jul 27 2023, 4:14 AM · Restricted Project, Restricted Project

Jul 24 2023

zjaffal committed rG3161db8ca07e: [Remark] Overload `<<` for Remark, RemarkType and RemarkLocation. (authored by zjaffal).
[Remark] Overload `<<` for Remark, RemarkType and RemarkLocation.
Jul 24 2023, 6:49 AM · Restricted Project, Restricted Project
zjaffal closed D155058: [Remark] Overload `<<` for Remark, RemarkType and RemarkLocation..
Jul 24 2023, 6:49 AM · Restricted Project, Restricted Project

Jul 13 2023

zjaffal requested review of D155187: [RemarkUtil] Add an option to collect remark count information given a list of keys..
Jul 13 2023, 5:07 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D155058: [Remark] Overload `<<` for Remark, RemarkType and RemarkLocation..
  1. Change std::string references to StringRef
Jul 13 2023, 1:17 AM · Restricted Project, Restricted Project

Jul 12 2023

zjaffal requested review of D155068: [Remarks] Introduce `llvm-remark-diff` tool..
Jul 12 2023, 4:07 AM · Restricted Project, Restricted Project
zjaffal requested review of D155058: [Remark] Overload `<<` for Remark, RemarkType and RemarkLocation..
Jul 12 2023, 2:48 AM · Restricted Project, Restricted Project

Jun 26 2023

zjaffal committed rGe800967eb110: [YAMLParser] Support block nodes when parsing YAML strings. (authored by zjaffal).
[YAMLParser] Support block nodes when parsing YAML strings.
Jun 26 2023, 6:31 AM · Restricted Project, Restricted Project
zjaffal closed D153760: [YAMLParser] Support block nodes when parsing YAML strings..
Jun 26 2023, 6:31 AM · Restricted Project, Restricted Project
zjaffal requested review of D153760: [YAMLParser] Support block nodes when parsing YAML strings..
Jun 26 2023, 5:09 AM · Restricted Project, Restricted Project

Jun 20 2023

zjaffal accepted D153325: [CodeGen][test] Add missing `REQUIRES`..

LGTM!

Jun 20 2023, 2:59 AM · Restricted Project, Restricted Project

Jun 9 2023

zjaffal committed rGc45695ef4657: [Metadata] Fix `addAnnotationMetadata` when appending a string tuple to an… (authored by zjaffal).
[Metadata] Fix `addAnnotationMetadata` when appending a string tuple to an…
Jun 9 2023, 6:22 AM · Restricted Project, Restricted Project
zjaffal closed D152448: [Metadata] Fix `addAnnotationMetadata` when appending a string tuple to an existing MDTuple..
Jun 9 2023, 6:21 AM · Restricted Project, Restricted Project

Jun 8 2023

zjaffal added a comment to D152448: [Metadata] Fix `addAnnotationMetadata` when appending a string tuple to an existing MDTuple..
In D152448#4406179, @fhahn wrote:

Is it possible to have a test for this?

Jun 8 2023, 10:29 AM · Restricted Project, Restricted Project
zjaffal committed rGd65c0527ab70: change checking for auto-init metadata to use `equalsStr` instead of casing… (authored by zjaffal).
change checking for auto-init metadata to use `equalsStr` instead of casing…
Jun 8 2023, 7:58 AM · Restricted Project, Restricted Project
zjaffal closed D152372: change checking for auto-init metadata to use `equalsStr` instead of casing MDOperand nodes..
Jun 8 2023, 7:58 AM · Restricted Project, Restricted Project
zjaffal requested review of D152448: [Metadata] Fix `addAnnotationMetadata` when appending a string tuple to an existing MDTuple..
Jun 8 2023, 7:57 AM · Restricted Project, Restricted Project

Jun 7 2023

zjaffal updated the diff for D151708: [AArch64] merge scaled and unscaled 8-bit and 18-bit zero narrow stores..

Fix crashing tests

Jun 7 2023, 8:01 AM · Restricted Project, Restricted Project
zjaffal requested review of D152372: change checking for auto-init metadata to use `equalsStr` instead of casing MDOperand nodes..
Jun 7 2023, 7:11 AM · Restricted Project, Restricted Project

May 30 2023

zjaffal requested review of D151708: [AArch64] merge scaled and unscaled 8-bit and 18-bit zero narrow stores..
May 30 2023, 6:37 AM · Restricted Project, Restricted Project

May 26 2023

zjaffal committed rG0c93879d9621: [AArch64] merge scaled and unscaled zero narrow stores. (authored by zjaffal).
[AArch64] merge scaled and unscaled zero narrow stores.
May 26 2023, 7:08 AM · Restricted Project, Restricted Project
zjaffal closed D150963: [AArch64] merge scaled and unscaled zero narrow stores..
May 26 2023, 7:07 AM · Restricted Project, Restricted Project

May 25 2023

zjaffal updated the diff for D150963: [AArch64] merge scaled and unscaled zero narrow stores..

Fix comments

May 25 2023, 4:52 AM · Restricted Project, Restricted Project

May 24 2023

zjaffal updated the diff for D150963: [AArch64] merge scaled and unscaled zero narrow stores..
  1. Assign OffsetImm to the appropriate value without doing recalculations.
  2. Remove unecessary checks.
May 24 2023, 2:10 AM · Restricted Project, Restricted Project

May 23 2023

zjaffal updated the diff for D150963: [AArch64] merge scaled and unscaled zero narrow stores..
  1. Change the way offsets are calculated to handle mixing of scaled and unscaled stores.
  2. Change the test to use .mir instead of .ll
May 23 2023, 11:06 AM · Restricted Project, Restricted Project

May 19 2023

zjaffal requested review of D150963: [AArch64] merge scaled and unscaled zero narrow stores..
May 19 2023, 7:26 AM · Restricted Project, Restricted Project

May 16 2023

zjaffal added a comment to D135462: [SelectionDAG] Do not second-guess alignment for alloca.

Hello this commit is causing a compiler crash for the following example:
https://llvm.godbolt.org/z/xajYWoa8K

May 16 2023, 12:05 PM · Restricted Project, Restricted Project

May 9 2023

zjaffal committed rG5d3a8842295e: [IRGen] Change annotation metadata to support inserting tuple of strings into… (authored by zjaffal).
[IRGen] Change annotation metadata to support inserting tuple of strings into…
May 9 2023, 7:52 AM · Restricted Project, Restricted Project
zjaffal closed D148328: [IRGen] Change annotation metadata to support inserting tuple of strings into annotation metadata array..
May 9 2023, 7:51 AM · Restricted Project, Restricted Project

Apr 25 2023

zjaffal updated the diff for D144840: [ConstraintElimination] Add tests to check for type bounds optimisation from zext instructions.

Remove redundant tests and simplify tests

Apr 25 2023, 7:57 AM · Restricted Project, Restricted Project
zjaffal retitled D148328: [IRGen] Change annotation metadata to support inserting tuple of strings into annotation metadata array. from [IRGen] Change annotation metadata to support a tuple of strings. to [IRGen] Change annotation metadata to support inserting tuple of strings into annotation metadata array..
Apr 25 2023, 4:35 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D148328: [IRGen] Change annotation metadata to support inserting tuple of strings into annotation metadata array..
  • Address comments
Apr 25 2023, 4:34 AM · Restricted Project, Restricted Project

Apr 19 2023

zjaffal updated the diff for D148705: [AArch64] Fix crash caused by performExtractVectorEltCombine on DUP nodes with float operands..

Update test and address comments

Apr 19 2023, 8:50 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D147322: [AArch64] Improve fshl cost modeling if 3rd arg is constant..
  1. Merge fshr cost modeling with this patch.
  2. Remove unnecessary debug output
  3. Fix cost model for scalar types. Using TyL.first + Cost instead of multiplication.
Apr 19 2023, 8:19 AM · Restricted Project, Restricted Project
zjaffal added inline comments to D147322: [AArch64] Improve fshl cost modeling if 3rd arg is constant..
Apr 19 2023, 5:00 AM · Restricted Project, Restricted Project
zjaffal requested review of D148705: [AArch64] Fix crash caused by performExtractVectorEltCombine on DUP nodes with float operands..
Apr 19 2023, 4:23 AM · Restricted Project, Restricted Project
zjaffal added a comment to D128144: [AArch64] Known bits for AArch64ISD::DUP.

This patch seems to miss the case where the DUP first operand is not an integer type

Apr 19 2023, 4:18 AM · Restricted Project, Restricted Project
zjaffal commandeered D147322: [AArch64] Improve fshl cost modeling if 3rd arg is constant..
Apr 19 2023, 2:23 AM · Restricted Project, Restricted Project

Apr 18 2023

zjaffal updated the diff for D147322: [AArch64] Improve fshl cost modeling if 3rd arg is constant..

Add more types to CostTblEntry

Apr 18 2023, 8:22 AM · Restricted Project, Restricted Project
zjaffal committed rGbdb173d0dde8: [llvm-remarkutil] Add an option to display DebugLoc when collecting counts for… (authored by zjaffal).
[llvm-remarkutil] Add an option to display DebugLoc when collecting counts for…
Apr 18 2023, 5:49 AM · Restricted Project, Restricted Project
zjaffal closed D148374: [llvm-remarkutil] Add an option to display DebugLoc when collecting counts for remarks..
Apr 18 2023, 5:49 AM · Restricted Project, Restricted Project

Apr 17 2023

zjaffal updated the summary of D148328: [IRGen] Change annotation metadata to support inserting tuple of strings into annotation metadata array..
Apr 17 2023, 8:00 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D148328: [IRGen] Change annotation metadata to support inserting tuple of strings into annotation metadata array..

Update LangRef.rst

Apr 17 2023, 7:56 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D148374: [llvm-remarkutil] Add an option to display DebugLoc when collecting counts for remarks..

refactor code to reduce duplication

Apr 17 2023, 1:53 AM · Restricted Project, Restricted Project
zjaffal committed rG721ecc9d413c: [ConstraintElimination] Transfer info from sgt %a, %b to ugt %a, %b if %b > 0 (authored by zjaffal).
[ConstraintElimination] Transfer info from sgt %a, %b to ugt %a, %b if %b > 0
Apr 17 2023, 1:29 AM · Restricted Project, Restricted Project
zjaffal closed D148326: [ConstraintElimination] Transfer info from sgt %a, %b to ugt %a, %b if %b > 0.
Apr 17 2023, 1:28 AM · Restricted Project, Restricted Project

Apr 14 2023

zjaffal added a comment to D148374: [llvm-remarkutil] Add an option to display DebugLoc when collecting counts for remarks..
In D148374#4269616, @thegameg wrote:

Why not use the YAML output directly in this case?

Apr 14 2023, 1:38 PM · Restricted Project, Restricted Project
zjaffal requested review of D148374: [llvm-remarkutil] Add an option to display DebugLoc when collecting counts for remarks..
Apr 14 2023, 1:34 PM · Restricted Project, Restricted Project
zjaffal added a comment to D148326: [ConstraintElimination] Transfer info from sgt %a, %b to ugt %a, %b if %b > 0.

alive 2 proof
https://alive2.llvm.org/ce/z/cCGqEb

Apr 14 2023, 8:32 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D148326: [ConstraintElimination] Transfer info from sgt %a, %b to ugt %a, %b if %b > 0.

rebase on top of main

Apr 14 2023, 8:26 AM · Restricted Project, Restricted Project
zjaffal committed rG51f3781aece4: [ConstraintElimination] Add tests to check for transfering facts from sgt to… (authored by zjaffal).
[ConstraintElimination] Add tests to check for transfering facts from sgt to…
Apr 14 2023, 7:44 AM · Restricted Project, Restricted Project
zjaffal closed D148321: [ConstraintElimination] Add tests to check for transfering facts from sgt to ugt..
Apr 14 2023, 7:44 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D148321: [ConstraintElimination] Add tests to check for transfering facts from sgt to ugt..

add more tests

Apr 14 2023, 7:22 AM · Restricted Project, Restricted Project
zjaffal added a comment to D144863: [ConstraintElimination] Add bound info for composite expressions..

ping

Apr 14 2023, 4:50 AM · Restricted Project, Restricted Project
zjaffal added a comment to D144842: [ConstraintElimination] Add upper bound info based on maximum type bounds for zext instructions.

ping

Apr 14 2023, 4:50 AM · Restricted Project, Restricted Project
zjaffal added a comment to D144841: [ConstraintElimination] Replace isKnownNegative entry with upper and lower bound info for each decomposed variable..

ping

Apr 14 2023, 4:50 AM · Restricted Project, Restricted Project
zjaffal added a comment to D144840: [ConstraintElimination] Add tests to check for type bounds optimisation from zext instructions.

ping

Apr 14 2023, 4:49 AM · Restricted Project, Restricted Project
zjaffal requested review of D148328: [IRGen] Change annotation metadata to support inserting tuple of strings into annotation metadata array..
Apr 14 2023, 4:42 AM · Restricted Project, Restricted Project
zjaffal requested review of D148326: [ConstraintElimination] Transfer info from sgt %a, %b to ugt %a, %b if %b > 0.
Apr 14 2023, 4:12 AM · Restricted Project, Restricted Project
zjaffal retitled D148321: [ConstraintElimination] Add tests to check for transfering facts from sgt to ugt. from [ConstraintElimination] Add tests to check for transfering facts from sgt to uge. to [ConstraintElimination] Add tests to check for transfering facts from sgt to ugt..
Apr 14 2023, 4:10 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D148321: [ConstraintElimination] Add tests to check for transfering facts from sgt to ugt..

change back to ugt

Apr 14 2023, 4:10 AM · Restricted Project, Restricted Project
zjaffal retitled D148321: [ConstraintElimination] Add tests to check for transfering facts from sgt to ugt. from [ConstraintElimination] Add tests to check for transfering facts from sgt to ugt. to [ConstraintElimination] Add tests to check for transfering facts from sgt to uge..
Apr 14 2023, 3:43 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D148321: [ConstraintElimination] Add tests to check for transfering facts from sgt to ugt..

update test cases to use uge instead of ugt

Apr 14 2023, 3:43 AM · Restricted Project, Restricted Project
zjaffal requested review of D148321: [ConstraintElimination] Add tests to check for transfering facts from sgt to ugt..
Apr 14 2023, 3:32 AM · Restricted Project, Restricted Project

Apr 7 2023

zjaffal committed rG436758f7b040: [llvm-remarkutil] Add missing new line for `llvm/docs/CommandGuide/llvm… (authored by zjaffal).
[llvm-remarkutil] Add missing new line for `llvm/docs/CommandGuide/llvm…
Apr 7 2023, 3:48 PM · Restricted Project, Restricted Project
zjaffal added a reverting change for rG0f7fcb4c670f: Revert "Add an option to print out annotation remark count.": rGdb01cf7b7cb0: Recommit "Add an option to print out annotation remark count.".
Apr 7 2023, 3:44 PM · Restricted Project, Restricted Project
zjaffal committed rGdb01cf7b7cb0: Recommit "Add an option to print out annotation remark count." (authored by zjaffal).
Recommit "Add an option to print out annotation remark count."
Apr 7 2023, 3:44 PM · Restricted Project, Restricted Project
zjaffal added a reverting change for rG7cc80ef5fa35: Add an option to print out annotation remark count.: rG0f7fcb4c670f: Revert "Add an option to print out annotation remark count.".
Apr 7 2023, 3:42 PM · Restricted Project, Restricted Project
zjaffal committed rG0f7fcb4c670f: Revert "Add an option to print out annotation remark count." (authored by zjaffal).
Revert "Add an option to print out annotation remark count."
Apr 7 2023, 3:42 PM · Restricted Project, Restricted Project
zjaffal added a reverting change for D147710: Add an option to print out annotation remark count.: rG0f7fcb4c670f: Revert "Add an option to print out annotation remark count.".
Apr 7 2023, 3:42 PM · Restricted Project, Restricted Project
zjaffal committed rG7cc80ef5fa35: Add an option to print out annotation remark count. (authored by zjaffal).
Add an option to print out annotation remark count.
Apr 7 2023, 3:34 PM · Restricted Project, Restricted Project
zjaffal closed D147710: Add an option to print out annotation remark count..
Apr 7 2023, 3:33 PM · Restricted Project, Restricted Project
zjaffal added inline comments to D147710: Add an option to print out annotation remark count..
Apr 7 2023, 2:33 PM · Restricted Project, Restricted Project
zjaffal updated the diff for D147710: Add an option to print out annotation remark count..

add new lines at the end yaml and rst files

Apr 7 2023, 3:19 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D147710: Add an option to print out annotation remark count..

Address comments.

Apr 7 2023, 3:17 AM · Restricted Project, Restricted Project

Apr 6 2023

zjaffal added a comment to D147710: Add an option to print out annotation remark count..

Thanks all for your comments I will update the patch accordingly

Apr 6 2023, 1:58 PM · Restricted Project, Restricted Project
zjaffal requested review of D147710: Add an option to print out annotation remark count..
Apr 6 2023, 7:13 AM · Restricted Project, Restricted Project

Apr 3 2023

zjaffal committed rG1d23d60c8d04: [ConstraintElimination] Add function arguments to constraint system before… (authored by zjaffal).
[ConstraintElimination] Add function arguments to constraint system before…
Apr 3 2023, 6:17 AM · Restricted Project, Restricted Project
zjaffal closed D144879: [ConstraintElimination] Add function arguments to constraint system before solving.
Apr 3 2023, 6:17 AM · Restricted Project, Restricted Project

Mar 30 2023

zjaffal updated the diff for D144863: [ConstraintElimination] Add bound info for composite expressions..

rebase on main

Mar 30 2023, 4:36 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D144879: [ConstraintElimination] Add function arguments to constraint system before solving.
  1. Pass FunctionArgs as ArrayRef<Value *> to ConstraintInfo and ConstraintSystem
  2. Remove unecessary import
  3. Change variable initialization for ConstraintInfo and ConstraintSystem
Mar 30 2023, 3:58 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D144842: [ConstraintElimination] Add upper bound info based on maximum type bounds for zext instructions.

Add condition to prevent generating upperbounds for variables with bitwidth > 64

Mar 30 2023, 3:07 AM · Restricted Project, Restricted Project
zjaffal updated the diff for D144841: [ConstraintElimination] Replace isKnownNegative entry with upper and lower bound info for each decomposed variable..

rebase on top of main

Mar 30 2023, 2:36 AM · Restricted Project, Restricted Project

Mar 29 2023

zjaffal updated the diff for D144879: [ConstraintElimination] Add function arguments to constraint system before solving.

Seperate the patch from depending on other ConstraintElimination patches

Mar 29 2023, 7:30 AM · Restricted Project, Restricted Project
zjaffal added a comment to D125072: [MachineOutliner] Make getOutliningType partially target-independent.
In D125072#4228904, @duck-37 wrote:

@zjaffal

most likely won't be able to get this done fully by tonight, so WIP patch is attached

llvm-trunk-18-48-43.patch1 KBDownload

Mar 29 2023, 2:54 AM · Restricted Project, Restricted Project

Mar 28 2023

zjaffal committed rG4d7d4543344b: [SLP][AArch64] Add test to check for the vectorization of fshl (authored by zjaffal).
[SLP][AArch64] Add test to check for the vectorization of fshl
Mar 28 2023, 9:47 AM · Restricted Project, Restricted Project
zjaffal closed D147056: [SLP][AArch64] Add test to check for the vectorization of fshl.
Mar 28 2023, 9:46 AM · Restricted Project, Restricted Project
zjaffal added a comment to D125072: [MachineOutliner] Make getOutliningType partially target-independent.

It looks like this commit introduced a new crash in llc when building for macos
Here is the link to the reproducer
https://godbolt.org/z/heqaE1jYa

Mar 28 2023, 9:30 AM · Restricted Project, Restricted Project
zjaffal added a comment to D124707: [AArch64] Make sure XRay pseudo-instruction sizes are reported correctly.
Mar 28 2023, 9:27 AM · Restricted Project, Restricted Project
zjaffal requested review of D147056: [SLP][AArch64] Add test to check for the vectorization of fshl.
Mar 28 2023, 8:49 AM · Restricted Project, Restricted Project