Page MenuHomePhabricator
People paquette

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (143 w, 3 d)

oh boy

Recent Activity
View All

Thu, Aug 15

paquette added inline comments to D66287: GlobalISel: add combiner for indexed loads and stores.
Thu, Aug 15, 9:31 AM · Restricted Project

Wed, Aug 14

paquette accepted D66245: [AArch64][GlobalISel] Custom selection for s8 load acquire.

LGTM

Wed, Aug 14, 2:05 PM · Restricted Project

Tue, Aug 13

paquette accepted D66185: [AArch64][GlobalISel] Legalize 128 bit divisions to libcalls.

LGTM

Tue, Aug 13, 4:40 PM · Restricted Project
paquette added inline comments to D66185: [AArch64][GlobalISel] Legalize 128 bit divisions to libcalls.
Tue, Aug 13, 4:02 PM · Restricted Project
paquette accepted D66184: [AArch64][GlobalISel] RBS: Treat s128s like vectors when unmerging.

LGTM

Tue, Aug 13, 4:01 PM · Restricted Project
paquette committed rGb28fa9ec5024: Attempt to fix issue with unresolved lit test in TableGen (authored by paquette).
Attempt to fix issue with unresolved lit test in TableGen
Tue, Aug 13, 3:34 PM
paquette committed rL368760: Attempt to fix issue with unresolved lit test in TableGen.
Attempt to fix issue with unresolved lit test in TableGen
Tue, Aug 13, 3:33 PM
paquette updated the diff for D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands.

Rebase changes after rL368757

Tue, Aug 13, 3:26 PM · Restricted Project
paquette committed rGf41ce85909fb: [GlobalISel][NFC] Factor out common target code from GlobalISelEmitterTests (authored by paquette).
[GlobalISel][NFC] Factor out common target code from GlobalISelEmitterTests
Tue, Aug 13, 3:18 PM
paquette committed rL368757: [GlobalISel][NFC] Factor out common target code from GlobalISelEmitterTests.
[GlobalISel][NFC] Factor out common target code from GlobalISelEmitterTests
Tue, Aug 13, 3:18 PM
paquette closed D65777: [GlobalISel][NFC] Factor out common target code from GlobalISelEmitter tests.
Tue, Aug 13, 3:17 PM · Restricted Project
paquette updated the diff for D66163: [AArch64][GlobalISel] Select patterns which use shifted register operands.

Improve LHS test cases and simplify NumBits calculation

Tue, Aug 13, 2:54 PM · Restricted Project
paquette created D66163: [AArch64][GlobalISel] Select patterns which use shifted register operands.
Tue, Aug 13, 1:50 PM · Restricted Project
paquette created D66162: [AArch64][GlobalISel] Select logical_imm32 and logical_imm64 patterns.
Tue, Aug 13, 1:42 PM · Restricted Project
paquette accepted D65473: GlobalISel: Avoid widening unmerge with matching source type.

LGTM

Tue, Aug 13, 9:50 AM
paquette accepted D65412: GlobalISel: Partially implement fewerElementsVector G_UNMERGE_VALUES.

LGTM

Tue, Aug 13, 9:02 AM

Mon, Aug 12

paquette accepted D65984: [GlobalISel] Make the InstructionSelector instance non-const, allowing state to be maintained..

LGTM

Mon, Aug 12, 1:04 PM · Restricted Project

Tue, Aug 6

paquette updated the diff for D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands.

Move the check for iPTRAny into CodeGenIntrinsic.

Tue, Aug 6, 10:37 AM · Restricted Project
paquette added inline comments to D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands.
Tue, Aug 6, 9:28 AM · Restricted Project

Mon, Aug 5

paquette accepted D65698: [GISel]: Add GISelKnownBits analysis .

Given that the patch's test is a port, I think this is fine.

Mon, Aug 5, 4:37 PM · Restricted Project
paquette added a comment to D65422: [GlobalISel][AArch64] Add naive selection for @llvm.aarch64.ldaxr.

I'd prefer to do this by extending the emitter. After D65756 lands, we should be able to get the 64-bit load intrinsics this way.

Mon, Aug 5, 3:14 PM · Restricted Project
paquette created D65780: [GlobalISel][AArch64] Use a GISelPredicateCode to select llvm.aarch64.stlxr.*.
Mon, Aug 5, 2:59 PM · Restricted Project
paquette created D65779: [GlobalISel][AArch64] Select llvm.aarch64.stxr.* intrinsics..
Mon, Aug 5, 2:54 PM · Restricted Project
paquette added a child revision for D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands: D65777: [GlobalISel][NFC] Factor out common target code from GlobalISelEmitter tests.
Mon, Aug 5, 2:25 PM · Restricted Project
paquette created D65777: [GlobalISel][NFC] Factor out common target code from GlobalISelEmitter tests.
Mon, Aug 5, 2:25 PM · Restricted Project
paquette added a parent revision for D65777: [GlobalISel][NFC] Factor out common target code from GlobalISelEmitter tests: D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands.
Mon, Aug 5, 2:25 PM · Restricted Project
paquette added inline comments to D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands.
Mon, Aug 5, 2:00 PM · Restricted Project
paquette added inline comments to D65698: [GISel]: Add GISelKnownBits analysis .
Mon, Aug 5, 11:13 AM · Restricted Project
paquette updated the diff for D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands.

Fix typo

Mon, Aug 5, 11:11 AM · Restricted Project
paquette added inline comments to D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands.
Mon, Aug 5, 11:10 AM · Restricted Project
paquette accepted D65758: [AArch64][GlobalISel] Inline tiny memcpy et al at -O0.

LGTM

Mon, Aug 5, 11:05 AM · Restricted Project
paquette created D65756: [GlobalISel] Teach GlobalISelEmitter to treat used iPTRAny operands as pointer operands.
Mon, Aug 5, 9:48 AM · Restricted Project

Fri, Aug 2

paquette committed rL367720: Use labmaster llvm-project in common.groovy for CTMark/test suite jobs.
Use labmaster llvm-project in common.groovy for CTMark/test suite jobs
Fri, Aug 2, 1:31 PM
paquette added a comment to D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).

Since option 2 is more in line with the long-term vision, I think it would be better to go down that route. Better to do it sooner than later.

Fri, Aug 2, 1:08 PM · Restricted Project
paquette committed rGe4c46c34cec6: [AArch64][GlobalISel] Support the neg_addsub_shifted_imm32 pattern (authored by paquette).
[AArch64][GlobalISel] Support the neg_addsub_shifted_imm32 pattern
Fri, Aug 2, 11:14 AM
paquette committed rL367700: [AArch64][GlobalISel] Support the neg_addsub_shifted_imm32 pattern.
[AArch64][GlobalISel] Support the neg_addsub_shifted_imm32 pattern
Fri, Aug 2, 11:12 AM
paquette closed D65460: [AArch64][GlobalISel] Support the neg_addsub_shifted_imm32 pattern.
Fri, Aug 2, 11:12 AM · Restricted Project

Thu, Aug 1

paquette committed rL367630: Update test suite jobs to use monorepo..
Update test suite jobs to use monorepo.
Thu, Aug 1, 3:49 PM
paquette committed rL367629: Update URL for last-good-build.properties.
Update URL for last-good-build.properties
Thu, Aug 1, 3:49 PM

Wed, Jul 31

paquette added inline comments to D64179: [CodeGen] Define an interface for the new pass manager..
Wed, Jul 31, 10:07 AM · Restricted Project

Tue, Jul 30

paquette created D65460: [AArch64][GlobalISel] Support the neg_addsub_shifted_imm32 pattern.
Tue, Jul 30, 10:09 AM · Restricted Project

Mon, Jul 29

paquette created D65422: [GlobalISel][AArch64] Add naive selection for @llvm.aarch64.ldaxr.
Mon, Jul 29, 3:38 PM · Restricted Project
paquette added a comment to D65360: [AArch64][GlobalISel] Eliminate redundant G_ZEXT when the source is implicitly zext-loaded.

I am a little concerned that continuing down this route is going to result in a bunch of work that every target will have to duplicate. I think it makes sense to come up with a plan to prevent that if possible.

Mon, Jul 29, 9:30 AM · Restricted Project
paquette accepted D65360: [AArch64][GlobalISel] Eliminate redundant G_ZEXT when the source is implicitly zext-loaded.

I think that for -O0 this makes sense.

Mon, Jul 29, 9:16 AM · Restricted Project

Fri, Jul 26

paquette accepted D65357: [AArch64][GlobalISel] Implement narrowing of G_SEXT..

LGTM

Fri, Jul 26, 4:36 PM · Restricted Project
paquette committed rGaa8b9993c23f: [AArch64][GlobalISel] Select @llvm.aarch64.stlxr for 32-bit pointers (authored by paquette).
[AArch64][GlobalISel] Select @llvm.aarch64.stlxr for 32-bit pointers
Fri, Jul 26, 4:33 PM
paquette committed rL367163: [AArch64][GlobalISel] Select @llvm.aarch64.stlxr for 32-bit pointers.
[AArch64][GlobalISel] Select @llvm.aarch64.stlxr for 32-bit pointers
Fri, Jul 26, 4:28 PM
paquette closed D65355: [AArch64][GlobalISel] Select @llvm.aarch64.stlxr for 32-bit pointers.
Fri, Jul 26, 4:28 PM · Restricted Project
paquette created D65355: [AArch64][GlobalISel] Select @llvm.aarch64.stlxr for 32-bit pointers.
Fri, Jul 26, 4:02 PM · Restricted Project

Wed, Jul 24

paquette committed rG728b18f29f97: [AArch64][GlobalISel] Select immediate modes for ADD when selecting G_GEP (authored by paquette).
[AArch64][GlobalISel] Select immediate modes for ADD when selecting G_GEP
Wed, Jul 24, 4:16 PM
paquette committed rL366959: [AArch64][GlobalISel] Select immediate modes for ADD when selecting G_GEP.
[AArch64][GlobalISel] Select immediate modes for ADD when selecting G_GEP
Wed, Jul 24, 4:15 PM
paquette closed D65248: [AArch64][GlobalISel] Select immediate modes for ADD when selecting G_GEP.
Wed, Jul 24, 4:15 PM · Restricted Project
paquette updated the diff for D65248: [AArch64][GlobalISel] Select immediate modes for ADD when selecting G_GEP.

updating test before committing

Wed, Jul 24, 4:08 PM · Restricted Project
paquette committed rG68499112cf6b: [AArch64][GlobalISel] Fold G_MUL into XRO load addressing mode when possible (authored by paquette).
[AArch64][GlobalISel] Fold G_MUL into XRO load addressing mode when possible
Wed, Jul 24, 3:51 PM
paquette committed rL366954: [AArch64][GlobalISel] Fold G_MUL into XRO load addressing mode when possible.
[AArch64][GlobalISel] Fold G_MUL into XRO load addressing mode when possible
Wed, Jul 24, 3:51 PM
paquette closed D65173: [AArch64][GlobalISel] Fold G_MUL into XRO load addressing mode when possible.
Wed, Jul 24, 3:50 PM · Restricted Project
paquette accepted D65244: [AArch64][GlobalISel] Don't try to use GISel if subtarget doesn't have neon or fp..

LGTM

Wed, Jul 24, 3:50 PM · Restricted Project
paquette created D65248: [AArch64][GlobalISel] Select immediate modes for ADD when selecting G_GEP.
Wed, Jul 24, 3:42 PM · Restricted Project
paquette accepted D64452: GlobalISel: Fold out unmerge to scalars from concat_vector.

LGTM

Wed, Jul 24, 10:24 AM
paquette committed rGc19c30776aee: [AArch64][GlobalISel] Make vector dup optimization look at last elt of ZeroVec (authored by paquette).
[AArch64][GlobalISel] Make vector dup optimization look at last elt of ZeroVec
Wed, Jul 24, 10:21 AM
paquette committed rL366930: [AArch64][GlobalISel] Make vector dup optimization look at last elt of ZeroVec.
[AArch64][GlobalISel] Make vector dup optimization look at last elt of ZeroVec
Wed, Jul 24, 10:18 AM
paquette closed D65168: [AArch64][GlobalISel] Make vector dup optimization look at last elt of ZeroVec.
Wed, Jul 24, 10:18 AM · Restricted Project
paquette accepted D65078: GlobalISel: Add G_ATOMICRMW_{FADD|FSUB}.

LGTM

Wed, Jul 24, 10:15 AM
paquette accepted D65167: [GlobalISel] Support for inlining memcpy, memset and memmove calls.

LGTM with some comments

Wed, Jul 24, 10:13 AM · Restricted Project

Tue, Jul 23

paquette created D65173: [AArch64][GlobalISel] Fold G_MUL into XRO load addressing mode when possible.
Tue, Jul 23, 4:41 PM · Restricted Project
paquette added inline comments to D65167: [GlobalISel] Support for inlining memcpy, memset and memmove calls.
Tue, Jul 23, 3:15 PM · Restricted Project
paquette committed rGa2fae1e3e991: [GlobalISel][AArch64] Save a copy on G_SELECT by fixing condition to GPR (authored by paquette).
[GlobalISel][AArch64] Save a copy on G_SELECT by fixing condition to GPR
Tue, Jul 23, 2:42 PM
paquette committed rL366854: [GlobalISel][AArch64] Save a copy on G_SELECT by fixing condition to GPR.
[GlobalISel][AArch64] Save a copy on G_SELECT by fixing condition to GPR
Tue, Jul 23, 2:42 PM
paquette closed D65157: [GlobalISel][AArch64] Save a copy on G_SELECT by fixing condition to GPR.
Tue, Jul 23, 2:42 PM · Restricted Project
paquette created D65168: [AArch64][GlobalISel] Make vector dup optimization look at last elt of ZeroVec.
Tue, Jul 23, 2:35 PM · Restricted Project
paquette accepted D65166: [AArch64][GlobalISel] Add support for s128 loads, stores, extracts, truncs..

LGTM

Tue, Jul 23, 2:27 PM · Restricted Project
paquette accepted D64065: Skip test earlier if metric is not found in compare.py.

LGTM

Tue, Jul 23, 2:07 PM · Restricted Project
paquette accepted D64066: Add geomean column earlier to dataout as Series in compare.py..

Sorry, I didn't get the email for this for some reason.

Tue, Jul 23, 2:06 PM · Restricted Project
paquette created D65157: [GlobalISel][AArch64] Save a copy on G_SELECT by fixing condition to GPR.
Tue, Jul 23, 10:36 AM · Restricted Project
paquette committed rG2b404d01e826: [GlobalISel][AArch64] Teach GISel to handle shifts in load addressing modes (authored by paquette).
[GlobalISel][AArch64] Teach GISel to handle shifts in load addressing modes
Tue, Jul 23, 9:10 AM
paquette committed rL366819: [GlobalISel][AArch64] Teach GISel to handle shifts in load addressing modes.
[GlobalISel][AArch64] Teach GISel to handle shifts in load addressing modes
Tue, Jul 23, 9:10 AM
paquette closed D65119: [GlobalISel][AArch64] Teach GISel to handle shifts in load addressing modes.
Tue, Jul 23, 9:10 AM · Restricted Project

Mon, Jul 22

paquette created D65119: [GlobalISel][AArch64] Teach GISel to handle shifts in load addressing modes.
Mon, Jul 22, 3:18 PM · Restricted Project

Jul 19 2019

paquette committed rG41affad967d4: [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs (authored by paquette).
[GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs
Jul 19 2019, 6:58 PM
paquette committed rL366625: [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs.
[GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs
Jul 19 2019, 6:55 PM
paquette closed D65024: [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs.
Jul 19 2019, 6:55 PM · Restricted Project
paquette updated the diff for D65024: [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs.

remove unused IR function from test

Jul 19 2019, 4:30 PM · Restricted Project
paquette updated the diff for D65024: [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs.

Address review comments.

Jul 19 2019, 4:28 PM · Restricted Project
paquette added inline comments to D65024: [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs.
Jul 19 2019, 3:56 PM · Restricted Project
paquette added inline comments to D65024: [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs.
Jul 19 2019, 3:56 PM · Restricted Project
paquette created D65024: [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs.
Jul 19 2019, 3:29 PM · Restricted Project

Jul 18 2019

paquette committed rG7a1dcc5ff1da: [GlobalISel][AArch64] Add support for base register + offset register loads (authored by paquette).
[GlobalISel][AArch64] Add support for base register + offset register loads
Jul 18 2019, 2:51 PM
paquette committed rL366503: [GlobalISel][AArch64] Add support for base register + offset register loads.
[GlobalISel][AArch64] Add support for base register + offset register loads
Jul 18 2019, 2:50 PM
paquette closed D64944: [GlobalISel][AArch64] Add support for base register + offset register loads.
Jul 18 2019, 2:50 PM · Restricted Project
paquette created D64944: [GlobalISel][AArch64] Add support for base register + offset register loads.
Jul 18 2019, 1:24 PM · Restricted Project

Jul 10 2019

paquette committed rG7c95925b133f: [GlobalISel][AArch64] Use getOpcodeDef instead of findMIFromReg (authored by paquette).
[GlobalISel][AArch64] Use getOpcodeDef instead of findMIFromReg
Jul 10 2019, 11:49 AM
paquette committed rL365684: [GlobalISel][AArch64] Use getOpcodeDef instead of findMIFromReg.
[GlobalISel][AArch64] Use getOpcodeDef instead of findMIFromReg
Jul 10 2019, 11:49 AM
paquette closed D64520: [GlobalISel][AArch64] Use getOpcodeDef instead of findMIFromReg.
Jul 10 2019, 11:49 AM · Restricted Project
paquette committed rG3132968ae969: [GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can (authored by paquette).
[GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can
Jul 10 2019, 11:46 AM
paquette committed rL365683: [GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can.
[GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can
Jul 10 2019, 11:45 AM
paquette closed D64513: [GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can.
Jul 10 2019, 11:44 AM · Restricted Project
paquette created D64520: [GlobalISel][AArch64] Use getOpcodeDef instead of findMIFromReg.
Jul 10 2019, 11:14 AM · Restricted Project
paquette updated the diff for D64513: [GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can.

Add a testcase showing that we won't crash if we encounter a copy from a physical register.

Jul 10 2019, 10:46 AM · Restricted Project
paquette added inline comments to D64513: [GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can.
Jul 10 2019, 10:34 AM · Restricted Project
paquette created D64513: [GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can.
Jul 10 2019, 10:10 AM · Restricted Project