Page MenuHomePhabricator
People paquette

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (117 w, 6 d)

oh boy

Recent Activity
View All

Today

paquette accepted D58466: [AArch64][GlobalISel] Implement partial support for G_SHUFFLE_VECTOR.

LGTM

Wed, Feb 20, 2:05 PM · Restricted Project
paquette added inline comments to D58466: [AArch64][GlobalISel] Implement partial support for G_SHUFFLE_VECTOR.
Wed, Feb 20, 11:59 AM · Restricted Project
paquette created D58469: [GlobalISel][AArch64] Add selection support for G_EXTRACT_VECTOR_ELT with FPR dest.
Wed, Feb 20, 11:49 AM

Mon, Feb 18

paquette committed rGb53e0f4b8115: [GlobalISel][AArch64] Legalize + select some llvm.ctlz.* intrinsics (authored by paquette).
[GlobalISel][AArch64] Legalize + select some llvm.ctlz.* intrinsics
Mon, Feb 18, 3:36 PM
paquette committed rL354299: [GlobalISel][AArch64] Legalize + select some llvm.ctlz.* intrinsics.
[GlobalISel][AArch64] Legalize + select some llvm.ctlz.* intrinsics
Mon, Feb 18, 3:35 PM
paquette closed D58155: [GlobalISel][AArch64] Legalize + select some llvm.ctlz.* intrinsics.
Mon, Feb 18, 3:35 PM · Restricted Project
paquette updated the diff for D58155: [GlobalISel][AArch64] Legalize + select some llvm.ctlz.* intrinsics.

Adding support for scalarizing was 2 LOC, so meh, let's just do it here.

Mon, Feb 18, 3:25 PM · Restricted Project
paquette accepted D58088: [adt] Add raw_pointer_iterator to iterate over std::unique_ptr<> collections.

Since it doesn't look like there's really any way to unify these right now, I think this LGTM.

Mon, Feb 18, 2:38 PM · Restricted Project
paquette accepted D58262: GlobalISel: Verify g_insert.

LGTM

Mon, Feb 18, 2:11 PM

Wed, Feb 13

paquette accepted D58217: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir.

Oh no! LGTM

Wed, Feb 13, 4:30 PM · Restricted Project
paquette added inline comments to D58073: [GlobalISel][NFC]: Add interface to reserve memory in GISelWorklist.
Wed, Feb 13, 1:30 PM · Restricted Project
paquette added inline comments to D58136: GlobalISel: Implement moreElementsVector for g_insert results.
Wed, Feb 13, 10:00 AM
paquette accepted D58136: GlobalISel: Implement moreElementsVector for g_insert results.

LGTM with question

Wed, Feb 13, 9:40 AM
paquette accepted D58124: GlobalISel: Implement moreElementsVector for G_EXTRACT source.

LGTM

Wed, Feb 13, 9:37 AM
paquette accepted D58127: GlobalISel: Implement moreElementsVector for select.

LGTM

Wed, Feb 13, 9:33 AM

Tue, Feb 12

paquette created D58155: [GlobalISel][AArch64] Legalize + select some llvm.ctlz.* intrinsics.
Tue, Feb 12, 3:53 PM · Restricted Project
paquette added a comment to D58088: [adt] Add raw_pointer_iterator to iterate over std::unique_ptr<> collections.

Hmm, It might be nice to have this as a specialization of pointer_iterator if possible.

Tue, Feb 12, 11:28 AM · Restricted Project
paquette created D58138: [GlobalISel][NFC] Gardening: Factor out more intrinsics into simple intrinsics.
Tue, Feb 12, 10:29 AM
paquette committed rGacbb7ca26c65: [GlobalISel][NFC] Gardening: Make translateSimpleUnaryIntrinsic general (authored by paquette).
[GlobalISel][NFC] Gardening: Make translateSimpleUnaryIntrinsic general
Tue, Feb 12, 9:40 AM
paquette committed rL353863: [GlobalISel][NFC] Gardening: Make translateSimpleUnaryIntrinsic general.
[GlobalISel][NFC] Gardening: Make translateSimpleUnaryIntrinsic general
Tue, Feb 12, 9:38 AM
paquette closed D58079: [GlobalISel][NFC] Gardening: Make translateSimpleUnaryIntrinsic general.
Tue, Feb 12, 9:38 AM · Restricted Project
paquette committed rG0e71e73faacf: [GlobalISel][AArch64] Select llvm.bswap* for non-vector types (authored by paquette).
[GlobalISel][AArch64] Select llvm.bswap* for non-vector types
Tue, Feb 12, 9:30 AM
paquette committed rL353861: [GlobalISel][AArch64] Select llvm.bswap* for non-vector types.
[GlobalISel][AArch64] Select llvm.bswap* for non-vector types
Tue, Feb 12, 9:29 AM
paquette closed D58081: [GlobalISel][AArch64] Select llvm.bswap* for non-vector types.
Tue, Feb 12, 9:29 AM · Restricted Project
paquette updated the diff for D58081: [GlobalISel][AArch64] Select llvm.bswap* for non-vector types.

Updating diff to address comments on test before committing

Tue, Feb 12, 9:26 AM · Restricted Project

Mon, Feb 11

paquette created D58081: [GlobalISel][AArch64] Select llvm.bswap* for non-vector types.
Mon, Feb 11, 3:44 PM · Restricted Project
paquette created D58079: [GlobalISel][NFC] Gardening: Make translateSimpleUnaryIntrinsic general.
Mon, Feb 11, 3:12 PM · Restricted Project
paquette added inline comments to D58073: [GlobalISel][NFC]: Add interface to reserve memory in GISelWorklist.
Mon, Feb 11, 2:09 PM · Restricted Project
paquette accepted D57724: GlobalISel: Verify G_EXTRACT.

LGTM

Mon, Feb 11, 11:02 AM
paquette committed rGe57fe23f702f: [AArch64][GlobalISel] Add isel support for a couple vector exts/truncs (authored by paquette).
[AArch64][GlobalISel] Add isel support for a couple vector exts/truncs
Mon, Feb 11, 10:58 AM
paquette committed rL353732: [AArch64][GlobalISel] Add isel support for a couple vector exts/truncs.
[AArch64][GlobalISel] Add isel support for a couple vector exts/truncs
Mon, Feb 11, 10:58 AM
paquette closed D57832: [AArch64][GlobalSel] Add isel support for a couple vector exts/truncs.
Mon, Feb 11, 10:58 AM · Restricted Project
paquette retitled D57832: [AArch64][GlobalSel] Add isel support for a couple vector exts/truncs from [AArch64][GlobalISe] Add isel support for a couple vector exts/truncs to [AArch64][GlobalSel] Add isel support for a couple vector exts/truncs.
Mon, Feb 11, 10:44 AM · Restricted Project
paquette updated the diff for D57832: [AArch64][GlobalSel] Add isel support for a couple vector exts/truncs.

Rebased after removing redundant IR from existing .mir test

Mon, Feb 11, 10:43 AM · Restricted Project
paquette committed rG828de9fc4b6f: [GlobalISel][AArch64] NFC: Remove unnecessary IR from select-fp-casts.mir (authored by paquette).
[GlobalISel][AArch64] NFC: Remove unnecessary IR from select-fp-casts.mir
Mon, Feb 11, 10:42 AM
paquette added inline comments to D57832: [AArch64][GlobalSel] Add isel support for a couple vector exts/truncs.
Mon, Feb 11, 10:41 AM · Restricted Project
paquette committed rL353731: [GlobalISel][AArch64] NFC: Remove unnecessary IR from select-fp-casts.mir.
[GlobalISel][AArch64] NFC: Remove unnecessary IR from select-fp-casts.mir
Mon, Feb 11, 10:41 AM
paquette updated the diff for D57832: [AArch64][GlobalSel] Add isel support for a couple vector exts/truncs.

Updated existing .mir test instead of adding a .ll test

Mon, Feb 11, 10:29 AM · Restricted Project
paquette committed rGebdb021031a9: [GlobalISel][AArch64] Select G_FFLOOR (authored by paquette).
[GlobalISel][AArch64] Select G_FFLOOR
Mon, Feb 11, 9:23 AM
paquette committed rL353722: [GlobalISel][AArch64] Select G_FFLOOR.
[GlobalISel][AArch64] Select G_FFLOOR
Mon, Feb 11, 9:22 AM
paquette closed D57486: [GlobalISel][AArch64] Select G_FFLOOR.
Mon, Feb 11, 9:22 AM · Restricted Project
paquette committed rGf472f31876e0: Recommit "[GlobalISel] Add IRTranslator support for G_FFLOOR" (authored by paquette).
Recommit "[GlobalISel] Add IRTranslator support for G_FFLOOR"
Mon, Feb 11, 9:17 AM
paquette committed rL353720: Recommit "[GlobalISel] Add IRTranslator support for G_FFLOOR".
Recommit "[GlobalISel] Add IRTranslator support for G_FFLOOR"
Mon, Feb 11, 9:17 AM

Fri, Feb 8

paquette added a comment to D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR.

Relanded in r353589. This works fine after r353586.

Fri, Feb 8, 4:39 PM · Restricted Project
paquette committed rGc230c13d4bcb: Recommit "[GlobalISel] Introduce a generic floating point floor opcode… (authored by paquette).
Recommit "[GlobalISel] Introduce a generic floating point floor opcode…
Fri, Feb 8, 4:38 PM
paquette committed rL353589: Recommit "[GlobalISel] Introduce a generic floating point floor opcode….
Recommit "[GlobalISel] Introduce a generic floating point floor opcode…
Fri, Feb 8, 4:37 PM
paquette added a comment to D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR.

I think that this is safe to recommit after the changes in https://reviews.llvm.org/D57980.

Fri, Feb 8, 4:32 PM · Restricted Project
paquette committed rG1ed1dd6d9548: [GlobalISel] Skip patterns that define complex suboperands twice instead of… (authored by paquette).
[GlobalISel] Skip patterns that define complex suboperands twice instead of…
Fri, Feb 8, 4:29 PM
paquette committed rL353586: [GlobalISel] Skip patterns that define complex suboperands twice instead of….
[GlobalISel] Skip patterns that define complex suboperands twice instead of…
Fri, Feb 8, 4:29 PM
paquette closed D57980: [GlobalISel] Skip patterns that define complex suboperands twice instead of dying.
Fri, Feb 8, 4:29 PM · Restricted Project
paquette created D57980: [GlobalISel] Skip patterns that define complex suboperands twice instead of dying.
Fri, Feb 8, 2:41 PM · Restricted Project

Wed, Feb 6

paquette created D57832: [AArch64][GlobalSel] Add isel support for a couple vector exts/truncs.
Wed, Feb 6, 11:22 AM · Restricted Project
paquette committed rGe288c526f1f4: [GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics (authored by paquette).
[GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics
Wed, Feb 6, 9:26 AM
paquette committed rL353316: [GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics.
[GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics
Wed, Feb 6, 9:26 AM
paquette closed D57774: [GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics.
Wed, Feb 6, 9:26 AM · Restricted Project
paquette updated the diff for D57774: [GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics.

Update diff to address nit before committing

Wed, Feb 6, 9:25 AM · Restricted Project

Tue, Feb 5

paquette updated the diff for D57774: [GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics.

Use a function containing a switch instead of a map, and move it all into IRTranslator.cpp.

Tue, Feb 5, 1:09 PM · Restricted Project
paquette accepted D57773: GlobalISel: Verify G_GEP.

LGTM

Tue, Feb 5, 11:41 AM
paquette added inline comments to D57774: [GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics.
Tue, Feb 5, 11:41 AM · Restricted Project
paquette created D57774: [GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics.
Tue, Feb 5, 11:32 AM · Restricted Project

Mon, Feb 4

paquette accepted D57526: MachineVerifier: Move verification of G_* instructions to function.

LGTM

Mon, Feb 4, 3:15 PM
paquette added inline comments to D57526: MachineVerifier: Move verification of G_* instructions to function.
Mon, Feb 4, 2:53 PM
paquette accepted D57536: GlobalISel: Verify g_select.

LGTM

Mon, Feb 4, 2:22 PM
paquette accepted D57685: MIR: Validate LLT types when parsing.

This seems like a pretty good idea... LGTM, aside from the one nit.

Mon, Feb 4, 2:03 PM
paquette added a comment to D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR.
In D57484#1383408, @arsenm wrote:
In D57484#1383395, @paquette wrote:

@arsenm, adding this opcode breaks AMDGPU somehow. Do you have any idea why that might be?

Breaks what?

Mon, Feb 4, 9:44 AM · Restricted Project
paquette committed rG92834ffcbf83: Revert "[GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR" (authored by paquette).
Revert "[GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR"
Mon, Feb 4, 9:34 AM
paquette updated subscribers of D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR.

@arsenm, adding this opcode breaks AMDGPU somehow. Do you have any idea why that might be?

Mon, Feb 4, 9:34 AM · Restricted Project
paquette committed rG834bded9d6d5: Revert "[GlobalISel] Add IRTranslator support for G_FFLOOR" (authored by paquette).
Revert "[GlobalISel] Add IRTranslator support for G_FFLOOR"
Mon, Feb 4, 9:34 AM
paquette committed rL353065: Revert "[GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR".
Revert "[GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR"
Mon, Feb 4, 9:34 AM
paquette committed rL353064: Revert "[GlobalISel] Add IRTranslator support for G_FFLOOR".
Revert "[GlobalISel] Add IRTranslator support for G_FFLOOR"
Mon, Feb 4, 9:33 AM
paquette committed rG73158e72012c: [GlobalISel] Add IRTranslator support for G_FFLOOR (authored by paquette).
[GlobalISel] Add IRTranslator support for G_FFLOOR
Mon, Feb 4, 9:18 AM
paquette committed rL353058: [GlobalISel] Add IRTranslator support for G_FFLOOR.
[GlobalISel] Add IRTranslator support for G_FFLOOR
Mon, Feb 4, 9:18 AM
paquette closed D57485: [GlobalISel] Add IRTranslator support for G_FFLOOR.
Mon, Feb 4, 9:18 AM · Restricted Project
paquette committed rG616a1fb4920f: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR (authored by paquette).
[GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR
Mon, Feb 4, 9:12 AM
paquette committed rL353057: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR.
[GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR
Mon, Feb 4, 9:10 AM
paquette closed D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR.
Mon, Feb 4, 9:10 AM · Restricted Project

Wed, Jan 30

paquette added a child revision for D57485: [GlobalISel] Add IRTranslator support for G_FFLOOR: D57486: [GlobalISel][AArch64] Select G_FFLOOR.
Wed, Jan 30, 4:25 PM · Restricted Project
paquette added a child revision for D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR: D57486: [GlobalISel][AArch64] Select G_FFLOOR.
Wed, Jan 30, 4:25 PM · Restricted Project
paquette added parent revisions for D57486: [GlobalISel][AArch64] Select G_FFLOOR: D57485: [GlobalISel] Add IRTranslator support for G_FFLOOR, D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR.
Wed, Jan 30, 4:25 PM · Restricted Project
paquette created D57486: [GlobalISel][AArch64] Select G_FFLOOR.
Wed, Jan 30, 4:25 PM · Restricted Project
paquette added a parent revision for D57485: [GlobalISel] Add IRTranslator support for G_FFLOOR: D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR.
Wed, Jan 30, 4:22 PM · Restricted Project
paquette added a child revision for D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR: D57485: [GlobalISel] Add IRTranslator support for G_FFLOOR.
Wed, Jan 30, 4:22 PM · Restricted Project
paquette created D57485: [GlobalISel] Add IRTranslator support for G_FFLOOR.
Wed, Jan 30, 4:21 PM · Restricted Project
paquette created D57484: [GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR.
Wed, Jan 30, 4:21 PM · Restricted Project
paquette committed rL352692: [GlobalISel][AArch64] Select G_FEXP.
[GlobalISel][AArch64] Select G_FEXP
Wed, Jan 30, 3:46 PM
paquette closed D57483: [GlobalISel][AArch64] Select G_FEXP.

Committed in r352692

Wed, Jan 30, 3:46 PM
paquette created D57483: [GlobalISel][AArch64] Select G_FEXP.
Wed, Jan 30, 3:40 PM
paquette closed D57418: [GlobalISel][AArch64] Select G_FABS.

Committed in r352684

Wed, Jan 30, 2:55 PM
paquette committed rL352684: [GlobalISel][AArch64] Select G_FABS.
[GlobalISel][AArch64] Select G_FABS
Wed, Jan 30, 2:54 PM
paquette accepted D57289: GlobalISel: Implement narrowScalar for bswap.

LGTM

Wed, Jan 30, 2:39 PM
paquette accepted D57122: GlobalISel: Use helper function for MMO splitting.

LGTM

Wed, Jan 30, 1:42 PM
paquette added inline comments to D57310: GlobalISel: Consolidate load/store legalization.
Wed, Jan 30, 1:38 PM
paquette accepted D57137: MIR: Reject non-power-of-2 alignments in MMO parsing.

Seems reasonable, LGTM

Wed, Jan 30, 1:20 PM
paquette committed rL352673: [GlobalISel][AArch64] Add instruction selection support for @llvm.log2.
[GlobalISel][AArch64] Add instruction selection support for @llvm.log2
Wed, Jan 30, 1:17 PM
paquette closed D57357: [GlobalISel][AArch64] Add instruction selection support for @llvm.log2.

Committed in r352673

Wed, Jan 30, 1:17 PM
paquette closed D57361: [GlobalISel][AArch64] Add instruction selection support for @llvm.sqrt.

Thanks! Committed in r352671.

Wed, Jan 30, 1:04 PM
paquette committed rL352671: [GlobalISel][AArch64] Add instruction selection support for @llvm.sqrt.
[GlobalISel][AArch64] Add instruction selection support for @llvm.sqrt
Wed, Jan 30, 1:04 PM
paquette closed D57360: [GlobalISel] Add IRTranslator support for @llvm.sqrt -> G_FSQRT.

Thanks! Committed in r352670.

Wed, Jan 30, 12:58 PM
paquette committed rL352670: [GlobalISel] Add IRTranslator support for @llvm.sqrt -> G_FSQRT.
[GlobalISel] Add IRTranslator support for @llvm.sqrt -> G_FSQRT
Wed, Jan 30, 12:58 PM
paquette added a comment to rL352668: [GlobalISel] Introduce a G_FSQRT generic instruction.

review: https://reviews.llvm.org/D57359

Wed, Jan 30, 12:52 PM