Do the outliner changes need to be a part of this patch? Or can you split the outliner changes out into a separate patch, and then add that separate patch as a child of this one?

May 16 2022, 5:47 PM · Restricted Project, Restricted Project, Restricted Project

May 13 2022

paquette accepted D125584: [GlobalIsel] Fix fallback if stack protector isn't supported..

LGTM, thanks!

May 13 2022, 1:51 PM · Restricted Project, Restricted Project

paquette accepted D125516: [GlobalISel] Handle constant splat in funnel shift combine.

Aside from @foad's one comment, I think this looks fine.

May 13 2022, 9:57 AM · Restricted Project, Restricted Project

May 12 2022

paquette accepted D117758: [GlobalISel] Change ConstantFoldVectorBinop to return vector of APInt.

I think this seems reasonable? Looks like a compile time improvement too, maybe?

May 12 2022, 10:07 AM · Restricted Project, Restricted Project

paquette accepted D125472: Fix an or+and miscompile w/ GlobalISel.

LGTM

May 12 2022, 10:00 AM · Restricted Project, Restricted Project

May 6 2022

paquette accepted D124777: [IROutliner] Accommodate PHINodes with entry outside region for numbering.

May 6 2022, 4:15 PM · Restricted Project, Restricted Project

May 4 2022

paquette added inline comments to D124777: [IROutliner] Accommodate PHINodes with entry outside region for numbering.

May 4 2022, 1:11 PM · Restricted Project, Restricted Project

May 3 2022

paquette accepted D124882: Fix zero-width bitfield extracts to emit 0.

LGTM

May 3 2022, 2:37 PM · Restricted Project, Restricted Project

May 2 2022

paquette accepted D124775: [IRSim] Removing check that caused early matching of commutative instructions.

I think this is fine. I have a couple nits on the comments, but I won't hold up review over them.

May 2 2022, 10:41 AM · Restricted Project, Restricted Project

Apr 22 2022

paquette accepted D123140: TableGen/GlobalISel: Make address space/align predicates consistent.

LGTM

Apr 22 2022, 10:23 AM · Restricted Project, Restricted Project

Apr 21 2022

paquette accepted D123860: GlobalISel: Relax handling of G_ASSERT_* with source register classes.

LGTM

Apr 21 2022, 6:05 PM · Restricted Project, Restricted Project

Apr 18 2022

paquette accepted D123903: [IRSim] Ignore Debug instructions with constructing canonical numbering for basic blocks.

I think that debug info handling might be a good argument for splitting the similarity identifier into a similarity finding version + outlining version. The outliner needs to be considerate about what it does to debug info, but the similarity identifier doesn't. Someone very well may want to ask questions about debug info similarity in the future.

Apr 18 2022, 10:36 AM · Restricted Project, Restricted Project

Apr 15 2022

paquette accepted D123507: AArch64/GlobalISel: Remove asserts on copy instructions.

LGTM

Apr 15 2022, 4:22 PM · Restricted Project, Restricted Project

paquette accepted D123555: AArch64/GlobalISel: Remove some null checks for getVRegDef.

LGTM

Apr 15 2022, 4:09 PM · Restricted Project, Restricted Project

paquette accepted D123554: GlobalISel: Add LLT helper to multiply vector sizes.

LGTM

Apr 15 2022, 1:40 PM · Restricted Project, Restricted Project

paquette accepted D123561: GlobalISel: Add LegalizeMutations to help use More/FewerElements.

LGTM

Apr 15 2022, 1:31 PM · Restricted Project, Restricted Project

paquette added inline comments to D123554: GlobalISel: Add LLT helper to multiply vector sizes.

Apr 15 2022, 1:30 PM · Restricted Project, Restricted Project

paquette added inline comments to D123860: GlobalISel: Relax handling of G_ASSERT_* with source register classes.

Apr 15 2022, 1:20 PM · Restricted Project, Restricted Project

paquette added a comment to D121343: Update benchmarks.

@mtrofin Everything these bots does is sets up a fresh environment each time, so there ought to be nothing left over from previous runs. Everything is done in a new directory each time IIRC, so we get a clean build every time.

Apr 15 2022, 1:07 PM · Restricted Project

Apr 14 2022

paquette added a comment to D121343: Update benchmarks.

This is also hitting the x86-64 macOS bots 😢

Apr 14 2022, 3:58 PM · Restricted Project

paquette accepted D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..

You know what, I think I wonked something up somehow on my end, because I rebuilt + reran the test suite overnight with -Oz + -O2 and it seems fine.

Apr 14 2022, 10:10 AM · Restricted Project, Restricted Project

Apr 13 2022

paquette added a comment to D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..

I applied this patch locally and tried to run the test suite at -O2 with it with asserts enabled. It fell over building fpcmp.

Apr 13 2022, 6:27 PM · Restricted Project, Restricted Project

paquette accepted D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..

I think this is fine.

Apr 13 2022, 2:31 PM · Restricted Project, Restricted Project

Apr 12 2022

paquette added a comment to D123561: GlobalISel: Add LegalizeMutations to help use More/FewerElements.

Ah. There are no C++ unit tests that can be updated without an immediate use case?

Apr 12 2022, 10:21 AM · Restricted Project, Restricted Project

paquette accepted D123556: AArch64/GlobalISel: Reduce use of getMinClassForRegBank.

LGTM

Apr 12 2022, 10:18 AM · Restricted Project, Restricted Project

paquette accepted D123560: GlobalISel: Implement MoreElements for select of vector conditions.

LGTM

Apr 12 2022, 10:15 AM · Restricted Project, Restricted Project

paquette accepted D123563: GlobalISel: Fix lowerSelect handling of boolean high bits.

LGTM

Apr 12 2022, 10:14 AM · Restricted Project, Restricted Project

paquette added a comment to D123561: GlobalISel: Add LegalizeMutations to help use More/FewerElements.

Testcase?

Apr 12 2022, 10:08 AM · Restricted Project, Restricted Project

paquette accepted D123620: AArch64/GlobalISel: Stop using legal s1 values.

I think this is a good cleanup. Even if we get some slightly worse codegen at -O0, it simplifies the selector + legalizer. LGTM

Apr 12 2022, 10:06 AM · Restricted Project, Restricted Project

paquette accepted D123619: AArch64/GlobalISel: Remove pointless s1 legalize rules.

LGTM

Apr 12 2022, 9:52 AM · Restricted Project, Restricted Project

Apr 11 2022

paquette added a comment to D123518: GlobalISel: memSizeNotByteSizePow2 legality helper.

Oh, I see

Apr 11 2022, 4:05 PM · Restricted Project, Restricted Project

paquette accepted D123518: GlobalISel: memSizeNotByteSizePow2 legality helper.

Also small bug fix that prevented the correct insertion of G_ASSERT_ZEXT in the AArch64 use case.

Apr 11 2022, 3:40 PM · Restricted Project, Restricted Project

paquette added inline comments to D123518: GlobalISel: memSizeNotByteSizePow2 legality helper.

Apr 11 2022, 2:52 PM · Restricted Project, Restricted Project

paquette accepted D123529: GlobalISel: Implement computeKnownBits for overflow bool results.

LGTM

Apr 11 2022, 2:50 PM · Restricted Project, Restricted Project

Apr 5 2022

paquette committed rG6c9bc2dd1ca7: [GlobalISel] NFC: Add test coverage for s144 and s142 (authored by paquette).

[GlobalISel] NFC: Add test coverage for s144 and s142

Apr 5 2022, 3:27 PM · Restricted Project, Restricted Project

paquette committed rG30922d62f420: [GlobalISel] NFC: Add some test coverage for s158 (authored by paquette).

[GlobalISel] NFC: Add some test coverage for s158

Apr 5 2022, 3:12 PM · Restricted Project, Restricted Project

paquette committed rG5830afa53252: [GlobalISel] NFC: Regen some tests + improve test coverage for wide even types (authored by paquette).

[GlobalISel] NFC: Regen some tests + improve test coverage for wide even types

Apr 5 2022, 12:14 PM · Restricted Project, Restricted Project

Mar 30 2022

paquette committed rGce6e280c335c: Recommit "[Docs] Add documentation for llvm-remark-size-diff" (authored by paquette).

Recommit "[Docs] Add documentation for llvm-remark-size-diff"

Mar 30 2022, 1:40 PM · Restricted Project, Restricted Project

paquette added a reverting change for rGbdea2afc8c16: [Docs] Add documentation for llvm-remark-size-diff: rG73138d280d91: Revert "[Docs] Add documentation for llvm-remark-size-diff".

Mar 30 2022, 1:34 PM · Restricted Project, Restricted Project

paquette committed rG73138d280d91: Revert "[Docs] Add documentation for llvm-remark-size-diff" (authored by paquette).

Revert "[Docs] Add documentation for llvm-remark-size-diff"

Mar 30 2022, 1:34 PM · Restricted Project, Restricted Project

paquette added a reverting change for D122744: [Docs] Add documentation for llvm-remark-size-diff: rG73138d280d91: Revert "[Docs] Add documentation for llvm-remark-size-diff".

Mar 30 2022, 1:34 PM · Restricted Project, Restricted Project

paquette committed rGbdea2afc8c16: [Docs] Add documentation for llvm-remark-size-diff (authored by paquette).

[Docs] Add documentation for llvm-remark-size-diff

Mar 30 2022, 1:27 PM · Restricted Project, Restricted Project

paquette closed D122744: [Docs] Add documentation for llvm-remark-size-diff.

Mar 30 2022, 1:27 PM · Restricted Project, Restricted Project

paquette requested review of D122744: [Docs] Add documentation for llvm-remark-size-diff.

Mar 30 2022, 9:49 AM · Restricted Project, Restricted Project

Mar 28 2022

paquette accepted D122559: [AArch64][GlobalISel] Add new MOVI pattern for fp constants.

Code looks equivalent to the fpimm32SIMDModImmType4XForm in AArch64InstrFormats.td, which looks fine to me.

Mar 28 2022, 10:17 AM · Restricted Project, Restricted Project

Mar 25 2022

paquette accepted D122206: [IROutliner] Ensure that phi values that are passed in as arguments are remapped as arguments.

LGTM with nit on a comment

Mar 25 2022, 9:38 AM · Restricted Project, Restricted Project

Mar 23 2022

paquette added inline comments to D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..

Mar 23 2022, 3:45 PM · Restricted Project, Restricted Project

Mar 16 2022

paquette accepted D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not.

I think after the one nit is fixed, this is good to go.

Mar 16 2022, 10:36 AM · Restricted Project, Restricted Project

Mar 14 2022

paquette added a comment to D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not.

Also, which GitHub issue is this associated with?

Mar 14 2022, 3:20 PM · Restricted Project, Restricted Project

paquette added inline comments to D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not.

Mar 14 2022, 11:03 AM · Restricted Project, Restricted Project

paquette accepted D121310: [IROutliner] IR Outliner can mix up order of incoming values when compressing phi nodes if contain the same values.

LGTM

Mar 14 2022, 10:58 AM · Restricted Project, Restricted Project

paquette added a comment to D120869: [IROutliner] Strip loop info when moving code into outlined function..

This testcase is better, but there are still lots of instructions which aren't necessary.

Mar 14 2022, 10:11 AM · Restricted Project, Restricted Project

paquette accepted D121567: [IROutliner] Do not outline from regions that are marked with OptNone.

FWIW I think we could shave off some compile time if we could make some sort of interface to the similarity identifier that tells it "this is for outlining". That may just be a subclass or something of the similarity identifier.

Mar 14 2022, 9:57 AM · Restricted Project, Restricted Project

Mar 9 2022

paquette added inline comments to D121310: [IROutliner] IR Outliner can mix up order of incoming values when compressing phi nodes if contain the same values.

Mar 9 2022, 11:43 AM · Restricted Project, Restricted Project

paquette added inline comments to D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not.

Mar 9 2022, 11:33 AM · Restricted Project, Restricted Project

paquette accepted D121312: [IROutliner] Avoid reusing PHINodes that have already been matched when merging outlined functions' phi node blocks.

LGTM

Mar 9 2022, 11:21 AM · Restricted Project, Restricted Project

paquette accepted D121313: [IROutliner] Fix miscounting of exit paths when a single phi node used as an output for several outlined regions..

Mar 9 2022, 11:19 AM · Restricted Project, Restricted Project

paquette added a comment to D120867: [IROutliner] Adding support to properly handle musttail, swifttailcc and tailcc.

Yeah, it looks like there's a clang attribute, but it isn't used anywhere in the LLVM test suite.

Mar 9 2022, 11:15 AM · Restricted Project, Restricted Project

paquette added a comment to D121296: [GlobalIsel][X86] Legalization of G_IS_FPCLASS.

Do you think you could split this into two patches?

Mar 9 2022, 10:25 AM · Restricted Project, Restricted Project

Mar 8 2022

paquette added a comment to D121085: [AArch64][GlobalISel] Implement G_SELECT translate to min/max/abs.

IIRC I was working on something similar in the combiner but for FP stuff (D116702)

Mar 8 2022, 10:31 AM · Restricted Project, Restricted Project

Mar 7 2022

paquette committed rG355ad3a3cdb3: Add JSON output option to llvm-remark-size-diff (authored by paquette).

Add JSON output option to llvm-remark-size-diff

Mar 7 2022, 4:54 PM · Restricted Project

paquette closed D121173: Add JSON output option to llvm-remark-size-diff.

Mar 7 2022, 4:54 PM · Restricted Project, Restricted Project

paquette added inline comments to D121173: Add JSON output option to llvm-remark-size-diff.

Mar 7 2022, 4:45 PM · Restricted Project, Restricted Project

paquette requested review of D121173: Add JSON output option to llvm-remark-size-diff.

Mar 7 2022, 3:58 PM · Restricted Project, Restricted Project

Mar 4 2022

paquette added a comment to D120867: [IROutliner] Adding support to properly handle musttail, swifttailcc and tailcc.

I'm not sure how often musttail/tailcc appears in the LLVM test suite, but this didn't introduce any asserts there, and all of the tests pass.

Mar 4 2022, 12:46 PM · Restricted Project, Restricted Project

paquette added a comment to D120869: [IROutliner] Strip loop info when moving code into outlined function..

Just verified that this resolves the crash in the benchmark on my end.

Mar 4 2022, 9:56 AM · Restricted Project, Restricted Project

Mar 3 2022

paquette added a comment to D120867: [IROutliner] Adding support to properly handle musttail, swifttailcc and tailcc.

Do you think you could add a statistic which counts the number of tail calls emitted? And maybe some debug output that says that something will be handled as a tail call?

Mar 3 2022, 9:48 AM · Restricted Project, Restricted Project

paquette accepted D120786: [IRSim] Removing length check so first instruction in module is included.

LGTM

Mar 3 2022, 9:15 AM · Restricted Project, Restricted Project

paquette accepted D120733: [IRSim][IROutliner] Ignore outlined sections that include musttail calls .

LGTM

Mar 3 2022, 9:14 AM · Restricted Project, Restricted Project

paquette accepted D120868: [IROutliner] handle functions that do not contain an exit path.

I am a little worried about the code extractor's assumptions, at least wrt noreturn functions (should the code extractor have a special case for noreturn?). But I think that should be handled in the code extractor, not here.

Mar 3 2022, 9:14 AM · Restricted Project, Restricted Project