Page MenuHomePhabricator

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (218 w, 5 d)

oh boy

Recent Activity

Yesterday

paquette committed rGf36007e81101: [GlobalISel] Implement computeKnownBits for G_SEXT_INREG (authored by paquette).
[GlobalISel] Implement computeKnownBits for G_SEXT_INREG
Tue, Jan 26, 3:08 PM
paquette closed D95484: [GlobalISel] Implement computeKnownBits for G_SEXT_INREG.
Tue, Jan 26, 3:08 PM · Restricted Project
paquette requested review of D95484: [GlobalISel] Implement computeKnownBits for G_SEXT_INREG.
Tue, Jan 26, 2:58 PM · Restricted Project
paquette accepted D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.

LGTM with test nit

Tue, Jan 26, 10:01 AM · Restricted Project
paquette added inline comments to D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.
Tue, Jan 26, 9:59 AM · Restricted Project
paquette added inline comments to D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Tue, Jan 26, 9:34 AM · Restricted Project

Mon, Jan 25

paquette accepted D95324: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE.

LGTM aside from nit

Mon, Jan 25, 10:53 AM · Restricted Project
paquette accepted D95323: [Test][AArch64] Move overflow add/sub tests to their own file. NFC.
Mon, Jan 25, 9:47 AM · Restricted Project

Thu, Jan 21

paquette accepted D92524: [IRSimilarity] Strip out the findSimilarity call from the constructor.

LGTM

Thu, Jan 21, 2:39 PM · Restricted Project

Wed, Jan 20

paquette accepted D92532: [IRSimilarity] Don't copy the Mapper for createCandidatesFromSuffixTree.

Yeah this seems fine

Wed, Jan 20, 6:02 PM · Restricted Project
paquette requested review of D95107: [AArch64][GlobalISel] Allow vector store legalization into 128-bit-wide types.
Wed, Jan 20, 5:40 PM · Restricted Project
paquette accepted D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it.

LGTM, thanks!

Wed, Jan 20, 12:05 PM · Restricted Project
paquette added a comment to D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it.

Can you add selection tests for s32 and s64?

Wed, Jan 20, 10:05 AM · Restricted Project
paquette accepted D95034: [AArch64][GlobalISel] Implement widenScalar for signed overflow.

LGTM

Wed, Jan 20, 9:50 AM · Restricted Project
paquette accepted D95035: [GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method.

LGTM

Wed, Jan 20, 9:44 AM · Restricted Project

Tue, Jan 19

paquette added a comment to D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.

Hopefully should be fixed by cbf52463599c860243d29877021fcdfcd9d46553

Tue, Jan 19, 10:43 AM · Restricted Project
paquette committed rGcbf52463599c: Fix buildbot after cfc60730179042a93cb9cb338982e71d20707a24 (authored by paquette).
Fix buildbot after cfc60730179042a93cb9cb338982e71d20707a24
Tue, Jan 19, 10:40 AM
paquette committed rGcfc607301790: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load (authored by paquette).
[GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load
Tue, Jan 19, 10:25 AM
paquette closed D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.
Tue, Jan 19, 10:24 AM · Restricted Project
paquette added a reviewer for D94936: [AArch64][GlobalISel] Instruction selection for add/sub with carry-in: aemerson.
Tue, Jan 19, 10:00 AM · Restricted Project
paquette added a comment to D94936: [AArch64][GlobalISel] Instruction selection for add/sub with carry-in.

Do you think you could split this into 3 patches, one for each commit?

Tue, Jan 19, 10:00 AM · Restricted Project

Fri, Jan 15

paquette updated the diff for D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.
  • Add a LLT variant of allowsMemoryAccess. This is the same as the DAGCombiner check.
  • Add a testcase that shows that when we have strict-align, the combine only fires when the resulting load will be aligned.
Fri, Jan 15, 4:25 PM · Restricted Project
paquette committed rGcc90d41945f6: [MIPatternMatch] Add m_OneNonDBGUse (authored by paquette).
[MIPatternMatch] Add m_OneNonDBGUse
Fri, Jan 15, 10:19 AM
paquette closed D94705: [MIPatternMatch] Add m_OneNonDBGUse.
Fri, Jan 15, 10:19 AM · Restricted Project

Thu, Jan 14

paquette accepted D94701: [AArch64][GlobalISel] Assign FPR banks to loads which are used by integer->float conversions..

LGTM

Thu, Jan 14, 12:19 PM · Restricted Project
paquette accepted D94702: [AArch64][GlobalISel] Add selection support for fpr bank source variants of G_SITOFP and G_UITOFP..

LGTM

Thu, Jan 14, 12:15 PM · Restricted Project
paquette updated the diff for D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.

Use m_OneNonDBGUse (D94705)

Thu, Jan 14, 12:12 PM · Restricted Project
paquette requested review of D94705: [MIPatternMatch] Add m_OneNonDBGUse.
Thu, Jan 14, 12:05 PM · Restricted Project
paquette added a comment to D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.

We also need to check for the strict-align function attribute before we generate wider loads.

Thu, Jan 14, 12:02 PM · Restricted Project
paquette added a comment to D94641: [AArch64][GlobalISel] Use wzr/xzr for FP stores of zero.

It it possible to extend the existing combine in prelegalizer combiner to handle this too? Or will that cause us to still miss some cases?

Thu, Jan 14, 11:36 AM · Restricted Project
paquette added a comment to D94641: [AArch64][GlobalISel] Use wzr/xzr for FP stores of zero.

A better, more general solution might be to move some of the G_FCONSTANT selection code into the legalizer or post-legalizer lowering. That might make some of the selection code which relies on seeing a G_FCONSTANT more difficult to get right though.

Thu, Jan 14, 10:04 AM · Restricted Project
paquette added a comment to D94641: [AArch64][GlobalISel] Use wzr/xzr for FP stores of zero.

Why is this in lowering instead of combine?

Thu, Jan 14, 9:52 AM · Restricted Project

Wed, Jan 13

paquette requested review of D94641: [AArch64][GlobalISel] Use wzr/xzr for FP stores of zero.
Wed, Jan 13, 4:26 PM · Restricted Project
paquette added inline comments to D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.
Wed, Jan 13, 11:27 AM · Restricted Project

Tue, Jan 12

paquette updated the diff for D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.

Fix a bug in isPredecessor exposed by this patch and add a testcase for it. It wasn't able to handle the case where DefMI is the first instruction in the block.

Tue, Jan 12, 3:28 PM · Restricted Project
paquette committed rGddcb0aae8b0d: [MIPatternMatch] Add matcher for G_PTR_ADD (authored by paquette).
[MIPatternMatch] Add matcher for G_PTR_ADD
Tue, Jan 12, 3:23 PM
paquette closed D94348: [MIPatternMatch] Add matcher for G_PTR_ADD.
Tue, Jan 12, 3:23 PM · Restricted Project
paquette added a comment to D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.
  • Avg regs/missed combine is the number of registers in RegsToVisit when the combine misses

Does this metric count the misses where there were no registers?

Tue, Jan 12, 2:02 PM · Restricted Project
paquette added a comment to D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.

Here's some measurements:

Tue, Jan 12, 12:14 PM · Restricted Project

Fri, Jan 8

paquette requested review of D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.
Fri, Jan 8, 4:05 PM · Restricted Project
paquette requested review of D94348: [MIPatternMatch] Add matcher for G_PTR_ADD.
Fri, Jan 8, 3:31 PM · Restricted Project

Tue, Jan 5

paquette added inline comments to D92219: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants.
Tue, Jan 5, 10:04 AM · Restricted Project
paquette accepted D93742: GlobalISel: Add isKnownToBeAPowerOfTwo helper function.

LGTM

Tue, Jan 5, 9:29 AM · Restricted Project
paquette accepted D93385: [Driver][MachineOutliner] Support outlining option with LTO.

LGTM

Tue, Jan 5, 9:28 AM · Restricted Project

Dec 17 2020

paquette added inline comments to D93411: [GlobalISel] Transform sext (cmp pred, x, y) -> select (cmp pred, x, y) tval, 0.
Dec 17 2020, 9:41 AM · Restricted Project

Dec 16 2020

paquette requested review of D93411: [GlobalISel] Transform sext (cmp pred, x, y) -> select (cmp pred, x, y) tval, 0.
Dec 16 2020, 11:01 AM · Restricted Project
paquette added inline comments to D93239: GlobalISel: Return APInt from getConstantVRegVal.
Dec 16 2020, 10:57 AM · Restricted Project

Dec 9 2020

paquette added a comment to D92953: [GlobalISel] Base implementation for sret demotion..

Thanks for working on this!

Dec 9 2020, 11:18 AM · Restricted Project

Dec 8 2020

paquette committed rG40d1fb22293b: [AArch64][GlobalISel] Swap select operands when inverting condition code (authored by paquette).
[AArch64][GlobalISel] Swap select operands when inverting condition code
Dec 8 2020, 2:24 PM
paquette committed rG21308c2b4c9d: [AArch64][GlobalISel] Check if G_SELECT has been optimized when folding binops (authored by paquette).
[AArch64][GlobalISel] Check if G_SELECT has been optimized when folding binops
Dec 8 2020, 1:48 PM
paquette committed rG5b5d3fa9d9cf: [AArch64][GlobalISel] Fold G_SELECT cc, %t, (G_ADD %x, 1) -> CSINC %t, %x, cc (authored by paquette).
[AArch64][GlobalISel] Fold G_SELECT cc, %t, (G_ADD %x, 1) -> CSINC %t, %x, cc
Dec 8 2020, 10:54 AM
paquette closed D92868: [AArch64][GlobalISel] Fold G_SELECT cc, %t, (G_ADD %x, 1) -> CSINC %t, %x, cc.
Dec 8 2020, 10:53 AM · Restricted Project
paquette committed rGcd9a52b99e68: [AArch64][GlobalISel] Fold binops on the true side of G_SELECT (authored by paquette).
[AArch64][GlobalISel] Fold binops on the true side of G_SELECT
Dec 8 2020, 10:43 AM
paquette closed D92860: [AArch64][GlobalISel] Fold binops on the true side of G_SELECT.
Dec 8 2020, 10:43 AM · Restricted Project
paquette committed rGce199667f65b: [AArch64][GlobalISel] Don't explicitly write to the zero register in emitCMN (authored by paquette).
[AArch64][GlobalISel] Don't explicitly write to the zero register in emitCMN
Dec 8 2020, 10:42 AM
paquette closed D92438: [AArch64][GlobalISel] Don't explicitly write to the zero register in emitCMN.
Dec 8 2020, 10:42 AM · Restricted Project
paquette requested review of D92868: [AArch64][GlobalISel] Fold G_SELECT cc, %t, (G_ADD %x, 1) -> CSINC %t, %x, cc.
Dec 8 2020, 10:26 AM · Restricted Project
paquette requested review of D92860: [AArch64][GlobalISel] Fold binops on the true side of G_SELECT.
Dec 8 2020, 9:51 AM · Restricted Project
paquette committed rGb15491eb3338: [AArch64][GlobalISel] Select G_SADDO and G_SSUBO (authored by paquette).
[AArch64][GlobalISel] Select G_SADDO and G_SSUBO
Dec 8 2020, 9:18 AM
paquette closed D92610: [AArch64][GlobalISel] Select G_SADDO and G_SSUBO.
Dec 8 2020, 9:18 AM · Restricted Project

Dec 7 2020

paquette committed rGd49f6491b6d1: [AArch64][GlobalISel] Refactor G_BRCOND selection (authored by paquette).
[AArch64][GlobalISel] Refactor G_BRCOND selection
Dec 7 2020, 5:24 PM
paquette closed D92582: [AArch64][GlobalISel] Refactor G_BRCOND selection.
Dec 7 2020, 5:24 PM · Restricted Project
paquette committed rG195a7af0abb2: [AArch64][GlobalISel] Narrow 128-bit regs to 64-bit regs in emitTestBit (authored by paquette).
[AArch64][GlobalISel] Narrow 128-bit regs to 64-bit regs in emitTestBit
Dec 7 2020, 3:05 PM
paquette closed D92707: [AArch64][GlobalISel] Narrow 128-bit regs to 64-bit regs in emitTestBit.
Dec 7 2020, 3:05 PM · Restricted Project
paquette added a comment to D92707: [AArch64][GlobalISel] Narrow 128-bit regs to 64-bit regs in emitTestBit.

With -O0 and -Os on CTMark, there is no change in size.__text.

Dec 7 2020, 10:40 AM · Restricted Project
paquette added inline comments to D92707: [AArch64][GlobalISel] Narrow 128-bit regs to 64-bit regs in emitTestBit.
Dec 7 2020, 9:39 AM · Restricted Project

Dec 4 2020

paquette requested review of D92707: [AArch64][GlobalISel] Narrow 128-bit regs to 64-bit regs in emitTestBit.
Dec 4 2020, 4:15 PM · Restricted Project

Dec 3 2020

paquette requested review of D92610: [AArch64][GlobalISel] Select G_SADDO and G_SSUBO.
Dec 3 2020, 2:42 PM · Restricted Project
paquette requested review of D92582: [AArch64][GlobalISel] Refactor G_BRCOND selection.
Dec 3 2020, 9:34 AM · Restricted Project

Dec 1 2020

paquette committed rGb6b0a80eb93c: Fix typo in testcase runline that got there because I have very bad hands (authored by paquette).
Fix typo in testcase runline that got there because I have very bad hands
Dec 1 2020, 4:58 PM
paquette committed rGc82f002cea30: [AArch64][GlobalISel] Don't write to WZR in non-flag-setting G_BRCOND case (authored by paquette).
[AArch64][GlobalISel] Don't write to WZR in non-flag-setting G_BRCOND case
Dec 1 2020, 4:48 PM
paquette closed D90626: [AArch64][GlobalISel] Don't write to WZR in non-flag-setting G_BRCOND case.
Dec 1 2020, 4:48 PM · Restricted Project
paquette requested review of D92438: [AArch64][GlobalISel] Don't explicitly write to the zero register in emitCMN.
Dec 1 2020, 4:35 PM · Restricted Project
paquette committed rG6c3fa97d8a62: [AArch64][GlobalISel] Select Bcc when it's better than TB(N)Z (authored by paquette).
[AArch64][GlobalISel] Select Bcc when it's better than TB(N)Z
Dec 1 2020, 3:45 PM
paquette closed D92358: [AArch64][GlobalISel] Select Bcc when it's better than TB(N)Z.
Dec 1 2020, 3:45 PM · Restricted Project
paquette updated the diff for D92358: [AArch64][GlobalISel] Select Bcc when it's better than TB(N)Z.

Tidy up logic a little, improve comments, and address review comments.

Dec 1 2020, 11:03 AM · Restricted Project

Nov 30 2020

paquette requested review of D92358: [AArch64][GlobalISel] Select Bcc when it's better than TB(N)Z.
Nov 30 2020, 5:29 PM · Restricted Project
paquette added inline comments to D91892: [GlobalISel] Add NamedRegionTimers for all GlobalISel passes in AArch64 pipeline..
Nov 30 2020, 11:02 AM · Restricted Project
paquette accepted D91655: [AArch64][GlobalISel] Fix crash during legalization of a vector G_SELECT with scalar mask..

LGTM

Nov 30 2020, 9:22 AM · Restricted Project

Nov 19 2020

paquette added inline comments to D91753: [GlobalISel] Add an isExtendedTrueVal helper..
Nov 19 2020, 2:13 PM · Restricted Project

Nov 18 2020

paquette requested review of D91755: [GlobalISel] Combine icmp eq/ne (ext (icmp cc, x, y)), true/false).
Nov 18 2020, 4:44 PM · Restricted Project
paquette requested review of D91754: [GlobalISel] Add isConstFalseVal helper to Utils.
Nov 18 2020, 4:31 PM · Restricted Project
paquette requested review of D91753: [GlobalISel] Add an isExtendedTrueVal helper..
Nov 18 2020, 4:29 PM · Restricted Project

Nov 16 2020

paquette accepted D90040: [AsmPrinter] Use getMnemonic for instruction-mix remark..

LGTM

Nov 16 2020, 4:44 PM · Restricted Project
paquette added inline comments to D90040: [AsmPrinter] Use getMnemonic for instruction-mix remark..
Nov 16 2020, 4:36 PM · Restricted Project
paquette added inline comments to D90040: [AsmPrinter] Use getMnemonic for instruction-mix remark..
Nov 16 2020, 2:32 PM · Restricted Project
paquette committed rG5bc0bd05e6a8: [AArch64][GlobalISel] Fold G_XOR x, -1 into G_SELECT and select CSINV (authored by paquette).
[AArch64][GlobalISel] Fold G_XOR x, -1 into G_SELECT and select CSINV
Nov 16 2020, 2:14 PM
paquette closed D90774: [AArch64][GlobalISel] Fold G_XOR x, -1 into G_SELECT and select CSINV.
Nov 16 2020, 2:14 PM · Restricted Project
paquette accepted D91475: [AArch64][GlobalISel] Look through a G_ZEXT when trying to match shift-extended register offsets..

LGTM

Nov 16 2020, 10:02 AM · Restricted Project

Nov 13 2020

paquette updated the diff for D90774: [AArch64][GlobalISel] Fold G_XOR x, -1 into G_SELECT and select CSINV.

Rebase + use new m_Not matcher

Nov 13 2020, 2:11 PM · Restricted Project
paquette committed rGd6a88e7e194d: [GlobalISel] Add convenience matchers for nots and all-ones constants (authored by paquette).
[GlobalISel] Add convenience matchers for nots and all-ones constants
Nov 13 2020, 1:54 PM
paquette closed D91459: [GlobalISel] Add convenience matchers for nots and all-ones constants.
Nov 13 2020, 1:54 PM · Restricted Project
paquette added inline comments to D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations.
Nov 13 2020, 1:53 PM · Restricted Project, Restricted Project
paquette accepted D91417: [IRGen] Add !annotation metadata for auto-init stores..

I think this looks reasonable.

Nov 13 2020, 1:49 PM · Restricted Project, Restricted Project
paquette requested review of D91459: [GlobalISel] Add convenience matchers for nots and all-ones constants.
Nov 13 2020, 1:40 PM · Restricted Project
paquette committed rG9a8bfe38350d: [AArch64][GlobalISel] Select G_SELECT cc, t, (G_SUB 0, x) -> CSNEG t, x, cc (authored by paquette).
[AArch64][GlobalISel] Select G_SELECT cc, t, (G_SUB 0, x) -> CSNEG t, x, cc
Nov 13 2020, 10:17 AM
paquette closed D90723: [AArch64][GlobalISel] Select G_SELECT cc, t, (G_SUB 0, x) -> CSNEG t, x, cc.
Nov 13 2020, 10:16 AM · Restricted Project
paquette committed rG6c20c1da1e5c: [AArch64][GlobalISel] NFC: Use CmpInst::isUnsigned instead of static helper (authored by paquette).
[AArch64][GlobalISel] NFC: Use CmpInst::isUnsigned instead of static helper
Nov 13 2020, 9:36 AM
paquette closed D91288: [AArch64][GlobalISel] NFC: Use CmpInst::isUnsigned instead of static helper.
Nov 13 2020, 9:36 AM · Restricted Project
paquette committed rGb184a2eccf3b: [GlobalISel] Add matchers for specific constants and a matcher for negations (authored by paquette).
[GlobalISel] Add matchers for specific constants and a matcher for negations
Nov 13 2020, 9:25 AM