Page MenuHomePhabricator

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (126 w, 1 d)

oh boy

Recent Activity

Yesterday

paquette committed rGd5c69e083698: [GlobalISel][AArch64] Legalize + select G_FRINT (authored by paquette).
[GlobalISel][AArch64] Legalize + select G_FRINT
Fri, Apr 19, 4:43 PM
paquette committed rL358799: [GlobalISel][AArch64] Legalize + select G_FRINT.
[GlobalISel][AArch64] Legalize + select G_FRINT
Fri, Apr 19, 4:43 PM
paquette closed D60895: [GlobalISel][AArch64] Legalize + select G_FRINT.
Fri, Apr 19, 4:42 PM · Restricted Project
paquette committed rGad69af3e95e6: [GlobalISel] Add IRTranslator support for G_FRINT (authored by paquette).
[GlobalISel] Add IRTranslator support for G_FRINT
Fri, Apr 19, 2:47 PM
paquette committed rL358787: [GlobalISel] Add IRTranslator support for G_FRINT.
[GlobalISel] Add IRTranslator support for G_FRINT
Fri, Apr 19, 2:47 PM
paquette closed D60893: [GlobalISel] Add IRTranslator support for G_FRINT.
Fri, Apr 19, 2:47 PM · Restricted Project
paquette committed rG627e8f8cb390: [GlobalISel] Add a G_FRINT opcode (authored by paquette).
[GlobalISel] Add a G_FRINT opcode
Fri, Apr 19, 2:46 PM
paquette committed rL358785: [GlobalISel] Add a G_FRINT opcode.
[GlobalISel] Add a G_FRINT opcode
Fri, Apr 19, 2:42 PM
paquette closed D60891: [GlobalISel] Add a G_FRINT opcode.
Fri, Apr 19, 2:42 PM · Restricted Project
paquette created D60923: [GlobalISel][AArch64] Legalize G_FNEARBYINT.
Fri, Apr 19, 2:19 PM · Restricted Project
paquette added a parent revision for D60922: [GlobalISel] Add IRTranslator support for G_FNEARBYINT: D60921: [GlobalISel] Add a G_FNEARBYINT opcode.
Fri, Apr 19, 2:13 PM · Restricted Project
paquette added a child revision for D60921: [GlobalISel] Add a G_FNEARBYINT opcode: D60922: [GlobalISel] Add IRTranslator support for G_FNEARBYINT.
Fri, Apr 19, 2:13 PM · Restricted Project
paquette created D60922: [GlobalISel] Add IRTranslator support for G_FNEARBYINT.
Fri, Apr 19, 2:13 PM · Restricted Project
paquette created D60921: [GlobalISel] Add a G_FNEARBYINT opcode.
Fri, Apr 19, 2:12 PM · Restricted Project
paquette accepted D60315: AMDGPU/GlobalISel: Fix non-power-of-2 G_EXTRACT sources.

LGTM

Fri, Apr 19, 10:02 AM
paquette created D60904: [GlobalISel][AArch64] Legalize vector G_FMA + fix G_FMA's register bank.
Fri, Apr 19, 9:56 AM · Restricted Project
paquette committed rGdfd87f6fa1b7: [GlobalISel][AArch64] Legalize vector G_FPOW (authored by paquette).
[GlobalISel][AArch64] Legalize vector G_FPOW
Fri, Apr 19, 9:28 AM
paquette committed rL358764: [GlobalISel][AArch64] Legalize vector G_FPOW.
[GlobalISel][AArch64] Legalize vector G_FPOW
Fri, Apr 19, 9:27 AM
paquette closed D60218: [GlobalISel][AArch64] Legalize vector G_FPOW.
Fri, Apr 19, 9:27 AM · Restricted Project

Thu, Apr 18

paquette added parent revisions for D60895: [GlobalISel][AArch64] Legalize + select G_FRINT: D60893: [GlobalISel] Add IRTranslator support for G_FRINT, D60891: [GlobalISel] Add a G_FRINT opcode.
Thu, Apr 18, 4:03 PM · Restricted Project
paquette added a child revision for D60891: [GlobalISel] Add a G_FRINT opcode: D60895: [GlobalISel][AArch64] Legalize + select G_FRINT.
Thu, Apr 18, 4:03 PM · Restricted Project
paquette added a child revision for D60893: [GlobalISel] Add IRTranslator support for G_FRINT: D60895: [GlobalISel][AArch64] Legalize + select G_FRINT.
Thu, Apr 18, 4:03 PM · Restricted Project
paquette created D60895: [GlobalISel][AArch64] Legalize + select G_FRINT.
Thu, Apr 18, 4:03 PM · Restricted Project
paquette added a parent revision for D60893: [GlobalISel] Add IRTranslator support for G_FRINT: D60891: [GlobalISel] Add a G_FRINT opcode.
Thu, Apr 18, 3:53 PM · Restricted Project
paquette added a child revision for D60891: [GlobalISel] Add a G_FRINT opcode: D60893: [GlobalISel] Add IRTranslator support for G_FRINT.
Thu, Apr 18, 3:53 PM · Restricted Project
paquette created D60893: [GlobalISel] Add IRTranslator support for G_FRINT.
Thu, Apr 18, 3:53 PM · Restricted Project
paquette updated the diff for D60891: [GlobalISel] Add a G_FRINT opcode.

Remove change to AArch64RegisterBankInfo.cpp; I want that to come in with a later commit where it makes more sense.

Thu, Apr 18, 3:47 PM · Restricted Project
paquette created D60891: [GlobalISel] Add a G_FRINT opcode.
Thu, Apr 18, 3:46 PM · Restricted Project
paquette committed rG0aa9b453c40e: [GlobalISel][AArch64] Legalize/select G_(S/Z/ANY)_EXT for v8s8s (authored by paquette).
[GlobalISel][AArch64] Legalize/select G_(S/Z/ANY)_EXT for v8s8s
Thu, Apr 18, 2:14 PM
paquette committed rL358715: [GlobalISel][AArch64] Legalize/select G_(S/Z/ANY)_EXT for v8s8s.
[GlobalISel][AArch64] Legalize/select G_(S/Z/ANY)_EXT for v8s8s
Thu, Apr 18, 2:14 PM
paquette closed D60881: [GlobalISel][AArch64] Legalize/select G_(S/Z/ANY)_EXT for v8s8s.
Thu, Apr 18, 2:14 PM · Restricted Project
paquette committed rG3b5119c68455: [GlobalISel][AArch64] Legalize v8s8 loads (authored by paquette).
[GlobalISel][AArch64] Legalize v8s8 loads
Thu, Apr 18, 2:14 PM
paquette committed rL358714: [GlobalISel][AArch64] Legalize v8s8 loads.
[GlobalISel][AArch64] Legalize v8s8 loads
Thu, Apr 18, 2:14 PM
paquette closed D60877: [GlobalISel][AArch64] Legalize v8s8 loads.
Thu, Apr 18, 2:14 PM · Restricted Project
paquette created D60889: [GlobalISel][AArch64] Add generic legalization rule for extends.
Thu, Apr 18, 2:08 PM · Restricted Project
paquette updated the diff for D60881: [GlobalISel][AArch64] Legalize/select G_(S/Z/ANY)_EXT for v8s8s.

Just realized that the G_ZEXT is the only thing relevant to check for in arm64-vabs.ll. Remove unnecessary check lines.

Thu, Apr 18, 11:16 AM · Restricted Project
paquette created D60881: [GlobalISel][AArch64] Legalize/select G_(S/Z/ANY)_EXT for v8s8s.
Thu, Apr 18, 11:03 AM · Restricted Project
paquette created D60877: [GlobalISel][AArch64] Legalize v8s8 loads.
Thu, Apr 18, 9:50 AM · Restricted Project

Thu, Apr 11

paquette accepted D60534: [AArch64][GlobalISel] Legalization and ISel support for load/stores of vectors of pointers.

I think this looks fine now that you've addressed @arsenm's comment.

Thu, Apr 11, 10:27 AM · Restricted Project

Tue, Apr 9

paquette accepted D60277: GlobalISel: Handle odd breakdowns for bit ops.

LGTM

Tue, Apr 9, 10:10 AM
paquette accepted D60280: GlobalISel: Support legalizing G_CONSTANT with irregular breakdown.

LGTM

Tue, Apr 9, 10:03 AM
paquette added inline comments to D60315: AMDGPU/GlobalISel: Fix non-power-of-2 G_EXTRACT sources.
Tue, Apr 9, 9:56 AM
paquette accepted D60425: [GlobalISel][AArch64] Allow CallLowering to handle types.

LGTM, some debug output would be nice to show what it is that we intend to implement

Tue, Apr 9, 9:55 AM · Restricted Project
paquette accepted D60435: [AArch64][GlobalISel] Legalize vector G_ICMP.

LGTM aside from question

Tue, Apr 9, 9:41 AM · Restricted Project
paquette accepted D60433: [AArch64][GlobalISel] Add legalization for some vector G_LSR and G_ASHR.

LGTM

Tue, Apr 9, 9:38 AM · Restricted Project
paquette accepted D60436: [AArch64][GlobalISel] Add isel support for vector G_ICMP and G_ASHR & G_LSR.

LGTM

Tue, Apr 9, 9:35 AM · Restricted Project

Thu, Apr 4

paquette added a comment to D60265: [LoopUnroll] Allow unrolling if the unrolled size does not exceed loop size..

Right, I should have said something here. Without D60266, there was no change in code size on the set of benchmarks, most likely because loop-rotate is not run and they are not in the required form for unrolling to happen.

Ok, cool!

Thu, Apr 4, 9:32 AM · Restricted Project
paquette added inline comments to D60266: [LoopUnroll] Rotate loop, when optimizing for size and can fully unroll a loop..
Thu, Apr 4, 9:24 AM · Restricted Project
paquette accepted D60265: [LoopUnroll] Allow unrolling if the unrolled size does not exceed loop size..

LGTM. Just a couple little comments, but none of them are critical:

Thu, Apr 4, 9:14 AM · Restricted Project

Wed, Apr 3

paquette added inline comments to D60227: [Remarks] Add string deduplication using a string table.
Wed, Apr 3, 1:53 PM · Restricted Project
paquette created D60221: [GlobalISel] Add a G_FPOWI instruction for @llvm.powi.
Wed, Apr 3, 11:05 AM · Restricted Project
paquette created D60218: [GlobalISel][AArch64] Legalize vector G_FPOW.
Wed, Apr 3, 10:35 AM · Restricted Project
paquette committed rGe794121cd0d2: [AArch64][GlobalISel] Legalize G_FEXP2 (authored by paquette).
[AArch64][GlobalISel] Legalize G_FEXP2
Wed, Apr 3, 9:59 AM
paquette committed rL357605: [AArch64][GlobalISel] Legalize G_FEXP2.
[AArch64][GlobalISel] Legalize G_FEXP2
Wed, Apr 3, 9:59 AM
paquette closed D60165: [AArch64][GlobalISel] Legalize G_FEXP2.
Wed, Apr 3, 9:59 AM · Restricted Project

Tue, Apr 2

paquette created D60165: [AArch64][GlobalISel] Legalize G_FEXP2.
Tue, Apr 2, 4:41 PM · Restricted Project
paquette committed rGed23352379c8: [GlobalISel] Add IRTranslator support for llvm.stacksave and llvm.stackrestore (authored by paquette).
[GlobalISel] Add IRTranslator support for llvm.stacksave and llvm.stackrestore
Tue, Apr 2, 3:45 PM
paquette committed rL357538: [GlobalISel] Add IRTranslator support for llvm.stacksave and llvm.stackrestore.
[GlobalISel] Add IRTranslator support for llvm.stacksave and llvm.stackrestore
Tue, Apr 2, 3:45 PM
paquette closed D60140: [GlobalISel] Add IRTranslator support for llvm.stacksave and llvm.stackrestore.
Tue, Apr 2, 3:45 PM · Restricted Project
paquette committed rG22c6215c7e59: [AArch64][GlobalISel] Select llvm.aarch64.stlxr(i64, i64*) (authored by paquette).
[AArch64][GlobalISel] Select llvm.aarch64.stlxr(i64, i64*)
Tue, Apr 2, 12:58 PM
paquette committed rL357518: [AArch64][GlobalISel] Select llvm.aarch64.stlxr(i64, i64*).
[AArch64][GlobalISel] Select llvm.aarch64.stlxr(i64, i64*)
Tue, Apr 2, 12:58 PM
paquette closed D60100: [AArch64][GlobalISel] Select llvm.aarch64.stlxr(i64, i64*).
Tue, Apr 2, 12:58 PM · Restricted Project
paquette created D60140: [GlobalISel] Add IRTranslator support for llvm.stacksave and llvm.stackrestore.
Tue, Apr 2, 10:50 AM · Restricted Project

Mon, Apr 1

paquette committed rGe44c20a68d26: [AArch64][GlobalISe] Select STRQui for stores into v264s instead of scalarizing (authored by paquette).
[AArch64][GlobalISe] Select STRQui for stores into v264s instead of scalarizing
Mon, Apr 1, 3:18 PM
paquette committed rL357432: [AArch64][GlobalISe] Select STRQui for stores into v264s instead of scalarizing.
[AArch64][GlobalISe] Select STRQui for stores into v264s instead of scalarizing
Mon, Apr 1, 3:18 PM
paquette closed D60083: [AArch64][GlobalISe] Select STRQui for stores into v264s instead of scalarizing.
Mon, Apr 1, 3:18 PM · Restricted Project
paquette created D60100: [AArch64][GlobalISel] Select llvm.aarch64.stlxr(i64, i64*).
Mon, Apr 1, 3:14 PM · Restricted Project
paquette created D60083: [AArch64][GlobalISe] Select STRQui for stores into v264s instead of scalarizing.
Mon, Apr 1, 11:42 AM · Restricted Project

Fri, Mar 29

paquette committed rGd3ffd47df94b: [GlobalISel][AArch64] Add isel support for G_INSERT_VECTOR_ELT on v2s32s (authored by paquette).
[GlobalISel][AArch64] Add isel support for G_INSERT_VECTOR_ELT on v2s32s
Fri, Mar 29, 2:39 PM
paquette committed rL357318: [GlobalISel][AArch64] Add isel support for G_INSERT_VECTOR_ELT on v2s32s.
[GlobalISel][AArch64] Add isel support for G_INSERT_VECTOR_ELT on v2s32s
Fri, Mar 29, 2:39 PM
paquette closed D59910: [GlobalISel][AArch64] Add instruction selection support for G_INSERT_VECTOR_ELT on v2s32s.
Fri, Mar 29, 2:39 PM · Restricted Project

Thu, Mar 28

paquette added inline comments to D59910: [GlobalISel][AArch64] Add instruction selection support for G_INSERT_VECTOR_ELT on v2s32s.
Thu, Mar 28, 10:30 AM · Restricted Project

Wed, Mar 27

paquette created D59910: [GlobalISel][AArch64] Add instruction selection support for G_INSERT_VECTOR_ELT on v2s32s.
Wed, Mar 27, 4:42 PM · Restricted Project
paquette committed rGeaf4df478216: [opt-viewer] Teach optrecord.py about !Failure tags (authored by paquette).
[opt-viewer] Teach optrecord.py about !Failure tags
Wed, Mar 27, 11:36 AM
paquette committed rL357110: [opt-viewer] Teach optrecord.py about !Failure tags.
[opt-viewer] Teach optrecord.py about !Failure tags
Wed, Mar 27, 11:33 AM
paquette closed D59895: [opt-viewer] Teach optrecord.py about !Failure tags.
Wed, Mar 27, 11:33 AM · Restricted Project
paquette created D59895: [opt-viewer] Teach optrecord.py about !Failure tags.
Wed, Mar 27, 11:28 AM · Restricted Project
paquette committed rGbeda859a15ae: [opt-viewer] Make filter_=None by default in get_remarks and gather_results (authored by paquette).
[opt-viewer] Make filter_=None by default in get_remarks and gather_results
Wed, Mar 27, 11:15 AM
paquette committed rL357106: [opt-viewer] Make filter_=None by default in get_remarks and gather_results.
[opt-viewer] Make filter_=None by default in get_remarks and gather_results
Wed, Mar 27, 11:13 AM
paquette closed D59894: [opt-viewer] Make filter_=None by default in get_remarks and gather_results.
Wed, Mar 27, 11:13 AM · Restricted Project
paquette created D59894: [opt-viewer] Make filter_=None by default in get_remarks and gather_results.
Wed, Mar 27, 11:09 AM · Restricted Project

Tue, Mar 26

paquette committed rG55d495475c95: Make -mno-outline pass -enable-machine-outliner=never to ld in LTO (authored by paquette).
Make -mno-outline pass -enable-machine-outliner=never to ld in LTO
Tue, Mar 26, 2:25 PM
paquette committed rL357031: Make -mno-outline pass -enable-machine-outliner=never to ld in LTO.
Make -mno-outline pass -enable-machine-outliner=never to ld in LTO
Tue, Mar 26, 2:25 PM
paquette committed rC357031: Make -mno-outline pass -enable-machine-outliner=never to ld in LTO.
Make -mno-outline pass -enable-machine-outliner=never to ld in LTO
Tue, Mar 26, 2:25 PM

Mon, Mar 25

paquette added inline comments to D59635: [AArch64] NFC: Cleanup isAArch64FrameOffsetLegal.
Mon, Mar 25, 10:33 AM

Fri, Mar 22

paquette accepted D59722: [ScheduleDAG] Avoid unnecessary recomputation of topological order..

Out of curiosity, do you have any numbers for how this impacts compile time on, say, CTMark? What percentage of an improvement can we expect from this?

Fri, Mar 22, 4:22 PM · Restricted Project
paquette added inline comments to D59635: [AArch64] NFC: Cleanup isAArch64FrameOffsetLegal.
Fri, Mar 22, 10:55 AM

Mar 19 2019

paquette accepted D59558: [AArch64][GlobalISel] Add an optimization to select vector DUP instructions.

Some minor nits included.

Mar 19 2019, 1:46 PM · Restricted Project
paquette accepted D59507: [DAGCombine] Fix a miscompile when reducing BUILD_VECTORs to a shuffle.

This makes a lot more sense than trying to salvage information from extracts. LGTM.

Mar 19 2019, 9:03 AM · Restricted Project

Mar 18 2019

paquette created D59509: Make static constructors + destructors minsize + cold (except for in -O0).
Mar 18 2019, 1:29 PM · Restricted Project

Mar 15 2019

paquette accepted D59434: [GlobalISel] Allow MachineIRBuilder to build subregister copies.

LGTM

Mar 15 2019, 2:51 PM · Restricted Project

Mar 14 2019

paquette committed rG7d6784f5225b: [AArch64][GlobalISel] Add isel support for G_UADDO on s32s and s64s (authored by paquette).
[AArch64][GlobalISel] Add isel support for G_UADDO on s32s and s64s
Mar 14 2019, 3:54 PM
paquette committed rL356214: [AArch64][GlobalISel] Add isel support for G_UADDO on s32s and s64s.
[AArch64][GlobalISel] Add isel support for G_UADDO on s32s and s64s
Mar 14 2019, 3:54 PM
paquette closed D58734: [AArch64][GlobalISel] Add isel support for G_UADDO on s32s and s64s.
Mar 14 2019, 3:54 PM · Restricted Project
paquette accepted D59392: [AArch64][GlobalISel] Implement selection for G_UNMERGE of vectors to vectors.

LGTM

Mar 14 2019, 3:27 PM · Restricted Project
paquette accepted D59390: [AArch64][GlobalISel] Add some support for G_CONCAT_VECTORS.

LGTM

Mar 14 2019, 3:26 PM · Restricted Project
paquette committed rG5aff1f475c60: [GlobalISel][AArch64] Add partial selection support for G_INSERT_VECTOR_ELT (authored by paquette).
[GlobalISel][AArch64] Add partial selection support for G_INSERT_VECTOR_ELT
Mar 14 2019, 11:02 AM
paquette committed rL356182: [GlobalISel][AArch64] Add partial selection support for G_INSERT_VECTOR_ELT.
[GlobalISel][AArch64] Add partial selection support for G_INSERT_VECTOR_ELT
Mar 14 2019, 11:02 AM
paquette closed D59325: [GlobalISel][AArch64] Add partial selection support for G_INSERT_VECTOR_ELT.
Mar 14 2019, 11:02 AM · Restricted Project
paquette updated the diff for D59325: [GlobalISel][AArch64] Add partial selection support for G_INSERT_VECTOR_ELT.

Restrict legal types to exactly v4s32 and v2s64, add TODOs for other types.

Mar 14 2019, 10:40 AM · Restricted Project