- User Since
- Nov 17 2016, 12:59 PM (151 w, 3 d)
Fri, Oct 4
Mon, Sep 30
Fri, Sep 27
LGTM with test change
Can we also have a check for say, __memcpy_chk?
Refactor forwarding code, and factor out IRTranslator changes into a helper.
Thu, Sep 26
Wed, Sep 25
Tue, Sep 24
I'm noticing that the existing test coverage for varargs tail calls has some room for improvement in general.
Looking back in the discussion, I think it's fine to have it act the same way as fastcc.
Mon, Sep 23
A couple things I think could have testcases:
Wed, Sep 18
Add test verifying that we fall back to SelectionDAG and die when a musttail call is not lowered as a tail call.
Tue, Sep 17
Sep 13 2019
Update comments, add -global-isel-abort=1 to test
Add missing check for when the return is a tail call.
Sep 12 2019
I think this seems reasonable.
Sep 11 2019
Sep 10 2019
Sep 9 2019
Sep 6 2019
Sep 5 2019
LGTM in any case; I think it would be good to find out why the register class can come out wrong though.
Fixed the issue. Issue was that I never tested returning something other than void. I disabled tail calling calls with non-void return types, and updated the test to reflect that.
@RKSimon Sorry about that. I'll enable EXPENSIVE_CHECKS.
Sep 4 2019
I'm going to commit this as-is and put up a separate review for remarks.
LGTM with style nit