Page MenuHomePhabricator

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (107 w, 4 d)

oh boy

Recent Activity

Yesterday

paquette accepted D55516: [GISel]: Add MachineIRBuilder support for passing in Flags while building instructions.

LGTM

Mon, Dec 10, 11:13 AM
paquette added inline comments to D55516: [GISel]: Add MachineIRBuilder support for passing in Flags while building instructions.
Mon, Dec 10, 10:05 AM

Fri, Dec 7

paquette closed D55392: [GlobalISel] Add IR translation support for the @llvm.log10 intrinsic.

Committed in r348657.

Fri, Dec 7, 2:12 PM
paquette committed rL348657: [GlobalISel] Add IR translation support for the @llvm.log10 intrinsic.
[GlobalISel] Add IR translation support for the @llvm.log10 intrinsic
Fri, Dec 7, 2:11 PM
paquette added a comment to D55392: [GlobalISel] Add IR translation support for the @llvm.log10 intrinsic.

@aemerson is right here. I got mixed up because I was just working through -Rpass-missed=gisel-select remarks in a test.

Fri, Dec 7, 2:06 PM
paquette retitled D55392: [GlobalISel] Add IR translation support for the @llvm.log10 intrinsic from [GlobalISel] Add instruction selection support for the @llvm.log10 intrinsic to [GlobalISel] Add IR translation support for the @llvm.log10 intrinsic.
Fri, Dec 7, 2:03 PM

Thu, Dec 6

paquette created D55392: [GlobalISel] Add IR translation support for the @llvm.log10 intrinsic.
Thu, Dec 6, 3:31 PM

Wed, Dec 5

paquette committed rL348439: [MachineOutliner][NFC] Move yet another std::vector out of a loop.
[MachineOutliner][NFC] Move yet another std::vector out of a loop
Wed, Dec 5, 4:29 PM
paquette committed rL348433: [MachineOutliner][NFC] Move std::vector out of loop.
[MachineOutliner][NFC] Move std::vector out of loop
Wed, Dec 5, 4:07 PM
paquette committed rL348432: [MachineOutliner][NFC] Remove IntegerInstructionMap from InstructionMapper.
[MachineOutliner][NFC] Remove IntegerInstructionMap from InstructionMapper
Wed, Dec 5, 4:05 PM
paquette committed rL348428: [MachineOutliner][NFC] Remove buildCandidateList and replace with findCandidates.
[MachineOutliner][NFC] Remove buildCandidateList and replace with findCandidates
Wed, Dec 5, 3:42 PM
paquette committed rL348427: [MachineOutliner][NFC] Candidates don't need to be shared_ptrs anymore.
[MachineOutliner][NFC] Candidates don't need to be shared_ptrs anymore
Wed, Dec 5, 3:27 PM
paquette committed rL348422: [MachineOutliner][NFC] Remove CandidateList, since it's now unused..
[MachineOutliner][NFC] Remove CandidateList, since it's now unused.
Wed, Dec 5, 2:54 PM
paquette committed rL348421: Fix buildbot capture warning.
Fix buildbot capture warning
Wed, Dec 5, 2:50 PM
paquette committed rL348420: [MachineOutliner][NFC] Simplify and unify pruning/outlining logic.
[MachineOutliner][NFC] Simplify and unify pruning/outlining logic
Wed, Dec 5, 2:31 PM
paquette committed rL348414: [MachineOutliner] Outline functions by order of benefit.
[MachineOutliner] Outline functions by order of benefit
Wed, Dec 5, 1:39 PM
paquette committed rL348392: [MachineOutliner][NFC] Use getOccurrenceCount() in getNotOutlinedCost().
[MachineOutliner][NFC] Use getOccurrenceCount() in getNotOutlinedCost()
Wed, Dec 5, 10:20 AM
paquette committed rL348391: [MachineOutliner][NFC] Make getters in MachineOutliner.h const.
[MachineOutliner][NFC] Make getters in MachineOutliner.h const
Wed, Dec 5, 10:15 AM
paquette committed rL348390: [MachineOutliner][NFC] Don't create outlined sequence from integer mapping.
[MachineOutliner][NFC] Don't create outlined sequence from integer mapping
Wed, Dec 5, 10:00 AM

Mon, Dec 3

paquette committed rL348220: [MachineOutliner] Move stack instr check logic to getOutliningCandidateInfo.
[MachineOutliner] Move stack instr check logic to getOutliningCandidateInfo
Mon, Dec 3, 4:35 PM
paquette committed rL348219: [MachineOutliner][AArch64][NFC] Add early exit to candidate discarding logic.
[MachineOutliner][AArch64][NFC] Add early exit to candidate discarding logic
Mon, Dec 3, 4:34 PM
paquette committed rL348168: [MachineOutliner] Drop candidates that require fixups if it's beneficial.
[MachineOutliner] Drop candidates that require fixups if it's beneficial
Mon, Dec 3, 11:14 AM

Sat, Dec 1

paquette committed rL348081: [MachineOutliner][AArch64] Improve checks for stack instructions.
[MachineOutliner][AArch64] Improve checks for stack instructions
Sat, Dec 1, 1:27 PM
paquette committed rL348080: Replace w16/w17 in machine-outliner.mir with w11/w12.
Replace w16/w17 in machine-outliner.mir with w11/w12
Sat, Dec 1, 1:26 PM

Fri, Nov 30

paquette committed rL348036: [MachineOutliner] Outline both register save calls + no LR save calls together.
[MachineOutliner] Outline both register save calls + no LR save calls together
Fri, Nov 30, 1:18 PM

Wed, Nov 14

paquette committed rL346913: [MachineOutliner][NFC] Check if CandidatesForRepeatedSeq < 2.
[MachineOutliner][NFC] Check if CandidatesForRepeatedSeq < 2
Wed, Nov 14, 4:05 PM
paquette committed rL346901: [MachineOutliner][NFC] Don't compute liveness if X16/X17/NZCV are unused.
[MachineOutliner][NFC] Don't compute liveness if X16/X17/NZCV are unused
Wed, Nov 14, 2:26 PM

Tue, Nov 13

paquette committed rL346816: [MachineOutliner][NFC] Use flags set in all candidates to check for calls.
[MachineOutliner][NFC] Use flags set in all candidates to check for calls
Tue, Nov 13, 3:44 PM
paquette committed rL346809: [MachineOutliner][NFC] Use MBB flags to avoid call checks in getOutliningInfo.
[MachineOutliner][NFC] Use MBB flags to avoid call checks in getOutliningInfo
Tue, Nov 13, 3:04 PM
paquette committed rL346803: [MachineOutliner][NFC] Exit getOutliningType if there are < 2 candidates.
[MachineOutliner][NFC] Exit getOutliningType if there are < 2 candidates
Tue, Nov 13, 2:19 PM

Mon, Nov 12

paquette committed rL346721: [MachineOutliner][NFC] Simplify isMBBSafeToOutlineFrom check in AArch64 outliner.
[MachineOutliner][NFC] Simplify isMBBSafeToOutlineFrom check in AArch64 outliner
Mon, Nov 12, 4:34 PM
paquette committed rL346718: [MachineOutliner][NFC] Change getMachineOutlinerMBBFlags to….
[MachineOutliner][NFC] Change getMachineOutlinerMBBFlags to…
Mon, Nov 12, 3:54 PM
paquette committed rL346682: [MachineOutliner][NFC] Early exit pruning when candidates don't share an MBB.
[MachineOutliner][NFC] Early exit pruning when candidates don't share an MBB
Mon, Nov 12, 9:53 AM
paquette committed rL346681: [MachineOutliner][NFC] Put suffix tree in buildCandidateList.
[MachineOutliner][NFC] Put suffix tree in buildCandidateList
Mon, Nov 12, 9:53 AM

Nov 7 2018

paquette committed rL346379: [MachineOutliner][NFC] Only map blocks which have adjacent legal instructions.
[MachineOutliner][NFC] Only map blocks which have adjacent legal instructions
Nov 7 2018, 4:36 PM
paquette committed rL346373: [MachineOutliner][NFC] Don't map MBBs that don't contain legal instructions.
[MachineOutliner][NFC] Don't map MBBs that don't contain legal instructions
Nov 7 2018, 4:04 PM
paquette committed rL346349: [MachineOutliner][NFC] Remove Parent field from SuffixTreeNode.
[MachineOutliner][NFC] Remove Parent field from SuffixTreeNode
Nov 7 2018, 11:58 AM
paquette committed rL346345: [MachineOutliner][NFC] Traverse suffix tree using a RepeatedSubstring iterator.
[MachineOutliner][NFC] Traverse suffix tree using a RepeatedSubstring iterator
Nov 7 2018, 11:24 AM
paquette committed rL346340: [MachineOutliner] Don't store outlined function numberings on OutlinedFunction.
[MachineOutliner] Don't store outlined function numberings on OutlinedFunction
Nov 7 2018, 10:39 AM

Nov 6 2018

paquette committed rL346275: [MachineOutliner][NFC] Remove OccurrenceCount from SuffixTreeNode.
[MachineOutliner][NFC] Remove OccurrenceCount from SuffixTreeNode
Nov 6 2018, 2:25 PM
paquette committed rL346274: [MachineOutliner][NFC] Remove IsInTree from SuffixTreeNode.
[MachineOutliner][NFC] Remove IsInTree from SuffixTreeNode
Nov 6 2018, 2:23 PM
paquette committed rL346269: [MachineOutliner][NFC] Add findRepeatedSubstrings to SuffixTree, kill LeafVector.
[MachineOutliner][NFC] Add findRepeatedSubstrings to SuffixTree, kill LeafVector
Nov 6 2018, 1:49 PM

Nov 1 2018

paquette committed rL345906: [MachineOutliner][NFC] Remember when you map something illegal across MBBs.
[MachineOutliner][NFC] Remember when you map something illegal across MBBs
Nov 1 2018, 4:11 PM

Oct 31 2018

paquette requested changes to D53942: IR Outliner Pass.

Thanks for putting this up! I think this patch needs some work though.

Oct 31 2018, 4:39 PM

Oct 29 2018

paquette committed rL345535: [MachineOutliner] Inherit target features from parent function.
[MachineOutliner] Inherit target features from parent function
Oct 29 2018, 1:29 PM

Oct 10 2018

paquette accepted D52776: [OptRemarks] Add library for parsing optimization remarks.

LGTM!

Oct 10 2018, 8:58 AM

Oct 5 2018

paquette closed D52945: [GlobalIsel] Add llvm.invariant.start and llvm.invariant.end.

Thanks! Committed in r343885. (https://reviews.llvm.org/rL343885)

Oct 5 2018, 2:06 PM
paquette committed rL343885: [GlobalIsel] Add llvm.invariant.start and llvm.invariant.end.
[GlobalIsel] Add llvm.invariant.start and llvm.invariant.end
Oct 5 2018, 2:05 PM
paquette created D52945: [GlobalIsel] Add llvm.invariant.start and llvm.invariant.end.
Oct 5 2018, 1:39 PM

Oct 4 2018

paquette added a comment to D52776: [OptRemarks] Add library for parsing optimization remarks.

Just one more round of comments.

Oct 4 2018, 4:27 PM
paquette accepted D52829: [AArch64] Fix verifier error when outlining indirect calls.

As long as you add a FIXME saying that we should move this responsibility over to the verifier, this LGTM.

Oct 4 2018, 11:00 AM
paquette added a comment to D52829: [AArch64] Fix verifier error when outlining indirect calls.

I don't think adding a special case to the verifier makes sense, when it's easy enough to generate code which is valid by the normal rules.

I think this is probably really the only thing the outliner does that upsets the verifier. So, from that perspective, I think that this is fine.

Oct 4 2018, 10:03 AM

Oct 2 2018

paquette added a comment to D52776: [OptRemarks] Add library for parsing optimization remarks.

Mostly style nits here.

Oct 2 2018, 10:40 AM
paquette committed rL343600: Revert "[sanitizer] Include inlined frames into __sanitizer_symbolize_pc output".
Revert "[sanitizer] Include inlined frames into __sanitizer_symbolize_pc output"
Oct 2 2018, 9:30 AM
paquette committed rCRT343600: Revert "[sanitizer] Include inlined frames into __sanitizer_symbolize_pc output".
Revert "[sanitizer] Include inlined frames into __sanitizer_symbolize_pc output"
Oct 2 2018, 9:30 AM

Sep 25 2018

paquette committed rL343005: Revert "[ConstHoist] Do not rebase single (or few) dependent constant".
Revert "[ConstHoist] Do not rebase single (or few) dependent constant"
Sep 25 2018, 11:43 AM

Sep 20 2018

paquette committed rL342688: [MachineOutliner][NFC] Don't add MBBs with a size < 2 to the search space.
[MachineOutliner][NFC] Don't add MBBs with a size < 2 to the search space
Sep 20 2018, 2:58 PM
paquette committed rL342677: [MachineOutliner][NFC] Move debug info emission to createOutlinedFunction.
[MachineOutliner][NFC] Move debug info emission to createOutlinedFunction
Sep 20 2018, 11:58 AM

Sep 17 2018

paquette committed rL342405: [MachineOutliner][NFC] Don't map more illegal instrs than you have to.
[MachineOutliner][NFC] Don't map more illegal instrs than you have to
Sep 17 2018, 11:44 AM

Sep 11 2018

paquette committed rL342009: [MachineOutliner] Add codegen size remarks to the MachineOutliner.
[MachineOutliner] Add codegen size remarks to the MachineOutliner
Sep 11 2018, 4:07 PM
paquette committed rL341960: [NFC] Fix typo in comment.
[NFC] Fix typo in comment
Sep 11 2018, 9:41 AM
paquette committed rL341959: [MachineOutliner][NFC] Factor out instruction mapping into its own function.
[MachineOutliner][NFC] Factor out instruction mapping into its own function
Sep 11 2018, 9:35 AM

Sep 10 2018

paquette committed rL341885: Add REQUIRES line to machine-size-remarks.
Add REQUIRES line to machine-size-remarks
Sep 10 2018, 4:54 PM
paquette committed rL341882: Explicitly state triple in machine-size-remarks.ll.
Explicitly state triple in machine-size-remarks.ll
Sep 10 2018, 4:33 PM
paquette committed rL341876: Add size remarks to MachineFunctionPass.
Add size remarks to MachineFunctionPass
Sep 10 2018, 3:25 PM

Sep 6 2018

paquette closed D51467: Output per-function size-info remarks.

Committed in r341588.

Sep 6 2018, 2:21 PM
paquette committed rL341588: Output per-function size-info remarks.
Output per-function size-info remarks
Sep 6 2018, 2:21 PM

Sep 4 2018

paquette updated the diff for D51467: Output per-function size-info remarks.

Forgot to address a review comment; just did that.

Sep 4 2018, 2:40 PM
paquette updated the diff for D51467: Output per-function size-info remarks.

Updated patch to reflect the NFC changes I put in to speed up size remarks.

Sep 4 2018, 2:24 PM
paquette committed rL341407: [NFC] Improve clarity in emitInstrCountChangedRemark.
[NFC] Improve clarity in emitInstrCountChangedRemark
Sep 4 2018, 2:04 PM

Aug 31 2018

paquette committed rL341267: Fix typo in size remarks for module passes.
Fix typo in size remarks for module passes
Aug 31 2018, 3:44 PM
paquette committed rL341253: [NFC] Optionally pass a function to emitInstrCountChangedRemark.
[NFC] Optionally pass a function to emitInstrCountChangedRemark
Aug 31 2018, 1:55 PM
paquette committed rL341252: [NFC] Check if P is a pass manager on entry to emitInstrCountChangedRemark.
[NFC] Check if P is a pass manager on entry to emitInstrCountChangedRemark
Aug 31 2018, 1:52 PM
paquette added a comment to rL341250: [NFC] Pass the instruction delta to emitInstrCountChangedRemark.

TIL that including "-O2" in a commit message will transform it into "https://reviews.llvm.org/owners/package/2/" when you hit reviews.llvm.org.

Aug 31 2018, 1:25 PM
paquette committed rL341250: [NFC] Pass the instruction delta to emitInstrCountChangedRemark.
[NFC] Pass the instruction delta to emitInstrCountChangedRemark
Aug 31 2018, 1:22 PM
paquette committed rL341249: [NFC] Pre-calculate SCC IR counts in size remarks..
[NFC] Pre-calculate SCC IR counts in size remarks.
Aug 31 2018, 1:22 PM
paquette committed rL341248: [NFC] Pre-calculate module IR counts in size remarks..
[NFC] Pre-calculate module IR counts in size remarks.
Aug 31 2018, 1:22 PM
paquette committed rL341247: [NFC] Pre-calculate loop IR counts in size remarks..
[NFC] Pre-calculate loop IR counts in size remarks.
Aug 31 2018, 1:22 PM
paquette committed rL341246: [NFC] Pre-calculate basic block IR counts in size remarks..
[NFC] Pre-calculate basic block IR counts in size remarks.
Aug 31 2018, 1:22 PM
paquette committed rL341245: [NFC] Pre-calculate function IR counts in size remarks..
[NFC] Pre-calculate function IR counts in size remarks.
Aug 31 2018, 1:20 PM

Aug 30 2018

paquette added a comment to D51467: Output per-function size-info remarks.

I ran this with a debug build, and I noticed it's pretty heavy wrt compile time. I'm working on fixing that before committing.

Aug 30 2018, 2:16 PM
paquette accepted D51465: Revamp test-suite documentation.

Added some style nits.

Aug 30 2018, 10:06 AM

Aug 29 2018

paquette created D51467: Output per-function size-info remarks.
Aug 29 2018, 4:23 PM

Aug 28 2018

paquette added inline comments to D51276: [New PM][PassTiming] implement -time-passes for the new pass manager.
Aug 28 2018, 10:24 AM
paquette accepted D51274: [NFC][PassTiming] factor out generic PassTimingInfo.

Added some nits on comments. These could be done in a follow-up patch. I think a lot of these comments could use a style update.

Aug 28 2018, 10:12 AM

Aug 17 2018

paquette committed rL340078: Add ability to track linker memory usage.
Add ability to track linker memory usage
Aug 17 2018, 1:48 PM

Aug 14 2018

paquette committed rL339725: Add mem_bytes to test_suite.py.
Add mem_bytes to test_suite.py
Aug 14 2018, 1:51 PM

Jul 30 2018

paquette closed D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.

Committed in r338278. (https://reviews.llvm.org/rL338278)

Jul 30 2018, 10:46 AM
paquette committed rL338278: [MachineOutliner][AArch64] Add support for saving LR to a register.
[MachineOutliner][AArch64] Add support for saving LR to a register
Jul 30 2018, 10:46 AM
paquette committed rL338272: Add machine verifier to arm64-opt-remarks-lazy-bfi.
Add machine verifier to arm64-opt-remarks-lazy-bfi
Jul 30 2018, 10:13 AM
paquette added a comment to rL338267: Attempt to fix Windows test failure caused by r338133.

Oh, it turns out this isn't just Windows. It's just that the verifier was running on those bots. Doh.

Jul 30 2018, 10:04 AM
paquette added a comment to rL338133: Enable MachineOutliner by default under -Oz for AArch64.

It seems like the issue is that on Windows, we also insert a 'Verify generated machine code' pass.

Jul 30 2018, 9:39 AM
paquette committed rL338267: Attempt to fix Windows test failure caused by r338133.
Attempt to fix Windows test failure caused by r338133
Jul 30 2018, 9:36 AM
paquette added a comment to rL338133: Enable MachineOutliner by default under -Oz for AArch64.

Sorry for the late response. Looking into the test failure now.

Jul 30 2018, 8:53 AM

Jul 27 2018

paquette updated the diff for D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.

Updated the diff. We now just look over the GPR64 register class instead of callee-saves.

Jul 27 2018, 5:19 PM
paquette added inline comments to D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.
Jul 27 2018, 5:11 PM
paquette committed rL338160: Recommit "Enable MachineOutliner by default under -Oz for AArch64".
Recommit "Enable MachineOutliner by default under -Oz for AArch64"
Jul 27 2018, 1:18 PM
paquette committed rL338148: [MachineOutliner] Exit getOutliningCandidateInfo when we erase all candidates.
[MachineOutliner] Exit getOutliningCandidateInfo when we erase all candidates
Jul 27 2018, 11:24 AM
paquette committed rL338136: Revert "Enable MachineOutliner by default under -Oz for AArch64".
Revert "Enable MachineOutliner by default under -Oz for AArch64"
Jul 27 2018, 10:25 AM
paquette closed D45916: Enable MachineOutliner by default under -Oz for AArch64.

Committed in r338133. (https://reviews.llvm.org/rL338133)

Jul 27 2018, 9:45 AM