paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (91 w, 4 d)

oh boy

Recent Activity

Fri, Aug 17

paquette committed rL340078: Add ability to track linker memory usage.
Add ability to track linker memory usage
Fri, Aug 17, 1:48 PM

Tue, Aug 14

paquette committed rL339725: Add mem_bytes to test_suite.py.
Add mem_bytes to test_suite.py
Tue, Aug 14, 1:51 PM

Mon, Jul 30

paquette closed D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.

Committed in r338278. (https://reviews.llvm.org/rL338278)

Mon, Jul 30, 10:46 AM
paquette committed rL338278: [MachineOutliner][AArch64] Add support for saving LR to a register.
[MachineOutliner][AArch64] Add support for saving LR to a register
Mon, Jul 30, 10:46 AM
paquette committed rL338272: Add machine verifier to arm64-opt-remarks-lazy-bfi.
Add machine verifier to arm64-opt-remarks-lazy-bfi
Mon, Jul 30, 10:13 AM
paquette added a comment to rL338267: Attempt to fix Windows test failure caused by r338133.

Oh, it turns out this isn't just Windows. It's just that the verifier was running on those bots. Doh.

Mon, Jul 30, 10:04 AM
paquette added a comment to rL338133: Enable MachineOutliner by default under -Oz for AArch64.

It seems like the issue is that on Windows, we also insert a 'Verify generated machine code' pass.

Mon, Jul 30, 9:39 AM
paquette committed rL338267: Attempt to fix Windows test failure caused by r338133.
Attempt to fix Windows test failure caused by r338133
Mon, Jul 30, 9:36 AM
paquette added a comment to rL338133: Enable MachineOutliner by default under -Oz for AArch64.

Sorry for the late response. Looking into the test failure now.

Mon, Jul 30, 8:53 AM

Fri, Jul 27

paquette updated the diff for D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.

Updated the diff. We now just look over the GPR64 register class instead of callee-saves.

Fri, Jul 27, 5:19 PM
paquette added inline comments to D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.
Fri, Jul 27, 5:11 PM
paquette committed rL338160: Recommit "Enable MachineOutliner by default under -Oz for AArch64".
Recommit "Enable MachineOutliner by default under -Oz for AArch64"
Fri, Jul 27, 1:18 PM
paquette committed rL338148: [MachineOutliner] Exit getOutliningCandidateInfo when we erase all candidates.
[MachineOutliner] Exit getOutliningCandidateInfo when we erase all candidates
Fri, Jul 27, 11:24 AM
paquette committed rL338136: Revert "Enable MachineOutliner by default under -Oz for AArch64".
Revert "Enable MachineOutliner by default under -Oz for AArch64"
Fri, Jul 27, 10:25 AM
paquette closed D45916: Enable MachineOutliner by default under -Oz for AArch64.

Committed in r338133. (https://reviews.llvm.org/rL338133)

Fri, Jul 27, 9:45 AM
paquette committed rL338133: Enable MachineOutliner by default under -Oz for AArch64.
Enable MachineOutliner by default under -Oz for AArch64
Fri, Jul 27, 9:45 AM

Thu, Jul 26

paquette accepted D49880: [MachineOutliner] Clean up subtarget handling..

LGTM

Thu, Jul 26, 3:58 PM
paquette created D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.
Thu, Jul 26, 3:52 PM

Tue, Jul 24

paquette committed rL337849: [MachineOutliner][NFC] Move outlined function remark into its own function.
[MachineOutliner][NFC] Move outlined function remark into its own function
Tue, Jul 24, 1:21 PM
paquette committed rL337848: [MachineOutliner][NFC] Move target frame info into OutlinedFunction.
[MachineOutliner][NFC] Move target frame info into OutlinedFunction
Tue, Jul 24, 1:13 PM
paquette committed rL337840: [MachineOutliner][NFC] Make Candidates own their call information.
[MachineOutliner][NFC] Make Candidates own their call information
Tue, Jul 24, 10:42 AM
paquette committed rL337839: [MachineOutliner][NFC] Move missed opt remark into its own function.
[MachineOutliner][NFC] Move missed opt remark into its own function
Tue, Jul 24, 10:37 AM
paquette committed rL337838: [MachineOutliner][NFC] Sink some candidate logic into OutlinedFunction.
[MachineOutliner][NFC] Sink some candidate logic into OutlinedFunction
Tue, Jul 24, 10:36 AM

Jul 18 2018

paquette added inline comments to D44910: [docs] Add Markdown support to Sphinx.
Jul 18 2018, 9:55 AM
paquette added inline comments to D44910: [docs] Add Markdown support to Sphinx.
Jul 18 2018, 9:40 AM

Jul 13 2018

paquette accepted D49299: [MachineOutliner][X86] Use TAILJMPd64 instead of JMP_1 for TailCall construction.

This looks good to me.

Jul 13 2018, 9:00 AM
paquette accepted D49295: [MachineOutliner] Check the last instruction from the sequence when updating liveness.

LGTM, thanks for catching that!

Jul 13 2018, 8:56 AM

Jul 6 2018

paquette committed rC336471: [MachineOutliner] Properly pass -moutline along to the toolchain.
[MachineOutliner] Properly pass -moutline along to the toolchain
Jul 6 2018, 3:30 PM
paquette committed rL336471: [MachineOutliner] Properly pass -moutline along to the toolchain.
[MachineOutliner] Properly pass -moutline along to the toolchain
Jul 6 2018, 3:29 PM
paquette accepted D49023: [MachineOutliner] Assert that Liveness tracking is accurate (NFC).

LGTM

Jul 6 2018, 1:23 PM
paquette added inline comments to D49023: [MachineOutliner] Assert that Liveness tracking is accurate (NFC).
Jul 6 2018, 8:53 AM

Jul 3 2018

paquette accepted D48867: [MachineOutliner] Fix typo in getOutliningCandidateInfo function name.

LGTM

Jul 3 2018, 12:12 PM

Jun 29 2018

paquette closed D48776: [MachineOutliner] Add support for target-default outlining.

Committed in r336040.

Jun 29 2018, 9:01 PM
paquette committed rL336040: [MachineOutliner] Add support for target-default outlining..
[MachineOutliner] Add support for target-default outlining.
Jun 29 2018, 9:01 PM
paquette committed rL336001: [MachineOutliner] Make -mno-outline use -enable-machine-outliner=never.
[MachineOutliner] Make -mno-outline use -enable-machine-outliner=never
Jun 29 2018, 11:11 AM
paquette committed rC336001: [MachineOutliner] Make -mno-outline use -enable-machine-outliner=never.
[MachineOutliner] Make -mno-outline use -enable-machine-outliner=never
Jun 29 2018, 11:11 AM
paquette updated the diff for D45916: Enable MachineOutliner by default under -Oz for AArch64.

Updated the patch so that it relies on the changes in D48776. That patch provides the scaffolding for allowing the outliner to be turned on by default by some target. This one flips the switch on AArch64 for -Oz.

Jun 29 2018, 10:48 AM
paquette created D48776: [MachineOutliner] Add support for target-default outlining.
Jun 29 2018, 10:17 AM
paquette closed D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.

Committed in r335986.
https://reviews.llvm.org/rL335986

Jun 29 2018, 9:18 AM
paquette committed rL335986: [MachineOutliner] Add always and never options to -enable-machine-outliner.
[MachineOutliner] Add always and never options to -enable-machine-outliner
Jun 29 2018, 9:17 AM

Jun 28 2018

paquette committed rL335930: [MachineOutliner] Never add the outliner in -O0.
[MachineOutliner] Never add the outliner in -O0
Jun 28 2018, 2:54 PM
paquette updated the diff for D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.

Removed the reference to enable-linkonceodr-outlining, since it was confusing.

Jun 28 2018, 11:04 AM
paquette added a comment to D48683: [MachineOutliner] Define MachineOutliner support in TargetOptions.

This was actually committed in r335887.

Jun 28 2018, 10:51 AM
paquette committed rL335887: [MachineOutliner] Define MachineOutliner support in TargetOptions.
[MachineOutliner] Define MachineOutliner support in TargetOptions
Jun 28 2018, 10:50 AM
paquette committed rL335883: Revert "[MachineOutliner] Add always and never options to -enable-machine….
Revert "[MachineOutliner] Add always and never options to -enable-machine…
Jun 28 2018, 10:31 AM
paquette committed rL335882: Revert "[MachineOutliner] Never add the outliner in -O0".
Revert "[MachineOutliner] Never add the outliner in -O0"
Jun 28 2018, 10:31 AM
paquette added a comment to D48683: [MachineOutliner] Define MachineOutliner support in TargetOptions.

Argh. I accidentally pushed https://reviews.llvm.org/D48682 instead of this. I'll revert it and push this instead. I haven't had enough coffee this morning.

Jun 28 2018, 10:21 AM
paquette added inline comments to D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.
Jun 28 2018, 10:17 AM
paquette committed rL335879: [MachineOutliner] Never add the outliner in -O0.
[MachineOutliner] Never add the outliner in -O0
Jun 28 2018, 10:10 AM
paquette committed rL335872: [MachineOutliner] Add always and never options to -enable-machine-outliner.
[MachineOutliner] Add always and never options to -enable-machine-outliner
Jun 28 2018, 9:47 AM
paquette closed D48683: [MachineOutliner] Define MachineOutliner support in TargetOptions.

Committed in r335872.

Jun 28 2018, 9:47 AM
paquette added inline comments to D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.
Jun 28 2018, 8:57 AM

Jun 27 2018

paquette created D48683: [MachineOutliner] Define MachineOutliner support in TargetOptions.
Jun 27 2018, 4:35 PM
paquette created D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.
Jun 27 2018, 4:30 PM
paquette added a comment to D45916: Enable MachineOutliner by default under -Oz for AArch64.

Yeah this is too big. I'll split this up into a few patches then update this one to just reflect turning the outliner on once I'm done...

Jun 27 2018, 4:29 PM
paquette closed D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Committed in r335758 (https://reviews.llvm.org/rL335758).

Jun 27 2018, 10:49 AM
paquette committed rL335758: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.
[MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across
Jun 27 2018, 10:48 AM
paquette updated the diff for D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Updated diff.

Jun 27 2018, 10:22 AM
paquette added a comment to D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Nevermind, the issue is my fault; should be (MachineBasicBlock::reverse_iterator)front(), not ++(MachineBasicBlock::reverse_iterator)front(). The resulting issue is tricky to debug because MachineInstrs are a circular linked list.

Ah, okay, I'll update the patch with that in a second.

Jun 27 2018, 9:12 AM

Jun 26 2018

paquette committed rL335672: [MachineOutliner] Emit a warning when using -moutline on unsupported targets.
[MachineOutliner] Emit a warning when using -moutline on unsupported targets
Jun 26 2018, 3:14 PM
paquette committed rC335672: [MachineOutliner] Emit a warning when using -moutline on unsupported targets.
[MachineOutliner] Emit a warning when using -moutline on unsupported targets
Jun 26 2018, 3:14 PM
paquette committed rL335668: [X86][AsmParser] Recommit r335658.
[X86][AsmParser] Recommit r335658
Jun 26 2018, 2:35 PM
paquette committed rL335660: Revert "[X86][AsmParser] Emit an error when RIP-relative instructions are used….
Revert "[X86][AsmParser] Emit an error when RIP-relative instructions are used…
Jun 26 2018, 2:02 PM
paquette closed D48605: [X86][AsmParser] Emit an error when RIP-relative instructions are used in 32-bit mode.

Thanks! Committed in r335658.

Jun 26 2018, 1:39 PM
paquette committed rL335658: [X86][AsmParser] Emit an error when RIP-relative instructions are used in 32….
[X86][AsmParser] Emit an error when RIP-relative instructions are used in 32…
Jun 26 2018, 1:38 PM
paquette created D48605: [X86][AsmParser] Emit an error when RIP-relative instructions are used in 32-bit mode.
Jun 26 2018, 1:25 PM

Jun 25 2018

paquette committed rL335549: [MachineOutliner] NFC - simplify -moutline/-mno-outline logic.
[MachineOutliner] NFC - simplify -moutline/-mno-outline logic
Jun 25 2018, 4:25 PM
paquette committed rC335549: [MachineOutliner] NFC - simplify -moutline/-mno-outline logic.
[MachineOutliner] NFC - simplify -moutline/-mno-outline logic
Jun 25 2018, 4:24 PM
paquette committed rL335504: [MachineOutliner] Outline from linkonceodrs by default in LTO when -moutline is….
[MachineOutliner] Outline from linkonceodrs by default in LTO when -moutline is…
Jun 25 2018, 10:40 AM
paquette committed rC335504: [MachineOutliner] Outline from linkonceodrs by default in LTO when -moutline is….
[MachineOutliner] Outline from linkonceodrs by default in LTO when -moutline is…
Jun 25 2018, 10:40 AM
paquette committed rC335503: [MachineOutliner] Make last of -moutline/-mno-outline win.
[MachineOutliner] Make last of -moutline/-mno-outline win
Jun 25 2018, 10:32 AM
paquette committed rL335503: [MachineOutliner] Make last of -moutline/-mno-outline win.
[MachineOutliner] Make last of -moutline/-mno-outline win
Jun 25 2018, 10:32 AM
paquette updated the diff for D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Updated diff to actually fix the LRU stuff (oops).

Jun 25 2018, 10:08 AM

Jun 22 2018

paquette updated the diff for D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Fixed my mistake using LiveRegUnits. This just walks back across the entire MBB now, so that we know if a register is live across the candidate.

Jun 22 2018, 3:16 PM

Jun 21 2018

paquette updated the diff for D45916: Enable MachineOutliner by default under -Oz for AArch64.

Updated the patch so that it no longer causes issues for the AMDGPU target. The outliner is now only added to the pass pipeline if a target specifies that it supports it in its TargetOptions. After this, whether or not a target supports the outliner must be defined within a specific TargetMachine (similar to GlobalIsel).

Jun 21 2018, 2:01 PM

Jun 20 2018

paquette committed rL335153: [MachineOutliner] Add debug info test for the outliner.
[MachineOutliner] Add debug info test for the outliner
Jun 20 2018, 11:46 AM
paquette added a comment to D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Ping! :)

Jun 20 2018, 9:27 AM

Jun 19 2018

paquette committed rL335076: [MachineOutliner] NFC: Remove insertOutlinerPrologue, rename….
[MachineOutliner] NFC: Remove insertOutlinerPrologue, rename…
Jun 19 2018, 2:19 PM

Jun 13 2018

paquette added a comment to D48109: [Timers] Use the pass argument name for JSON keys in time-passes.

This would make much more sense IMO. Especially for passes with long names. (For example, I'd much rather see "patchable-function" than "Implement the 'patchable-function' attribute" in the JSON)

Jun 13 2018, 9:44 AM

Jun 12 2018

paquette updated the diff for D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Fixed comments.

Jun 12 2018, 3:03 PM
paquette updated the diff for D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.
  • Added a comment for saving/restoring LR
  • Removed LRUOut, since it's not necessary here, and incurs unnecessary calculation
  • LRUIn -> LRU
Jun 12 2018, 10:00 AM
paquette added inline comments to D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.
Jun 12 2018, 9:21 AM

Jun 11 2018

paquette updated the diff for D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Updated patch to handle the live-in case. Updated the test to be more explicit as well.

Jun 11 2018, 10:00 AM

Jun 4 2018

paquette closed D47654: [MachineOutliner] NFC - Move intermediate data structures to MachineOutliner.h.

Closed in r333952 (https://reviews.llvm.org/rL333952)

Jun 4 2018, 2:19 PM
paquette committed rL333952: [MachineOutliner] NFC - Move intermediate data structures to MachineOutliner.h.
[MachineOutliner] NFC - Move intermediate data structures to MachineOutliner.h
Jun 4 2018, 2:18 PM

Jun 1 2018

paquette added a comment to D47553: Add TargetLowering::shouldExpandAtomicToLibCall and query it from AtomicExpandPass.
In D47553#1119498, @asb wrote:

I think I can disable outlining for an entire function using isFunctionSafeToOutlineFrom

Yeah, that'll work. It's conservative, but it will ensure that the outliner will never touch the function, and thus, won't touch the instructions (or anything between them).

Jun 1 2018, 4:37 PM
paquette added inline comments to D47654: [MachineOutliner] NFC - Move intermediate data structures to MachineOutliner.h.
Jun 1 2018, 4:28 PM
paquette updated the diff for D47654: [MachineOutliner] NFC - Move intermediate data structures to MachineOutliner.h.

Got rid of the whitespace changes and remembered to pass -U999999 this time.

Jun 1 2018, 4:20 PM
paquette added a dependent revision for D47654: [MachineOutliner] NFC - Move intermediate data structures to MachineOutliner.h: D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.
Jun 1 2018, 2:32 PM
paquette added a dependency for D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across: D47654: [MachineOutliner] NFC - Move intermediate data structures to MachineOutliner.h.
Jun 1 2018, 2:32 PM
paquette created D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.
Jun 1 2018, 2:31 PM
paquette created D47654: [MachineOutliner] NFC - Move intermediate data structures to MachineOutliner.h.
Jun 1 2018, 2:25 PM

May 22 2018

paquette accepted D47173: [MachineOutliner] Add "thunk" outlining for AArch64..

Cool! LGTM.

May 22 2018, 10:14 AM

May 18 2018

paquette updated subscribers of D38768: Add remarks describing when a pass changes the IR instruction count of a module.

Ah, you’re right.

May 18 2018, 1:09 PM
paquette committed rL332758: [NFC] Change cast from r332739 to a static cast.
[NFC] Change cast from r332739 to a static cast
May 18 2018, 1:08 PM
paquette closed D38768: Add remarks describing when a pass changes the IR instruction count of a module.

Committed as r332739.

May 18 2018, 10:31 AM
paquette committed rL332739: Add remarks describing when a pass changes the IR instruction count of a module.
Add remarks describing when a pass changes the IR instruction count of a module
May 18 2018, 10:30 AM
paquette added inline comments to D38768: Add remarks describing when a pass changes the IR instruction count of a module.
May 18 2018, 10:10 AM
paquette updated the diff for D38768: Add remarks describing when a pass changes the IR instruction count of a module.

Updated patch to address review.

May 18 2018, 10:08 AM

May 17 2018

paquette updated the diff for D38768: Add remarks describing when a pass changes the IR instruction count of a module.

A few changes here after running this on some more complicated code.

May 17 2018, 11:26 AM