- User Since
- Nov 17 2016, 12:59 PM (100 w, 1 d)
Wed, Oct 10
Fri, Oct 5
Thanks! Committed in r343885. (https://reviews.llvm.org/rL343885)
Thu, Oct 4
Just one more round of comments.
As long as you add a FIXME saying that we should move this responsibility over to the verifier, this LGTM.
I think this is probably really the only thing the outliner does that upsets the verifier. So, from that perspective, I think that this is fine.
Tue, Oct 2
Mostly style nits here.
Tue, Sep 25
Thu, Sep 20
Sep 17 2018
Sep 11 2018
Sep 10 2018
Sep 6 2018
Committed in r341588.
Sep 4 2018
Forgot to address a review comment; just did that.
Updated patch to reflect the NFC changes I put in to speed up size remarks.
Aug 31 2018
TIL that including "-O2" in a commit message will transform it into "https://reviews.llvm.org/owners/package/2/" when you hit reviews.llvm.org.
Aug 30 2018
I ran this with a debug build, and I noticed it's pretty heavy wrt compile time. I'm working on fixing that before committing.
Added some style nits.
Aug 29 2018
Aug 28 2018
Added some nits on comments. These could be done in a follow-up patch. I think a lot of these comments could use a style update.
Aug 17 2018
Aug 14 2018
Jul 30 2018
Committed in r338278. (https://reviews.llvm.org/rL338278)
Oh, it turns out this isn't just Windows. It's just that the verifier was running on those bots. Doh.
It seems like the issue is that on Windows, we also insert a 'Verify generated machine code' pass.
Sorry for the late response. Looking into the test failure now.
Jul 27 2018
Updated the diff. We now just look over the GPR64 register class instead of callee-saves.
Committed in r338133. (https://reviews.llvm.org/rL338133)
Jul 26 2018
Jul 24 2018
Jul 18 2018
Jul 13 2018
This looks good to me.
LGTM, thanks for catching that!
Jul 6 2018
Jul 3 2018
Jun 29 2018
Committed in r336040.
Updated the patch so that it relies on the changes in D48776. That patch provides the scaffolding for allowing the outliner to be turned on by default by some target. This one flips the switch on AArch64 for -Oz.
Committed in r335986.
Jun 28 2018
Removed the reference to enable-linkonceodr-outlining, since it was confusing.
This was actually committed in r335887.
Argh. I accidentally pushed https://reviews.llvm.org/D48682 instead of this. I'll revert it and push this instead. I haven't had enough coffee this morning.
Committed in r335872.
Jun 27 2018
Yeah this is too big. I'll split this up into a few patches then update this one to just reflect turning the outliner on once I'm done...
Committed in r335758 (https://reviews.llvm.org/rL335758).
Ah, okay, I'll update the patch with that in a second.