Page MenuHomePhabricator
People paquette

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (165 w, 4 d)

oh boy

Recent Activity
View All

Thu, Jan 16

paquette committed rGb82d18e1e8e6: [AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS (authored by paquette).
[AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS
Thu, Jan 16, 3:24 PM
paquette closed D72814: [AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS.
Thu, Jan 16, 3:24 PM · Restricted Project
paquette updated the diff for D72814: [AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS.
  • Don't use getZExtValue
  • Add asserts that we're getting a G_FCONSTANT
Thu, Jan 16, 1:45 PM · Restricted Project
paquette added a comment to D72814: [AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS.

When we go through gpr, there might be fp immediate values which cannot be represented with a single instruction GPR register materialization, instead requiring movk/movz.

Thu, Jan 16, 11:39 AM · Restricted Project
paquette accepted D72608: GlobalISel: Don't ignore requested ext narrowing type.

LGTM

Thu, Jan 16, 9:25 AM · Restricted Project
paquette accepted D72512: GlobalISel: Move extension scalar narrowing to separate function.

LGTM

Thu, Jan 16, 9:25 AM · Restricted Project
paquette accepted D72603: GlobalISel: Apply target MMO flags to atomics.

LGTM

Thu, Jan 16, 9:25 AM · Restricted Project
paquette accepted D72599: GlobalISel: Preserve load/store metadata in IRTranslator.

LGTM

Thu, Jan 16, 9:25 AM · Restricted Project
paquette accepted D72851: TableGen/GlobalISel: Fix srcvalue inputs.

LGTM

Thu, Jan 16, 9:16 AM · Restricted Project

Wed, Jan 15

paquette added a comment to D72814: [AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS.

Also I have no idea if this is how we want to do target-specific combines, so if there's a better way to do it, I'll take it.

Wed, Jan 15, 4:34 PM · Restricted Project
paquette created D72814: [AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS.
Wed, Jan 15, 4:32 PM · Restricted Project

Mon, Jan 13

paquette added inline comments to D72608: GlobalISel: Don't ignore requested ext narrowing type.
Mon, Jan 13, 11:03 AM · Restricted Project

Fri, Jan 10

paquette committed rGceb801612a67: [AArch64] Don't generate libcalls for wide shifts on Darwin (authored by paquette).
[AArch64] Don't generate libcalls for wide shifts on Darwin
Fri, Jan 10, 4:07 PM

Thu, Jan 9

paquette committed rGff658e14a884: Merge commit 'refs/am/changes/dde7b6bcda9d8cf874fd77b98d0d62d6aeaed049_apple/ma… (authored by paquette).
Merge commit 'refs/am/changes/dde7b6bcda9d8cf874fd77b98d0d62d6aeaed049_apple/ma…
Thu, Jan 9, 5:15 PM
paquette committed rG62da741ad3a9: Merge commit 'refs/am/changes/a6d57a8cd4cfa2a8395eaa6599fc12f7509f98f0_apple/ma… (authored by paquette).
Merge commit 'refs/am/changes/a6d57a8cd4cfa2a8395eaa6599fc12f7509f98f0_apple/ma…
Thu, Jan 9, 5:13 PM
paquette committed rG94ead1300f17: Merge commit 'refs/am/changes/3ce3d23facf146698c4ef6107d1b9425b3ff5764_apple/ma… (authored by paquette).
Merge commit 'refs/am/changes/3ce3d23facf146698c4ef6107d1b9425b3ff5764_apple/ma…
Thu, Jan 9, 5:07 PM
paquette committed rG51c6f929c723: Merge commit 'refs/am/changes/d53e61863d48a07ce285d5b0a36abc67583023bd_apple/ma… (authored by paquette).
Merge commit 'refs/am/changes/d53e61863d48a07ce285d5b0a36abc67583023bd_apple/ma…
Thu, Jan 9, 5:06 PM
paquette accepted D72407: TableGen/GlobalISel: Add way for SDNodeXForm to work on timm.

LGTM

Thu, Jan 9, 2:00 PM · Restricted Project
paquette accepted D72424: TableGen/GlobalISel: Fix pattern matching of immarg literals.

LGTM

Thu, Jan 9, 1:50 PM · Restricted Project
paquette accepted D72422: [AArch64][GlobalISel] Implement selection of <2 x float> vector splat..

LGTM

Thu, Jan 9, 12:25 PM · Restricted Project
paquette committed rG9949b1a1753a: [GlobalISel][AArch64] Import + select LDR*roW and STR*roW patterns (authored by paquette).
[GlobalISel][AArch64] Import + select LDR*roW and STR*roW patterns
Thu, Jan 9, 12:17 PM
paquette closed D72426: [GlobalISel][AArch64] Import + select LDR*roW and STR*roW patterns.
Thu, Jan 9, 12:16 PM · Restricted Project
paquette accepted D72170: AMDGPU/GlobalISel: Fix argument lowering for vectors of pointers.

Currently all targets seem to be duplicating similar looking pack/unpack functions

That's kind of unfortunate.

Thu, Jan 9, 12:16 PM · Restricted Project
paquette added inline comments to D72407: TableGen/GlobalISel: Add way for SDNodeXForm to work on timm.
Thu, Jan 9, 12:07 PM · Restricted Project
paquette added inline comments to D72424: TableGen/GlobalISel: Fix pattern matching of immarg literals.
Thu, Jan 9, 12:07 PM · Restricted Project
paquette accepted D72428: TableGen/GlobalISel: Address fixme.

LGTM

Thu, Jan 9, 9:27 AM · Restricted Project

Wed, Jan 8

paquette added inline comments to D72422: [AArch64][GlobalISel] Implement selection of <2 x float> vector splat..
Wed, Jan 8, 4:42 PM · Restricted Project
paquette created D72426: [GlobalISel][AArch64] Import + select LDR*roW and STR*roW patterns.
Wed, Jan 8, 4:24 PM · Restricted Project

Tue, Jan 7

paquette accepted D72351: [AArch64][GlobalISel] Fold a chain of two G_PTR_ADDs of constant offsets..

LGTM

Tue, Jan 7, 11:52 AM · Restricted Project
paquette added inline comments to D72351: [AArch64][GlobalISel] Fold a chain of two G_PTR_ADDs of constant offsets..
Tue, Jan 7, 11:41 AM · Restricted Project
paquette committed rGacd258082477: [MachineOutliner][AArch64] Save + restore LR in noreturn functions (authored by paquette).
[MachineOutliner][AArch64] Save + restore LR in noreturn functions
Tue, Jan 7, 11:31 AM

Mon, Jan 6

paquette added inline comments to D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
Mon, Jan 6, 2:17 PM · Restricted Project
paquette accepted D72037: TableGen/GlobalISel: Handle default operands that are used.

LGTM

Mon, Jan 6, 2:07 PM · Restricted Project
paquette accepted D72264: GlobalISel: Implement s32->s64 G_FPTOSI lowering.

LGTM

Mon, Jan 6, 1:57 PM · Restricted Project
paquette added a comment to D72170: AMDGPU/GlobalISel: Fix argument lowering for vectors of pointers.

When these arguments are broken down by the EVT based callbacks, the pointer information is lost.

Mon, Jan 6, 1:57 PM · Restricted Project
paquette accepted D72263: GlobalISel: Correct result type for G_FCMP in lowerFPTOUI.

(I feel like a verifier should have caught this?)

Mon, Jan 6, 1:39 PM · Restricted Project
paquette added inline comments to D72264: GlobalISel: Implement s32->s64 G_FPTOSI lowering.
Mon, Jan 6, 1:39 PM · Restricted Project
paquette accepted D71858: GlobalISel: Implement lower for G_INTRINSIC_ROUND.

LGTM

Mon, Jan 6, 1:20 PM · Restricted Project
paquette accepted D72288: GlobalISel: Fix unsupported legalize action.

I think this seems reasonable.

Mon, Jan 6, 1:20 PM · Restricted Project

Dec 20 2019

paquette committed rGd5750770eb96: [NFC][MachineOutliner] Rewrite setSuffixIndices to be iterative (authored by paquette).
[NFC][MachineOutliner] Rewrite setSuffixIndices to be iterative
Dec 20 2019, 4:19 PM

Dec 19 2019

paquette committed rGdcaaede1e57e: [lit] Add "from .main import main" back into lit/__init__.py (authored by paquette).
[lit] Add "from .main import main" back into lit/__init__.py
Dec 19 2019, 4:11 PM
paquette committed rZORGbeec338bc850: Fix print function monorepo_build.py to fix test_monorepo_build.py (authored by paquette).
Fix print function monorepo_build.py to fix test_monorepo_build.py
Dec 19 2019, 3:20 PM
paquette committed rZORG94f63327278e: Fix issue with print statements in build.py (authored by paquette).
Fix issue with print statements in build.py
Dec 19 2019, 3:13 PM
paquette committed rZORG5d9ac9c5e2a6: [tasktool] Install default lit from pip (authored by paquette).
[tasktool] Install default lit from pip
Dec 19 2019, 1:42 PM
paquette accepted D71721: [AArch64] [Windows] Use COFF stubs for calls to extern_weak functions.

LGTM

Dec 19 2019, 11:33 AM · Restricted Project
paquette added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

I think that it should be possible to write a test case for this. You don't really have to expose a *bug* here but just show that the exposed uses are added to the outlined function. That's sufficient for a testcase.

Dec 19 2019, 11:22 AM · Restricted Project

Dec 18 2019

paquette committed rZORG52de0fa652b1: [tasktool] Separate SVN checkout from pip install (authored by paquette).
[tasktool] Separate SVN checkout from pip install
Dec 18 2019, 3:26 PM
paquette committed rZORGe4009499ad7b: [tasktool] Update repos to point at GitHub repos (authored by paquette).
[tasktool] Update repos to point at GitHub repos
Dec 18 2019, 2:48 PM
paquette committed rZORG70fd0a372df6: [tasktool] Try to make pip happy with installing lit (authored by paquette).
[tasktool] Try to make pip happy with installing lit
Dec 18 2019, 1:32 PM
paquette committed rZORG3588a67a1045: [tasktool] Use the magical GitHub SVN support to checkout lit (authored by paquette).
[tasktool] Use the magical GitHub SVN support to checkout lit
Dec 18 2019, 10:56 AM
paquette committed rZORGab420dccfa24: Remove outdated llvm-mirror git link in README.md (authored by paquette).
Remove outdated llvm-mirror git link in README.md
Dec 18 2019, 10:25 AM
paquette committed rZORG771fd2bd1a33: Use official LLVM GitHub repo in zorg/jenkins/jobs/config instead of mirror (authored by paquette).
Use official LLVM GitHub repo in zorg/jenkins/jobs/config instead of mirror
Dec 18 2019, 10:16 AM
paquette committed rZORG93352290bda3: Don't use SVN to pull the test suite, zorg, or LNT in jenkins/common.groovy (authored by paquette).
Don't use SVN to pull the test suite, zorg, or LNT in jenkins/common.groovy
Dec 18 2019, 10:16 AM

Dec 17 2019

paquette accepted D71587: [AArch64][GlobalISel]: Fix a crash in GlobalIsel in dealing with 16bit uadd.with.overflow..
Dec 17 2019, 11:56 AM · Restricted Project
paquette accepted D71587: [AArch64][GlobalISel]: Fix a crash in GlobalIsel in dealing with 16bit uadd.with.overflow..

Thanks for fixing this!

Dec 17 2019, 9:26 AM · Restricted Project

Dec 13 2019

paquette accepted D71448: [Legalizer] Making artifact combining order-independent.

LGTM aside from some places where a couple comments can be added.

Dec 13 2019, 11:56 AM · Restricted Project

Dec 12 2019

paquette committed rG9e86a5ba41fc: Merge branch 'master' into upstream-with-swift (authored by paquette).
Merge branch 'master' into upstream-with-swift
Dec 12 2019, 12:15 PM

Dec 10 2019

paquette accepted D70562: [LiveRegUnits] Add phys_regs_and_masks iterator range (NFC)..

LGTM!

Dec 10 2019, 2:40 PM · Restricted Project

Dec 6 2019

paquette added inline comments to D70562: [LiveRegUnits] Add phys_regs_and_masks iterator range (NFC)..
Dec 6 2019, 4:16 PM · Restricted Project
paquette accepted D70566: [MCRegInfo] Add sub_and_superregs_inclusive iterator range..

I don't suppose it's possible to add a testcase for this somehow? Not sure if there's any infrastructure for that.

Dec 6 2019, 4:16 PM · Restricted Project
paquette accepted D71153: [AArch64][GlobalISel] Add support for selection of vector G_SHL with immediates..

LGTM

Dec 6 2019, 4:07 PM · Restricted Project

Dec 5 2019

paquette accepted D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing..

LGTM!

Dec 5 2019, 3:07 PM · Restricted Project

Nov 19 2019

paquette added inline comments to D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing..
Nov 19 2019, 10:24 AM · Restricted Project

Nov 11 2019

paquette accepted D69416: [Examples] Add IRTransformations directory to examples..

LGTM aside from typos

Nov 11 2019, 2:56 PM · Restricted Project

Nov 6 2019

paquette added a comment to D69920: [AArch64] Use callee calling convention for RegMask and return value.

Sure! I just need to get my commit access transferred from SVN to GitHub and then I'll commit it for you.

Nov 6 2019, 2:59 PM · Restricted Project
paquette accepted D69920: [AArch64] Use callee calling convention for RegMask and return value.
Nov 6 2019, 1:34 PM · Restricted Project
paquette added a comment to D69920: [AArch64] Use callee calling convention for RegMask and return value.

Nice! LGTM

Nov 6 2019, 1:34 PM · Restricted Project

Oct 29 2019

paquette committed rG6757930b01ba: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective (authored by juliehockett).
[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective
Oct 29 2019, 4:17 PM
paquette committed rGc8136cea1aa9: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by paquette).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 4:17 PM
paquette committed rG66628f170904: Fix link error introduced in previous merge (authored by paquette).
Fix link error introduced in previous merge
Oct 29 2019, 4:17 PM
paquette added a comment to rGcbcb85bb7072: Merge remote-tracking branch 'trunk/master' into github/upstream-with-swift.

I'm sorry, what?

Oct 29 2019, 3:01 PM
paquette committed rGcbcb85bb7072: Merge remote-tracking branch 'trunk/master' into github/upstream-with-swift (authored by paquette).
Merge remote-tracking branch 'trunk/master' into github/upstream-with-swift
Oct 29 2019, 3:00 PM

Oct 28 2019

paquette accepted D69482: [MachineOuliner][NFC] Refactoring code to make outline rerunning a cleaner diff..

LGTM

Oct 28 2019, 10:35 AM · Restricted Project
paquette added a comment to D69482: [MachineOuliner][NFC] Refactoring code to make outline rerunning a cleaner diff..

I think the implementation of doOutline is missing here?

Oct 28 2019, 9:04 AM · Restricted Project

Oct 25 2019

paquette added a comment to D69446: [llvm][MachineOutliner] Add support for repeating machine outliner N times. .

This is pretty cool, thanks for working on this.

Oct 25 2019, 1:25 PM · Restricted Project
paquette added inline comments to D69416: [Examples] Add IRTransformations directory to examples..
Oct 25 2019, 11:30 AM · Restricted Project
paquette added a comment to D69367: [GlobalISel][AArch64][AMDGPU][X86] Teach LegalizationArtifactCombiner to combine trunc(g_constant)..

Looking at D56706, @aditya_nandakumar said:

Oct 25 2019, 11:21 AM · Restricted Project

Oct 24 2019

paquette accepted D69367: [GlobalISel][AArch64][AMDGPU][X86] Teach LegalizationArtifactCombiner to combine trunc(g_constant)..

LGTM

Oct 24 2019, 10:56 AM · Restricted Project

Oct 21 2019

paquette added inline comments to D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
Oct 21 2019, 10:16 AM · Restricted Project
paquette added a comment to D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.

I think this needs some more tests. In particular, I'd like to see some test cases that show what happens when

Oct 21 2019, 9:58 AM · Restricted Project

Oct 18 2019

paquette accepted D69187: [GISel][CallLowering] Make isIncomingArgumentHandler a pure virtual method.

LGTM

Oct 18 2019, 11:44 AM · Restricted Project
paquette added inline comments to D67602: GlobalISel: Handle llvm.read_register.
Oct 18 2019, 10:49 AM
paquette added a comment to D67602: GlobalISel: Handle llvm.read_register.

Even though this was reverted, I'm going to necromance it to point out an issue with the approach wrt AArch64 in the inline comments.

Oct 18 2019, 10:02 AM

Oct 4 2019

paquette committed rG784892c9641a: [MachineOutliner] Disable outlining from noreturn functions (authored by paquette).
[MachineOutliner] Disable outlining from noreturn functions
Oct 4 2019, 2:31 PM
paquette committed rL373791: [MachineOutliner] Disable outlining from noreturn functions.
[MachineOutliner] Disable outlining from noreturn functions
Oct 4 2019, 2:22 PM

Sep 30 2019

paquette committed rGb1c1095fdc56: [AArch64][GlobalISel] Support lowering variadic musttail calls (authored by paquette).
[AArch64][GlobalISel] Support lowering variadic musttail calls
Sep 30 2019, 9:50 AM
paquette committed rL373226: [AArch64][GlobalISel] Support lowering variadic musttail calls.
[AArch64][GlobalISel] Support lowering variadic musttail calls
Sep 30 2019, 9:47 AM
paquette closed D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.
Sep 30 2019, 9:47 AM · Restricted Project

Sep 27 2019

paquette accepted D68151: [GlobalISel] Add an operand to memory intrinsics to denote the "tail" marker..

LGTM with test change

Sep 27 2019, 3:31 PM · Restricted Project
paquette added a comment to D68151: [GlobalISel] Add an operand to memory intrinsics to denote the "tail" marker..

Can we also have a check for say, __memcpy_chk?

Sep 27 2019, 11:37 AM · Restricted Project
paquette updated the diff for D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.

Refactor forwarding code, and factor out IRTranslator changes into a helper.

Sep 27 2019, 11:28 AM · Restricted Project

Sep 26 2019

paquette added inline comments to D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.
Sep 26 2019, 2:55 PM · Restricted Project

Sep 25 2019

paquette created D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.
Sep 25 2019, 11:49 AM · Restricted Project
paquette committed rG8535a8672e16: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering (authored by paquette).
[AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering
Sep 25 2019, 9:45 AM
paquette committed rL372897: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering.
[AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering
Sep 25 2019, 9:45 AM
paquette closed D67939: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering.
Sep 25 2019, 9:44 AM · Restricted Project

Sep 24 2019

paquette added a comment to D67939: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering.

I'm noticing that the existing test coverage for varargs tail calls has some room for improvement in general.

Sep 24 2019, 4:30 PM · Restricted Project
paquette added a comment to D67855: [X86] Add new calling convention that guarantees tail call optimization.

Looking back in the discussion, I think it's fine to have it act the same way as fastcc.

Sep 24 2019, 9:46 AM · Restricted Project
paquette added inline comments to D67855: [X86] Add new calling convention that guarantees tail call optimization.
Sep 24 2019, 9:20 AM · Restricted Project

Sep 23 2019

paquette created D67939: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering.
Sep 23 2019, 4:02 PM · Restricted Project