Page MenuHomePhabricator
People paquette

paquette (Jessica Paquette)
Jessica Paquette

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (330 w, 5 d)

no

Recent Activity
View All

Today

paquette committed rTaa159f7cbc51: Assert in codesize.py that we have exactly one of size..text and size.__text (authored by paquette).
Assert in codesize.py that we have exactly one of size..text and size.__text
Wed, Mar 22, 11:56 AM · Restricted Project
paquette closed D146567: Assert in codesize.py that we have exactly one of size..text and size.__text.
Wed, Mar 22, 11:56 AM · Restricted Project
paquette updated the diff for D146567: Assert in codesize.py that we have exactly one of size..text and size.__text.

Addressing review feedback before pushing

Wed, Mar 22, 11:54 AM · Restricted Project

Yesterday

paquette requested review of D146567: Assert in codesize.py that we have exactly one of size..text and size.__text.
Tue, Mar 21, 2:38 PM · Restricted Project
paquette added inline comments to D146260: Make code size metric names independent of platform.
Tue, Mar 21, 12:27 PM · Restricted Project
paquette committed rLNT7c485bf52e04: Restore code size tracking support in Darwin (authored by paquette).
Restore code size tracking support in Darwin
Tue, Mar 21, 11:23 AM · Restricted Project

Mon, Mar 20

paquette abandoned D146260: Make code size metric names independent of platform.

Over in D146257 we decided that we don't want to change the test suite, and would prefer the change to be local to LNT. We don't need this change.

Mon, Mar 20, 3:06 PM · Restricted Project
paquette updated the diff for D146257: Restore code size tracking support in Darwin.

Address review feedback

Mon, Mar 20, 3:05 PM · Restricted Project
paquette added inline comments to D146257: Restore code size tracking support in Darwin.
Mon, Mar 20, 1:50 PM · Restricted Project
paquette accepted D146375: [NFC][Outliner] Delete default ctors for Candidate & OutlinedFunction..

LGTM

Mon, Mar 20, 10:30 AM · Restricted Project, Restricted Project

Fri, Mar 17

paquette added a comment to D136774: [Outliner] Add an option to only enable outlining of patterns above a certain threshold.

The overhead of representing a new function in the binary depends on exception metadata and alignment

Fri, Mar 17, 6:19 PM · Restricted Project, Restricted Project
paquette accepted D139337: [IRSim] Treat Branch OperVals different from regular operands.

LGTM

Fri, Mar 17, 10:50 AM · Restricted Project, Restricted Project
paquette accepted D139336: [IRSim] Ensure that assignment accurately reduces potential mapping between different candidates.

I think this looks good, with a nit.

Fri, Mar 17, 10:49 AM · Restricted Project, Restricted Project
paquette accepted D139338: [IRSim] Check largest sections first when analyzing similarity.

LGTM

Fri, Mar 17, 10:48 AM · Restricted Project, Restricted Project

Thu, Mar 16

paquette added reviewers for D146260: Make code size metric names independent of platform: fhahn, cmatthews, azhar.
Thu, Mar 16, 2:16 PM · Restricted Project
paquette added reviewers for D146257: Restore code size tracking support in Darwin: fhahn, azhar, cmatthews.
Thu, Mar 16, 2:16 PM · Restricted Project
paquette updated the summary of D146257: Restore code size tracking support in Darwin.
Thu, Mar 16, 2:14 PM · Restricted Project
paquette requested review of D146260: Make code size metric names independent of platform.
Thu, Mar 16, 2:14 PM · Restricted Project
paquette requested review of D146257: Restore code size tracking support in Darwin.
Thu, Mar 16, 2:05 PM · Restricted Project

Wed, Mar 15

paquette added inline comments to D146105: [AArch64] Add hex comments to mov-imm spellings in the InstPrinter.
Wed, Mar 15, 10:43 AM · Restricted Project, Restricted Project
paquette accepted D146105: [AArch64] Add hex comments to mov-imm spellings in the InstPrinter.

LGTM

Wed, Mar 15, 10:42 AM · Restricted Project, Restricted Project

Tue, Mar 14

paquette added inline comments to D146105: [AArch64] Add hex comments to mov-imm spellings in the InstPrinter.
Tue, Mar 14, 10:44 PM · Restricted Project, Restricted Project
Herald added a project to D109576: [LNT] Fixed missing code_size metric: Restricted Project.

Hey, we noticed we haven't been getting size results in LNT as a result of this change.

Tue, Mar 14, 3:58 PM · Restricted Project, Restricted Project

Thu, Feb 23

paquette added inline comments to D144670: [AArch64][GlobalISel] Legalize G_SHUFFLE_VECTOR with smaller dest size.
Thu, Feb 23, 1:10 PM · Restricted Project, Restricted Project

Feb 17 2023

paquette accepted D144303: [GlobalISel] Combine out-of-range shifts to undef.

I think this seems reasonable?

Feb 17 2023, 2:45 PM · Restricted Project, Restricted Project
paquette accepted D141066: CodeExtractor: Fix creating addrspacecasts for lifetime markers.

LGTM

Feb 17 2023, 10:51 AM · Restricted Project, Restricted Project

Feb 13 2023

paquette accepted D143323: [ConstraintElim] Add reproducer remarks..

Only things I can think of that would be nice to add are

Feb 13 2023, 10:12 AM · Restricted Project, Restricted Project

Feb 9 2023

paquette accepted D125072: [MachineOutliner] Make getOutliningType partially target-independent.

This is nice, thank you.

Feb 9 2023, 11:13 AM · Restricted Project, Restricted Project

Feb 6 2023

paquette added inline comments to D143323: [ConstraintElim] Add reproducer remarks..
Feb 6 2023, 10:52 AM · Restricted Project, Restricted Project
paquette accepted D143387: AArch64/GISel: fall back to SDAG if a Darwin function needs varargs regs saved..

LGTM

Feb 6 2023, 10:38 AM · Restricted Project, Restricted Project

Feb 3 2023

paquette committed rGb514b45d7baa: Update test to be the correct version (authored by paquette).
Update test to be the correct version
Feb 3 2023, 11:23 PM · Restricted Project, Restricted Project
paquette committed rG92d3672452db: [MachineOutliner] Improve mapper statistics (authored by paquette).
[MachineOutliner] Improve mapper statistics
Feb 3 2023, 10:28 PM · Restricted Project, Restricted Project
paquette committed rGd1359acb9a4a: [MachineOutliner] NFC: Add debug output to populateMapper (authored by paquette).
[MachineOutliner] NFC: Add debug output to populateMapper
Feb 3 2023, 10:01 PM · Restricted Project, Restricted Project
paquette committed rG51fa03200f7e: [MachineOutliner] NFC: Add debug output to overlap pruning code (authored by paquette).
[MachineOutliner] NFC: Add debug output to overlap pruning code
Feb 3 2023, 5:44 PM · Restricted Project, Restricted Project
paquette committed rGfe35e142dffa: [MachineOutliner] NFC: Pull variable out from erase_if (authored by paquette).
[MachineOutliner] NFC: Pull variable out from erase_if
Feb 3 2023, 4:42 PM · Restricted Project, Restricted Project
paquette committed rG443c5b9fd505: [NFC] Remove redundant check for MBB being empty in outliner (authored by paquette).
[NFC] Remove redundant check for MBB being empty in outliner
Feb 3 2023, 4:42 PM · Restricted Project, Restricted Project
paquette committed rG7bb9d70bbb98: [NFC] Remove unneccessary `llvm::` in MachineOutliner/SuffixTree (authored by paquette).
[NFC] Remove unneccessary `llvm::` in MachineOutliner/SuffixTree
Feb 3 2023, 4:42 PM · Restricted Project, Restricted Project
paquette committed rGec37ebf59be7: [NFC] Use SmallVector/ArrayRef in MachineOutliner/SuffixTree for small types (authored by paquette).
[NFC] Use SmallVector/ArrayRef in MachineOutliner/SuffixTree for small types
Feb 3 2023, 4:42 PM · Restricted Project, Restricted Project
paquette committed rG4de8521bc528: [MachineOutliner][AArch64] NFC: Split MBBs into "outlinable ranges" (authored by paquette).
[MachineOutliner][AArch64] NFC: Split MBBs into "outlinable ranges"
Feb 3 2023, 3:34 PM · Restricted Project, Restricted Project

Jan 30 2023

paquette accepted D142791: [GlobalISel] Don't combine instructions with unknown type in hoist_logic_op_with_same_opcode_hands..

LGTM

Jan 30 2023, 10:07 AM · Restricted Project, Restricted Project

Jan 27 2023

paquette added inline comments to D142791: [GlobalISel] Don't combine instructions with unknown type in hoist_logic_op_with_same_opcode_hands..
Jan 27 2023, 4:52 PM · Restricted Project, Restricted Project

Dec 22 2022

paquette committed rGe0f5307f6382: Fix indentation in LangRef.rst (authored by paquette).
Fix indentation in LangRef.rst
Dec 22 2022, 11:45 AM · Restricted Project, Restricted Project
paquette added inline comments to D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it.
Dec 22 2022, 11:45 AM · Restricted Project, Restricted Project
paquette committed rG7ef8f9c972bb: [IR/MachineOutliner] Add a "nooutline" function attr and respect it (authored by paquette).
[IR/MachineOutliner] Add a "nooutline" function attr and respect it
Dec 22 2022, 10:23 AM · Restricted Project, Restricted Project
paquette closed D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it.
Dec 22 2022, 10:22 AM · Restricted Project, Restricted Project

Dec 21 2022

paquette added a comment to D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it.

Good to go then?

Dec 21 2022, 3:49 PM · Restricted Project, Restricted Project
paquette added a comment to D140302: [GlobalISel] [AArch64] Fold G_PTRTOINT(G_CONSTANT).
In D140302#4004963, @andcarminati wrote:
In D140302#4004906, @arsenm wrote:

Where are these coming from? I thought we directly emitted pointer constants now?

Well, we have this folding implemented in our development branch (custom target) and we think it is interesting for AArch64 too.

Dec 21 2022, 2:29 PM · Restricted Project, Restricted Project
paquette accepted D140305: [GlobalISel][Legalizer] add minScalarIf action.

LGTM

Dec 21 2022, 2:28 PM · Restricted Project, Restricted Project
paquette updated the diff for D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it.
  • Remove typed pointers from IR test
  • Move the attribute in the docs and mark it as a string
  • Remove unnecessary check for empty function in the MachineOutliner
  • Improve wording in docs
Dec 21 2022, 11:15 AM · Restricted Project, Restricted Project
paquette added a comment to D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it.
In D140438#4010322, @nikic wrote:

FWIW, if something affects IR semantics, I'd generally expect it to be a first-class attribute.

Dec 21 2022, 10:45 AM · Restricted Project, Restricted Project

Dec 20 2022

paquette added inline comments to D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it.
Dec 20 2022, 3:32 PM · Restricted Project, Restricted Project
paquette added a comment to D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it.

(somewhat straightforward, but I feel like adding something to the langref requires a LGTM from someone)

Dec 20 2022, 3:24 PM · Restricted Project, Restricted Project
paquette requested review of D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it.
Dec 20 2022, 3:24 PM · Restricted Project, Restricted Project

Dec 16 2022

paquette accepted D139418: [AArch64] GlobalIsel codegen for gpr CTZ.

I had two minor comments, but after you fix those, I think this is good to go.

Dec 16 2022, 11:24 AM · Restricted Project, Restricted Project
paquette added inline comments to D139419: [AArch64] lower abs intrinsic to new ABS instruction in GIsel.
Dec 16 2022, 11:23 AM · Restricted Project, Restricted Project

Dec 13 2022

paquette added a comment to D139443: [AArch64] Support SLC in ACLE prefetch intrinsics.

GISel part LGTM

Dec 13 2022, 10:32 AM · Restricted Project, Restricted Project, Restricted Project

Dec 7 2022

paquette added a comment to D80249: CodeGen: Don't lazily construct MachineFunctionInfo.
  1. Lazily constructing MFI is causing real pain, and makes it possible to write some silly bugs
  2. There haven't been any comments on this in a considerable amount of time, implying there aren't any strong opinions
  3. The drawback is that you have to type "MF" in some places
Dec 7 2022, 3:18 PM · Restricted Project, Restricted Project
paquette added inline comments to D139417: [AArch64] add GlobalIsel support for scalar CNT instruction.
Dec 7 2022, 2:16 PM · Restricted Project, Restricted Project
paquette added inline comments to D139418: [AArch64] GlobalIsel codegen for gpr CTZ.
Dec 7 2022, 2:11 PM · Restricted Project, Restricted Project
paquette added inline comments to D139420: [AArch64][GlobalISel] implement GPR (U/S)(MIN/MAX) instr support.
Dec 7 2022, 2:08 PM · Restricted Project, Restricted Project
paquette added inline comments to D139419: [AArch64] lower abs intrinsic to new ABS instruction in GIsel.
Dec 7 2022, 10:28 AM · Restricted Project, Restricted Project
paquette added inline comments to D139417: [AArch64] add GlobalIsel support for scalar CNT instruction.
Dec 7 2022, 10:23 AM · Restricted Project, Restricted Project

Dec 6 2022

paquette added a comment to D139336: [IRSim] Ensure that assignment accurately reduces potential mapping between different candidates.

Is it possible to write a testcase?

Dec 6 2022, 10:49 AM · Restricted Project, Restricted Project
paquette added inline comments to D139338: [IRSim] Check largest sections first when analyzing similarity.
Dec 6 2022, 10:45 AM · Restricted Project, Restricted Project
paquette added a comment to D139338: [IRSim] Check largest sections first when analyzing similarity.

Can we add a statistic which calculates the average size of an outlinable region?

Dec 6 2022, 10:36 AM · Restricted Project, Restricted Project
paquette added inline comments to D139337: [IRSim] Treat Branch OperVals different from regular operands.
Dec 6 2022, 10:35 AM · Restricted Project, Restricted Project
paquette added a comment to D139337: [IRSim] Treat Branch OperVals different from regular operands.

Testcase?

Dec 6 2022, 10:29 AM · Restricted Project, Restricted Project
paquette added inline comments to D139334: [IRSim] Reduce IROutliner Compile time by reducing the number of time the CodeExtractorCache is rebuilt..
Dec 6 2022, 10:28 AM · Restricted Project, Restricted Project
paquette added a comment to D139336: [IRSim] Ensure that assignment accurately reduces potential mapping between different candidates.

Is this one of the compile time patches we discussed offline? If so, could you mention that + an overview of the improvements in the commit message?

Dec 6 2022, 10:24 AM · Restricted Project, Restricted Project
paquette accepted D137631: AArch64: implement canonical `!isnan(...)` with single compare..

LGTM

Dec 6 2022, 10:08 AM · Restricted Project, Restricted Project
paquette accepted D137905: [GlobalISel] Add a new G_INVOKE_REGION_START instruction to fix an EH bug.

I think this looks good at this point

Dec 6 2022, 9:50 AM · Restricted Project, Restricted Project
paquette accepted D138454: GlobalISel: Enable CSE of G_SELECT.

:GTM

Dec 6 2022, 9:48 AM · Restricted Project, Restricted Project

Nov 18 2022

paquette accepted D138303: GlobalISel: Legalize strict_fsub.

LGTM

Nov 18 2022, 2:48 PM · Restricted Project, Restricted Project
paquette added a comment to D138303: GlobalISel: Legalize strict_fsub.

Looks like there are some unrelated changes in here?

Nov 18 2022, 10:31 AM · Restricted Project, Restricted Project

Nov 16 2022

paquette added a comment to D137905: [GlobalISel] Add a new G_INVOKE_REGION_START instruction to fix an EH bug.

Does G_INVOKE_REGION_START work with the terminators() iterator?

Nov 16 2022, 1:58 PM · Restricted Project, Restricted Project
paquette added inline comments to D137905: [GlobalISel] Add a new G_INVOKE_REGION_START instruction to fix an EH bug.
Nov 16 2022, 10:12 AM · Restricted Project, Restricted Project

Nov 15 2022

paquette accepted D138082: GlobalISel: ComputeNumSignBits from load range metadata.

LGTM

Nov 15 2022, 5:35 PM · Restricted Project, Restricted Project
paquette added inline comments to D137905: [GlobalISel] Add a new G_INVOKE_REGION_START instruction to fix an EH bug.
Nov 15 2022, 3:04 PM · Restricted Project, Restricted Project
paquette accepted D138067: GlobalISel: Try to fold G_SEXT_INREG to G_AND with mask.

LGTM

Nov 15 2022, 2:58 PM · Restricted Project, Restricted Project
paquette added a comment to D138059: [MicroBenchmarks,AArch64] Added correctness test & other performance tests for truncate or zero-extend vector operations.

Why randomized?

Nov 15 2022, 1:35 PM · Restricted Project

Nov 2 2022

paquette accepted D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms..

If there's nothing else to add wrt telling people what's changed, I think this looks good?

Nov 2 2022, 2:09 PM · Restricted Project, Restricted Project, Restricted Project
paquette added a comment to D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms..

maybe link back to the discourse thread in the commit message?

Nov 2 2022, 10:11 AM · Restricted Project, Restricted Project, Restricted Project

Nov 1 2022

paquette accepted D136793: [AArch64][GlobalISel] Add some minor post-selection optimizations..
Nov 1 2022, 3:49 PM · Restricted Project, Restricted Project

Oct 28 2022

paquette accepted D136982: AArch64: Register null MCTargetStreamer.

LGTM

Oct 28 2022, 3:50 PM · Restricted Project, Restricted Project

Oct 26 2022

paquette added inline comments to D136793: [AArch64][GlobalISel] Add some minor post-selection optimizations..
Oct 26 2022, 4:14 PM · Restricted Project, Restricted Project

Oct 25 2022

paquette accepted D136433: [GlobalISel][AArch64] Fix miscompile caused by wrong G_ZEXT selection in GISel.

This looks fine to me.

Oct 25 2022, 11:18 AM · Restricted Project, Restricted Project

Oct 18 2022

paquette added a comment to D135633: [GlobalISel] Combine things like (z = x <= 0 ? z = x : z = 0) -> x & (x >> bw-1).
In D135633#3856871, @arsenm wrote:
In D135633#3856846, @paquette wrote:

Split into two combines to avoid the hook. The "and-not" combine is now opt-in by the target.

If someone needed different behavior per type, it would still need a hook (or some other mechanism to parameterize combines by type)

Oct 18 2022, 2:53 PM · Restricted Project, Restricted Project

Oct 13 2022

paquette updated the diff for D135633: [GlobalISel] Combine things like (z = x <= 0 ? z = x : z = 0) -> x & (x >> bw-1).

Split into two combines to avoid the hook. The "and-not" combine is now opt-in by the target.

Oct 13 2022, 1:58 PM · Restricted Project, Restricted Project

Oct 11 2022

paquette committed rG0f1a51e17353: [GlobalISel] Allow vectors in redundant or + add combines (authored by paquette).
[GlobalISel] Allow vectors in redundant or + add combines
Oct 11 2022, 3:32 PM · Restricted Project, Restricted Project
paquette closed D135719: [GlobalISel] Allow vectors in redundant or + add combines.
Oct 11 2022, 3:31 PM · Restricted Project, Restricted Project
paquette requested review of D135719: [GlobalISel] Allow vectors in redundant or + add combines.
Oct 11 2022, 3:20 PM · Restricted Project, Restricted Project
paquette updated the diff for D135633: [GlobalISel] Combine things like (z = x <= 0 ? z = x : z = 0) -> x & (x >> bw-1).
  • simplify comment
  • use captured NeedsNot
  • support vector case + add test
Oct 11 2022, 11:15 AM · Restricted Project, Restricted Project
paquette committed rG036a13065b7a: [GlobalISel] Combine (X op Y) == X --> Y == 0 (authored by paquette).
[GlobalISel] Combine (X op Y) == X --> Y == 0
Oct 11 2022, 9:53 AM · Restricted Project, Restricted Project
paquette closed D135380: [GlobalISel] Combine (X op Y) == X --> Y == 0.
Oct 11 2022, 9:53 AM · Restricted Project, Restricted Project

Oct 10 2022

paquette requested review of D135633: [GlobalISel] Combine things like (z = x <= 0 ? z = x : z = 0) -> x & (x >> bw-1).
Oct 10 2022, 6:25 PM · Restricted Project, Restricted Project

Oct 7 2022

paquette added inline comments to D135380: [GlobalISel] Combine (X op Y) == X --> Y == 0.
Oct 7 2022, 9:18 PM · Restricted Project, Restricted Project
paquette updated the diff for D135380: [GlobalISel] Combine (X op Y) == X --> Y == 0.

Use shiny new commutative matcher

Oct 7 2022, 8:23 PM · Restricted Project, Restricted Project
paquette committed rG45b9c6b01f26: [GlobalISel] Add commutative matchers for compares. (authored by paquette).
[GlobalISel] Add commutative matchers for compares.
Oct 7 2022, 8:08 PM · Restricted Project, Restricted Project
paquette closed D135415: [GlobalISel] Add commutative matchers for compares..
Oct 7 2022, 8:08 PM · Restricted Project, Restricted Project
paquette added a comment to D135415: [GlobalISel] Add commutative matchers for compares..

Yep, did that in D135491. :)

Oct 7 2022, 5:07 PM · Restricted Project, Restricted Project