Page MenuHomePhabricator
People paquette

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (135 w, 5 d)

oh boy

Recent Activity
View All

Yesterday

paquette accepted D61962: [LoopUnroll] Add support for loops with exiting headers and uncond latches..

LGTM

Mon, Jun 24, 8:57 AM · Restricted Project

Fri, Jun 21

paquette added inline comments to D61962: [LoopUnroll] Add support for loops with exiting headers and uncond latches..
Fri, Jun 21, 2:35 PM · Restricted Project
paquette accepted D63169: [GlobalISel][IRTranslator] Change switch table translation to generate jump tables and range checks..

LGTM

Fri, Jun 21, 9:03 AM · Restricted Project
paquette accepted D63587: [AArch64][GlobalISel] Make s8 and s16 G_CONSTANTs legal.

I think that this is reasonable. LGTM

Fri, Jun 21, 9:00 AM · Restricted Project

Thu, Jun 20

paquette accepted D63502: GlobalISel: Remove unsigned variant of SrcOp.

This is just a rename based off D63496, right?

Thu, Jun 20, 4:52 PM
paquette accepted D63630: [GlobalISel][Localizer] Allow localization of G_INTTOPTR and chains of instructions.

Seems reasonable, LGTM.

Thu, Jun 20, 4:42 PM · Restricted Project
paquette added inline comments to D63169: [GlobalISel][IRTranslator] Change switch table translation to generate jump tables and range checks..
Thu, Jun 20, 4:06 PM · Restricted Project

Wed, Jun 19

paquette added inline comments to D63466: [Remarks] Add an LLVM-bitstream-based remark serializer.
Wed, Jun 19, 10:09 AM · Restricted Project

Mon, Jun 17

paquette committed rG49537bbf74a6: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so (authored by paquette).
[GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so
Mon, Jun 17, 11:39 AM
paquette committed rL363596: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so.
[GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so
Mon, Jun 17, 11:36 AM
paquette closed D63163: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so.
Mon, Jun 17, 11:36 AM · Restricted Project
paquette added a comment to D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).

I agree it would be nice to use an int64_t because it matches up with the MachineOperand API. (e.g. getImm() returns an int64_t)

Mon, Jun 17, 10:38 AM · Restricted Project
paquette added a comment to D63405: GlobalISel: Don't lose fneg flags when lowering to fsub.

IIRC, isn't preserving the original flags the outcome we want here? If so, I think the updated patch is fine.

Mon, Jun 17, 10:21 AM
paquette added a comment to D63405: GlobalISel: Don't lose fneg flags when lowering to fsub.

... ah wait he already got to it while I was typing, never mind. :)

Mon, Jun 17, 10:21 AM
paquette added inline comments to D63169: [GlobalISel][IRTranslator] Change switch table translation to generate jump tables and range checks..
Mon, Jun 17, 9:53 AM · Restricted Project
paquette accepted D63424: GlobalISel: Ignore callsite attributes when picking intrinsic type.

LGTM

Mon, Jun 17, 9:14 AM

Fri, Jun 14

paquette added a comment to D63163: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so.
In D63163#1538760, @arsenm wrote:

I thought PeepholeOptimizer took care of this sort of thing?

Fri, Jun 14, 2:32 PM · Restricted Project
paquette updated the diff for D63163: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so.
  • tryFoldCMN -> tryOptCMN
  • Make tryOptCMN single-exit
  • Make tryOptCMN not leave the G_ICMP in a half-selected state; now it selects the CMN entirely.
  • Factor out cset emission into emitCSet.
Fri, Jun 14, 2:26 PM · Restricted Project
paquette accepted D63223: [AArch64][GlobalISel] Implement selection support for the new G_JUMP_TABLE and G_BRJT ops.

LGTM

Fri, Jun 14, 11:03 AM · Restricted Project
paquette added inline comments to D63303: [GlobalISel][Localizer] Rewrite localizer to run in 2 phases, inter & intra block..
Fri, Jun 14, 10:55 AM · Restricted Project
paquette added a comment to D63306: Add a remarks-based code size diffing tool.
In D63306#1543020, @echristo wrote:

Haven't done much of a review, one drive by, but in general I like the idea. Would it make sense to have a general "remarks in object files" tool rather than just a size one? (It can, of course, only do size at the beginning.)

Thoughts?

Fri, Jun 14, 10:45 AM · Restricted Project

Thu, Jun 13

paquette created D63306: Add a remarks-based code size diffing tool.
Thu, Jun 13, 4:25 PM · Restricted Project

Tue, Jun 11

paquette created D63163: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so.
Tue, Jun 11, 1:23 PM · Restricted Project
paquette accepted D63111: [GlobalISel] Add a G_JUMP_TABLE opcode.

LGTM

Tue, Jun 11, 12:43 PM · Restricted Project

Mon, Jun 10

paquette committed rGb22954384e34: [GlobalISel] Translate memset/memmove/memcpy from undef ptrs into nops (authored by paquette).
[GlobalISel] Translate memset/memmove/memcpy from undef ptrs into nops
Mon, Jun 10, 2:53 PM
paquette committed rL362989: [GlobalISel] Translate memset/memmove/memcpy from undef ptrs into nops.
[GlobalISel] Translate memset/memmove/memcpy from undef ptrs into nops
Mon, Jun 10, 2:53 PM
paquette closed D63095: [GlobalISel] Translate memset/memmove/memcpy from undef ptrs into nothing.
Mon, Jun 10, 2:53 PM · Restricted Project
paquette updated the diff for D63095: [GlobalISel] Translate memset/memmove/memcpy from undef ptrs into nothing.

Improve test

Mon, Jun 10, 2:36 PM · Restricted Project
paquette created D63095: [GlobalISel] Translate memset/memmove/memcpy from undef ptrs into nothing.
Mon, Jun 10, 1:44 PM · Restricted Project

Mon, Jun 3

paquette committed rG7500c97ce4bd: [AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp (authored by paquette).
[AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp
Mon, Jun 3, 1:45 PM
paquette committed rL362446: [AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp.
[AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp
Mon, Jun 3, 1:45 PM
paquette closed D62695: [AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp.
Mon, Jun 3, 1:45 PM · Restricted Project

Thu, May 30

paquette updated the diff for D62695: [AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp.

Remove incorrect/outdated comment, and add a description of what tryOptSelect is trying to do.

Thu, May 30, 3:26 PM · Restricted Project
paquette created D62695: [AArch64][GlobalISel] Optimize G_FCMP + G_SELECT pairs when G_SELECT is fp.
Thu, May 30, 12:03 PM · Restricted Project

Tue, May 28

paquette committed rGb73ea75b384d: [AArch64][GlobalISel] Select FCMPSri/FCMPDri when comparing against 0.0 (authored by paquette).
[AArch64][GlobalISel] Select FCMPSri/FCMPDri when comparing against 0.0
Tue, May 28, 3:51 PM
paquette committed rL361888: [AArch64][GlobalISel] Select FCMPSri/FCMPDri when comparing against 0.0.
[AArch64][GlobalISel] Select FCMPSri/FCMPDri when comparing against 0.0
Tue, May 28, 3:50 PM
paquette closed D62539: [AArch64][GlobalISel] Select FCMPSri/FCMPDri when comparing against 0.0.
Tue, May 28, 3:50 PM · Restricted Project
paquette created D62539: [AArch64][GlobalISel] Select FCMPSri/FCMPDri when comparing against 0.0.
Tue, May 28, 11:26 AM · Restricted Project

May 24 2019

paquette committed rG97d668d70f52: [GlobalISel][AArch64] Make FP constraint checks consider possible use/def banks (authored by paquette).
[GlobalISel][AArch64] Make FP constraint checks consider possible use/def banks
May 24 2019, 4:07 PM
paquette committed rL361679: [GlobalISel][AArch64] Make FP constraint checks consider possible use/def banks.
[GlobalISel][AArch64] Make FP constraint checks consider possible use/def banks
May 24 2019, 4:06 PM
paquette closed D62426: [GlobalISel][AArch64] Make FP constraint checks consider possible use/def register banks.
May 24 2019, 4:05 PM · Restricted Project
paquette committed rGbede937b1678: [GlobalISel][AArch64] NFC: Factor out HasFPConstraints into a proper function (authored by paquette).
[GlobalISel][AArch64] NFC: Factor out HasFPConstraints into a proper function
May 24 2019, 3:14 PM
paquette committed rL361677: [GlobalISel][AArch64] NFC: Factor out HasFPConstraints into a proper function.
[GlobalISel][AArch64] NFC: Factor out HasFPConstraints into a proper function
May 24 2019, 3:13 PM
paquette closed D62421: [GlobalISel][AArch64] NFC: Factor out HasFPConstraints into a proper function.
May 24 2019, 3:13 PM · Restricted Project
paquette added inline comments to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.
May 24 2019, 2:27 PM · Restricted Project
paquette added a parent revision for D62426: [GlobalISel][AArch64] Make FP constraint checks consider possible use/def register banks: D62421: [GlobalISel][AArch64] NFC: Factor out HasFPConstraints into a proper function.
May 24 2019, 2:08 PM · Restricted Project
paquette added a child revision for D62421: [GlobalISel][AArch64] NFC: Factor out HasFPConstraints into a proper function: D62426: [GlobalISel][AArch64] Make FP constraint checks consider possible use/def register banks.
May 24 2019, 2:08 PM · Restricted Project
paquette created D62426: [GlobalISel][AArch64] Make FP constraint checks consider possible use/def register banks.
May 24 2019, 2:07 PM · Restricted Project
paquette created D62421: [GlobalISel][AArch64] NFC: Factor out HasFPConstraints into a proper function.
May 24 2019, 1:02 PM · Restricted Project
paquette committed rG56503865ed4d: [GlobalISel][AArch64] Improve register bank mappings for G_SELECT (authored by paquette).
[GlobalISel][AArch64] Improve register bank mappings for G_SELECT
May 24 2019, 12:35 PM
paquette committed rL361665: [GlobalISel][AArch64] Improve register bank mappings for G_SELECT.
[GlobalISel][AArch64] Improve register bank mappings for G_SELECT
May 24 2019, 12:33 PM
paquette closed D62267: [GlobalISel][AArch64] Improve register bank mappings for G_SELECT.
May 24 2019, 12:32 PM · Restricted Project

May 23 2019

paquette accepted D62076: AMDGPU/GlobalISel: Legality for integer min/max.

LGTM

May 23 2019, 9:15 AM

May 22 2019

paquette updated the summary of D62267: [GlobalISel][AArch64] Improve register bank mappings for G_SELECT.
May 22 2019, 1:42 PM · Restricted Project
paquette created D62267: [GlobalISel][AArch64] Improve register bank mappings for G_SELECT.
May 22 2019, 1:05 PM · Restricted Project

May 3 2019

paquette committed rG910630c1e4a1: [AArch64][GlobalISel] Use fcsel instead of csel for G_SELECT on FPRs (authored by paquette).
[AArch64][GlobalISel] Use fcsel instead of csel for G_SELECT on FPRs
May 3 2019, 3:36 PM
paquette committed rL359940: [AArch64][GlobalISel] Use fcsel instead of csel for G_SELECT on FPRs.
[AArch64][GlobalISel] Use fcsel instead of csel for G_SELECT on FPRs
May 3 2019, 3:35 PM

May 1 2019

paquette committed rGd010a3b63e0a: Fix erroneous flag in GISel line for arm64-fast-isel-materialize.ll (authored by paquette).
Fix erroneous flag in GISel line for arm64-fast-isel-materialize.ll
May 1 2019, 3:49 PM
paquette committed rL359737: Fix erroneous flag in GISel line for arm64-fast-isel-materialize.ll.
Fix erroneous flag in GISel line for arm64-fast-isel-materialize.ll
May 1 2019, 3:47 PM
paquette committed rGa3843fe6f461: [GlobalISel][AArch64] Use fmov for G_FCONSTANT when possible (authored by paquette).
[GlobalISel][AArch64] Use fmov for G_FCONSTANT when possible
May 1 2019, 3:41 PM
paquette committed rL359734: [GlobalISel][AArch64] Use fmov for G_FCONSTANT when possible.
[GlobalISel][AArch64] Use fmov for G_FCONSTANT when possible
May 1 2019, 3:41 PM
paquette added a comment to D61273: [globalisel] Update the legalizer documentation.

The extra sections really make a difference! Looks great now.

May 1 2019, 9:22 AM · Restricted Project

Apr 29 2019

paquette committed rG7f6fe7c02c75: [GlobalISel][AArch64] Select llvm.aarch64.crypto.sha1h (authored by paquette).
[GlobalISel][AArch64] Select llvm.aarch64.crypto.sha1h
Apr 29 2019, 2:03 PM
paquette committed rL359501: [GlobalISel][AArch64] Select llvm.aarch64.crypto.sha1h.
[GlobalISel][AArch64] Select llvm.aarch64.crypto.sha1h
Apr 29 2019, 2:03 PM
paquette accepted D61273: [globalisel] Update the legalizer documentation.

I think this looks good. I have a few stylistic suggestions, but I don't think they're worth holding up review over.

Apr 29 2019, 1:23 PM · Restricted Project

Apr 26 2019

paquette committed rG76f64b665bb1: [GlobalISel][AArch64] Use getConstantVRegValWithLookThrough for extracts (authored by paquette).
[GlobalISel][AArch64] Use getConstantVRegValWithLookThrough for extracts
Apr 26 2019, 2:52 PM
paquette committed rL359351: [GlobalISel][AArch64] Use getConstantVRegValWithLookThrough for extracts.
[GlobalISel][AArch64] Use getConstantVRegValWithLookThrough for extracts
Apr 26 2019, 2:51 PM
paquette committed rG67ab9eb193ce: [AArch64][GlobalISel] Select G_BSWAP for vectors of s32 and s64 (authored by paquette).
[AArch64][GlobalISel] Select G_BSWAP for vectors of s32 and s64
Apr 26 2019, 10:59 AM
paquette committed rL359331: [AArch64][GlobalISel] Select G_BSWAP for vectors of s32 and s64.
[AArch64][GlobalISel] Select G_BSWAP for vectors of s32 and s64
Apr 26 2019, 10:59 AM

Apr 25 2019

paquette committed rGf54258c88842: [GlobalISel][AArch64] Make G_EXTRACT_VECTOR_ELT legal for v8s16s (authored by paquette).
[GlobalISel][AArch64] Make G_EXTRACT_VECTOR_ELT legal for v8s16s
Apr 25 2019, 1:00 PM
paquette committed rL359231: [GlobalISel][AArch64] Make G_EXTRACT_VECTOR_ELT legal for v8s16s.
[GlobalISel][AArch64] Make G_EXTRACT_VECTOR_ELT legal for v8s16s
Apr 25 2019, 12:59 PM
paquette committed rG8184b6e7f610: [GlobalISel][AArch64] Add generic legalization rule for extends (authored by paquette).
[GlobalISel][AArch64] Add generic legalization rule for extends
Apr 25 2019, 11:43 AM
paquette committed rL359222: [GlobalISel][AArch64] Add generic legalization rule for extends.
[GlobalISel][AArch64] Add generic legalization rule for extends
Apr 25 2019, 11:43 AM
paquette closed D60889: [GlobalISel][AArch64] Add generic legalization rule for extends.
Apr 25 2019, 11:43 AM · Restricted Project
paquette closed D60923: [GlobalISel][AArch64] Legalize G_FNEARBYINT.

https://reviews.llvm.org/rGba55767f516a

Apr 25 2019, 9:45 AM · Restricted Project
paquette committed rGba55767f516a: [GlobalISel][AArch64] Legalize G_FNEARBYINT (authored by paquette).
[GlobalISel][AArch64] Legalize G_FNEARBYINT
Apr 25 2019, 9:44 AM
paquette accepted D60923: [GlobalISel][AArch64] Legalize G_FNEARBYINT.

trivial commit, pushing it along

Apr 25 2019, 9:43 AM · Restricted Project
paquette committed rL359204: [GlobalISel][AArch64] Legalize G_FNEARBYINT.
[GlobalISel][AArch64] Legalize G_FNEARBYINT
Apr 25 2019, 9:42 AM
paquette committed rGbd7ac30b1538: [GlobalISel] Add IRTranslator support for G_FNEARBYINT (authored by paquette).
[GlobalISel] Add IRTranslator support for G_FNEARBYINT
Apr 25 2019, 9:42 AM
paquette committed rL359203: [GlobalISel] Add IRTranslator support for G_FNEARBYINT.
[GlobalISel] Add IRTranslator support for G_FNEARBYINT
Apr 25 2019, 9:37 AM
paquette closed D60922: [GlobalISel] Add IRTranslator support for G_FNEARBYINT.
Apr 25 2019, 9:37 AM · Restricted Project
paquette accepted D60922: [GlobalISel] Add IRTranslator support for G_FNEARBYINT.

Pushing this along because it's trivial and Amara isn't around right now

Apr 25 2019, 9:36 AM · Restricted Project
paquette committed rGf13b6a74cecf: [GlobalISel] Add a G_FNEARBYINT opcode (authored by paquette).
[GlobalISel] Add a G_FNEARBYINT opcode
Apr 25 2019, 9:34 AM
paquette committed rL359201: [GlobalISel] Add a G_FNEARBYINT opcode.
[GlobalISel] Add a G_FNEARBYINT opcode
Apr 25 2019, 9:34 AM
paquette closed D60921: [GlobalISel] Add a G_FNEARBYINT opcode.
Apr 25 2019, 9:34 AM · Restricted Project
paquette accepted D60921: [GlobalISel] Add a G_FNEARBYINT opcode.

Since Amara is on vacation, I'm just going to push the G_FNEARBYINT stuff along since it's pretty trivial.

Apr 25 2019, 9:33 AM · Restricted Project

Apr 23 2019

paquette closed D60904: [GlobalISel][AArch64] Legalize vector G_FMA + fix G_FMA's register bank.
Apr 23 2019, 4:23 PM · Restricted Project
paquette accepted D60904: [GlobalISel][AArch64] Legalize vector G_FMA + fix G_FMA's register bank.

was told to YOLO trivial patches like these offline

Apr 23 2019, 4:22 PM · Restricted Project
paquette committed rG4fe7574d5d5f: [AArch64][GlobalISel] Select G_INTRINSIC_ROUND (authored by paquette).
[AArch64][GlobalISel] Select G_INTRINSIC_ROUND
Apr 23 2019, 4:05 PM
paquette committed rL359046: [AArch64][GlobalISel] Select G_INTRINSIC_ROUND.
[AArch64][GlobalISel] Select G_INTRINSIC_ROUND
Apr 23 2019, 4:01 PM
paquette committed rG9766bf1854d0: [AArch64][GlobalISel] Mark G_INTRINSIC_ROUND as a pre-isel floating point opcode (authored by paquette).
[AArch64][GlobalISel] Mark G_INTRINSIC_ROUND as a pre-isel floating point opcode
Apr 23 2019, 3:48 PM
paquette committed rL359044: [AArch64][GlobalISel] Mark G_INTRINSIC_ROUND as a pre-isel floating point opcode.
[AArch64][GlobalISel] Mark G_INTRINSIC_ROUND as a pre-isel floating point opcode
Apr 23 2019, 3:45 PM
paquette committed rG3cc6d1f542b5: [AArch64][GlobalISel] Legalize G_INTRINSIC_ROUND (authored by paquette).
[AArch64][GlobalISel] Legalize G_INTRINSIC_ROUND
Apr 23 2019, 2:11 PM
paquette committed rL359033: [AArch64][GlobalISel] Legalize G_INTRINSIC_ROUND.
[AArch64][GlobalISel] Legalize G_INTRINSIC_ROUND
Apr 23 2019, 2:11 PM
paquette committed rG991cb3924250: [AArch64][GlobalISel] Actually select G_INTRINSIC_TRUNC (authored by paquette).
[AArch64][GlobalISel] Actually select G_INTRINSIC_TRUNC
Apr 23 2019, 1:45 PM
paquette committed rL359030: [AArch64][GlobalISel] Actually select G_INTRINSIC_TRUNC.
[AArch64][GlobalISel] Actually select G_INTRINSIC_TRUNC
Apr 23 2019, 1:45 PM
paquette committed rGede0b2e69544: [AArch64][GlobalISel] Teach regbankselect about G_INTRINSIC_TRUNC (authored by paquette).
[AArch64][GlobalISel] Teach regbankselect about G_INTRINSIC_TRUNC
Apr 23 2019, 11:20 AM
paquette committed rG56342642a087: [AArch64][GlobalISel] Legalize G_INTRINSIC_TRUNC (authored by paquette).
[AArch64][GlobalISel] Legalize G_INTRINSIC_TRUNC
Apr 23 2019, 11:20 AM
paquette committed rL359022: [AArch64][GlobalISel] Teach regbankselect about G_INTRINSIC_TRUNC.
[AArch64][GlobalISel] Teach regbankselect about G_INTRINSIC_TRUNC
Apr 23 2019, 11:19 AM
paquette committed rL359021: [AArch64][GlobalISel] Legalize G_INTRINSIC_TRUNC.
[AArch64][GlobalISel] Legalize G_INTRINSIC_TRUNC
Apr 23 2019, 11:18 AM