People paquette

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (100 w, 1 d)

oh boy

Recent Activity
View All

Wed, Oct 10

paquette accepted D52776: [OptRemarks] Add library for parsing optimization remarks.

LGTM!

Wed, Oct 10, 8:58 AM

Fri, Oct 5

paquette closed D52945: [GlobalIsel] Add llvm.invariant.start and llvm.invariant.end.

Thanks! Committed in r343885. (https://reviews.llvm.org/rL343885)

Fri, Oct 5, 2:06 PM
paquette committed rL343885: [GlobalIsel] Add llvm.invariant.start and llvm.invariant.end.
[GlobalIsel] Add llvm.invariant.start and llvm.invariant.end
Fri, Oct 5, 2:05 PM
paquette created D52945: [GlobalIsel] Add llvm.invariant.start and llvm.invariant.end.
Fri, Oct 5, 1:39 PM

Thu, Oct 4

paquette added a comment to D52776: [OptRemarks] Add library for parsing optimization remarks.

Just one more round of comments.

Thu, Oct 4, 4:27 PM
paquette accepted D52829: [AArch64] Fix verifier error when outlining indirect calls.

As long as you add a FIXME saying that we should move this responsibility over to the verifier, this LGTM.

Thu, Oct 4, 11:00 AM
paquette added a comment to D52829: [AArch64] Fix verifier error when outlining indirect calls.
In D52829#1254842, @olista01 wrote:

I don't think adding a special case to the verifier makes sense, when it's easy enough to generate code which is valid by the normal rules.

I think this is probably really the only thing the outliner does that upsets the verifier. So, from that perspective, I think that this is fine.

Thu, Oct 4, 10:03 AM

Tue, Oct 2

paquette added a comment to D52776: [OptRemarks] Add library for parsing optimization remarks.

Mostly style nits here.

Tue, Oct 2, 10:40 AM
paquette committed rL343600: Revert "[sanitizer] Include inlined frames into __sanitizer_symbolize_pc output".
Revert "[sanitizer] Include inlined frames into __sanitizer_symbolize_pc output"
Tue, Oct 2, 9:30 AM
paquette committed rCRT343600: Revert "[sanitizer] Include inlined frames into __sanitizer_symbolize_pc output".
Revert "[sanitizer] Include inlined frames into __sanitizer_symbolize_pc output"
Tue, Oct 2, 9:30 AM

Tue, Sep 25

paquette committed rL343005: Revert "[ConstHoist] Do not rebase single (or few) dependent constant".
Revert "[ConstHoist] Do not rebase single (or few) dependent constant"
Tue, Sep 25, 11:43 AM

Thu, Sep 20

paquette committed rL342688: [MachineOutliner][NFC] Don't add MBBs with a size < 2 to the search space.
[MachineOutliner][NFC] Don't add MBBs with a size < 2 to the search space
Thu, Sep 20, 2:58 PM
paquette committed rL342677: [MachineOutliner][NFC] Move debug info emission to createOutlinedFunction.
[MachineOutliner][NFC] Move debug info emission to createOutlinedFunction
Thu, Sep 20, 11:58 AM

Sep 17 2018

paquette committed rL342405: [MachineOutliner][NFC] Don't map more illegal instrs than you have to.
[MachineOutliner][NFC] Don't map more illegal instrs than you have to
Sep 17 2018, 11:44 AM

Sep 11 2018

paquette committed rL342009: [MachineOutliner] Add codegen size remarks to the MachineOutliner.
[MachineOutliner] Add codegen size remarks to the MachineOutliner
Sep 11 2018, 4:07 PM
paquette committed rL341960: [NFC] Fix typo in comment.
[NFC] Fix typo in comment
Sep 11 2018, 9:41 AM
paquette committed rL341959: [MachineOutliner][NFC] Factor out instruction mapping into its own function.
[MachineOutliner][NFC] Factor out instruction mapping into its own function
Sep 11 2018, 9:35 AM

Sep 10 2018

paquette committed rL341885: Add REQUIRES line to machine-size-remarks.
Add REQUIRES line to machine-size-remarks
Sep 10 2018, 4:54 PM
paquette committed rL341882: Explicitly state triple in machine-size-remarks.ll.
Explicitly state triple in machine-size-remarks.ll
Sep 10 2018, 4:33 PM
paquette committed rL341876: Add size remarks to MachineFunctionPass.
Add size remarks to MachineFunctionPass
Sep 10 2018, 3:25 PM

Sep 6 2018

paquette closed D51467: Output per-function size-info remarks.

Committed in r341588.

Sep 6 2018, 2:21 PM
paquette committed rL341588: Output per-function size-info remarks.
Output per-function size-info remarks
Sep 6 2018, 2:21 PM

Sep 4 2018

paquette updated the diff for D51467: Output per-function size-info remarks.

Forgot to address a review comment; just did that.

Sep 4 2018, 2:40 PM
paquette updated the diff for D51467: Output per-function size-info remarks.

Updated patch to reflect the NFC changes I put in to speed up size remarks.

Sep 4 2018, 2:24 PM
paquette committed rL341407: [NFC] Improve clarity in emitInstrCountChangedRemark.
[NFC] Improve clarity in emitInstrCountChangedRemark
Sep 4 2018, 2:04 PM

Aug 31 2018

paquette committed rL341267: Fix typo in size remarks for module passes.
Fix typo in size remarks for module passes
Aug 31 2018, 3:44 PM
paquette committed rL341253: [NFC] Optionally pass a function to emitInstrCountChangedRemark.
[NFC] Optionally pass a function to emitInstrCountChangedRemark
Aug 31 2018, 1:55 PM
paquette committed rL341252: [NFC] Check if P is a pass manager on entry to emitInstrCountChangedRemark.
[NFC] Check if P is a pass manager on entry to emitInstrCountChangedRemark
Aug 31 2018, 1:52 PM
paquette added a comment to rL341250: [NFC] Pass the instruction delta to emitInstrCountChangedRemark.

TIL that including "-O2" in a commit message will transform it into "https://reviews.llvm.org/owners/package/2/" when you hit reviews.llvm.org.

Aug 31 2018, 1:25 PM
paquette committed rL341250: [NFC] Pass the instruction delta to emitInstrCountChangedRemark.
[NFC] Pass the instruction delta to emitInstrCountChangedRemark
Aug 31 2018, 1:22 PM
paquette committed rL341249: [NFC] Pre-calculate SCC IR counts in size remarks..
[NFC] Pre-calculate SCC IR counts in size remarks.
Aug 31 2018, 1:22 PM
paquette committed rL341248: [NFC] Pre-calculate module IR counts in size remarks..
[NFC] Pre-calculate module IR counts in size remarks.
Aug 31 2018, 1:22 PM
paquette committed rL341247: [NFC] Pre-calculate loop IR counts in size remarks..
[NFC] Pre-calculate loop IR counts in size remarks.
Aug 31 2018, 1:22 PM
paquette committed rL341246: [NFC] Pre-calculate basic block IR counts in size remarks..
[NFC] Pre-calculate basic block IR counts in size remarks.
Aug 31 2018, 1:22 PM
paquette committed rL341245: [NFC] Pre-calculate function IR counts in size remarks..
[NFC] Pre-calculate function IR counts in size remarks.
Aug 31 2018, 1:20 PM

Aug 30 2018

paquette added a comment to D51467: Output per-function size-info remarks.

I ran this with a debug build, and I noticed it's pretty heavy wrt compile time. I'm working on fixing that before committing.

Aug 30 2018, 2:16 PM
paquette accepted D51465: Revamp test-suite documentation.

Added some style nits.

Aug 30 2018, 10:06 AM

Aug 29 2018

paquette created D51467: Output per-function size-info remarks.
Aug 29 2018, 4:23 PM

Aug 28 2018

paquette added inline comments to D51276: [New PM][PassTiming] implement -time-passes for the new pass manager.
Aug 28 2018, 10:24 AM
paquette accepted D51274: [NFC][PassTiming] factor out generic PassTimingInfo.

Added some nits on comments. These could be done in a follow-up patch. I think a lot of these comments could use a style update.

Aug 28 2018, 10:12 AM

Aug 17 2018

paquette committed rL340078: Add ability to track linker memory usage.
Add ability to track linker memory usage
Aug 17 2018, 1:48 PM

Aug 14 2018

paquette committed rL339725: Add mem_bytes to test_suite.py.
Add mem_bytes to test_suite.py
Aug 14 2018, 1:51 PM

Jul 30 2018

paquette closed D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.

Committed in r338278. (https://reviews.llvm.org/rL338278)

Jul 30 2018, 10:46 AM
paquette committed rL338278: [MachineOutliner][AArch64] Add support for saving LR to a register.
[MachineOutliner][AArch64] Add support for saving LR to a register
Jul 30 2018, 10:46 AM
paquette committed rL338272: Add machine verifier to arm64-opt-remarks-lazy-bfi.
Add machine verifier to arm64-opt-remarks-lazy-bfi
Jul 30 2018, 10:13 AM
paquette added a comment to rL338267: Attempt to fix Windows test failure caused by r338133.

Oh, it turns out this isn't just Windows. It's just that the verifier was running on those bots. Doh.

Jul 30 2018, 10:04 AM
paquette added a comment to rL338133: Enable MachineOutliner by default under -Oz for AArch64.

It seems like the issue is that on Windows, we also insert a 'Verify generated machine code' pass.

Jul 30 2018, 9:39 AM
paquette committed rL338267: Attempt to fix Windows test failure caused by r338133.
Attempt to fix Windows test failure caused by r338133
Jul 30 2018, 9:36 AM
paquette added a comment to rL338133: Enable MachineOutliner by default under -Oz for AArch64.

Sorry for the late response. Looking into the test failure now.

Jul 30 2018, 8:53 AM

Jul 27 2018

paquette updated the diff for D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.

Updated the diff. We now just look over the GPR64 register class instead of callee-saves.

Jul 27 2018, 5:19 PM
paquette added inline comments to D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.
Jul 27 2018, 5:11 PM
paquette committed rL338160: Recommit "Enable MachineOutliner by default under -Oz for AArch64".
Recommit "Enable MachineOutliner by default under -Oz for AArch64"
Jul 27 2018, 1:18 PM
paquette committed rL338148: [MachineOutliner] Exit getOutliningCandidateInfo when we erase all candidates.
[MachineOutliner] Exit getOutliningCandidateInfo when we erase all candidates
Jul 27 2018, 11:24 AM
paquette committed rL338136: Revert "Enable MachineOutliner by default under -Oz for AArch64".
Revert "Enable MachineOutliner by default under -Oz for AArch64"
Jul 27 2018, 10:25 AM
paquette closed D45916: Enable MachineOutliner by default under -Oz for AArch64.

Committed in r338133. (https://reviews.llvm.org/rL338133)

Jul 27 2018, 9:45 AM
paquette committed rL338133: Enable MachineOutliner by default under -Oz for AArch64.
Enable MachineOutliner by default under -Oz for AArch64
Jul 27 2018, 9:45 AM

Jul 26 2018

paquette accepted D49880: [MachineOutliner] Clean up subtarget handling..

LGTM

Jul 26 2018, 3:58 PM
paquette created D49884: [MachineOutliner] Add support for saving LR to a callee-saved register.
Jul 26 2018, 3:52 PM

Jul 24 2018

paquette committed rL337849: [MachineOutliner][NFC] Move outlined function remark into its own function.
[MachineOutliner][NFC] Move outlined function remark into its own function
Jul 24 2018, 1:21 PM
paquette committed rL337848: [MachineOutliner][NFC] Move target frame info into OutlinedFunction.
[MachineOutliner][NFC] Move target frame info into OutlinedFunction
Jul 24 2018, 1:13 PM
paquette committed rL337840: [MachineOutliner][NFC] Make Candidates own their call information.
[MachineOutliner][NFC] Make Candidates own their call information
Jul 24 2018, 10:42 AM
paquette committed rL337839: [MachineOutliner][NFC] Move missed opt remark into its own function.
[MachineOutliner][NFC] Move missed opt remark into its own function
Jul 24 2018, 10:37 AM
paquette committed rL337838: [MachineOutliner][NFC] Sink some candidate logic into OutlinedFunction.
[MachineOutliner][NFC] Sink some candidate logic into OutlinedFunction
Jul 24 2018, 10:36 AM

Jul 18 2018

paquette added inline comments to D44910: [docs] Add Markdown support to Sphinx.
Jul 18 2018, 9:55 AM
paquette added inline comments to D44910: [docs] Add Markdown support to Sphinx.
Jul 18 2018, 9:40 AM

Jul 13 2018

paquette accepted D49299: [MachineOutliner][X86] Use TAILJMPd64 instead of JMP_1 for TailCall construction.

This looks good to me.

Jul 13 2018, 9:00 AM
paquette accepted D49295: [MachineOutliner] Check the last instruction from the sequence when updating liveness.

LGTM, thanks for catching that!

Jul 13 2018, 8:56 AM

Jul 6 2018

paquette committed rC336471: [MachineOutliner] Properly pass -moutline along to the toolchain.
[MachineOutliner] Properly pass -moutline along to the toolchain
Jul 6 2018, 3:30 PM
paquette committed rL336471: [MachineOutliner] Properly pass -moutline along to the toolchain.
[MachineOutliner] Properly pass -moutline along to the toolchain
Jul 6 2018, 3:29 PM
paquette accepted D49023: [MachineOutliner] Assert that Liveness tracking is accurate (NFC).

LGTM

Jul 6 2018, 1:23 PM
paquette added inline comments to D49023: [MachineOutliner] Assert that Liveness tracking is accurate (NFC).
Jul 6 2018, 8:53 AM

Jul 3 2018

paquette accepted D48867: [MachineOutliner] Fix typo in getOutliningCandidateInfo function name.

LGTM

Jul 3 2018, 12:12 PM

Jun 29 2018

paquette closed D48776: [MachineOutliner] Add support for target-default outlining.

Committed in r336040.

Jun 29 2018, 9:01 PM
paquette committed rL336040: [MachineOutliner] Add support for target-default outlining..
[MachineOutliner] Add support for target-default outlining.
Jun 29 2018, 9:01 PM
paquette committed rL336001: [MachineOutliner] Make -mno-outline use -enable-machine-outliner=never.
[MachineOutliner] Make -mno-outline use -enable-machine-outliner=never
Jun 29 2018, 11:11 AM
paquette committed rC336001: [MachineOutliner] Make -mno-outline use -enable-machine-outliner=never.
[MachineOutliner] Make -mno-outline use -enable-machine-outliner=never
Jun 29 2018, 11:11 AM
paquette updated the diff for D45916: Enable MachineOutliner by default under -Oz for AArch64.

Updated the patch so that it relies on the changes in D48776. That patch provides the scaffolding for allowing the outliner to be turned on by default by some target. This one flips the switch on AArch64 for -Oz.

Jun 29 2018, 10:48 AM
paquette created D48776: [MachineOutliner] Add support for target-default outlining.
Jun 29 2018, 10:17 AM
paquette closed D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.

Committed in r335986.
https://reviews.llvm.org/rL335986

Jun 29 2018, 9:18 AM
paquette committed rL335986: [MachineOutliner] Add always and never options to -enable-machine-outliner.
[MachineOutliner] Add always and never options to -enable-machine-outliner
Jun 29 2018, 9:17 AM

Jun 28 2018

paquette committed rL335930: [MachineOutliner] Never add the outliner in -O0.
[MachineOutliner] Never add the outliner in -O0
Jun 28 2018, 2:54 PM
paquette updated the diff for D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.

Removed the reference to enable-linkonceodr-outlining, since it was confusing.

Jun 28 2018, 11:04 AM
paquette added a comment to D48683: [MachineOutliner] Define MachineOutliner support in TargetOptions.

This was actually committed in r335887.

Jun 28 2018, 10:51 AM
paquette committed rL335887: [MachineOutliner] Define MachineOutliner support in TargetOptions.
[MachineOutliner] Define MachineOutliner support in TargetOptions
Jun 28 2018, 10:50 AM
paquette committed rL335883: Revert "[MachineOutliner] Add always and never options to -enable-machine….
Revert "[MachineOutliner] Add always and never options to -enable-machine…
Jun 28 2018, 10:31 AM
paquette committed rL335882: Revert "[MachineOutliner] Never add the outliner in -O0".
Revert "[MachineOutliner] Never add the outliner in -O0"
Jun 28 2018, 10:31 AM
paquette added a comment to D48683: [MachineOutliner] Define MachineOutliner support in TargetOptions.

Argh. I accidentally pushed https://reviews.llvm.org/D48682 instead of this. I'll revert it and push this instead. I haven't had enough coffee this morning.

Jun 28 2018, 10:21 AM
paquette added inline comments to D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.
Jun 28 2018, 10:17 AM
paquette committed rL335879: [MachineOutliner] Never add the outliner in -O0.
[MachineOutliner] Never add the outliner in -O0
Jun 28 2018, 10:10 AM
paquette committed rL335872: [MachineOutliner] Add always and never options to -enable-machine-outliner.
[MachineOutliner] Add always and never options to -enable-machine-outliner
Jun 28 2018, 9:47 AM
paquette closed D48683: [MachineOutliner] Define MachineOutliner support in TargetOptions.

Committed in r335872.

Jun 28 2018, 9:47 AM
paquette added inline comments to D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.
Jun 28 2018, 8:57 AM

Jun 27 2018

paquette created D48683: [MachineOutliner] Define MachineOutliner support in TargetOptions.
Jun 27 2018, 4:35 PM
paquette created D48682: [MachineOutliner] Add always and never options to -enable-machine-outliner.
Jun 27 2018, 4:30 PM
paquette added a comment to D45916: Enable MachineOutliner by default under -Oz for AArch64.

Yeah this is too big. I'll split this up into a few patches then update this one to just reflect turning the outliner on once I'm done...

Jun 27 2018, 4:29 PM
paquette closed D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Committed in r335758 (https://reviews.llvm.org/rL335758).

Jun 27 2018, 10:49 AM
paquette committed rL335758: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.
[MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across
Jun 27 2018, 10:48 AM
paquette updated the diff for D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.

Updated diff.

Jun 27 2018, 10:22 AM
paquette added a comment to D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across.
In D47655#1144273, @efriedma wrote:

Nevermind, the issue is my fault; should be (MachineBasicBlock::reverse_iterator)front(), not ++(MachineBasicBlock::reverse_iterator)front(). The resulting issue is tricky to debug because MachineInstrs are a circular linked list.

Ah, okay, I'll update the patch with that in a second.

Jun 27 2018, 9:12 AM

Jun 26 2018

paquette committed rL335672: [MachineOutliner] Emit a warning when using -moutline on unsupported targets.
[MachineOutliner] Emit a warning when using -moutline on unsupported targets
Jun 26 2018, 3:14 PM