no
User Details
- User Since
- Nov 17 2016, 12:59 PM (330 w, 5 d)
Today
Addressing review feedback before pushing
Yesterday
Mon, Mar 20
Over in D146257 we decided that we don't want to change the test suite, and would prefer the change to be local to LNT. We don't need this change.
Address review feedback
LGTM
Fri, Mar 17
The overhead of representing a new function in the binary depends on exception metadata and alignment
LGTM
I think this looks good, with a nit.
LGTM
Thu, Mar 16
Wed, Mar 15
LGTM
Tue, Mar 14
Hey, we noticed we haven't been getting size results in LNT as a result of this change.
Thu, Feb 23
Feb 17 2023
I think this seems reasonable?
LGTM
Feb 13 2023
Only things I can think of that would be nice to add are
Feb 9 2023
This is nice, thank you.
Feb 6 2023
LGTM
Feb 3 2023
Jan 30 2023
LGTM
Jan 27 2023
Dec 22 2022
Dec 21 2022
Good to go then?
LGTM
- Remove typed pointers from IR test
- Move the attribute in the docs and mark it as a string
- Remove unnecessary check for empty function in the MachineOutliner
- Improve wording in docs
Dec 20 2022
(somewhat straightforward, but I feel like adding something to the langref requires a LGTM from someone)
Dec 16 2022
I had two minor comments, but after you fix those, I think this is good to go.
Dec 13 2022
GISel part LGTM
Dec 7 2022
- Lazily constructing MFI is causing real pain, and makes it possible to write some silly bugs
- There haven't been any comments on this in a considerable amount of time, implying there aren't any strong opinions
- The drawback is that you have to type "MF" in some places
Dec 6 2022
Is it possible to write a testcase?
Can we add a statistic which calculates the average size of an outlinable region?
Testcase?
Is this one of the compile time patches we discussed offline? If so, could you mention that + an overview of the improvements in the commit message?
LGTM
I think this looks good at this point
:GTM
Nov 18 2022
LGTM
Looks like there are some unrelated changes in here?
Nov 16 2022
Does G_INVOKE_REGION_START work with the terminators() iterator?
Nov 15 2022
LGTM
LGTM
Why randomized?
Nov 2 2022
If there's nothing else to add wrt telling people what's changed, I think this looks good?
maybe link back to the discourse thread in the commit message?
Nov 1 2022
Oct 28 2022
LGTM
Oct 26 2022
Oct 25 2022
This looks fine to me.
Oct 18 2022
Oct 13 2022
Split into two combines to avoid the hook. The "and-not" combine is now opt-in by the target.
Oct 11 2022
- simplify comment
- use captured NeedsNot
- support vector case + add test
Oct 10 2022
Oct 7 2022
Use shiny new commutative matcher
Yep, did that in D135491. :)