Page MenuHomePhabricator
People paquette

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (239 w, 6 d)

oh boy

Recent Activity
View All

Thu, Jun 10

paquette accepted D104070: [AArch64][GlobalISel] Fix incorrectly generating uxtw/sxtw for addressing modes..

Oh rad

Thu, Jun 10, 4:37 PM · Restricted Project
paquette committed rG933df6ca796c: [AArch64][GlobalISel] Legalize scalar G_CTTZ + G_CTTZ_ZERO_UNDEF (authored by paquette).
[AArch64][GlobalISel] Legalize scalar G_CTTZ + G_CTTZ_ZERO_UNDEF
Thu, Jun 10, 3:30 PM
paquette closed D104065: [AArch64][GlobalISel] Legalize scalar G_CTTZ + G_CTTZ_ZERO_UNDEF.
Thu, Jun 10, 3:30 PM · Restricted Project
paquette requested review of D104065: [AArch64][GlobalISel] Legalize scalar G_CTTZ + G_CTTZ_ZERO_UNDEF.
Thu, Jun 10, 2:51 PM · Restricted Project
paquette updated subscribers of D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..
Thu, Jun 10, 2:36 PM · debug-info, Restricted Project
paquette added a comment to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..
In D87302#2811182, @dblaikie wrote:

Does the outliner only run for commoning code, or can it run on a single function (for hot/cold reasons, or anything else)?

BUt yeah, in the commoning case, DWARF (& LLVM IR) have no way to represent this situation and dropping the location is the best tool we have at the moment. It's discussed here: https://llvm.org/docs/HowToUpdateDebugInfo.html#when-to-drop-an-instruction-location

Thu, Jun 10, 2:33 PM · debug-info, Restricted Project
paquette committed rG1b894ccdc9ee: [AArch64][GlobalISel] Mark some G_BITREVERSE types as legal + select them (authored by paquette).
[AArch64][GlobalISel] Mark some G_BITREVERSE types as legal + select them
Thu, Jun 10, 10:34 AM
paquette closed D103999: [AArch64][GlobalISel] Mark some G_BITREVERSE types as legal + select them.
Thu, Jun 10, 10:34 AM · Restricted Project

Wed, Jun 9

paquette requested review of D103999: [AArch64][GlobalISel] Mark some G_BITREVERSE types as legal + select them.
Wed, Jun 9, 5:39 PM · Restricted Project
paquette accepted D103994: Annotate memcpy's of globals with info about the src/dst.

LGTM

Wed, Jun 9, 4:43 PM · Restricted Project

Fri, Jun 4

paquette accepted D103301: [AArch64][GlobalISel] Implement moreElements legalization for G_SHUFFLE_VECTOR..

all my comments were pretty minor so LGTM

Fri, Jun 4, 1:16 PM · Restricted Project
paquette added inline comments to D103301: [AArch64][GlobalISel] Implement moreElements legalization for G_SHUFFLE_VECTOR..
Fri, Jun 4, 1:15 PM · Restricted Project
paquette committed rG507d193ea7ef: [AArch64][GlobalISel] Handle multiple phis in fixupPHIOpBanks (authored by paquette).
[AArch64][GlobalISel] Handle multiple phis in fixupPHIOpBanks
Fri, Jun 4, 10:00 AM
paquette closed D103582: [AArch64][GlobalISel] Handle multiple phis in fixupPHIOpBanks.
Fri, Jun 4, 10:00 AM · Restricted Project

Thu, Jun 3

paquette added inline comments to D103582: [AArch64][GlobalISel] Handle multiple phis in fixupPHIOpBanks.
Thu, Jun 3, 2:31 PM · Restricted Project

Wed, Jun 2

paquette requested review of D103582: [AArch64][GlobalISel] Handle multiple phis in fixupPHIOpBanks.
Wed, Jun 2, 5:53 PM · Restricted Project

Tue, Jun 1

paquette requested review of D103498: [AArch64][GlobalISel] Use PackedVectorAllTypeList for G_SHUFFLE_VECTOR.
Tue, Jun 1, 5:29 PM · Restricted Project
paquette committed rGe7f501b5e7db: [GlobalISel][AArch64] Combine and (lshr x, cst), mask -> ubfx x, cst, width (authored by paquette).
[GlobalISel][AArch64] Combine and (lshr x, cst), mask -> ubfx x, cst, width
Tue, Jun 1, 11:02 AM
paquette closed D99283: [GlobalISel] Combine and (lshr x, cst), mask -> ubfx x, cst, width.
Tue, Jun 1, 11:02 AM · Restricted Project

Fri, May 28

paquette updated the diff for D99283: [GlobalISel] Combine and (lshr x, cst), mask -> ubfx x, cst, width.

Make this a generic combine + add a target hook to define when it should be enabled.

Fri, May 28, 4:47 PM · Restricted Project
paquette accepted D103334: [GISel] Eliminate redundant bitmasking.

LGTM with some minor comments

Fri, May 28, 3:02 PM · Restricted Project
paquette added inline comments to D103334: [GISel] Eliminate redundant bitmasking.
Fri, May 28, 1:26 PM · Restricted Project
paquette added inline comments to D103291: [AArch64][GISel] and+or+shl => bfi.
Fri, May 28, 12:26 PM · Restricted Project
paquette added inline comments to D103334: [GISel] Eliminate redundant bitmasking.
Fri, May 28, 12:25 PM · Restricted Project
paquette added inline comments to D103291: [AArch64][GISel] and+or+shl => bfi.
Fri, May 28, 12:15 PM · Restricted Project

Wed, May 26

paquette committed rG08d31ff4f45f: Fix unit test after 324af79dbc6066 (authored by paquette).
Fix unit test after 324af79dbc6066
Wed, May 26, 5:51 PM
paquette committed rG324af79dbc60: [GlobalISel] Don't emit lost debug location remarks when legalizing tail calls (authored by paquette).
[GlobalISel] Don't emit lost debug location remarks when legalizing tail calls
Wed, May 26, 5:16 PM
paquette closed D103128: [GlobalISel] Don't emit lost debug location remarks when legalizing tail calls.
Wed, May 26, 5:16 PM · Restricted Project

Tue, May 25

paquette requested review of D103128: [GlobalISel] Don't emit lost debug location remarks when legalizing tail calls.
Tue, May 25, 5:15 PM · Restricted Project
paquette added inline comments to D99283: [GlobalISel] Combine and (lshr x, cst), mask -> ubfx x, cst, width.
Tue, May 25, 11:34 AM · Restricted Project

May 20 2021

paquette added inline comments to D99283: [GlobalISel] Combine and (lshr x, cst), mask -> ubfx x, cst, width.
May 20 2021, 2:01 PM · Restricted Project
paquette updated the diff for D99283: [GlobalISel] Combine and (lshr x, cst), mask -> ubfx x, cst, width.
  • Fix UB by doing all the computations on unsigned ints (which is what SDAG does anyway)
  • Simplify the logic a little bit more
  • Add boundary testcases which use signed + unsigned max integer values
May 20 2021, 9:57 AM · Restricted Project

May 19 2021

paquette added a comment to D102542: [GlobalISel] Simplify G_ICMP to true/false when the result is known.

Recommitted with test fix in 84ae1cf8edc00cbf02a7396fef256f39046c1e5b.

May 19 2021, 9:30 AM · Restricted Project
paquette committed rG84ae1cf8edc0: Recommit "[GlobalISel] Simplify G_ICMP to true/false when the result is known" (authored by paquette).
Recommit "[GlobalISel] Simplify G_ICMP to true/false when the result is known"
May 19 2021, 9:30 AM
paquette added a comment to D102542: [GlobalISel] Simplify G_ICMP to true/false when the result is known.

Oh, sorry about that and thanks for taking care of the revert.

May 19 2021, 9:18 AM · Restricted Project

May 18 2021

paquette committed rG58c57e1b5f5f: [AArch64][GlobalISel] Prefer mov for s32->s64 G_ZEXT (authored by paquette).
[AArch64][GlobalISel] Prefer mov for s32->s64 G_ZEXT
May 18 2021, 10:00 AM
paquette closed D102656: [AArch64][GlobalISel] Prefer mov for s32->s64 G_ZEXT.
May 18 2021, 10:00 AM · Restricted Project
paquette committed rG892497c80630: [GlobalISel] Simplify G_ICMP to true/false when the result is known (authored by paquette).
[GlobalISel] Simplify G_ICMP to true/false when the result is known
May 18 2021, 9:41 AM
paquette closed D102542: [GlobalISel] Simplify G_ICMP to true/false when the result is known.
May 18 2021, 9:41 AM · Restricted Project

May 17 2021

paquette added inline comments to D102656: [AArch64][GlobalISel] Prefer mov for s32->s64 G_ZEXT.
May 17 2021, 4:10 PM · Restricted Project
paquette requested review of D102656: [AArch64][GlobalISel] Prefer mov for s32->s64 G_ZEXT.
May 17 2021, 4:08 PM · Restricted Project
paquette accepted D102613: ARM: support mandatory tail calls.

This looks really similar to the AArch64 code, so I think it's probably good to go.

May 17 2021, 11:35 AM · Restricted Project

May 14 2021

paquette requested review of D102542: [GlobalISel] Simplify G_ICMP to true/false when the result is known.
May 14 2021, 5:07 PM · Restricted Project
paquette accepted D95443: IR/AArch64/X86: add "swifttailcc" calling convention..

LGTM

May 14 2021, 9:30 AM · Restricted Project

May 13 2021

paquette updated the diff for D99283: [GlobalISel] Combine and (lshr x, cst), mask -> ubfx x, cst, width.

Rebase + move to AArch64-only to match the G_SBFX combine. Maybe this can be cannibalized into something more generic.

May 13 2021, 10:05 AM · Restricted Project

May 12 2021

paquette added inline comments to D95443: IR/AArch64/X86: add "swifttailcc" calling convention..
May 12 2021, 9:24 AM · Restricted Project

May 11 2021

paquette accepted D101947: GlobalISel: Split ValueHandler into assignment and emission classes.

Seems fine to me.

May 11 2021, 1:04 PM · Restricted Project
paquette accepted D102204: [AArch64][GlobalISel] Support truncstorei8/i16 w/ combine to form truncating G_STOREs..

LGTM

May 11 2021, 10:37 AM · Restricted Project
paquette added inline comments to D95443: IR/AArch64/X86: add "swifttailcc" calling convention..
May 11 2021, 10:13 AM · Restricted Project
paquette added inline comments to D95443: IR/AArch64/X86: add "swifttailcc" calling convention..
May 11 2021, 10:04 AM · Restricted Project
paquette added inline comments to D102204: [AArch64][GlobalISel] Support truncstorei8/i16 w/ combine to form truncating G_STOREs..
May 11 2021, 9:29 AM · Restricted Project

May 10 2021

paquette committed rG79be9c59c6ac: [AArch64][GlobalISel] Add post-legalizer lowering for NEON vector fcmps (authored by paquette).
[AArch64][GlobalISel] Add post-legalizer lowering for NEON vector fcmps
May 10 2021, 3:43 PM
paquette closed D101782: [AArch64][GlobalISel] Add post-legalizer lowering for NEON vector fcmps.
May 10 2021, 3:42 PM · Restricted Project
paquette committed rG6d8b070d9619: [AArch64][GlobalISel] Enable memcpy family combines on minsize functions (authored by paquette).
[AArch64][GlobalISel] Enable memcpy family combines on minsize functions
May 10 2021, 3:25 PM
paquette closed D102198: [AArch64][GlobalISel] Enable memcpy family combines on minsize functions.
May 10 2021, 3:25 PM · Restricted Project
paquette requested review of D102198: [AArch64][GlobalISel] Enable memcpy family combines on minsize functions.
May 10 2021, 2:12 PM · Restricted Project
paquette updated the diff for D101782: [AArch64][GlobalISel] Add post-legalizer lowering for NEON vector fcmps.

Address comments

May 10 2021, 10:09 AM · Restricted Project
paquette added inline comments to D101349: AArch64: support i128 cmpxchg in GlobalISel..
May 10 2021, 9:25 AM · Restricted Project
paquette accepted D101349: AArch64: support i128 cmpxchg in GlobalISel..

LGTM

May 10 2021, 9:24 AM · Restricted Project

May 7 2021

paquette added inline comments to D102038: [AArch64][GlobalISel] Create a new minimal combiner pass just for -O0..
May 7 2021, 5:00 PM · Restricted Project
paquette accepted D102038: [AArch64][GlobalISel] Create a new minimal combiner pass just for -O0..

LGTM

May 7 2021, 4:59 PM · Restricted Project
paquette added inline comments to D101782: [AArch64][GlobalISel] Add post-legalizer lowering for NEON vector fcmps.
May 7 2021, 4:57 PM · Restricted Project
paquette committed rG1312852040b3: [AArch64][GlobalISel] Legalize narrow type G_CTPOPs (authored by paquette).
[AArch64][GlobalISel] Legalize narrow type G_CTPOPs
May 7 2021, 2:53 PM
paquette closed D100908: [AArch64][GlobalISel] Legalize narrow type G_CTPOPs.
May 7 2021, 2:52 PM · Restricted Project
paquette accepted D101932: [GlobalISel] Don't form zero/sign extending loads for atomics.

LGTM

May 7 2021, 12:05 PM · Restricted Project
paquette accepted D101963: GlobalISel: Don't hardcode varargs=false in resultsCompatible.

LGTM

May 7 2021, 12:04 PM · Restricted Project
paquette added inline comments to D102038: [AArch64][GlobalISel] Create a new minimal combiner pass just for -O0..
May 7 2021, 11:46 AM · Restricted Project

May 5 2021

paquette added inline comments to D95443: IR/AArch64/X86: add "swifttailcc" calling convention..
May 5 2021, 9:07 AM · Restricted Project

May 4 2021

paquette added inline comments to D101234: GlobalISel: Use DAG call lowering infrastructure in a more compatible way.
May 4 2021, 9:43 AM · Restricted Project
paquette accepted D100709: X86/GlobalISel: Rely on default assignValueToRe.

LGTM

May 4 2021, 9:35 AM · Restricted Project
paquette accepted D101238: X86/GlobalISel: Use generic version of splitToValueTypes.

LGTM

May 4 2021, 9:34 AM · Restricted Project

May 3 2021

paquette requested review of D101782: [AArch64][GlobalISel] Add post-legalizer lowering for NEON vector fcmps.
May 3 2021, 12:28 PM · Restricted Project

Apr 29 2021

paquette accepted D101590: [AArch64][GlobalISel] Use a single MachineIRBuilder for most of isel. NFC..

Nice cleanup, LGTM.

Apr 29 2021, 10:09 PM · Restricted Project
paquette accepted D101543: [AArch64][GlobalISel] Fix width value for G_SBFX/G_UBFX.

LGTM!

Apr 29 2021, 10:36 AM · Restricted Project
paquette added a comment to D99814: [JumpThreading] Change asserts for WantInteger into actual checks.

Personally, I'd like to avoid refactoring in this patch just to keep things small and avoid any unintended side-effects. Does that sound okay? I think refactoring is probably a good idea in a follow-up. :)

Apr 29 2021, 8:37 AM · Restricted Project

Apr 28 2021

paquette committed rG4d41810cf679: [AArch64][GlobalISel] Don't match thread-local globals in matchFoldGlobalOffset (authored by paquette).
[AArch64][GlobalISel] Don't match thread-local globals in matchFoldGlobalOffset
Apr 28 2021, 1:48 PM
paquette closed D101478: [AArch64][GlobalISel] Don't match thread-local globals in matchFoldGlobalOffset.
Apr 28 2021, 1:48 PM · Restricted Project
paquette requested review of D101478: [AArch64][GlobalISel] Don't match thread-local globals in matchFoldGlobalOffset.
Apr 28 2021, 11:17 AM · Restricted Project

Apr 27 2021

paquette added a comment to D101349: AArch64: support i128 cmpxchg in GlobalISel..

I think it would be good to add dedicated legalizer + regbankselect MIR tests?

Apr 27 2021, 9:53 AM · Restricted Project

Apr 23 2021

paquette accepted D101152: AArch64: support atomics up to 64-bits in GISel.
Apr 23 2021, 11:47 AM · Restricted Project

Apr 21 2021

paquette committed rG3011aa1aea9f: [AArch64][GlobalISel] Fix regbankselect for G_FCMP with vector destinations (authored by paquette).
[AArch64][GlobalISel] Fix regbankselect for G_FCMP with vector destinations
Apr 21 2021, 6:20 PM
paquette closed D100885: [AArch64][GlobalISel] Fix regbankselect for G_FCMP with vector destinations.
Apr 21 2021, 6:20 PM · Restricted Project
paquette committed rG6cb759907812: [AArch64][GlobalISel] Mark some vector G_ABS cases as legal (authored by paquette).
[AArch64][GlobalISel] Mark some vector G_ABS cases as legal
Apr 21 2021, 6:11 PM
paquette closed D100916: [AArch64][GlobalISel] Mark some vector G_ABS cases as legal.
Apr 21 2021, 6:11 PM · Restricted Project
paquette added inline comments to D101005: [AArch64][GlobalISel] Simplify out of range rotate amount..
Apr 21 2021, 6:05 PM · Restricted Project

Apr 20 2021

paquette requested review of D100916: [AArch64][GlobalISel] Mark some vector G_ABS cases as legal.
Apr 20 2021, 5:55 PM · Restricted Project
paquette requested review of D100908: [AArch64][GlobalISel] Legalize narrow type G_CTPOPs.
Apr 20 2021, 4:16 PM · Restricted Project
paquette requested review of D100885: [AArch64][GlobalISel] Fix regbankselect for G_FCMP with vector destinations.
Apr 20 2021, 1:16 PM · Restricted Project
paquette added inline comments to D100836: AArch64: expand G_DIVREM operations in GlobalISel.
Apr 20 2021, 8:54 AM · Restricted Project
paquette accepted D100855: AArch64: support mixed-size vector fp <-> int conversions in GlobalISel..

LGTM

Apr 20 2021, 8:52 AM · Restricted Project

Apr 19 2021

paquette committed rG65f257a2152c: [AArch64][GlobalISel] Implement custom legalization for s32 and s64 G_CTPOP (authored by paquette).
[AArch64][GlobalISel] Implement custom legalization for s32 and s64 G_CTPOP
Apr 19 2021, 10:56 AM
paquette closed D100399: [AArch64][GlobalISel] Implement custom legalization for s32 and s64 G_CTPOP.
Apr 19 2021, 10:56 AM · Restricted Project
paquette committed rG91bbb914e017: [AArch64][GlobalISel] Regbankselect + select @llvm.aarch64.neon.uaddlv (authored by paquette).
[AArch64][GlobalISel] Regbankselect + select @llvm.aarch64.neon.uaddlv
Apr 19 2021, 10:48 AM
paquette closed D100398: [AArch64][GlobalISel] Regbankselect + select @llvm.aarch64.neon.uaddlv.
Apr 19 2021, 10:48 AM · Restricted Project

Apr 15 2021

paquette added inline comments to D100398: [AArch64][GlobalISel] Regbankselect + select @llvm.aarch64.neon.uaddlv.
Apr 15 2021, 4:54 PM · Restricted Project
paquette added inline comments to D100398: [AArch64][GlobalISel] Regbankselect + select @llvm.aarch64.neon.uaddlv.
Apr 15 2021, 2:02 PM · Restricted Project

Apr 13 2021

paquette added inline comments to D99833: [TableGen] generate `getRegBankFromRegClass`.
Apr 13 2021, 11:17 AM · Restricted Project
paquette added a comment to D99833: [TableGen] generate `getRegBankFromRegClass`.

When I build llc with this patch, with AMDGPU as a target, I get a lot of warnings.

Apr 13 2021, 11:12 AM · Restricted Project
paquette committed rG516d09387bed: [AArch64][GlobalISel] Mark G_CTPOP as legal for v16s8 and v8s8 (authored by paquette).
[AArch64][GlobalISel] Mark G_CTPOP as legal for v16s8 and v8s8
Apr 13 2021, 11:04 AM
paquette closed D100349: [AArch64][GlobalISel] Mark G_CTPOP as legal for v16s8 and v8s8.
Apr 13 2021, 11:04 AM · Restricted Project