- User Since
- Nov 17 2016, 12:59 PM (135 w, 5 d)
Fri, Jun 21
I think that this is reasonable. LGTM
Thu, Jun 20
This is just a rename based off D63496, right?
Seems reasonable, LGTM.
Wed, Jun 19
Mon, Jun 17
I agree it would be nice to use an int64_t because it matches up with the MachineOperand API. (e.g. getImm() returns an int64_t)
IIRC, isn't preserving the original flags the outcome we want here? If so, I think the updated patch is fine.
... ah wait he already got to it while I was typing, never mind. :)
Fri, Jun 14
- tryFoldCMN -> tryOptCMN
- Make tryOptCMN single-exit
- Make tryOptCMN not leave the G_ICMP in a half-selected state; now it selects the CMN entirely.
- Factor out cset emission into emitCSet.
Thu, Jun 13
Tue, Jun 11
Mon, Jun 10
Mon, Jun 3
Thu, May 30
Remove incorrect/outdated comment, and add a description of what tryOptSelect is trying to do.
Tue, May 28
May 24 2019
May 23 2019
May 22 2019
May 3 2019
May 1 2019
The extra sections really make a difference! Looks great now.
Apr 29 2019
I think this looks good. I have a few stylistic suggestions, but I don't think they're worth holding up review over.
Apr 26 2019
Apr 25 2019
trivial commit, pushing it along
Pushing this along because it's trivial and Amara isn't around right now
Since Amara is on vacation, I'm just going to push the G_FNEARBYINT stuff along since it's pretty trivial.
Apr 23 2019
was told to YOLO trivial patches like these offline