Page MenuHomePhabricator
People paquette

paquette (Jessica Paquette)
unmitigated disaster

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2016, 12:59 PM (151 w, 3 d)

oh boy

Recent Activity
View All

Fri, Oct 4

paquette committed rG784892c9641a: [MachineOutliner] Disable outlining from noreturn functions (authored by paquette).
[MachineOutliner] Disable outlining from noreturn functions
Fri, Oct 4, 2:31 PM
paquette committed rL373791: [MachineOutliner] Disable outlining from noreturn functions.
[MachineOutliner] Disable outlining from noreturn functions
Fri, Oct 4, 2:22 PM

Mon, Sep 30

paquette committed rGb1c1095fdc56: [AArch64][GlobalISel] Support lowering variadic musttail calls (authored by paquette).
[AArch64][GlobalISel] Support lowering variadic musttail calls
Mon, Sep 30, 9:50 AM
paquette committed rL373226: [AArch64][GlobalISel] Support lowering variadic musttail calls.
[AArch64][GlobalISel] Support lowering variadic musttail calls
Mon, Sep 30, 9:47 AM
paquette closed D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.
Mon, Sep 30, 9:47 AM · Restricted Project

Fri, Sep 27

paquette accepted D68151: [GlobalISel] Add an operand to memory intrinsics to denote the "tail" marker..

LGTM with test change

Fri, Sep 27, 3:31 PM · Restricted Project
paquette added a comment to D68151: [GlobalISel] Add an operand to memory intrinsics to denote the "tail" marker..

Can we also have a check for say, __memcpy_chk?

Fri, Sep 27, 11:37 AM · Restricted Project
paquette updated the diff for D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.

Refactor forwarding code, and factor out IRTranslator changes into a helper.

Fri, Sep 27, 11:28 AM · Restricted Project

Thu, Sep 26

paquette added inline comments to D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.
Thu, Sep 26, 2:55 PM · Restricted Project

Wed, Sep 25

paquette created D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.
Wed, Sep 25, 11:49 AM · Restricted Project
paquette committed rG8535a8672e16: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering (authored by paquette).
[AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering
Wed, Sep 25, 9:45 AM
paquette committed rL372897: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering.
[AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering
Wed, Sep 25, 9:45 AM
paquette closed D67939: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering.
Wed, Sep 25, 9:44 AM · Restricted Project

Tue, Sep 24

paquette added a comment to D67939: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering.

I'm noticing that the existing test coverage for varargs tail calls has some room for improvement in general.

Tue, Sep 24, 4:30 PM · Restricted Project
paquette added a comment to D67855: [X86] Add new calling convention that guarantees tail call optimization.

Looking back in the discussion, I think it's fine to have it act the same way as fastcc.

Tue, Sep 24, 9:46 AM · Restricted Project
paquette added inline comments to D67855: [X86] Add new calling convention that guarantees tail call optimization.
Tue, Sep 24, 9:20 AM · Restricted Project

Mon, Sep 23

paquette created D67939: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering.
Mon, Sep 23, 4:02 PM · Restricted Project
paquette added a comment to D67855: [X86] Add new calling convention that guarantees tail call optimization.

A couple things I think could have testcases:

Mon, Sep 23, 1:35 PM · Restricted Project

Wed, Sep 18

paquette committed rGce65ebc39e5b: [AArch64][GlobalISel] Support lowering musttail calls (authored by paquette).
[AArch64][GlobalISel] Support lowering musttail calls
Wed, Sep 18, 3:45 PM
paquette committed rL372273: [AArch64][GlobalISel] Support lowering musttail calls.
[AArch64][GlobalISel] Support lowering musttail calls
Wed, Sep 18, 3:45 PM
paquette closed D67681: [AArch64][GlobalISel] Support lowering musttail calls.
Wed, Sep 18, 3:45 PM · Restricted Project
paquette updated the diff for D67681: [AArch64][GlobalISel] Support lowering musttail calls.

Add test verifying that we fall back to SelectionDAG and die when a musttail call is not lowered as a tail call.

Wed, Sep 18, 3:12 PM · Restricted Project
paquette accepted D67724: [AArch64] Don't implicitly enable global isel on Darwin if code-model==large..

LGTM

Wed, Sep 18, 12:56 PM · Restricted Project

Tue, Sep 17

paquette created D67681: [AArch64][GlobalISel] Support lowering musttail calls.
Tue, Sep 17, 3:03 PM · Restricted Project
paquette committed rG8a4d9f04b51a: [AArch64][GlobalISel] Support -tailcallopt (authored by paquette).
[AArch64][GlobalISel] Support -tailcallopt
Tue, Sep 17, 1:25 PM
paquette committed rL372177: [AArch64][GlobalISel] Support -tailcallopt.
[AArch64][GlobalISel] Support -tailcallopt
Tue, Sep 17, 1:22 PM
paquette closed D67580: [AArch64][GlobalISel] Support -tailcallopt.
Tue, Sep 17, 1:22 PM · Restricted Project
paquette committed rGd16cf40f8c35: [AArch64][GlobalISel][NFC] Refactor tail call lowering code (authored by paquette).
[AArch64][GlobalISel][NFC] Refactor tail call lowering code
Tue, Sep 17, 12:12 PM
paquette committed rL372164: [AArch64][GlobalISel][NFC] Refactor tail call lowering code.
[AArch64][GlobalISel][NFC] Refactor tail call lowering code
Tue, Sep 17, 12:07 PM
paquette closed D67577: [AArch64][GlobalISel][NFC] Refactor tail call lowering code.
Tue, Sep 17, 12:06 PM · Restricted Project

Sep 13 2019

paquette added a parent revision for D67580: [AArch64][GlobalISel] Support -tailcallopt: D67577: [AArch64][GlobalISel][NFC] Refactor tail call lowering code.
Sep 13 2019, 3:54 PM · Restricted Project
paquette added a child revision for D67577: [AArch64][GlobalISel][NFC] Refactor tail call lowering code: D67580: [AArch64][GlobalISel] Support -tailcallopt.
Sep 13 2019, 3:54 PM · Restricted Project
paquette created D67580: [AArch64][GlobalISel] Support -tailcallopt.
Sep 13 2019, 3:54 PM · Restricted Project
paquette created D67577: [AArch64][GlobalISel][NFC] Refactor tail call lowering code.
Sep 13 2019, 3:20 PM · Restricted Project
paquette committed rG727328ab63b2: [AArch64][GlobalISel] Tail call memory intrinsics (authored by paquette).
[AArch64][GlobalISel] Tail call memory intrinsics
Sep 13 2019, 1:32 PM
paquette committed rL371893: [AArch64][GlobalISel] Tail call memory intrinsics.
[AArch64][GlobalISel] Tail call memory intrinsics
Sep 13 2019, 1:24 PM
paquette closed D67566: [AArch64][GlobalISel] Tail call memory intrinsics.
Sep 13 2019, 1:24 PM · Restricted Project
paquette updated the diff for D67566: [AArch64][GlobalISel] Tail call memory intrinsics.

Update comments, add -global-isel-abort=1 to test

Sep 13 2019, 11:52 AM · Restricted Project
paquette updated the diff for D67566: [AArch64][GlobalISel] Tail call memory intrinsics.

Add missing check for when the return is a tail call.

Sep 13 2019, 11:17 AM · Restricted Project
paquette created D67566: [AArch64][GlobalISel] Tail call memory intrinsics.
Sep 13 2019, 10:40 AM · Restricted Project
paquette committed rG14bfb56b1aea: [AArch64][GlobalISel] Add support for sibcalling callees with varargs (authored by paquette).
[AArch64][GlobalISel] Add support for sibcalling callees with varargs
Sep 13 2019, 9:10 AM
paquette committed rL371868: [AArch64][GlobalISel] Add support for sibcalling callees with varargs.
[AArch64][GlobalISel] Add support for sibcalling callees with varargs
Sep 13 2019, 9:08 AM
paquette closed D67518: [AArch64][GlobalISel] Add support for sibcalling callees with varargs.
Sep 13 2019, 9:08 AM · Restricted Project

Sep 12 2019

paquette committed rG0c283cb50418: [AArch64][GlobalISel] Support tail calling with swiftself parameters (authored by paquette).
[AArch64][GlobalISel] Support tail calling with swiftself parameters
Sep 12 2019, 4:05 PM
paquette committed rL371788: [AArch64][GlobalISel] Support tail calling with swiftself parameters.
[AArch64][GlobalISel] Support tail calling with swiftself parameters
Sep 12 2019, 4:00 PM
paquette closed D67511: [AArch64][GlobalISel] Support tail calling with swiftself parameters.
Sep 12 2019, 4:00 PM · Restricted Project
paquette committed rGa42070a6aa8f: [AArch64][GlobalISel] Support sibling calls with outgoing arguments (authored by paquette).
[AArch64][GlobalISel] Support sibling calls with outgoing arguments
Sep 12 2019, 3:13 PM
paquette committed rL371780: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
[AArch64][GlobalISel] Support sibling calls with outgoing arguments
Sep 12 2019, 3:09 PM
paquette closed D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Sep 12 2019, 3:08 PM · Restricted Project
paquette added a parent revision for D67518: [AArch64][GlobalISel] Add support for sibcalling callees with varargs: D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Sep 12 2019, 1:41 PM · Restricted Project
paquette created D67518: [AArch64][GlobalISel] Add support for sibcalling callees with varargs.
Sep 12 2019, 1:41 PM · Restricted Project
paquette added a child revision for D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments: D67518: [AArch64][GlobalISel] Add support for sibcalling callees with varargs.
Sep 12 2019, 1:41 PM · Restricted Project
paquette added a parent revision for D67511: [AArch64][GlobalISel] Support tail calling with swiftself parameters: D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Sep 12 2019, 12:04 PM · Restricted Project
paquette created D67511: [AArch64][GlobalISel] Support tail calling with swiftself parameters.
Sep 12 2019, 12:04 PM · Restricted Project
paquette added a child revision for D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments: D67511: [AArch64][GlobalISel] Support tail calling with swiftself parameters.
Sep 12 2019, 12:04 PM · Restricted Project
paquette accepted D67333: DAG/GlobalISel: Correct type profile of bitcount ops.

I think this seems reasonable.

Sep 12 2019, 9:20 AM
paquette updated the diff for D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.

Improve comment

Sep 12 2019, 9:14 AM · Restricted Project
paquette added inline comments to D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Sep 12 2019, 9:14 AM · Restricted Project

Sep 11 2019

paquette committed rGe297ad1bd964: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility (authored by paquette).
[GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility
Sep 11 2019, 4:44 PM
paquette committed rL371692: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility.
[GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility
Sep 11 2019, 4:44 PM
paquette closed D67465: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility.
Sep 11 2019, 4:44 PM · Restricted Project
paquette added a parent revision for D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments: D67465: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility.
Sep 11 2019, 3:10 PM · Restricted Project
paquette created D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Sep 11 2019, 3:10 PM · Restricted Project
paquette added a child revision for D67465: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility: D67471: [AArch64][GlobalISel] Support sibling calls with outgoing arguments.
Sep 11 2019, 3:10 PM · Restricted Project
paquette created D67465: [GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility.
Sep 11 2019, 1:50 PM · Restricted Project
paquette added inline comments to D66210: [RISCV] Enable the machine outliner for RISC-V.
Sep 11 2019, 11:08 AM · Restricted Project

Sep 10 2019

paquette committed rG469d42fcf6b6: [GlobalISel] When a tail call is emitted in a block, stop translating it (authored by paquette).
[GlobalISel] When a tail call is emitted in a block, stop translating it
Sep 10 2019, 4:35 PM
paquette committed rL371572: [GlobalISel] When a tail call is emitted in a block, stop translating it.
[GlobalISel] When a tail call is emitted in a block, stop translating it
Sep 10 2019, 4:33 PM
paquette closed D67415: [GlobalISel] When a tail call is emitted in a block, stop translating it.
Sep 10 2019, 4:33 PM · Restricted Project
paquette committed rG2af5b193d5e5: [AArch64][GlobalISel] Support sibling calls with mismatched calling conventions (authored by paquette).
[AArch64][GlobalISel] Support sibling calls with mismatched calling conventions
Sep 10 2019, 4:25 PM
paquette committed rL371570: [AArch64][GlobalISel] Support sibling calls with mismatched calling conventions.
[AArch64][GlobalISel] Support sibling calls with mismatched calling conventions
Sep 10 2019, 4:23 PM
paquette closed D67361: [AArch64][GlobalISel] Support sibling calls with mismatched calling conventions.
Sep 10 2019, 4:23 PM · Restricted Project
paquette created D67415: [GlobalISel] When a tail call is emitted in a block, stop translating it.
Sep 10 2019, 2:10 PM · Restricted Project

Sep 9 2019

paquette created D67361: [AArch64][GlobalISel] Support sibling calls with mismatched calling conventions.
Sep 9 2019, 10:34 AM · Restricted Project
paquette committed rGbfb00e3d536e: [GlobalISel][AArch64] Handle tail calls with non-void return types (authored by paquette).
[GlobalISel][AArch64] Handle tail calls with non-void return types
Sep 9 2019, 10:16 AM
paquette committed rL371425: [GlobalISel][AArch64] Handle tail calls with non-void return types.
[GlobalISel][AArch64] Handle tail calls with non-void return types
Sep 9 2019, 10:15 AM
paquette closed D67282: [GlobalISel][AArch64] Handle tail calls with non-void return types.
Sep 9 2019, 10:15 AM · Restricted Project

Sep 6 2019

paquette accepted D67303: [AArch64][GlobalISel] Enable the localizer for optimized builds.

LGTM

Sep 6 2019, 2:50 PM · Restricted Project
paquette committed rG121d9114f567: [AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt (authored by paquette).
[AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt
Sep 6 2019, 9:49 AM
paquette committed rL371227: [AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt.
[AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt
Sep 6 2019, 9:49 AM
paquette closed D67245: [AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt.
Sep 6 2019, 9:49 AM · Restricted Project
paquette created D67282: [GlobalISel][AArch64] Handle tail calls with non-void return types.
Sep 6 2019, 9:00 AM · Restricted Project

Sep 5 2019

paquette accepted D67104: GlobalISel/TableGen: Fix handling of EXTRACT_SUBREG constraints.

LGTM in any case; I think it would be good to find out why the register class can come out wrong though.

Sep 5 2019, 4:37 PM
paquette created D67245: [AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt.
Sep 5 2019, 4:25 PM · Restricted Project
paquette committed rG20e866709882: Recommit "[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic… (authored by paquette).
Recommit "[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic…
Sep 5 2019, 1:21 PM
paquette committed rL371114: Recommit "[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic….
Recommit "[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic…
Sep 5 2019, 1:20 PM
paquette added a comment to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.

Fixed the issue. Issue was that I never tested returning something other than void. I disabled tail calling calls with non-void return types, and updated the test to reflect that.

Sep 5 2019, 1:20 PM · Restricted Project
paquette accepted D67209: [MIR] MIR Namer pass.

LGTM

Sep 5 2019, 12:50 PM · Restricted Project
paquette added inline comments to D67209: [MIR] MIR Namer pass.
Sep 5 2019, 10:55 AM · Restricted Project
paquette added a comment to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.

@RKSimon Sorry about that. I'll enable EXPENSIVE_CHECKS.

Sep 5 2019, 9:10 AM · Restricted Project

Sep 4 2019

paquette committed rGb78324fc4087: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls (authored by paquette).
[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls
Sep 4 2019, 3:57 PM
paquette committed rL370996: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
[AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls
Sep 4 2019, 3:57 PM
paquette closed D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
Sep 4 2019, 3:57 PM · Restricted Project
paquette added a comment to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.

I'm going to commit this as-is and put up a separate review for remarks.

Sep 4 2019, 3:43 PM · Restricted Project
paquette added inline comments to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
Sep 4 2019, 3:36 PM · Restricted Project
paquette added inline comments to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
Sep 4 2019, 11:47 AM · Restricted Project
paquette added inline comments to D67133: [GlobalISel]: Fix some non determinism exposed in CSE due to not notifying observers about mutations + add verification for CSE.
Sep 4 2019, 11:38 AM · Restricted Project
paquette accepted D67187: GlobalISel: Add basic legalization for G_BITREVERSE.

LGTM

Sep 4 2019, 11:25 AM
paquette accepted D67136: GlobalISel/TableGen: Handle REG_SEQUENCE patterns.

LGTM with style nit

Sep 4 2019, 11:21 AM
paquette created D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
Sep 4 2019, 11:13 AM · Restricted Project