This revision supports to scalarize a binary operation of two scalable
splat vectors.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | ||
---|---|---|
23506 | Not sure we should be creating SPLAT_VECTOR on targets that don't support SPLAT_VECTOR. At the very least it's a waste of compile time to convert it back to a BUILD_VECTOR. |
LGTM with one minor
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | ||
---|---|---|
23476 | OK - please can you add a TODO comment? It sounds like something that needs revisiting in the future. |
We're seeing failures after this revision https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8808242343748276609/overview, as well as upstream bots https://lab.llvm.org/buildbot/#/builders/188/builds/17108
Use DAG.isSplatValue instead?