Page MenuHomePhabricator

mkazantsev (Max Kazantsev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2017, 8:11 PM (121 w, 10 h)

Recent Activity

Feb 21 2019

mkazantsev added inline comments to D58524: [LoopSimplifyCFG] Update MemorySSA after r353911..
Feb 21 2019, 10:27 PM · Restricted Project
mkazantsev created D58500: [DO NOT MERGE] Explore MSSA behavior in LoopSimplifyCFG.
Feb 21 2019, 3:44 AM · Restricted Project
mkazantsev committed rG8ff2e8699428: [NFC] Replace EOL in test file (authored by mkazantsev).
[NFC] Replace EOL in test file
Feb 21 2019, 1:56 AM
mkazantsev committed rL354562: [NFC] Replace EOL in test file.
[NFC] Replace EOL in test file
Feb 21 2019, 1:56 AM
mkazantsev committed rGb672602f9ed9: [TEST] Add failing test that shows problems with MSSA update in LoopSimplifyCFG (authored by mkazantsev).
[TEST] Add failing test that shows problems with MSSA update in LoopSimplifyCFG
Feb 21 2019, 1:40 AM
mkazantsev committed rL354559: [TEST] Add failing test that shows problems with MSSA update in LoopSimplifyCFG.
[TEST] Add failing test that shows problems with MSSA update in LoopSimplifyCFG
Feb 21 2019, 1:39 AM

Feb 20 2019

mkazantsev committed rG10489d76f635: [LoopSimplifyCFG] Add missing MSSA edge deletion (authored by mkazantsev).
[LoopSimplifyCFG] Add missing MSSA edge deletion
Feb 20 2019, 9:52 PM
mkazantsev committed rL354547: [LoopSimplifyCFG] Add missing MSSA edge deletion.
[LoopSimplifyCFG] Add missing MSSA edge deletion
Feb 20 2019, 9:50 PM
mkazantsev added a comment to D58113: [SCEV] Teach computeSCEVAtScope benefit from one-input Phi. PR39673.

Ping?

Feb 20 2019, 3:08 AM

Feb 19 2019

mkazantsev added a comment to D58231: [LICM] Support of widenable condition guards in LICM.

Ok. Then I suggest to hold it off unless we see a case where unswitch doesn't do its job and this does.

Feb 19 2019, 9:58 PM · Restricted Project
mkazantsev added a comment to D58231: [LICM] Support of widenable condition guards in LICM.

The main motivation is unification - I don't want to leave a single thing that is supported for intrinsic guards and not supported for control flow guards. Unswitching has known problems related to exponential code size growth, so I don't want our ability to eliminate guards in loops to depend on its cost model.

Feb 19 2019, 3:21 AM · Restricted Project
mkazantsev committed rGebd95ea86e45: [NFC] API for signaling that the current loop is being deleted (authored by mkazantsev).
[NFC] API for signaling that the current loop is being deleted
Feb 19 2019, 3:19 AM
mkazantsev committed rG30095d97955c: [NFC] Store loop header in a local to keep it available after the loop is… (authored by mkazantsev).
[NFC] Store loop header in a local to keep it available after the loop is…
Feb 19 2019, 3:19 AM
mkazantsev committed rL354314: [NFC] API for signaling that the current loop is being deleted.
[NFC] API for signaling that the current loop is being deleted
Feb 19 2019, 3:19 AM
mkazantsev committed rL354313: [NFC] Store loop header in a local to keep it available after the loop is….
[NFC] Store loop header in a local to keep it available after the loop is…
Feb 19 2019, 3:19 AM
mkazantsev updated the diff for D54831: [LoopSimplifyCFG] Delete current loop.

Rebased.

Feb 19 2019, 3:11 AM · Restricted Project
mkazantsev updated the diff for D54750: [LoopSimplifyCFG] Support blocks that are live, but no longer a part of current loop.

Rebased.

Feb 19 2019, 3:09 AM · Restricted Project

Feb 17 2019

mkazantsev updated the diff for D54750: [LoopSimplifyCFG] Support blocks that are live, but no longer a part of current loop.
Feb 17 2019, 10:29 AM · Restricted Project
mkazantsev updated the diff for D54750: [LoopSimplifyCFG] Support blocks that are live, but no longer a part of current loop.
Feb 17 2019, 10:29 AM · Restricted Project
mkazantsev committed rG635b98857850: [TEST] Remove 2>&1 from tests (authored by mkazantsev).
[TEST] Remove 2>&1 from tests
Feb 17 2019, 10:22 AM
mkazantsev committed rG4561475e0913: [NFC] Teach getInnermostLoopFor walk up the loop trees (authored by mkazantsev).
[NFC] Teach getInnermostLoopFor walk up the loop trees
Feb 17 2019, 10:22 AM
mkazantsev committed rL354229: [TEST] Remove 2>&1 from tests.
[TEST] Remove 2>&1 from tests
Feb 17 2019, 10:22 AM
mkazantsev committed rL354227: [NFC] Teach getInnermostLoopFor walk up the loop trees.
[NFC] Teach getInnermostLoopFor walk up the loop trees
Feb 17 2019, 10:22 AM
mkazantsev committed rGd72c1a0c5c66: [NFC] Fix name and clarifying comment for factored-out function (authored by mkazantsev).
[NFC] Fix name and clarifying comment for factored-out function
Feb 17 2019, 7:23 AM
mkazantsev committed rL354220: [NFC] Fix name and clarifying comment for factored-out function.
[NFC] Fix name and clarifying comment for factored-out function
Feb 17 2019, 7:22 AM
mkazantsev committed rG0f943269a01f: [NFC] Factor out a function for future reuse (authored by mkazantsev).
[NFC] Factor out a function for future reuse
Feb 17 2019, 7:04 AM
mkazantsev committed rL354218: [NFC] Factor out a function for future reuse.
[NFC] Factor out a function for future reuse
Feb 17 2019, 7:04 AM

Feb 15 2019

mkazantsev committed rGc065b025a666: [NFCI] Factor out block removal from stack of nested loops (authored by mkazantsev).
[NFCI] Factor out block removal from stack of nested loops
Feb 15 2019, 4:21 AM
mkazantsev committed rL354124: [NFCI] Factor out block removal from stack of nested loops.
[NFCI] Factor out block removal from stack of nested loops
Feb 15 2019, 4:21 AM
mkazantsev committed rG136f09bea19b: [NFC] Promote DFS to field for further use (authored by mkazantsev).
[NFC] Promote DFS to field for further use
Feb 15 2019, 3:39 AM
mkazantsev committed rL354118: [NFC] Promote DFS to field for further use.
[NFC] Promote DFS to field for further use
Feb 15 2019, 3:39 AM
mkazantsev updated the diff for D58231: [LICM] Support of widenable condition guards in LICM.
Feb 15 2019, 1:37 AM · Restricted Project
mkazantsev committed rG73db5c137af2: [NFC] Tweak SplitBlockAndInsertIfThen to use existing ThenBlock (authored by mkazantsev).
[NFC] Tweak SplitBlockAndInsertIfThen to use existing ThenBlock
Feb 15 2019, 12:18 AM
mkazantsev committed rL354107: [NFC] Tweak SplitBlockAndInsertIfThen to use existing ThenBlock.
[NFC] Tweak SplitBlockAndInsertIfThen to use existing ThenBlock
Feb 15 2019, 12:18 AM

Feb 14 2019

mkazantsev committed rG184bd7a0d856: [TEST] Update test comments, refactor checks with update_test_checks.py (authored by mkazantsev).
[TEST] Update test comments, refactor checks with update_test_checks.py
Feb 14 2019, 11:07 PM
mkazantsev committed rL354101: [TEST] Update test comments, refactor checks with update_test_checks.py.
[TEST] Update test comments, refactor checks with update_test_checks.py
Feb 14 2019, 11:07 PM
mkazantsev added inline comments to D58187: Teach DTU to recalculate DT/PDT automatically when EntryBB is changed.
Feb 14 2019, 10:10 PM · Restricted Project
mkazantsev planned changes to D58231: [LICM] Support of widenable condition guards in LICM.
Feb 14 2019, 9:26 PM · Restricted Project
mkazantsev created D58231: [LICM] Support of widenable condition guards in LICM.
Feb 14 2019, 4:51 AM · Restricted Project
mkazantsev committed rG24383cd7bbe2: Make widenable condition transparent for MemoryWriteTracking (authored by mkazantsev).
Make widenable condition transparent for MemoryWriteTracking
Feb 14 2019, 3:11 AM
mkazantsev committed rGb3168a400f2f: Teach isGuaranteedToTransferExecutionToSuccessor about widenable conditions (authored by mkazantsev).
Teach isGuaranteedToTransferExecutionToSuccessor about widenable conditions
Feb 14 2019, 3:11 AM
mkazantsev committed rL354021: Make widenable condition transparent for MemoryWriteTracking.
Make widenable condition transparent for MemoryWriteTracking
Feb 14 2019, 3:11 AM
mkazantsev committed rL354020: Teach isGuaranteedToTransferExecutionToSuccessor about widenable conditions.
Teach isGuaranteedToTransferExecutionToSuccessor about widenable conditions
Feb 14 2019, 3:11 AM
mkazantsev committed rGdeaf2ba28007: [NFC] Refactor LICM code for better readability (authored by mkazantsev).
[NFC] Refactor LICM code for better readability
Feb 14 2019, 1:05 AM
mkazantsev committed rL354013: [NFC] Refactor LICM code for better readability.
[NFC] Refactor LICM code for better readability
Feb 14 2019, 1:03 AM

Feb 13 2019

mkazantsev added a comment to D57428: [SCEV] Guard movement of insertion point for loop-invariants (take 2).

I did not look into this too deeply, but the problem you're describing sounds like it can be solved by setting InsertPt to getFirstNonPHI at some point.

Feb 13 2019, 9:32 PM · Restricted Project
mkazantsev accepted D57881: [DTU] Refine the document of mutation APIs [NFC] (PR40528).

LGTM. Thakns a lot for doing this!

Feb 13 2019, 9:18 PM · Restricted Project
mkazantsev accepted D58192: [LoopUnrollPeel] Add case where we should forget the peeled loop from SCEV..
Feb 13 2019, 9:11 PM · Restricted Project
mkazantsev added a comment to D58192: [LoopUnrollPeel] Add case where we should forget the peeled loop from SCEV..

LGTM, but use forgetTopmostLoop instead.

Feb 13 2019, 9:11 PM · Restricted Project
mkazantsev committed rG3fe9ad7a9f07: [NFC] Add const qualifiers where possible (authored by mkazantsev).
[NFC] Add const qualifiers where possible
Feb 13 2019, 3:55 AM
mkazantsev committed rL353941: [NFC] Add const qualifiers where possible.
[NFC] Add const qualifiers where possible
Feb 13 2019, 3:54 AM
mkazantsev abandoned D57568: [SCEV] Don't bother preserving LCSSA in SCEV.

Looks like there is a lot of places in code that expect that... :(

Feb 13 2019, 2:25 AM
mkazantsev committed rG2bb95e7c7646: [GuardWidening] Support widening of explicitly expressed guards (authored by mkazantsev).
[GuardWidening] Support widening of explicitly expressed guards
Feb 13 2019, 1:59 AM
mkazantsev committed rL353932: [GuardWidening] Support widening of explicitly expressed guards.
[GuardWidening] Support widening of explicitly expressed guards
Feb 13 2019, 1:59 AM
mkazantsev closed D56075: [GuardWidening] Support widening of explicitly expressed guards.
Feb 13 2019, 1:59 AM · Restricted Project
mkazantsev updated the diff for D56075: [GuardWidening] Support widening of explicitly expressed guards.

Added test with mixed guards (both intrinsic and widenable conditions).

Feb 13 2019, 1:42 AM · Restricted Project

Feb 12 2019

mkazantsev committed rG5cf777e41387: [LoopSimplifyCFG] Re-enable const branch folding by default (authored by mkazantsev).
[LoopSimplifyCFG] Re-enable const branch folding by default
Feb 12 2019, 10:14 PM
mkazantsev committed rL353911: [LoopSimplifyCFG] Re-enable const branch folding by default.
[LoopSimplifyCFG] Re-enable const branch folding by default
Feb 12 2019, 10:12 PM
mkazantsev added inline comments to D57881: [DTU] Refine the document of mutation APIs [NFC] (PR40528).
Feb 12 2019, 9:41 PM · Restricted Project
mkazantsev created D58113: [SCEV] Teach computeSCEVAtScope benefit from one-input Phi. PR39673.
Feb 12 2019, 3:57 AM
mkazantsev committed rG4a1c02987e2a: [NFC] Simplify code & reduce nest slightly (authored by mkazantsev).
[NFC] Simplify code & reduce nest slightly
Feb 12 2019, 3:33 AM
mkazantsev committed rL353832: [NFC] Simplify code & reduce nest slightly.
[NFC] Simplify code & reduce nest slightly
Feb 12 2019, 3:33 AM
mkazantsev added inline comments to D57881: [DTU] Refine the document of mutation APIs [NFC] (PR40528).
Feb 12 2019, 2:59 AM · Restricted Project
mkazantsev committed rG2a184af22185: [IndVars] Fix corner case with unreachable Phi inputs. PR40454 (authored by mkazantsev).
[IndVars] Fix corner case with unreachable Phi inputs. PR40454
Feb 12 2019, 2:00 AM
mkazantsev committed rL353816: [IndVars] Fix corner case with unreachable Phi inputs. PR40454.
[IndVars] Fix corner case with unreachable Phi inputs. PR40454
Feb 12 2019, 1:59 AM
mkazantsev closed D58045: [IndVars] Fix corner case with unreachable Phi inputs. PR40454.
Feb 12 2019, 1:59 AM · Restricted Project
mkazantsev updated the diff for D58045: [IndVars] Fix corner case with unreachable Phi inputs. PR40454.

Moved print after check.

Feb 12 2019, 1:41 AM · Restricted Project
mkazantsev committed rGbf6af8fbf007: [LoopSimplifyCFG] Change logic of dead loops removal to avoid hitting asserts (authored by mkazantsev).
[LoopSimplifyCFG] Change logic of dead loops removal to avoid hitting asserts
Feb 12 2019, 1:37 AM
mkazantsev committed rL353813: [LoopSimplifyCFG] Change logic of dead loops removal to avoid hitting asserts.
[LoopSimplifyCFG] Change logic of dead loops removal to avoid hitting asserts
Feb 12 2019, 1:36 AM
mkazantsev closed D57221: [LoopSimplifyCFG] Change logic of dead loops removal to avoid hitting asserts.
Feb 12 2019, 1:36 AM · Restricted Project
Herald updated subscribers of D57221: [LoopSimplifyCFG] Change logic of dead loops removal to avoid hitting asserts.
Feb 12 2019, 1:31 AM · Restricted Project
mkazantsev committed rG9aae9da947e1: Delete blocks from DTU to avoid dangling pointers (authored by mkazantsev).
Delete blocks from DTU to avoid dangling pointers
Feb 12 2019, 12:11 AM
mkazantsev committed rL353804: Delete blocks from DTU to avoid dangling pointers.
Delete blocks from DTU to avoid dangling pointers
Feb 12 2019, 12:11 AM

Feb 11 2019

mkazantsev committed rG6bf861597c87: [LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks (authored by mkazantsev).
[LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks
Feb 11 2019, 11:49 PM
mkazantsev committed rL353803: [LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks.
[LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks
Feb 11 2019, 11:47 PM
mkazantsev closed D57231: [LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks.
Feb 11 2019, 11:47 PM · Restricted Project
mkazantsev committed rG20b9189975e0: [NFC] Rename DontDeleteUselessPHIs --> KeepOneInputPHIs (authored by mkazantsev).
[NFC] Rename DontDeleteUselessPHIs --> KeepOneInputPHIs
Feb 11 2019, 11:11 PM
mkazantsev committed rL353801: [NFC] Rename DontDeleteUselessPHIs --> KeepOneInputPHIs.
[NFC] Rename DontDeleteUselessPHIs --> KeepOneInputPHIs
Feb 11 2019, 11:09 PM
mkazantsev added inline comments to D57231: [LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks.
Feb 11 2019, 11:09 PM · Restricted Project
mkazantsev committed rG0686d1ae4170: [NFC] Add parameter for keeping one-input Phis in DeleteDeadBlock(s) (authored by mkazantsev).
[NFC] Add parameter for keeping one-input Phis in DeleteDeadBlock(s)
Feb 11 2019, 10:15 PM
mkazantsev committed rL353799: [NFC] Add parameter for keeping one-input Phis in DeleteDeadBlock(s).
[NFC] Add parameter for keeping one-input Phis in DeleteDeadBlock(s)
Feb 11 2019, 10:14 PM
mkazantsev added a comment to D57231: [LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks.

I'll split out changes in basic block utils as separate NFC, then submit change in LoopSimplifyCFG separately.

Feb 11 2019, 9:23 PM · Restricted Project
mkazantsev added inline comments to D57231: [LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks.
Feb 11 2019, 9:09 PM · Restricted Project
mkazantsev committed rG0136e7a24613: [TEST] Add missing opportunity test for PR39673 (authored by mkazantsev).
[TEST] Add missing opportunity test for PR39673
Feb 11 2019, 4:58 AM
mkazantsev committed rL353693: [TEST] Add missing opportunity test for PR39673.
[TEST] Add missing opportunity test for PR39673
Feb 11 2019, 4:58 AM
mkazantsev created D58045: [IndVars] Fix corner case with unreachable Phi inputs. PR40454.
Feb 11 2019, 4:04 AM · Restricted Project
mkazantsev committed rG8ec0c5e02f5e: [TEST] Add failing test from PR40454 (authored by mkazantsev).
[TEST] Add failing test from PR40454
Feb 11 2019, 2:45 AM
mkazantsev committed rL353688: [TEST] Add failing test from PR40454.
[TEST] Add failing test from PR40454
Feb 11 2019, 2:44 AM

Feb 10 2019

mkazantsev added inline comments to D57881: [DTU] Refine the document of mutation APIs [NFC] (PR40528).
Feb 10 2019, 9:55 PM · Restricted Project

Feb 8 2019

mkazantsev committed rG6b63d3a27709: [LoopSimplifyCFG] Use DTU.applyUpdates instead of insert/deleteEdge (authored by mkazantsev).
[LoopSimplifyCFG] Use DTU.applyUpdates instead of insert/deleteEdge
Feb 8 2019, 12:14 AM
mkazantsev committed rL353502: [LoopSimplifyCFG] Use DTU.applyUpdates instead of insert/deleteEdge.
[LoopSimplifyCFG] Use DTU.applyUpdates instead of insert/deleteEdge
Feb 8 2019, 12:13 AM
mkazantsev closed D57316: [LoopSimplifyCFG] Use DTU.applyUpdates instead of insert/deleteEdge.
Feb 8 2019, 12:13 AM · Restricted Project

Feb 6 2019

mkazantsev added a comment to D46044: [LoopUnrollPeel] Fix potentially incorrect invalidation of SCEV in peelLoop.

Hi Florian,

Feb 6 2019, 11:39 PM
mkazantsev added reviewers for D57231: [LoopSimplifyCFG] Pay respect to LCSSA when removing dead blocks: skatkov, apilipenko, reames.
Feb 6 2019, 11:15 PM · Restricted Project
mkazantsev updated the diff for D57316: [LoopSimplifyCFG] Use DTU.applyUpdates instead of insert/deleteEdge.
Feb 6 2019, 10:44 PM · Restricted Project
mkazantsev added a comment to D57316: [LoopSimplifyCFG] Use DTU.applyUpdates instead of insert/deleteEdge.

Actually I am just confused by the number of different ways to do the same thing, all having different bugs inside. If using DTU.applyUpdates is the right day now, I'm ok with that.

Feb 6 2019, 10:06 PM · Restricted Project
mkazantsev added inline comments to D56075: [GuardWidening] Support widening of explicitly expressed guards.
Feb 6 2019, 4:02 AM · Restricted Project
mkazantsev updated the diff for D56075: [GuardWidening] Support widening of explicitly expressed guards.

Removed redundant code by an NFC, rebased.

Feb 6 2019, 3:38 AM · Restricted Project
mkazantsev committed rGcd48ac36613f: [NFC] Simplify check in guard widening (authored by mkazantsev).
[NFC] Simplify check in guard widening
Feb 6 2019, 3:27 AM
mkazantsev committed rL353290: [NFC] Simplify check in guard widening.
[NFC] Simplify check in guard widening
Feb 6 2019, 3:26 AM