This is an archive of the discontinued LLVM Phabricator instance.

Cleanup MCParser headers
ClosedPublic

Authored by serge-sans-paille on Feb 9 2022, 11:07 AM.

Details

Summary

As usual with that header cleanup series, some implicit dependencies now need to
be explicit:

llvm/MC/MCParser/MCAsmParser.h no longer includes llvm/MC/MCParser/MCAsmLexer.h

Preprocessed lines to build llvm on my setup:
after: 1068185081
before: 1068324320

So no compile time benefit to expect, but we still get the looser coupling
between files which is great.

Discourse thread: https://discourse.llvm.org/t/include-what-you-use-include-cleanup

Diff Detail

Unit TestsFailed

Event Timeline

serge-sans-paille requested review of this revision.Feb 9 2022, 11:07 AM

Rebased on main / no changes

MaskRay accepted this revision.Feb 10 2022, 9:25 PM

Looks great!

This revision is now accepted and ready to land.Feb 10 2022, 9:25 PM
This revision was landed with ongoing or failed builds.Feb 11 2022, 1:40 AM
This revision was automatically updated to reflect the committed changes.