This is an archive of the discontinued LLVM Phabricator instance.

[flang] Use `GNUInstallDirs` to support custom installation dirs.
ClosedPublic

Authored by Ericson2314 on Dec 10 2021, 7:15 PM.

Details

Summary

Extracted from D99484. My new plan is to start from the outside and work
inward.

Diff Detail

Event Timeline

Ericson2314 created this revision.Dec 10 2021, 7:15 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: mgorny. · View Herald Transcript
Ericson2314 requested review of this revision.Dec 10 2021, 7:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2021, 7:15 PM

Fix installed config include dir

MehdiChinoune added inline comments.
flang/cmake/modules/AddFlang.cmake
2
MehdiChinoune added inline comments.Dec 13 2021, 3:27 AM
flang/cmake/modules/AddFlang.cmake
2

Fix typo @MehdiChinoune found

Thanks, and sory that was there! I hand-split up my old patch and need to do
some test builds since there are new changes beyond the split like that one
line.

Ericson2314 marked an inline comment as done.Dec 13 2021, 9:45 AM
  1. Updating D115569: [flang] Use GNUInstallDirs to support custom installation dirs. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

Fix typo

Reuse function from LLD's patch

Ericson2314 marked an inline comment as done.Dec 27 2021, 1:25 PM
  1. Updating D115569: [flang] Use GNUInstallDirs to support custom installation dirs. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

rebase to hopefully fix pre-merge CI

  1. Updating D115569: [flang] Use GNUInstallDirs to support custom installation dirs. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

fix mod inc path

  1. Updating D115569: [flang] Use GNUInstallDirs to support custom installation dirs. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

rebase

  1. Updating D115569: [flang] Use GNUInstallDirs to support custom installation dirs. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

fix bad import

This revision is now accepted and ready to land.Dec 31 2021, 1:28 AM