Page MenuHomePhabricator

Leporacanthicus (Mats Petersson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2016, 9:41 AM (372 w, 2 d)

Recent Activity

Fri, Mar 17

Leporacanthicus added a comment to D141306: Add loop-versioning pass to improve unit-stride.

I failed to apply this patch locally.

Fri, Mar 17, 10:11 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141306: Add loop-versioning pass to improve unit-stride.

Rebase only

Fri, Mar 17, 10:10 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141307: Add -f[no-]loop-versioning option.

Rebase and fix conflicts

Fri, Mar 17, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus added a comment to D141306: Add loop-versioning pass to improve unit-stride.

I failed to apply this patch locally.

Fri, Mar 17, 2:44 AM · Restricted Project, Restricted Project

Thu, Mar 16

Leporacanthicus added a comment to D141306: Add loop-versioning pass to improve unit-stride.

Yes, I've only spent SOME time trying to understand why vectorizer doesn't - it basically comes down to "can't figure out how the stride is calculated, and whether it may change over time". The loop versioning here is helping to solve that for the lower layers in the compiler - and in my experience (I've written quite a few different style loops and such), either some MLIR pass(es) manages to vectorize the codr, or LLVM loop vectorizer can't do it either. [Why is there two layers of vectorizers? I don't know - presumably people like to write code that does similar things on multiple levels].

OK.

Also, the overall goal isn't ONLY to vectorize, but also to "improve overall loop performance". It may be that we can convince the compiler to do a better job in some other way, but right now, I'm not aware of what that should be. The fundamental problem is that the descriptors used to pass array information is getting in the way of lots of things. It should be noted that although we see performance improvement in roms_r, it does NOT come from vectorization of the loop constructs - both gfortran and flang uses loop versioning, and gets similar performance improvement - and neither compiler uses vector instructions in the hot loops in ROMS.

I am confused about how the performance gets improved for roms_r you mentioned. From the test in this patch, I can only see the optimization opportunity of loop vectorization after loop versioning. Maybe another test case extracted in roms_r showing how it gets performance improvement is better.

Thu, Mar 16, 12:03 PM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D141306: Add loop-versioning pass to improve unit-stride.

FYI, another related scenario is https://github.com/llvm/llvm-project/issues/59388.

I also faced one case having loop interchange opportunity, which is blocked by the Fortran array stride information not understood by SCEV analysis. I think this is one common issue in loop optimization. So there maybe need some discussions whether loop versioning in MLIR pass is the right solution.

Thu, Mar 16, 11:30 AM · Restricted Project, Restricted Project

Wed, Mar 15

Leporacanthicus accepted D146075: [flang][driver][openmp] Write MLIR for -save-temps.

LGTM.

Wed, Mar 15, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus added a reviewer for D141306: Add loop-versioning pass to improve unit-stride: SBallantyne.
Wed, Mar 15, 7:47 AM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D141306: Add loop-versioning pass to improve unit-stride.

I have not noticed any measurable increase in compile time - Spec 2017 wrf_r takes within 1-2 seconds, and that's the one that takes about 15 minutes to build in total. I'm not saying it's impossible to come up with something that compiles slowly with this code, but I've made as good an attempt as I can to "exit early" if there's nothing that needs doing, and only duplicate the innermost loop [which potentially is not the most optimal case].

Great! This sounds good to me.

The problem I'm trying to solve here is that the Loop Vectorizer optimisation doesn't "like" the descriptor access to read the strides [and other descriptor accesses] - it doesn't understand that the value is a constant for a given run of a loop. With versioning , it basically makes the Loop Vectorizer "happy" with the loop, so it can do its own thing.

I think the loop vectorize pass is doing the similar thing. Check the generated LLVM IR the following Fortran case:

subroutine sum1d(a, n)
  real*8 :: a(:)
  integer :: n
  real*8 :: sum
  integer :: i
  sum = 0
  do i=1,n
     sum = sum + a(i)
  end do
  call temp(sum)
end subroutine sum1d
$ flang-new -fc1 -emit-llvm -O3 test.f90
$ cat test.ll
define void @sum1d_(ptr nocapture readonly %0, ptr nocapture readonly %1) local_unnamed_addr {
  %3 = alloca double, align 8
  store double 0.000000e+00, ptr %3, align 8, !tbaa !1
  %4 = load i32, ptr %1, align 4, !tbaa !1
  %5 = icmp sgt i32 %4, 0
  br i1 %5, label %.lr.ph, label %._crit_edge

.lr.ph:                                           ; preds = %2
  %6 = zext i32 %4 to i64
  %7 = load ptr, ptr %0, align 8, !tbaa !5
  %8 = getelementptr { ptr, i64, i32, i8, i8, i8, i8, [1 x [3 x i64]] }, ptr %0, i64 0, i32 7, i64 0, i64 2
  %9 = load i64, ptr %8, align 8, !tbaa !5
  br label %10

10:                                               ; preds = %.lr.ph, %10
  %indvars.iv = phi i64 [ 1, %.lr.ph ], [ %indvars.iv.next, %10 ]
  %11 = phi double [ 0.000000e+00, %.lr.ph ], [ %16, %10 ]
  %12 = add nsw i64 %indvars.iv, -1
  %13 = mul i64 %9, %12
  %14 = getelementptr i8, ptr %7, i64 %13                                                            ! Note: This has the similar structure as the LLVM IR generated from the following C code.
  %15 = load double, ptr %14, align 8, !tbaa !1
  %16 = fadd contract double %11, %15
  store double %16, ptr %3, align 8, !tbaa !1
  %indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
  %exitcond.not = icmp eq i64 %indvars.iv, %6
  br i1 %exitcond.not, label %._crit_edge, label %10

._crit_edge:                                      ; preds = %10, %2
  call void @temp_(ptr nonnull %3)
  ret void
}

When you compare it with the generated IR from the following C case using clang case.c -S -emit-llvm -O3:

void temp(double *sum);

void test1(double * restrict A, double * restrict B, int N, int Stride) {
  int i;
  for (i = 0; i < N; ++i)
    B[i * Stride] += A[i * Stride];
}

void test2(double * restrict A, int N, int Stride) {
  int i;
  double sum = 0.0;
  for (i = 0; i < N; ++i)
    sum += A[i * Stride];
  temp(&sum);
}

The loop in function test1 can be vectorized using stride-check loop versioning. I don't dig why test2 fail in vectorizing the reduction. Anyway, the loop vectorize pass can do some similar work. But I am not sure if the SCEV analysis there can handle the Fortran case.

Wed, Mar 15, 3:48 AM · Restricted Project, Restricted Project

Tue, Mar 14

Leporacanthicus added a comment to D141306: Add loop-versioning pass to improve unit-stride.

I am thinking if we should do the loop versioning in MLIR since this may increase compilation time in optimization passes.

Tue, Mar 14, 12:03 PM · Restricted Project, Restricted Project

Wed, Mar 8

Leporacanthicus added inline comments to D141306: Add loop-versioning pass to improve unit-stride.
Wed, Mar 8, 11:39 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141306: Add loop-versioning pass to improve unit-stride.

Updated to reflect review comments.

  • Use different type for Walk functions.
  • Use "unwrap" functions to get to types.
  • Fix some debug output and related stuff.
  • Some other minor changes, including clang-format fixups.
Wed, Mar 8, 11:28 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141307: Add -f[no-]loop-versioning option.

Fix copied comment to reflect the new content.

Wed, Mar 8, 11:25 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus added inline comments to D141307: Add -f[no-]loop-versioning option.
Wed, Mar 8, 7:41 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141307: Add -f[no-]loop-versioning option.

Updates based on review comments:

  • Add tests.
  • Enable on -O3
Wed, Mar 8, 7:25 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 6

Leporacanthicus added reviewers for D141306: Add loop-versioning pass to improve unit-stride: vzakhari, peixin, tblah.
Mon, Mar 6, 7:10 AM · Restricted Project, Restricted Project

Fri, Mar 3

Leporacanthicus retitled D141306: Add loop-versioning pass to improve unit-stride from WIP LoopVersioning to Add loop-versioning pass to improve unit-stride.
Fri, Mar 3, 2:42 AM · Restricted Project, Restricted Project
Leporacanthicus retitled D141307: Add -f[no-]loop-versioning option from [WIP] Add -f[no-]loop-versioning option to Add -f[no-]loop-versioning option.
Fri, Mar 3, 2:39 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 2

Leporacanthicus updated the diff for D141306: Add loop-versioning pass to improve unit-stride.

Add tests.

Thu, Mar 2, 8:30 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141307: Add -f[no-]loop-versioning option.

Update for rebase.

Thu, Mar 2, 8:22 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Feb 28

Leporacanthicus accepted D144974: [flang] Fix a bug with simplified minloc that treated logicals with even values > 1 as 0.

LGTM

Tue, Feb 28, 8:34 AM · Restricted Project, Restricted Project

Feb 21 2023

Leporacanthicus added a comment to D144103: [Flang] Add Minloc to simplify intrinsics pass.

Generally looks OK, just some minor nitpicks.

Feb 21 2023, 10:43 AM · Restricted Project, Restricted Project

Feb 16 2023

Leporacanthicus updated the diff for D141306: Add loop-versioning pass to improve unit-stride.

Update to remove WIP

Feb 16 2023, 10:15 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141307: Add -f[no-]loop-versioning option.

Rebased and updated help-message

Feb 16 2023, 10:13 AM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2023

Leporacanthicus added a comment to D143899: [Flang] Fix for Any/All simplification to properly propogate the inital value.

Aside from minor nit-picks, this looks good to me.

Feb 13 2023, 9:15 AM · Restricted Project, Restricted Project

Feb 3 2023

Leporacanthicus accepted D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

LGTM.

Feb 3 2023, 6:17 AM · Restricted Project, Restricted Project

Feb 2 2023

Leporacanthicus updated the diff for D141306: Add loop-versioning pass to improve unit-stride.

Updated patch, now works for 1D and 2D arrays.

Feb 2 2023, 4:09 AM · Restricted Project, Restricted Project

Feb 1 2023

Leporacanthicus added inline comments to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Feb 1 2023, 7:21 AM · Restricted Project, Restricted Project

Jan 31 2023

Leporacanthicus updated the diff for D141306: Add loop-versioning pass to improve unit-stride.

Some progress, now identifying the correct loops a little better.

Jan 31 2023, 12:10 PM · Restricted Project, Restricted Project
Leporacanthicus added inline comments to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Jan 31 2023, 9:24 AM · Restricted Project, Restricted Project

Jan 30 2023

Leporacanthicus accepted D142877: [flang] Fix simplify intrinsic for count not checking for rank = 0 properly.

LGTM, thanks for fixing!

Jan 30 2023, 3:47 AM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D142877: [flang] Fix simplify intrinsic for count not checking for rank = 0 properly.

Looks OK except for the test checking for the wrong "Not".

Jan 30 2023, 2:53 AM · Restricted Project, Restricted Project

Jan 26 2023

Leporacanthicus accepted D142209: [flang] Add Count to simplified intrinsics.

I think this is good to go in now, subject to @vzakhari not finding anything else wrong.

Jan 26 2023, 11:53 AM · Restricted Project, Restricted Project

Jan 20 2023

Leporacanthicus added a comment to D142209: [flang] Add Count to simplified intrinsics.

Looks OK in general, just some minor tidy-up suggestions.

Jan 20 2023, 9:28 AM · Restricted Project, Restricted Project

Jan 13 2023

Leporacanthicus updated the diff for D141306: Add loop-versioning pass to improve unit-stride.

Rebase again

Jan 13 2023, 5:08 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141307: Add -f[no-]loop-versioning option.

Rebase

Jan 13 2023, 4:48 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141306: Add loop-versioning pass to improve unit-stride.

Rebase to latest llvm/main.

Jan 13 2023, 4:12 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D141306: Add loop-versioning pass to improve unit-stride.

Added "move remaining loop into else branch" and related changes.

Jan 13 2023, 4:01 AM · Restricted Project, Restricted Project

Jan 10 2023

Leporacanthicus added a comment to D141306: Add loop-versioning pass to improve unit-stride.

Hi @Leporacanthicus, thank you for working on this! I wonder if you target any particular benchmark with these changes - can you please post any information in the description?

This is work described here:
https://discourse.llvm.org/t/transformations-to-aid-optimizer-for-subroutines-functions-with-assumed-shape-arguments/66447/3

Jan 10 2023, 12:57 PM · Restricted Project, Restricted Project

Jan 9 2023

Leporacanthicus requested review of D141307: Add -f[no-]loop-versioning option.
Jan 9 2023, 10:27 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus requested review of D141306: Add loop-versioning pass to improve unit-stride.
Jan 9 2023, 10:25 AM · Restricted Project, Restricted Project

Nov 3 2022

Leporacanthicus added inline comments to D137335: [flang]Fix build failure in tests.
Nov 3 2022, 7:38 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D137335: [flang]Fix build failure in tests.

Try again, this time without requires line

Nov 3 2022, 7:38 AM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D137335: [flang]Fix build failure in tests.

What if you remove --target=x86_64-unknown-linux-gnu instead and make the tests target agnostic?

Nov 3 2022, 7:28 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D137335: [flang]Fix build failure in tests.

Instead of requiring x86, remove target in tests. This will allow
testing on a wider range of targets, rather than a smaller range.

Nov 3 2022, 7:19 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D137335: [flang]Fix build failure in tests.

Update to correct typos.

Nov 3 2022, 6:41 AM · Restricted Project, Restricted Project
Leporacanthicus added reviewers for D137335: [flang]Fix build failure in tests: vzakhari, kiranchandramohan, DavidTruby, tblah, awarzynski.
Nov 3 2022, 6:31 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D137335: [flang]Fix build failure in tests.
Nov 3 2022, 6:28 AM · Restricted Project, Restricted Project

Nov 2 2022

Leporacanthicus updated the diff for D133568: [Flang][Driver]Add datalayout before doing LLVM-IR transformation.

Update comments (clarify/reword, fix typos) and rebase.

Nov 2 2022, 11:18 AM · Restricted Project, Restricted Project

Oct 19 2022

Leporacanthicus added inline comments to D133568: [Flang][Driver]Add datalayout before doing LLVM-IR transformation.
Oct 19 2022, 7:34 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D133568: [Flang][Driver]Add datalayout before doing LLVM-IR transformation.

Updates per review comments and local testing.

Oct 19 2022, 7:33 AM · Restricted Project, Restricted Project

Oct 11 2022

Leporacanthicus added a comment to D129156: Add -fpass-plugin option to Flang.

@MatsPetersson & @clementval , could you share you build command so that the failure can be reproduced before this re-lands?

I can't share the same command that I used, because it's some old CMAKE command that I no longer have in my history. But I tested this patch, and it works in the same tree that I was using it last week.

Oct 11 2022, 3:21 AM · Restricted Project, Restricted Project, Restricted Project

Oct 7 2022

Leporacanthicus accepted D130633: [flang][nfc] Relocate a few driver tests.

LGTM.

Oct 7 2022, 9:11 AM · Restricted Project, Restricted Project

Oct 6 2022

Leporacanthicus requested review of D135364: [flang] Add simplified version of minval.
Oct 6 2022, 7:10 AM · Restricted Project, Restricted Project

Oct 5 2022

Leporacanthicus updated the diff for D133568: [Flang][Driver]Add datalayout before doing LLVM-IR transformation.

Updates based on review comments:

  • Additional MLIR DataLayout.
  • Add check lines for datalayout in the MLIR and LLVM output
Oct 5 2022, 11:02 AM · Restricted Project, Restricted Project

Sep 14 2022

Leporacanthicus added inline comments to D133568: [Flang][Driver]Add datalayout before doing LLVM-IR transformation.
Sep 14 2022, 8:18 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D133859: [flang][driver]Fix broken PowerPC tests.
Sep 14 2022, 7:13 AM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D133820: [flang] Support multidimensional reductions in SimplifyIntrinsicsPass..

Again, thanks for the work here. It looks roughly like I had imagined [although I was kind of wishfully thinking that maybe we could just treat ND as 1D, just larger - at least for things where "ordering isn't important", such as sum or maxval]

Sep 14 2022, 5:22 AM · Restricted Project, Restricted Project
Leporacanthicus accepted D133818: [flang] Support more data types for reduction in SimplifyIntrinsicsPass..

Thanks for working on this!

Sep 14 2022, 4:05 AM · Restricted Project, Restricted Project

Sep 13 2022

Leporacanthicus added a reviewer for D133792: [flang][driver]Fix broken flang-new mlir test: kiranchandramohan.
Sep 13 2022, 11:04 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D133792: [flang][driver]Fix broken flang-new mlir test.
Sep 13 2022, 11:00 AM · Restricted Project, Restricted Project

Sep 9 2022

Leporacanthicus added a reviewer for D133568: [Flang][Driver]Add datalayout before doing LLVM-IR transformation: vzakhari.
Sep 9 2022, 4:04 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D133568: [Flang][Driver]Add datalayout before doing LLVM-IR transformation.
Sep 9 2022, 3:56 AM · Restricted Project, Restricted Project
Leporacanthicus accepted D131041: [Flang] Update build documentation.

LGTM

Sep 9 2022, 3:00 AM · Restricted Project, Restricted Project

Sep 2 2022

Leporacanthicus added a comment to D132652: [FLANG][NFC]Use RTNAME instead of hard-coding for simplify intrinsics.

LGTM, except for the buildbot failures.

Sep 2 2022, 3:47 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D132652: [FLANG][NFC]Use RTNAME instead of hard-coding for simplify intrinsics.

Rebase to latest llvm/main

Sep 2 2022, 3:34 AM · Restricted Project, Restricted Project

Aug 31 2022

Leporacanthicus added inline comments to D132588: [FLANG][NFCI]De-duplicate code in SimplifyIntrinsics.
Aug 31 2022, 12:44 PM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D132588: [FLANG][NFCI]De-duplicate code in SimplifyIntrinsics.

Added const to KindMapping argument.

Aug 31 2022, 12:41 PM · Restricted Project, Restricted Project
Leporacanthicus added inline comments to D132652: [FLANG][NFC]Use RTNAME instead of hard-coding for simplify intrinsics.
Aug 31 2022, 12:33 PM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D132652: [FLANG][NFC]Use RTNAME instead of hard-coding for simplify intrinsics.

Revew comment fixes:

  • Removed unused header file
  • Changed function names from RTName to Runtime to better reflect what they do.
Aug 31 2022, 12:15 PM · Restricted Project, Restricted Project
Leporacanthicus added inline comments to D132588: [FLANG][NFCI]De-duplicate code in SimplifyIntrinsics.
Aug 31 2022, 8:57 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D132588: [FLANG][NFCI]De-duplicate code in SimplifyIntrinsics.

Updates per review comments:

  • Fix typos
  • Use llvm::function_ref instead of std::function
Aug 31 2022, 8:24 AM · Restricted Project, Restricted Project

Aug 25 2022

Leporacanthicus added reviewers for D132652: [FLANG][NFC]Use RTNAME instead of hard-coding for simplify intrinsics: vzakhari, awarzynski, kiranchandramohan, clementval, DylanFleming-arm.
Aug 25 2022, 6:26 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D132652: [FLANG][NFC]Use RTNAME instead of hard-coding for simplify intrinsics.
Aug 25 2022, 6:21 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D132588: [FLANG][NFCI]De-duplicate code in SimplifyIntrinsics.

Updated comment for helper function

Aug 25 2022, 6:19 AM · Restricted Project, Restricted Project
Leporacanthicus added reviewers for D132588: [FLANG][NFCI]De-duplicate code in SimplifyIntrinsics: vzakhari, kiranchandramohan, clementval, awarzynski, DylanFleming-arm.
Aug 25 2022, 6:16 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D132567: [FLANG]Remove experimental flag from SUM simplification.

Trying again, patch seems to have got messed up.

Aug 25 2022, 1:50 AM · Restricted Project, Restricted Project

Aug 24 2022

Leporacanthicus added a comment to D132567: [FLANG]Remove experimental flag from SUM simplification.

I think my patch is messed up, however. It seems to have included my refactoring as well, which should be a separate patch.

Aug 24 2022, 1:36 PM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D132567: [FLANG]Remove experimental flag from SUM simplification.

Remove comment that was no longer valid

Aug 24 2022, 12:14 PM · Restricted Project, Restricted Project
Leporacanthicus requested review of D132588: [FLANG][NFCI]De-duplicate code in SimplifyIntrinsics.
Aug 24 2022, 12:13 PM · Restricted Project, Restricted Project
Leporacanthicus added inline comments to D132567: [FLANG]Remove experimental flag from SUM simplification.
Aug 24 2022, 11:18 AM · Restricted Project, Restricted Project
Leporacanthicus added reviewers for D132567: [FLANG]Remove experimental flag from SUM simplification: vzakhari, DylanFleming-arm, kiranchandramohan, awarzynski.
Aug 24 2022, 8:36 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D132567: [FLANG]Remove experimental flag from SUM simplification.
Aug 24 2022, 8:34 AM · Restricted Project, Restricted Project
Leporacanthicus added inline comments to D132234: [FLANG]Add maxval simplification support.
Aug 24 2022, 5:26 AM · Restricted Project, Restricted Project

Aug 22 2022

Leporacanthicus added inline comments to D132234: [FLANG]Add maxval simplification support.
Aug 22 2022, 12:10 PM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D132234: [FLANG]Add maxval simplification support.

Review updates:

  • Use different method to find a smallest value to start for MAXVAL
  • Tidy up some code in general.
  • Add descriptive comment to big function.
  • Pass loc around in a few places.
Aug 22 2022, 12:06 PM · Restricted Project, Restricted Project

Aug 19 2022

Leporacanthicus added reviewers for D132238: [Flang]Fix another way to crash SimplifyIntrinsics: kiranchandramohan, DylanFleming-arm, vzakhari.
Aug 19 2022, 8:38 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D132238: [Flang]Fix another way to crash SimplifyIntrinsics.
Aug 19 2022, 8:31 AM · Restricted Project, Restricted Project
Leporacanthicus added reviewers for D132234: [FLANG]Add maxval simplification support: kiranchandramohan, vzakhari.
Aug 19 2022, 7:53 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D132234: [FLANG]Add maxval simplification support.
Aug 19 2022, 7:44 AM · Restricted Project, Restricted Project

Aug 18 2022

Leporacanthicus accepted D132069: [flang] Enable SimplifyIntrinsics pass in driver..

LGTM! Thanks for the work on this!

Aug 18 2022, 3:38 AM · Restricted Project, Restricted Project

Aug 17 2022

Leporacanthicus added inline comments to D131912: [MLIR]Add support for Arith MAX & MIN operations.
Aug 17 2022, 11:18 AM · Restricted Project, Restricted Project
Leporacanthicus added a reviewer for D132046: [MLIR][NFC] Sort table of operations alphabetically: bondhugula.
Aug 17 2022, 11:12 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D132046: [MLIR][NFC] Sort table of operations alphabetically.
Aug 17 2022, 11:11 AM · Restricted Project, Restricted Project
Leporacanthicus added inline comments to D131912: [MLIR]Add support for Arith MAX & MIN operations.
Aug 17 2022, 9:48 AM · Restricted Project, Restricted Project

Aug 16 2022

Leporacanthicus accepted D131640: [flang] Control SUM simplification with a pass option..

LGTM. I do expect this to be short-lived [or at least for the SUM operations!]

Aug 16 2022, 1:04 PM · Restricted Project, Restricted Project
Leporacanthicus added inline comments to D131671: [flang]Avoid asking for operands when there are none.
Aug 16 2022, 1:00 PM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D131671: [flang]Avoid asking for operands when there are none.

Updated check for expected operation (always fir::ConvertOp) instead of
checking for number of operands. Assert to capture should number of operands
be zero.

Aug 16 2022, 12:58 PM · Restricted Project, Restricted Project

Aug 15 2022

Leporacanthicus added reviewers for D131912: [MLIR]Add support for Arith MAX & MIN operations: rriddle, mehdi_amini, kiranchandramohan.
Aug 15 2022, 11:33 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D131912: [MLIR]Add support for Arith MAX & MIN operations.
Aug 15 2022, 11:32 AM · Restricted Project, Restricted Project