- User Since
- Feb 5 2016, 9:41 AM (329 w, 2 h)
Update test to MLIR
Wed, May 25
Wed, May 18
Add assert for bounds back in, remove if-statment. This puts the code in
the new loop back to how the code was before the loop.
Replace if with assert, as it was in earlier code (before the loop was added)
Fri, May 13
Thu, May 12
Update for review comments
Wed, May 11
Tue, May 10
Apr 14 2022
Apr 8 2022
Apr 1 2022
Mar 30 2022
I have left my machine to compile that file over night, to see if it's a genuine hang or just "takes a very long time" - if it's not finished by tomorrow morning, I'm definitely calling it a hang. I will report back tomorrow on the result of that.
Mar 29 2022
We did some more digging and it looks like a Clang 13 issue. On AArch64, both Clang 12 and Clang 14 are fine. I believe that @Leporacanthicus was also able to reproduce this with Clang 13 on X86.
Jan 27 2022
Dec 8 2021
LGTM. Just one nit-pick, there's a few new tests that test some pretty specific things. Would be nice to have a line or three about what they actually test - e.g "Tests that destructor is not called until after OpenMP section has completed".
Nov 26 2021
Nov 23 2021
Nov 22 2021
Generally looks good to me. Just one nit-pick and one "I don't really understand how this actually produces the correct result" (may be that I'm just missing something!)
Nov 17 2021
Make simd_modifier a unit-attribute and fix formatting
Fix review comments
Nov 3 2021
As this is now squashed into D111051, this review is no longer required.
Squashed the "fixes" commit and the original commit
Nov 1 2021
Oct 26 2021
Update to match changes in dependent commit (+ rebase)
Oct 21 2021
Rebase to latest llvm/main
Oct 18 2021
Oct 14 2021
Looks OK to me, but please don't merge until someone else also approves.
Oct 13 2021
Oct 12 2021
Updating according to review comments
Oct 11 2021
Oct 4 2021
Trying to get two commits in one arcanist command - may not work
Sep 2 2021
Ah, this definitely would make "random" values for floating point values - in weird ways that are hard to understand!
Aug 24 2021
Looks like it's doing what's needed. Is there a follow-on patch to fix the fact that values isn't being passed to the DATE_AND_TIME subroutine?
Aug 17 2021
(Sorry, I thought I'd approved it yesterday, but clearly didn't click the submit button!)
Aug 13 2021
It would seem that your patch may have broken some builds:
Aug 5 2021
Jul 29 2021
Thanks for the updated patch, this seems to work for my simple use-case.
Jul 27 2021
Jul 26 2021
Sorry for the rather lengthy comment. I am not sure if I'm expecting the wrong thing, I'm doing something wrong, or this patch is incorrect, so I'll try to put as much information into this comment as I can.
Any suggestions, hints or similar would be welcome. I fully expect some of my workarounds and fixes to be called out as wrong - and I don't mean my global variable, which is clearly just a workaround for not understanding how to get the correct value out of where it is known.
Jul 21 2021
Jul 16 2021
Jul 13 2021
Jul 9 2021
Jun 17 2021
Some minor nit-picks, but nothing wrong - I tested this with some of my fortran code that I've been using for other testing, and it seems to work.
Jun 2 2021
May 26 2021
Removed wrong comment endings.
May 21 2021
@Meinersbur Is there anything else I need to do here?
May 14 2021
Remove the code that add in modifiers to the scheduling type,
as per review comments.
May 12 2021
Rebase and fixed comment style.
May 7 2021
Patch doesn't apply because it is relying on my previous patch. Doh!
May 6 2021
May 5 2021
Adding MLIR to LLVM-IR tests. The tests are very basic, just checking that
the correct runtime functions are called.
Apr 29 2021
Updates based on review comments:
- Fix style using PascalCase rather than camelCase.
- Add Doxygen comment for parameter.
- Change comment style for constants.
- Remove useless error output - there was no way to get to that error.
- Use llvm_unreachable instead of assert(0).
Apr 28 2021
Will do some minor fixes tomorrow, thanks for the feedback!
Apr 20 2021
Apr 13 2021
Apr 8 2021
Updates as per review comments:
Apr 1 2021
Updates requested in review:
- Avoid making temporary string
- Avoid British English in comment
- Be consistent and not mixing auto/named type in new tests
Mar 30 2021
Add testing for chunk size in dynamic work sharing loop test.
Mar 24 2021
Nice test, thanks for adding that!
Mar 23 2021
I'm wondering if it's possible to construct a test-case for this "shuffle it around" situation, so that some newbie (like me ...) doesn't break it accidentally when making changes?
Mar 22 2021
Fixes as per review comments
Mar 16 2021
Fixed various review comments.
Mar 15 2021
I'm going to upload the fixes once they compile, but it's getting late, so probably not until tomorrow morning.
Mar 12 2021
Mar 11 2021
Updated files based on selected review commets.
Fixed a few issues with the code-generation.
Added a basic test (similar to static workshare loop.
Feb 24 2021
Please note that this is not intended as the final commit, but rather a basis for asking some advice on how to move forward.