Page MenuHomePhabricator

Leporacanthicus (Mats Petersson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2016, 9:41 AM (270 w, 4 d)

Recent Activity

Yesterday

Leporacanthicus accepted D100309: [flang] Update the remaining tests to use the new driver when enabled.

LGTM.

Tue, Apr 13, 9:10 AM · Restricted Project, Restricted Project

Thu, Apr 8

Leporacanthicus added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Could you add the following to the unittest?

Builder.restoreIP(EndIP);
Builder.CreateRetVoid();
OMPBuilder.finalize();
EXPECT_FALSE(verifyModule(*M, &errs()));

I checks whether the IR is internally consistent.

Thu, Apr 8, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Updates as per review comments:

Thu, Apr 8, 3:04 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Apr 1

Leporacanthicus added inline comments to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Thu, Apr 1, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Updates requested in review:

  • Avoid making temporary string
  • Avoid British English in comment
  • Be consistent and not mixing auto/named type in new tests
Thu, Apr 1, 9:36 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 30

Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Add testing for chunk size in dynamic work sharing loop test.

Tue, Mar 30, 3:58 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 24

Leporacanthicus accepted D99198: [flang] Fix output buffering bug.

LGTM

Wed, Mar 24, 1:55 AM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D99198: [flang] Fix output buffering bug.

Nice test, thanks for adding that!

Wed, Mar 24, 12:13 AM · Restricted Project, Restricted Project

Tue, Mar 23

Leporacanthicus added a comment to D99198: [flang] Fix output buffering bug.

I'm wondering if it's possible to construct a test-case for this "shuffle it around" situation, so that some newbie (like me ...) doesn't break it accidentally when making changes?

It gets exercised pretty thoroughly by the I/O tests in the FCVS Fortran '77 suite, especially by codes doing direct and sequential I/O, and the flang/unittests/Runtime/external-io.cpp test really shook it out on the read path (and still passes with this change now that it's used on the write path). But it would be nice to be able to make the code work harder by e.g. using an artificially small buffer size. I've done that in the past during development (but obviously not for console output, sorry) but I'm not sure how it could be made part of a unit testing framework.

Tue, Mar 23, 12:16 PM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D99198: [flang] Fix output buffering bug.

I'm wondering if it's possible to construct a test-case for this "shuffle it around" situation, so that some newbie (like me ...) doesn't break it accidentally when making changes?

Tue, Mar 23, 10:40 AM · Restricted Project, Restricted Project

Mon, Mar 22

Leporacanthicus added inline comments to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Mon, Mar 22, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Fixes as per review comments

Mon, Mar 22, 11:31 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 16

Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Fixed various review comments.

Tue, Mar 16, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 15

Leporacanthicus added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

I'm going to upload the fixes once they compile, but it's getting late, so probably not until tomorrow morning.

Mon, Mar 15, 1:17 PM · Restricted Project, Restricted Project, Restricted Project

Mar 12 2021

Leporacanthicus added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Please note that this is not intended as the final commit, but rather a basis for asking some advice on how to move forward.

The main stumbling point, which may be my lack of understanding of what it's supposed to do: the CanonicalLoopInfo assumes that the the cond block has a CmpInst as the first instruction. In the dynamic, the corresponding block [in my understanding] starts with a call instruction to fetch the "next" set of data to process. This causes the assertOK to fail, hence it is commented out on line 1300 in the patch.

Mar 12 2021, 2:59 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2021

Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Updated files based on selected review commets.
Fixed a few issues with the code-generation.
Added a basic test (similar to static workshare loop.

Mar 11 2021, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2021

Leporacanthicus added inline comments to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Feb 24 2021, 10:52 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Please note that this is not intended as the final commit, but rather a basis for asking some advice on how to move forward.

Feb 24 2021, 8:26 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus requested review of D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Feb 24 2021, 8:18 AM · Restricted Project, Restricted Project, Restricted Project

Dec 23 2016

Leporacanthicus added inline comments to D28080: [Docs][OpenCL] Added OpenCL feature description to user manual..
Dec 23 2016, 1:47 PM

Feb 5 2016

Leporacanthicus added inline comments to D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0.
Feb 5 2016, 9:48 AM