- User Since
- Feb 5 2016, 9:41 AM (372 w, 2 d)
Fri, Mar 17
Rebase and fix conflicts
Thu, Mar 16
Wed, Mar 15
Tue, Mar 14
Wed, Mar 8
Updated to reflect review comments.
- Use different type for Walk functions.
- Use "unwrap" functions to get to types.
- Fix some debug output and related stuff.
- Some other minor changes, including clang-format fixups.
Fix copied comment to reflect the new content.
Updates based on review comments:
- Add tests.
- Enable on -O3
Mon, Mar 6
Fri, Mar 3
Thu, Mar 2
Update for rebase.
Tue, Feb 28
Feb 21 2023
Generally looks OK, just some minor nitpicks.
Feb 16 2023
Update to remove WIP
Rebased and updated help-message
Feb 13 2023
Aside from minor nit-picks, this looks good to me.
Feb 3 2023
Feb 2 2023
Updated patch, now works for 1D and 2D arrays.
Feb 1 2023
Jan 31 2023
Some progress, now identifying the correct loops a little better.
Jan 30 2023
LGTM, thanks for fixing!
Looks OK except for the test checking for the wrong "Not".
Jan 26 2023
I think this is good to go in now, subject to @vzakhari not finding anything else wrong.
Jan 20 2023
Looks OK in general, just some minor tidy-up suggestions.
Jan 13 2023
Rebase to latest llvm/main.
Added "move remaining loop into else branch" and related changes.
Jan 10 2023
This is work described here:
Jan 9 2023
Nov 3 2022
Try again, this time without requires line
Instead of requiring x86, remove target in tests. This will allow
testing on a wider range of targets, rather than a smaller range.
Update to correct typos.
Nov 2 2022
Update comments (clarify/reword, fix typos) and rebase.
Oct 19 2022
Updates per review comments and local testing.
Oct 11 2022
@MatsPetersson & @clementval , could you share you build command so that the failure can be reproduced before this re-lands?
I can't share the same command that I used, because it's some old CMAKE command that I no longer have in my history. But I tested this patch, and it works in the same tree that I was using it last week.
Oct 7 2022
Oct 6 2022
Oct 5 2022
Updates based on review comments:
- Additional MLIR DataLayout.
- Add check lines for datalayout in the MLIR and LLVM output
Sep 14 2022
Again, thanks for the work here. It looks roughly like I had imagined [although I was kind of wishfully thinking that maybe we could just treat ND as 1D, just larger - at least for things where "ordering isn't important", such as sum or maxval]
Thanks for working on this!
Sep 13 2022
Sep 9 2022
Sep 2 2022
Rebase to latest llvm/main
Aug 31 2022
Added const to KindMapping argument.
Revew comment fixes:
- Removed unused header file
- Changed function names from RTName to Runtime to better reflect what they do.
Updates per review comments:
- Fix typos
- Use llvm::function_ref instead of std::function
Aug 25 2022
Updated comment for helper function
Trying again, patch seems to have got messed up.
Aug 24 2022
I think my patch is messed up, however. It seems to have included my refactoring as well, which should be a separate patch.
Remove comment that was no longer valid
Aug 22 2022
- Use different method to find a smallest value to start for MAXVAL
- Tidy up some code in general.
- Add descriptive comment to big function.
- Pass loc around in a few places.
Aug 19 2022
Aug 18 2022
LGTM! Thanks for the work on this!
Aug 17 2022
Aug 16 2022
LGTM. I do expect this to be short-lived [or at least for the SUM operations!]
Updated check for expected operation (always fir::ConvertOp) instead of
checking for number of operands. Assert to capture should number of operands