Page MenuHomePhabricator

MehdiChinoune (مهدي شينون (Mehdi Chinoune))
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2021, 10:53 AM (15 w, 2 d)

Recent Activity

May 7 2021

MehdiChinoune added a comment to D101842: [flang][cmake] Enable the new driver by default.

Address PR comments

Thank you for taking a look @Meinersbur. It sounds that instead of updating LLVM_ENABLE_PROJECTS, it will be better to generate an error when Clang is missing. What do you think?

May 7 2021, 10:32 AM · Restricted Project, Restricted Project

Apr 20 2021

MehdiChinoune added a comment to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..

Could someone push this change p, please.

Do you have an email I can use for the commit author?

Apr 20 2021, 2:06 PM · Restricted Project, Restricted Project

Apr 15 2021

MehdiChinoune added a comment to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..

Could someone push this change p, please.

Apr 15 2021, 8:08 PM · Restricted Project, Restricted Project

Apr 14 2021

MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 7:19 AM · Restricted Project, Restricted Project
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 4:39 AM · Restricted Project, Restricted Project
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 3:24 AM · Restricted Project, Restricted Project
MehdiChinoune updated the diff for D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..

Update diff

Apr 14 2021, 3:21 AM · Restricted Project, Restricted Project
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 2:53 AM · Restricted Project, Restricted Project
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 2:03 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..

Sorry for the wait. Patch LGTM.

Would you like me to push it top main?

Apr 14 2021, 1:25 AM · Restricted Project, Restricted Project

Apr 13 2021

MehdiChinoune requested review of D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 13 2021, 9:40 PM · Restricted Project, Restricted Project

Apr 10 2021

MehdiChinoune added a comment to D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..

Ping

Apr 10 2021, 10:18 PM · Restricted Project, Restricted Project

Apr 4 2021

MehdiChinoune abandoned D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..
Apr 4 2021, 7:19 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..

Could you please update D96069 instead?

I lost access to my old account.

You can take control of the patch with your new account with the “Commandeer revision” action.

Apr 4 2021, 7:19 AM · Restricted Project, Restricted Project
MehdiChinoune updated the diff for D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..
Apr 4 2021, 7:17 AM · Restricted Project, Restricted Project
MehdiChinoune commandeered D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..
Apr 4 2021, 7:16 AM · Restricted Project, Restricted Project

Apr 3 2021

MehdiChinoune added a comment to D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..

Could you please update D96069 instead?

Apr 3 2021, 8:35 PM · Restricted Project, Restricted Project
MehdiChinoune requested review of D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..
Apr 3 2021, 4:03 AM · Restricted Project, Restricted Project

Apr 2 2021

MehdiChinoune accepted D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.
Apr 2 2021, 2:00 PM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

I don't see any other error for now.

Apr 2 2021, 1:51 PM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

It works

Apr 2 2021, 1:08 PM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

I get this error:

D:\dev\llvm-project\flang\runtime\reduction.cpp(95): error C2059: syntax error: 'template'
D:\dev\llvm-project\flang\runtime\reduction.cpp(404): note: see reference to function template instantiation 'signed char Fortran::runtime::GetTotalReduction<Fortran::common::TypeCategory::Integer,1,Fortran::runtime::IntegerSumAccumulator<int>>(const Fortran::runtime::Descriptor &,const char *,int,int,const Fortran::runtime::Descriptor *,ACCUMULATOR &&,const char *)' being compiled
        with
        [
            ACCUMULATOR=Fortran::runtime::IntegerSumAccumulator<int>
        ]

Could you fix it?

Apr 2 2021, 12:15 PM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

It would be better if you exclude int128 intrinsic functions introduced in D99764

Apr 2 2021, 11:33 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99666: [flang] Implement reductions in the runtime.

Other issues with MSVC:
1 - MSVC doesn't have __uint128 and __int128.
MSVC doesn't accept that portable Int128 type defined in uint128.h to be linked with a C function.
Maybe you should disable int128 intrinsic functions on the platforms where __unit128 and __int128 are not available

Apr 2 2021, 10:47 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99666: [flang] Implement reductions in the runtime.

This commit breaks Building on MSVC.

Apr 2 2021, 3:19 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99666: [flang] Implement reductions in the runtime.
Apr 2 2021, 3:09 AM · Restricted Project, Restricted Project