Page MenuHomePhabricator

MehdiChinoune (مهدي شينون (Mehdi Chinoune))
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2021, 10:53 AM (63 w, 1 d)

Recent Activity

Thu, May 19

MehdiChinoune added a comment to D125262: [flang][MSVC] Fix building with `/permissive-` flag.

LGTM

Thu, May 19, 7:52 PM · Restricted Project, Restricted Project

Fri, May 13

MehdiChinoune added a comment to D125262: [flang][MSVC] Fix building with `/permissive-` flag.

Please add a summary where you mention that CLOCK_REALTIME is POSIX defined and never available with msvc, even without /permissive-. The difference is that the template is never instantiated and the compiler ignores the undefined identifier.

Fri, May 13, 8:54 PM · Restricted Project, Restricted Project
MehdiChinoune updated the summary of D125262: [flang][MSVC] Fix building with `/permissive-` flag.
Fri, May 13, 8:50 PM · Restricted Project, Restricted Project

Wed, May 11

MehdiChinoune added a comment to D125262: [flang][MSVC] Fix building with `/permissive-` flag.

This is the error message:

[6795/8382] Building CXX object tools\flang\runtime\CMakeFiles\obj.FortranRuntime.dir\time-intrinsic.cpp.obj
FAILED: tools/flang/runtime/CMakeFiles/obj.FortranRuntime.dir/time-intrinsic.cpp.obj
sccache C:\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\cl.exe  /nologo /TP -DBUILD_EXAMPLES -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\flang\runtime -IC:\ws\w3\llvm-project\premerge-checks\flang\runtime -IC:\ws\w3\llvm-project\premerge-checks\flang\include -Itools\flang\include -Iinclude -IC:\ws\w3\llvm-project\premerge-checks\llvm\include -IC:\ws\w3\llvm-project\premerge-checks\llvm\..\mlir\include -Itools\mlir\include -Itools\clang\include -IC:\ws\w3\llvm-project\premerge-checks\llvm\..\clang\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2 -UNDEBUG -std:c++17  /EHs-c- /GR- /showIncludes /Fotools\flang\runtime\CMakeFiles\obj.FortranRuntime.dir\time-intrinsic.cpp.obj /Fdtools\flang\runtime\CMakeFiles\obj.FortranRuntime.dir\ /FS -c C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp
C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp(77): error C2065: 'CLOCK_REALTIME': undeclared identifier
C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp(77): error C3861: 'CLOCK_REALTIME': identifier not found
C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp(146): error C2065: 'CLOCK_REALTIME': undeclared identifier
C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp(146): error C3861: 'CLOCK_REALTIME': identifier not found

https://buildkite.com/llvm-project/premerge-checks/builds/92047#ae63959e-de4c-4cf0-a663-eeab39a06ce8/410-7338

Wed, May 11, 7:14 AM · Restricted Project, Restricted Project

Tue, May 10

MehdiChinoune added a comment to D125262: [flang][MSVC] Fix building with `/permissive-` flag.

Patch summary missing. What is failing with /permissive-?

Tue, May 10, 2:51 PM · Restricted Project, Restricted Project
MehdiChinoune added a reviewer for D125262: [flang][MSVC] Fix building with `/permissive-` flag: Meinersbur.
Tue, May 10, 5:10 AM · Restricted Project, Restricted Project

Mon, May 9

MehdiChinoune requested review of D125263: [CMake][MSVC] Use `/permissive-` as MSVC equivalent to `-pedantic`.
Mon, May 9, 12:40 PM · Restricted Project, Restricted Project
MehdiChinoune requested review of D125262: [flang][MSVC] Fix building with `/permissive-` flag.
Mon, May 9, 12:31 PM · Restricted Project, Restricted Project

Apr 7 2022

MehdiChinoune added a comment to D122523: [lldb] Fix building standalone LLDB on Windows..

@MehdiChinoune can you provide your preferred form of the git author line, Real Name <email@address>?

Apr 7 2022, 12:59 AM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

MehdiChinoune updated subscribers of D122523: [lldb] Fix building standalone LLDB on Windows..
Apr 6 2022, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Apr 3 2022

MehdiChinoune added a comment to D122523: [lldb] Fix building standalone LLDB on Windows..

Could someone push it for me, Please.

Apr 3 2022, 8:50 PM · Restricted Project, Restricted Project, Restricted Project

Mar 25 2022

MehdiChinoune requested review of D122523: [lldb] Fix building standalone LLDB on Windows..
Mar 25 2022, 11:20 PM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO: Restricted Project.

This commit make building standalone LLDB impossible on Windows. llvm/Config/config.h file is only generated at build-time and not get installed with llvm.
Please Fix it.

Mar 25 2022, 10:59 PM · Restricted Project, Restricted Project

Dec 13 2021

MehdiChinoune added inline comments to D115569: [flang] Use `GNUInstallDirs` to support custom installation dirs..
Dec 13 2021, 3:27 AM · Restricted Project, Restricted Project
MehdiChinoune added inline comments to D115569: [flang] Use `GNUInstallDirs` to support custom installation dirs..
Dec 13 2021, 3:23 AM · Restricted Project, Restricted Project

Nov 24 2021

MehdiChinoune added a comment to D114406: Add issue/PR templates to discourge issue/PR creation.
Nov 24 2021, 11:00 PM · Restricted Project

Sep 15 2021

MehdiChinoune added a project to D100897: [flang] Make 'team_number()' an intrinsic function: Restricted Project.
Sep 15 2021, 11:49 AM · Restricted Project, Restricted Project
MehdiChinoune added a project to D108057: [Flang] Add compiled python modules to .gitignore: Restricted Project.
Sep 15 2021, 11:48 AM · Restricted Project, Restricted Project
MehdiChinoune added a project to D109547: [flang] Add runtime interface for NUM_IMAGES: Restricted Project.
Sep 15 2021, 11:48 AM · Restricted Project
MehdiChinoune added a project to D108059: [flang] Make 'this_image()' an intrinsic function: Restricted Project.
Sep 15 2021, 11:46 AM · Restricted Project, Restricted Project

May 7 2021

MehdiChinoune added a comment to D101842: [flang][cmake] Enable the new driver by default.

Address PR comments

Thank you for taking a look @Meinersbur. It sounds that instead of updating LLVM_ENABLE_PROJECTS, it will be better to generate an error when Clang is missing. What do you think?

May 7 2021, 10:32 AM · Restricted Project, Restricted Project

Apr 20 2021

MehdiChinoune added a comment to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..

Could someone push this change p, please.

Do you have an email I can use for the commit author?

Apr 20 2021, 2:06 PM · Restricted Project, Restricted Project

Apr 15 2021

MehdiChinoune added a comment to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..

Could someone push this change p, please.

Apr 15 2021, 8:08 PM · Restricted Project, Restricted Project

Apr 14 2021

MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 7:19 AM · Restricted Project, Restricted Project
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 4:39 AM · Restricted Project, Restricted Project
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 3:24 AM · Restricted Project, Restricted Project
MehdiChinoune updated the diff for D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..

Update diff

Apr 14 2021, 3:21 AM · Restricted Project, Restricted Project
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 2:53 AM · Restricted Project, Restricted Project
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 2:03 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..

Sorry for the wait. Patch LGTM.

Would you like me to push it top main?

Apr 14 2021, 1:25 AM · Restricted Project, Restricted Project

Apr 13 2021

MehdiChinoune requested review of D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 13 2021, 9:40 PM · Restricted Project, Restricted Project

Apr 10 2021

MehdiChinoune added a comment to D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..

Ping

Apr 10 2021, 10:18 PM · Restricted Project, Restricted Project

Apr 4 2021

MehdiChinoune abandoned D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..
Apr 4 2021, 7:19 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..

Could you please update D96069 instead?

I lost access to my old account.

You can take control of the patch with your new account with the “Commandeer revision” action.

Apr 4 2021, 7:19 AM · Restricted Project, Restricted Project
MehdiChinoune updated the diff for D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..
Apr 4 2021, 7:17 AM · Restricted Project, Restricted Project
MehdiChinoune commandeered D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..
Apr 4 2021, 7:16 AM · Restricted Project, Restricted Project

Apr 3 2021

MehdiChinoune added a comment to D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..

Could you please update D96069 instead?

Apr 3 2021, 8:35 PM · Restricted Project, Restricted Project
MehdiChinoune requested review of D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..
Apr 3 2021, 4:03 AM · Restricted Project, Restricted Project

Apr 2 2021

MehdiChinoune accepted D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.
Apr 2 2021, 2:00 PM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

I don't see any other error for now.

Apr 2 2021, 1:51 PM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

It works

Apr 2 2021, 1:08 PM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

I get this error:

D:\dev\llvm-project\flang\runtime\reduction.cpp(95): error C2059: syntax error: 'template'
D:\dev\llvm-project\flang\runtime\reduction.cpp(404): note: see reference to function template instantiation 'signed char Fortran::runtime::GetTotalReduction<Fortran::common::TypeCategory::Integer,1,Fortran::runtime::IntegerSumAccumulator<int>>(const Fortran::runtime::Descriptor &,const char *,int,int,const Fortran::runtime::Descriptor *,ACCUMULATOR &&,const char *)' being compiled
        with
        [
            ACCUMULATOR=Fortran::runtime::IntegerSumAccumulator<int>
        ]

Could you fix it?

Apr 2 2021, 12:15 PM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

It would be better if you exclude int128 intrinsic functions introduced in D99764

Apr 2 2021, 11:33 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99666: [flang] Implement reductions in the runtime.

Other issues with MSVC:
1 - MSVC doesn't have __uint128 and __int128.
MSVC doesn't accept that portable Int128 type defined in uint128.h to be linked with a C function.
Maybe you should disable int128 intrinsic functions on the platforms where __unit128 and __int128 are not available

Apr 2 2021, 10:47 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99666: [flang] Implement reductions in the runtime.

This commit breaks Building on MSVC.

Apr 2 2021, 3:19 AM · Restricted Project, Restricted Project
MehdiChinoune added a comment to D99666: [flang] Implement reductions in the runtime.
Apr 2 2021, 3:09 AM · Restricted Project, Restricted Project