This is an archive of the discontinued LLVM Phabricator instance.

[Polly][CMake] Make PollyConfig.cmake relocatable like other projects'

Authored by Ericson2314 on Jan 3 2022, 1:20 PM.



This builds on D116521 to add this functionality to Polly without more copy-pasted code.

Diff Detail

Event Timeline

Ericson2314 created this revision.Jan 3 2022, 1:20 PM
Ericson2314 requested review of this revision.Jan 3 2022, 1:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2022, 1:20 PM
Ericson2314 added inline comments.Jan 3 2022, 8:31 PM

This duplicated the above so I just deleted it.

beanz accepted this revision.Jan 7 2022, 12:30 PM


This revision is now accepted and ready to land.Jan 7 2022, 12:30 PM

This is actually *not* working, CI reports. I haven't yet figured out why the same idiom that works everywhere else doesn't work here. Back to the drawing board.

Fix relatie path calculation issue in exports.

Instead reuse the same shared logic to get the path and do it that way.

Ericson2314 added inline comments.Jan 7 2022, 10:01 PM

This is the new bit, replacing the wold way of doing relative exports.

Someday, it would be nice to replace this the usual LLVMDistributionSupport methods, but that is a bigger change best left for later.

Ericson2314 added inline comments.Jan 13 2022, 9:27 PM

Not sure where @beanz is at, and this was a just a small addition to the approved part, so I am just going go forward with it.