This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Use `GNUInstallDirs` to support custom installation dirs.

Authored by Ericson2314 on Dec 10 2021, 7:15 PM.



Extracted from D99484. My new plan is to start from the outside and work

Diff Detail

Event Timeline

Ericson2314 created this revision.Dec 10 2021, 7:15 PM
Ericson2314 requested review of this revision.Dec 10 2021, 7:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2021, 7:15 PM
Ericson2314 added reviewers: compnerd, phosek.
Ericson2314 added inline comments.Dec 12 2021, 8:57 AM

I think a problem with D115544 was that AddLLVM was assuming GNUInstallDirs yet downstream packages didn't yet include it.

By starting with "leaf" packages I side-step this issue somewhat, but I am still putting these here defensively so that downstream projects that might include these aren't broken, and the precedent is set.

  1. Updating D115570: [lldb] Use GNUInstallDirs to support custom installation dirs. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

remove blank line we don't need to add

compnerd accepted this revision.Dec 21 2021, 4:11 PM
This revision is now accepted and ready to land.Dec 21 2021, 4:11 PM