Page MenuHomePhabricator

[mlir][core] Attribute vector
Needs ReviewPublic

Authored by Mogball on Nov 1 2021, 1:14 PM.

Details

Summary

PoC of using an attribute vector (and some other optimizations).

Diff Detail

Event Timeline

Mogball created this revision.Nov 1 2021, 1:14 PM
Herald added a reviewer: rriddle. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: jpienaar. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: sjarus. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Mogball requested review of this revision.Nov 1 2021, 1:14 PM
Mogball updated this revision to Diff 383872.Nov 1 2021, 1:34 PM

clang-format

Mogball updated this revision to Diff 384865.Nov 4 2021, 2:04 PM

Remove fallback subrange

ftynse added inline comments.Nov 5 2021, 2:38 AM
flang/include/flang/Optimizer/Builder/FIRBuilder.h
129

llvm::mlir:: namespace looks incorrect here

Mogball added inline comments.Nov 5 2021, 11:04 AM
flang/include/flang/Optimizer/Builder/FIRBuilder.h
129

This is just a PoC patch so that others (i.e. Chris) can test the performance on whatever benchmarks they have available. But, yeah, I should probably make sure flang compiles (some tests will still fail).

Mogball updated this revision to Diff 385137.Nov 5 2021, 11:32 AM

Fix flang build