Page MenuHomePhabricator

wrengr (wren romano)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 2 2021, 2:15 PM (41 w, 5 d)

Recent Activity

Yesterday

wrengr requested review of D126106: [mlir][sparse] Moving some functions around.
Fri, May 20, 4:44 PM · Restricted Project, Restricted Project
wrengr requested review of D126105: [mlir][sparse] Improving ExecutionEngine/SparseTensorUtils.h.
Fri, May 20, 4:38 PM · Restricted Project, Restricted Project

Thu, May 19

wrengr committed rGa9a19f5965a5: [mlir][sparse] Adding x-macros for OverheadType (authored by wrengr).
[mlir][sparse] Adding x-macros for OverheadType
Thu, May 19, 4:53 PM · Restricted Project, Restricted Project
wrengr closed D126026: [mlir][sparse] Adding x-macros for OverheadType.
Thu, May 19, 4:53 PM · Restricted Project, Restricted Project
wrengr added inline comments to D126019: [mlir][sparse] Simplifying closure.
Thu, May 19, 4:50 PM · Restricted Project, Restricted Project
wrengr added inline comments to D126026: [mlir][sparse] Adding x-macros for OverheadType.
Thu, May 19, 4:01 PM · Restricted Project, Restricted Project
wrengr updated the diff for D126026: [mlir][sparse] Adding x-macros for OverheadType.

Replacing stackoverflow links with direct references to the standard

Thu, May 19, 4:01 PM · Restricted Project, Restricted Project
wrengr requested review of D126026: [mlir][sparse] Adding x-macros for OverheadType.
Thu, May 19, 3:32 PM · Restricted Project, Restricted Project
wrengr committed rG774674ce9abb: [mlir][sparse] Factored out a "FATAL" macro for unrecoverable assertion failure (authored by wrengr).
[mlir][sparse] Factored out a "FATAL" macro for unrecoverable assertion failure
Thu, May 19, 3:26 PM · Restricted Project, Restricted Project
wrengr closed D126022: [mlir][sparse] Factored out a "FATAL" macro for unrecoverable assertion failure.
Thu, May 19, 3:26 PM · Restricted Project, Restricted Project
wrengr committed rGaff9c89fabb3: [mlir][sparse] Simplifying closure (authored by wrengr).
[mlir][sparse] Simplifying closure
Thu, May 19, 3:16 PM · Restricted Project, Restricted Project
wrengr closed D126019: [mlir][sparse] Simplifying closure.
Thu, May 19, 3:15 PM · Restricted Project, Restricted Project
wrengr committed rGfa6aed2abd50: [mlir][sparse] Using the name "dimSizes" more consistently (authored by wrengr).
[mlir][sparse] Using the name "dimSizes" more consistently
Thu, May 19, 3:13 PM · Restricted Project, Restricted Project
wrengr closed D126016: [mlir][sparse] Using the name "dimSizes" more consistently.
Thu, May 19, 3:12 PM · Restricted Project, Restricted Project
wrengr added inline comments to D126022: [mlir][sparse] Factored out a "FATAL" macro for unrecoverable assertion failure.
Thu, May 19, 3:11 PM · Restricted Project, Restricted Project
wrengr requested review of D126022: [mlir][sparse] Factored out a "FATAL" macro for unrecoverable assertion failure.
Thu, May 19, 3:02 PM · Restricted Project, Restricted Project
wrengr requested review of D126019: [mlir][sparse] Simplifying closure.
Thu, May 19, 2:05 PM · Restricted Project, Restricted Project
wrengr requested review of D126016: [mlir][sparse] Using the name "dimSizes" more consistently.
Thu, May 19, 1:48 PM · Restricted Project, Restricted Project
wrengr accepted D126007: [mlir][sparse] fix unsigned comparison bug in assert.
Thu, May 19, 1:24 PM · Restricted Project, Restricted Project

Mon, May 16

wrengr committed rGbfadd13df474: [mlir][sparse] Moved _mlir_ciface_newSparseTensor closer to its macros (authored by wrengr).
[mlir][sparse] Moved _mlir_ciface_newSparseTensor closer to its macros
Mon, May 16, 5:53 PM · Restricted Project, Restricted Project
wrengr closed D125432: [mlir][sparse] Moved _mlir_ciface_newSparseTensor closer to its macros.
Mon, May 16, 5:53 PM · Restricted Project, Restricted Project
wrengr updated the diff for D125432: [mlir][sparse] Moved _mlir_ciface_newSparseTensor closer to its macros.

correcting a usage of tensor instead of coo

Mon, May 16, 5:05 PM · Restricted Project, Restricted Project
wrengr updated the diff for D125432: [mlir][sparse] Moved _mlir_ciface_newSparseTensor closer to its macros.

rebasing

Mon, May 16, 4:46 PM · Restricted Project, Restricted Project
wrengr committed rG1313f5d3071c: [mlir][sparse] Restyling macros in the runtime library (authored by wrengr).
[mlir][sparse] Restyling macros in the runtime library
Mon, May 16, 4:44 PM · Restricted Project, Restricted Project
wrengr closed D125431: [mlir][sparse] Restyling macros in the runtime library.
Mon, May 16, 4:43 PM · Restricted Project, Restricted Project
wrengr updated the diff for D125431: [mlir][sparse] Restyling macros in the runtime library.

rerunning git-clang-format

Mon, May 16, 3:52 PM · Restricted Project, Restricted Project
wrengr committed rG769444201153: [mlir][sparse] Adding "final" keyword wherever appropriate (authored by wrengr).
[mlir][sparse] Adding "final" keyword wherever appropriate
Mon, May 16, 3:44 PM · Restricted Project, Restricted Project
wrengr closed D125428: [mlir][sparse] Adding "final" keyword wherever appropriate.
Mon, May 16, 3:43 PM · Restricted Project, Restricted Project
wrengr committed rG8cb332406c09: [mlir][sparse] Enhancing sparse=>sparse conversion. (authored by wrengr).
[mlir][sparse] Enhancing sparse=>sparse conversion.
Mon, May 16, 3:42 PM · Restricted Project, Restricted Project
wrengr closed D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..
Mon, May 16, 3:42 PM · Restricted Project, Restricted Project
wrengr updated the diff for D125431: [mlir][sparse] Restyling macros in the runtime library.

rebasing for D125596

Mon, May 16, 3:14 PM · Restricted Project, Restricted Project
wrengr updated the diff for D125428: [mlir][sparse] Adding "final" keyword wherever appropriate.

Rebasing for latest dependency (D122061 at diff 429856 2022-05-16T14:33)

Mon, May 16, 2:39 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

Rebasing for D125596

Mon, May 16, 2:33 PM · Restricted Project, Restricted Project

Thu, May 12

wrengr committed rG753fe330c1d6: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage (authored by wrengr).
[mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage
Thu, May 12, 5:06 PM · Restricted Project, Restricted Project
wrengr closed D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.
Thu, May 12, 5:06 PM · Restricted Project, Restricted Project
wrengr updated the diff for D125432: [mlir][sparse] Moved _mlir_ciface_newSparseTensor closer to its macros.

(rebasing for dependencies having rerun git-clang-format)

Thu, May 12, 11:26 AM · Restricted Project, Restricted Project
wrengr updated the diff for D125431: [mlir][sparse] Restyling macros in the runtime library.

(rebasing for dependencies having rerun git-clang-format)

Thu, May 12, 11:25 AM · Restricted Project, Restricted Project

Wed, May 11

wrengr requested review of D125432: [mlir][sparse] Moved _mlir_ciface_newSparseTensor closer to its macros.
Wed, May 11, 4:41 PM · Restricted Project, Restricted Project
wrengr requested review of D125431: [mlir][sparse] Restyling macros in the runtime library.
Wed, May 11, 4:34 PM · Restricted Project, Restricted Project
wrengr requested review of D125428: [mlir][sparse] Adding "final" keyword wherever appropriate.
Wed, May 11, 4:11 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

Rerunning git-clang-format

Wed, May 11, 4:05 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Rerunning git-clang-format

Wed, May 11, 4:00 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

(Previous attempt didn't work, so fixing some things manually)

Wed, May 11, 2:02 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

(attempting to get the clang-formatter to run again)

Wed, May 11, 1:59 PM · Restricted Project, Restricted Project
wrengr added a comment to D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

Arg! It looks like when I installed the github version of Arcanist to avoid the https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1838310.html bug with Debian's version, the new version isn't automatically applying the formatting script :( So please bear with the overly-long lines for now

Wed, May 11, 1:28 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

Rebasing for the latest version of D122060 (2022-05-11T13:09)

Wed, May 11, 1:25 PM · Restricted Project, Restricted Project
wrengr added inline comments to D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.
Wed, May 11, 1:12 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Refactoring to minimize overhead (namely splitting the enumerator class up so that we can avoid the cost of virtual-method calls within the loop-nest). Current benchmarks indicate this differential has no statistically significant difference in cpu time compared to the baseline; or on occasion is somewhat faster than the baseline.

Wed, May 11, 1:09 PM · Restricted Project, Restricted Project

Fri, May 6

wrengr added a comment to D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

After banging away at things, I seem to have come up with a version that has -4.82~-6.79% slowdown (i.e., 5~7% speedup). I need to check a few more things to make sure these results are actually valid, then I'll upload the new version.

Fri, May 6, 6:15 PM · Restricted Project, Restricted Project
wrengr added a comment to D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Unfortunately the benchmarks have been... annoying. I finished writing them up and ran them at the end of week last week, and they showed <1% slowdown. I was going to post a comment to that effect on monday, but I wanted to rerun them just to be sure— and even though I hadn't touched the code (neither for this CL, nor for the benchmark itself, nor rebasing for the recent upstream changes) suddenly it was showing 2~15% slowdown. Which has undermined my belief in the credibility of the benchmarks. So this week I've been trying to figure out how to improve the reliability of the benchmarks, as well as trying to track down where the slowdown is coming from (assuming it's not spurious).

Fri, May 6, 12:28 PM · Restricted Project, Restricted Project

Apr 13 2022

wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

rebasing to fix spurious build failure

Apr 13 2022, 7:07 PM · Restricted Project, Restricted Project
wrengr added inline comments to D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.
Apr 13 2022, 5:40 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Removed the intermediate class EnumerableSparseTensorStorage<V>.

Apr 13 2022, 5:39 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

rebase

Apr 13 2022, 3:37 PM · Restricted Project, Restricted Project
wrengr updated the summary of D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..
Apr 13 2022, 3:36 PM · Restricted Project, Restricted Project
wrengr abandoned D122936: [mlir][sparse] Moved the ElementConsumer typedef to a "type alias".

Rolled into D122060

Apr 13 2022, 3:09 PM · Restricted Project, Restricted Project
wrengr added inline comments to D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.
Apr 13 2022, 3:09 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Addressing comments, fixing an issue about "slicing", and incorporating D122936

Apr 13 2022, 3:08 PM · Restricted Project, Restricted Project

Apr 8 2022

wrengr added inline comments to D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.
Apr 8 2022, 11:51 AM · Restricted Project, Restricted Project
wrengr committed rG8d8b566f0c66: [mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base (authored by wrengr).
[mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base
Apr 8 2022, 11:44 AM · Restricted Project, Restricted Project
wrengr closed D122928: [mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base.
Apr 8 2022, 11:44 AM · Restricted Project, Restricted Project

Apr 6 2022

wrengr updated the diff for D122928: [mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base.

Using checkedMul in finalizeSegment, now that D123166 renders it potentially unsafe.

Apr 6 2022, 6:09 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

Rebasing for D123166. Also removing a bunch of inline keywords, per MLIR style-guide.

Apr 6 2022, 5:44 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122936: [mlir][sparse] Moved the ElementConsumer typedef to a "type alias".

No local changes, but rebasing over newest version of parent D122060 for the sake of child D122061

Apr 6 2022, 5:33 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Rebasing for D123166. Also removing a bunch of inline keywords, per MLIR style-guide.

Apr 6 2022, 5:29 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122928: [mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base.

Rebasing for D123166. Also removing a bunch of inline keywords, per MLIR style-guide.

Apr 6 2022, 5:01 PM · Restricted Project, Restricted Project
wrengr added inline comments to D122928: [mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base.
Apr 6 2022, 4:13 PM · Restricted Project, Restricted Project
wrengr accepted D123253: [mlir][sparse] replace stack-based access pattern with dyn-alloc.

Modulo my comments, lgtm

Apr 6 2022, 4:10 PM · Restricted Project, Restricted Project
wrengr added a comment to D123253: [mlir][sparse] replace stack-based access pattern with dyn-alloc.

I'll have to take a closer look at the new test, but otherwise everything lgtm

Apr 6 2022, 4:07 PM · Restricted Project, Restricted Project

Apr 4 2022

wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

rebase

Apr 4 2022, 7:24 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122936: [mlir][sparse] Moved the ElementConsumer typedef to a "type alias".

rebase

Apr 4 2022, 7:22 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

rebase

Apr 4 2022, 7:19 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122928: [mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base.

rebase

Apr 4 2022, 7:15 PM · Restricted Project, Restricted Project
wrengr committed rG72ec2f76396f: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex` (authored by wrengr).
[mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`
Apr 4 2022, 7:12 PM · Restricted Project, Restricted Project
wrengr closed D122625: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`.
Apr 4 2022, 7:11 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122625: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`.

rebase

Apr 4 2022, 5:41 PM · Restricted Project, Restricted Project
wrengr updated the summary of D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..
Apr 4 2022, 5:21 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

rebase

Apr 4 2022, 5:20 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122936: [mlir][sparse] Moved the ElementConsumer typedef to a "type alias".

rebase

Apr 4 2022, 5:19 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

rebase

Apr 4 2022, 5:18 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122928: [mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base.

rebase

Apr 4 2022, 5:18 PM · Restricted Project, Restricted Project
wrengr added inline comments to D122625: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`.
Apr 4 2022, 4:38 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122625: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`.

Re-adjusting the return value of appendIndex.

Apr 4 2022, 4:38 PM · Restricted Project, Restricted Project
wrengr added inline comments to D122625: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`.
Apr 4 2022, 4:12 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122625: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`.

addressing comments

Apr 4 2022, 4:12 PM · Restricted Project, Restricted Project
wrengr added inline comments to D122625: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`.
Apr 4 2022, 2:04 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122625: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`.

Addressing comments

Apr 4 2022, 2:04 PM · Restricted Project, Restricted Project
wrengr added inline comments to D122934: [mlir][sparse] Simplifying code in expInsert.
Apr 4 2022, 12:58 PM · Restricted Project, Restricted Project
wrengr committed rG3bf2ba3b9a58: [mlir][sparse] Simplifying code in expInsert (authored by wrengr).
[mlir][sparse] Simplifying code in expInsert
Apr 4 2022, 12:54 PM · Restricted Project, Restricted Project
wrengr closed D122934: [mlir][sparse] Simplifying code in expInsert.
Apr 4 2022, 12:54 PM · Restricted Project, Restricted Project

Apr 1 2022

wrengr added inline comments to D122625: [mlir][sparse] Factoring out `finalizeSegment` and (generic) `appendIndex`.
Apr 1 2022, 7:40 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..

Lots of reorganization, subsequent to all the recent changes in the parent revisions.

Apr 1 2022, 4:58 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Cleaning up how EnumerableSparseTensorStorage delegates to constructors of its base class.

Apr 1 2022, 3:29 PM · Restricted Project, Restricted Project
wrengr requested review of D122936: [mlir][sparse] Moved the ElementConsumer typedef to a "type alias".
Apr 1 2022, 1:41 PM · Restricted Project, Restricted Project
wrengr requested review of D122934: [mlir][sparse] Simplifying code in expInsert.
Apr 1 2022, 12:52 PM · Restricted Project, Restricted Project
wrengr updated the summary of D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.
Apr 1 2022, 12:47 PM · Restricted Project, Restricted Project
wrengr added inline comments to D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.
Apr 1 2022, 12:46 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Factored out D122928 to address the request for reorganization

Apr 1 2022, 12:46 PM · Restricted Project, Restricted Project
wrengr updated the diff for D122928: [mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base.

re-adding todo lost when splitting the diff

Apr 1 2022, 12:02 PM · Restricted Project, Restricted Project
wrengr requested review of D122928: [mlir][sparse] Moving <P,I,V>-invariant parts of SparseTensorStorage to base.
Apr 1 2022, 11:55 AM · Restricted Project, Restricted Project