Page MenuHomePhabricator
People wrengr

wrengr (wren romano)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 2 2021, 2:15 PM (86 w, 5 d)

Recent Activity
View All

Thu, Mar 30

wrengr committed rG962484aeca0c: [mlir][sparse] Correcting some terminology / naming-scheme errors. (authored by wrengr).
[mlir][sparse] Correcting some terminology / naming-scheme errors.
Thu, Mar 30, 6:26 PM · Restricted Project, Restricted Project
wrengr closed D147291: [mlir][sparse] Correcting some terminology / naming-scheme errors..
Thu, Mar 30, 6:26 PM · Restricted Project, Restricted Project
wrengr requested review of D147291: [mlir][sparse] Correcting some terminology / naming-scheme errors..
Thu, Mar 30, 6:22 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Thu, Mar 30, 3:44 PM · Restricted Project, Restricted Project
wrengr accepted D147272: [mlir][sparse] Fix a problem in handling data type conversion..
Thu, Mar 30, 2:31 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Thu, Mar 30, 12:55 PM · Restricted Project, Restricted Project
wrengr committed rGf2696e469a5c: [mlir][sparse] Cleaning up some usage of SparseTensorType (authored by wrengr).
[mlir][sparse] Cleaning up some usage of SparseTensorType
Thu, Mar 30, 12:00 PM · Restricted Project, Restricted Project
wrengr closed D147196: [mlir][sparse] Cleaning up some usage of SparseTensorType.
Thu, Mar 30, 12:00 PM · Restricted Project, Restricted Project

Wed, Mar 29

wrengr requested review of D147196: [mlir][sparse] Cleaning up some usage of SparseTensorType.
Wed, Mar 29, 8:25 PM · Restricted Project, Restricted Project
wrengr accepted D147192: [mlir][sparse] avoid creating temporary unordered COO buffer when reshape sparse tensor..

(Assuming my previous comment is implemented)

Wed, Mar 29, 6:21 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147192: [mlir][sparse] avoid creating temporary unordered COO buffer when reshape sparse tensor..
Wed, Mar 29, 6:12 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147192: [mlir][sparse] avoid creating temporary unordered COO buffer when reshape sparse tensor..
Wed, Mar 29, 6:06 PM · Restricted Project, Restricted Project
wrengr committed rG46a384dfbe11: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId… (authored by wrengr).
[mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId…
Wed, Mar 29, 6:02 PM · Restricted Project, Restricted Project
wrengr closed D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.
Wed, Mar 29, 6:02 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146693: [mlir][sparse] Introducing newtypes for TensorId, LoopId, TensorLoopId.

rebasing for the postponement splitting of D146684

Wed, Mar 29, 4:47 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146688: [mlir][sparse] Simplifying Merger::expContainsTensor.

rebasing for the postponement splitting of D146684

Wed, Mar 29, 4:46 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146693: [mlir][sparse] Introducing newtypes for TensorId, LoopId, TensorLoopId.

rebasing for the postponement splitting of D146684

Wed, Mar 29, 4:34 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146691: [mlir][sparse] Introducing iterators for TensorId, LoopId, TensorLoopId.

rebasing for the postponement splitting of D146684

Wed, Mar 29, 4:33 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146690: [mlir][sparse] Introducing newtypes for ExprId, LatPointId, LatSetId.

Postponing the migration of TensorId, LoopId, TensorLoopId into MergerNewtypes.h until D146691 (and D146693)

Wed, Mar 29, 4:32 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.

Postponing the introduction of MergerNewtypes.h until D146690 (and D146691, D146693)

Wed, Mar 29, 4:31 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Wed, Mar 29, 3:21 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Wed, Mar 29, 3:04 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Wed, Mar 29, 1:27 PM · Restricted Project, Restricted Project
wrengr added inline comments to D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.
Wed, Mar 29, 12:17 PM · Restricted Project, Restricted Project

Tue, Mar 28

wrengr added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Tue, Mar 28, 6:11 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Tue, Mar 28, 5:30 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Tue, Mar 28, 5:03 PM · Restricted Project, Restricted Project
wrengr committed rG0ceec3ebfcf3: [mlir][sparse] Fixing -Wignored-reference-qualifiers in MergerTest.cpp (authored by wrengr).
[mlir][sparse] Fixing -Wignored-reference-qualifiers in MergerTest.cpp
Tue, Mar 28, 4:33 PM · Restricted Project, Restricted Project
wrengr closed D147090: [mlir][sparse] Fixing -Wignored-reference-qualifiers in MergerTest.cpp.
Tue, Mar 28, 4:33 PM · Restricted Project, Restricted Project
wrengr updated the diff for D147090: [mlir][sparse] Fixing -Wignored-reference-qualifiers in MergerTest.cpp.

rebase

Tue, Mar 28, 4:33 PM · Restricted Project, Restricted Project
wrengr added a comment to D147011: [mlir][sparse] Replace Element with ElementId for sorting..

Nit: in the CL summary it should be "Previously, we represented a"

Tue, Mar 28, 4:30 PM · Restricted Project, Restricted Project
wrengr requested review of D147090: [mlir][sparse] Fixing -Wignored-reference-qualifiers in MergerTest.cpp.
Tue, Mar 28, 2:48 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147074: [mlir][sparse] convert a sparse tensor slice to sparse tensor correctly..
Tue, Mar 28, 1:01 PM · Restricted Project, Restricted Project
wrengr committed rG164b918d7377: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test (authored by wrengr).
[mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test
Tue, Mar 28, 11:26 AM · Restricted Project, Restricted Project
wrengr closed D146561: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test.
Tue, Mar 28, 11:25 AM · Restricted Project, Restricted Project

Mon, Mar 27

wrengr accepted D147014: [mlir][sparse] rephrase the documentation for sparse compiler create-sparse-deallocs option..
Mon, Mar 27, 4:57 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147014: [mlir][sparse] rephrase the documentation for sparse compiler create-sparse-deallocs option..
Mon, Mar 27, 4:49 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147010: [mlir][sparse] add create-sparse-deallocs options to match the create-deallocs in BufferizationOption..
Mon, Mar 27, 4:20 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147010: [mlir][sparse] add create-sparse-deallocs options to match the create-deallocs in BufferizationOption..
Mon, Mar 27, 4:16 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147010: [mlir][sparse] add create-sparse-deallocs options to match the create-deallocs in BufferizationOption..
Mon, Mar 27, 4:02 PM · Restricted Project, Restricted Project
wrengr added inline comments to D147010: [mlir][sparse] add create-sparse-deallocs options to match the create-deallocs in BufferizationOption..
Mon, Mar 27, 4:00 PM · Restricted Project, Restricted Project

Fri, Mar 24

wrengr added inline comments to D142930: [mlir][sparse] extend loop emitter to emit slice driven loops.
Fri, Mar 24, 7:02 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146691: [mlir][sparse] Introducing iterators for TensorId, LoopId, TensorLoopId.

rebase

Fri, Mar 24, 7:00 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146690: [mlir][sparse] Introducing newtypes for ExprId, LatPointId, LatSetId.

Addressing the -Wmismatched-tags warnings on Debian.

Fri, Mar 24, 6:57 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146691: [mlir][sparse] Introducing iterators for TensorId, LoopId, TensorLoopId.

rebase

Fri, Mar 24, 6:51 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146690: [mlir][sparse] Introducing newtypes for ExprId, LatPointId, LatSetId.

rebase

Fri, Mar 24, 6:16 PM · Restricted Project, Restricted Project
wrengr added inline comments to D142930: [mlir][sparse] extend loop emitter to emit slice driven loops.
Fri, Mar 24, 6:15 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146688: [mlir][sparse] Simplifying Merger::expContainsTensor.

rebase

Fri, Mar 24, 4:21 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.

rebase

Fri, Mar 24, 4:04 PM · Restricted Project, Restricted Project
wrengr committed rG755285f1e99e: [mlir][sparse] Factoring out LoopEmitter::isValidLevel (authored by wrengr).
[mlir][sparse] Factoring out LoopEmitter::isValidLevel
Fri, Mar 24, 3:52 PM · Restricted Project, Restricted Project
wrengr closed D146676: [mlir][sparse] Factoring out LoopEmitter::isValidLevel.
Fri, Mar 24, 3:52 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146561: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test.

rebase

Fri, Mar 24, 3:49 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146676: [mlir][sparse] Factoring out LoopEmitter::isValidLevel.

rebase

Fri, Mar 24, 3:27 PM · Restricted Project, Restricted Project
wrengr committed rG74c54206d7ab: [mlir][sparse] moving kInvalidId into "detail" namespace (authored by wrengr).
[mlir][sparse] moving kInvalidId into "detail" namespace
Fri, Mar 24, 3:16 PM · Restricted Project, Restricted Project
wrengr closed D146674: [mlir][sparse] moving kInvalidId into "detail" namespace.
Fri, Mar 24, 3:15 PM · Restricted Project, Restricted Project
wrengr committed rG0280681b6d2a: [mlir][sparse] Updating TensorExp ctor to catch unknown TensorExp::Kind (authored by wrengr).
[mlir][sparse] Updating TensorExp ctor to catch unknown TensorExp::Kind
Fri, Mar 24, 3:08 PM · Restricted Project, Restricted Project
wrengr closed D146673: [mlir][sparse] Updating TensorExp ctor to catch unknown TensorExp::Kind.
Fri, Mar 24, 3:08 PM · Restricted Project, Restricted Project
wrengr committed rGb3379538e8bd: [mlir][sparse] Misc cleanup in Merger.h (authored by wrengr).
[mlir][sparse] Misc cleanup in Merger.h
Fri, Mar 24, 3:06 PM · Restricted Project, Restricted Project
wrengr closed D146562: [mlir][sparse] Misc cleanup in Merger.h.
Fri, Mar 24, 3:06 PM · Restricted Project, Restricted Project
wrengr committed rG7c7c10a0233f: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const (authored by wrengr).
[mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const
Fri, Mar 24, 2:49 PM · Restricted Project, Restricted Project
wrengr closed D146083: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const.
Fri, Mar 24, 2:48 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146674: [mlir][sparse] moving kInvalidId into "detail" namespace.

rebase

Fri, Mar 24, 2:46 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146673: [mlir][sparse] Updating TensorExp ctor to catch unknown TensorExp::Kind.

rebase

Fri, Mar 24, 2:37 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146562: [mlir][sparse] Misc cleanup in Merger.h.

rebase

Fri, Mar 24, 2:37 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146083: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const.

rebase

Fri, Mar 24, 2:18 PM · Restricted Project, Restricted Project

Wed, Mar 22

wrengr updated the diff for D146693: [mlir][sparse] Introducing newtypes for TensorId, LoopId, TensorLoopId.

git-clang-format

Wed, Mar 22, 10:57 PM · Restricted Project, Restricted Project
wrengr requested review of D146693: [mlir][sparse] Introducing newtypes for TensorId, LoopId, TensorLoopId.
Wed, Mar 22, 10:55 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146691: [mlir][sparse] Introducing iterators for TensorId, LoopId, TensorLoopId.

git-clang-format

Wed, Mar 22, 10:45 PM · Restricted Project, Restricted Project
wrengr requested review of D146691: [mlir][sparse] Introducing iterators for TensorId, LoopId, TensorLoopId.
Wed, Mar 22, 10:40 PM · Restricted Project, Restricted Project
wrengr requested review of D146690: [mlir][sparse] Introducing newtypes for ExprId, LatPointId, LatSetId.
Wed, Mar 22, 10:26 PM · Restricted Project, Restricted Project
wrengr requested review of D146688: [mlir][sparse] Simplifying Merger::expContainsTensor.
Wed, Mar 22, 10:09 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146676: [mlir][sparse] Factoring out LoopEmitter::isValidLevel.

rebase

Wed, Mar 22, 10:07 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146674: [mlir][sparse] moving kInvalidId into "detail" namespace.

rebase

Wed, Mar 22, 10:03 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.

rebase & git-clang-format

Wed, Mar 22, 9:56 PM · Restricted Project, Restricted Project
wrengr updated the summary of D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.
Wed, Mar 22, 9:55 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146561: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test.

rebase

Wed, Mar 22, 9:53 PM · Restricted Project, Restricted Project
wrengr updated the summary of D146561: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test.
Wed, Mar 22, 9:47 PM · Restricted Project, Restricted Project
wrengr updated the summary of D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.
Wed, Mar 22, 9:34 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146676: [mlir][sparse] Factoring out LoopEmitter::isValidLevel.

arc diff git merge-base HEAD origin --update D146676

Wed, Mar 22, 9:29 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146674: [mlir][sparse] moving kInvalidId into "detail" namespace.

arc diff git merge-base HEAD origin --update D146674

Wed, Mar 22, 9:28 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146676: [mlir][sparse] Factoring out LoopEmitter::isValidLevel.

rebase

Wed, Mar 22, 9:26 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146674: [mlir][sparse] moving kInvalidId into "detail" namespace.

rebase

Wed, Mar 22, 9:24 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146673: [mlir][sparse] Updating TensorExp ctor to catch unknown TensorExp::Kind.

rebase

Wed, Mar 22, 9:23 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146562: [mlir][sparse] Misc cleanup in Merger.h.

rebase, and removing D146561 as a dependency

Wed, Mar 22, 9:21 PM · Restricted Project, Restricted Project
wrengr updated the summary of D146562: [mlir][sparse] Misc cleanup in Merger.h.
Wed, Mar 22, 9:17 PM · Restricted Project, Restricted Project
wrengr requested review of D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.
Wed, Mar 22, 8:48 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146561: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test.

rebase

Wed, Mar 22, 8:30 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146083: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const.

rebase

Wed, Mar 22, 8:25 PM · Restricted Project, Restricted Project
wrengr added inline comments to D146674: [mlir][sparse] moving kInvalidId into "detail" namespace.
Wed, Mar 22, 6:41 PM · Restricted Project, Restricted Project
wrengr requested review of D146676: [mlir][sparse] Factoring out LoopEmitter::isValidLevel.
Wed, Mar 22, 5:14 PM · Restricted Project, Restricted Project
wrengr requested review of D146674: [mlir][sparse] moving kInvalidId into "detail" namespace.
Wed, Mar 22, 5:13 PM · Restricted Project, Restricted Project
wrengr requested review of D146673: [mlir][sparse] Updating TensorExp ctor to catch unknown TensorExp::Kind.
Wed, Mar 22, 5:09 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146562: [mlir][sparse] Misc cleanup in Merger.h.

rebase

Wed, Mar 22, 5:08 PM · Restricted Project, Restricted Project
wrengr updated the diff for D146083: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const.

Addressing nits, and rebasing

Wed, Mar 22, 5:07 PM · Restricted Project, Restricted Project
wrengr added inline comments to D142930: [mlir][sparse] extend loop emitter to emit slice driven loops.
Wed, Mar 22, 3:35 PM · Restricted Project, Restricted Project
wrengr added inline comments to D142930: [mlir][sparse] extend loop emitter to emit slice driven loops.
Wed, Mar 22, 2:10 PM · Restricted Project, Restricted Project
wrengr added inline comments to D142930: [mlir][sparse] extend loop emitter to emit slice driven loops.
Wed, Mar 22, 1:49 PM · Restricted Project, Restricted Project
wrengr added inline comments to D146083: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const.
Wed, Mar 22, 1:37 PM · Restricted Project, Restricted Project

Tue, Mar 21

wrengr abandoned D129243: [mlir][tblgen] Improve detecting default-prototype builder for AttrOrTypeDef.
Tue, Mar 21, 5:44 PM · Restricted Project, Restricted Project
wrengr accepted D146563: [mlir][sparse] fix crash when using pure constant index in indexing mapping (fixes #61530).
Tue, Mar 21, 4:39 PM · Restricted Project, Restricted Project