PoC patch.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
Could you expand the description to give the why's of the change?
mlir/include/mlir/IR/OperationSupport.h | ||
---|---|---|
532 | Class comment? | |
533 | Not sure the unsigned comment make sense. Many also consider using unsigned to represent non-negative constraint as anti-pattern (see previous discussion on list). | |
567 | Also document what is returned when it is not found. |
mlir/include/mlir/IR/OperationSupport.h | ||
---|---|---|
533 | In this case it's important to keep the size of Operation smaller. E.g. we use unsigned for the number of successors instead of size_t because it's half the size. std::vector (by default) is 33% bigger than SmallVector because its size and capacity are 64 bit |
Class comment?