Page MenuHomePhabricator

[mlir][core] Inline Intrinsic Attributes
Needs ReviewPublic

Authored by Mogball on Oct 29 2021, 11:03 PM.

Diff Detail

Unit TestsFailed

TimeTest
370 msx64 debian > MLIR.Conversion/MemRefToLLVM::memref-to-llvm.mlir
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt -convert-memref-to-llvm /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Conversion/MemRefToLLVM/memref-to-llvm.mlir -split-input-file | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Conversion/MemRefToLLVM/memref-to-llvm.mlir
90 msx64 debian > MLIR.Conversion/SPIRVToLLVM::lower-host-to-llvm-calls.mlir
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt --lower-host-to-llvm /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Conversion/SPIRVToLLVM/lower-host-to-llvm-calls.mlir | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Conversion/SPIRVToLLVM/lower-host-to-llvm-calls.mlir
100 msx64 debian > MLIR.Conversion/SPIRVToLLVM::memory-ops-to-llvm.mlir
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt -convert-spirv-to-llvm /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Conversion/SPIRVToLLVM/memory-ops-to-llvm.mlir | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Conversion/SPIRVToLLVM/memory-ops-to-llvm.mlir
80 msx64 debian > MLIR.Dialect/GPU::outlining.mlir
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt -allow-unregistered-dialect -gpu-kernel-outlining -split-input-file -verify-diagnostics /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/GPU/outlining.mlir | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/GPU/outlining.mlir
60 msx64 debian > MLIR.Dialect/LLVMIR::global.mlir
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt -split-input-file -verify-diagnostics /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/LLVMIR/global.mlir | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/LLVMIR/global.mlir
View Full Test Results (8 Failed)

Event Timeline

Mogball created this revision.Oct 29 2021, 11:03 PM
Mogball requested review of this revision.Oct 29 2021, 11:03 PM
Herald added a reviewer: herhut. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript

Could you expand the description to give the why's of the change?

mlir/include/mlir/IR/OperationSupport.h
532

Class comment?

533

Not sure the unsigned comment make sense. Many also consider using unsigned to represent non-negative constraint as anti-pattern (see previous discussion on list).

567

Also document what is returned when it is not found.

Mogball added inline comments.Thu, Nov 18, 9:01 AM
mlir/include/mlir/IR/OperationSupport.h
533

In this case it's important to keep the size of Operation smaller. E.g. we use unsigned for the number of successors instead of size_t because it's half the size.

std::vector (by default) is 33% bigger than SmallVector because its size and capacity are 64 bit