This is an archive of the discontinued LLVM Phabricator instance.

[mlir][core] Inline Intrinsic Attributes
AbandonedPublic

Authored by Mogball on Oct 29 2021, 11:03 PM.

Diff Detail

Event Timeline

Mogball created this revision.Oct 29 2021, 11:03 PM
Mogball requested review of this revision.Oct 29 2021, 11:03 PM
Herald added a reviewer: herhut. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript

Could you expand the description to give the why's of the change?

mlir/include/mlir/IR/OperationSupport.h
532

Class comment?

533

Not sure the unsigned comment make sense. Many also consider using unsigned to represent non-negative constraint as anti-pattern (see previous discussion on list).

567

Also document what is returned when it is not found.

Mogball added inline comments.Nov 18 2021, 9:01 AM
mlir/include/mlir/IR/OperationSupport.h
533

In this case it's important to keep the size of Operation smaller. E.g. we use unsigned for the number of successors instead of size_t because it's half the size.

std::vector (by default) is 33% bigger than SmallVector because its size and capacity are 64 bit

Mogball abandoned this revision.Mar 23 2022, 1:24 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: awarzynski. · View Herald Transcript