Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM. I have one minor question. Please address only if others point out the same thing.
llvm/docs/ReleaseNotes.rst | ||
---|---|---|
58 | Is alongside Clang important? Should we say something about the default behaviour (i.e parse, unparse and use external compiler to generate code)? |
Yes, it is for the release branch. Hope it is not too late. I had volunteered but missed it in the last two weeks.
Yes. I agree that this is not 100% clear (other than from the updated file itself). Is there any way to make this more visible?
Yes, it is for the release branch. Hope it is not too late. I had volunteered but missed it in the last two weeks.
You're just in time I think: https://lists.llvm.org/pipermail/cfe-dev/2021-August/068723.html
Yes. I agree that this is not 100% clear (other than from the updated file itself). Is there any way to make this more visible?
I don't see one, doesn't matter just wanted to double check.
llvm/docs/ReleaseNotes.rst | ||
---|---|---|
58 |
Good point, let me remove this.
Wouldn't flang/docs/ReleaseNotes.md be more suitable for this level of detail? Also, there has been no changes between LLVM 12 and 13 here, so I'm not sure whether we should include this. If there are no further comments on this today, I will skip it and merge as is. |
Deadline was extended to Friday: https://lists.llvm.org/pipermail/llvm-dev/2021-September/152525.html
The deadline does not apply to release note changes, they can be committed any time before the final release.
Merged into the release/13.x branch: https://github.com/llvm/llvm-project/commit/181739213aa00de40a5bc6fbb1c578ce25b78d39. Closing manually.
Is alongside Clang important? Should we say something about the default behaviour (i.e parse, unparse and use external compiler to generate code)?