This is an archive of the discontinued LLVM Phabricator instance.

[docs] Update release notes with items related to Flang
ClosedPublic

Authored by awarzynski on Sep 6 2021, 4:52 AM.

Diff Detail

Event Timeline

awarzynski created this revision.Sep 6 2021, 4:52 AM
awarzynski requested review of this revision.Sep 6 2021, 4:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2021, 4:52 AM
kiranchandramohan accepted this revision.Sep 6 2021, 5:01 AM

LGTM. I have one minor question. Please address only if others point out the same thing.

llvm/docs/ReleaseNotes.rst
58

Is alongside Clang important? Should we say something about the default behaviour (i.e parse, unparse and use external compiler to generate code)?

This revision is now accepted and ready to land.Sep 6 2021, 5:01 AM

Perhaps a silly question, this is for the llvm 13 branch right?

Perhaps a silly question, this is for the llvm 13 branch right?

Yes, it is for the release branch. Hope it is not too late. I had volunteered but missed it in the last two weeks.

Perhaps a silly question, this is for the llvm 13 branch right?

Yes. I agree that this is not 100% clear (other than from the updated file itself). Is there any way to make this more visible?

Yes, it is for the release branch. Hope it is not too late. I had volunteered but missed it in the last two weeks.

You're just in time I think: https://lists.llvm.org/pipermail/cfe-dev/2021-August/068723.html

Yes. I agree that this is not 100% clear (other than from the updated file itself). Is there any way to make this more visible?

I don't see one, doesn't matter just wanted to double check.

awarzynski added inline comments.Sep 6 2021, 6:48 AM
llvm/docs/ReleaseNotes.rst
58

Is alongside Clang important?

Good point, let me remove this.

Should we say something about the default behaviour (i.e parse, unparse and use external compiler to generate code)?

Wouldn't flang/docs/ReleaseNotes.md be more suitable for this level of detail? Also, there has been no changes between LLVM 12 and 13 here, so I'm not sure whether we should include this. If there are no further comments on this today, I will skip it and merge as is.

awarzynski updated this revision to Diff 370911.Sep 6 2021, 6:49 AM

Remove "alongside Clang"

The deadline does not apply to release note changes, they can be committed any time before the final release.