This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Semachecking for XL compat builtin icbt
ClosedPublic

Authored by quinnp on Jul 12 2021, 12:23 PM.

Details

Reviewers
nemanjai
stefanp
Group Reviewers
Restricted Project
Commits
rG59d2ba2a3de9: [PowerPC] Semachecking for XL compat builtin icbt
Summary

This patch is in a series of patches to provide builtins for compatibility with the XL compiler.
This patch adds semachecking for an already implemented builtin, __icbt. __icbt is only
valid for Power8 and up.

Diff Detail

Event Timeline

quinnp created this revision.Jul 12 2021, 12:23 PM
quinnp requested review of this revision.Jul 12 2021, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2021, 12:23 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
quinnp added reviewers: Restricted Project, nemanjai, stefanp.Jul 12 2021, 12:33 PM
nemanjai accepted this revision.Jul 12 2021, 2:33 PM

LGTM.

This revision is now accepted and ready to land.Jul 12 2021, 2:33 PM
nemanjai added inline comments.Jul 12 2021, 2:34 PM
clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c
1

Oh, I believe you're missing REQUIRES: powerpc-registered-target in this test case (please look at the requirements in the other builtins tests).

quinnp edited the summary of this revision. (Show Details)Jul 14 2021, 8:13 AM
quinnp edited the summary of this revision. (Show Details)
quinnp updated this revision to Diff 359077.Jul 15 2021, 11:54 AM

Removing some FIXME comments and tests that are handled elsewhere with semachecking.

Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2021, 11:54 AM
quinnp added inline comments.Jul 15 2021, 11:59 AM
clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c
1

I don't think I need REQUIRES: powerpc-registered-target, I am copying clang/test/CodeGen/builtins-ppc-xlcompat-pwr9.c which was committed here https://reviews.llvm.org/D102875#change-CGl81jJwEOZy. Although I may be wrong.

quinnp updated this revision to Diff 359398.EditedJul 16 2021, 11:22 AM

Adding REQUIRES: powerpc-registered-target to a testcase and removing checks for entry: in front end test case.

quinnp marked an inline comment as done.Jul 16 2021, 11:25 AM
kamaub edited the summary of this revision. (Show Details)Jul 20 2021, 8:53 AM
This revision was landed with ongoing or failed builds.Jul 20 2021, 9:05 AM
This revision was automatically updated to reflect the committed changes.
MaskRay added inline comments.
clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c
11

This will attempt to write a file in srcdir which can cause an error if srcdir is in a readonly filesystem.

I added -o - in e8bc871ca2780788ad580bb23ef2621b09e6394b