- User Since
- May 13 2021, 11:10 AM (97 w, 22 h)
Aug 16 2022
Hi @MaskRay, could you please take a look at @nemanjai's suggestion?
So I would prefer that we handle this in the CMake files if @MaskRay doesn't object.
Jul 27 2022
Adding lit config to mark tests as unsupported for non PPC targets.
Addressing review comments: fixing test cases and improving test case clarity.
Jul 25 2022
Adressing review comments. Moving tests into function-sections.c, using %s instead of creating a new file with touch, and modifying some CHECK lines to simplify checks.
Jul 21 2022
Adressed review comments.
- Modified how llvm-lto test-cases check the llvm-objdump -t output.
- Renamed gold-lto-sections.c to forwarding-sections-liblto.c and modified the test to use the RUN lines from forwarding-sections-liblto.c with the target specified using --target=.
Jul 20 2022
Addressing review comments. Changing test cases to use llvm-objdump -t instead of obj2yaml.
Addressing review comments. Fixing the forwarding for -fno-function-sectons and removing the ObjectFormatType check.
Jul 19 2022
Modifying a test to fix check lines.
If this is for the legacy LTO interface, please state so. lld/*/LTO.cpp sets c.Options.DataSections = true; to enable data sections by default.
Fixing test case.
Jul 18 2022
Addressing review comment.
Updating patch to forward -data-sections=1 to libLTO/gold instead of just -data-sections when -fdata-sections is explicitly specified in clang. This is to be more explicit since -data-sections=0 is now being forwared when -fno-data-sections is explicitly specified.
Updating patch with a clang change to properly forward -data-sections=0 to libLTO/gold when -fno-data-sections is explicitly specified.
Jul 15 2022
I've realized that getExplicitDataSections() interacts with the clang options -fdata-sections and -fno-data-sections differently than the llc versions of these options, --data-sections=true and --data-sections=false. In particular,
- when --data-sections=true is specified with llvm-lto, getExplicitDataSections() returns 1
- when --data-sections=false is specified with llvm-lto, getExplicitDataSections() returns 0
- when no data-sections options are specified with llvm-lto, getExplicitDataSections() returns None.
- when -fdata-sections is specified with clang, getExplicitDataSections() returns 1
- when -fno-data-sections is specified with clang, getExplicitDataSections() returns None.
- when no data-sections options are specified with clang, getExplicitDataSections() returns None.
Jul 11 2022
Jul 8 2022
Jun 28 2022
Jun 17 2022
Jun 15 2022
Adding a comments to the early exits in expandVSXLoadForLE and expandVSXStoreForLE.
Updating patch to delay SVX load and store combine until after legalization.
Jun 13 2022
LGTM as well aside from Zarko's comment.
Jun 10 2022
Rebasing with main.
I did not remove that on purpose, so adding it back makes sense to me.
I've updated the patch to remove the path without the /root/usr suffix and exclusively add the path with the root/usr suffix.
Addressing review comments. Removing path without /root/usr suffix and changing unit test to match.
Jun 9 2022
Hi, this patch broke one of the PowerPC bots (https://lab.llvm.org/buildbot/#/builders/121). unix03-sigpipe-exit.test is failing. Here is the first build with this patch: https://lab.llvm.org/buildbot/#/builders/121/builds/20219
Jun 8 2022
Thank you @nemanjai! I've updated the patch based on your suggestion and tested it for both the existing testcase and the RHEL buildbot failure.
Addressing review comments.
May 5 2022
Other than my comment, LGTM
Apr 25 2022
Apr 13 2022
Apr 12 2022
Fixing failing tests added in this patch.
Small change for consistency.
Small change for consistency. llvm::Value -> Value
Updating patch with a fix for emitting builtin arguments in an unspecified order.
Re-opening the revision so that I can update it with a fix.
Apr 7 2022
Fixing a set of builtins added by the rebase with main.
Rebasing with main.
Fixing some testcases that broke due to re-ordering IR in my last update.
Adressing review comments. Added a testcase which fails prior to this patch due to the arguments being emmited multiple times. Refactored some calls to EmitScalarExpr() to be more consistent.
Mar 30 2022
Moving testcases that require code generation from clang/test/Sema/ppc-pair-mma-types.c to clang/test/CodeGen/PowerPC/ppc-mma-types.c and clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c. This is because some of these tests use the line Ops.push_back(EmitArrayToPointerDecay(E->getArg(i)).getPointer()); which I initially removed from EmitPPCbuiltinExpr. I have added this back in the switch statement where it is needed.
Mar 28 2022
Mar 21 2022
Fixing a failing test case.