Page MenuHomePhabricator

quinnp (Quinn Pham)
User

Projects

User does not belong to any projects.

User Details

User Since
May 13 2021, 11:10 AM (58 w, 3 d)

Recent Activity

Fri, Jun 17

quinnp committed rGdeb7655209a7: [PowerPC] Fix PPCVSXSwapRemoval pass to include MTVSCR and MFVSCR as not… (authored by quinnp).
[PowerPC] Fix PPCVSXSwapRemoval pass to include MTVSCR and MFVSCR as not…
Fri, Jun 17, 8:14 AM · Restricted Project, Restricted Project
quinnp closed D128062: [PowerPC] Fix PPCVSXSwapRemoval pass to include MTVSCR and MFVSCR as not swappable..
Fri, Jun 17, 8:14 AM · Restricted Project, Restricted Project
quinnp added reviewers for D128062: [PowerPC] Fix PPCVSXSwapRemoval pass to include MTVSCR and MFVSCR as not swappable.: Restricted Project, nemanjai, lei, stefanp.
Fri, Jun 17, 7:48 AM · Restricted Project, Restricted Project
quinnp requested review of D128062: [PowerPC] Fix PPCVSXSwapRemoval pass to include MTVSCR and MFVSCR as not swappable..
Fri, Jun 17, 7:47 AM · Restricted Project, Restricted Project

Wed, Jun 15

quinnp committed rG335e8bf1008f: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads… (authored by quinnp).
[PowerPC] emit VSX instructions instead of VMX instructions for vector loads…
Wed, Jun 15, 10:06 AM · Restricted Project, Restricted Project
quinnp closed D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores.
Wed, Jun 15, 10:06 AM · Restricted Project, Restricted Project
quinnp updated the summary of D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores.
Wed, Jun 15, 7:13 AM · Restricted Project, Restricted Project
quinnp updated the diff for D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores.

Adding a comments to the early exits in expandVSXLoadForLE and expandVSXStoreForLE.

Wed, Jun 15, 7:12 AM · Restricted Project, Restricted Project
quinnp updated the diff for D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores.

Updating patch to delay SVX load and store combine until after legalization.

Wed, Jun 15, 6:21 AM · Restricted Project, Restricted Project

Mon, Jun 13

quinnp updated the summary of D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores.
Mon, Jun 13, 11:57 AM · Restricted Project, Restricted Project
quinnp updated the summary of D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores.
Mon, Jun 13, 11:55 AM · Restricted Project, Restricted Project
quinnp accepted D127439: [PowerPC] Fix combine step for shufflevector..

LGTM as well aside from Zarko's comment.

Mon, Jun 13, 10:13 AM · Restricted Project, Restricted Project
quinnp committed rG35aaf548237a: [clang][driver] fix to correctly set devtoolset on RHEL (authored by quinnp).
[clang][driver] fix to correctly set devtoolset on RHEL
Mon, Jun 13, 7:13 AM · Restricted Project, Restricted Project
quinnp closed D127310: [clang][driver] fix to correctly set devtoolset on RHEL.
Mon, Jun 13, 7:12 AM · Restricted Project, Restricted Project

Fri, Jun 10

quinnp updated the diff for D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores.

Rebasing with main.

Fri, Jun 10, 10:11 AM · Restricted Project, Restricted Project
quinnp added a comment to D127310: [clang][driver] fix to correctly set devtoolset on RHEL.

I did not remove that on purpose, so adding it back makes sense to me.

I've updated the patch to remove the path without the /root/usr suffix and exclusively add the path with the root/usr suffix.

Fri, Jun 10, 7:42 AM · Restricted Project, Restricted Project
quinnp updated the diff for D127310: [clang][driver] fix to correctly set devtoolset on RHEL.

Addressing review comments. Removing path without /root/usr prefix and changing unit test to match.

Fri, Jun 10, 7:38 AM · Restricted Project, Restricted Project

Thu, Jun 9

quinnp added a comment to rG51b557adc131: Add an error message to the default SIGPIPE handler.

Hi, this patch broke one of the PowerPC bots (https://lab.llvm.org/buildbot/#/builders/121). unix03-sigpipe-exit.test is failing. Here is the first build with this patch: https://lab.llvm.org/buildbot/#/builders/121/builds/20219

Thu, Jun 9, 10:29 AM · Restricted Project, Restricted Project

Wed, Jun 8

quinnp added a comment to D127310: [clang][driver] fix to correctly set devtoolset on RHEL.

Thank you @nemanjai! I've updated the patch based on your suggestion and tested it for both the existing testcase and the RHEL buildbot failure.

Wed, Jun 8, 10:20 AM · Restricted Project, Restricted Project
quinnp updated the diff for D127310: [clang][driver] fix to correctly set devtoolset on RHEL.

Addressing review comments.

Wed, Jun 8, 10:19 AM · Restricted Project, Restricted Project
quinnp added reviewers for D127310: [clang][driver] fix to correctly set devtoolset on RHEL: nemanjai, MaskRay, tbaeder, tstellar, phosek.
Wed, Jun 8, 8:08 AM · Restricted Project, Restricted Project
quinnp requested review of D127310: [clang][driver] fix to correctly set devtoolset on RHEL.
Wed, Jun 8, 8:06 AM · Restricted Project, Restricted Project
quinnp added reviewers for D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores: nemanjai, lei, Restricted Project.
Wed, Jun 8, 7:58 AM · Restricted Project, Restricted Project
quinnp requested review of D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores.
Wed, Jun 8, 7:57 AM · Restricted Project, Restricted Project

May 5 2022

quinnp accepted D113514: [LLVM][sancov] Inclusive language: Add -ignorelist option.

Other than my comment, LGTM

May 5 2022, 6:44 AM · Restricted Project, Restricted Project
quinnp added inline comments to D113514: [LLVM][sancov] Inclusive language: Add -ignorelist option.
May 5 2022, 6:43 AM · Restricted Project, Restricted Project

Apr 25 2022

quinnp committed rG09e75d3f0996: [libcxx][NFC] Inclusive language: remove use of sanity check (authored by quinnp).
[libcxx][NFC] Inclusive language: remove use of sanity check
Apr 25 2022, 2:54 PM · Restricted Project, Restricted Project
quinnp closed D124391: [libcxx][NFC] Inclusive language: remove use of sanity check.
Apr 25 2022, 2:54 PM · Restricted Project, Restricted Project
quinnp committed rGb3e8e43789d2: [compiler-rt][NFC] Inclusive language: remove use of sanity check/test (authored by quinnp).
[compiler-rt][NFC] Inclusive language: remove use of sanity check/test
Apr 25 2022, 2:13 PM · Restricted Project, Restricted Project
quinnp closed D124390: [compiler-rt][NFC] Inclusive language: remove use of sanity check/test.
Apr 25 2022, 2:13 PM · Restricted Project, Restricted Project
quinnp committed rG0386213352ec: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/ (authored by quinnp).
[clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/
Apr 25 2022, 1:26 PM · Restricted Project, Restricted Project
quinnp closed D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/.
Apr 25 2022, 1:26 PM · Restricted Project, Restricted Project
quinnp added reviewers for D124391: [libcxx][NFC] Inclusive language: remove use of sanity check: ldionne, ZarkoCA.
Apr 25 2022, 7:59 AM · Restricted Project, Restricted Project
quinnp requested review of D124391: [libcxx][NFC] Inclusive language: remove use of sanity check.
Apr 25 2022, 7:59 AM · Restricted Project, Restricted Project
quinnp added reviewers for D124390: [compiler-rt][NFC] Inclusive language: remove use of sanity check/test: dvyukov, ZarkoCA.
Apr 25 2022, 7:50 AM · Restricted Project, Restricted Project
quinnp requested review of D124390: [compiler-rt][NFC] Inclusive language: remove use of sanity check/test.
Apr 25 2022, 7:49 AM · Restricted Project, Restricted Project
quinnp added reviewers for D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/: george.karpenkov, aaron.ballman, ZarkoCA.
Apr 25 2022, 7:40 AM · Restricted Project, Restricted Project
quinnp requested review of D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/.
Apr 25 2022, 7:38 AM · Restricted Project, Restricted Project

Apr 13 2022

quinnp committed rG7d7022fb0ce4: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once (authored by quinnp).
[PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once
Apr 13 2022, 2:32 PM · Restricted Project, Restricted Project
quinnp closed D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.
Apr 13 2022, 2:32 PM · Restricted Project, Restricted Project

Apr 12 2022

quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Fixing failing tests added in this patch.

Apr 12 2022, 1:12 PM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Small change for consistency.

Apr 12 2022, 12:17 PM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Small change for consistency. llvm::Value -> Value

Apr 12 2022, 11:56 AM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Updating patch with a fix for emitting builtin arguments in an unspecified order.

Apr 12 2022, 11:53 AM · Restricted Project, Restricted Project
quinnp reopened D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Re-opening the revision so that I can update it with a fix.

Apr 12 2022, 11:53 AM · Restricted Project, Restricted Project

Apr 7 2022

quinnp added a comment to D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Looks like this breaks tests on windows: http://45.33.8.238/win/55893/step_7.txt

Please take a look and revert for now if it takes a while to fix.

Apr 7 2022, 2:49 PM · Restricted Project, Restricted Project
quinnp added a reverting change for rG2aae5b1fac38: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once: rGfef56f79ac8c: Revert "[PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once".
Apr 7 2022, 2:47 PM · Restricted Project, Restricted Project
quinnp committed rGfef56f79ac8c: Revert "[PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once" (authored by quinnp).
Revert "[PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once"
Apr 7 2022, 2:47 PM · Restricted Project, Restricted Project
quinnp added a reverting change for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once: rGfef56f79ac8c: Revert "[PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once".
Apr 7 2022, 2:46 PM · Restricted Project, Restricted Project
quinnp committed rG2aae5b1fac38: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once (authored by quinnp).
[PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once
Apr 7 2022, 2:00 PM · Restricted Project, Restricted Project
quinnp closed D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.
Apr 7 2022, 2:00 PM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Fixing a set of builtins added by the rebase with main.

Apr 7 2022, 11:38 AM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Rebasing with main.

Apr 7 2022, 10:51 AM · Restricted Project, Restricted Project
quinnp added inline comments to D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.
Apr 7 2022, 10:37 AM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Fixing some testcases that broke due to re-ordering IR in my last update.

Apr 7 2022, 10:36 AM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Adressing review comments. Added a testcase which fails prior to this patch due to the arguments being emmited multiple times. Refactored some calls to EmitScalarExpr() to be more consistent.

Apr 7 2022, 10:21 AM · Restricted Project, Restricted Project

Mar 30 2022

quinnp added inline comments to D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.
Mar 30 2022, 6:27 AM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Moving testcases that require code generation from clang/test/Sema/ppc-pair-mma-types.c to clang/test/CodeGen/PowerPC/ppc-mma-types.c and clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c. This is because some of these tests use the line Ops.push_back(EmitArrayToPointerDecay(E->getArg(i)).getPointer()); which I initially removed from EmitPPCbuiltinExpr. I have added this back in the switch statement where it is needed.

Mar 30 2022, 6:22 AM · Restricted Project, Restricted Project

Mar 28 2022

quinnp added inline comments to D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.
Mar 28 2022, 1:03 PM · Restricted Project, Restricted Project

Mar 21 2022

quinnp accepted D121430: [PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes..

LGTM

Mar 21 2022, 7:31 AM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Fixing a failing test case.

Mar 21 2022, 6:54 AM · Restricted Project, Restricted Project

Mar 15 2022

quinnp updated the summary of D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.
Mar 15 2022, 7:47 AM · Restricted Project, Restricted Project
quinnp updated the summary of D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.
Mar 15 2022, 7:45 AM · Restricted Project, Restricted Project
quinnp updated the diff for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.

Minor formatting update.

Mar 15 2022, 6:29 AM · Restricted Project, Restricted Project

Mar 14 2022

quinnp added reviewers for D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once: Restricted Project, nemanjai, lei.
Mar 14 2022, 1:45 PM · Restricted Project, Restricted Project
quinnp requested review of D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once.
Mar 14 2022, 1:44 PM · Restricted Project, Restricted Project

Feb 27 2022

quinnp accepted D120514: [mlir-tblgen] Fix non-deterministic generating static verifier in DRR..

LGTM. @Chia-hungDuan I've verified that this fixes the issue. Thanks again for implementing this!

Feb 27 2022, 7:54 AM · Restricted Project

Feb 23 2022

quinnp added a comment to D110199: Static verifier for type/attribute in DRR.

Hi @Chia-hungDuan, while doing PowerPC Linux release testing for LLVM 14.0.0-rc1 I encountered some differing object files between Phase2 and Phase3 of the bootstrap build:

# Comparing Phase 2 and Phase 3 files
file ArithmeticOps.cpp.o differs between phase 2 and phase 3
file TestPatterns.cpp.o differs between phase 2 and phase 3

I used git bisect to find that this patch was the first instance of the differing files. We are hoping to fix this for the LLVM 14.0.0 release. I've created this issue in the llvm project. It would be great if you could take a look at it. Thanks!

Feb 23 2022, 2:04 PM · Restricted Project

Feb 11 2022

quinnp accepted D119521: [PowerPC] Add default handling for single element vectors, and split/promote vNi1 vectors..

lgtm

Feb 11 2022, 9:35 AM · Restricted Project, Restricted Project

Jan 24 2022

quinnp committed rG6a028296fe62: [PowerPC] Emit warning when SP is clobbered by asm (authored by quinnp).
[PowerPC] Emit warning when SP is clobbered by asm
Jan 24 2022, 1:12 PM
quinnp closed D112073: [PowerPC] Emit warning when SP is clobbered by asm.
Jan 24 2022, 1:12 PM · Restricted Project, Restricted Project

Dec 21 2021

quinnp updated the summary of D112073: [PowerPC] Emit warning when SP is clobbered by asm.
Dec 21 2021, 8:21 AM · Restricted Project, Restricted Project
quinnp updated the summary of D112073: [PowerPC] Emit warning when SP is clobbered by asm.
Dec 21 2021, 8:21 AM · Restricted Project, Restricted Project
quinnp updated the diff for D112073: [PowerPC] Emit warning when SP is clobbered by asm.

Adressing review comments. Added register alias sp for the register r1.
Added a front end testcase to test the location information and all of the
aliases for r1. Merged the back end test cases so that we are testing both
r1 and x1 in 32bit and 64bit.

Dec 21 2021, 8:15 AM · Restricted Project, Restricted Project

Nov 30 2021

quinnp updated the summary of D112073: [PowerPC] Emit warning when SP is clobbered by asm.
Nov 30 2021, 6:47 AM · Restricted Project, Restricted Project
quinnp updated the diff for D112073: [PowerPC] Emit warning when SP is clobbered by asm.

Addressing review comments. Added a comment about why we are not using getReservedRegs(). Added implementation for PPC64.

Nov 30 2021, 6:43 AM · Restricted Project, Restricted Project

Nov 25 2021

quinnp committed rGb11c66accfb1: [NFC] Inclusive language: rename master flag to main flag (authored by quinnp).
[NFC] Inclusive language: rename master flag to main flag
Nov 25 2021, 1:16 PM
quinnp closed D114090: [NFC] Inclusive language: rename master flag to main flag.
Nov 25 2021, 1:16 PM · Restricted Project, Restricted Project
quinnp committed rGb90eef30048d: [NFC][flang] Inclusive language: remove instances of master (authored by quinnp).
[NFC][flang] Inclusive language: remove instances of master
Nov 25 2021, 1:11 PM
quinnp closed D113923: [NFC][flang] Inclusive language: remove instances of master.
Nov 25 2021, 1:11 PM · Restricted Project, Restricted Project
quinnp accepted D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck.

LGTM

Nov 25 2021, 12:20 PM · Restricted Project, Restricted Project
quinnp committed rGa712b661eb94: [NFC][llvm] Inclusive language: replace master in llvm docs (authored by quinnp).
[NFC][llvm] Inclusive language: replace master in llvm docs
Nov 25 2021, 11:37 AM
quinnp closed D114187: [NFC][llvm] Inclusive language: replace master in llvm docs.
Nov 25 2021, 11:36 AM · Restricted Project
quinnp committed rG5c162ec54520: [NFC][compiler-rt] Inclusive language: replace master/slave with… (authored by quinnp).
[NFC][compiler-rt] Inclusive language: replace master/slave with…
Nov 25 2021, 11:31 AM
quinnp closed D114255: [NFC][compiler-rt] Inclusive language: replace master/slave with primary/secondary.
Nov 25 2021, 11:31 AM · Restricted Project
quinnp committed rG34303d3db78f: [NFC][llvm] Inclusive language: replace master with main in dbg-call-site… (authored by quinnp).
[NFC][llvm] Inclusive language: replace master with main in dbg-call-site…
Nov 25 2021, 10:34 AM
quinnp closed D114097: [NFC][llvm] Inclusive language: replace master with main in dbg-call-site-spilled-arg.mir.
Nov 25 2021, 10:34 AM · Restricted Project
quinnp committed rGc3dc6b081da6: [NFC][clang-tools-extra] Inclusive language: replace master with main (authored by quinnp).
[NFC][clang-tools-extra] Inclusive language: replace master with main
Nov 25 2021, 9:01 AM
quinnp closed D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main.
Nov 25 2021, 9:01 AM · Restricted Project

Nov 24 2021

quinnp added a comment to D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main.

@sammccall could you take a look at the other changes when you have time? Thanks!

Nov 24 2021, 10:28 AM · Restricted Project
quinnp added a comment to D114187: [NFC][llvm] Inclusive language: replace master in llvm docs.

@Paul-C-Anagnostopoulos could you take a look at the new changes when you have time? Thanks!

Nov 24 2021, 9:52 AM · Restricted Project
quinnp committed rG6ee69c0dea1e: [NFC][X86] Inclusive language: Rename master label in x86-shrink-wrapping.ll (authored by quinnp).
[NFC][X86] Inclusive language: Rename master label in x86-shrink-wrapping.ll
Nov 24 2021, 7:48 AM
quinnp closed D113940: [NFC][X86] Inclusive language: Rename master label in x86-shrink-wrapping.ll.
Nov 24 2021, 7:47 AM · Restricted Project
quinnp added a comment to D113923: [NFC][flang] Inclusive language: remove instances of master.

@schweitz could you take a look at the new changes when you have time? Thanks!

Nov 24 2021, 7:21 AM · Restricted Project, Restricted Project

Nov 23 2021

quinnp committed rG1345bc5e16c0: [NFC][llvm] Inclusive language: remove instance of master in LiveRangeUtils.h (authored by quinnp).
[NFC][llvm] Inclusive language: remove instance of master in LiveRangeUtils.h
Nov 23 2021, 11:08 AM
quinnp closed D114191: [NFC][llvm] Inclusive language: remove instance of master in LiveRangeUtils.h.
Nov 23 2021, 11:07 AM · Restricted Project

Nov 22 2021

quinnp committed rG592504aa26eb: [NFC][llvm] Inclusive language: replace master with main in 2007-04-02… (authored by quinnp).
[NFC][llvm] Inclusive language: replace master with main in 2007-04-02…
Nov 22 2021, 12:41 PM
quinnp closed D114276: [NFC][llvm] Inclusive language: replace master with main in 2007-04-02-RegScavengerAssert.ll.
Nov 22 2021, 12:41 PM · Restricted Project
quinnp committed rGad501054f1b5: [NFC][clang] Inclusive language: rename master variable to controller in debug… (authored by quinnp).
[NFC][clang] Inclusive language: rename master variable to controller in debug…
Nov 22 2021, 12:03 PM
quinnp closed D114108: [NFC][clang] Inclusive language: rename master variable to controller in debug-info tests.
Nov 22 2021, 12:03 PM · Restricted Project