Page MenuHomePhabricator
Differential D95496

[clang][OpenMP] Augment ForStmt/CXXForRangeStmt for OpenMP canonical loops.
Needs ReviewPublic
Actions

Authored by Meinersbur on Jan 26 2021, 7:26 PM.

Details

Reviewers
jdoerfert
AMDChirag
anchu-rajendran
kiranchandramohan
SouraVX
ftynse
kiranktp
fghanim
ABataev
dblaikie
rsmith
aaron.ballman
shafik
craig.topper
Summary

Alternative version of D94973. Instead of a new AST node of kind OMPCanonicalLoop that acts as parent of a ForStmt or CXXForRangeStmt, introduce a new superclass for both classes for storying the properties for an OpenMP canonical loop.

This was suggested by @ABataev following the same approach taken in D83261 for directives. In this patch, the equivalent of OMPChildren is LoopChildren and the class corresponding to OMPExecutableDirective is MaybeCanonicalLoopStmt.

Diff Detail

Unit TestsFailed
View All

TimeTest
430 msx64 windows > Clang.OpenMP::cancel_codegen.cpp
Script: -- : 'RUN: at line 1'; c:\ws\w1\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w1\llvm-project\premerge-checks\build\lib\clang\12.0.0\include -nostdsysteminc -verify -fopenmp -fopenmp-version=45 -triple x86_64-apple-darwin13.4.0 -emit-llvm -o - C:\ws\w1\llvm-project\premerge-checks\clang\test\OpenMP\cancel_codegen.cpp | c:\ws\w1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w1\llvm-project\premerge-checks\clang\test\OpenMP\cancel_codegen.cpp --check-prefixes=ALL,CHECK
200 msx64 windows > Clang.OpenMP::irbuilder_nested_parallel_for.c
Script: -- : 'RUN: at line 2'; c:\ws\w1\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w1\llvm-project\premerge-checks\build\lib\clang\12.0.0\include -nostdsysteminc -verify -fopenmp -fopenmp-enable-irbuilder -x c++ -emit-llvm C:\ws\w1\llvm-project\premerge-checks\clang\test\OpenMP\irbuilder_nested_parallel_for.c -triple x86_64-unknown-unknown -fexceptions -fcxx-exceptions -o - | c:\ws\w1\llvm-project\premerge-checks\build\bin\filecheck.exe --check-prefixes=CHECK C:\ws\w1\llvm-project\premerge-checks\clang\test\OpenMP\irbuilder_nested_parallel_for.c

Event Timeline

Meinersbur created this revision.Jan 26 2021, 7:26 PM
Herald added a reviewer: shafik. · View Herald TranscriptJan 26 2021, 7:26 PM
Herald added subscribers: dexonsmith, martong, guansong and 2 others. · View Herald Transcript
Meinersbur requested review of this revision.Jan 26 2021, 7:26 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 26 2021, 7:26 PM
Herald added subscribers: llvm-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B86791: Diff 319450.Jan 26 2021, 8:28 PM
martong removed a subscriber: martong.Jan 27 2021, 12:58 AM
Meinersbur retitled this revision from [clang][OpenMP] Augment ForStmt/CXXForRangeStmt for OpenMP canonicial loop. to [clang][OpenMP] Augment ForStmt/CXXForRangeStmt for OpenMP canonical loops..Feb 1 2021, 6:35 PM
jdenny mentioned this in D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops..Feb 26 2021, 11:43 AM
craig.topper resigned from this revision.Feb 26 2021, 1:30 PM

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
AST/
257 lines
104 lines
Basic/
6 lines
Sema/
5 lines
lib/
AST/
14 lines
96 lines
49 lines
CodeGen/
8 lines
140 lines
25 lines
Parse/
10 lines
Sema/
25 lines
356 lines
14 lines
3 lines
Serialization/
12 lines
10 lines
test/
OpenMP/
147 lines
164 lines
147 lines
llvm/
include/
llvm/
Frontend/
OpenMP/
6 lines
lib/
Frontend/
OpenMP/
10 lines

Diff 319450

View Options

clang/include/clang/AST/Stmt.h

Loading...
View Options

clang/include/clang/AST/StmtCXX.h

Loading...
View Options

clang/include/clang/Basic/StmtNodes.td

Loading...
View Options

clang/include/clang/Sema/Sema.h

Loading...
View Options

clang/lib/AST/ASTImporter.cpp

Loading...
View Options

clang/lib/AST/Stmt.cpp

Loading...
View Options

clang/lib/AST/StmtCXX.cpp

Loading...
View Options

clang/lib/CodeGen/CGStmt.cpp

Loading...
View Options

clang/lib/CodeGen/CGStmtOpenMP.cpp

Loading...
View Options

clang/lib/CodeGen/CodeGenFunction.h

Loading...
View Options

clang/lib/Parse/ParseOpenMP.cpp

Loading...
View Options

clang/lib/Sema/SemaExpr.cpp

Loading...
View Options

clang/lib/Sema/SemaOpenMP.cpp

Loading...
View Options

clang/lib/Sema/SemaStmt.cpp

Loading...
View Options

clang/lib/Sema/TreeTransform.h

Loading...
View Options

clang/lib/Serialization/ASTReaderStmt.cpp

Loading...
View Options

clang/lib/Serialization/ASTWriterStmt.cpp

Loading...
View Options

clang/test/OpenMP/irbuilder_for_iterator.cpp

Loading...
View Options

clang/test/OpenMP/irbuilder_for_rangefor.cpp

Loading...
View Options

clang/test/OpenMP/irbuilder_for_unsigned.c

Loading...
View Options

llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h

Loading...
View Options

llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp

Loading...