Page MenuHomePhabricator

SouraVX (Sourabh Singh Tomar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2019, 11:05 PM (72 w, 5 d)

Recent Activity

Tue, Jan 12

SouraVX committed rG4744478b99f1: [mlir][openmp][NFCI] Rename `continuationIP` to `continuationBlock` (authored by SouraVX).
[mlir][openmp][NFCI] Rename `continuationIP` to `continuationBlock`
Tue, Jan 12, 2:17 AM

Tue, Jan 5

SouraVX accepted D93301: [flang][driver] Add support for `-c` and `-emit-obj`.

LGTM! - Thanks!

Tue, Jan 5, 10:09 PM · Restricted Project, Restricted Project

Sun, Dec 20

SouraVX accepted D93558: [docs] Release notes for IsDecl in DIModule..

LGTM, Thanks!

Sun, Dec 20, 9:50 PM · Restricted Project

Dec 17 2020

SouraVX accepted D93462: [DebugInfo] Support Fortran 'use <external module>' statement..

LGTM! Thanks for the patch.
One small thing, do you mind adding a one liner to release notes ? It would help in tracking extensions to Debug Metadata(previous extensions of DIModule were part of LLVM11).

Dec 17 2020, 10:19 PM · debug-info, Restricted Project
SouraVX added a project to D93462: [DebugInfo] Support Fortran 'use <external module>' statement.: debug-info.
Dec 17 2020, 10:13 PM · debug-info, Restricted Project
SouraVX updated subscribers of D93462: [DebugInfo] Support Fortran 'use <external module>' statement..
Dec 17 2020, 8:35 AM · debug-info, Restricted Project

Dec 15 2020

SouraVX added a comment to D93301: [flang][driver] Add support for `-c` and `-emit-obj`.

Thanks! for the patch, some minor comments inlined. Rest LGTM. Let others also have a look.

Dec 15 2020, 8:32 PM · Restricted Project, Restricted Project

Dec 11 2020

SouraVX accepted D93088: [OpenMPIRBuilder] Various changes required for tileLoops..

LGTM Thank You @Meinersbur for taking out time :).

Dec 11 2020, 1:02 AM · Restricted Project

Dec 9 2020

SouraVX added inline comments to D92974: [OpenMPIRBuilder] Implement tileLoops..
Dec 9 2020, 11:36 PM · Restricted Project
SouraVX added a comment to D92974: [OpenMPIRBuilder] Implement tileLoops..

Thanks for the patch! Some NIT's related to refactoring/moving inline. I've tried to highlight some parts, if you like the idea in general, there might be more opportunities to reduce the size of this patch(thus capturing the most crucial part tileLoop).

Dec 9 2020, 10:17 PM · Restricted Project

Dec 8 2020

SouraVX accepted D92443: [flang][openacc] Avoid use of init, shutdown and set in compute construct.

LGTM, Thanks!

Dec 8 2020, 7:35 AM · Restricted Project, Restricted Project
SouraVX added inline comments to D92120: [flang][openacc] Update reference to OpenACC 3.1 specification.
Dec 8 2020, 7:28 AM · Restricted Project, Restricted Project, Unknown Object (Project)
SouraVX accepted D92120: [flang][openacc] Update reference to OpenACC 3.1 specification.
Dec 8 2020, 7:19 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Dec 7 2020

SouraVX added inline comments to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Dec 7 2020, 7:17 AM · Unknown Object (Project)

Dec 6 2020

SouraVX committed rGc11d868a39cb: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR (authored by SouraVX).
[MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR
Dec 6 2020, 8:54 PM
SouraVX closed D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Dec 6 2020, 8:54 PM · Unknown Object (Project)

Dec 4 2020

SouraVX added a comment to D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop.

@ftynse would you mind having a look at D87247 ?

Dec 4 2020, 4:09 AM · Restricted Project, Restricted Project

Dec 3 2020

SouraVX accepted D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.

LGTM Thanks! Please wait for @aprantl for any comments/approval.

Dec 3 2020, 9:59 PM · debug-info, Restricted Project
SouraVX added a project to D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType: debug-info.
Dec 3 2020, 1:33 AM · debug-info, Restricted Project
SouraVX added a comment to D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.

Thanks @cchen15 for the patch! It seems like you're also adding support for FORTRAN deferred length string would you please make appropriate changes in summary to reflect the intent.

Dec 3 2020, 1:32 AM · debug-info, Restricted Project

Dec 2 2020

SouraVX added a reviewer for D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType: schweitz.
Dec 2 2020, 9:02 PM · debug-info, Restricted Project
SouraVX added a reviewer for D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop: kiranchandramohan.
Dec 2 2020, 6:04 AM · Restricted Project, Restricted Project

Dec 1 2020

SouraVX updated the diff for D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.

Added error propagation support. @ftynse I was waiting for your response, however I noticed same approach in D92055. So I've revised this.

Dec 1 2020, 7:32 AM · Unknown Object (Project)

Nov 26 2020

SouraVX added inline comments to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Nov 26 2020, 9:19 AM · Unknown Object (Project)

Nov 24 2020

SouraVX added a comment to D90488: [flang][openacc] Lower init and shutdown directive.

There was discussion on the last few calls to move it upstream very soon. A RFC should have been sent to coordinate the upstreaming of the fir-dev patch(es). Looks like it hasn't moved yet. @kiranchandramohan @SouraVX @schweitz @sscalpone Do you know if there is any progress with the upstreaming process?

AFAIK(based on @jdoerfert comment in our last meet) it's up for internal review for Lab folks.

Nov 24 2020, 10:11 PM · Restricted Project, Restricted Project
SouraVX added inline comments to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Nov 24 2020, 11:05 AM · Unknown Object (Project)
SouraVX updated the diff for D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.

Addressed comments related to formatting test case + Rebase.

Nov 24 2020, 11:05 AM · Unknown Object (Project)
SouraVX added a comment to D91982: [mlir] Add conversion from SCF parallel loops to OpenMP.

Please ignore if this is out of context.
So Flang lower all loops into fir.do_loop(which is essentially a superset of scf.for) then it may lower to scf.for(depending on feasibility). So the question I have is what's the intended lowering targeted here for openmp worksharing loop ?

Nov 24 2020, 7:47 AM · Unknown Object (Project)

Nov 19 2020

SouraVX updated the diff for D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.

Rebase + Ping!

Nov 19 2020, 4:46 AM · Unknown Object (Project)

Nov 6 2020

SouraVX added inline comments to D90916: [DebugInfo] Emit locations for large constant integers.
Nov 6 2020, 4:43 AM · Restricted Project
SouraVX added a comment to D90916: [DebugInfo] Emit locations for large constant integers.

Thanks for the patch! Overall this looks nice. We can also represent long double(128 bits) using DW_OP_implicit_value, any plans for supporting that too ? long double is non-trivial like it has different representation on Power. It's pending on me since a while :(

Nov 6 2020, 4:39 AM · Restricted Project

Oct 23 2020

SouraVX committed rGe7d37742a2a5: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct (authored by SouraVX).
[flang][OpenMP] Upstream lowering of OpenMP `Flush` construct
Oct 23 2020, 8:40 AM
SouraVX closed D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
Oct 23 2020, 8:39 AM · Restricted Project, Restricted Project
SouraVX added inline comments to D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
Oct 23 2020, 8:34 AM · Restricted Project, Restricted Project
SouraVX updated the diff for D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.

Removed ununsed variable.

Oct 23 2020, 8:21 AM · Restricted Project, Restricted Project
SouraVX added inline comments to D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
Oct 23 2020, 8:14 AM · Restricted Project, Restricted Project
SouraVX added a comment to D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.

After this patch both LLVM Master and FIR-dev branches will be in sync.

Oct 23 2020, 8:12 AM · Restricted Project, Restricted Project
SouraVX retitled D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct from [flang][OpenMP] Upstream lowering of `FlushOp` clauses to [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
Oct 23 2020, 8:09 AM · Restricted Project, Restricted Project
SouraVX retitled D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct from [flang][OpenMP] Upstream lowering of `ParallelOp` clauses to [flang][OpenMP] Upstream lowering of `FlushOp` clauses.
Oct 23 2020, 8:08 AM · Restricted Project, Restricted Project
SouraVX requested review of D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
Oct 23 2020, 8:07 AM · Restricted Project, Restricted Project
SouraVX committed rG1d328446bf92: [flang][OpenMP] Upstream lowering of `ParallelOp` clauses (authored by SouraVX).
[flang][OpenMP] Upstream lowering of `ParallelOp` clauses
Oct 23 2020, 7:52 AM
SouraVX closed D89769: [flang][OpenMP] Upstream lowering of `ParallelOp` clauses.
Oct 23 2020, 7:51 AM · Restricted Project, Restricted Project

Oct 22 2020

SouraVX added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Thanks for the patch and adding the unit-test for the same. This API is still un-used(directly) (classic flang uses it's own way to construct this.).
The new Flang is the planned consumer for it, Although since most CodeGen part of new Flang is still lives downstream. There's not much we can do about it WRT to debug-info and these API utilization.

Oct 22 2020, 9:48 AM · Restricted Project
SouraVX accepted D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Thanks for your patience. LGTM! at least the part I reviewed. Though I would vote for having another approval(From some senior folks in community)

Oct 22 2020, 9:19 AM · Restricted Project, Restricted Project, Restricted Project

Oct 21 2020

SouraVX added a project to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder: Restricted Project.
Oct 21 2020, 1:17 AM · Restricted Project, Restricted Project

Oct 20 2020

SouraVX updated the diff for D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Oct 20 2020, 3:55 AM · Unknown Object (Project)

Oct 19 2020

SouraVX requested review of D89769: [flang][OpenMP] Upstream lowering of `ParallelOp` clauses.
Oct 19 2020, 11:49 PM · Restricted Project, Restricted Project

Oct 16 2020

SouraVX abandoned D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.

Thanks @kiranchandramohan for helping out in this :). I'm abandoning this in favor of your approach. (Updating the PR also)
Thanks @tskeith for suggestion, I'll take a note of this.

Oct 16 2020, 9:08 AM · Restricted Project, Unknown Object (Project), Restricted Project
SouraVX updated subscribers of D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.
Oct 16 2020, 8:55 AM · Restricted Project, Restricted Project, Restricted Project
SouraVX added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.

Thanks @kiranchandramohan for suggestion. I already tried this thing(didn't worked out).
Unless I'm missing something: There's a type mismatch while interfacing this function. Here's the snippet of usability

case Fortran::parser::OmpProcBindClause::Type::Master:
          parallelOp.proc_bind_valAttr(firOpBuilder.getStringAttr(
           omp::stringifyClauseProcBindKind(procBindClause->v)));
          break;

Error:

error: cannot convert ‘const Fortran::parser::OmpProcBindClause::Type’ to ‘mlir::omp::ClauseProcBindKind’ for argument ‘1’ to ‘llvm::StringRef mlir::omp::stringifyClauseProcBindKind(mlir::omp::ClauseProcBindKind)’
              omp::stringifyClauseProcBindKind(procBindClause->v)));

An alternative solution would be: (but it's hard coding) ? (do you vote for this?)

case Fortran::parser::OmpProcBindClause::Type::Master:
          parallelOp.proc_bind_valAttr(firOpBuilder.getStringAttr(
           StringRef("master")));
          break;
Oct 16 2020, 7:57 AM · Restricted Project, Unknown Object (Project), Restricted Project
SouraVX added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.

Ping! @ all reviewers.

Oct 16 2020, 7:24 AM · Restricted Project, Unknown Object (Project), Restricted Project

Oct 15 2020

SouraVX added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Oct 15 2020, 8:22 AM · Unknown Object (Project)

Oct 14 2020

SouraVX added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.

I guess @clementval or @rriddle can approve the new extra functions added based on its need in Flang parse-tree lowering or on similar usage for StrEnumAttributes in rest of MLIR.

Snippet of usability from an upcoming/in-progress patch.

 switch (procBindClause->v) {
+                     case Fortran::parser::OmpProcBindClause::Type::Master:
+                     parallelOp.proc_bind_valAttr(firOpBuilder.getStringAttr(parallelOp.getProcBindValueMasterAttrName()));
+                             break;
+                     case Fortran::parser::OmpProcBindClause::Type::Close:
+                     parallelOp.proc_bind_valAttr(firOpBuilder.getStringAttr(parallelOp.getProcBindValueCloseAttrName()));
+                             break;
+                     case Fortran::parser::OmpProcBindClause::Type::Spread:
+                     parallelOp.proc_bind_valAttr(firOpBuilder.getStringAttr(parallelOp.getProcBindValueSpreadAttrName()));
+                             break;

Aside from this, Should we promote/remodel these attributes as UnitAttr? What do you guys think?

I feel the current modelling as an Optional StrEnumAttribute is fine here. proc_bind and default takes a set of values which are best captured by this modelling. If we have these as unit attributes then all the values can occur at the same time unless disabled using the verifier.

Oct 14 2020, 8:05 PM · Restricted Project, Unknown Object (Project), Restricted Project

Oct 13 2020

SouraVX retitled D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp` from [MLIR, OpenMP] Remodel `proc_bind_kind` clause as a unit attribute to [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.
Oct 13 2020, 10:21 PM · Restricted Project, Unknown Object (Project), Restricted Project
SouraVX updated the diff for D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.

Ah, potential oversight of details(Sorry for that!). Anyway I've rolled back to initial version and introduced some extra declaration that can be used by Flang(once this patch is in) while lowering.
Aside from this, Should we promote/remodel these attributes as UnitAttr? What do you guys think?

Oct 13 2020, 10:20 PM · Restricted Project, Unknown Object (Project), Restricted Project
SouraVX added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.

What kind of issues? This seems like a regression in terms of usability. Can you describe in detail the problems that you were having?

Oct 13 2020, 1:53 PM · Restricted Project, Unknown Object (Project), Restricted Project
SouraVX added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.

If we agreed upon this, the next step would be to remodel default clause as UnitAttr also.

Oct 13 2020, 1:39 PM · Restricted Project, Unknown Object (Project), Restricted Project
SouraVX requested review of D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.
Oct 13 2020, 1:36 PM · Restricted Project, Unknown Object (Project), Restricted Project
SouraVX added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Thanks for the patch! Overall it's in pretty nice state and conformant to design highlighted.
Could you please clang-format this patch, There are lot of lint warning that causes lot of noise while reviewing.
Couple of NIT comments inline. I've tried marking all but, Could you please finish comments with period.

Oct 13 2020, 3:15 AM · Restricted Project, Restricted Project, Restricted Project

Oct 12 2020

SouraVX added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 12 2020, 7:04 AM · Restricted Project, debug-info
SouraVX added a reviewer for D89218: [DebugInfo] Support for DW_TAG_generic_subrange: schweitz.
Oct 12 2020, 7:04 AM · Restricted Project, debug-info

Oct 9 2020

SouraVX added inline comments to D88965: [Flang][OpenMP] Rework parser changes for OpenMP atomic construct..
Oct 9 2020, 9:24 AM · Restricted Project, Restricted Project
SouraVX added inline comments to D88965: [Flang][OpenMP] Rework parser changes for OpenMP atomic construct..
Oct 9 2020, 5:29 AM · Restricted Project, Restricted Project

Oct 7 2020

SouraVX added a project to D88628: [flang][openacc] Fix semantic check for wait and atomic directives: Restricted Project.
Oct 7 2020, 8:13 AM · Restricted Project, Restricted Project
SouraVX accepted D88720: [OpenMP][MLIR] Fix for nested parallel regions.

Thanks for the patch. You may want to wait for @jdoerfert for final sign off!

Oct 7 2020, 8:02 AM · Unknown Object (Project)
SouraVX added inline comments to D88720: [OpenMP][MLIR] Fix for nested parallel regions.
Oct 7 2020, 12:16 AM · Unknown Object (Project)

Oct 6 2020

SouraVX accepted D88909: [NFC][flang] Introduce new helper TODO macro for further development.

Thanks for the patch!
NIT:
A more reasonable commit message could be:
[NFCI][flang] Introduce new helper TODO for further development
Or something similar(aligned to intent) :)

Oct 6 2020, 10:12 AM · Restricted Project, Restricted Project

Oct 5 2020

SouraVX updated subscribers of D88706: [OpenMP][MLIR] WIP : Fix for AllocaIP.

Here is a question regarding allocas in the llvm dialect; by the time they are translated to llvm ir proper, are they already located in the entry block in the dialect itself, or are they located in different places but you have something like an AllocaIP where you move allocas to entry block during the translation to proper llvm IR?
What is FIR planning to do about their stack allocations? if they are not guaranteeing it's in the entry BB then that's an issue.

AFAIK both of these cases we end up having alloca in the entry block.
@schweitz can confirm this WRT FIR.

Oct 5 2020, 12:40 AM · Restricted Project, Unknown Object (Project)

Oct 4 2020

SouraVX added inline comments to D88706: [OpenMP][MLIR] WIP : Fix for AllocaIP.
Oct 4 2020, 11:02 PM · Restricted Project, Unknown Object (Project)

Oct 2 2020

SouraVX added inline comments to D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.
Oct 2 2020, 12:51 PM · Restricted Project, Restricted Project, Unknown Object (Project)
SouraVX added a comment to D88720: [OpenMP][MLIR] Fix for nested parallel regions.

@SouraVX In this patch I have removed the OpenMPIRBuilder alloca changes. This contains only the changes to in ModuleTranslation and it seems to work fine. Can you check at your end as well as with the master Operation?

Oct 2 2020, 12:16 PM · Unknown Object (Project)

Sep 29 2020

SouraVX accepted D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

Since it's already approved, feel free to remove test case modification and commit no need for another revision :)
EDIT: if other reviewers comments are already addressed.

Sep 29 2020, 4:44 AM · Unknown Object (Project)

Sep 25 2020

SouraVX committed rGd2f1f530430e: [flang][OpenMP] Place the insertion point to the start of the block (authored by SouraVX).
[flang][OpenMP] Place the insertion point to the start of the block
Sep 25 2020, 11:27 AM
SouraVX closed D88221: [flang][OpenMP] Place the insertion point to the start of the block.
Sep 25 2020, 11:27 AM · Restricted Project, Restricted Project

Sep 24 2020

SouraVX retitled D88221: [flang][OpenMP] Place the insertion point to the start of the block from [flang][OpenMP] Upstream OpenMP Parallel construct codegen support to [flang][OpenMP] Place the insertion point to the start of the block.
Sep 24 2020, 10:16 AM · Restricted Project, Restricted Project
SouraVX added a comment to D88221: [flang][OpenMP] Place the insertion point to the start of the block.

Are you alluding, that this review should be renamed as some "Upstream XXXX code from PR" and nothing else ?

Sep 24 2020, 7:43 AM · Restricted Project, Restricted Project
SouraVX added a comment to D88221: [flang][OpenMP] Place the insertion point to the start of the block.

This is not "codegen support" is it? That sounds like "we now support codegen of X". Maybe: "Fix XXX codegen insertion point placement"?

Sep 24 2020, 7:41 AM · Restricted Project, Restricted Project
SouraVX added a comment to D88221: [flang][OpenMP] Place the insertion point to the start of the block.

Please use a proper commit message and subject. Linking some other discussion is fine but it should be self contained.

Sorry, I should've done better. Now modified to convey the intent.

Sep 24 2020, 7:04 AM · Restricted Project, Restricted Project
SouraVX retitled D88221: [flang][OpenMP] Place the insertion point to the start of the block from [flang][OpenMP] Parallel region codegen support to [flang][OpenMP] Upstream OpenMP Parallel construct codegen support.
Sep 24 2020, 7:03 AM · Restricted Project, Restricted Project
SouraVX added a project to D88221: [flang][OpenMP] Place the insertion point to the start of the block: Restricted Project.
Sep 24 2020, 5:26 AM · Restricted Project, Restricted Project
SouraVX requested review of D88221: [flang][OpenMP] Place the insertion point to the start of the block.
Sep 24 2020, 5:26 AM · Restricted Project, Restricted Project

Sep 23 2020

SouraVX committed rGdfa9065ad778: [NFCI][flang] Renamed a variable name to a more descriptive name (authored by SouraVX).
[NFCI][flang] Renamed a variable name to a more descriptive name
Sep 23 2020, 5:54 AM
SouraVX added a comment to D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct.

Removed unit-test in be1197c403b22291e35cbc5e96788860ceabd40c

Sep 23 2020, 5:47 AM · Restricted Project, Restricted Project
SouraVX committed rGbe1197c403b2: [flang] Removed OpenMP lowering unittests (authored by SouraVX).
[flang] Removed OpenMP lowering unittests
Sep 23 2020, 5:47 AM
SouraVX committed rG34b08487f04a: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct (authored by SouraVX).
[OpenMP][flang]Lower NUM_THREADS clause for parallel construct
Sep 23 2020, 5:28 AM
SouraVX closed D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct.
Sep 23 2020, 5:27 AM · Restricted Project, Restricted Project
SouraVX updated the summary of D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct.
Sep 23 2020, 5:25 AM · Restricted Project, Restricted Project
SouraVX added a comment to D87549: [OpenMP][MLIR] Add assembly format for master op.

Reverse Ping! Could you please land this ?

Sep 23 2020, 1:00 AM · Unknown Object (Project)

Sep 22 2020

SouraVX updated the diff for D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct.
Sep 22 2020, 12:57 AM · Restricted Project, Restricted Project
SouraVX added a reviewer for D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct: jeanPerier.
Sep 22 2020, 12:28 AM · Restricted Project, Restricted Project
SouraVX added a comment to D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct.

Thanks @jeanPerier for reviewing this!

Sep 22 2020, 12:27 AM · Restricted Project, Restricted Project

Sep 21 2020

SouraVX added a project to D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs.: Restricted Project.
Sep 21 2020, 12:30 AM · Restricted Project, Restricted Project, Restricted Project
SouraVX added a reviewer for D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs.: schweitz.
Sep 21 2020, 12:29 AM · Restricted Project, Restricted Project, Restricted Project
SouraVX added reviewers for D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs.: kiranktp, SouraVX.
Sep 21 2020, 12:29 AM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2020

SouraVX committed rG000eb1f314c1: [docs][flang] Fix typos (authored by SuJunda).
[docs][flang] Fix typos
Sep 20 2020, 10:36 PM
SouraVX closed D87885: [docs][flang] Fix typos.
Sep 20 2020, 10:36 PM · Restricted Project, Restricted Project
SouraVX added a comment to D87885: [docs][flang] Fix typos.
Sep 20 2020, 10:26 PM · Restricted Project, Restricted Project
SouraVX retitled D87885: [docs][flang] Fix typos from [docs] Fix typos to [docs][flang] Fix typos.
Sep 20 2020, 10:24 PM · Restricted Project, Restricted Project
SouraVX accepted D87885: [docs][flang] Fix typos.

LGTM, thanks!

Sep 20 2020, 10:23 PM · Restricted Project, Restricted Project

Sep 18 2020

SouraVX added inline comments to D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct.
Sep 18 2020, 2:08 PM · Restricted Project, Restricted Project