Page MenuHomePhabricator

SouraVX (Sourabh Singh Tomar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2019, 11:05 PM (49 w, 19 h)

Recent Activity

Today

SouraVX added reviewers for D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables: jmorse, davide.
Wed, Aug 5, 12:30 PM · Restricted Project
SouraVX added a comment to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.

How does the start scope compare to the location range of the variable, and the scope range of the enclosing scope?

DW_AT_start_scope value in contiguous scope case is offset from start of the Lex Block(i.e low_pc of enclosing scope).

Wed, Aug 5, 12:29 PM · Restricted Project
SouraVX added a comment to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.

Sorry for the confusion/churn. This is the resultant DWARF(for the variable of interest) for this test case.

0x0000007a:       DW_TAG_variable
                    **DW_AT_location      (0x00000000:
                       [0x0000000000401178, 0x00000000004011c1): DW_OP_breg6 RBP-24)** // This is what causing increased in location list(even at "-O0 -g")
                    DW_AT_name  ("Local")
                    DW_AT_decl_file     ("/Scope.c")
                    DW_AT_decl_line     (7)
                    DW_AT_type  (0x0000008f "int")
                    DW_AT_start_scope   (0x00000017)
Wed, Aug 5, 9:49 AM · Restricted Project

Yesterday

SouraVX added a comment to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.

According to the --show-section-sizes output, the .debug_loc has been increased?

Tue, Aug 4, 8:38 AM · Restricted Project
SouraVX added a comment to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.

LGTM(at least the part I reviewed). But it would be good to wait for @kiranchandramohan and IIRC @ftynse has contributed a lot in GPU dialect. So it would be nice to have there views/thoughts also.
Thanks for your patience :)

Tue, Aug 4, 8:04 AM · Restricted Project
SouraVX added a reviewer for D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables: djtodoro.
Tue, Aug 4, 6:14 AM · Restricted Project

Mon, Aug 3

SouraVX added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Mon, Aug 3, 12:24 PM · Restricted Project
SouraVX added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Mon, Aug 3, 12:01 PM · Restricted Project

Sun, Aug 2

SouraVX reopened D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.
Sun, Aug 2, 12:30 PM · debug-info, Restricted Project
SouraVX added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

It's not just endiannes that is causing trouble to PPC target. Looking at a comment regarding PPC target's long double representation in AsmPrinter.cpp

// PPC's long double has odd notions of endianness compared to how LLVM
// handles it: p[0] goes first for *big* endian on PPC.

This patch does not handle this, I'll see if we can fix this up without too many changes, otherwise I'll file a new review covering all scenarios endianess and this target specific.

Sun, Aug 2, 12:15 PM · debug-info, Restricted Project

Sat, Aug 1

SouraVX updated subscribers of D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

It seems to me this is reverted again in 7c182663a857fc87552fa2861c7f94046d55845e . Reverting author @amyk didn't updated here.
I'll see if I can get around the endianness, if that's the only issue ?

Sat, Aug 1, 11:44 PM · debug-info, Restricted Project
SouraVX added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Sat, Aug 1, 10:31 AM · Restricted Project
SouraVX added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Sat, Aug 1, 9:55 AM · Restricted Project

Fri, Jul 31

SouraVX committed rGbf812c145ca2: [flang][OpenMP] Added initial support for lowering OpenMP parallel construct (authored by SouraVX).
[flang][OpenMP] Added initial support for lowering OpenMP parallel construct
Fri, Jul 31, 11:30 AM
SouraVX closed D84965: [flang][OpenMP] Added initial support for lowering OpenMP parallel construct.
Fri, Jul 31, 11:30 AM · Restricted Project
SouraVX added inline comments to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.
Fri, Jul 31, 6:26 AM · Restricted Project
SouraVX committed rG793c29a267ca: [MLIR,OpenMP][NFCI] Removed loop for accessing regions of ParallelOp (authored by SouraVX).
[MLIR,OpenMP][NFCI] Removed loop for accessing regions of ParallelOp
Fri, Jul 31, 6:23 AM
SouraVX closed D85008: [MLIR,OpenMP][NFCI] Removed loop for accessing regions of ParallelOp.
Fri, Jul 31, 6:23 AM · Restricted Project
SouraVX added a comment to D84965: [flang][OpenMP] Added initial support for lowering OpenMP parallel construct.

If this lowers to the OpenMP MLIR Dialect, would it be possible to have some lit codegen tests on the generated IR from a sample input file? Unless not all the necessary infrastructure is in yet for this.

Fri, Jul 31, 6:14 AM · Restricted Project
SouraVX added a comment to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.

Please ignore these test cases dwarfdump-dataLocationVar.ll and dwarfdump-dataLocationExp.ll. These were generated with flang at the time when it was having bug of emitting dummy LexicalBlock. I've an approved PR in flang for this, once merged I'll correct these test cases(separately).

Fri, Jul 31, 3:46 AM · Restricted Project
SouraVX requested review of D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.
Fri, Jul 31, 3:43 AM · Restricted Project
SouraVX requested review of D85008: [MLIR,OpenMP][NFCI] Removed loop for accessing regions of ParallelOp.
Fri, Jul 31, 1:19 AM · Restricted Project

Thu, Jul 30

SouraVX requested review of D84965: [flang][OpenMP] Added initial support for lowering OpenMP parallel construct.
Thu, Jul 30, 11:33 AM · Restricted Project

Wed, Jul 29

SouraVX accepted D84798: [OpenMP,MLIR] Translation of parallel operation: num_threads, if clauses 3/n.

LGTM. Thanks!

Wed, Jul 29, 7:24 AM · Restricted Project

Thu, Jul 23

SouraVX added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

There was another failure in WebAssembly debug info test case caught by build-bot. That's also fixed with commit id mentioned.
Once the change stabilizes, I plan to do a quick refactoring(wherever applicable WRT this change).

Thu, Jul 23, 3:14 AM · debug-info, Restricted Project
SouraVX committed rG8998f8ab6630: [DebugInfo] Attempt to fix regression test failure after 59a76d957a2603ee0 (authored by SouraVX).
[DebugInfo] Attempt to fix regression test failure after 59a76d957a2603ee0
Thu, Jul 23, 2:40 AM
SouraVX added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

Temporarily reverted in 9d2da6759b4d05d834371bcaaa8fc3d9b3385b18.
Due to failing/assertion in test case in Sparc Backend.
test/DebugInfo/Sparc/subreg.ll

Thu, Jul 23, 1:32 AM · debug-info, Restricted Project
SouraVX committed rG59a76d957a26: Re-apply:" Emit DW_OP_implicit_value for Floating point constants" (authored by SouraVX).
Re-apply:" Emit DW_OP_implicit_value for Floating point constants"
Thu, Jul 23, 1:31 AM

Wed, Jul 22

SouraVX added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

Temporarily reverted in 9d2da6759b4d05d834371bcaaa8fc3d9b3385b18.
Due to failing/assertion in test case in Sparc Backend.
test/DebugInfo/Sparc/subreg.ll

Wed, Jul 22, 8:25 PM · debug-info, Restricted Project
SouraVX committed rG9d2da6759b4d: Revert "[DebugInfo] Emit DW_OP_implicit_value for Floating point constants" (authored by SouraVX).
Revert "[DebugInfo] Emit DW_OP_implicit_value for Floating point constants"
Wed, Jul 22, 8:23 PM
SouraVX added a reverting change for rG6b55a95898e9: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants: rG9d2da6759b4d: Revert "[DebugInfo] Emit DW_OP_implicit_value for Floating point constants".
Wed, Jul 22, 8:23 PM
SouraVX abandoned D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`.

Fixed By: https://reviews.llvm.org/D84278

Wed, Jul 22, 7:05 PM · debug-info, Restricted Project
SouraVX abandoned D80945: [DebugInfo] Fix a fatal error originating from split-macro support.

Fixed By: https://reviews.llvm.org/D84278

Wed, Jul 22, 7:05 PM · debug-info, Restricted Project
SouraVX abandoned D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present.

Fixed by: https://reviews.llvm.org/D84278

Wed, Jul 22, 7:05 PM · debug-info, Restricted Project
SouraVX committed rG6b55a95898e9: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants (authored by SouraVX).
[DebugInfo] Emit DW_OP_implicit_value for Floating point constants
Wed, Jul 22, 6:52 PM
SouraVX closed D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.
Wed, Jul 22, 6:52 PM · debug-info, Restricted Project
SouraVX committed rG9e4ab439c2ee: [flang][OpenMP] Added support for lowering OpenMP taskyield construct (authored by SouraVX).
[flang][OpenMP] Added support for lowering OpenMP taskyield construct
Wed, Jul 22, 6:48 PM
SouraVX closed D84350: [flang][OpenMP] Added support for lowering OpenMP taskyield construct.
Wed, Jul 22, 6:47 PM · Restricted Project
SouraVX added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

I think I'd be happy with emitting a warning to llvm::dbgs(), or an assembler comment (if that is available here, not sure).

Here, I've used LLVM_DEBUG so that it won't hurt any thing. This seems Okay to you ?

Wed, Jul 22, 12:20 PM · debug-info, Restricted Project
SouraVX retitled D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants from [DebugInfo] Added support for DW_OP_implicit_value in llvm to [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.
Wed, Jul 22, 12:18 PM · debug-info, Restricted Project
SouraVX updated the diff for D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

Addressed @aprantl review comments. Thanks for this!

Wed, Jul 22, 12:17 PM · debug-info, Restricted Project
Herald added a project to D84350: [flang][OpenMP] Added support for lowering OpenMP taskyield construct: Restricted Project.
Wed, Jul 22, 11:14 AM · Restricted Project
SouraVX added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

For cases other than those gracefully handled(`float, double, long double) for DW_OP_implicit_value I'm considering a hard error sort of assert/llvm_unreachable or 2nd option could be just bail out early.

Wed, Jul 22, 10:29 AM · debug-info, Restricted Project
SouraVX added inline comments to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.
Wed, Jul 22, 6:30 AM · debug-info, Restricted Project
SouraVX accepted D84278: DebugInfo: Use debug_line.dwo for debug_macro.dwo.

Thank you so much @dblaikie for this. Admittedly, for all the direction I've been digging, missed this one :)
The catch here is that getDwoLineTable(U)->getFile(... this will enable the line table through MCDwarf interface, so we don't have/need to rely in DwarfTypeUnit interface for enabling line table.
Anyways, I'm planning to abandon all the revisions associated with this. IMHO D82084 is also not needed(since you did it without touching that) so we can leave it until there is actual need/situation ?

Wed, Jul 22, 6:27 AM · Restricted Project
SouraVX updated the diff for D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

Addressed review comments by @aprantl, Thanks for this.
Changes:

  • Edited the summary to reflect the intention.
  • This patch switches to DW_OP_implicit_value for all the floating point constants float, double and long double, for demonstration purposes, considering 1 byte space saving(discussed above).
  • Changes are still a bit conservative, in a sense emission of DW_OP_implicit_value is guarded with additional check for debugger tunning.

This will ensure that, we didn't break any existing machinery/consumers.

Wed, Jul 22, 6:16 AM · debug-info, Restricted Project

Mon, Jul 20

SouraVX added inline comments to D84195: [flang][openacc] Skeleton for OpenACC construct lowering.
Mon, Jul 20, 9:31 PM · Unknown Object (Project), Restricted Project
SouraVX committed rG2d10258a31a6: [DebugInfo] Support for DW_AT_associated and DW_AT_allocated. (authored by alok).
[DebugInfo] Support for DW_AT_associated and DW_AT_allocated.
Mon, Jul 20, 7:25 AM
SouraVX closed D83544: [DebugInfo] Support for DW_AT_associated and DW_AT_allocated..
Mon, Jul 20, 7:25 AM · Restricted Project, debug-info

Sat, Jul 18

SouraVX updated the diff for D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`.

Tried one more time disregarding both the approach followed previously.
This time finally worked out(in a much cleaner way).
It exposes getDwoLineTable private method. But IMO that's needed
anyways, since it will used/needed subsequently in D81476.

Sat, Jul 18, 3:18 AM · debug-info, Restricted Project

Fri, Jul 17

SouraVX added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

@aprantl @probinson could you folks please provide a quick comment on this as a whole ?
Meanwhile, I also have a patch(locally) which switches to DW_OP_implicit_value for all the floating point constants float, double, long double working fantastic. For correctness checked that executables are debuggable with GDB.

Fri, Jul 17, 12:05 PM · debug-info, Restricted Project
SouraVX committed rG079b49b3fb22: [flang][OpenMP] Added support for lowering OpenMP taskwait construct (authored by SouraVX).
[flang][OpenMP] Added support for lowering OpenMP taskwait construct
Fri, Jul 17, 7:32 AM
SouraVX closed D83983: [flang][OpenMP] Added support for lowering OpenMP taskwait construct.
Fri, Jul 17, 7:32 AM · Unknown Object (Project), Restricted Project

Thu, Jul 16

SouraVX added a reviewer for D83983: [flang][OpenMP] Added support for lowering OpenMP taskwait construct: clementval.
Thu, Jul 16, 11:01 PM · Unknown Object (Project), Restricted Project
Herald added a project to D83983: [flang][OpenMP] Added support for lowering OpenMP taskwait construct: Restricted Project.
Thu, Jul 16, 1:10 PM · Unknown Object (Project), Restricted Project
SouraVX added a comment to D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`.

@dblaikie and other reviewers, these changes seems Okay to you folks ?

Thu, Jul 16, 8:59 AM · debug-info, Restricted Project

Tue, Jul 14

SouraVX added inline comments to D83659: [flang][OpenMP] upstream OpenMP lowering.
Tue, Jul 14, 5:32 AM · Restricted Project, Restricted Project, Unknown Object (Project)
SouraVX committed rG3d0b76022df6: [flang][OpenMP] upstream OpenMP lowering (authored by SouraVX).
[flang][OpenMP] upstream OpenMP lowering
Tue, Jul 14, 5:32 AM
SouraVX closed D83659: [flang][OpenMP] upstream OpenMP lowering.
Tue, Jul 14, 5:32 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Mon, Jul 13

SouraVX updated the summary of D83659: [flang][OpenMP] upstream OpenMP lowering.
Mon, Jul 13, 12:11 PM · Restricted Project, Restricted Project, Unknown Object (Project)
SouraVX added inline comments to D83659: [flang][OpenMP] upstream OpenMP lowering.
Mon, Jul 13, 12:08 PM · Restricted Project, Restricted Project, Unknown Object (Project)
SouraVX updated the diff for D83659: [flang][OpenMP] upstream OpenMP lowering.

Thanks @kiranchandramohan for reviewing this.

  • Addressed nit comments.
  • updated commit message accordingly.
Mon, Jul 13, 12:07 PM · Restricted Project, Restricted Project, Unknown Object (Project)
Herald added a project to D83659: [flang][OpenMP] upstream OpenMP lowering: Restricted Project.
Mon, Jul 13, 12:25 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Sat, Jul 11

SouraVX added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

Sure, I understand the need having specific name(and my mistake of choosing a generic name addImplicitValue for the purpose of this patch). I've noted down and work on your inputs/concerns and revise once @aprantl and @probinson also have a look on it. Thanks again for your inputs :)

Sat, Jul 11, 12:18 PM · debug-info, Restricted Project
SouraVX added a comment to D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.

Thanks @dblaikie for your feedback!

Not sure it's worth committing such a narrow implementation - might be worth a bit of generalization even in this first patch?

This operation(as you might have noticed) has limited usage, since DW_OP_stack_value and friends fits in other cases very well. This is specifically made to cater needs(such as in this case) where the variable size is bigger than (size of address). This will cater all the needs in math(HPC) based applications where usage of long double is ubiquitous.

looks to be very specific to long double right now (but without any assertions, API features, or comments to enforce that restriction) - and in the DwarfDebug.cpp caller, which could presumably be used for all constant values, maybe (not sure if that would be a good thing or not - haven't looked at the alternatives, etc))

Yes, that's very specific and you'll notice that it has very strict enforcement requirements isConstrantFP followed by if (AP.getDwarfVersion() >= 4 && RawBytes.getBitWidth() == 80)(making sure we don't mess up existing infra).
For the documentation/comments part, admittedly I didn't put any behavior/requirement specifics in the declaration, However the definition part is fully documented and self-explanatory(IMO). Should we put some brief comments there(declaration part) too ?

Sat, Jul 11, 10:33 AM · debug-info, Restricted Project

Fri, Jul 10

SouraVX created D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants.
Fri, Jul 10, 8:19 AM · debug-info, Restricted Project

Thu, Jul 9

SouraVX added a comment to D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`.

Apologies for If I'm pinging too frequently :) . Gentle Ping to all reviewers again! :)

Thu, Jul 9, 4:03 AM · debug-info, Restricted Project

Tue, Jul 7

SouraVX added a comment to D82975: [DebugInfo] Allow GNU macro extension to be emitted.

I think if it's about compatibility(analogous behavior with GCC), existing infra is Okay/Fine(Since same encodings are used). We just need to emit the .debug_macro section with version 4 and teach the llvm-dwarfdump to parse it correctly.

One difference though is that the GNU extension does not have anything like the strx entries that LLVM currently emits: https://github.com/gcc-mirror/gcc/blob/master/include/dwarf2.h#L425, so I assume we still need code to emit the strp entries when targeting DWARF 4?

Likely - but might want to check what GCC does - maybe it uses some kind of strx encoding that's not documented, etc.

My recollection is that .debug_macro was invented independently of the strx forms so the prototype probably wouldn't have used them. Easy enough to check whether GCC's -fdebug-macro with v4 is emitting a .debug_str_offsets section.

LLVM wouldn't be using strx forms from .debug_info for v4, and would have no other reason to emit .debug_str_offsets, so I wouldn't want LLVM to use them in a v4 compatibility mode .debug_macro section either.

GCC certainly seems to produce some kind of debug_macro.dwo section (& binutils dwp supports it in the index, if I recall correctly) using some form llvm-dwarfdump currently doesn't understand:

$ g++-tot -g3 main.cpp -c -gsplit-dwarf && llvm-objdump -h main.dwo | grep " \.debug"
  1 .debug_info.dwo        0000003c 0000000000000000 
  2 .debug_abbrev.dwo      0000003e 0000000000000000 
  3 .debug_macro.dwo       0000001e 0000000000000000 
  4 .debug_macro.dwo       00000364 0000000000000000 
  5 .debug_macro.dwo       00000013 0000000000000000 
  6 .debug_line.dwo        00000048 0000000000000000 
  7 .debug_str_offsets.dwo 000002d5 0000000000000000 
  8 .debug_str.dwo         00000e05 0000000000000000 
$ llvm-dwarfdump-tot main.dwo -debug-macro
main.dwo:       file format elf64-x86-64

.debug_macro.dwo contents:
0x00000000:
 - lineno: 19 macro: 
DW_MACINFO_invalid

I mean, I don't have strong feelings about supporting macro debug info in general, but if someone feels strongly about debug_macro GNU extension DWARFv4 support, there's certainly some GCC behavior that one could use to model the Split DWARF support for that off.

Tue, Jul 7, 12:56 AM · Restricted Project, debug-info

Jul 5 2020

SouraVX added a comment to D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`.

Gentle Ping :)

Jul 5 2020, 11:09 AM · debug-info, Restricted Project

Jul 2 2020

SouraVX added a comment to D82693: [flang] Upstream two FIR transformation passes.

This is the nature of this process we're on. We're being asked to upstream tiny bits with each diff, the smaller the better. The reality is that however one slices it, the code will always be interrelated. In order to keep the diffs small, some sort of compromise must be made

How about series/chain of patches filed together with dependencies[Parent-Child] specified ? This could help in review/tracking process.

Jul 2 2020, 12:29 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jul 1 2020

SouraVX updated subscribers of D82972: [DebugInfo] Introduce GNU macro extension entry encodings.
Jul 1 2020, 10:16 PM · Restricted Project, debug-info
SouraVX added a comment to D82972: [DebugInfo] Introduce GNU macro extension entry encodings.

Do we really need this ?, Please have a look at https://sourceware.org/legacy-ml/gdb-patches/2017-02/msg00528.html
IMO, it would be unwise to commit it till the discussion thread in D82975 converges ?

Jul 1 2020, 10:11 PM · Restricted Project, debug-info
SouraVX updated subscribers of D82975: [DebugInfo] Allow GNU macro extension to be emitted.

When you say 'by default' - do you mean by default when the user requests macro debug info (via -fdebug-macro) or by default without any extra flag?
& what does GCC do? Does it have a way to emit the standard debug_macinfo in v4 and below? Or does it always emit the debug_macro GNU extension?

Jul 1 2020, 10:11 PM · Restricted Project, debug-info

Jun 28 2020

SouraVX accepted D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.

Overall this seems great Thanks! I have one minor concern:
This patch seems to do 2 things: Support for nested parallel regions(which was crashing earlier) and some infrastructure change(introducing AllocBuilder..).
I'm not sure of this, but is it possible to separate these as 2( or more) patches ? 1 for Nested parallel region support and other patch as a infrastructure change ?

I'll try.

Jun 28 2020, 1:27 PM · Restricted Project, Restricted Project

Jun 26 2020

SouraVX added a comment to D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`.

@dblaikie Are you Convinced/Okay with explanation and the overall changes.

Jun 26 2020, 4:50 AM · debug-info, Restricted Project
SouraVX added a comment to D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.

Overall this seems great Thanks! I have one minor concern:
This patch seems to do 2 things: Support for nested parallel regions(which was crashing earlier) and some infrastructure change(introducing AllocBuilder..).
I'm not sure of this, but is it possible to separate these as 2( or more) patches ? 1 for Nested parallel region support and other patch as a infrastructure change ?

Jun 26 2020, 4:18 AM · Restricted Project, Restricted Project

Jun 19 2020

SouraVX added inline comments to D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`.
Jun 19 2020, 1:02 AM · debug-info, Restricted Project

Jun 18 2020

SouraVX added inline comments to D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`.
Jun 18 2020, 1:06 PM · debug-info, Restricted Project
SouraVX planned changes to D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present.

Based on the feedback by @dblaikie (Thanks for this)! Filed separate refactoring revison D82084. Planning to revise this after we reach consensus on that(D82084).
Thanks!

Jun 18 2020, 5:24 AM · debug-info, Restricted Project
SouraVX created D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`.
Jun 18 2020, 5:24 AM · debug-info, Restricted Project

Jun 15 2020

SouraVX added inline comments to D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present.
Jun 15 2020, 1:46 PM · debug-info, Restricted Project
SouraVX added a comment to D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present.

Thanks @dblaikie for reviewing this!

Jun 15 2020, 1:19 PM · debug-info, Restricted Project
SouraVX added a comment to D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present.

Ping @ all reviewers!

Jun 15 2020, 12:04 PM · debug-info, Restricted Project
SouraVX accepted D81844: [DebugInfo] Support parsing and dumping of DWARF64 macro units..

LGTM, Thanks! Please wait for other reviewers, in case if they've any comments.

Jun 15 2020, 9:13 AM · debug-info, Restricted Project

Jun 10 2020

SouraVX added inline comments to D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present.
Jun 10 2020, 10:07 PM · debug-info, Restricted Project
SouraVX updated the diff for D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present.

Addressed @probinson review comments. Thanks for this!

Jun 10 2020, 10:06 PM · debug-info, Restricted Project

Jun 9 2020

SouraVX planned changes to D80945: [DebugInfo] Fix a fatal error originating from split-macro support.

I've raised another review D81476 for addressing this. Will revise this afterwards.
Thank You.

Jun 9 2020, 9:19 AM · debug-info, Restricted Project
SouraVX added a reviewer for D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present: jini.susan.george.
Jun 9 2020, 9:19 AM · debug-info, Restricted Project
SouraVX created D81476: [DWARF5] Enable .debug_line.dwo section emission if macro info is present.
Jun 9 2020, 9:19 AM · debug-info, Restricted Project

Jun 1 2020

SouraVX added a comment to D80945: [DebugInfo] Fix a fatal error originating from split-macro support.

I don't think this field (debug_line_offset) is optional if the debug_macro.dwo section contains DW_MACRO_start_file: "If a DW_MACRO_start_file entry is present, the header contains a reference to the .debug_line section of the compilation."

Yes, but spec seems a bit ambiguous in stating this. "If zero, that field is omitted. Pg. 166, line 14-16", Not explicitly stating the fact/case where it should be always present.
And spec also doesn't say anything about explicit presence of debug_line.dwo when debug_macro.dwo is present, although it seems it should be present.

Jun 1 2020, 11:15 PM · debug-info, Restricted Project
SouraVX updated the diff for D80945: [DebugInfo] Fix a fatal error originating from split-macro support.

Added corrected test case.

Jun 1 2020, 12:25 PM · debug-info, Restricted Project
SouraVX added a project to D80945: [DebugInfo] Fix a fatal error originating from split-macro support: debug-info.
Jun 1 2020, 12:25 PM · debug-info, Restricted Project
SouraVX added reviewers for D80945: [DebugInfo] Fix a fatal error originating from split-macro support: probinson, dblaikie.
Jun 1 2020, 12:25 PM · debug-info, Restricted Project
SouraVX created D80945: [DebugInfo] Fix a fatal error originating from split-macro support.
Jun 1 2020, 12:25 PM · debug-info, Restricted Project

May 29 2020

SouraVX committed rG20c9bb44ec1a: [DWARF5] Added support for emission of .debug_macro.dwo section (authored by SouraVX).
[DWARF5] Added support for emission of .debug_macro.dwo section
May 29 2020, 10:50 PM
SouraVX closed D78866: [DWARF5] Added support for emission of .debug_macro.dwo section.
May 29 2020, 10:50 PM · Restricted Project, debug-info
SouraVX added a comment to D78866: [DWARF5] Added support for emission of .debug_macro.dwo section.

debug_macro.dwo section

.debug_macro.dwo

May 29 2020, 10:50 PM · Restricted Project, debug-info
SouraVX retitled D78866: [DWARF5] Added support for emission of .debug_macro.dwo section from [DWARF5] Added support for emission of debug_macro.dwo section to [DWARF5] Added support for emission of .debug_macro.dwo section.
May 29 2020, 10:50 PM · Restricted Project, debug-info
SouraVX committed rGb47403c0a4c5: [DWARF5] Replace emission of strp with stx forms in debug_macro section (authored by SouraVX).
[DWARF5] Replace emission of strp with stx forms in debug_macro section
May 29 2020, 12:01 PM
SouraVX committed rGe7102eed20d9: [DWARF5] Added support for .debug_macro.dwo section in llvm-dwarfdump (authored by SouraVX).
[DWARF5] Added support for .debug_macro.dwo section in llvm-dwarfdump
May 29 2020, 12:01 PM