Page MenuHomePhabricator

NoQ (Artem Dergachev)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 3 2015, 9:16 AM (280 w, 2 d)

Recent Activity

Tue, Jan 12

NoQ added inline comments to D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics..
Tue, Jan 12, 1:50 PM
NoQ updated the diff for D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics..

Add a few comments here and there.

Tue, Jan 12, 1:51 AM
NoQ requested review of D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics..
Tue, Jan 12, 1:50 AM

Mon, Jan 11

NoQ added a comment to D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result.

this would be a great flow-sensitive check for the clang static analyzer

Mon, Jan 11, 9:19 PM · Restricted Project, Restricted Project
NoQ added a comment to D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..

Yup, i'm sorry. I even saw this failure locally but was like "this test doesn't look familiar, probably someone else broke it" which i wouldn't have said if i looked at it for more than 1 second as it's strikingly obvious. My bad.

Mon, Jan 11, 7:18 AM · Restricted Project

Thu, Jan 7

NoQ added a comment to D92634: [Analyzer] Diagnose signed integer overflow.

My code seems to think that a variable print_count has the value INT_MAX for some reason

Thu, Jan 7, 2:48 AM · Restricted Project

Wed, Jan 6

NoQ added inline comments to D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..
Wed, Jan 6, 7:53 AM · Restricted Project
NoQ updated the diff for D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..

Drop broken attributes. Fix naming.

Wed, Jan 6, 7:53 AM · Restricted Project
NoQ added inline comments to D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..
Wed, Jan 6, 3:44 AM · Restricted Project
NoQ updated the diff for D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..

Handle conflicts across redeclarations! Fix typos and documentation formatting.

Wed, Jan 6, 3:44 AM · Restricted Project

Tue, Jan 5

NoQ added inline comments to D92634: [Analyzer] Diagnose signed integer overflow.
Tue, Jan 5, 1:04 AM · Restricted Project
NoQ added a comment to D92634: [Analyzer] Diagnose signed integer overflow.

This patch adds a new core checker. I wouldn't be comfortable enabling it by default without a much more careful evaluation (than a single lit test). In particular, i'm worried about false positives due to constraint solving issues and our incorrect cast representation - it sounds like both of these may disproportionally affect this checker. I also still wonder about "intentional" use of signed overflows; it's likely that some developers would prefer to silence the check. At least we should have a rough idea about how loud it is.

Tue, Jan 5, 12:59 AM · Restricted Project

Thu, Dec 24

NoQ accepted D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute.

Amazing, thank you. I'm happy with the analysis and i have nothing more to say really :)

Thu, Dec 24, 12:07 AM · Restricted Project

Wed, Dec 23

NoQ added inline comments to D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists.
Wed, Dec 23, 8:16 PM · Restricted Project
NoQ added inline comments to D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..
Wed, Dec 23, 5:54 PM · Restricted Project
NoQ updated the diff for D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..

Add an error for conflicting attributes!

Wed, Dec 23, 5:47 PM · Restricted Project

Tue, Dec 22

NoQ added inline comments to D93595: [analyzer] Fix extraction of punned and known scalar SVals.
Tue, Dec 22, 11:10 PM · Restricted Project
NoQ added inline comments to D93595: [analyzer] Fix extraction of punned and known scalar SVals.
Tue, Dec 22, 11:05 PM · Restricted Project
NoQ added a comment to D93595: [analyzer] Fix extraction of punned and known scalar SVals.

I think you've found a very nice and compact 50% solution to the problem. I didn't think of this while i was looking for a proper fix. Very nice.

Tue, Dec 22, 10:59 PM · Restricted Project
NoQ added a comment to D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute.

Add one gigantic comment on status kinds and the reasons behind some of the design choices

Tue, Dec 22, 10:13 PM · Restricted Project

Mon, Dec 21

NoQ accepted D93565: scan-view: Remove Reporter.py and associated AppleScript files.

Uhm, yeah, indeed. Let's remove it, thanks!

Mon, Dec 21, 1:14 PM · Restricted Project

Dec 17 2020

NoQ added inline comments to D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists.
Dec 17 2020, 6:58 PM · Restricted Project

Dec 11 2020

NoQ added inline comments to D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis..
Dec 11 2020, 11:09 AM · Restricted Project

Dec 9 2020

NoQ added inline comments to D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis..
Dec 9 2020, 10:02 AM · Restricted Project

Dec 1 2020

NoQ updated the diff for D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis..

Whoops, fix typos in header formalities.

Dec 1 2020, 2:16 PM · Restricted Project
NoQ requested review of D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis..
Dec 1 2020, 2:14 PM · Restricted Project
NoQ updated the diff for D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..

Fxd!

Dec 1 2020, 1:42 AM · Restricted Project
NoQ added inline comments to D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..
Dec 1 2020, 1:41 AM · Restricted Project

Nov 29 2020

NoQ accepted D92221: Don't delete default constructor of PathDiagnosticConsumerOptions.

Aha, ok then! Thanks for cleaning this up.

Nov 29 2020, 4:16 PM · Restricted Project

Nov 24 2020

NoQ added a comment to D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute.

A few random comments here and there as i slowly wrap my head around the overall analysis algorithm.

Nov 24 2020, 6:50 PM · Restricted Project

Nov 23 2020

NoQ added a comment to D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..

if the TCB-based functions are a small subset of the code then this attribute is better

Nov 23 2020, 11:55 PM · Restricted Project

Nov 20 2020

NoQ requested review of D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..
Nov 20 2020, 3:45 PM · Restricted Project

Nov 9 2020

NoQ added a comment to D52957: [analyzer] Teach CallEvent about C++17 aligned new..
In D52957#2379330, @NoQ wrote:

The argument value can be computed by taking the size of the type (and aligning to the requested alignment, i guess(?)) and multiplying it by array size (for which there is an expression) in case of array new. It'd be great to write down these computations once in the CallEvent class and then re-use them.

Should I provide them as member functions to the CXXAllocatorCall class?
Something like size_t getAlignment() and size_t getAllocationSize()?

Nov 9 2020, 2:04 PM

Nov 6 2020

NoQ added a comment to D52957: [analyzer] Teach CallEvent about C++17 aligned new..

You cannot have an argument expression because there's no argument expression anywhere in the AST. There's an argument, but it's not computed as a value of any syntactic expression. If there was no argument, getArgExpr(0) would have crashed; but it returns a nullptr which indicates that there's no expression to return.

Nov 6 2020, 9:00 AM

Nov 5 2020

NoQ accepted D90754: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup.

Looks great, thanks!

Nov 5 2020, 7:52 PM · Restricted Project
NoQ added a comment to D52957: [analyzer] Teach CallEvent about C++17 aligned new..

Everything looks good to me here. The new-expression new int; has 1 implicit argument (allocation size passed to the implementation of operator new, the value is probably 4) and 0 placement arguments (the ones that are explicitly written down after new and before int). See also https://en.cppreference.com/w/cpp/language/new#Placement_new.

Nov 5 2020, 7:50 PM

Nov 3 2020

NoQ added inline comments to D74735: [analyzer] Add support for CXXInheritedCtorInitExpr..
Nov 3 2020, 1:30 PM · Restricted Project

Nov 2 2020

NoQ added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

I don't think you actually need active support for invoking exit handlers path-sensitively at the end of main() in order to implement your checker. You can still find out in a path-insensitive manner whether any given function acts as an exit handler, like you already do. Then during path-sensitive analysis of that function you can warn at any invocation of exit().

Nov 2 2020, 5:56 PM · Restricted Project, Restricted Project, Restricted Project
NoQ added a comment to D89481: [scan-build] Fix clang++ pathname again.

Is there a reason why "NoQ accepted this revision." kept this at "Needs Review" rather than moving it to "This revision is now accepted and ready to land."?

Nov 2 2020, 4:43 PM · Restricted Project

Oct 27 2020

NoQ accepted D89481: [scan-build] Fix clang++ pathname again.

Since recently we started doing LIT tests for scan-build in test/Analysis/scan-build, if you find a good way to test this feature feel free to add a regression test.

Oct 27 2020, 10:31 AM · Restricted Project

Oct 23 2020

NoQ accepted D89982: [analyzer] [NFC] Simplify SVal::getAsLocSymbol function using existing functions.

Looks correct, thanks!

Oct 23 2020, 10:31 AM · Restricted Project
NoQ added a comment to D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef.

Honestly i'd rather eliminate SymExpr and go with Symbol everywhere. It's an overloaded term but appending "Expr" to it doesn't really make it significantly less overloaded. We're also properly namespaced so there wouldn't be any linking issues with the rest of LLVM. "Symbol" is catchy and it's one of the most important concepts to grasp in the static analyzer, i'd love to keep it.

Oct 23 2020, 10:29 AM · Restricted Project

Oct 17 2020

NoQ added a comment to D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning.

Aha, great, sounds like all casting can be made more correct, not just casting on store retrieve! Maybe it's worth celebrating through extra unittests on evalCast(). Thank you for looking into this.

Oct 17 2020, 5:22 AM · Restricted Project

Oct 13 2020

NoQ added inline comments to D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis..
Oct 13 2020, 10:56 AM · Restricted Project

Oct 12 2020

NoQ added a comment to D88332: [WIP][Analyzer] PtrToIntegCastLibcChecker.
In D88332#2297374, @NoQ wrote:

Hmm, if we could add an interface to CallDescriptionMap to accept AnyCall instead of CallEvent then we could use it for path-insensitive checkers as well. That'd have saved some lines of code.

Sounds interesting but I lack context to imagine the details. Would the map be still initialized by some ASTVisitor?

Oct 12 2020, 2:46 PM
NoQ added inline comments to D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis..
Oct 12 2020, 1:25 PM · Restricted Project

Oct 8 2020

NoQ added a comment to D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning.

This actually looks correct to me but i suggest a bit more investigation. Architecturally, it doesn't make sense to me that CastRetrievedVal() does anything beyond svalBuilder.dispatchCast(V, castTy). After all, there's only one way to cast a value from one type to another, and dispatchCast() was supposed to be the ultimate method to do so.

Oct 8 2020, 3:36 PM · Restricted Project

Oct 7 2020

NoQ accepted D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer.

Looks great, thank you! I think you can commit it :)

Oct 7 2020, 5:35 PM · Restricted Project

Oct 5 2020

NoQ added a comment to D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally.

i'm pretty worried about our ability to actually achieve that in the near future

Oct 5 2020, 10:06 PM · Restricted Project
NoQ added a comment to D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine.

With Z3 constraint manager you absolutely want your constraints to be as precise as possible. The only reason we don't add these casts is because it confuses the constraint manager a lot. With a better constraint manager we would have spared ourselves a lot of suffering in this area.

Oct 5 2020, 9:46 PM · Restricted Project

Oct 1 2020

NoQ added a comment to D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine.

Aha, ok, thanks, I now understand what the problem is because I was able to run the test before the patch and see how the patch changes the behavior.

Oct 1 2020, 9:03 PM · Restricted Project
NoQ added a comment to D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally.

A value of an expression should have the same type and value-kind as the expression.

Oct 1 2020, 8:13 PM · Restricted Project
NoQ added a comment to D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally.

No, you got it all wrong again. I don't want to explain this one more time so let's talk about some basics: A value of an expression should have the same type and value-kind as the expression. Can we get there? How?

Oct 1 2020, 6:53 PM · Restricted Project
NoQ added a comment to D86743: [analyzer] Ignore VLASizeChecker case that could cause crash.

But that's for a different bug, no? Even if that patch somehow dodges *this* crash, the underlying problem of us being unable to account for mutability of VLA sizes still remains to be addressed.

Oct 1 2020, 1:36 AM · Restricted Project

Sep 30 2020

NoQ added a comment to D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally.

(in the latest message by "load" i mean the first load that produces a pointer (i.e., an ElementRegion) as the result)

Sep 30 2020, 2:22 PM · Restricted Project
NoQ added a comment to D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally.

I'm trying to say that the value produced by the load should not be the same as the stored value, because these two values are of different types. When exactly does the first value change into the second value is a different story; the current grand vision around which the code is written says that it changes during load, therefore it's the load code (step #2) that's to blame.

Sep 30 2020, 2:20 PM · Restricted Project
NoQ added a comment to D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally.

In the Summary's example, at location #2 the value of **p is &Element{SymRegion{reg_$0<int * a>},0 S64b,unsigned char} - which is exactly what we stored at line #1.

void test(int *a, char ***b, float *c) {
  *(unsigned char **)b = (unsigned char *)a; // #1
  if (**b == 0) // no-crash, #2
    ;
  // ...
}
Sep 30 2020, 11:17 AM · Restricted Project
NoQ added a comment to D86743: [analyzer] Ignore VLASizeChecker case that could cause crash.

Yup, that's pretty bad.

Sep 30 2020, 9:43 AM · Restricted Project
NoQ added a comment to D86743: [analyzer] Ignore VLASizeChecker case that could cause crash.

The last comment for that bug is D69726, but the bug is not closed to it seems to me that D69726 does not solve it, just takes a single step towards the solution.

Sep 30 2020, 9:36 AM · Restricted Project
NoQ added a comment to D69726: [analyzer] DynamicSize: Store the dynamic size.

Thank you for reminding me of this patch. I still think it's a pretty important patch and i'm interested in getting it landed.

Sep 30 2020, 9:30 AM · Restricted Project

Sep 29 2020

NoQ added a comment to D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally.

A load from a region of type T should always yield a value of type T because that's what a load is.

Sep 29 2020, 12:13 PM · Restricted Project

Sep 28 2020

NoQ added a comment to D77062: [analyzer] [NFC] Simplify CStringChecke::assumeZero function.

Nice, very interesting!

Sep 28 2020, 11:00 AM · Restricted Project
NoQ added a comment to D87800: [WIP][Analyzer] find stack addresses leaked via out-params.

I also recommend using a specialized callback checkBind instead of pattern-matching binary operators specifically.

Sep 28 2020, 10:13 AM
NoQ added a comment to D88070: [WIP][Analyzer] find stack addresses leaked via out-params - in checkEndFunction.

The code you've added looks correct. I suspect either heap invalidation or dead symbol elimination cleaning up the binding.

Sep 28 2020, 10:11 AM
NoQ added a comment to D87800: [WIP][Analyzer] find stack addresses leaked via out-params.

Now, the current implementation still has false positives in the sense that it warns at every suspicious assignment without checking what is the actual state of LHS of such assignment at the point of return from the function.

Sep 28 2020, 10:07 AM

Sep 27 2020

NoQ added inline comments to D88332: [WIP][Analyzer] PtrToIntegCastLibcChecker.
Sep 27 2020, 11:36 PM
NoQ added a comment to D88332: [WIP][Analyzer] PtrToIntegCastLibcChecker.

Hmm, if we could add an interface to CallDescriptionMap to accept AnyCall instead of CallEvent then we could use it for path-insensitive checkers as well. That'd have saved some lines of code.

Sep 27 2020, 11:23 PM
NoQ added a comment to D88359: [analyzer][RFC] Complete rewrite of ArrayBoundCheckerV2.

We already have a similar simplification facility in SValBuilder created to solve the similar problem with iterator checkers. It fires up when it knows that the values it works with are limited to roughly 1/4 of their type's range and therefore none of the individual operations over them can potentially overflow (cf. D35109). It's currently off by default because performance was not properly evaluated and none of the on-by-default checkers rely on it. This is currently the intended approach to such issues. It was decided that constructing a custom solver for "non-overflowing but still bounded" arithmetic was not the right thing to do, mostly because it absolutely doesn't correspond to the actual run-time behavior of the program that we're supposed to be modeling.

Sep 27 2020, 1:43 PM · Restricted Project

Sep 24 2020

NoQ added a comment to D86743: [analyzer] Ignore VLASizeChecker case that could cause crash.

A VLA in a loop may have different size on each iteration of the loop. This looks very much related to https://bugs.llvm.org/show_bug.cgi?id=28450.

Sep 24 2020, 12:15 AM · Restricted Project

Sep 23 2020

NoQ added inline comments to D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling.
Sep 23 2020, 9:45 PM · Restricted Project

Sep 22 2020

NoQ added inline comments to D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling.
Sep 22 2020, 1:24 PM · Restricted Project
NoQ added inline comments to D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling.
Sep 22 2020, 1:08 AM · Restricted Project
NoQ requested changes to D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling.
Sep 22 2020, 12:59 AM · Restricted Project

Sep 21 2020

NoQ added inline comments to D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling.
Sep 21 2020, 11:38 PM · Restricted Project
NoQ accepted D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange.

Uh-oh, so you're saying that you're actively modeling every single operator + and - on every single integer in the program even when they don't represent any iterators at all? How can a raw integer be an iterator to begin with, given that you can't dereference an integer? Is this caused by D82185? Can you defend against such situations by checking that the operand is a pointer before doing any operations?

Sep 21 2020, 11:16 PM · Restricted Project
NoQ accepted D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers.

Aha, yup, thanks, this looks good!

Sep 21 2020, 10:50 PM · Restricted Project
NoQ requested changes to D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock.
Sep 21 2020, 10:38 PM · Restricted Project
NoQ added inline comments to D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs.
Sep 21 2020, 5:50 PM · Restricted Project
NoQ accepted D83259: [Analyzer][WebKit] UncountedLocalVarsChecker.

Thank you, i think this is good to land!

Sep 21 2020, 1:36 PM

Sep 19 2020

NoQ added a comment to D83259: [Analyzer][WebKit] UncountedLocalVarsChecker.

(I.e., i don't have strong opinions about high-level design and will happily push the green button as soon as minor nits are addressed)

Sep 19 2020, 4:39 PM

Sep 18 2020

NoQ added a comment to D83259: [Analyzer][WebKit] UncountedLocalVarsChecker.

Sry! I'll try my best to keep up from now on.

Sep 18 2020, 1:00 AM
NoQ added a comment to D87800: [WIP][Analyzer] find stack addresses leaked via out-params.

My quick naive attempt of getting SVal of DeclRefExpr and checking if its MemRegion is in current stack frame didn't get very far because the returned SVal kind is undefined.

Sep 18 2020, 12:30 AM

Sep 8 2020

NoQ added inline comments to D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting.
Sep 8 2020, 2:37 PM · Restricted Project
NoQ added inline comments to D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME.
Sep 8 2020, 1:06 PM · Restricted Project
NoQ added inline comments to D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME.
Sep 8 2020, 1:04 PM · Restricted Project
NoQ added inline comments to D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers.
Sep 8 2020, 12:43 PM · Restricted Project
NoQ added inline comments to D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock.
Sep 8 2020, 1:50 AM · Restricted Project

Sep 5 2020

NoQ accepted D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait.

This looks correct to me. Thanks a lot. This hack was surprisingly crude and i'm very glad that we now consistently use expressions in our Environment.

Sep 5 2020, 5:38 PM · Restricted Project

Sep 3 2020

NoQ added a comment to D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer.

What are types of each term in this expression?

Sep 3 2020, 12:09 AM · Restricted Project

Sep 2 2020

NoQ added a comment to D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer.

Nice catch, thx!

Sep 2 2020, 11:58 PM · Restricted Project

Aug 27 2020

NoQ accepted D86373: [analyzer] Add modeling for unique_ptr move constructor.

Yup, that's more like it!~

Aug 27 2020, 4:02 PM · Restricted Project
NoQ accepted D86027: [analyzer] Add bool operator modeling for unque_ptr.

I have no other concerns, i think this is good to go!

Aug 27 2020, 3:57 PM · Restricted Project
NoQ added inline comments to D85752: [Analyzer] Store the pointed/referenced type for dynamic casts.
Aug 27 2020, 11:43 AM · Restricted Project

Aug 25 2020

NoQ added a comment to D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock.

No-no, recursive locks are much more complicated than that, please do them separately. You'll have to discriminate between a real double lock / double unlock bug and an actual valid use of the recursive mutex in order to emit any warnings at all. That's completely different checker logic.

Aug 25 2020, 1:45 PM · Restricted Project
NoQ accepted D86293: [analyzer] Add modeling of Eq operator in smart ptr.

Looks amazing now.

Aug 25 2020, 1:14 PM · Restricted Project
NoQ added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 25 2020, 1:10 PM · Restricted Project
NoQ added a comment to D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker.

Hans is pinging us on Bugzilla because this patch is marked as a release blocker (and i believe that it indeed is). I think we should land these patches.

Aug 25 2020, 12:14 PM · Restricted Project
NoQ added inline comments to D86027: [analyzer] Add bool operator modeling for unque_ptr.
Aug 25 2020, 12:08 AM · Restricted Project

Aug 24 2020

NoQ added a comment to D86465: [analyzer][solver] Redesign constraint ranges data structure.

If the numbers are confirmed to be as good as what i've sneak-peeked so far, that should be pretty amazing. Also whoa, test coverage!~

Aug 24 2020, 11:48 PM · Restricted Project
NoQ added inline comments to D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME.
Aug 24 2020, 11:23 PM · Restricted Project