Page MenuHomePhabricator

rsmith (Richard Smith - zygoloid)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2012, 2:19 PM (421 w, 6 d)

Recent Activity

Today

rsmith committed rG269bc3f5df6c: PR47138: Don't crash if the preferred alignment of an invalid record (authored by rsmith).
PR47138: Don't crash if the preferred alignment of an invalid record
Wed, Aug 12, 12:31 PM
rsmith added a comment to D85710: Code generation support for lvalue bit-field conditionals..

I always imagined that we'd implement this by just inverting the emission: emit the RHS of the assignment and then pass a callback down to a function that descended into conditional operators and called the callback when it hit a leaf. Having an LValue case that's an arbitrarily-nested conditional seems unfortunate.

Wed, Aug 12, 11:40 AM · Restricted Project

Yesterday

rsmith added inline comments to D85791: Fix for: Bug 47119 - ICE: is_invocable_v (access via :: of non static member).
Tue, Aug 11, 5:28 PM · Restricted Project
rsmith added a comment to D85256: Add -Wtautological-value-range-compare warning..

This appears to be a general problem: the GetExprRange mechanism in SemaChecking miscomputes the ranges for +, *, and - expressions, and we'll get them wrong for all warnings that use that mechanism :-(

Tue, Aug 11, 1:55 PM · Restricted Project
rsmith requested review of D85778: More accurately compute the ranges of possible values for +, -, *, &, %..
Tue, Aug 11, 1:53 PM · Restricted Project
rsmith added a comment to D85256: Add -Wtautological-value-range-compare warning..

I think this generates a false positive with test.cc

enum E { E1 = 1, E2 = 2 };
bool f(E e) { return ((e & E1) ? 1 : 0) + ((e & E2) ? 1 : 0) > 1; }

and clang++ -fsyntax-only -Wtautological-value-range-compare test.cc

test.cc:2:62: warning: result of comparison of 1-bit unsigned value > 1 is always false [-Wtautological-value-range-compare]
bool f(E e) { return ((e & E1) ? 1 : 0) + ((e & E2) ? 1 : 0) > 1; }
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
Tue, Aug 11, 12:12 PM · Restricted Project
rsmith updated the diff for D85710: Code generation support for lvalue bit-field conditionals..
  • Remove development aid from test.
Tue, Aug 11, 12:38 AM · Restricted Project
rsmith requested review of D85710: Code generation support for lvalue bit-field conditionals..
Tue, Aug 11, 12:32 AM · Restricted Project

Mon, Aug 10

rsmith accepted D85696: [AST] add parenthesis locations for IfStmt and SwitchStmt.

Only relatively trivial comments; please feel free to commit once they're addressed.

Mon, Aug 10, 6:20 PM · Restricted Project
rsmith added inline comments to D85601: Fixes an assertion when IntRange processes a throw expression.
Mon, Aug 10, 6:09 PM · Restricted Project
rsmith requested review of D85699: PR47099: Split <intrin0.h> out of <intrin.h>..
Mon, Aug 10, 5:50 PM · Restricted Project
rsmith added a comment to D83929: [clang]: Remove assertion which checks explicit declaration.

Please add a corresponding test case. Other than that this looks good. Thanks!

Mon, Aug 10, 5:47 PM
rsmith committed rG0fd3d379e26d: Improve diagnostic for an expression that's not constant because it uses (authored by rsmith).
Improve diagnostic for an expression that's not constant because it uses
Mon, Aug 10, 5:03 PM
rsmith committed rG09517a90682f: Add regression test from PR46487. (authored by rsmith).
Add regression test from PR46487.
Mon, Aug 10, 3:55 PM
rsmith added inline comments to D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type.
Mon, Aug 10, 3:43 PM · Restricted Project
rsmith added inline comments to D85613: [clang] Look through bindings when checking whether a default argument references a local entity..
Mon, Aug 10, 9:36 AM · Restricted Project

Sun, Aug 9

rsmith committed rGa4ca710d9ca9: More cleanup after removing the ability to reference a dependent (authored by rsmith).
More cleanup after removing the ability to reference a dependent
Sun, Aug 9, 11:40 PM
rsmith committed rG617007240cbf: Improve modeling of variable template specializations with dependent (authored by rsmith).
Improve modeling of variable template specializations with dependent
Sun, Aug 9, 11:22 PM
rsmith added inline comments to D85613: [clang] Look through bindings when checking whether a default argument references a local entity..
Sun, Aug 9, 11:09 PM · Restricted Project
rsmith added inline comments to D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type.
Sun, Aug 9, 9:30 PM · Restricted Project
rsmith added a comment to D85601: Fixes an assertion when IntRange processes a throw expression.

Did this only crash during error recovery before, or also for your void g() example? If we were only crashing in error recovery, that would suggest that error recovery was producing a bad AST, and perhaps we should be fixing this elsewhere.

Sun, Aug 9, 1:11 PM · Restricted Project

Fri, Aug 7

rsmith committed rGfb943696cbc6: PR47025, PR47043: Diagnose unexpanded parameter packs in concept (authored by rsmith).
PR47025, PR47043: Diagnose unexpanded parameter packs in concept
Fri, Aug 7, 6:20 PM

Thu, Aug 6

rsmith added inline comments to D85473: [Clang] Add option to allow marking pass-by-value args as noalias..
Thu, Aug 6, 11:17 PM · Restricted Project
rsmith committed rGb2847671b83f: Reinstate check that we don't crash. (authored by rsmith).
Reinstate check that we don't crash.
Thu, Aug 6, 7:08 PM
rsmith committed rG2f1fffab73f8: Disable clang-tidy test that started failing after clang commit ed5a18f. (authored by rsmith).
Disable clang-tidy test that started failing after clang commit ed5a18f.
Thu, Aug 6, 7:06 PM
rsmith committed rGed5a18fc0399: PR30738: Implement two-phase name lookup for fold-expressions. (authored by rsmith).
PR30738: Implement two-phase name lookup for fold-expressions.
Thu, Aug 6, 4:57 PM
rsmith added a comment to D79279: Add overloaded versions of builtin mem* functions.

I thought part of the point of __builtin_memcpy was so that C library headers could do #define memcpy(x, y, z) __builtin_memcpy(x, y, z). If so, the conformance issue touches __builtin_memcpy as well, not just calls to the library builtin.

Thu, Aug 6, 4:50 PM · Restricted Project, Restricted Project
rsmith added a comment to D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder..

If the intent is for getTypeInfo to always return sizes that are multiples of the char size, then the design should be inverted and getTypeInfo should simply be calling getTypeInfoInChars and multiply that result by the char size. But that isn't how it works.

The reason it doesn't work this way is just that someone made the wrong choice a decade ago, and nobody has spent the time to rewrite it since. Patch welcome.

This does sound like a good thing to do, but it would be problematic downstream since it would completely prohibit the design that we're trying to use.

Thu, Aug 6, 4:01 PM · Restricted Project
rsmith added a comment to D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath.

Looks reasonable to me. I expect you'll find more places that need to learn how to handle dependent types in C, but this looks like a solid start.

Thu, Aug 6, 1:42 PM · Restricted Project
rsmith committed rGd6492d874478: Add -Wtautological-value-range-compare warning. (authored by rsmith).
Add -Wtautological-value-range-compare warning.
Thu, Aug 6, 1:29 PM
rsmith closed D85256: Add -Wtautological-value-range-compare warning..
Thu, Aug 6, 1:29 PM · Restricted Project
rsmith added a comment to D79279: Add overloaded versions of builtin mem* functions.

I thought part of the point of __builtin_memcpy was so that C library headers could do #define memcpy(x, y, z) __builtin_memcpy(x, y, z). If so, the conformance issue touches __builtin_memcpy as well, not just calls to the library builtin.

Thu, Aug 6, 1:04 PM · Restricted Project, Restricted Project
rsmith added a reviewer for D79279: Add overloaded versions of builtin mem* functions: tstellar.
Thu, Aug 6, 1:03 PM · Restricted Project, Restricted Project
rsmith added a comment to D85097: [Sema] add warning for comparisons like 'x<=y<=z'.

The diagnostic we get for the case of three or more comparison operators here doesn't seem ideal. Perhaps we could do this check as part of the SemaChecking pass over the completed expression rather than doing it as we form the individual comparisons? That way we'll have the contextual information necessary to find the complete chained comparison; we'd also be able to detect the special case where the operator sequence is the operand of an &/|/^ so that we need parentheses in the fixit.

Thu, Aug 6, 12:48 PM · Restricted Project

Wed, Aug 5

rsmith committed rG076b120bebfd: CFG: Destroy temporaries in (a,b) expression in the correct order. (authored by rsmith).
CFG: Destroy temporaries in (a,b) expression in the correct order.
Wed, Aug 5, 2:53 PM
rsmith added a comment to D79279: Add overloaded versions of builtin mem* functions.

Two observations that are new to me in this review:

Wed, Aug 5, 11:42 AM · Restricted Project, Restricted Project
rsmith added a comment to D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder..

This is not ideal, since it makes the calculations char size dependent, and breaks for sizes that are not a multiple of the char size.

How can we have a non-bitfield member whose size is not a multiple of the size of a char?

Downstream, we have fixed-point types that are 24 bits large, but where the char size is 16. The type then takes up 2 chars, where 8 of the bits are padding. The only way in Clang to express that the width of the bit representation of a type should be smaller than the number of chars it takes up in memory -- and consequently, produce an i24 in IR -- is to return a non-charsize multiple from getTypeInfo.

Wed, Aug 5, 10:17 AM · Restricted Project

Tue, Aug 4

rsmith added a comment to D79279: Add overloaded versions of builtin mem* functions.

Thanks. I'd like @rjmccall to approve too, but the design of these intrinsics and the Sema and constant evaluation parts seem fine. (We don't strictly need constant evaluation to abort on library UB, so I think not catching the misalignment case is OK.)

Tue, Aug 4, 6:24 PM · Restricted Project, Restricted Project
rsmith committed rGdd37b5a35b69: PR46997: don't run clang-format on clang's testcases. (authored by rsmith).
PR46997: don't run clang-format on clang's testcases.
Tue, Aug 4, 5:55 PM
rsmith added a comment to D85256: Add -Wtautological-value-range-compare warning..
Tue, Aug 4, 5:33 PM · Restricted Project
rsmith updated the diff for D85256: Add -Wtautological-value-range-compare warning..
Tue, Aug 4, 5:25 PM · Restricted Project
rsmith updated the diff for D85256: Add -Wtautological-value-range-compare warning..

Unbreak test that was autobroken by lint.

Tue, Aug 4, 5:21 PM · Restricted Project
rsmith requested review of D85256: Add -Wtautological-value-range-compare warning..
Tue, Aug 4, 4:21 PM · Restricted Project
rsmith added a comment to D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder..

This is not ideal, since it makes the

calculations char size dependent, and breaks for sizes that
are not a multiple of the char size.

Tue, Aug 4, 9:13 AM · Restricted Project

Fri, Jul 31

rsmith committed rG234f51a65a45: Don't crash if we deserialize a pack expansion type whose pattern (authored by rsmith).
Don't crash if we deserialize a pack expansion type whose pattern
Fri, Jul 31, 5:20 PM
rsmith added inline comments to D79279: Add overloaded versions of builtin mem* functions.
Fri, Jul 31, 4:51 PM · Restricted Project, Restricted Project
rsmith edited reviewers for D85051: Improve the representation of <compare>'s zero-only type., added: ldionne; removed: mclow.lists.
Fri, Jul 31, 3:19 PM · Restricted Project
rsmith requested review of D85051: Improve the representation of <compare>'s zero-only type..
Fri, Jul 31, 3:16 PM · Restricted Project

Thu, Jul 30

rsmith added a comment to D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

Based on richard's suggestions, that seems about right. However I believe all the asserts should have a message to go along with them as we typicaly do.

Thu, Jul 30, 4:36 PM · Restricted Project
rsmith added inline comments to D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..
Thu, Jul 30, 4:32 PM · Restricted Project
rsmith accepted D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Thanks, looks nice =)

Thu, Jul 30, 4:00 PM · Restricted Project
rsmith committed rG1e7f026c3b59: PR46908: Emit undef destroying_delete_t as an aggregate RValue. (authored by rsmith).
PR46908: Emit undef destroying_delete_t as an aggregate RValue.
Thu, Jul 30, 2:50 PM
rsmith requested changes to D83929: [clang]: Remove assertion which checks explicit declaration.

We already check that explicit is only used in the proper scopes in ActOnFunctionDeclarator (and the proper scopes aren't just class scopes, due to deduction guides). In fact, the assert appears to have nothing to do with whether the expression appears at function scope; that's a red herring caused by unary && (address of label) doing different things at that scope. An analogous case crashes at class scope too:

Thu, Jul 30, 12:40 PM

Wed, Jul 29

rsmith committed rGa64883431369: PR46729: Reject explicit and partial specializations with C linkage. (authored by rsmith).
PR46729: Reject explicit and partial specializations with C linkage.
Wed, Jul 29, 5:44 PM
rsmith committed rG6ce97eee3546: Fix invalid attempted explicit instantiation, which Clang now rejects. (authored by rsmith).
Fix invalid attempted explicit instantiation, which Clang now rejects.
Wed, Jul 29, 1:07 PM
rsmith committed rG1cbdf932b41e: PR46231: Promote diagnostic for 'template<...>;' from ExtWarn to Error. (authored by rsmith).
PR46231: Promote diagnostic for 'template<...>;' from ExtWarn to Error.
Wed, Jul 29, 12:35 PM
rsmith committed rGe69138dad5a5: PR46859: Fix crash if declaring a template in a DeclScope with no DeclContext. (authored by rsmith).
PR46859: Fix crash if declaring a template in a DeclScope with no DeclContext.
Wed, Jul 29, 12:03 PM

Tue, Jul 28

rsmith committed rG9cf98d26e7b1: PR46637: Fix handling of placeholder types in trailing-return-types. (authored by rsmith).
PR46637: Fix handling of placeholder types in trailing-return-types.
Tue, Jul 28, 3:54 PM
rsmith accepted D81678: Introduce noundef attribute at call sites for stricter poison analysis.

Looks good with suggestions applied, and with the portability problems in the test fixed. (Maybe just add a -triple? Though it would be good to also test inalloca and ARM constructor this returns and so on.)

Tue, Jul 28, 1:45 PM · Restricted Project, Restricted Project
rsmith committed rG740a164dec48: PR46377: Fix dependence calculation for function types and typedef (authored by rsmith).
PR46377: Fix dependence calculation for function types and typedef
Tue, Jul 28, 1:23 PM

Mon, Jul 27

rsmith added inline comments to D79279: Add overloaded versions of builtin mem* functions.
Mon, Jul 27, 7:53 PM · Restricted Project, Restricted Project
rsmith added a comment to D80925: Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context..

I'm going to try to fix this a different way, by fixing the bad case in Sema::ClassifyName instead.

Mon, Jul 27, 7:38 PM · Restricted Project
rsmith committed rG23d6525cbdc9: Don't form a 'context-independent expr' reference to a member during name… (authored by rsmith).
Don't form a 'context-independent expr' reference to a member during name…
Mon, Jul 27, 7:38 PM
rsmith added a reverting change for rG2f7269b6773d: Fix compiler crash when an expression parsed in the tentative parsing and must…: rG23d6525cbdc9: Don't form a 'context-independent expr' reference to a member during name….
Mon, Jul 27, 7:38 PM
rsmith added a comment to D80925: Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context..

This is at best only a partial fix. Sema::NC_ContextIndependentExpr is supposed to be used (unsurprisingly) only if we form a context-independent annotation, but here we're forming a context-dependent expression that depends on whether it appears in an unevaluated context. I think the better approach would be to fix the case in Sema::ClassifyName that violates context-independence instead (there's a FIXME there for this issue).

Mon, Jul 27, 5:55 PM · Restricted Project

Thu, Jul 23

rsmith added a comment to D79279: Add overloaded versions of builtin mem* functions.

These new builtins should ideally support constant evaluation if possible.

Thu, Jul 23, 1:44 PM · Restricted Project, Restricted Project

Wed, Jul 22

rsmith added inline comments to D84048: DR2303: Prefer 'nearer' base classes during template deduction..
Wed, Jul 22, 6:47 PM · Restricted Project
rsmith added inline comments to D84048: DR2303: Prefer 'nearer' base classes during template deduction..
Wed, Jul 22, 4:32 PM · Restricted Project
rsmith committed rG6c18f7db73a0: For PR46800, implement the GCC __builtin_complex builtin. (authored by rsmith).
For PR46800, implement the GCC __builtin_complex builtin.
Wed, Jul 22, 1:43 PM

Tue, Jul 21

rsmith added inline comments to D81678: Introduce noundef attribute at call sites for stricter poison analysis.
Tue, Jul 21, 2:27 PM · Restricted Project, Restricted Project
rsmith requested changes to D81678: Introduce noundef attribute at call sites for stricter poison analysis.

I'd like to see some testcases for the C++ side of this. The following things all seem like they might be interesting: passing and returning classes and unions, especially ones that aren't trivially-copyable, nullptr_t, pointers to members, this parameters, VTTs, the "complete object" flag for MS ABI constructors, the this return from constructors in the ARM ABI, parameters and return values of virtual adjustment thunks.

Tue, Jul 21, 2:26 PM · Restricted Project, Restricted Project
rsmith added a comment to D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Additionally, I sent out a CWG message on the reflector about this: https://godbolt.org/z/bEr61T

My implementation has this as ambiguous, but the wording makes it well-formed I think. I don't think that was the intent of CWG2303, so unless they confirm that this was their intent (or that I'm wrong), I'll leave this patch as is.

Tue, Jul 21, 12:40 PM · Restricted Project

Fri, Jul 17

rsmith accepted D84067: Fix issue in typo handling which could lead clang to hang.
Fri, Jul 17, 4:26 PM · Restricted Project

Thu, Jul 16

rsmith committed rG8ef9e2bf355d: Revert "[libFuzzer] Link libFuzzer's own interceptors when other compiler… (authored by rsmith).
Revert "[libFuzzer] Link libFuzzer's own interceptors when other compiler…
Thu, Jul 16, 6:09 PM
rsmith added a reverting change for rGf78d9fceea73: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are…: rG8ef9e2bf355d: Revert "[libFuzzer] Link libFuzzer's own interceptors when other compiler….
Thu, Jul 16, 6:09 PM
rsmith added a reverting change for rG12d1124c49be: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when…: rG8ef9e2bf355d: Revert "[libFuzzer] Link libFuzzer's own interceptors when other compiler….
Thu, Jul 16, 6:09 PM

Wed, Jul 15

rsmith committed rGd256b8ad5f28: Fix "unused variable" warning from recent GCC. (authored by rsmith).
Fix "unused variable" warning from recent GCC.
Wed, Jul 15, 11:35 AM
rsmith committed rG268025e2636c: Fix "unused variable" warning from recent GCC. (authored by rsmith).
Fix "unused variable" warning from recent GCC.
Wed, Jul 15, 11:33 AM

Tue, Jul 14

rsmith committed rG71292379d757: Make LazyCallThroughManager destructor virtual rather than arranging for all… (authored by rsmith).
Make LazyCallThroughManager destructor virtual rather than arranging for all…
Tue, Jul 14, 6:41 PM
rsmith committed rG099fd3748470: Fix undefined behavior due to deleting an object with a non-virtual destructor… (authored by rsmith).
Fix undefined behavior due to deleting an object with a non-virtual destructor…
Tue, Jul 14, 5:30 PM
rsmith committed rGf49edafd9abf: Fix test that was accidentally adding the llvm-as binary into an IR archive. (authored by rsmith).
Fix test that was accidentally adding the llvm-as binary into an IR archive.
Tue, Jul 14, 5:08 PM
rsmith added a comment to D63640: [clang] Improve Serialization/Imporing of APValues.

Are we at a point where we can test this now? Perhaps by adding an assert in codegen that we always have an evaluated value for any constexpr variable that we emit?

Tue, Jul 14, 10:58 AM · Restricted Project
rsmith committed rGbfd643353e6b: Fix merging of two arity-only pack deductions. (authored by rsmith).
Fix merging of two arity-only pack deductions.
Tue, Jul 14, 10:02 AM

Mon, Jul 13

rsmith added a comment to D83725: [llvm-mc] Add --doc-id=<id> to support multiple documents in a file.

Would it make sense to split this into a separate utility[...]?

Teach the extract utility about comment markers of common file extensions (.s, .ll, .c, .cpp)? (To make editors happy, the separator should be a comment in that file (e.g. # ; // --- etc))

Mon, Jul 13, 6:02 PM · Restricted Project
rsmith added a comment to D83725: [llvm-mc] Add --doc-id=<id> to support multiple documents in a file.

Would it make sense to split this into a separate utility, so you could use (eg)

Mon, Jul 13, 5:42 PM · Restricted Project
rsmith committed rG746b8c400bd3: Basic support for flexible array members in constant evaluation. (authored by rsmith).
Basic support for flexible array members in constant evaluation.
Mon, Jul 13, 4:58 PM

Jul 12 2020

rsmith added a comment to D83647: Don't allow mangling substitutions to refer to unrelated entities from different <encoding>s..

Hm, I think this is not quite right. For example, given:

Jul 12 2020, 4:00 PM · Restricted Project
Herald added a project to D83647: Don't allow mangling substitutions to refer to unrelated entities from different <encoding>s.: Restricted Project.
Jul 12 2020, 2:11 PM · Restricted Project

Jul 9 2020

rsmith committed rGb03f1756fb4f: [demangler] More properly save and restore the template parameter state when… (authored by rsmith).
[demangler] More properly save and restore the template parameter state when…
Jul 9 2020, 9:13 PM
rsmith committed rG553dbb6d7b32: [demangler] Don't allow the template parameters from the <encoding> in a <local… (authored by rsmith).
[demangler] Don't allow the template parameters from the <encoding> in a <local…
Jul 9 2020, 8:38 PM
rsmith committed rGf721e0582b15: PR46648: Do not eagerly instantiate default arguments for a generic lambda when… (authored by rsmith).
PR46648: Do not eagerly instantiate default arguments for a generic lambda when…
Jul 9 2020, 5:25 PM
rsmith committed rGa5569f089844: Push parameters into the local instantiation scope before instantiating a… (authored by rsmith).
Push parameters into the local instantiation scope before instantiating a…
Jul 9 2020, 5:25 PM
rsmith committed rG7462793be771: Move default argument instantiation to SemaTemplateInstantiateDecl.cpp. (authored by rsmith).
Move default argument instantiation to SemaTemplateInstantiateDecl.cpp.
Jul 9 2020, 5:25 PM

Jul 8 2020

rsmith committed rG00068c452a59: Improve diagnostics for constant evaluation that fails because a variable's… (authored by rsmith).
Improve diagnostics for constant evaluation that fails because a variable's…
Jul 8 2020, 6:14 PM
rsmith committed rG903bda14c330: PR46640: Permit the first parameter of a destroying 'operator delete' to be… (authored by rsmith).
PR46640: Permit the first parameter of a destroying 'operator delete' to be…
Jul 8 2020, 2:31 PM
rsmith committed rG4544c2d95ad0: Recover more gracefully from stack exhaustion during template argument… (authored by rsmith).
Recover more gracefully from stack exhaustion during template argument…
Jul 8 2020, 1:09 PM

Jul 7 2020

rsmith committed rG065fc1eafe7c: PR45521: Preserve the value kind when performing a standard conversion sequence… (authored by rsmith).
PR45521: Preserve the value kind when performing a standard conversion sequence…
Jul 7 2020, 6:28 PM
rsmith added a comment to D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute.

@aaron.ballman We will need to do something like this in general, but I'm not sure it's going to be as easy as just inheriting the attribute in the general case. What do you think?

Jul 7 2020, 12:41 PM · Restricted Project
rsmith added a reviewer for D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute: aaron.ballman.
Jul 7 2020, 12:36 PM · Restricted Project
rsmith accepted D83263: Clang crashed while checking for deletion of copy and move ctors.
Jul 7 2020, 11:27 AM · Restricted Project