Page MenuHomePhabricator

aaron.ballman (Aaron Ballman)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 14 2013, 3:16 PM (401 w, 4 d)

Recent Activity

Today

aaron.ballman added inline comments to D90188: Add support for attribute 'using_if_exists'.
Mon, Nov 23, 7:25 AM
aaron.ballman added reviewers for D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.: aaronpuchert, delesley.

This feels an awful lot like a set of attributes we already have -- can capability attributes be used for this instead? https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#basic-concepts-capabilities The documentation is largely centered around thread safety, but the gist of the idea seems similar to what you're proposing here -- certain parts of the program have different roles and you want to control how functions in one role can interact with functions in another role.

Mon, Nov 23, 6:56 AM
aaron.ballman added a comment to D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check.

Ping.
If there's no pushback within next 24h i will commit this and wait for post-commit review (if any).
Thanks.

Mon, Nov 23, 6:47 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman accepted D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

LGTM, but please wait for @njames93 in case they have additional feedback.

Mon, Nov 23, 6:19 AM · Restricted Project, Restricted Project
aaron.ballman accepted D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier.

LGTM!

Mon, Nov 23, 6:11 AM · Restricted Project
aaron.ballman added inline comments to D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.
Mon, Nov 23, 6:06 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman accepted D91918: Remove the IgnoreImplicitCastsAndParentheses traversal kind.

LGTM aside from a documentation request, thank you for this cleanup!

Mon, Nov 23, 5:51 AM · Restricted Project
aaron.ballman accepted D91916: Remove automatic traversal from forEach matcher.

LGTM!

Mon, Nov 23, 5:47 AM · Restricted Project
aaron.ballman accepted D91917: Update mode used in traverse() examples.

LGTM!

Mon, Nov 23, 5:38 AM · Restricted Project
aaron.ballman updated subscribers of D89743: Support Attr in DynTypedNode and ASTMatchers..

We didn't talk about overloading isImplicit to apply to attrs too, but it doesn't seem like that was controversial (and it does help with the tests).

I spoke too soon about this...
This prevents hasAncestor(isImplicit()) from compiling, because hasAncestor needs to deduce the node type from its argument to call ASTMatchFinder::matchesAncestorOf<T>().
This occurs in a few places in tree and many places in our private codebase...
The workaround is hasAncestor(decl(isImplicit())) which is reasonable, except that "is contained in *any* implicit node" is probably actually the intent. Well, at least it's not a regression.

Mon, Nov 23, 5:36 AM · Restricted Project
aaron.ballman closed D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.
Mon, Nov 23, 5:11 AM · Restricted Project
aaron.ballman added a comment to D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.

@aaron.ballman Can you land it for me? I don't have commit access.

Happy to do so -- are you okay with "Jann Horn <jannh@google.com>" for author attribution?

Yes, thanks.

Mon, Nov 23, 5:11 AM · Restricted Project
aaron.ballman committed rG00dad9d028ce: Ignore noderef attribute in unevaluated context (authored by thejh).
Ignore noderef attribute in unevaluated context
Mon, Nov 23, 5:11 AM
aaron.ballman added a comment to D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.

@aaron.ballman Can you land it for me? I don't have commit access.

Mon, Nov 23, 5:07 AM · Restricted Project
aaron.ballman accepted D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.

LGTM!

Mon, Nov 23, 5:03 AM · Restricted Project

Fri, Nov 20

aaron.ballman added a comment to D89743: Support Attr in DynTypedNode and ASTMatchers..

(while this is useful to you, let's keep discussing, but I'm also happy to stop and land this with your preferred API/semantics - just LMK if changes are needed)

Let's hold off on landing for just a little bit. I don't think changes are needed yet, but the discussion may change my opinion and we might as well avoid churn. However, if you need to land part of this while we discuss other parts, LMK.

Sorry I haven't had more to say on this. I would like to land at least the attr-in-DynTypedNode part, as this unblocks some stuff unrelated to matchers in clangd (someone just filed a dupe bug, which reminded me...)

Fri, Nov 20, 11:56 AM · Restricted Project
aaron.ballman accepted D91565: Guard init_priority attribute within libc++.

LGTM, thank you for the fixes!

Fri, Nov 20, 11:39 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D91565: Guard init_priority attribute within libc++.
Fri, Nov 20, 10:18 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.
Fri, Nov 20, 9:14 AM · Restricted Project
aaron.ballman added a comment to D91872: [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls..

Drive-by question from the peanut gallery, sorry if this is an ignorant one -- not all declarations have a trailing semicolon; is that handled properly? e.g., int x; has a trailing semicolon but int x, y; only has a trailing semicolon for one of the two declarations. Relatedly, in int f(int x);, the declaration of f has a trailing semicolon, but the declaration of x does not.

No, it's a good question -- the comments and the patch description should have been clearer. I've updated both. Also, I found a test that needed to be fixed (and also, hopefully, illustrates why the new behavior is preferred. The old behavior left the semicolon out of the replacement (which looks weird) because it was working around the fact that the source being removed didn't include the trailing semicolon, while the new version can just specify the replacement correctly).

Thanks!

Fri, Nov 20, 9:02 AM · Restricted Project
aaron.ballman added a comment to D91872: [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls..

Drive-by question from the peanut gallery, sorry if this is an ignorant one -- not all declarations have a trailing semicolon; is that handled properly? e.g., int x; has a trailing semicolon but int x, y; only has a trailing semicolon for one of the two declarations. Relatedly, in int f(int x);, the declaration of f has a trailing semicolon, but the declaration of x does not.

Fri, Nov 20, 8:37 AM · Restricted Project
aaron.ballman accepted D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check.

LGTM, thank you for the new check!

Fri, Nov 20, 8:30 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.
Fri, Nov 20, 7:38 AM · Restricted Project
aaron.ballman accepted D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init..

LGTM!

Fri, Nov 20, 6:07 AM · Restricted Project, Restricted Project
aaron.ballman closed D91047: Add a call super attribute plugin example.

@aaron.ballman That would be nice if your could help, and Yafei Liu <psionic12@outlook.com> is okay.

Fri, Nov 20, 5:52 AM · Restricted Project
aaron.ballman committed rG2ce6352e4634: Add a call super attribute plugin example (authored by psionic12).
Add a call super attribute plugin example
Fri, Nov 20, 5:51 AM
aaron.ballman accepted D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource.

LGTM, thank you for the new documentation!

Fri, Nov 20, 5:45 AM · Restricted Project

Thu, Nov 19

aaron.ballman requested changes to D90180: [clang-tidy] find/fix unneeded semicolon after switch.
Thu, Nov 19, 12:50 PM · Restricted Project, Restricted Project
aaron.ballman requested changes to D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros.

The request in D90180 was to not add a check for each kind of problematic semicolon situation but to instead make a single check that has configuration options for which semi colon situations to care about. The proposed changes here should be rolled into that unified check.

Thu, Nov 19, 12:49 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource.
Thu, Nov 19, 12:45 PM · Restricted Project
aaron.ballman added inline comments to D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.
Thu, Nov 19, 10:48 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman added inline comments to D75229: [clang-tidy] Add signal-in-multithreaded-program check.
Thu, Nov 19, 7:54 AM · Restricted Project, Restricted Project
aaron.ballman added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

I updated it to use XXShortSizeThreshold.

But I was thinking.. perhaps a more generic approach could be "xxIgnoreRegex", this would allow you to do things such as :

VariableIgnoreRegex: ([a-z]{2}|index)
ClassIgnoreRegex: (Special_CASE|CommonOther.*)
etc.

it would be more generic while also allowing for excluding short names.

Thu, Nov 19, 6:42 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init..
Thu, Nov 19, 6:35 AM · Restricted Project, Restricted Project
aaron.ballman added a comment to D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource.

Thank you for the documentation effort!

Thu, Nov 19, 6:25 AM · Restricted Project
aaron.ballman accepted D91047: Add a call super attribute plugin example.

LGTM, thank you for the new plugin example! Do you need me to commit on your behalf? If so, are you okay with Yafei Liu <psionic12@outlook.com> for attribution?

Thu, Nov 19, 5:35 AM · Restricted Project
aaron.ballman accepted D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved.

LGTM!

Thu, Nov 19, 5:30 AM · Restricted Project

Wed, Nov 18

aaron.ballman added inline comments to D91565: Guard init_priority attribute within libc++.
Wed, Nov 18, 12:36 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D91047: Add a call super attribute plugin example.
Wed, Nov 18, 8:52 AM · Restricted Project
aaron.ballman accepted D91543: [clang-tidy] Improving bugprone-sizeof-expr check..

LGTM!

Wed, Nov 18, 8:39 AM · Restricted Project, Restricted Project
aaron.ballman accepted D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view..

LGTM!

Wed, Nov 18, 7:57 AM · Restricted Project
aaron.ballman accepted D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved.

LGTM aside from the testing request.

Wed, Nov 18, 7:13 AM · Restricted Project
aaron.ballman closed D91592: [ASTMatchers] Fix typo for hasAnyOverloadedOperatorName.

Thank you for the fix, I've commit on your behalf in 871fe71f2951cb19421a2b47ddb54ed6b3c8cba2

Wed, Nov 18, 4:50 AM · Restricted Project
aaron.ballman committed rG871fe71f2951: Fix typo for hasAnyOverloadedOperatorName; NFC (authored by keishi).
Fix typo for hasAnyOverloadedOperatorName; NFC
Wed, Nov 18, 4:49 AM

Tue, Nov 17

aaron.ballman added a comment to D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

Do [[deprecated]] and [[maybe_unused]] now work for using-declarators? If so, a test for that would be useful.

Tue, Nov 17, 1:11 PM
aaron.ballman added a comment to D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params.

Thank you for working on this!

Tue, Nov 17, 1:07 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved.
Tue, Nov 17, 1:01 PM · Restricted Project
aaron.ballman added a comment to D91543: [clang-tidy] Improving bugprone-sizeof-expr check..

This checker has multiple weaknesses. There are more cases when the warnings should not appear (probably if the argument of sizeof is a template parameter), or more than one warning is generated for a code construct. The test code could be further improved too (but there are many cases to handle). This fix addresses only a single problematic case.

Tue, Nov 17, 8:32 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check.
Tue, Nov 17, 8:22 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D91630: [Parse] Add parsing support for C++ attributes on using-declarations.
Tue, Nov 17, 7:48 AM
aaron.ballman added a comment to D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

Can you mention this change in the release notes? Also, should we document it explicitly in the Language Extensions documentation, or do you think this is too tiny of a feature to warrant that?

Tue, Nov 17, 7:47 AM
aaron.ballman accepted D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode.

LGTM, thank you!

Tue, Nov 17, 7:19 AM · Restricted Project
aaron.ballman accepted D90984: Update matchers to be traverse-aware.

LGTM, thank you!

Tue, Nov 17, 6:57 AM · Restricted Project
aaron.ballman added inline comments to D90984: Update matchers to be traverse-aware.
Tue, Nov 17, 6:50 AM · Restricted Project
aaron.ballman added a comment to D91311: Add new 'preferred_name' attribute..

I think that the fact we need to re declare everything shows how the ergonomics would be better if we could just add the attribute to the typedef. See for example how we're re-declaring a bunch of stuff in <iosfwd>. How bad of an idea is it to try putting the attribute on typedefs instead, and how strongly are you opposed to it? Because from a naive user perspective, having to redeclare the class with a closed set of preferred names feels awkward (IMO, of course).

Tue, Nov 17, 5:54 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions..
Tue, Nov 17, 5:31 AM · Restricted Project, Restricted Project
aaron.ballman accepted D91543: [clang-tidy] Improving bugprone-sizeof-expr check..

LGTM aside from a testing request.

Tue, Nov 17, 5:25 AM · Restricted Project, Restricted Project
aaron.ballman accepted D91592: [ASTMatchers] Fix typo for hasAnyOverloadedOperatorName.

LGTM! Do you need me to commit on your behalf? If so, is Keishi Hattori <shenhan@google.com> the correct attribution you'd like me to use?

Tue, Nov 17, 4:51 AM · Restricted Project

Mon, Nov 16

aaron.ballman added a comment to D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode.

Thank you for this, I think it's mostly looking good!

Mon, Nov 16, 12:04 PM · Restricted Project
aaron.ballman committed rGfa72ce346c5f: Another speculative fix for lldb related to ConstexprSpecKind (authored by aaron.ballman).
Another speculative fix for lldb related to ConstexprSpecKind
Mon, Nov 16, 11:41 AM
aaron.ballman committed rG1941d9651cc9: Speculatively fix the lldb build (authored by aaron.ballman).
Speculatively fix the lldb build
Mon, Nov 16, 11:24 AM
aaron.ballman accepted D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type..

LGTM, thank you for the fix!

Mon, Nov 16, 11:14 AM · Restricted Project, Restricted Project
aaron.ballman closed D91486: [NFC, Refactor] Convert ConstexprKind from Specifiers.h to a scoped enum.

Thank you for the patch, I've commit on your behalf in 41b65f166b51760f77d0f9e465b3858f46e101f0

Mon, Nov 16, 11:11 AM
aaron.ballman committed rG41b65f166b51: Convert ConstexprKind from Specifiers.h to a scoped enum; NFC (authored by tschuett).
Convert ConstexprKind from Specifiers.h to a scoped enum; NFC
Mon, Nov 16, 11:10 AM
aaron.ballman accepted D91486: [NFC, Refactor] Convert ConstexprKind from Specifiers.h to a scoped enum.

LGTM!

Mon, Nov 16, 11:08 AM
aaron.ballman added inline comments to D90984: Update matchers to be traverse-aware.
Mon, Nov 16, 9:01 AM · Restricted Project
aaron.ballman added a comment to D90188: Add support for attribute 'using_if_exists'.

Add support for C++11-style attributes on using-declarations.

Mon, Nov 16, 7:41 AM
aaron.ballman added inline comments to D91047: Add a call super attribute plugin example.
Mon, Nov 16, 6:55 AM · Restricted Project
aaron.ballman added inline comments to D91311: Add new 'preferred_name' attribute..
Mon, Nov 16, 6:38 AM · Restricted Project, Restricted Project
aaron.ballman committed rGf9e639efda4a: Fix bots that are running with assertions enabled; NFC. (authored by aaron.ballman).
Fix bots that are running with assertions enabled; NFC.
Mon, Nov 16, 6:23 AM
aaron.ballman committed rGf7c881b89eab: Adding some explicit casts to appease build bots; NFC (authored by aaron.ballman).
Adding some explicit casts to appease build bots; NFC
Mon, Nov 16, 6:14 AM
aaron.ballman committed rG7c6412e0ccf5: Convert TypeSpecifierSign from Specifiers.h to a scoped enum; NFC (authored by tschuett).
Convert TypeSpecifierSign from Specifiers.h to a scoped enum; NFC
Mon, Nov 16, 6:09 AM
aaron.ballman closed D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum.

rebased

Mon, Nov 16, 6:09 AM · Restricted Project
aaron.ballman added a comment to D91486: [NFC, Refactor] Convert ConstexprKind from Specifiers.h to a scoped enum.

There are some uses of static_cast<std::underlying_type_t<ConstexprSpecKind>>() that I'm not certain really need that much complexity given that I doubt we'd ever change the underlying type of the enumeration away from being an int (or something which promotes to int). Do you think using underlying_type_t adds some extra value I'm not seeing? We seem to go both ways in this patch and should be consistent -- my weak preference is to cast to int for brevity and to reduce the template instantiation work when compiling Clang, but I don't insist.

Mon, Nov 16, 6:06 AM
aaron.ballman added a comment to D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum.

LGTM! I'll land on your behalf momentarily.

Mon, Nov 16, 5:48 AM · Restricted Project
aaron.ballman accepted D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum.

LGTM! I'll land on your behalf momentarily.

Mon, Nov 16, 5:43 AM · Restricted Project
aaron.ballman closed D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny).

Yes. Thank you!

Mon, Nov 16, 5:32 AM · Restricted Project
aaron.ballman committed rGa6ac2b32fbab: Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum; NFC (authored by tschuett).
Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum; NFC
Mon, Nov 16, 5:29 AM
aaron.ballman added a comment to D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny).

I am happy, if you could commit this for me. I am still learning.

Mon, Nov 16, 5:26 AM · Restricted Project
aaron.ballman accepted D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny).

LGTM! Would you like me to commit this one on your behalf or would you like to request your own commit access (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)?

Mon, Nov 16, 5:20 AM · Restricted Project
aaron.ballman added a comment to D91409: [NFC, Refactor] Convert TypeSpecifierWidth from Specifiers.h to a scoped enum.

Committed here: https://github.com/llvm/llvm-project/commit/e6aa06545b123292be283af7c414daead23cf9ab .

Thanks Thorsten - please keep these patches coming :)

Mon, Nov 16, 5:13 AM

Fri, Nov 13

aaron.ballman committed rG66b876c014ad: Pass the source range when diagnosing an unknown attribute (authored by aaron.ballman).
Pass the source range when diagnosing an unknown attribute
Fri, Nov 13, 10:30 AM
aaron.ballman accepted D91409: [NFC, Refactor] Convert TypeSpecifierWidth from Specifiers.h to a scoped enum.

LGTM aside from a place where I think we can remove a cast.

Fri, Nov 13, 9:48 AM
aaron.ballman added inline comments to D91409: [NFC, Refactor] Convert TypeSpecifierWidth from Specifiers.h to a scoped enum.
Fri, Nov 13, 7:44 AM
aaron.ballman added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Should this be a NamingStyle option instead.
{key: readability-identifier-naming.ParameterShortSizeThreshold, value: 2}
WDYT?

I think that makes a lot of sense -- I can imagine wanting to enforce different identifier lengths depending on whether we're spelling a type name vs a local variable name, etc.

I considered this but thought the configuration and documentation would be quite cumbersome. We could provide a global setting (as already done) and allow refining it further by type if needed? For what it's worth I only need it for local variables, I imagine that would be the main use case.

Or should we simply add this threshold to every type of name, similar to how suffix, prefix and case style have been done?

Fri, Nov 13, 6:42 AM · Restricted Project, Restricted Project
aaron.ballman updated subscribers of D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check.

CC'ing @rsmith regarding the suggestion/question of also having a clang diagnostic for this.

Fri, Nov 13, 6:30 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman added inline comments to D91409: [NFC, Refactor] Convert TypeSpecifierWidth from Specifiers.h to a scoped enum.
Fri, Nov 13, 6:17 AM
aaron.ballman added inline comments to D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.
Fri, Nov 13, 6:02 AM · Restricted Project
aaron.ballman added inline comments to D91047: Add a call super attribute plugin example.
Fri, Nov 13, 5:55 AM · Restricted Project
aaron.ballman accepted D91311: Add new 'preferred_name' attribute..

The attribute parts LGTM, but I did have a question about the libc++ parts.

Fri, Nov 13, 5:15 AM · Restricted Project, Restricted Project

Thu, Nov 12

aaron.ballman added inline comments to D90984: Update matchers to be traverse-aware.
Thu, Nov 12, 1:12 PM · Restricted Project
aaron.ballman accepted D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

LGTM!

Thu, Nov 12, 10:33 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to rGd093401a2617: [NFC] Remove string parameter of annotation attribute from AST childs..
Thu, Nov 12, 10:13 AM
aaron.ballman committed rGb336826c1dd9: Non-implicit attribute creation requires a source range; NFC (authored by aaron.ballman).
Non-implicit attribute creation requires a source range; NFC
Thu, Nov 12, 10:11 AM
aaron.ballman added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Thu, Nov 12, 9:48 AM · Restricted Project, Restricted Project
aaron.ballman added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Should this be a NamingStyle option instead.
{key: readability-identifier-naming.ParameterShortSizeThreshold, value: 2}
WDYT?

Thu, Nov 12, 7:07 AM · Restricted Project, Restricted Project
aaron.ballman added a comment to D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type..
In D90042#2390203, @flx wrote:

Thanks for the suggestion, I had never hear of creduce!

Thu, Nov 12, 6:17 AM · Restricted Project, Restricted Project
aaron.ballman accepted D91184: [clang-tidy] Merge options inplace instead of copying.

LGTM!

Thu, Nov 12, 5:53 AM · Restricted Project
aaron.ballman added a comment to D91311: Add new 'preferred_name' attribute..

I really like this attribute, thank you for working on this!

Thu, Nov 12, 5:46 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Thu, Nov 12, 4:43 AM · Restricted Project, Restricted Project