Page MenuHomePhabricator

tianshilei1992 (Shilei Tian)
Ph.D. student in Stony Brook University

Projects

User does not belong to any projects.

User Details

User Since
Oct 12 2019, 11:44 AM (43 w, 23 h)

Recent Activity

Wed, Aug 5

tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Make mutex close to their protected variables

Wed, Aug 5, 2:32 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Use const_iterator

Wed, Aug 5, 1:38 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Updated the calculation of NumBuckets

Wed, Aug 5, 12:39 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Updated according to comments

Wed, Aug 5, 12:30 PM · Restricted Project

Tue, Aug 4

tianshilei1992 updated the summary of D85274: [OpenMP] Introduced a bump-like allocator into the target memory management.
Tue, Aug 4, 9:35 PM · Restricted Project
tianshilei1992 added reviewers for D85274: [OpenMP] Introduced a bump-like allocator into the target memory management: JonChesterfield, ye-luo.
Tue, Aug 4, 9:34 PM · Restricted Project
tianshilei1992 requested review of D85274: [OpenMP] Introduced a bump-like allocator into the target memory management.
Tue, Aug 4, 9:32 PM · Restricted Project

Mon, Aug 3

tianshilei1992 added inline comments to D81054: [OpenMP] Introduce target memory manager.
Mon, Aug 3, 6:44 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Updated based on comments

Mon, Aug 3, 6:42 PM · Restricted Project
tianshilei1992 added inline comments to D81054: [OpenMP] Introduce target memory manager.
Mon, Aug 3, 6:02 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Rebased before moving to allocator

Mon, Aug 3, 10:03 AM · Restricted Project

Sun, Aug 2

tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Added debug print

Sun, Aug 2, 6:10 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Took type alias into the class

Sun, Aug 2, 12:50 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Fixed a minor issue

Sun, Aug 2, 12:23 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Removed a wrong line of code

Sun, Aug 2, 11:04 AM · Restricted Project

Sat, Aug 1

tianshilei1992 added inline comments to D81054: [OpenMP] Introduce target memory manager.
Sat, Aug 1, 8:53 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Updated the function name in exports

Sat, Aug 1, 7:14 PM · Restricted Project
tianshilei1992 updated the summary of D81054: [OpenMP] Introduce target memory manager.
Sat, Aug 1, 7:12 PM · Restricted Project
tianshilei1992 added inline comments to D81054: [OpenMP] Introduce target memory manager.
Sat, Aug 1, 7:09 PM · Restricted Project
tianshilei1992 updated the diff for D81054: [OpenMP] Introduce target memory manager.

Refactored the whole patch. Corresponding tests will be added soon.

Sat, Aug 1, 7:04 PM · Restricted Project

Fri, Jul 31

tianshilei1992 committed rGf2400f024d32: [OpenMP] Fixed the issue that target memory deallocation might be called when… (authored by tianshilei1992).
[OpenMP] Fixed the issue that target memory deallocation might be called when…
Fri, Jul 31, 3:54 PM
tianshilei1992 closed D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used.
Fri, Jul 31, 3:54 PM · Restricted Project
tianshilei1992 updated the diff for D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used.

"clause" -> "modifier"

Fri, Jul 31, 11:37 AM · Restricted Project
tianshilei1992 updated the diff for D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used.

Updated the comments and arguments

Fri, Jul 31, 11:27 AM · Restricted Project

Thu, Jul 30

tianshilei1992 added inline comments to D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used.
Thu, Jul 30, 7:39 PM · Restricted Project
tianshilei1992 updated the diff for D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used.

Fixed issues in comments

Thu, Jul 30, 7:38 PM · Restricted Project
tianshilei1992 updated the diff for D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used.

Removed the tailing synchronization because it is no use any more

Thu, Jul 30, 7:24 PM · Restricted Project
tianshilei1992 added a comment to D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used.

Thanks for fixing the bug. It should be good for the moment.
When I think about the existence of recursive mapper, we may still have more sync than needed. I think recursion the whole targetDataBegin/targetDataEnd is convenient but sub-optimal choice.
Recursion should only be done on the map/mapper analysis. Just leave my thoughts here. It needs a discussion beyond this patch.

Thu, Jul 30, 7:23 PM · Restricted Project
tianshilei1992 added inline comments to D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used.
Thu, Jul 30, 7:07 PM · Restricted Project
tianshilei1992 committed rG0f1016562648: [OpenMP] Refactored the function `targetDataEnd` (authored by tianshilei1992).
[OpenMP] Refactored the function `targetDataEnd`
Thu, Jul 30, 6:39 PM
tianshilei1992 closed D84991: [OpenMP] Refactored the function `targetDataEnd`.
Thu, Jul 30, 6:39 PM · Restricted Project
tianshilei1992 updated the summary of D84991: [OpenMP] Refactored the function `targetDataEnd`.
Thu, Jul 30, 6:11 PM · Restricted Project
tianshilei1992 committed rG8218eee269c3: [OpenMP] Refactored the function `target` (authored by tianshilei1992).
[OpenMP] Refactored the function `target`
Thu, Jul 30, 6:06 PM
tianshilei1992 closed D84816: [OpenMP] Refactored the function `target`.
Thu, Jul 30, 6:06 PM · Restricted Project
tianshilei1992 added a reviewer for D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used: ye-luo.
Thu, Jul 30, 6:01 PM · Restricted Project
tianshilei1992 requested review of D84996: [OpenMP] Fixed the issue that target memory deallocation might be called when they're being used.
Thu, Jul 30, 6:00 PM · Restricted Project
tianshilei1992 added a reviewer for D84991: [OpenMP] Refactored the function `targetDataEnd`: ye-luo.
Thu, Jul 30, 4:52 PM · Restricted Project
tianshilei1992 requested review of D84991: [OpenMP] Refactored the function `targetDataEnd`.
Thu, Jul 30, 4:52 PM · Restricted Project
tianshilei1992 added inline comments to D84816: [OpenMP] Refactored the function `target`.
Thu, Jul 30, 3:41 PM · Restricted Project
tianshilei1992 updated the diff for D84816: [OpenMP] Refactored the function `target`.

Updated the doc of function processDataBefore

Thu, Jul 30, 3:41 PM · Restricted Project

Wed, Jul 29

tianshilei1992 updated the summary of D84816: [OpenMP] Refactored the function `target`.
Wed, Jul 29, 8:44 AM · Restricted Project

Tue, Jul 28

tianshilei1992 added a reviewer for D84816: [OpenMP] Refactored the function `target`: ye-luo.
Tue, Jul 28, 6:22 PM · Restricted Project
tianshilei1992 requested review of D84816: [OpenMP] Refactored the function `target`.
Tue, Jul 28, 6:21 PM · Restricted Project
tianshilei1992 committed rG30440924d48c: [OpenMP] Replaced mutex lock/unlock in `target` with `std::lock_guard` (authored by tianshilei1992).
[OpenMP] Replaced mutex lock/unlock in `target` with `std::lock_guard`
Tue, Jul 28, 5:31 PM
tianshilei1992 closed D84799: [OpenMP] Replaced mutex lock/unlock in `target` with `std::lock_guard`.
Tue, Jul 28, 5:31 PM · Restricted Project
tianshilei1992 committed rG3ce69d4d50a2: [NFC][OpenMP] Renamed all variable and function names in `target` to conform… (authored by tianshilei1992).
[NFC][OpenMP] Renamed all variable and function names in `target` to conform…
Tue, Jul 28, 5:11 PM
tianshilei1992 closed D84797: [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard.
Tue, Jul 28, 5:11 PM · Restricted Project
tianshilei1992 retitled D84797: [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard from [NFC][OpenMP] Renamed all variable and function names in `target` to conformwith LLVM code standard to [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard.
Tue, Jul 28, 2:32 PM · Restricted Project
tianshilei1992 updated the diff for D84799: [OpenMP] Replaced mutex lock/unlock in `target` with `std::lock_guard`.

Initialize TargetTable`

Tue, Jul 28, 2:15 PM · Restricted Project
tianshilei1992 added inline comments to D84797: [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard.
Tue, Jul 28, 2:10 PM · Restricted Project
tianshilei1992 updated the diff for D84797: [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard.

Renamed some function names

Tue, Jul 28, 2:08 PM · Restricted Project
tianshilei1992 abandoned D84778: [OpenMP] Refactor the `target` function.

Will resubmit in three patches.

Tue, Jul 28, 1:53 PM · Restricted Project
tianshilei1992 added a reviewer for D84799: [OpenMP] Replaced mutex lock/unlock in `target` with `std::lock_guard`: ye-luo.
Tue, Jul 28, 1:53 PM · Restricted Project
tianshilei1992 requested review of D84799: [OpenMP] Replaced mutex lock/unlock in `target` with `std::lock_guard`.
Tue, Jul 28, 1:52 PM · Restricted Project
tianshilei1992 retitled D84797: [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard from [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard to [NFC][OpenMP] Renamed all variable and function names in `target` to conformwith LLVM code standard.
Tue, Jul 28, 1:40 PM · Restricted Project
tianshilei1992 requested review of D84797: [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard.
Tue, Jul 28, 1:39 PM · Restricted Project
tianshilei1992 abandoned D84381: [OpenMP] Wait for kernel prior to memory deallocation.

Will get it fix in another patch.

Tue, Jul 28, 12:42 PM · Restricted Project
tianshilei1992 added a comment to D84778: [OpenMP] Refactor the `target` function.

I don't think it deserves three patches. The goal is to refactor the target function, and this patch just did this only thing. According to the bi-weekly meeting, the renaming could be with other related changes.

Tue, Jul 28, 11:56 AM · Restricted Project
tianshilei1992 added a reviewer for D84778: [OpenMP] Refactor the `target` function: ye-luo.
Tue, Jul 28, 11:00 AM · Restricted Project
tianshilei1992 requested review of D84778: [OpenMP] Refactor the `target` function.
Tue, Jul 28, 10:59 AM · Restricted Project

Mon, Jul 27

tianshilei1992 committed rG932316660179: [OpenMP] Add more pass-through functions in DeviceTy (authored by ye-luo).
[OpenMP] Add more pass-through functions in DeviceTy
Mon, Jul 27, 1:08 PM
tianshilei1992 closed D84487: [OpenMP] Add more pass-through functions in DeviceTy.
Mon, Jul 27, 1:08 PM · Restricted Project

Fri, Jul 24

tianshilei1992 accepted D84487: [OpenMP] Add more pass-through functions in DeviceTy.

LGTM

Fri, Jul 24, 7:58 PM · Restricted Project
tianshilei1992 added inline comments to D84487: [OpenMP] Add more pass-through functions in DeviceTy.
Fri, Jul 24, 2:53 PM · Restricted Project
tianshilei1992 added inline comments to D84487: [OpenMP] Add more pass-through functions in DeviceTy.
Fri, Jul 24, 1:10 PM · Restricted Project
tianshilei1992 added inline comments to D84487: [OpenMP] Add more pass-through functions in DeviceTy.
Fri, Jul 24, 10:51 AM · Restricted Project
tianshilei1992 added a comment to D80649: [OpenMP] Improve D2D memcpy to use more efficient driver API.

I'm looking through the tests in this directory and try to run them on a GPU.

Are those tests supposed to run on GPU?

Fri, Jul 24, 10:27 AM · Restricted Project
tianshilei1992 added inline comments to D84487: [OpenMP] Add more pass-through functions in DeviceTy.
Fri, Jul 24, 9:51 AM · Restricted Project
tianshilei1992 added inline comments to D84487: [OpenMP] Add more pass-through functions in DeviceTy.
Fri, Jul 24, 9:01 AM · Restricted Project
tianshilei1992 added inline comments to D84487: [OpenMP] Add more pass-through functions in DeviceTy.
Fri, Jul 24, 8:36 AM · Restricted Project

Wed, Jul 22

tianshilei1992 added a comment to D84381: [OpenMP] Wait for kernel prior to memory deallocation.
Wed, Jul 22, 9:52 PM · Restricted Project
tianshilei1992 updated the summary of D84381: [OpenMP] Wait for kernel prior to memory deallocation.
Wed, Jul 22, 9:18 PM · Restricted Project
tianshilei1992 requested review of D84381: [OpenMP] Wait for kernel prior to memory deallocation.
Wed, Jul 22, 9:17 PM · Restricted Project
tianshilei1992 updated the diff for D84381: [OpenMP] Wait for kernel prior to memory deallocation.

Fixed an issue that target may return before D2H is still in progress

Wed, Jul 22, 9:17 PM · Restricted Project
tianshilei1992 reopened D84381: [OpenMP] Wait for kernel prior to memory deallocation.

Does it mean the D2H will always run synchronously after this change?
Does it also mean that target_data_end should be split into data transfer and data free parts?

Wed, Jul 22, 8:04 PM · Restricted Project
tianshilei1992 committed rGc0185dc7df86: Revert "[OpenMP] Wait for kernel prior to memory deallocation" (authored by tianshilei1992).
Revert "[OpenMP] Wait for kernel prior to memory deallocation"
Wed, Jul 22, 8:04 PM
tianshilei1992 added a reverting change for rG9b2832c0897c: [OpenMP] Wait for kernel prior to memory deallocation: rGc0185dc7df86: Revert "[OpenMP] Wait for kernel prior to memory deallocation".
Wed, Jul 22, 8:04 PM
tianshilei1992 committed rG9b2832c0897c: [OpenMP] Wait for kernel prior to memory deallocation (authored by tianshilei1992).
[OpenMP] Wait for kernel prior to memory deallocation
Wed, Jul 22, 7:55 PM
tianshilei1992 closed D84381: [OpenMP] Wait for kernel prior to memory deallocation.
Wed, Jul 22, 7:55 PM · Restricted Project
tianshilei1992 updated the summary of D84381: [OpenMP] Wait for kernel prior to memory deallocation.
Wed, Jul 22, 7:40 PM · Restricted Project
tianshilei1992 updated the diff for D84381: [OpenMP] Wait for kernel prior to memory deallocation.

Updated based on comments

Wed, Jul 22, 7:39 PM · Restricted Project
Herald added a project to D84381: [OpenMP] Wait for kernel prior to memory deallocation: Restricted Project.
Wed, Jul 22, 7:27 PM · Restricted Project

Fri, Jul 17

tianshilei1992 added inline comments to D84062: [OpenMP] libomp cleanup: add check of input global tid parameter.
Fri, Jul 17, 1:13 PM · Restricted Project
tianshilei1992 added a comment to D84062: [OpenMP] libomp cleanup: add check of input global tid parameter.

@tianshilei1992 Does this impact the "unshakled thread" design?

Fri, Jul 17, 11:50 AM · Restricted Project

Jul 7 2020

tianshilei1992 added a comment to D83269: [OpenMP] Identify GPU kernels (aka. OpenMP target regions).

LGTM but I would like others to take a look.

Jul 7 2020, 7:44 AM · Restricted Project
tianshilei1992 committed rGc5348aecd772: [OpenMP] Use primary context in CUDA plugin (authored by ye-luo).
[OpenMP] Use primary context in CUDA plugin
Jul 7 2020, 7:15 AM
tianshilei1992 closed D82718: [OpenMP] Use primary context in CUDA plugin.
Jul 7 2020, 7:14 AM · Restricted Project

Jul 6 2020

tianshilei1992 added inline comments to D83271: [OpenMP] Replace function pointer uses in GPU state machine.
Jul 6 2020, 7:44 PM · Restricted Project

Jun 30 2020

tianshilei1992 added a comment to D82718: [OpenMP] Use primary context in CUDA plugin.

This patch drops the CU_CTX_SCHED_BLOCKING_SYNC property currently selected for the context. Is this intended? Should we add another function call to request this behavior for the primary context?

That is good point. We depend on the synchronous behavior in some cases in the RTL.

Are you sure this is the right flag you need?

Jun 30 2020, 7:32 PM · Restricted Project
tianshilei1992 added a comment to D82718: [OpenMP] Use primary context in CUDA plugin.

This patch drops the CU_CTX_SCHED_BLOCKING_SYNC property currently selected for the context. Is this intended? Should we add another function call to request this behavior for the primary context?

Jun 30 2020, 1:03 PM · Restricted Project

Jun 29 2020

tianshilei1992 added a comment to D81054: [OpenMP] Introduce target memory manager.

I happened to find that the huge overhead of cuMemFree might be due to the fact that it is called when the data is still being used. Will come back to this patch after I fix the issue and re-evaluate whether we still need this.

Jun 29 2020, 10:00 PM · Restricted Project
tianshilei1992 updated the summary of D77609: [OpenMP] Added the support for unshackled task in RTL.
Jun 29 2020, 10:00 PM · Restricted Project
tianshilei1992 updated the summary of D77609: [OpenMP] Added the support for unshackled task in RTL.
Jun 29 2020, 10:00 PM · Restricted Project
tianshilei1992 updated the summary of D77609: [OpenMP] Added the support for unshackled task in RTL.
Jun 29 2020, 10:00 PM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.
Jun 29 2020, 10:00 PM · Restricted Project
tianshilei1992 committed rG45bb073da8ef: [OpenMP] fix clang warning about printf format in CUDA plugin (authored by ye-luo).
[OpenMP] fix clang warning about printf format in CUDA plugin
Jun 29 2020, 7:47 PM
tianshilei1992 closed D82789: [OpenMP] fix clang warning about printf format in CUDA plugin.
Jun 29 2020, 7:47 PM · Restricted Project
tianshilei1992 accepted D82789: [OpenMP] fix clang warning about printf format in CUDA plugin.

LGTM

Jun 29 2020, 7:47 PM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.
Jun 29 2020, 2:12 PM · Restricted Project
tianshilei1992 updated the diff for D78075: [Clang][OpenMP] Added support for nowait target in CodeGen.

Will update failed tests later

Jun 29 2020, 1:36 PM · Restricted Project