Page MenuHomePhabricator

tianshilei1992 (Shilei Tian)
Ph.D. student in Stony Brook University

Projects

User does not belong to any projects.

User Details

User Since
Oct 12 2019, 11:44 AM (66 w, 8 h)

Recent Activity

Today

tianshilei1992 requested review of D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR.
Sat, Jan 16, 7:00 PM · Restricted Project
tianshilei1992 updated the diff for D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language.

Continue to add some forward declarations

Sat, Jan 16, 6:38 PM · Restricted Project
tianshilei1992 updated the diff for D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language.

Rebased and fixed some issues

Sat, Jan 16, 6:12 PM · Restricted Project
tianshilei1992 planned changes to D81989: [OpenMP] Introduce low level dependency process to target offloading.
Sat, Jan 16, 2:55 PM · Restricted Project
tianshilei1992 committed rGed939f853da1: [OpenMP] Added the support for hidden helper task in RTL (authored by tianshilei1992).
[OpenMP] Added the support for hidden helper task in RTL
Sat, Jan 16, 11:14 AM
tianshilei1992 closed D77609: [OpenMP] Added the support for hidden helper task in RTL.
Sat, Jan 16, 11:13 AM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for hidden helper task in RTL.

Refined test cases and rebased

Sat, Jan 16, 9:49 AM · Restricted Project

Yesterday

tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for hidden helper task in RTL.

Fixed a bug in __kmp_release_deps

Fri, Jan 15, 6:05 PM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for hidden helper task in RTL.

Rebase

Fri, Jan 15, 10:28 AM · Restricted Project

Thu, Jan 14

tianshilei1992 removed a reviewer for D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language: jdoerfert.
Thu, Jan 14, 8:15 PM · Restricted Project
tianshilei1992 requested review of D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language.
Thu, Jan 14, 8:15 PM · Restricted Project
tianshilei1992 committed rG547b032ccc8e: [OpenMP] Remove omptarget-nvptx from deps as it is no longer a valid target (authored by tianshilei1992).
[OpenMP] Remove omptarget-nvptx from deps as it is no longer a valid target
Thu, Jan 14, 4:16 PM
tianshilei1992 closed D94725: [OpenMP] Remove omptarget-nvptx from deps as it is no longer a valid target.
Thu, Jan 14, 4:16 PM · Restricted Project
tianshilei1992 added inline comments to D94728: [libomptarget][nvptx][nfc] Move target_impl functions out of header.
Thu, Jan 14, 4:11 PM · Restricted Project
tianshilei1992 accepted D94728: [libomptarget][nvptx][nfc] Move target_impl functions out of header.

LGTM

Thu, Jan 14, 4:09 PM · Restricted Project
tianshilei1992 requested review of D94725: [OpenMP] Remove omptarget-nvptx from deps as it is no longer a valid target.
Thu, Jan 14, 2:27 PM · Restricted Project
tianshilei1992 committed rG64e9e9aeee01: [OpenMP] Dropped unnecessary define when compiling deviceRTLs for NVPTX (authored by tianshilei1992).
[OpenMP] Dropped unnecessary define when compiling deviceRTLs for NVPTX
Thu, Jan 14, 10:55 AM
tianshilei1992 closed D94700: [OpenMP] Dropped unnecessary define when compiling deviceRTLs for NVPTX.
Thu, Jan 14, 10:55 AM · Restricted Project
tianshilei1992 committed rG763c1f993346: [OpenMP] Drop the static library libomptarget-nvptx (authored by tianshilei1992).
[OpenMP] Drop the static library libomptarget-nvptx
Thu, Jan 14, 10:34 AM
tianshilei1992 closed D94573: [OpenMP] Drop the static library libomptarget-nvptx.
Thu, Jan 14, 10:34 AM · Restricted Project
tianshilei1992 added a comment to D94700: [OpenMP] Dropped unnecessary define when compiling deviceRTLs for NVPTX.

Sure. But don't get too distracted here. All of the nvcc stuff will go away.

Thu, Jan 14, 10:17 AM · Restricted Project
tianshilei1992 requested review of D94700: [OpenMP] Dropped unnecessary define when compiling deviceRTLs for NVPTX.
Thu, Jan 14, 10:07 AM · Restricted Project
tianshilei1992 updated the diff for D94573: [OpenMP] Drop the static library libomptarget-nvptx.

Optimized some logics

Thu, Jan 14, 9:53 AM · Restricted Project
tianshilei1992 updated the diff for D94573: [OpenMP] Drop the static library libomptarget-nvptx.

Rebased the patch and removed unnecessary part

Thu, Jan 14, 9:39 AM · Restricted Project

Tue, Jan 12

tianshilei1992 requested review of D94573: [OpenMP] Drop the static library libomptarget-nvptx.
Tue, Jan 12, 6:27 PM · Restricted Project
tianshilei1992 accepted D94565: [libomptarget][nvptx] Include omp_data.cu in bitcode deviceRTL.

This makes steps for deprecating the static library in the near future.

Tue, Jan 12, 4:42 PM · Restricted Project
tianshilei1992 committed rG01f1273fe2f0: [OpenMP] Fixed a typo in openmp/CMakeLists.txt (authored by tianshilei1992).
[OpenMP] Fixed a typo in openmp/CMakeLists.txt
Tue, Jan 12, 2:01 PM
tianshilei1992 committed rG68ff52ffead2: [OpenMP] Fixed the link error that cannot find static data member (authored by tianshilei1992).
[OpenMP] Fixed the link error that cannot find static data member
Tue, Jan 12, 1:48 PM
tianshilei1992 closed D94541: [OpenMP] Fixed the link error that cannot find static data member.
Tue, Jan 12, 1:48 PM · Restricted Project
tianshilei1992 requested review of D94541: [OpenMP] Fixed the link error that cannot find static data member.
Tue, Jan 12, 11:59 AM · Restricted Project
tianshilei1992 committed rGbdd1ad5e5c57: [OpenMP] Fixed include directories for OpenMP when building OpenMP with… (authored by tianshilei1992).
[OpenMP] Fixed include directories for OpenMP when building OpenMP with…
Tue, Jan 12, 11:33 AM
tianshilei1992 closed D94534: [OpenMP] Fixed include directories for OpenMP when building OpenMP with LLVM_ENABLE_RUNTIMES.
Tue, Jan 12, 11:32 AM · Restricted Project
tianshilei1992 updated the summary of D94534: [OpenMP] Fixed include directories for OpenMP when building OpenMP with LLVM_ENABLE_RUNTIMES.
Tue, Jan 12, 11:03 AM · Restricted Project
tianshilei1992 requested review of D94534: [OpenMP] Fixed include directories for OpenMP when building OpenMP with LLVM_ENABLE_RUNTIMES.
Tue, Jan 12, 10:59 AM · Restricted Project

Mon, Jan 11

tianshilei1992 added a comment to D94170: [libomptarget][ve] Workaround for the libomptarget memory manager cleanup.

The issue has been fixed D94379 by moving the memory manager to plugin. I only enabled CUDA. If VE would like this feature, you can also do it in a similar way.

Mon, Jan 11, 6:35 PM · Restricted Project
tianshilei1992 committed rG0871d6d51648: [OpenMP] Move memory manager to plugin and make it a common interface (authored by tianshilei1992).
[OpenMP] Move memory manager to plugin and make it a common interface
Mon, Jan 11, 6:34 PM
tianshilei1992 closed D94379: [OpenMP] Move memory manager to plugin and make it a common interface.
Mon, Jan 11, 6:34 PM · Restricted Project
tianshilei1992 updated the diff for D94379: [OpenMP] Move memory manager to plugin and make it a common interface.

Fixed header guard

Mon, Jan 11, 5:17 PM · Restricted Project
tianshilei1992 updated the diff for D94379: [OpenMP] Move memory manager to plugin and make it a common interface.

Fixed some comments

Mon, Jan 11, 3:24 PM · Restricted Project
tianshilei1992 committed rGa81c68ae6be5: [OpenMP] Take elf_common.c as a interface library (authored by tianshilei1992).
[OpenMP] Take elf_common.c as a interface library
Mon, Jan 11, 2:35 PM
tianshilei1992 closed D94443: [OpenMP] Take elf_common.c as a interface library.
Mon, Jan 11, 2:34 PM · Restricted Project
tianshilei1992 added a comment to D94443: [OpenMP] Take elf_common.c as a interface library.

Yep, that looks like it'll work. The included source is a good thing to get rid of. Did you consider a header only library instead? There isn't much code in elf_common and we already know the headers work in the various rtl.cpp

Mon, Jan 11, 12:42 PM · Restricted Project
tianshilei1992 updated the diff for D94443: [OpenMP] Take elf_common.c as a interface library.

Fixed wrong comments

Mon, Jan 11, 12:38 PM · Restricted Project
tianshilei1992 requested review of D94443: [OpenMP] Take elf_common.c as a interface library.
Mon, Jan 11, 12:37 PM · Restricted Project

Sun, Jan 10

tianshilei1992 updated the diff for D94379: [OpenMP] Move memory manager to plugin and make it a common interface.

Still uses LIBOMPTARGET_MEMORY_MANAGER_THRESHOLD. A plugin can extends the function getSizeThresholdFromEnv in the future to make separate control.

Sun, Jan 10, 7:58 PM · Restricted Project
tianshilei1992 updated the diff for D94379: [OpenMP] Move memory manager to plugin and make it a common interface.

Use interface class to replace the template

Sun, Jan 10, 5:48 PM · Restricted Project
tianshilei1992 added inline comments to D94379: [OpenMP] Move memory manager to plugin and make it a common interface.
Sun, Jan 10, 5:22 PM · Restricted Project
tianshilei1992 abandoned D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.

Proposed to move the memory manager to plugin. See D94379 for more details.

Sun, Jan 10, 5:13 PM · Restricted Project
tianshilei1992 requested review of D94379: [OpenMP] Move memory manager to plugin and make it a common interface.
Sun, Jan 10, 5:12 PM · Restricted Project
tianshilei1992 abandoned D85274: [OpenMP] Introduced a bump-like allocator into the target memory management.
Sun, Jan 10, 4:36 PM · Restricted Project
tianshilei1992 committed rG7be3285248bf: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM (authored by tianshilei1992).
[OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM
Sun, Jan 10, 1:46 PM
tianshilei1992 closed D93738: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM.
Sun, Jan 10, 1:46 PM · Restricted Project, Restricted Project
tianshilei1992 committed rG894d2dbf5020: [LLVM] Added OpenMP to `LLVM_ALL_RUNTIMES` (authored by tianshilei1992).
[LLVM] Added OpenMP to `LLVM_ALL_RUNTIMES`
Sun, Jan 10, 1:46 PM
tianshilei1992 closed D94369: [LLVM] Added OpenMP to `LLVM_ALL_RUNTIMES`.
Sun, Jan 10, 1:46 PM · Restricted Project
tianshilei1992 updated the summary of D94369: [LLVM] Added OpenMP to `LLVM_ALL_RUNTIMES`.
Sun, Jan 10, 1:45 PM · Restricted Project
tianshilei1992 added a comment to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.

The complexity of this approach is very high relative to instantiating MemoryManagerTy in the cuda plugin, and optionally in any others that want to use it.

Sun, Jan 10, 1:29 PM · Restricted Project

Sat, Jan 9

tianshilei1992 requested review of D94369: [LLVM] Added OpenMP to `LLVM_ALL_RUNTIMES`.
Sat, Jan 9, 5:44 PM · Restricted Project
tianshilei1992 updated the summary of D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Sat, Jan 9, 12:58 PM · Restricted Project
tianshilei1992 updated the diff for D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.

Fixed the issue that target memory are not released when the plugin is destroyed

Sat, Jan 9, 12:55 PM · Restricted Project
tianshilei1992 added inline comments to D93738: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM.
Sat, Jan 9, 10:10 AM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D93738: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM.

Removed useless comment

Sat, Jan 9, 10:08 AM · Restricted Project, Restricted Project
tianshilei1992 committed rG175c336a1c5a: [OpenMP] Remove copy constructor of `RTLInfoTy` (authored by tianshilei1992).
[OpenMP] Remove copy constructor of `RTLInfoTy`
Sat, Jan 9, 10:01 AM
tianshilei1992 closed D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`.
Sat, Jan 9, 10:01 AM · Restricted Project
tianshilei1992 added a comment to D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`.

std::mutex is non-copyable and non-movable. Any struct containing it will be marked non-copyable and non-movable implicitly. Actually I'm not sure how compiler handles this struct because if I explicitly add RTLInfoTy(RTLInfoTy &&) = default and RTLInfoTy(const RTLInfoTy &) = delete, the compiler complains "no matching constructor for initialization of 'RTLInfoTy'". However, everything seems all good if I don't do anything...

Sat, Jan 9, 9:18 AM · Restricted Project
tianshilei1992 updated the summary of D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`.
Sat, Jan 9, 9:17 AM · Restricted Project
tianshilei1992 committed rG676c7cb0c0d4: [OpenMP] Added the support for cache line size 256 for A64FX (authored by tianshilei1992).
[OpenMP] Added the support for cache line size 256 for A64FX
Sat, Jan 9, 8:59 AM
tianshilei1992 closed D93169: [OpenMP] Added the support for cache line size 256 for A64FX.
Sat, Jan 9, 8:58 AM · Restricted Project
tianshilei1992 added a comment to D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`.

std::mutex is non-copyable and non-movable. Any struct containing it will be marked non-copyable and non-movable implicitly. Actually I'm not know how compiler handles this struct because if I explicitly add RTLInfoTy(RTLInfoTy &&) = default and RTLInfoTy(const RTLInfoTy &) = delete, the compiler complains "no matching constructor for initialization of 'RTLInfoTy'". However, everything seems all good if I don't do anything...

Sat, Jan 9, 8:57 AM · Restricted Project
tianshilei1992 updated the diff for D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`.

Dropped ValidPlugin &&

Sat, Jan 9, 8:47 AM · Restricted Project
tianshilei1992 updated the diff for D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`.

Added a missing plugin interface

Sat, Jan 9, 8:16 AM · Restricted Project
tianshilei1992 updated the diff for D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`.

Fixed the continue condition

Sat, Jan 9, 8:11 AM · Restricted Project
tianshilei1992 added inline comments to D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`.
Sat, Jan 9, 7:59 AM · Restricted Project
tianshilei1992 added a reviewer for D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`: JonChesterfield.
Sat, Jan 9, 7:55 AM · Restricted Project
tianshilei1992 requested review of D94361: [OpenMP] Remove copy constructor of `RTLInfoTy`.
Sat, Jan 9, 7:54 AM · Restricted Project
tianshilei1992 updated the diff for D93169: [OpenMP] Added the support for cache line size 256 for A64FX.

Used TRUE/FALSE instead of 0/1 for LIBOMP_DETECT_AARCH64_A64FX

Sat, Jan 9, 7:16 AM · Restricted Project

Thu, Jan 7

tianshilei1992 added a comment to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.

I suppose this is better, though it seems backwards to me. Plus we still leak memory with this design.

The memory will be eventually released by the driver if the process is terminated, right?

Thu, Jan 7, 7:39 PM · Restricted Project
tianshilei1992 added inline comments to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Thu, Jan 7, 7:38 PM · Restricted Project
tianshilei1992 added inline comments to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Thu, Jan 7, 6:44 PM · Restricted Project
tianshilei1992 added inline comments to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Thu, Jan 7, 6:00 PM · Restricted Project
tianshilei1992 added inline comments to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Thu, Jan 7, 4:45 PM · Restricted Project
tianshilei1992 updated the diff for D93169: [OpenMP] Added the support for cache line size 256 for A64FX.

Removed useless comment

Thu, Jan 7, 2:25 PM · Restricted Project
tianshilei1992 updated the diff for D93169: [OpenMP] Added the support for cache line size 256 for A64FX.

Optimized string match

Thu, Jan 7, 2:23 PM · Restricted Project
tianshilei1992 updated the diff for D93169: [OpenMP] Added the support for cache line size 256 for A64FX.

Parse /proc/cpuinfo with CMake directly

Thu, Jan 7, 2:07 PM · Restricted Project
tianshilei1992 committed rG63b42a051456: [NFC] clang/test/openMP/target_codegen.cpp should not depend on ssa name (authored by jeroen.dobbelaere).
[NFC] clang/test/openMP/target_codegen.cpp should not depend on ssa name
Thu, Jan 7, 1:39 PM
tianshilei1992 closed D93038: [NFC] clang/test/openMP/target_codegen.cpp should not depend on ssa name.
Thu, Jan 7, 1:39 PM · Restricted Project
tianshilei1992 updated the summary of D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Thu, Jan 7, 1:25 PM · Restricted Project
tianshilei1992 updated the diff for D93169: [OpenMP] Added the support for cache line size 256 for A64FX.

Updated to make OMPT work

Thu, Jan 7, 1:16 PM · Restricted Project
tianshilei1992 updated the diff for D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.

Updated the coding style

Thu, Jan 7, 12:57 PM · Restricted Project
tianshilei1992 added a comment to D81054: [OpenMP] Introduce target memory manager.

The fix is on Phab now. Please refer to D94256 for more details.

Thu, Jan 7, 12:51 PM · Restricted Project
tianshilei1992 added a comment to D94170: [libomptarget][ve] Workaround for the libomptarget memory manager cleanup.

I'm trying to fix the issue in D94256. Please take a review. :-)

Thu, Jan 7, 12:50 PM · Restricted Project
tianshilei1992 updated the summary of D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Thu, Jan 7, 12:49 PM · Restricted Project
tianshilei1992 added inline comments to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Thu, Jan 7, 12:48 PM · Restricted Project
tianshilei1992 updated the diff for D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.

Only check the validity in MemoryManagerTy::~MemoryManagerTy

Thu, Jan 7, 12:48 PM · Restricted Project
tianshilei1992 added a comment to D93169: [OpenMP] Added the support for cache line size 256 for A64FX.

Why is it necessary to write and compile a C program just to parse /proc/cpuinfo? Can this be done directly from CMake?

Thu, Jan 7, 12:43 PM · Restricted Project
tianshilei1992 requested review of D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Thu, Jan 7, 12:30 PM · Restricted Project
tianshilei1992 accepted D93038: [NFC] clang/test/openMP/target_codegen.cpp should not depend on ssa name.

Oh, that one “escaped” from being replaced. Thank you!

Thu, Jan 7, 7:28 AM · Restricted Project
tianshilei1992 added a comment to D81054: [OpenMP] Introduce target memory manager.

I’m going to put the issue on the top of my list.

Thu, Jan 7, 6:52 AM · Restricted Project

Wed, Jan 6

tianshilei1992 committed rG5acdae1f9a77: [OpenMP] Fixed an issue that wrong LLVM headers might be included when building… (authored by tianshilei1992).
[OpenMP] Fixed an issue that wrong LLVM headers might be included when building…
Wed, Jan 6, 2:08 PM
tianshilei1992 closed D93737: [OpenMP] Fixed an issue that wrong LLVM headers might be included when building libomptarget.
Wed, Jan 6, 2:07 PM · Restricted Project
tianshilei1992 committed rGe2a623094f6b: [OpenMP] Fixed the test environment when building along with LLVM (authored by tianshilei1992).
[OpenMP] Fixed the test environment when building along with LLVM
Wed, Jan 6, 2:06 PM