Page MenuHomePhabricator

tahonermann (Tom Honermann)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2015, 1:34 PM (300 w, 18 h)

Recent Activity

Wed, Dec 23

tahonermann added inline comments to D93031: Enable fexec-charset option .
Wed, Dec 23, 10:04 PM · Restricted Project, Restricted Project

Dec 16 2020

tahonermann added inline comments to D93031: Enable fexec-charset option .
Dec 16 2020, 8:55 AM · Restricted Project, Restricted Project
tahonermann added inline comments to D93031: Enable fexec-charset option .
Dec 16 2020, 8:35 AM · Restricted Project, Restricted Project

Dec 11 2020

tahonermann added inline comments to D93031: Enable fexec-charset option .
Dec 11 2020, 11:14 PM · Restricted Project, Restricted Project

Aug 7 2020

tahonermann accepted D82081: [z/OS] Add binary format goff and operating system zos to the triple.

I'm not a regular Clang reviewer. But for what it is worth, the changes look correct, clear, and appropriate from my lens (though I disagree slightly with some of the lint recommendations in the cases where the recommendation deviates from the surrounding code style). It looks like the concerns Hubert raised have been addressed.

Aug 7 2020, 9:29 AM · Restricted Project, Restricted Project

Jun 18 2020

tahonermann added a comment to D82081: [z/OS] Add binary format goff and operating system zos to the triple.

@Kai, I'm afraid I won't be able to assist much in reviews of most z/OS related patches (due to lack of time and lack of expertise with various parts of z/OS), but please do copy me on anything related to source and execution character set encoding or conversions, handling of universal-character-names, and encoding of output files (preprocessor output, dependency output, etc...)

Jun 18 2020, 8:41 AM · Restricted Project, Restricted Project

Jan 6 2020

tahonermann added inline comments to D72053: [RFC] Handling implementation limits.
Jan 6 2020, 8:06 AM · Restricted Project

Jul 2 2019

tahonermann added a comment to D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683).

See PR25683 (https://bugs.llvm.org/show_bug.cgi?id=25683) for more details. The patch posted here differs slightly from what is posted in the PR; getLocation() is called instead of getBeginLoc() since the latter may return a customized begin location.

Jul 2 2019, 10:24 AM · Restricted Project
tahonermann created D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683).
Jul 2 2019, 10:17 AM · Restricted Project

Sep 30 2016

tahonermann added a comment to D9127: PR23175 (fix) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.

For what it's worth, Coverity has been running with this patch in place for at least a year and a half now. I believe the only reason it wasn't committed was due to concerns with the test case in D9126. I haven't had time to address those concerns (and don't expect to anytime soon).

Sep 30 2016, 7:47 AM

Jul 6 2015

tahonermann added a comment to D9126: PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.

What's the state of this?

Jul 6 2015, 7:54 AM

Apr 22 2015

tahonermann added inline comments to D9126: PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.
Apr 22 2015, 12:07 PM
tahonermann added a comment to D9127: PR23175 (fix) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.

For future reference, it's our convention to include the code change and tests in the same review.

Apr 22 2015, 8:35 AM
tahonermann added inline comments to D9126: PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.
Apr 22 2015, 8:31 AM

Apr 21 2015

tahonermann added a comment to D9127: PR23175 (fix) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.

Please add a testcase (I'd imagine it's not too hard to craft one in this case?).

Apr 21 2015, 6:33 PM

Apr 20 2015

tahonermann added inline comments to D9127: PR23175 (fix) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.
Apr 20 2015, 2:07 PM
tahonermann added a comment to D9127: PR23175 (fix) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.

The formatting I intended in the summary did not take affect. Here is the referenced code as I intended it to display:

Apr 20 2015, 2:05 PM
tahonermann added a comment to D9126: PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.

A fix for this issue has been proposed in D9127.

Apr 20 2015, 2:03 PM
tahonermann retitled D9127: PR23175 (fix) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file from to PR23175 (fix) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.
Apr 20 2015, 2:02 PM
tahonermann retitled D9126: PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file from to PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file.
Apr 20 2015, 1:59 PM